From: Richard Henderson <richard.henderson@linaro.org>
To: "Alex Bennée" <alex.bennee@linaro.org>, qemu-devel@nongnu.org
Cc: Aleksandar Markovic <aleksandar.m.mail@gmail.com>
Subject: Re: Looking for issues/features for my first contribution
Date: Fri, 8 Nov 2019 14:05:53 +0100 [thread overview]
Message-ID: <afe76e1b-bad8-e531-b284-cedd5dd7d5cf@linaro.org> (raw)
In-Reply-To: <87a796hh1n.fsf@linaro.org>
On 11/8/19 10:08 AM, Alex Bennée wrote:
> Rajath Shashidhara <rajaths@cs.utexas.edu> writes:
>> [b] As per the datasheet, DS3231 has a built-in temperature sensor.
>> Temperature can be read from a dedicated register. There can be two
>> approaches to emulating this: (1) Return a constant temperature value
>> on every read (2) Throw a not-supported exception/warning. What is the
>> qemu convention for handling such features ?
>
> Don't throw an exception. You can at the minimum do a
> qemu_log_mask(LOG_UNIMP) to indicate the system is using currently
> unimplemented functionality. Alternatively wire-up a device property via
> QOM so the user can vary the reported temperature.
FWIW, Phillipe recently added a dummy temp sensor for raspi4:
git show 99c641370b52348b2893b2cd19624bf9a416ccfa
wherein he hard-codes 25C. Unless you're wanting to test the
guest kernel handling of overheating, this seems sufficient.
r~
next prev parent reply other threads:[~2019-11-08 13:06 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-06 23:50 Looking for issues/features for my first contribution Rajath Shashidhara
2019-11-07 10:37 ` Aleksandar Markovic
2019-11-07 13:33 ` Aleksandar Markovic
2019-11-07 18:49 ` Rajath Shashidhara
2019-11-08 2:39 ` Rajath Shashidhara
2019-11-08 9:08 ` Alex Bennée
2019-11-08 13:05 ` Richard Henderson [this message]
2019-11-08 19:31 ` Aleksandar Markovic
2019-11-09 16:01 ` Peter Maydell
2019-11-09 21:08 ` Aleksandar Markovic
2019-11-10 14:33 ` Peter Maydell
2019-11-08 19:36 ` Aleksandar Markovic
2019-11-08 21:54 ` BALATON Zoltan
2019-11-09 19:46 ` Aleksandar Markovic
2019-11-09 21:33 ` Rajath Shashidhara
2019-11-09 23:55 ` Aleksandar Markovic
2019-11-07 11:18 ` Alex Bennée
2019-11-07 13:54 ` Stefan Hajnoczi
2019-11-07 18:51 ` Rajath Shashidhara
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=afe76e1b-bad8-e531-b284-cedd5dd7d5cf@linaro.org \
--to=richard.henderson@linaro.org \
--cc=aleksandar.m.mail@gmail.com \
--cc=alex.bennee@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).