* [PATCH for 6.2 v2 0/5] Fix Q35 ACPI PCI Hot-plug I/O issues
@ 2021-11-10 21:11 Igor Mammedov
2021-11-10 21:11 ` [PATCH for 6.2 v2 1/5] pcie: rename 'native-hotplug' to 'x-native-hotplug' Igor Mammedov
` (5 more replies)
0 siblings, 6 replies; 24+ messages in thread
From: Igor Mammedov @ 2021-11-10 21:11 UTC (permalink / raw)
To: qemu-devel; +Cc: ani, mapfelba, jusual, kraxel, mst
Changelog:
v2:
* simplify [1/5] and rename property to x-native-hotplug (CC stable)
* [4/5]
- rename function parameter to reflect actual action
- drop local 'hotplug' variable and opencode statement
* test with SeaBIOS/OVMF and Linux guest,
Windows also works with SeaBIOS, can't install it in EFI
mode on current master (it's stuck when formatting disk/or
copying files to hdd).
Attempt [1] to fix I/O allocation with the 'reserve-io' hint on each
pcie-root-port resulted in regression [2-3]. This patchset aims to fix
it by addressing the root cause of the problem - the disabled PCIe
Slot HPC bit.
[1] 'hw/pcie-root-port: Fix hotplug for PCI devices requiring IO'
[2] https://gitlab.com/qemu-project/qemu/-/issues/641
[3] https://bugzilla.redhat.com/show_bug.cgi?id=2006409
CC: kraxel@redhat.com
Igor Mammedov (1):
pcie: rename 'native-hotplug' to 'x-native-hotplug'
Julia Suvorova (4):
hw/acpi/ich9: Add compat prop to keep HPC bit set for 6.1 machine type
bios-tables-test: Allow changes in DSDT ACPI tables
hw/i386/acpi-build: Deny control on PCIe Native Hot-plug in _OSC
bios-tables-test: Update golden binaries
include/hw/acpi/ich9.h | 1 +
hw/acpi/ich9.c | 18 ++++++++++++++++++
hw/i386/acpi-build.c | 12 ++++++++----
hw/i386/pc.c | 2 ++
hw/i386/pc_q35.c | 9 +++++++--
hw/pci/pcie_port.c | 2 +-
tests/data/acpi/q35/DSDT | Bin 8289 -> 8289 bytes
tests/data/acpi/q35/DSDT.acpihmat | Bin 9614 -> 9614 bytes
tests/data/acpi/q35/DSDT.bridge | Bin 11003 -> 11003 bytes
tests/data/acpi/q35/DSDT.cphp | Bin 8753 -> 8753 bytes
tests/data/acpi/q35/DSDT.dimmpxm | Bin 9943 -> 9943 bytes
tests/data/acpi/q35/DSDT.dmar | Bin 0 -> 8289 bytes
tests/data/acpi/q35/DSDT.ipmibt | Bin 8364 -> 8364 bytes
tests/data/acpi/q35/DSDT.ivrs | Bin 8306 -> 8306 bytes
tests/data/acpi/q35/DSDT.memhp | Bin 9648 -> 9648 bytes
tests/data/acpi/q35/DSDT.mmio64 | Bin 9419 -> 9419 bytes
tests/data/acpi/q35/DSDT.multi-bridge | Bin 8583 -> 8583 bytes
tests/data/acpi/q35/DSDT.nohpet | Bin 8147 -> 8147 bytes
tests/data/acpi/q35/DSDT.nosmm | Bin 0 -> 8289 bytes
tests/data/acpi/q35/DSDT.numamem | Bin 8295 -> 8295 bytes
tests/data/acpi/q35/DSDT.smm-compat | Bin 0 -> 8289 bytes
tests/data/acpi/q35/DSDT.smm-compat-nosmm | Bin 0 -> 8289 bytes
tests/data/acpi/q35/DSDT.tis.tpm12 | Bin 8894 -> 8894 bytes
tests/data/acpi/q35/DSDT.tis.tpm2 | Bin 8894 -> 8894 bytes
tests/data/acpi/q35/DSDT.xapic | Bin 35652 -> 35652 bytes
25 files changed, 37 insertions(+), 7 deletions(-)
create mode 100644 tests/data/acpi/q35/DSDT.dmar
create mode 100644 tests/data/acpi/q35/DSDT.nosmm
create mode 100644 tests/data/acpi/q35/DSDT.smm-compat
create mode 100644 tests/data/acpi/q35/DSDT.smm-compat-nosmm
--
2.27.0
^ permalink raw reply [flat|nested] 24+ messages in thread
* [PATCH for 6.2 v2 1/5] pcie: rename 'native-hotplug' to 'x-native-hotplug'
2021-11-10 21:11 [PATCH for 6.2 v2 0/5] Fix Q35 ACPI PCI Hot-plug I/O issues Igor Mammedov
@ 2021-11-10 21:11 ` Igor Mammedov
2021-11-11 3:25 ` Ani Sinha
2021-11-10 21:11 ` [PATCH for 6.2 v2 2/5] hw/acpi/ich9: Add compat prop to keep HPC bit set for 6.1 machine type Igor Mammedov
` (4 subsequent siblings)
5 siblings, 1 reply; 24+ messages in thread
From: Igor Mammedov @ 2021-11-10 21:11 UTC (permalink / raw)
To: qemu-devel; +Cc: mapfelba, mst, jusual, qemu-stable, kraxel, ani
Mark property as experimental/internal adding 'x-' prefix.
Property was introduced in 6.1 and it should have provided
ability to turn on native PCIE hotplug on port even when
ACPI PCI hotplug is in use is user explicitly sets property
on CLI. However that never worked since slot is wired to
ACPI hotplug controller.
Another non-intended usecase: disable native hotplug on slot
when APCI based hotplug is disabled, which works but slot has
'hotplug' property for this taks.
It should be relatively safe to rename it to experimental
as no users should exist for it and given that the property
is broken we don't really want to leave it around for much
longer lest users start using it.
Signed-off-by: Igor Mammedov <imammedo@redhat.com>
---
CC: qemu-stable@nongnu.org
---
hw/i386/pc_q35.c | 2 +-
hw/pci/pcie_port.c | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/hw/i386/pc_q35.c b/hw/i386/pc_q35.c
index 797e09500b..fc34b905ee 100644
--- a/hw/i386/pc_q35.c
+++ b/hw/i386/pc_q35.c
@@ -243,7 +243,7 @@ static void pc_q35_init(MachineState *machine)
NULL);
if (acpi_pcihp) {
- object_register_sugar_prop(TYPE_PCIE_SLOT, "native-hotplug",
+ object_register_sugar_prop(TYPE_PCIE_SLOT, "x-native-hotplug",
"false", true);
}
diff --git a/hw/pci/pcie_port.c b/hw/pci/pcie_port.c
index da850e8dde..e95c1e5519 100644
--- a/hw/pci/pcie_port.c
+++ b/hw/pci/pcie_port.c
@@ -148,7 +148,7 @@ static Property pcie_slot_props[] = {
DEFINE_PROP_UINT8("chassis", PCIESlot, chassis, 0),
DEFINE_PROP_UINT16("slot", PCIESlot, slot, 0),
DEFINE_PROP_BOOL("hotplug", PCIESlot, hotplug, true),
- DEFINE_PROP_BOOL("native-hotplug", PCIESlot, native_hotplug, true),
+ DEFINE_PROP_BOOL("x-native-hotplug", PCIESlot, native_hotplug, true),
DEFINE_PROP_END_OF_LIST()
};
--
2.27.0
^ permalink raw reply related [flat|nested] 24+ messages in thread
* [PATCH for 6.2 v2 2/5] hw/acpi/ich9: Add compat prop to keep HPC bit set for 6.1 machine type
2021-11-10 21:11 [PATCH for 6.2 v2 0/5] Fix Q35 ACPI PCI Hot-plug I/O issues Igor Mammedov
2021-11-10 21:11 ` [PATCH for 6.2 v2 1/5] pcie: rename 'native-hotplug' to 'x-native-hotplug' Igor Mammedov
@ 2021-11-10 21:11 ` Igor Mammedov
2021-11-15 10:05 ` Ani Sinha
2021-11-10 21:11 ` [PATCH for 6.2 v2 3/5] bios-tables-test: Allow changes in DSDT ACPI tables Igor Mammedov
` (3 subsequent siblings)
5 siblings, 1 reply; 24+ messages in thread
From: Igor Mammedov @ 2021-11-10 21:11 UTC (permalink / raw)
To: qemu-devel; +Cc: ani, mapfelba, jusual, kraxel, mst
From: Julia Suvorova <jusual@redhat.com>
To solve issues [1-2] the Hot Plug Capable bit in PCIe Slots will be
turned on, while the switch to ACPI Hot-plug will be done in the
DSDT table.
Introducing 'x-keep-native-hpc' property disables the HPC bit only
in 6.1 and as a result keeps the forced 'reserve-io' on
pcie-root-ports in 6.1 too.
[1] https://gitlab.com/qemu-project/qemu/-/issues/641
[2] https://bugzilla.redhat.com/show_bug.cgi?id=2006409
Signed-off-by: Julia Suvorova <jusual@redhat.com>
Signed-off-by: Igor Mammedov <imammedo@redhat.com>
---
v2:
* s/native-hpc-bit/x-native-hotplug/ to fix conflict
---
include/hw/acpi/ich9.h | 1 +
hw/acpi/ich9.c | 18 ++++++++++++++++++
hw/i386/pc.c | 2 ++
hw/i386/pc_q35.c | 7 ++++++-
4 files changed, 27 insertions(+), 1 deletion(-)
diff --git a/include/hw/acpi/ich9.h b/include/hw/acpi/ich9.h
index f04f1791bd..7ca92843c6 100644
--- a/include/hw/acpi/ich9.h
+++ b/include/hw/acpi/ich9.h
@@ -56,6 +56,7 @@ typedef struct ICH9LPCPMRegs {
AcpiCpuHotplug gpe_cpu;
CPUHotplugState cpuhp_state;
+ bool keep_pci_slot_hpc;
bool use_acpi_hotplug_bridge;
AcpiPciHpState acpi_pci_hotplug;
MemHotplugState acpi_memory_hotplug;
diff --git a/hw/acpi/ich9.c b/hw/acpi/ich9.c
index 1ee2ba2c50..ebe08ed831 100644
--- a/hw/acpi/ich9.c
+++ b/hw/acpi/ich9.c
@@ -419,6 +419,20 @@ static void ich9_pm_set_acpi_pci_hotplug(Object *obj, bool value, Error **errp)
s->pm.use_acpi_hotplug_bridge = value;
}
+static bool ich9_pm_get_keep_pci_slot_hpc(Object *obj, Error **errp)
+{
+ ICH9LPCState *s = ICH9_LPC_DEVICE(obj);
+
+ return s->pm.keep_pci_slot_hpc;
+}
+
+static void ich9_pm_set_keep_pci_slot_hpc(Object *obj, bool value, Error **errp)
+{
+ ICH9LPCState *s = ICH9_LPC_DEVICE(obj);
+
+ s->pm.keep_pci_slot_hpc = value;
+}
+
void ich9_pm_add_properties(Object *obj, ICH9LPCPMRegs *pm)
{
static const uint32_t gpe0_len = ICH9_PMIO_GPE0_LEN;
@@ -428,6 +442,7 @@ void ich9_pm_add_properties(Object *obj, ICH9LPCPMRegs *pm)
pm->disable_s4 = 0;
pm->s4_val = 2;
pm->use_acpi_hotplug_bridge = true;
+ pm->keep_pci_slot_hpc = true;
object_property_add_uint32_ptr(obj, ACPI_PM_PROP_PM_IO_BASE,
&pm->pm_io_base, OBJ_PROP_FLAG_READ);
@@ -454,6 +469,9 @@ void ich9_pm_add_properties(Object *obj, ICH9LPCPMRegs *pm)
object_property_add_bool(obj, ACPI_PM_PROP_ACPI_PCIHP_BRIDGE,
ich9_pm_get_acpi_pci_hotplug,
ich9_pm_set_acpi_pci_hotplug);
+ object_property_add_bool(obj, "x-keep-pci-slot-hpc",
+ ich9_pm_get_keep_pci_slot_hpc,
+ ich9_pm_set_keep_pci_slot_hpc);
}
void ich9_pm_device_pre_plug_cb(HotplugHandler *hotplug_dev, DeviceState *dev,
diff --git a/hw/i386/pc.c b/hw/i386/pc.c
index 2592a82148..a2ef40ecbc 100644
--- a/hw/i386/pc.c
+++ b/hw/i386/pc.c
@@ -98,6 +98,7 @@ GlobalProperty pc_compat_6_1[] = {
{ TYPE_X86_CPU, "hv-version-id-build", "0x1bbc" },
{ TYPE_X86_CPU, "hv-version-id-major", "0x0006" },
{ TYPE_X86_CPU, "hv-version-id-minor", "0x0001" },
+ { "ICH9-LPC", "x-keep-pci-slot-hpc", "false" },
};
const size_t pc_compat_6_1_len = G_N_ELEMENTS(pc_compat_6_1);
@@ -107,6 +108,7 @@ GlobalProperty pc_compat_6_0[] = {
{ "qemu64" "-" TYPE_X86_CPU, "stepping", "3" },
{ TYPE_X86_CPU, "x-vendor-cpuid-only", "off" },
{ "ICH9-LPC", ACPI_PM_PROP_ACPI_PCIHP_BRIDGE, "off" },
+ { "ICH9-LPC", "x-keep-pci-slot-hpc", "true" },
};
const size_t pc_compat_6_0_len = G_N_ELEMENTS(pc_compat_6_0);
diff --git a/hw/i386/pc_q35.c b/hw/i386/pc_q35.c
index fc34b905ee..e1e100316d 100644
--- a/hw/i386/pc_q35.c
+++ b/hw/i386/pc_q35.c
@@ -137,6 +137,7 @@ static void pc_q35_init(MachineState *machine)
DriveInfo *hd[MAX_SATA_PORTS];
MachineClass *mc = MACHINE_GET_CLASS(machine);
bool acpi_pcihp;
+ bool keep_pci_slot_hpc;
/* Check whether RAM fits below 4G (leaving 1/2 GByte for IO memory
* and 256 Mbytes for PCI Express Enhanced Configuration Access Mapping
@@ -242,7 +243,11 @@ static void pc_q35_init(MachineState *machine)
ACPI_PM_PROP_ACPI_PCIHP_BRIDGE,
NULL);
- if (acpi_pcihp) {
+ keep_pci_slot_hpc = object_property_get_bool(OBJECT(lpc),
+ "x-keep-pci-slot-hpc",
+ NULL);
+
+ if (!keep_pci_slot_hpc && acpi_pcihp) {
object_register_sugar_prop(TYPE_PCIE_SLOT, "x-native-hotplug",
"false", true);
}
--
2.27.0
^ permalink raw reply related [flat|nested] 24+ messages in thread
* [PATCH for 6.2 v2 3/5] bios-tables-test: Allow changes in DSDT ACPI tables
2021-11-10 21:11 [PATCH for 6.2 v2 0/5] Fix Q35 ACPI PCI Hot-plug I/O issues Igor Mammedov
2021-11-10 21:11 ` [PATCH for 6.2 v2 1/5] pcie: rename 'native-hotplug' to 'x-native-hotplug' Igor Mammedov
2021-11-10 21:11 ` [PATCH for 6.2 v2 2/5] hw/acpi/ich9: Add compat prop to keep HPC bit set for 6.1 machine type Igor Mammedov
@ 2021-11-10 21:11 ` Igor Mammedov
2021-11-11 5:55 ` Ani Sinha
2021-11-10 21:11 ` [PATCH for 6.2 v2 4/5] hw/i386/acpi-build: Deny control on PCIe Native Hot-plug in _OSC Igor Mammedov
` (2 subsequent siblings)
5 siblings, 1 reply; 24+ messages in thread
From: Igor Mammedov @ 2021-11-10 21:11 UTC (permalink / raw)
To: qemu-devel; +Cc: ani, mapfelba, jusual, kraxel, mst
From: Julia Suvorova <jusual@redhat.com>
Prepare for changing the _OSC method in q35 DSDT.
Signed-off-by: Julia Suvorova <jusual@redhat.com>
Signed-off-by: Igor Mammedov <imammedo@redhat.com>
---
tests/qtest/bios-tables-test-allowed-diff.h | 16 ++++++++++++++++
1 file changed, 16 insertions(+)
diff --git a/tests/qtest/bios-tables-test-allowed-diff.h b/tests/qtest/bios-tables-test-allowed-diff.h
index dfb8523c8b..48e5634d4b 100644
--- a/tests/qtest/bios-tables-test-allowed-diff.h
+++ b/tests/qtest/bios-tables-test-allowed-diff.h
@@ -1 +1,17 @@
/* List of comma-separated changed AML files to ignore */
+"tests/data/acpi/q35/DSDT",
+"tests/data/acpi/q35/DSDT.tis",
+"tests/data/acpi/q35/DSDT.bridge",
+"tests/data/acpi/q35/DSDT.mmio64",
+"tests/data/acpi/q35/DSDT.ipmibt",
+"tests/data/acpi/q35/DSDT.cphp",
+"tests/data/acpi/q35/DSDT.memhp",
+"tests/data/acpi/q35/DSDT.acpihmat",
+"tests/data/acpi/q35/DSDT.numamem",
+"tests/data/acpi/q35/DSDT.dimmpxm",
+"tests/data/acpi/q35/DSDT.nohpet",
+"tests/data/acpi/q35/DSDT.tis.tpm2",
+"tests/data/acpi/q35/DSDT.tis.tpm12",
+"tests/data/acpi/q35/DSDT.multi-bridge",
+"tests/data/acpi/q35/DSDT.ivrs",
+"tests/data/acpi/q35/DSDT.xapic",
--
2.27.0
^ permalink raw reply related [flat|nested] 24+ messages in thread
* [PATCH for 6.2 v2 4/5] hw/i386/acpi-build: Deny control on PCIe Native Hot-plug in _OSC
2021-11-10 21:11 [PATCH for 6.2 v2 0/5] Fix Q35 ACPI PCI Hot-plug I/O issues Igor Mammedov
` (2 preceding siblings ...)
2021-11-10 21:11 ` [PATCH for 6.2 v2 3/5] bios-tables-test: Allow changes in DSDT ACPI tables Igor Mammedov
@ 2021-11-10 21:11 ` Igor Mammedov
2021-11-11 5:49 ` Ani Sinha
2021-11-10 21:11 ` [PATCH for 6.2 v2 5/5] bios-tables-test: Update golden binaries Igor Mammedov
2021-11-12 9:47 ` [PATCH for 6.2 v2 0/5] Fix Q35 ACPI PCI Hot-plug I/O issues Michael S. Tsirkin
5 siblings, 1 reply; 24+ messages in thread
From: Igor Mammedov @ 2021-11-10 21:11 UTC (permalink / raw)
To: qemu-devel; +Cc: ani, mapfelba, jusual, kraxel, mst
From: Julia Suvorova <jusual@redhat.com>
There are two ways to enable ACPI PCI Hot-plug:
* Disable the Hot-plug Capable bit on PCIe slots.
This was the first approach which led to regression [1-2], as
I/O space for a port is allocated only when it is hot-pluggable,
which is determined by HPC bit.
* Leave the HPC bit on and disable PCIe Native Hot-plug in _OSC
method.
This removes the (future) ability of hot-plugging switches with PCIe
Native hotplug since ACPI PCI Hot-plug only works with cold-plugged
bridges. If the user wants to explicitely use this feature, they can
disable ACPI PCI Hot-plug with:
--global ICH9-LPC.acpi-pci-hotplug-with-bridge-support=off
Change the bit in _OSC method so that the OS selects ACPI PCI Hot-plug
instead of PCIe Native.
[1] https://gitlab.com/qemu-project/qemu/-/issues/641
[2] https://bugzilla.redhat.com/show_bug.cgi?id=2006409
Signed-off-by: Julia Suvorova <jusual@redhat.com>
Signed-off-by: Igor Mammedov <imammedo@redhat.com>
---
v2:
- (mst)
* drop local hotplug var and opencode it
* rename acpi_pcihp parameter to enable_native_pcie_hotplug
to reflect what it actually does
tested:
with hotplugging nic into 1 root port with seabios/ovmf/Fedora34
Windows tested only with seabios (using exiting images)
(installer fails to install regardless on bios)
---
hw/i386/acpi-build.c | 12 ++++++++----
1 file changed, 8 insertions(+), 4 deletions(-)
diff --git a/hw/i386/acpi-build.c b/hw/i386/acpi-build.c
index a3ad6abd33..a99c6e4fe3 100644
--- a/hw/i386/acpi-build.c
+++ b/hw/i386/acpi-build.c
@@ -1337,7 +1337,7 @@ static void build_x86_acpi_pci_hotplug(Aml *table, uint64_t pcihp_addr)
aml_append(table, scope);
}
-static Aml *build_q35_osc_method(void)
+static Aml *build_q35_osc_method(bool enable_native_pcie_hotplug)
{
Aml *if_ctx;
Aml *if_ctx2;
@@ -1359,8 +1359,10 @@ static Aml *build_q35_osc_method(void)
/*
* Always allow native PME, AER (no dependencies)
* Allow SHPC (PCI bridges can have SHPC controller)
+ * Disable PCIe Native Hot-plug if ACPI PCI Hot-plug is enabled.
*/
- aml_append(if_ctx, aml_and(a_ctrl, aml_int(0x1F), a_ctrl));
+ aml_append(if_ctx, aml_and(a_ctrl,
+ aml_int(0x1E | (enable_native_pcie_hotplug ? 0x1 : 0x0)), a_ctrl));
if_ctx2 = aml_if(aml_lnot(aml_equal(aml_arg(1), aml_int(1))));
/* Unknown revision */
@@ -1449,7 +1451,7 @@ build_dsdt(GArray *table_data, BIOSLinker *linker,
aml_append(dev, aml_name_decl("_CID", aml_eisaid("PNP0A03")));
aml_append(dev, aml_name_decl("_ADR", aml_int(0)));
aml_append(dev, aml_name_decl("_UID", aml_int(pcmc->pci_root_uid)));
- aml_append(dev, build_q35_osc_method());
+ aml_append(dev, build_q35_osc_method(!pm->pcihp_bridge_en));
aml_append(sb_scope, dev);
if (mcfg_valid) {
aml_append(sb_scope, build_q35_dram_controller(&mcfg));
@@ -1565,7 +1567,9 @@ build_dsdt(GArray *table_data, BIOSLinker *linker,
if (pci_bus_is_express(bus)) {
aml_append(dev, aml_name_decl("_HID", aml_eisaid("PNP0A08")));
aml_append(dev, aml_name_decl("_CID", aml_eisaid("PNP0A03")));
- aml_append(dev, build_q35_osc_method());
+
+ /* Expander bridges do not have ACPI PCI Hot-plug enabled */
+ aml_append(dev, build_q35_osc_method(true));
} else {
aml_append(dev, aml_name_decl("_HID", aml_eisaid("PNP0A03")));
}
--
2.27.0
^ permalink raw reply related [flat|nested] 24+ messages in thread
* [PATCH for 6.2 v2 5/5] bios-tables-test: Update golden binaries
2021-11-10 21:11 [PATCH for 6.2 v2 0/5] Fix Q35 ACPI PCI Hot-plug I/O issues Igor Mammedov
` (3 preceding siblings ...)
2021-11-10 21:11 ` [PATCH for 6.2 v2 4/5] hw/i386/acpi-build: Deny control on PCIe Native Hot-plug in _OSC Igor Mammedov
@ 2021-11-10 21:11 ` Igor Mammedov
2021-11-11 5:51 ` Ani Sinha
2021-11-11 8:34 ` Michael S. Tsirkin
2021-11-12 9:47 ` [PATCH for 6.2 v2 0/5] Fix Q35 ACPI PCI Hot-plug I/O issues Michael S. Tsirkin
5 siblings, 2 replies; 24+ messages in thread
From: Igor Mammedov @ 2021-11-10 21:11 UTC (permalink / raw)
To: qemu-devel; +Cc: ani, mapfelba, jusual, kraxel, mst
From: Julia Suvorova <jusual@redhat.com>
The changes are the result of
'hw/i386/acpi-build: Deny control on PCIe Native Hot-Plug in _OSC'
and listed here:
Method (_OSC, 4, NotSerialized) // _OSC: Operating System Capabilities
{
CreateDWordField (Arg3, Zero, CDW1)
If ((Arg0 == ToUUID ("33db4d5b-1ff7-401c-9657-7441c03dd766") /* PCI Host Bridge Device */))
{
CreateDWordField (Arg3, 0x04, CDW2)
CreateDWordField (Arg3, 0x08, CDW3)
Local0 = CDW3 /* \_SB_.PCI0._OSC.CDW3 */
- Local0 &= 0x1F
+ Local0 &= 0x1E
Signed-off-by: Julia Suvorova <jusual@redhat.com>
Signed-off-by: Igor Mammedov <imammedo@redhat.com>
---
tests/qtest/bios-tables-test-allowed-diff.h | 16 ----------------
tests/data/acpi/q35/DSDT | Bin 8289 -> 8289 bytes
tests/data/acpi/q35/DSDT.acpihmat | Bin 9614 -> 9614 bytes
tests/data/acpi/q35/DSDT.bridge | Bin 11003 -> 11003 bytes
tests/data/acpi/q35/DSDT.cphp | Bin 8753 -> 8753 bytes
tests/data/acpi/q35/DSDT.dimmpxm | Bin 9943 -> 9943 bytes
tests/data/acpi/q35/DSDT.dmar | Bin 0 -> 8289 bytes
tests/data/acpi/q35/DSDT.ipmibt | Bin 8364 -> 8364 bytes
tests/data/acpi/q35/DSDT.ivrs | Bin 8306 -> 8306 bytes
tests/data/acpi/q35/DSDT.memhp | Bin 9648 -> 9648 bytes
tests/data/acpi/q35/DSDT.mmio64 | Bin 9419 -> 9419 bytes
tests/data/acpi/q35/DSDT.multi-bridge | Bin 8583 -> 8583 bytes
tests/data/acpi/q35/DSDT.nohpet | Bin 8147 -> 8147 bytes
tests/data/acpi/q35/DSDT.nosmm | Bin 0 -> 8289 bytes
tests/data/acpi/q35/DSDT.numamem | Bin 8295 -> 8295 bytes
tests/data/acpi/q35/DSDT.smm-compat | Bin 0 -> 8289 bytes
tests/data/acpi/q35/DSDT.smm-compat-nosmm | Bin 0 -> 8289 bytes
tests/data/acpi/q35/DSDT.tis.tpm12 | Bin 8894 -> 8894 bytes
tests/data/acpi/q35/DSDT.tis.tpm2 | Bin 8894 -> 8894 bytes
tests/data/acpi/q35/DSDT.xapic | Bin 35652 -> 35652 bytes
20 files changed, 16 deletions(-)
create mode 100644 tests/data/acpi/q35/DSDT.dmar
create mode 100644 tests/data/acpi/q35/DSDT.nosmm
create mode 100644 tests/data/acpi/q35/DSDT.smm-compat
create mode 100644 tests/data/acpi/q35/DSDT.smm-compat-nosmm
diff --git a/tests/qtest/bios-tables-test-allowed-diff.h b/tests/qtest/bios-tables-test-allowed-diff.h
index 48e5634d4b..dfb8523c8b 100644
--- a/tests/qtest/bios-tables-test-allowed-diff.h
+++ b/tests/qtest/bios-tables-test-allowed-diff.h
@@ -1,17 +1 @@
/* List of comma-separated changed AML files to ignore */
-"tests/data/acpi/q35/DSDT",
-"tests/data/acpi/q35/DSDT.tis",
-"tests/data/acpi/q35/DSDT.bridge",
-"tests/data/acpi/q35/DSDT.mmio64",
-"tests/data/acpi/q35/DSDT.ipmibt",
-"tests/data/acpi/q35/DSDT.cphp",
-"tests/data/acpi/q35/DSDT.memhp",
-"tests/data/acpi/q35/DSDT.acpihmat",
-"tests/data/acpi/q35/DSDT.numamem",
-"tests/data/acpi/q35/DSDT.dimmpxm",
-"tests/data/acpi/q35/DSDT.nohpet",
-"tests/data/acpi/q35/DSDT.tis.tpm2",
-"tests/data/acpi/q35/DSDT.tis.tpm12",
-"tests/data/acpi/q35/DSDT.multi-bridge",
-"tests/data/acpi/q35/DSDT.ivrs",
-"tests/data/acpi/q35/DSDT.xapic",
diff --git a/tests/data/acpi/q35/DSDT b/tests/data/acpi/q35/DSDT
index 281fc82c03b2562d2e6b7caec0d817b034a47138..c1965f6051ef2af81dd8412abe169d87845bb033 100644
GIT binary patch
delta 24
gcmaFp@X&$FCD<h-QGtPh@z+GID~xg*?>ET<0BnZ{w*UYD
delta 24
gcmaFp@X&$FCD<h-QGtPh@#jRYD~$3R?>ET<0BnK?w*UYD
diff --git a/tests/data/acpi/q35/DSDT.acpihmat b/tests/data/acpi/q35/DSDT.acpihmat
index 8c1e05a11a328ec1cc6f86e36e52c28f41f9744e..f24d4874bff8d327a165ed7c36de507aea114edd 100644
GIT binary patch
delta 24
fcmeD4?(^ny33dtTQ)OUa+&+=(3ZvY{`|DKzU@Hhn
delta 24
fcmeD4?(^ny33dtTQ)OUa+%}Qx3ZwkS`|DKzU?vDi
diff --git a/tests/data/acpi/q35/DSDT.bridge b/tests/data/acpi/q35/DSDT.bridge
index 6f1464b6c712d7f33cb4b891b7ce76fe228f44c9..424d51bd1cb39ea73501ef7d0044ee52cec5bdac 100644
GIT binary patch
delta 24
gcmewz`a6`%CD<k8w-y5fBg;gtD~xg*@5^Wb0CWThXaE2J
delta 24
gcmewz`a6`%CD<k8w-y5fBlASAD~$3R@5^Wb0CWEcXaE2J
diff --git a/tests/data/acpi/q35/DSDT.cphp b/tests/data/acpi/q35/DSDT.cphp
index f8337ff5191a37a47dcf7c09a6c39c4e704a15bf..f1275606f68eeba54bfb11e63d818420385a62b9 100644
GIT binary patch
delta 24
fcmdn!veAXhCD<jzP>F$oF>WH)6-K#@_k$DxTWtqt
delta 24
fcmdn!veAXhCD<jzP>F$oF?J%?6-N1u_k$DxTWAMo
diff --git a/tests/data/acpi/q35/DSDT.dimmpxm b/tests/data/acpi/q35/DSDT.dimmpxm
index fe5820d93d057ef09a001662369b15afbc5b87e2..76e451e829ec4c245315f7eed8731aa1be45a747 100644
GIT binary patch
delta 24
gcmccad)=4ICD<k8x*7umqsK(9D~xg*@BdH*0B$o00{{R3
delta 24
gcmccad)=4ICD<k8x*7umqx(dzD~$3R@BdH*0B$Y`0{{R3
diff --git a/tests/data/acpi/q35/DSDT.dmar b/tests/data/acpi/q35/DSDT.dmar
new file mode 100644
index 0000000000000000000000000000000000000000..c1965f6051ef2af81dd8412abe169d87845bb033
GIT binary patch
literal 8289
zcmb7JOKcm*8J^`!tL0K!Qk3OaY{E(UN|8{0Bx#EVC3pF<L~6yQ;si9nrRB7;og#}k
z2J%1vSpgEqhoT9aphr4TfZp0uuQkw1d-JUUdg`H<T#F(`4`IK5h9l3A6cF>U+JE-@
z{(rvNo&8obUf^~51;&j3l{egaP$<9Ry9N9V#u%N`U#F3{%(}Z?xz;n%v4qjRo#y8_
zl+FB)z4BJg`29}!c^JO+QE2odcI6A_vn&1RgFE3BMxa|)BFmx^r?Sus%DwKMYx!=Y
zX!hz2&n`W%Ota^Tv$)wSd2MF)wi+JGug~>10ylB@26MejtHV}uu#;V~oNn`<=e{|8
z@)w_9daHE*=l}TS-5XW{fV22(;_tbL4&i&Dbt)V>pAN1W?-QM0TOBTaI^dT@n?qNk
zkXr89qKQ(i?%(L{z38<|F7IQ;Z}~;HxQc$c?I3&FI{DEGV>S&A{r)r>js7A|nez^F
znx;@$G3$P%BUKvEMyk5Ib-&YOHe(OIO|wMzwnOpK%axW_@Y`Omkbk}xbV@9umN25G
z{=1>&ghTt2LC6MSdNkT+!-Y=<efGP)&HnY@<UZTC7DeB(*20JL)Rza}vIJx3&G(+A
z-q3h=_l`G$QjZTY%AZD8{6>2-W`&mRtSvqlmq0>w_s*}CJ%GhMilg`Fl`M1ATCN!(
z3z=cmjH~P_{+@}UT6gcM=El|mYjH_qnO5=)jZk;*?7H7smAMn*ej6Iru`)H|?fBbq
z(>$}wGoN)gng^UD&=}1boQLs;ab})zIOpkh$35sxdVK$Q>WD?mFwZapL)6MX8lzp`
z4LU~pzHOPfH59lQyR8BaUZJ}iR4!r`{LQv-<I)tk<znR`E|go%wvm1yXcV~R)>gCN
zH@sI0U8B72uCe^nzFWB%>pn@*XcX-bB6`QT#wbVk`_#P8^3RmOnT4WU5go!YHq3h|
z-wT=x!}amhc<{pC{~cU-xB1D+*Ue*pb(<08di~eo@X5h-Has@CX2mcA-sjJejmLJx
z_Oo&0HXYc#mErQ>x-}Q&k};NH{V2TCXKcT3`VF_r@^%k@jcA7==Qpn!^sqSY*L))T
z?T(*YySbZ7C-8K#_10R2iE{(zRhF}<-HIWo$smrP&T^Rq`hl4waN~$r04|7YoCl~3
ziHZCi8{<r1#}P3lG{!g+P|ie1O!S6h<D4mb5NE`c(70d%%9#j>DXU;!2`tZ(;7kck
z2&U{jLRDu{)0yN<2~7&7>^wqMXG+tV;!Fum={garI_ET<bDGXMT_-|Sr>W^QHJzre
z6QQaTZy;r)=QW-4x=w_uPD|5iX*w-kCqh+cTGN@<bf$Hk2vwbU7b^GD)^yssPK2t?
zjHWZA>CEUl5vn>DG@T2Y&IMg3LRIIYrgKr#xv1+zsOoeyosOo{(RCtJb!Ii4SxskF
z*NITonbUOUG@UtJCqh-{lBRP>)48PUM5yY_YdZ6q&b+P@p{jFP)48naT-J3WRCONF
zbRN-k9?^9oRCVG@0#BcO53OiAS9F~SRh>sQokumDM|GVDRh`E;vowAa9^=gN_+@uY
zFx^KXF}*SNxW+uLF^}s^gevod#yp`hPv}g9D)XeqJgG5H>P&<x^9halgvNYAXChRY
zr#Mr(%qh;4@Ay-KDPP<Oi7D^kX|3jIt>$UHCPGougn^b61FZ!Ol;&n?;2ed=28sY>
zMG!|Ii^4z!j$4w!h$Z`Hps0Wz7$`z14F)Q((m)j`8K{6B7$`#YMjEKVjw7n68mNFC
z7$`#Yh+|=(0y~bz8ab2<R6u2@>V$!cw44b8RiI>`2&F5Mfg+STVW0xbnJ`cVN(L&R
zye1haLa7r5DzKah16818paRO7WS|J8P8g`bawZH^fs%m=C})y^B9!+N1}d<e2?JH2
zWS|1dnPi{{rA`>Az;Y%GRDqI#3Mglifg+STVW0xbnJ`cVN(L&RoJj_XQ0jz%3M^;B
zKouw%sDN@N87M-j69y`<oCyO}pk$x|%9&)K2&GOKsK9b23{-)VfeI*Rl7S+WI$@v!
z%b74x1xf}gpqxnticso=feI{V!ax-$8K{7ACK)I~sS^e&u$&14RiI>`0?L_Wpa`W-
z7^uK<CJa=8l7R{+XOe*;lsaLc0?U~&Pz6c`DxjQ628vMXgn<eyXTm@gC>f}LawZul
zLa7r5DzKah16818paRO7WS|J8P8g`bawZH^fs%m=C})y^B9uB|paRR8Fi-_b1}dPO
zNd}5g>V$y`EN8+%6(|{~fN~}oC_<?d28u{AP(-SMB2*0&p<<v469%d<$v_n*8K}a9
zfhtTGsKO)zRhVR;3KIsZFkzqylMGa0l7T8r7^uR8fhtTgP=!ebsxV=oh~(Xcfg-{k
z<AX^CiV(L!hQyR(3j;+Y#})>PNRBNTC_*{5WS|JKRCK%t3uQxl!2em@r+-NArRYzo
zd;6!)#p%CPTGgQS4#RJ6mf*OXWjeTY@Jxoam(2>DSLslrL*2|TH8!ytFr0tS+TFn-
z%ly8T&Yy2=y6t%Y+QsaGmHs%z=J`s{JM1pCSxFol(R(}ABBL{OqK&1O^*MYal;o0!
zjpZ6z3^LK}AbZ4G`gnoO$Kh@a?{9`TF;*|~i+mkupSpnFl=9i0*9h4AbZ+hPmPJ~R
zVnDcU9<TI*c3|Ay8TWz8Q~S7jd7?TNPrh^YvQoXwtC!I~wR$-}yL!31*Cg#?DGkeg
zW9?S#G0MA2d6$=WC(65rly}GFy$SIa7PP*zdQU0u@$%k8dGC<&-ne{avV7t(%2$-~
z6<)qFQND6W`O3I_b+UZ&G0In!@>O2GI#IrQNcrlxd~LFP>M_dKl=3xRzBW<5c1Zc!
zxO{!G{M=)duPf#2ynKD4eEpE}b(Bxgt8B8oBg)H{2R<t>-NpK?-j+}CDUUxiugB>o
zr?HjQ)8SiVDxGMXnQm%c=Ja&<0GUcB+GeJknrB!7rg<iX;j3gSooJhxZff4-^>p}D
znMx<xW~Q5(2g`aoe7{Vk6KyloO+D8~^mO>BnMx<xW~Q5ZPFM7F_|ln5C))IM&WT6s
z*?WsYvy814Y^&IDtob_|FNxiWx^?-{iof5k1oA1hFgf8(8Q0$`)Zch3di~a~3U9u4
z^Nm|?ZohVubq&{FUmHKI8Oy2}U)f*ThK*HycoHq0e`Q;C_x2AcD6xX;S6YVKXa$Db
zZoX__0lY|us=?x}+w`!=o+D)34Jzvez`atZfVJjEt6@fr8u8ShyUg{VL!y(JlIu5$
z#nmEpLu?!+^I5l3eKj_;20QFSw^%G*%hyv_y)VsopS=8BLT+u4P!d4P?~~0a7O`-6
zd@y-|Bt+ICmffeWtgr2d`DT)2JzgPWG8Hn+%%86waRawy9wNhZTa`<>*eGJ#k#Y44
zFE_YqMC@v0gc0k1v2Oo%5E`FtqbZEGCrfg{la073!<Ek_TX9>qzZ}jF`ql_#zKmvF
zA3ilTa&+IL?K{-RKD*UNukO7tyf6jhPX=z^wiS=21_l?wyR}Uli<N}fS)_zl*f!mA
zXxr|t&K5V73;nruW%e*P=iQB<V;?fiv!9l!{209G+KjP@tk`5LL9b6XVwh+4uKU4@
z^h{&^<A>>i=i1z-ryDb%S?XldmdUW%K;NPH1#Fsj(j<oMT)Un>fyq<zE4@nbEE~^w
znn?6aIU5PO#3%lEP8FYL`JVv0%4i@Cb_B(amD1q5E#6ZN;WU@UOy!$Ge6RFk+WPaI
z42xlj0KX9(uw(eperOve+6}yu@cRarAKC|T275@1{fBR|^6T_jJQ~qwG5ump+kQ2%
zjrB)yh5bRhav%G$--;{uU%LAYwrt1QL>rA3?SWz7v>(N^N$DmqIAWKY?*NxDIO5ev
z?aDh*Y+R;=gY$P{Ayr5je5dnb!ms;nF~qcu{3r<qX~z3?I@f*szHJ=EHsud5qkM3#
zmrErK^d0BtdpR><#Vjo1A-X_UNQv{aN4KH7_iXi&D||1rS!r(JF*-|VZ04#xc9Kq#
z-r`OxahY%JRTFd<yL;)NSQLB47?K|a#TP|@J7zGLaj@z!Y+B;vtUNi#Pg3-Vu>S)s
Cro3tZ
literal 0
HcmV?d00001
diff --git a/tests/data/acpi/q35/DSDT.ipmibt b/tests/data/acpi/q35/DSDT.ipmibt
index 631741065860fd5036aa303904dabd1d2839f9c6..6ad2411d0ec95f204cfc64b430c537bce09c35bd 100644
GIT binary patch
delta 24
gcmZ4ExW<voCD<iojRFG$quxZWD~xg*@1K<i0AMf(82|tP
delta 24
gcmZ4ExW<voCD<iojRFG$qwYkmD~$3R@1K<i0AMQ!82|tP
diff --git a/tests/data/acpi/q35/DSDT.ivrs b/tests/data/acpi/q35/DSDT.ivrs
index b0eafe90e5832935557ec5e6802c0147c88f379c..cad26e3f0c27a40a33101155a5282ed9bcb1d441 100644
GIT binary patch
delta 24
gcmez5@X3M8CD<jTNP&TYan?kxD~xg*?@yKo0BrUMn*aa+
delta 24
gcmez5@X3M8CD<jTNP&TYappv>D~$3R?@yKo0BrFHn*aa+
diff --git a/tests/data/acpi/q35/DSDT.memhp b/tests/data/acpi/q35/DSDT.memhp
index 9bc11518fc57687ca789dc70793b48b29a0d74ed..4e9cb3dc6896bb79ccac0fe342a404549f6610e8 100644
GIT binary patch
delta 24
gcmdnsy}_HyCD<iogDL|9<C}?GR~Y3s-oK~<0BV~F1poj5
delta 24
gcmdnsy}_HyCD<iogDL|9<LilBR~Y3t-oK~<0BV*A1poj5
diff --git a/tests/data/acpi/q35/DSDT.mmio64 b/tests/data/acpi/q35/DSDT.mmio64
index 713288a12ef2b70a20b4e8836c036ba4db3a57a8..eb5a1c7171c02d153487bfcecfb7019b7c1bf406 100644
GIT binary patch
delta 24
gcmX@@dD@f9CD<k8v<d?Q<BEw~R~Y3s-hZPE0B$h}CjbBd
delta 24
gcmX@@dD@f9CD<k8v<d?Q<MN4IR~Y3t-hZPE0B$S^CjbBd
diff --git a/tests/data/acpi/q35/DSDT.multi-bridge b/tests/data/acpi/q35/DSDT.multi-bridge
index a24c713d22102a1a1583b5c902edffe1694e5cfe..45808eb03b78d07ebbe853f674abfed589d35e26 100644
GIT binary patch
delta 24
fcmZp7Zg=K#33dr-S7cyd?3>7Sg;8$f{S^uTTRaEr
delta 24
fcmZp7Zg=K#33dr-S7cyd?48JUg;9Rv{S^uTTQ>*m
diff --git a/tests/data/acpi/q35/DSDT.nohpet b/tests/data/acpi/q35/DSDT.nohpet
index e8202e6ddfbe96071f32f1ec05758f650569943e..83d1aa00ac5686df479673fb0d7830f946e25dea 100644
GIT binary patch
delta 24
gcmca?f7zbPCD<k8vOEI=<B^G6R~Y3s-v1&80B=4CMF0Q*
delta 24
gcmca?f7zbPCD<k8vOEI=<Kc;1R~Y3t-v1&80B<=7MF0Q*
diff --git a/tests/data/acpi/q35/DSDT.nosmm b/tests/data/acpi/q35/DSDT.nosmm
new file mode 100644
index 0000000000000000000000000000000000000000..c1965f6051ef2af81dd8412abe169d87845bb033
GIT binary patch
literal 8289
zcmb7JOKcm*8J^`!tL0K!Qk3OaY{E(UN|8{0Bx#EVC3pF<L~6yQ;si9nrRB7;og#}k
z2J%1vSpgEqhoT9aphr4TfZp0uuQkw1d-JUUdg`H<T#F(`4`IK5h9l3A6cF>U+JE-@
z{(rvNo&8obUf^~51;&j3l{egaP$<9Ry9N9V#u%N`U#F3{%(}Z?xz;n%v4qjRo#y8_
zl+FB)z4BJg`29}!c^JO+QE2odcI6A_vn&1RgFE3BMxa|)BFmx^r?Sus%DwKMYx!=Y
zX!hz2&n`W%Ota^Tv$)wSd2MF)wi+JGug~>10ylB@26MejtHV}uu#;V~oNn`<=e{|8
z@)w_9daHE*=l}TS-5XW{fV22(;_tbL4&i&Dbt)V>pAN1W?-QM0TOBTaI^dT@n?qNk
zkXr89qKQ(i?%(L{z38<|F7IQ;Z}~;HxQc$c?I3&FI{DEGV>S&A{r)r>js7A|nez^F
znx;@$G3$P%BUKvEMyk5Ib-&YOHe(OIO|wMzwnOpK%axW_@Y`Omkbk}xbV@9umN25G
z{=1>&ghTt2LC6MSdNkT+!-Y=<efGP)&HnY@<UZTC7DeB(*20JL)Rza}vIJx3&G(+A
z-q3h=_l`G$QjZTY%AZD8{6>2-W`&mRtSvqlmq0>w_s*}CJ%GhMilg`Fl`M1ATCN!(
z3z=cmjH~P_{+@}UT6gcM=El|mYjH_qnO5=)jZk;*?7H7smAMn*ej6Iru`)H|?fBbq
z(>$}wGoN)gng^UD&=}1boQLs;ab})zIOpkh$35sxdVK$Q>WD?mFwZapL)6MX8lzp`
z4LU~pzHOPfH59lQyR8BaUZJ}iR4!r`{LQv-<I)tk<znR`E|go%wvm1yXcV~R)>gCN
zH@sI0U8B72uCe^nzFWB%>pn@*XcX-bB6`QT#wbVk`_#P8^3RmOnT4WU5go!YHq3h|
z-wT=x!}amhc<{pC{~cU-xB1D+*Ue*pb(<08di~eo@X5h-Has@CX2mcA-sjJejmLJx
z_Oo&0HXYc#mErQ>x-}Q&k};NH{V2TCXKcT3`VF_r@^%k@jcA7==Qpn!^sqSY*L))T
z?T(*YySbZ7C-8K#_10R2iE{(zRhF}<-HIWo$smrP&T^Rq`hl4waN~$r04|7YoCl~3
ziHZCi8{<r1#}P3lG{!g+P|ie1O!S6h<D4mb5NE`c(70d%%9#j>DXU;!2`tZ(;7kck
z2&U{jLRDu{)0yN<2~7&7>^wqMXG+tV;!Fum={garI_ET<bDGXMT_-|Sr>W^QHJzre
z6QQaTZy;r)=QW-4x=w_uPD|5iX*w-kCqh+cTGN@<bf$Hk2vwbU7b^GD)^yssPK2t?
zjHWZA>CEUl5vn>DG@T2Y&IMg3LRIIYrgKr#xv1+zsOoeyosOo{(RCtJb!Ii4SxskF
z*NITonbUOUG@UtJCqh-{lBRP>)48PUM5yY_YdZ6q&b+P@p{jFP)48naT-J3WRCONF
zbRN-k9?^9oRCVG@0#BcO53OiAS9F~SRh>sQokumDM|GVDRh`E;vowAa9^=gN_+@uY
zFx^KXF}*SNxW+uLF^}s^gevod#yp`hPv}g9D)XeqJgG5H>P&<x^9halgvNYAXChRY
zr#Mr(%qh;4@Ay-KDPP<Oi7D^kX|3jIt>$UHCPGougn^b61FZ!Ol;&n?;2ed=28sY>
zMG!|Ii^4z!j$4w!h$Z`Hps0Wz7$`z14F)Q((m)j`8K{6B7$`#YMjEKVjw7n68mNFC
z7$`#Yh+|=(0y~bz8ab2<R6u2@>V$!cw44b8RiI>`2&F5Mfg+STVW0xbnJ`cVN(L&R
zye1haLa7r5DzKah16818paRO7WS|J8P8g`bawZH^fs%m=C})y^B9!+N1}d<e2?JH2
zWS|1dnPi{{rA`>Az;Y%GRDqI#3Mglifg+STVW0xbnJ`cVN(L&RoJj_XQ0jz%3M^;B
zKouw%sDN@N87M-j69y`<oCyO}pk$x|%9&)K2&GOKsK9b23{-)VfeI*Rl7S+WI$@v!
z%b74x1xf}gpqxnticso=feI{V!ax-$8K{7ACK)I~sS^e&u$&14RiI>`0?L_Wpa`W-
z7^uK<CJa=8l7R{+XOe*;lsaLc0?U~&Pz6c`DxjQ628vMXgn<eyXTm@gC>f}LawZul
zLa7r5DzKah16818paRO7WS|J8P8g`bawZH^fs%m=C})y^B9uB|paRR8Fi-_b1}dPO
zNd}5g>V$y`EN8+%6(|{~fN~}oC_<?d28u{AP(-SMB2*0&p<<v469%d<$v_n*8K}a9
zfhtTGsKO)zRhVR;3KIsZFkzqylMGa0l7T8r7^uR8fhtTgP=!ebsxV=oh~(Xcfg-{k
z<AX^CiV(L!hQyR(3j;+Y#})>PNRBNTC_*{5WS|JKRCK%t3uQxl!2em@r+-NArRYzo
zd;6!)#p%CPTGgQS4#RJ6mf*OXWjeTY@Jxoam(2>DSLslrL*2|TH8!ytFr0tS+TFn-
z%ly8T&Yy2=y6t%Y+QsaGmHs%z=J`s{JM1pCSxFol(R(}ABBL{OqK&1O^*MYal;o0!
zjpZ6z3^LK}AbZ4G`gnoO$Kh@a?{9`TF;*|~i+mkupSpnFl=9i0*9h4AbZ+hPmPJ~R
zVnDcU9<TI*c3|Ay8TWz8Q~S7jd7?TNPrh^YvQoXwtC!I~wR$-}yL!31*Cg#?DGkeg
zW9?S#G0MA2d6$=WC(65rly}GFy$SIa7PP*zdQU0u@$%k8dGC<&-ne{avV7t(%2$-~
z6<)qFQND6W`O3I_b+UZ&G0In!@>O2GI#IrQNcrlxd~LFP>M_dKl=3xRzBW<5c1Zc!
zxO{!G{M=)duPf#2ynKD4eEpE}b(Bxgt8B8oBg)H{2R<t>-NpK?-j+}CDUUxiugB>o
zr?HjQ)8SiVDxGMXnQm%c=Ja&<0GUcB+GeJknrB!7rg<iX;j3gSooJhxZff4-^>p}D
znMx<xW~Q5(2g`aoe7{Vk6KyloO+D8~^mO>BnMx<xW~Q5ZPFM7F_|ln5C))IM&WT6s
z*?WsYvy814Y^&IDtob_|FNxiWx^?-{iof5k1oA1hFgf8(8Q0$`)Zch3di~a~3U9u4
z^Nm|?ZohVubq&{FUmHKI8Oy2}U)f*ThK*HycoHq0e`Q;C_x2AcD6xX;S6YVKXa$Db
zZoX__0lY|us=?x}+w`!=o+D)34Jzvez`atZfVJjEt6@fr8u8ShyUg{VL!y(JlIu5$
z#nmEpLu?!+^I5l3eKj_;20QFSw^%G*%hyv_y)VsopS=8BLT+u4P!d4P?~~0a7O`-6
zd@y-|Bt+ICmffeWtgr2d`DT)2JzgPWG8Hn+%%86waRawy9wNhZTa`<>*eGJ#k#Y44
zFE_YqMC@v0gc0k1v2Oo%5E`FtqbZEGCrfg{la073!<Ek_TX9>qzZ}jF`ql_#zKmvF
zA3ilTa&+IL?K{-RKD*UNukO7tyf6jhPX=z^wiS=21_l?wyR}Uli<N}fS)_zl*f!mA
zXxr|t&K5V73;nruW%e*P=iQB<V;?fiv!9l!{209G+KjP@tk`5LL9b6XVwh+4uKU4@
z^h{&^<A>>i=i1z-ryDb%S?XldmdUW%K;NPH1#Fsj(j<oMT)Un>fyq<zE4@nbEE~^w
znn?6aIU5PO#3%lEP8FYL`JVv0%4i@Cb_B(amD1q5E#6ZN;WU@UOy!$Ge6RFk+WPaI
z42xlj0KX9(uw(eperOve+6}yu@cRarAKC|T275@1{fBR|^6T_jJQ~qwG5ump+kQ2%
zjrB)yh5bRhav%G$--;{uU%LAYwrt1QL>rA3?SWz7v>(N^N$DmqIAWKY?*NxDIO5ev
z?aDh*Y+R;=gY$P{Ayr5je5dnb!ms;nF~qcu{3r<qX~z3?I@f*szHJ=EHsud5qkM3#
zmrErK^d0BtdpR><#Vjo1A-X_UNQv{aN4KH7_iXi&D||1rS!r(JF*-|VZ04#xc9Kq#
z-r`OxahY%JRTFd<yL;)NSQLB47?K|a#TP|@J7zGLaj@z!Y+B;vtUNi#Pg3-Vu>S)s
Cro3tZ
literal 0
HcmV?d00001
diff --git a/tests/data/acpi/q35/DSDT.numamem b/tests/data/acpi/q35/DSDT.numamem
index 151e7cf42953f3f5fe61ff0140ab7b976fe9e5b8..050aaa237b466b0bda8cca5cfaa06f84661d622e 100644
GIT binary patch
delta 24
gcmaFv@Z5pRCD<h-U4emtamhrkD~xg*?{~-p0BWTOc>n+a
delta 24
gcmaFv@Z5pRCD<h-U4emtaq&d1D~$3R?{~-p0BWEJc>n+a
diff --git a/tests/data/acpi/q35/DSDT.smm-compat b/tests/data/acpi/q35/DSDT.smm-compat
new file mode 100644
index 0000000000000000000000000000000000000000..c1965f6051ef2af81dd8412abe169d87845bb033
GIT binary patch
literal 8289
zcmb7JOKcm*8J^`!tL0K!Qk3OaY{E(UN|8{0Bx#EVC3pF<L~6yQ;si9nrRB7;og#}k
z2J%1vSpgEqhoT9aphr4TfZp0uuQkw1d-JUUdg`H<T#F(`4`IK5h9l3A6cF>U+JE-@
z{(rvNo&8obUf^~51;&j3l{egaP$<9Ry9N9V#u%N`U#F3{%(}Z?xz;n%v4qjRo#y8_
zl+FB)z4BJg`29}!c^JO+QE2odcI6A_vn&1RgFE3BMxa|)BFmx^r?Sus%DwKMYx!=Y
zX!hz2&n`W%Ota^Tv$)wSd2MF)wi+JGug~>10ylB@26MejtHV}uu#;V~oNn`<=e{|8
z@)w_9daHE*=l}TS-5XW{fV22(;_tbL4&i&Dbt)V>pAN1W?-QM0TOBTaI^dT@n?qNk
zkXr89qKQ(i?%(L{z38<|F7IQ;Z}~;HxQc$c?I3&FI{DEGV>S&A{r)r>js7A|nez^F
znx;@$G3$P%BUKvEMyk5Ib-&YOHe(OIO|wMzwnOpK%axW_@Y`Omkbk}xbV@9umN25G
z{=1>&ghTt2LC6MSdNkT+!-Y=<efGP)&HnY@<UZTC7DeB(*20JL)Rza}vIJx3&G(+A
z-q3h=_l`G$QjZTY%AZD8{6>2-W`&mRtSvqlmq0>w_s*}CJ%GhMilg`Fl`M1ATCN!(
z3z=cmjH~P_{+@}UT6gcM=El|mYjH_qnO5=)jZk;*?7H7smAMn*ej6Iru`)H|?fBbq
z(>$}wGoN)gng^UD&=}1boQLs;ab})zIOpkh$35sxdVK$Q>WD?mFwZapL)6MX8lzp`
z4LU~pzHOPfH59lQyR8BaUZJ}iR4!r`{LQv-<I)tk<znR`E|go%wvm1yXcV~R)>gCN
zH@sI0U8B72uCe^nzFWB%>pn@*XcX-bB6`QT#wbVk`_#P8^3RmOnT4WU5go!YHq3h|
z-wT=x!}amhc<{pC{~cU-xB1D+*Ue*pb(<08di~eo@X5h-Has@CX2mcA-sjJejmLJx
z_Oo&0HXYc#mErQ>x-}Q&k};NH{V2TCXKcT3`VF_r@^%k@jcA7==Qpn!^sqSY*L))T
z?T(*YySbZ7C-8K#_10R2iE{(zRhF}<-HIWo$smrP&T^Rq`hl4waN~$r04|7YoCl~3
ziHZCi8{<r1#}P3lG{!g+P|ie1O!S6h<D4mb5NE`c(70d%%9#j>DXU;!2`tZ(;7kck
z2&U{jLRDu{)0yN<2~7&7>^wqMXG+tV;!Fum={garI_ET<bDGXMT_-|Sr>W^QHJzre
z6QQaTZy;r)=QW-4x=w_uPD|5iX*w-kCqh+cTGN@<bf$Hk2vwbU7b^GD)^yssPK2t?
zjHWZA>CEUl5vn>DG@T2Y&IMg3LRIIYrgKr#xv1+zsOoeyosOo{(RCtJb!Ii4SxskF
z*NITonbUOUG@UtJCqh-{lBRP>)48PUM5yY_YdZ6q&b+P@p{jFP)48naT-J3WRCONF
zbRN-k9?^9oRCVG@0#BcO53OiAS9F~SRh>sQokumDM|GVDRh`E;vowAa9^=gN_+@uY
zFx^KXF}*SNxW+uLF^}s^gevod#yp`hPv}g9D)XeqJgG5H>P&<x^9halgvNYAXChRY
zr#Mr(%qh;4@Ay-KDPP<Oi7D^kX|3jIt>$UHCPGougn^b61FZ!Ol;&n?;2ed=28sY>
zMG!|Ii^4z!j$4w!h$Z`Hps0Wz7$`z14F)Q((m)j`8K{6B7$`#YMjEKVjw7n68mNFC
z7$`#Yh+|=(0y~bz8ab2<R6u2@>V$!cw44b8RiI>`2&F5Mfg+STVW0xbnJ`cVN(L&R
zye1haLa7r5DzKah16818paRO7WS|J8P8g`bawZH^fs%m=C})y^B9!+N1}d<e2?JH2
zWS|1dnPi{{rA`>Az;Y%GRDqI#3Mglifg+STVW0xbnJ`cVN(L&RoJj_XQ0jz%3M^;B
zKouw%sDN@N87M-j69y`<oCyO}pk$x|%9&)K2&GOKsK9b23{-)VfeI*Rl7S+WI$@v!
z%b74x1xf}gpqxnticso=feI{V!ax-$8K{7ACK)I~sS^e&u$&14RiI>`0?L_Wpa`W-
z7^uK<CJa=8l7R{+XOe*;lsaLc0?U~&Pz6c`DxjQ628vMXgn<eyXTm@gC>f}LawZul
zLa7r5DzKah16818paRO7WS|J8P8g`bawZH^fs%m=C})y^B9uB|paRR8Fi-_b1}dPO
zNd}5g>V$y`EN8+%6(|{~fN~}oC_<?d28u{AP(-SMB2*0&p<<v469%d<$v_n*8K}a9
zfhtTGsKO)zRhVR;3KIsZFkzqylMGa0l7T8r7^uR8fhtTgP=!ebsxV=oh~(Xcfg-{k
z<AX^CiV(L!hQyR(3j;+Y#})>PNRBNTC_*{5WS|JKRCK%t3uQxl!2em@r+-NArRYzo
zd;6!)#p%CPTGgQS4#RJ6mf*OXWjeTY@Jxoam(2>DSLslrL*2|TH8!ytFr0tS+TFn-
z%ly8T&Yy2=y6t%Y+QsaGmHs%z=J`s{JM1pCSxFol(R(}ABBL{OqK&1O^*MYal;o0!
zjpZ6z3^LK}AbZ4G`gnoO$Kh@a?{9`TF;*|~i+mkupSpnFl=9i0*9h4AbZ+hPmPJ~R
zVnDcU9<TI*c3|Ay8TWz8Q~S7jd7?TNPrh^YvQoXwtC!I~wR$-}yL!31*Cg#?DGkeg
zW9?S#G0MA2d6$=WC(65rly}GFy$SIa7PP*zdQU0u@$%k8dGC<&-ne{avV7t(%2$-~
z6<)qFQND6W`O3I_b+UZ&G0In!@>O2GI#IrQNcrlxd~LFP>M_dKl=3xRzBW<5c1Zc!
zxO{!G{M=)duPf#2ynKD4eEpE}b(Bxgt8B8oBg)H{2R<t>-NpK?-j+}CDUUxiugB>o
zr?HjQ)8SiVDxGMXnQm%c=Ja&<0GUcB+GeJknrB!7rg<iX;j3gSooJhxZff4-^>p}D
znMx<xW~Q5(2g`aoe7{Vk6KyloO+D8~^mO>BnMx<xW~Q5ZPFM7F_|ln5C))IM&WT6s
z*?WsYvy814Y^&IDtob_|FNxiWx^?-{iof5k1oA1hFgf8(8Q0$`)Zch3di~a~3U9u4
z^Nm|?ZohVubq&{FUmHKI8Oy2}U)f*ThK*HycoHq0e`Q;C_x2AcD6xX;S6YVKXa$Db
zZoX__0lY|us=?x}+w`!=o+D)34Jzvez`atZfVJjEt6@fr8u8ShyUg{VL!y(JlIu5$
z#nmEpLu?!+^I5l3eKj_;20QFSw^%G*%hyv_y)VsopS=8BLT+u4P!d4P?~~0a7O`-6
zd@y-|Bt+ICmffeWtgr2d`DT)2JzgPWG8Hn+%%86waRawy9wNhZTa`<>*eGJ#k#Y44
zFE_YqMC@v0gc0k1v2Oo%5E`FtqbZEGCrfg{la073!<Ek_TX9>qzZ}jF`ql_#zKmvF
zA3ilTa&+IL?K{-RKD*UNukO7tyf6jhPX=z^wiS=21_l?wyR}Uli<N}fS)_zl*f!mA
zXxr|t&K5V73;nruW%e*P=iQB<V;?fiv!9l!{209G+KjP@tk`5LL9b6XVwh+4uKU4@
z^h{&^<A>>i=i1z-ryDb%S?XldmdUW%K;NPH1#Fsj(j<oMT)Un>fyq<zE4@nbEE~^w
znn?6aIU5PO#3%lEP8FYL`JVv0%4i@Cb_B(amD1q5E#6ZN;WU@UOy!$Ge6RFk+WPaI
z42xlj0KX9(uw(eperOve+6}yu@cRarAKC|T275@1{fBR|^6T_jJQ~qwG5ump+kQ2%
zjrB)yh5bRhav%G$--;{uU%LAYwrt1QL>rA3?SWz7v>(N^N$DmqIAWKY?*NxDIO5ev
z?aDh*Y+R;=gY$P{Ayr5je5dnb!ms;nF~qcu{3r<qX~z3?I@f*szHJ=EHsud5qkM3#
zmrErK^d0BtdpR><#Vjo1A-X_UNQv{aN4KH7_iXi&D||1rS!r(JF*-|VZ04#xc9Kq#
z-r`OxahY%JRTFd<yL;)NSQLB47?K|a#TP|@J7zGLaj@z!Y+B;vtUNi#Pg3-Vu>S)s
Cro3tZ
literal 0
HcmV?d00001
diff --git a/tests/data/acpi/q35/DSDT.smm-compat-nosmm b/tests/data/acpi/q35/DSDT.smm-compat-nosmm
new file mode 100644
index 0000000000000000000000000000000000000000..c1965f6051ef2af81dd8412abe169d87845bb033
GIT binary patch
literal 8289
zcmb7JOKcm*8J^`!tL0K!Qk3OaY{E(UN|8{0Bx#EVC3pF<L~6yQ;si9nrRB7;og#}k
z2J%1vSpgEqhoT9aphr4TfZp0uuQkw1d-JUUdg`H<T#F(`4`IK5h9l3A6cF>U+JE-@
z{(rvNo&8obUf^~51;&j3l{egaP$<9Ry9N9V#u%N`U#F3{%(}Z?xz;n%v4qjRo#y8_
zl+FB)z4BJg`29}!c^JO+QE2odcI6A_vn&1RgFE3BMxa|)BFmx^r?Sus%DwKMYx!=Y
zX!hz2&n`W%Ota^Tv$)wSd2MF)wi+JGug~>10ylB@26MejtHV}uu#;V~oNn`<=e{|8
z@)w_9daHE*=l}TS-5XW{fV22(;_tbL4&i&Dbt)V>pAN1W?-QM0TOBTaI^dT@n?qNk
zkXr89qKQ(i?%(L{z38<|F7IQ;Z}~;HxQc$c?I3&FI{DEGV>S&A{r)r>js7A|nez^F
znx;@$G3$P%BUKvEMyk5Ib-&YOHe(OIO|wMzwnOpK%axW_@Y`Omkbk}xbV@9umN25G
z{=1>&ghTt2LC6MSdNkT+!-Y=<efGP)&HnY@<UZTC7DeB(*20JL)Rza}vIJx3&G(+A
z-q3h=_l`G$QjZTY%AZD8{6>2-W`&mRtSvqlmq0>w_s*}CJ%GhMilg`Fl`M1ATCN!(
z3z=cmjH~P_{+@}UT6gcM=El|mYjH_qnO5=)jZk;*?7H7smAMn*ej6Iru`)H|?fBbq
z(>$}wGoN)gng^UD&=}1boQLs;ab})zIOpkh$35sxdVK$Q>WD?mFwZapL)6MX8lzp`
z4LU~pzHOPfH59lQyR8BaUZJ}iR4!r`{LQv-<I)tk<znR`E|go%wvm1yXcV~R)>gCN
zH@sI0U8B72uCe^nzFWB%>pn@*XcX-bB6`QT#wbVk`_#P8^3RmOnT4WU5go!YHq3h|
z-wT=x!}amhc<{pC{~cU-xB1D+*Ue*pb(<08di~eo@X5h-Has@CX2mcA-sjJejmLJx
z_Oo&0HXYc#mErQ>x-}Q&k};NH{V2TCXKcT3`VF_r@^%k@jcA7==Qpn!^sqSY*L))T
z?T(*YySbZ7C-8K#_10R2iE{(zRhF}<-HIWo$smrP&T^Rq`hl4waN~$r04|7YoCl~3
ziHZCi8{<r1#}P3lG{!g+P|ie1O!S6h<D4mb5NE`c(70d%%9#j>DXU;!2`tZ(;7kck
z2&U{jLRDu{)0yN<2~7&7>^wqMXG+tV;!Fum={garI_ET<bDGXMT_-|Sr>W^QHJzre
z6QQaTZy;r)=QW-4x=w_uPD|5iX*w-kCqh+cTGN@<bf$Hk2vwbU7b^GD)^yssPK2t?
zjHWZA>CEUl5vn>DG@T2Y&IMg3LRIIYrgKr#xv1+zsOoeyosOo{(RCtJb!Ii4SxskF
z*NITonbUOUG@UtJCqh-{lBRP>)48PUM5yY_YdZ6q&b+P@p{jFP)48naT-J3WRCONF
zbRN-k9?^9oRCVG@0#BcO53OiAS9F~SRh>sQokumDM|GVDRh`E;vowAa9^=gN_+@uY
zFx^KXF}*SNxW+uLF^}s^gevod#yp`hPv}g9D)XeqJgG5H>P&<x^9halgvNYAXChRY
zr#Mr(%qh;4@Ay-KDPP<Oi7D^kX|3jIt>$UHCPGougn^b61FZ!Ol;&n?;2ed=28sY>
zMG!|Ii^4z!j$4w!h$Z`Hps0Wz7$`z14F)Q((m)j`8K{6B7$`#YMjEKVjw7n68mNFC
z7$`#Yh+|=(0y~bz8ab2<R6u2@>V$!cw44b8RiI>`2&F5Mfg+STVW0xbnJ`cVN(L&R
zye1haLa7r5DzKah16818paRO7WS|J8P8g`bawZH^fs%m=C})y^B9!+N1}d<e2?JH2
zWS|1dnPi{{rA`>Az;Y%GRDqI#3Mglifg+STVW0xbnJ`cVN(L&RoJj_XQ0jz%3M^;B
zKouw%sDN@N87M-j69y`<oCyO}pk$x|%9&)K2&GOKsK9b23{-)VfeI*Rl7S+WI$@v!
z%b74x1xf}gpqxnticso=feI{V!ax-$8K{7ACK)I~sS^e&u$&14RiI>`0?L_Wpa`W-
z7^uK<CJa=8l7R{+XOe*;lsaLc0?U~&Pz6c`DxjQ628vMXgn<eyXTm@gC>f}LawZul
zLa7r5DzKah16818paRO7WS|J8P8g`bawZH^fs%m=C})y^B9uB|paRR8Fi-_b1}dPO
zNd}5g>V$y`EN8+%6(|{~fN~}oC_<?d28u{AP(-SMB2*0&p<<v469%d<$v_n*8K}a9
zfhtTGsKO)zRhVR;3KIsZFkzqylMGa0l7T8r7^uR8fhtTgP=!ebsxV=oh~(Xcfg-{k
z<AX^CiV(L!hQyR(3j;+Y#})>PNRBNTC_*{5WS|JKRCK%t3uQxl!2em@r+-NArRYzo
zd;6!)#p%CPTGgQS4#RJ6mf*OXWjeTY@Jxoam(2>DSLslrL*2|TH8!ytFr0tS+TFn-
z%ly8T&Yy2=y6t%Y+QsaGmHs%z=J`s{JM1pCSxFol(R(}ABBL{OqK&1O^*MYal;o0!
zjpZ6z3^LK}AbZ4G`gnoO$Kh@a?{9`TF;*|~i+mkupSpnFl=9i0*9h4AbZ+hPmPJ~R
zVnDcU9<TI*c3|Ay8TWz8Q~S7jd7?TNPrh^YvQoXwtC!I~wR$-}yL!31*Cg#?DGkeg
zW9?S#G0MA2d6$=WC(65rly}GFy$SIa7PP*zdQU0u@$%k8dGC<&-ne{avV7t(%2$-~
z6<)qFQND6W`O3I_b+UZ&G0In!@>O2GI#IrQNcrlxd~LFP>M_dKl=3xRzBW<5c1Zc!
zxO{!G{M=)duPf#2ynKD4eEpE}b(Bxgt8B8oBg)H{2R<t>-NpK?-j+}CDUUxiugB>o
zr?HjQ)8SiVDxGMXnQm%c=Ja&<0GUcB+GeJknrB!7rg<iX;j3gSooJhxZff4-^>p}D
znMx<xW~Q5(2g`aoe7{Vk6KyloO+D8~^mO>BnMx<xW~Q5ZPFM7F_|ln5C))IM&WT6s
z*?WsYvy814Y^&IDtob_|FNxiWx^?-{iof5k1oA1hFgf8(8Q0$`)Zch3di~a~3U9u4
z^Nm|?ZohVubq&{FUmHKI8Oy2}U)f*ThK*HycoHq0e`Q;C_x2AcD6xX;S6YVKXa$Db
zZoX__0lY|us=?x}+w`!=o+D)34Jzvez`atZfVJjEt6@fr8u8ShyUg{VL!y(JlIu5$
z#nmEpLu?!+^I5l3eKj_;20QFSw^%G*%hyv_y)VsopS=8BLT+u4P!d4P?~~0a7O`-6
zd@y-|Bt+ICmffeWtgr2d`DT)2JzgPWG8Hn+%%86waRawy9wNhZTa`<>*eGJ#k#Y44
zFE_YqMC@v0gc0k1v2Oo%5E`FtqbZEGCrfg{la073!<Ek_TX9>qzZ}jF`ql_#zKmvF
zA3ilTa&+IL?K{-RKD*UNukO7tyf6jhPX=z^wiS=21_l?wyR}Uli<N}fS)_zl*f!mA
zXxr|t&K5V73;nruW%e*P=iQB<V;?fiv!9l!{209G+KjP@tk`5LL9b6XVwh+4uKU4@
z^h{&^<A>>i=i1z-ryDb%S?XldmdUW%K;NPH1#Fsj(j<oMT)Un>fyq<zE4@nbEE~^w
znn?6aIU5PO#3%lEP8FYL`JVv0%4i@Cb_B(amD1q5E#6ZN;WU@UOy!$Ge6RFk+WPaI
z42xlj0KX9(uw(eperOve+6}yu@cRarAKC|T275@1{fBR|^6T_jJQ~qwG5ump+kQ2%
zjrB)yh5bRhav%G$--;{uU%LAYwrt1QL>rA3?SWz7v>(N^N$DmqIAWKY?*NxDIO5ev
z?aDh*Y+R;=gY$P{Ayr5je5dnb!ms;nF~qcu{3r<qX~z3?I@f*szHJ=EHsud5qkM3#
zmrErK^d0BtdpR><#Vjo1A-X_UNQv{aN4KH7_iXi&D||1rS!r(JF*-|VZ04#xc9Kq#
z-r`OxahY%JRTFd<yL;)NSQLB47?K|a#TP|@J7zGLaj@z!Y+B;vtUNi#Pg3-Vu>S)s
Cro3tZ
literal 0
HcmV?d00001
diff --git a/tests/data/acpi/q35/DSDT.tis.tpm12 b/tests/data/acpi/q35/DSDT.tis.tpm12
index c96b5277a14ae98174408d690d6e0246bd932623..0ebdf6fbd77967f1ab5d5337b7b1fed314cfaca8 100644
GIT binary patch
delta 24
gcmdnzy3du%CD<iopArKDqxwXyD~xg*@84Gh0A(f!W&i*H
delta 24
gcmdnzy3du%CD<iopArKDquNBSD~$3R@84Gh0A(QvW&i*H
diff --git a/tests/data/acpi/q35/DSDT.tis.tpm2 b/tests/data/acpi/q35/DSDT.tis.tpm2
index c92d4d29c79352a60974ea9f665d0b9a410a4bac..dcbb7f0af377425db53130e8ba1c62c09c22e006 100644
GIT binary patch
delta 24
gcmdnzy3du%CD<iopArKD<D-dOR~Y3s-oLL10Bm##ApigX
delta 24
gcmdnzy3du%CD<iopArKD<HLzuR~Y3t-oLL10BmmwApigX
diff --git a/tests/data/acpi/q35/DSDT.xapic b/tests/data/acpi/q35/DSDT.xapic
index 119fc90f1f8a7b6934df6fd95609446e627ce15d..17552ce363ae81985f69f9ae85837a1540b79ae0 100644
GIT binary patch
delta 26
icmX>yjp@iVCN7s?mk^h31_s6r6S=N1%5A)#+64f6_X&Rh
delta 26
icmX>yjp@iVCN7s?mk^h31_s9U6S=N1%5S`%+64f6@(F(c
--
2.27.0
^ permalink raw reply related [flat|nested] 24+ messages in thread
* Re: [PATCH for 6.2 v2 1/5] pcie: rename 'native-hotplug' to 'x-native-hotplug'
2021-11-10 21:11 ` [PATCH for 6.2 v2 1/5] pcie: rename 'native-hotplug' to 'x-native-hotplug' Igor Mammedov
@ 2021-11-11 3:25 ` Ani Sinha
2021-11-12 10:47 ` Igor Mammedov
0 siblings, 1 reply; 24+ messages in thread
From: Ani Sinha @ 2021-11-11 3:25 UTC (permalink / raw)
To: Igor Mammedov; +Cc: mapfelba, mst, jusual, qemu-devel, qemu-stable, kraxel, ani
On Wed, 10 Nov 2021, Igor Mammedov wrote:
> Mark property as experimental/internal adding 'x-' prefix.
>
> Property was introduced in 6.1 and it should have provided
> ability to turn on native PCIE hotplug on port even when
> ACPI PCI hotplug is in use is user explicitly sets property
> on CLI. However that never worked since slot is wired to
> ACPI hotplug controller.
> Another non-intended usecase: disable native hotplug on slot
> when APCI based hotplug is disabled, which works but slot has
> 'hotplug' property for this taks.
>
> It should be relatively safe to rename it to experimental
> as no users should exist for it and given that the property
> is broken we don't really want to leave it around for much
> longer lest users start using it.
>
> Signed-off-by: Igor Mammedov <imammedo@redhat.com>
Barring the comment below,
Reviewed-by: Ani Sinha <ani@anisinha.ca>
> ---
> CC: qemu-stable@nongnu.org
> ---
> hw/i386/pc_q35.c | 2 +-
> hw/pci/pcie_port.c | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/hw/i386/pc_q35.c b/hw/i386/pc_q35.c
> index 797e09500b..fc34b905ee 100644
> --- a/hw/i386/pc_q35.c
> +++ b/hw/i386/pc_q35.c
> @@ -243,7 +243,7 @@ static void pc_q35_init(MachineState *machine)
> NULL);
>
> if (acpi_pcihp) {
> - object_register_sugar_prop(TYPE_PCIE_SLOT, "native-hotplug",
> + object_register_sugar_prop(TYPE_PCIE_SLOT, "x-native-hotplug",
> "false", true);
Let us document the fact that this property is experimental. It was not at
once obvious to me that an "x-" prefix meant to indicate experimental
status.
> }
>
> diff --git a/hw/pci/pcie_port.c b/hw/pci/pcie_port.c
> index da850e8dde..e95c1e5519 100644
> --- a/hw/pci/pcie_port.c
> +++ b/hw/pci/pcie_port.c
> @@ -148,7 +148,7 @@ static Property pcie_slot_props[] = {
> DEFINE_PROP_UINT8("chassis", PCIESlot, chassis, 0),
> DEFINE_PROP_UINT16("slot", PCIESlot, slot, 0),
> DEFINE_PROP_BOOL("hotplug", PCIESlot, hotplug, true),
> - DEFINE_PROP_BOOL("native-hotplug", PCIESlot, native_hotplug, true),
> + DEFINE_PROP_BOOL("x-native-hotplug", PCIESlot, native_hotplug, true),
> DEFINE_PROP_END_OF_LIST()
> };
>
> --
> 2.27.0
>
>
^ permalink raw reply [flat|nested] 24+ messages in thread
* Re: [PATCH for 6.2 v2 4/5] hw/i386/acpi-build: Deny control on PCIe Native Hot-plug in _OSC
2021-11-10 21:11 ` [PATCH for 6.2 v2 4/5] hw/i386/acpi-build: Deny control on PCIe Native Hot-plug in _OSC Igor Mammedov
@ 2021-11-11 5:49 ` Ani Sinha
2021-11-12 10:51 ` Igor Mammedov
0 siblings, 1 reply; 24+ messages in thread
From: Ani Sinha @ 2021-11-11 5:49 UTC (permalink / raw)
To: Igor Mammedov; +Cc: mapfelba, mst, jusual, qemu-devel, kraxel, ani
On Wed, 10 Nov 2021, Igor Mammedov wrote:
> From: Julia Suvorova <jusual@redhat.com>
>
> There are two ways to enable ACPI PCI Hot-plug:
>
> * Disable the Hot-plug Capable bit on PCIe slots.
>
> This was the first approach which led to regression [1-2], as
> I/O space for a port is allocated only when it is hot-pluggable,
> which is determined by HPC bit.
>
> * Leave the HPC bit on and disable PCIe Native Hot-plug in _OSC
> method.
>
> This removes the (future) ability of hot-plugging switches with PCIe
> Native hotplug since ACPI PCI Hot-plug only works with cold-plugged
> bridges. If the user wants to explicitely use this feature, they can
> disable ACPI PCI Hot-plug with:
> --global ICH9-LPC.acpi-pci-hotplug-with-bridge-support=off
>
> Change the bit in _OSC method so that the OS selects ACPI PCI Hot-plug
> instead of PCIe Native.
>
> [1] https://gitlab.com/qemu-project/qemu/-/issues/641
> [2] https://bugzilla.redhat.com/show_bug.cgi?id=2006409
>
> Signed-off-by: Julia Suvorova <jusual@redhat.com>
> Signed-off-by: Igor Mammedov <imammedo@redhat.com>
> ---
> v2:
> - (mst)
> * drop local hotplug var and opencode it
> * rename acpi_pcihp parameter to enable_native_pcie_hotplug
> to reflect what it actually does
>
> tested:
> with hotplugging nic into 1 root port with seabios/ovmf/Fedora34
> Windows tested only with seabios (using exiting images)
> (installer fails to install regardless on bios)
> ---
> hw/i386/acpi-build.c | 12 ++++++++----
> 1 file changed, 8 insertions(+), 4 deletions(-)
>
> diff --git a/hw/i386/acpi-build.c b/hw/i386/acpi-build.c
> index a3ad6abd33..a99c6e4fe3 100644
> --- a/hw/i386/acpi-build.c
> +++ b/hw/i386/acpi-build.c
> @@ -1337,7 +1337,7 @@ static void build_x86_acpi_pci_hotplug(Aml *table, uint64_t pcihp_addr)
> aml_append(table, scope);
> }
>
> -static Aml *build_q35_osc_method(void)
> +static Aml *build_q35_osc_method(bool enable_native_pcie_hotplug)
> {
> Aml *if_ctx;
> Aml *if_ctx2;
> @@ -1359,8 +1359,10 @@ static Aml *build_q35_osc_method(void)
> /*
> * Always allow native PME, AER (no dependencies)
> * Allow SHPC (PCI bridges can have SHPC controller)
> + * Disable PCIe Native Hot-plug if ACPI PCI Hot-plug is enabled.
> */
Based on v2, I think its more useful to have this comment where the
function is called.
> - aml_append(if_ctx, aml_and(a_ctrl, aml_int(0x1F), a_ctrl));
> + aml_append(if_ctx, aml_and(a_ctrl,
> + aml_int(0x1E | (enable_native_pcie_hotplug ? 0x1 : 0x0)), a_ctrl));
>
> if_ctx2 = aml_if(aml_lnot(aml_equal(aml_arg(1), aml_int(1))));
> /* Unknown revision */
> @@ -1449,7 +1451,7 @@ build_dsdt(GArray *table_data, BIOSLinker *linker,
> aml_append(dev, aml_name_decl("_CID", aml_eisaid("PNP0A03")));
> aml_append(dev, aml_name_decl("_ADR", aml_int(0)));
> aml_append(dev, aml_name_decl("_UID", aml_int(pcmc->pci_root_uid)));
> - aml_append(dev, build_q35_osc_method());
> + aml_append(dev, build_q35_osc_method(!pm->pcihp_bridge_en));
See above. I think it helps to add a comment here saying native hotplug is
enabled when acpi hotplug is disabled for cold plugged bridges.
> aml_append(sb_scope, dev);
> if (mcfg_valid) {
> aml_append(sb_scope, build_q35_dram_controller(&mcfg));
> @@ -1565,7 +1567,9 @@ build_dsdt(GArray *table_data, BIOSLinker *linker,
> if (pci_bus_is_express(bus)) {
> aml_append(dev, aml_name_decl("_HID", aml_eisaid("PNP0A08")));
> aml_append(dev, aml_name_decl("_CID", aml_eisaid("PNP0A03")));
> - aml_append(dev, build_q35_osc_method());
> +
> + /* Expander bridges do not have ACPI PCI Hot-plug enabled */
> + aml_append(dev, build_q35_osc_method(true));
> } else {
> aml_append(dev, aml_name_decl("_HID", aml_eisaid("PNP0A03")));
> }
> --
> 2.27.0
>
>
^ permalink raw reply [flat|nested] 24+ messages in thread
* Re: [PATCH for 6.2 v2 5/5] bios-tables-test: Update golden binaries
2021-11-10 21:11 ` [PATCH for 6.2 v2 5/5] bios-tables-test: Update golden binaries Igor Mammedov
@ 2021-11-11 5:51 ` Ani Sinha
2021-11-11 8:34 ` Michael S. Tsirkin
1 sibling, 0 replies; 24+ messages in thread
From: Ani Sinha @ 2021-11-11 5:51 UTC (permalink / raw)
To: Igor Mammedov; +Cc: mapfelba, mst, jusual, qemu-devel, kraxel, ani
On Wed, 10 Nov 2021, Igor Mammedov wrote:
> From: Julia Suvorova <jusual@redhat.com>
>
> The changes are the result of
> 'hw/i386/acpi-build: Deny control on PCIe Native Hot-Plug in _OSC'
> and listed here:
>
> Method (_OSC, 4, NotSerialized) // _OSC: Operating System Capabilities
> {
> CreateDWordField (Arg3, Zero, CDW1)
> If ((Arg0 == ToUUID ("33db4d5b-1ff7-401c-9657-7441c03dd766") /* PCI Host Bridge Device */))
> {
> CreateDWordField (Arg3, 0x04, CDW2)
> CreateDWordField (Arg3, 0x08, CDW3)
> Local0 = CDW3 /* \_SB_.PCI0._OSC.CDW3 */
> - Local0 &= 0x1F
> + Local0 &= 0x1E
>
> Signed-off-by: Julia Suvorova <jusual@redhat.com>
> Signed-off-by: Igor Mammedov <imammedo@redhat.com>
Acked-by: Ani Sinha <ani@anisinha.ca>
> ---
> tests/qtest/bios-tables-test-allowed-diff.h | 16 ----------------
> tests/data/acpi/q35/DSDT | Bin 8289 -> 8289 bytes
> tests/data/acpi/q35/DSDT.acpihmat | Bin 9614 -> 9614 bytes
> tests/data/acpi/q35/DSDT.bridge | Bin 11003 -> 11003 bytes
> tests/data/acpi/q35/DSDT.cphp | Bin 8753 -> 8753 bytes
> tests/data/acpi/q35/DSDT.dimmpxm | Bin 9943 -> 9943 bytes
> tests/data/acpi/q35/DSDT.dmar | Bin 0 -> 8289 bytes
> tests/data/acpi/q35/DSDT.ipmibt | Bin 8364 -> 8364 bytes
> tests/data/acpi/q35/DSDT.ivrs | Bin 8306 -> 8306 bytes
> tests/data/acpi/q35/DSDT.memhp | Bin 9648 -> 9648 bytes
> tests/data/acpi/q35/DSDT.mmio64 | Bin 9419 -> 9419 bytes
> tests/data/acpi/q35/DSDT.multi-bridge | Bin 8583 -> 8583 bytes
> tests/data/acpi/q35/DSDT.nohpet | Bin 8147 -> 8147 bytes
> tests/data/acpi/q35/DSDT.nosmm | Bin 0 -> 8289 bytes
> tests/data/acpi/q35/DSDT.numamem | Bin 8295 -> 8295 bytes
> tests/data/acpi/q35/DSDT.smm-compat | Bin 0 -> 8289 bytes
> tests/data/acpi/q35/DSDT.smm-compat-nosmm | Bin 0 -> 8289 bytes
> tests/data/acpi/q35/DSDT.tis.tpm12 | Bin 8894 -> 8894 bytes
> tests/data/acpi/q35/DSDT.tis.tpm2 | Bin 8894 -> 8894 bytes
> tests/data/acpi/q35/DSDT.xapic | Bin 35652 -> 35652 bytes
> 20 files changed, 16 deletions(-)
> create mode 100644 tests/data/acpi/q35/DSDT.dmar
> create mode 100644 tests/data/acpi/q35/DSDT.nosmm
> create mode 100644 tests/data/acpi/q35/DSDT.smm-compat
> create mode 100644 tests/data/acpi/q35/DSDT.smm-compat-nosmm
>
> diff --git a/tests/qtest/bios-tables-test-allowed-diff.h b/tests/qtest/bios-tables-test-allowed-diff.h
> index 48e5634d4b..dfb8523c8b 100644
> --- a/tests/qtest/bios-tables-test-allowed-diff.h
> +++ b/tests/qtest/bios-tables-test-allowed-diff.h
> @@ -1,17 +1 @@
> /* List of comma-separated changed AML files to ignore */
> -"tests/data/acpi/q35/DSDT",
> -"tests/data/acpi/q35/DSDT.tis",
> -"tests/data/acpi/q35/DSDT.bridge",
> -"tests/data/acpi/q35/DSDT.mmio64",
> -"tests/data/acpi/q35/DSDT.ipmibt",
> -"tests/data/acpi/q35/DSDT.cphp",
> -"tests/data/acpi/q35/DSDT.memhp",
> -"tests/data/acpi/q35/DSDT.acpihmat",
> -"tests/data/acpi/q35/DSDT.numamem",
> -"tests/data/acpi/q35/DSDT.dimmpxm",
> -"tests/data/acpi/q35/DSDT.nohpet",
> -"tests/data/acpi/q35/DSDT.tis.tpm2",
> -"tests/data/acpi/q35/DSDT.tis.tpm12",
> -"tests/data/acpi/q35/DSDT.multi-bridge",
> -"tests/data/acpi/q35/DSDT.ivrs",
> -"tests/data/acpi/q35/DSDT.xapic",
> diff --git a/tests/data/acpi/q35/DSDT b/tests/data/acpi/q35/DSDT
> index 281fc82c03b2562d2e6b7caec0d817b034a47138..c1965f6051ef2af81dd8412abe169d87845bb033 100644
> GIT binary patch
> delta 24
> gcmaFp@X&$FCD<h-QGtPh@z+GID~xg*?>ET<0BnZ{w*UYD
>
> delta 24
> gcmaFp@X&$FCD<h-QGtPh@#jRYD~$3R?>ET<0BnK?w*UYD
>
> diff --git a/tests/data/acpi/q35/DSDT.acpihmat b/tests/data/acpi/q35/DSDT.acpihmat
> index 8c1e05a11a328ec1cc6f86e36e52c28f41f9744e..f24d4874bff8d327a165ed7c36de507aea114edd 100644
> GIT binary patch
> delta 24
> fcmeD4?(^ny33dtTQ)OUa+&+=(3ZvY{`|DKzU@Hhn
>
> delta 24
> fcmeD4?(^ny33dtTQ)OUa+%}Qx3ZwkS`|DKzU?vDi
>
> diff --git a/tests/data/acpi/q35/DSDT.bridge b/tests/data/acpi/q35/DSDT.bridge
> index 6f1464b6c712d7f33cb4b891b7ce76fe228f44c9..424d51bd1cb39ea73501ef7d0044ee52cec5bdac 100644
> GIT binary patch
> delta 24
> gcmewz`a6`%CD<k8w-y5fBg;gtD~xg*@5^Wb0CWThXaE2J
>
> delta 24
> gcmewz`a6`%CD<k8w-y5fBlASAD~$3R@5^Wb0CWEcXaE2J
>
> diff --git a/tests/data/acpi/q35/DSDT.cphp b/tests/data/acpi/q35/DSDT.cphp
> index f8337ff5191a37a47dcf7c09a6c39c4e704a15bf..f1275606f68eeba54bfb11e63d818420385a62b9 100644
> GIT binary patch
> delta 24
> fcmdn!veAXhCD<jzP>F$oF>WH)6-K#@_k$DxTWtqt
>
> delta 24
> fcmdn!veAXhCD<jzP>F$oF?J%?6-N1u_k$DxTWAMo
>
> diff --git a/tests/data/acpi/q35/DSDT.dimmpxm b/tests/data/acpi/q35/DSDT.dimmpxm
> index fe5820d93d057ef09a001662369b15afbc5b87e2..76e451e829ec4c245315f7eed8731aa1be45a747 100644
> GIT binary patch
> delta 24
> gcmccad)=4ICD<k8x*7umqsK(9D~xg*@BdH*0B$o00{{R3
>
> delta 24
> gcmccad)=4ICD<k8x*7umqx(dzD~$3R@BdH*0B$Y`0{{R3
>
> diff --git a/tests/data/acpi/q35/DSDT.dmar b/tests/data/acpi/q35/DSDT.dmar
> new file mode 100644
> index 0000000000000000000000000000000000000000..c1965f6051ef2af81dd8412abe169d87845bb033
> GIT binary patch
> literal 8289
> zcmb7JOKcm*8J^`!tL0K!Qk3OaY{E(UN|8{0Bx#EVC3pF<L~6yQ;si9nrRB7;og#}k
> z2J%1vSpgEqhoT9aphr4TfZp0uuQkw1d-JUUdg`H<T#F(`4`IK5h9l3A6cF>U+JE-@
> z{(rvNo&8obUf^~51;&j3l{egaP$<9Ry9N9V#u%N`U#F3{%(}Z?xz;n%v4qjRo#y8_
> zl+FB)z4BJg`29}!c^JO+QE2odcI6A_vn&1RgFE3BMxa|)BFmx^r?Sus%DwKMYx!=Y
> zX!hz2&n`W%Ota^Tv$)wSd2MF)wi+JGug~>10ylB@26MejtHV}uu#;V~oNn`<=e{|8
> z@)w_9daHE*=l}TS-5XW{fV22(;_tbL4&i&Dbt)V>pAN1W?-QM0TOBTaI^dT@n?qNk
> zkXr89qKQ(i?%(L{z38<|F7IQ;Z}~;HxQc$c?I3&FI{DEGV>S&A{r)r>js7A|nez^F
> znx;@$G3$P%BUKvEMyk5Ib-&YOHe(OIO|wMzwnOpK%axW_@Y`Omkbk}xbV@9umN25G
> z{=1>&ghTt2LC6MSdNkT+!-Y=<efGP)&HnY@<UZTC7DeB(*20JL)Rza}vIJx3&G(+A
> z-q3h=_l`G$QjZTY%AZD8{6>2-W`&mRtSvqlmq0>w_s*}CJ%GhMilg`Fl`M1ATCN!(
> z3z=cmjH~P_{+@}UT6gcM=El|mYjH_qnO5=)jZk;*?7H7smAMn*ej6Iru`)H|?fBbq
> z(>$}wGoN)gng^UD&=}1boQLs;ab})zIOpkh$35sxdVK$Q>WD?mFwZapL)6MX8lzp`
> z4LU~pzHOPfH59lQyR8BaUZJ}iR4!r`{LQv-<I)tk<znR`E|go%wvm1yXcV~R)>gCN
> zH@sI0U8B72uCe^nzFWB%>pn@*XcX-bB6`QT#wbVk`_#P8^3RmOnT4WU5go!YHq3h|
> z-wT=x!}amhc<{pC{~cU-xB1D+*Ue*pb(<08di~eo@X5h-Has@CX2mcA-sjJejmLJx
> z_Oo&0HXYc#mErQ>x-}Q&k};NH{V2TCXKcT3`VF_r@^%k@jcA7==Qpn!^sqSY*L))T
> z?T(*YySbZ7C-8K#_10R2iE{(zRhF}<-HIWo$smrP&T^Rq`hl4waN~$r04|7YoCl~3
> ziHZCi8{<r1#}P3lG{!g+P|ie1O!S6h<D4mb5NE`c(70d%%9#j>DXU;!2`tZ(;7kck
> z2&U{jLRDu{)0yN<2~7&7>^wqMXG+tV;!Fum={garI_ET<bDGXMT_-|Sr>W^QHJzre
> z6QQaTZy;r)=QW-4x=w_uPD|5iX*w-kCqh+cTGN@<bf$Hk2vwbU7b^GD)^yssPK2t?
> zjHWZA>CEUl5vn>DG@T2Y&IMg3LRIIYrgKr#xv1+zsOoeyosOo{(RCtJb!Ii4SxskF
> z*NITonbUOUG@UtJCqh-{lBRP>)48PUM5yY_YdZ6q&b+P@p{jFP)48naT-J3WRCONF
> zbRN-k9?^9oRCVG@0#BcO53OiAS9F~SRh>sQokumDM|GVDRh`E;vowAa9^=gN_+@uY
> zFx^KXF}*SNxW+uLF^}s^gevod#yp`hPv}g9D)XeqJgG5H>P&<x^9halgvNYAXChRY
> zr#Mr(%qh;4@Ay-KDPP<Oi7D^kX|3jIt>$UHCPGougn^b61FZ!Ol;&n?;2ed=28sY>
> zMG!|Ii^4z!j$4w!h$Z`Hps0Wz7$`z14F)Q((m)j`8K{6B7$`#YMjEKVjw7n68mNFC
> z7$`#Yh+|=(0y~bz8ab2<R6u2@>V$!cw44b8RiI>`2&F5Mfg+STVW0xbnJ`cVN(L&R
> zye1haLa7r5DzKah16818paRO7WS|J8P8g`bawZH^fs%m=C})y^B9!+N1}d<e2?JH2
> zWS|1dnPi{{rA`>Az;Y%GRDqI#3Mglifg+STVW0xbnJ`cVN(L&RoJj_XQ0jz%3M^;B
> zKouw%sDN@N87M-j69y`<oCyO}pk$x|%9&)K2&GOKsK9b23{-)VfeI*Rl7S+WI$@v!
> z%b74x1xf}gpqxnticso=feI{V!ax-$8K{7ACK)I~sS^e&u$&14RiI>`0?L_Wpa`W-
> z7^uK<CJa=8l7R{+XOe*;lsaLc0?U~&Pz6c`DxjQ628vMXgn<eyXTm@gC>f}LawZul
> zLa7r5DzKah16818paRO7WS|J8P8g`bawZH^fs%m=C})y^B9uB|paRR8Fi-_b1}dPO
> zNd}5g>V$y`EN8+%6(|{~fN~}oC_<?d28u{AP(-SMB2*0&p<<v469%d<$v_n*8K}a9
> zfhtTGsKO)zRhVR;3KIsZFkzqylMGa0l7T8r7^uR8fhtTgP=!ebsxV=oh~(Xcfg-{k
> z<AX^CiV(L!hQyR(3j;+Y#})>PNRBNTC_*{5WS|JKRCK%t3uQxl!2em@r+-NArRYzo
> zd;6!)#p%CPTGgQS4#RJ6mf*OXWjeTY@Jxoam(2>DSLslrL*2|TH8!ytFr0tS+TFn-
> z%ly8T&Yy2=y6t%Y+QsaGmHs%z=J`s{JM1pCSxFol(R(}ABBL{OqK&1O^*MYal;o0!
> zjpZ6z3^LK}AbZ4G`gnoO$Kh@a?{9`TF;*|~i+mkupSpnFl=9i0*9h4AbZ+hPmPJ~R
> zVnDcU9<TI*c3|Ay8TWz8Q~S7jd7?TNPrh^YvQoXwtC!I~wR$-}yL!31*Cg#?DGkeg
> zW9?S#G0MA2d6$=WC(65rly}GFy$SIa7PP*zdQU0u@$%k8dGC<&-ne{avV7t(%2$-~
> z6<)qFQND6W`O3I_b+UZ&G0In!@>O2GI#IrQNcrlxd~LFP>M_dKl=3xRzBW<5c1Zc!
> zxO{!G{M=)duPf#2ynKD4eEpE}b(Bxgt8B8oBg)H{2R<t>-NpK?-j+}CDUUxiugB>o
> zr?HjQ)8SiVDxGMXnQm%c=Ja&<0GUcB+GeJknrB!7rg<iX;j3gSooJhxZff4-^>p}D
> znMx<xW~Q5(2g`aoe7{Vk6KyloO+D8~^mO>BnMx<xW~Q5ZPFM7F_|ln5C))IM&WT6s
> z*?WsYvy814Y^&IDtob_|FNxiWx^?-{iof5k1oA1hFgf8(8Q0$`)Zch3di~a~3U9u4
> z^Nm|?ZohVubq&{FUmHKI8Oy2}U)f*ThK*HycoHq0e`Q;C_x2AcD6xX;S6YVKXa$Db
> zZoX__0lY|us=?x}+w`!=o+D)34Jzvez`atZfVJjEt6@fr8u8ShyUg{VL!y(JlIu5$
> z#nmEpLu?!+^I5l3eKj_;20QFSw^%G*%hyv_y)VsopS=8BLT+u4P!d4P?~~0a7O`-6
> zd@y-|Bt+ICmffeWtgr2d`DT)2JzgPWG8Hn+%%86waRawy9wNhZTa`<>*eGJ#k#Y44
> zFE_YqMC@v0gc0k1v2Oo%5E`FtqbZEGCrfg{la073!<Ek_TX9>qzZ}jF`ql_#zKmvF
> zA3ilTa&+IL?K{-RKD*UNukO7tyf6jhPX=z^wiS=21_l?wyR}Uli<N}fS)_zl*f!mA
> zXxr|t&K5V73;nruW%e*P=iQB<V;?fiv!9l!{209G+KjP@tk`5LL9b6XVwh+4uKU4@
> z^h{&^<A>>i=i1z-ryDb%S?XldmdUW%K;NPH1#Fsj(j<oMT)Un>fyq<zE4@nbEE~^w
> znn?6aIU5PO#3%lEP8FYL`JVv0%4i@Cb_B(amD1q5E#6ZN;WU@UOy!$Ge6RFk+WPaI
> z42xlj0KX9(uw(eperOve+6}yu@cRarAKC|T275@1{fBR|^6T_jJQ~qwG5ump+kQ2%
> zjrB)yh5bRhav%G$--;{uU%LAYwrt1QL>rA3?SWz7v>(N^N$DmqIAWKY?*NxDIO5ev
> z?aDh*Y+R;=gY$P{Ayr5je5dnb!ms;nF~qcu{3r<qX~z3?I@f*szHJ=EHsud5qkM3#
> zmrErK^d0BtdpR><#Vjo1A-X_UNQv{aN4KH7_iXi&D||1rS!r(JF*-|VZ04#xc9Kq#
> z-r`OxahY%JRTFd<yL;)NSQLB47?K|a#TP|@J7zGLaj@z!Y+B;vtUNi#Pg3-Vu>S)s
> Cro3tZ
>
> literal 0
> HcmV?d00001
>
> diff --git a/tests/data/acpi/q35/DSDT.ipmibt b/tests/data/acpi/q35/DSDT.ipmibt
> index 631741065860fd5036aa303904dabd1d2839f9c6..6ad2411d0ec95f204cfc64b430c537bce09c35bd 100644
> GIT binary patch
> delta 24
> gcmZ4ExW<voCD<iojRFG$quxZWD~xg*@1K<i0AMf(82|tP
>
> delta 24
> gcmZ4ExW<voCD<iojRFG$qwYkmD~$3R@1K<i0AMQ!82|tP
>
> diff --git a/tests/data/acpi/q35/DSDT.ivrs b/tests/data/acpi/q35/DSDT.ivrs
> index b0eafe90e5832935557ec5e6802c0147c88f379c..cad26e3f0c27a40a33101155a5282ed9bcb1d441 100644
> GIT binary patch
> delta 24
> gcmez5@X3M8CD<jTNP&TYan?kxD~xg*?@yKo0BrUMn*aa+
>
> delta 24
> gcmez5@X3M8CD<jTNP&TYappv>D~$3R?@yKo0BrFHn*aa+
>
> diff --git a/tests/data/acpi/q35/DSDT.memhp b/tests/data/acpi/q35/DSDT.memhp
> index 9bc11518fc57687ca789dc70793b48b29a0d74ed..4e9cb3dc6896bb79ccac0fe342a404549f6610e8 100644
> GIT binary patch
> delta 24
> gcmdnsy}_HyCD<iogDL|9<C}?GR~Y3s-oK~<0BV~F1poj5
>
> delta 24
> gcmdnsy}_HyCD<iogDL|9<LilBR~Y3t-oK~<0BV*A1poj5
>
> diff --git a/tests/data/acpi/q35/DSDT.mmio64 b/tests/data/acpi/q35/DSDT.mmio64
> index 713288a12ef2b70a20b4e8836c036ba4db3a57a8..eb5a1c7171c02d153487bfcecfb7019b7c1bf406 100644
> GIT binary patch
> delta 24
> gcmX@@dD@f9CD<k8v<d?Q<BEw~R~Y3s-hZPE0B$h}CjbBd
>
> delta 24
> gcmX@@dD@f9CD<k8v<d?Q<MN4IR~Y3t-hZPE0B$S^CjbBd
>
> diff --git a/tests/data/acpi/q35/DSDT.multi-bridge b/tests/data/acpi/q35/DSDT.multi-bridge
> index a24c713d22102a1a1583b5c902edffe1694e5cfe..45808eb03b78d07ebbe853f674abfed589d35e26 100644
> GIT binary patch
> delta 24
> fcmZp7Zg=K#33dr-S7cyd?3>7Sg;8$f{S^uTTRaEr
>
> delta 24
> fcmZp7Zg=K#33dr-S7cyd?48JUg;9Rv{S^uTTQ>*m
>
> diff --git a/tests/data/acpi/q35/DSDT.nohpet b/tests/data/acpi/q35/DSDT.nohpet
> index e8202e6ddfbe96071f32f1ec05758f650569943e..83d1aa00ac5686df479673fb0d7830f946e25dea 100644
> GIT binary patch
> delta 24
> gcmca?f7zbPCD<k8vOEI=<B^G6R~Y3s-v1&80B=4CMF0Q*
>
> delta 24
> gcmca?f7zbPCD<k8vOEI=<Kc;1R~Y3t-v1&80B<=7MF0Q*
>
> diff --git a/tests/data/acpi/q35/DSDT.nosmm b/tests/data/acpi/q35/DSDT.nosmm
> new file mode 100644
> index 0000000000000000000000000000000000000000..c1965f6051ef2af81dd8412abe169d87845bb033
> GIT binary patch
> literal 8289
> zcmb7JOKcm*8J^`!tL0K!Qk3OaY{E(UN|8{0Bx#EVC3pF<L~6yQ;si9nrRB7;og#}k
> z2J%1vSpgEqhoT9aphr4TfZp0uuQkw1d-JUUdg`H<T#F(`4`IK5h9l3A6cF>U+JE-@
> z{(rvNo&8obUf^~51;&j3l{egaP$<9Ry9N9V#u%N`U#F3{%(}Z?xz;n%v4qjRo#y8_
> zl+FB)z4BJg`29}!c^JO+QE2odcI6A_vn&1RgFE3BMxa|)BFmx^r?Sus%DwKMYx!=Y
> zX!hz2&n`W%Ota^Tv$)wSd2MF)wi+JGug~>10ylB@26MejtHV}uu#;V~oNn`<=e{|8
> z@)w_9daHE*=l}TS-5XW{fV22(;_tbL4&i&Dbt)V>pAN1W?-QM0TOBTaI^dT@n?qNk
> zkXr89qKQ(i?%(L{z38<|F7IQ;Z}~;HxQc$c?I3&FI{DEGV>S&A{r)r>js7A|nez^F
> znx;@$G3$P%BUKvEMyk5Ib-&YOHe(OIO|wMzwnOpK%axW_@Y`Omkbk}xbV@9umN25G
> z{=1>&ghTt2LC6MSdNkT+!-Y=<efGP)&HnY@<UZTC7DeB(*20JL)Rza}vIJx3&G(+A
> z-q3h=_l`G$QjZTY%AZD8{6>2-W`&mRtSvqlmq0>w_s*}CJ%GhMilg`Fl`M1ATCN!(
> z3z=cmjH~P_{+@}UT6gcM=El|mYjH_qnO5=)jZk;*?7H7smAMn*ej6Iru`)H|?fBbq
> z(>$}wGoN)gng^UD&=}1boQLs;ab})zIOpkh$35sxdVK$Q>WD?mFwZapL)6MX8lzp`
> z4LU~pzHOPfH59lQyR8BaUZJ}iR4!r`{LQv-<I)tk<znR`E|go%wvm1yXcV~R)>gCN
> zH@sI0U8B72uCe^nzFWB%>pn@*XcX-bB6`QT#wbVk`_#P8^3RmOnT4WU5go!YHq3h|
> z-wT=x!}amhc<{pC{~cU-xB1D+*Ue*pb(<08di~eo@X5h-Has@CX2mcA-sjJejmLJx
> z_Oo&0HXYc#mErQ>x-}Q&k};NH{V2TCXKcT3`VF_r@^%k@jcA7==Qpn!^sqSY*L))T
> z?T(*YySbZ7C-8K#_10R2iE{(zRhF}<-HIWo$smrP&T^Rq`hl4waN~$r04|7YoCl~3
> ziHZCi8{<r1#}P3lG{!g+P|ie1O!S6h<D4mb5NE`c(70d%%9#j>DXU;!2`tZ(;7kck
> z2&U{jLRDu{)0yN<2~7&7>^wqMXG+tV;!Fum={garI_ET<bDGXMT_-|Sr>W^QHJzre
> z6QQaTZy;r)=QW-4x=w_uPD|5iX*w-kCqh+cTGN@<bf$Hk2vwbU7b^GD)^yssPK2t?
> zjHWZA>CEUl5vn>DG@T2Y&IMg3LRIIYrgKr#xv1+zsOoeyosOo{(RCtJb!Ii4SxskF
> z*NITonbUOUG@UtJCqh-{lBRP>)48PUM5yY_YdZ6q&b+P@p{jFP)48naT-J3WRCONF
> zbRN-k9?^9oRCVG@0#BcO53OiAS9F~SRh>sQokumDM|GVDRh`E;vowAa9^=gN_+@uY
> zFx^KXF}*SNxW+uLF^}s^gevod#yp`hPv}g9D)XeqJgG5H>P&<x^9halgvNYAXChRY
> zr#Mr(%qh;4@Ay-KDPP<Oi7D^kX|3jIt>$UHCPGougn^b61FZ!Ol;&n?;2ed=28sY>
> zMG!|Ii^4z!j$4w!h$Z`Hps0Wz7$`z14F)Q((m)j`8K{6B7$`#YMjEKVjw7n68mNFC
> z7$`#Yh+|=(0y~bz8ab2<R6u2@>V$!cw44b8RiI>`2&F5Mfg+STVW0xbnJ`cVN(L&R
> zye1haLa7r5DzKah16818paRO7WS|J8P8g`bawZH^fs%m=C})y^B9!+N1}d<e2?JH2
> zWS|1dnPi{{rA`>Az;Y%GRDqI#3Mglifg+STVW0xbnJ`cVN(L&RoJj_XQ0jz%3M^;B
> zKouw%sDN@N87M-j69y`<oCyO}pk$x|%9&)K2&GOKsK9b23{-)VfeI*Rl7S+WI$@v!
> z%b74x1xf}gpqxnticso=feI{V!ax-$8K{7ACK)I~sS^e&u$&14RiI>`0?L_Wpa`W-
> z7^uK<CJa=8l7R{+XOe*;lsaLc0?U~&Pz6c`DxjQ628vMXgn<eyXTm@gC>f}LawZul
> zLa7r5DzKah16818paRO7WS|J8P8g`bawZH^fs%m=C})y^B9uB|paRR8Fi-_b1}dPO
> zNd}5g>V$y`EN8+%6(|{~fN~}oC_<?d28u{AP(-SMB2*0&p<<v469%d<$v_n*8K}a9
> zfhtTGsKO)zRhVR;3KIsZFkzqylMGa0l7T8r7^uR8fhtTgP=!ebsxV=oh~(Xcfg-{k
> z<AX^CiV(L!hQyR(3j;+Y#})>PNRBNTC_*{5WS|JKRCK%t3uQxl!2em@r+-NArRYzo
> zd;6!)#p%CPTGgQS4#RJ6mf*OXWjeTY@Jxoam(2>DSLslrL*2|TH8!ytFr0tS+TFn-
> z%ly8T&Yy2=y6t%Y+QsaGmHs%z=J`s{JM1pCSxFol(R(}ABBL{OqK&1O^*MYal;o0!
> zjpZ6z3^LK}AbZ4G`gnoO$Kh@a?{9`TF;*|~i+mkupSpnFl=9i0*9h4AbZ+hPmPJ~R
> zVnDcU9<TI*c3|Ay8TWz8Q~S7jd7?TNPrh^YvQoXwtC!I~wR$-}yL!31*Cg#?DGkeg
> zW9?S#G0MA2d6$=WC(65rly}GFy$SIa7PP*zdQU0u@$%k8dGC<&-ne{avV7t(%2$-~
> z6<)qFQND6W`O3I_b+UZ&G0In!@>O2GI#IrQNcrlxd~LFP>M_dKl=3xRzBW<5c1Zc!
> zxO{!G{M=)duPf#2ynKD4eEpE}b(Bxgt8B8oBg)H{2R<t>-NpK?-j+}CDUUxiugB>o
> zr?HjQ)8SiVDxGMXnQm%c=Ja&<0GUcB+GeJknrB!7rg<iX;j3gSooJhxZff4-^>p}D
> znMx<xW~Q5(2g`aoe7{Vk6KyloO+D8~^mO>BnMx<xW~Q5ZPFM7F_|ln5C))IM&WT6s
> z*?WsYvy814Y^&IDtob_|FNxiWx^?-{iof5k1oA1hFgf8(8Q0$`)Zch3di~a~3U9u4
> z^Nm|?ZohVubq&{FUmHKI8Oy2}U)f*ThK*HycoHq0e`Q;C_x2AcD6xX;S6YVKXa$Db
> zZoX__0lY|us=?x}+w`!=o+D)34Jzvez`atZfVJjEt6@fr8u8ShyUg{VL!y(JlIu5$
> z#nmEpLu?!+^I5l3eKj_;20QFSw^%G*%hyv_y)VsopS=8BLT+u4P!d4P?~~0a7O`-6
> zd@y-|Bt+ICmffeWtgr2d`DT)2JzgPWG8Hn+%%86waRawy9wNhZTa`<>*eGJ#k#Y44
> zFE_YqMC@v0gc0k1v2Oo%5E`FtqbZEGCrfg{la073!<Ek_TX9>qzZ}jF`ql_#zKmvF
> zA3ilTa&+IL?K{-RKD*UNukO7tyf6jhPX=z^wiS=21_l?wyR}Uli<N}fS)_zl*f!mA
> zXxr|t&K5V73;nruW%e*P=iQB<V;?fiv!9l!{209G+KjP@tk`5LL9b6XVwh+4uKU4@
> z^h{&^<A>>i=i1z-ryDb%S?XldmdUW%K;NPH1#Fsj(j<oMT)Un>fyq<zE4@nbEE~^w
> znn?6aIU5PO#3%lEP8FYL`JVv0%4i@Cb_B(amD1q5E#6ZN;WU@UOy!$Ge6RFk+WPaI
> z42xlj0KX9(uw(eperOve+6}yu@cRarAKC|T275@1{fBR|^6T_jJQ~qwG5ump+kQ2%
> zjrB)yh5bRhav%G$--;{uU%LAYwrt1QL>rA3?SWz7v>(N^N$DmqIAWKY?*NxDIO5ev
> z?aDh*Y+R;=gY$P{Ayr5je5dnb!ms;nF~qcu{3r<qX~z3?I@f*szHJ=EHsud5qkM3#
> zmrErK^d0BtdpR><#Vjo1A-X_UNQv{aN4KH7_iXi&D||1rS!r(JF*-|VZ04#xc9Kq#
> z-r`OxahY%JRTFd<yL;)NSQLB47?K|a#TP|@J7zGLaj@z!Y+B;vtUNi#Pg3-Vu>S)s
> Cro3tZ
>
> literal 0
> HcmV?d00001
>
> diff --git a/tests/data/acpi/q35/DSDT.numamem b/tests/data/acpi/q35/DSDT.numamem
> index 151e7cf42953f3f5fe61ff0140ab7b976fe9e5b8..050aaa237b466b0bda8cca5cfaa06f84661d622e 100644
> GIT binary patch
> delta 24
> gcmaFv@Z5pRCD<h-U4emtamhrkD~xg*?{~-p0BWTOc>n+a
>
> delta 24
> gcmaFv@Z5pRCD<h-U4emtaq&d1D~$3R?{~-p0BWEJc>n+a
>
> diff --git a/tests/data/acpi/q35/DSDT.smm-compat b/tests/data/acpi/q35/DSDT.smm-compat
> new file mode 100644
> index 0000000000000000000000000000000000000000..c1965f6051ef2af81dd8412abe169d87845bb033
> GIT binary patch
> literal 8289
> zcmb7JOKcm*8J^`!tL0K!Qk3OaY{E(UN|8{0Bx#EVC3pF<L~6yQ;si9nrRB7;og#}k
> z2J%1vSpgEqhoT9aphr4TfZp0uuQkw1d-JUUdg`H<T#F(`4`IK5h9l3A6cF>U+JE-@
> z{(rvNo&8obUf^~51;&j3l{egaP$<9Ry9N9V#u%N`U#F3{%(}Z?xz;n%v4qjRo#y8_
> zl+FB)z4BJg`29}!c^JO+QE2odcI6A_vn&1RgFE3BMxa|)BFmx^r?Sus%DwKMYx!=Y
> zX!hz2&n`W%Ota^Tv$)wSd2MF)wi+JGug~>10ylB@26MejtHV}uu#;V~oNn`<=e{|8
> z@)w_9daHE*=l}TS-5XW{fV22(;_tbL4&i&Dbt)V>pAN1W?-QM0TOBTaI^dT@n?qNk
> zkXr89qKQ(i?%(L{z38<|F7IQ;Z}~;HxQc$c?I3&FI{DEGV>S&A{r)r>js7A|nez^F
> znx;@$G3$P%BUKvEMyk5Ib-&YOHe(OIO|wMzwnOpK%axW_@Y`Omkbk}xbV@9umN25G
> z{=1>&ghTt2LC6MSdNkT+!-Y=<efGP)&HnY@<UZTC7DeB(*20JL)Rza}vIJx3&G(+A
> z-q3h=_l`G$QjZTY%AZD8{6>2-W`&mRtSvqlmq0>w_s*}CJ%GhMilg`Fl`M1ATCN!(
> z3z=cmjH~P_{+@}UT6gcM=El|mYjH_qnO5=)jZk;*?7H7smAMn*ej6Iru`)H|?fBbq
> z(>$}wGoN)gng^UD&=}1boQLs;ab})zIOpkh$35sxdVK$Q>WD?mFwZapL)6MX8lzp`
> z4LU~pzHOPfH59lQyR8BaUZJ}iR4!r`{LQv-<I)tk<znR`E|go%wvm1yXcV~R)>gCN
> zH@sI0U8B72uCe^nzFWB%>pn@*XcX-bB6`QT#wbVk`_#P8^3RmOnT4WU5go!YHq3h|
> z-wT=x!}amhc<{pC{~cU-xB1D+*Ue*pb(<08di~eo@X5h-Has@CX2mcA-sjJejmLJx
> z_Oo&0HXYc#mErQ>x-}Q&k};NH{V2TCXKcT3`VF_r@^%k@jcA7==Qpn!^sqSY*L))T
> z?T(*YySbZ7C-8K#_10R2iE{(zRhF}<-HIWo$smrP&T^Rq`hl4waN~$r04|7YoCl~3
> ziHZCi8{<r1#}P3lG{!g+P|ie1O!S6h<D4mb5NE`c(70d%%9#j>DXU;!2`tZ(;7kck
> z2&U{jLRDu{)0yN<2~7&7>^wqMXG+tV;!Fum={garI_ET<bDGXMT_-|Sr>W^QHJzre
> z6QQaTZy;r)=QW-4x=w_uPD|5iX*w-kCqh+cTGN@<bf$Hk2vwbU7b^GD)^yssPK2t?
> zjHWZA>CEUl5vn>DG@T2Y&IMg3LRIIYrgKr#xv1+zsOoeyosOo{(RCtJb!Ii4SxskF
> z*NITonbUOUG@UtJCqh-{lBRP>)48PUM5yY_YdZ6q&b+P@p{jFP)48naT-J3WRCONF
> zbRN-k9?^9oRCVG@0#BcO53OiAS9F~SRh>sQokumDM|GVDRh`E;vowAa9^=gN_+@uY
> zFx^KXF}*SNxW+uLF^}s^gevod#yp`hPv}g9D)XeqJgG5H>P&<x^9halgvNYAXChRY
> zr#Mr(%qh;4@Ay-KDPP<Oi7D^kX|3jIt>$UHCPGougn^b61FZ!Ol;&n?;2ed=28sY>
> zMG!|Ii^4z!j$4w!h$Z`Hps0Wz7$`z14F)Q((m)j`8K{6B7$`#YMjEKVjw7n68mNFC
> z7$`#Yh+|=(0y~bz8ab2<R6u2@>V$!cw44b8RiI>`2&F5Mfg+STVW0xbnJ`cVN(L&R
> zye1haLa7r5DzKah16818paRO7WS|J8P8g`bawZH^fs%m=C})y^B9!+N1}d<e2?JH2
> zWS|1dnPi{{rA`>Az;Y%GRDqI#3Mglifg+STVW0xbnJ`cVN(L&RoJj_XQ0jz%3M^;B
> zKouw%sDN@N87M-j69y`<oCyO}pk$x|%9&)K2&GOKsK9b23{-)VfeI*Rl7S+WI$@v!
> z%b74x1xf}gpqxnticso=feI{V!ax-$8K{7ACK)I~sS^e&u$&14RiI>`0?L_Wpa`W-
> z7^uK<CJa=8l7R{+XOe*;lsaLc0?U~&Pz6c`DxjQ628vMXgn<eyXTm@gC>f}LawZul
> zLa7r5DzKah16818paRO7WS|J8P8g`bawZH^fs%m=C})y^B9uB|paRR8Fi-_b1}dPO
> zNd}5g>V$y`EN8+%6(|{~fN~}oC_<?d28u{AP(-SMB2*0&p<<v469%d<$v_n*8K}a9
> zfhtTGsKO)zRhVR;3KIsZFkzqylMGa0l7T8r7^uR8fhtTgP=!ebsxV=oh~(Xcfg-{k
> z<AX^CiV(L!hQyR(3j;+Y#})>PNRBNTC_*{5WS|JKRCK%t3uQxl!2em@r+-NArRYzo
> zd;6!)#p%CPTGgQS4#RJ6mf*OXWjeTY@Jxoam(2>DSLslrL*2|TH8!ytFr0tS+TFn-
> z%ly8T&Yy2=y6t%Y+QsaGmHs%z=J`s{JM1pCSxFol(R(}ABBL{OqK&1O^*MYal;o0!
> zjpZ6z3^LK}AbZ4G`gnoO$Kh@a?{9`TF;*|~i+mkupSpnFl=9i0*9h4AbZ+hPmPJ~R
> zVnDcU9<TI*c3|Ay8TWz8Q~S7jd7?TNPrh^YvQoXwtC!I~wR$-}yL!31*Cg#?DGkeg
> zW9?S#G0MA2d6$=WC(65rly}GFy$SIa7PP*zdQU0u@$%k8dGC<&-ne{avV7t(%2$-~
> z6<)qFQND6W`O3I_b+UZ&G0In!@>O2GI#IrQNcrlxd~LFP>M_dKl=3xRzBW<5c1Zc!
> zxO{!G{M=)duPf#2ynKD4eEpE}b(Bxgt8B8oBg)H{2R<t>-NpK?-j+}CDUUxiugB>o
> zr?HjQ)8SiVDxGMXnQm%c=Ja&<0GUcB+GeJknrB!7rg<iX;j3gSooJhxZff4-^>p}D
> znMx<xW~Q5(2g`aoe7{Vk6KyloO+D8~^mO>BnMx<xW~Q5ZPFM7F_|ln5C))IM&WT6s
> z*?WsYvy814Y^&IDtob_|FNxiWx^?-{iof5k1oA1hFgf8(8Q0$`)Zch3di~a~3U9u4
> z^Nm|?ZohVubq&{FUmHKI8Oy2}U)f*ThK*HycoHq0e`Q;C_x2AcD6xX;S6YVKXa$Db
> zZoX__0lY|us=?x}+w`!=o+D)34Jzvez`atZfVJjEt6@fr8u8ShyUg{VL!y(JlIu5$
> z#nmEpLu?!+^I5l3eKj_;20QFSw^%G*%hyv_y)VsopS=8BLT+u4P!d4P?~~0a7O`-6
> zd@y-|Bt+ICmffeWtgr2d`DT)2JzgPWG8Hn+%%86waRawy9wNhZTa`<>*eGJ#k#Y44
> zFE_YqMC@v0gc0k1v2Oo%5E`FtqbZEGCrfg{la073!<Ek_TX9>qzZ}jF`ql_#zKmvF
> zA3ilTa&+IL?K{-RKD*UNukO7tyf6jhPX=z^wiS=21_l?wyR}Uli<N}fS)_zl*f!mA
> zXxr|t&K5V73;nruW%e*P=iQB<V;?fiv!9l!{209G+KjP@tk`5LL9b6XVwh+4uKU4@
> z^h{&^<A>>i=i1z-ryDb%S?XldmdUW%K;NPH1#Fsj(j<oMT)Un>fyq<zE4@nbEE~^w
> znn?6aIU5PO#3%lEP8FYL`JVv0%4i@Cb_B(amD1q5E#6ZN;WU@UOy!$Ge6RFk+WPaI
> z42xlj0KX9(uw(eperOve+6}yu@cRarAKC|T275@1{fBR|^6T_jJQ~qwG5ump+kQ2%
> zjrB)yh5bRhav%G$--;{uU%LAYwrt1QL>rA3?SWz7v>(N^N$DmqIAWKY?*NxDIO5ev
> z?aDh*Y+R;=gY$P{Ayr5je5dnb!ms;nF~qcu{3r<qX~z3?I@f*szHJ=EHsud5qkM3#
> zmrErK^d0BtdpR><#Vjo1A-X_UNQv{aN4KH7_iXi&D||1rS!r(JF*-|VZ04#xc9Kq#
> z-r`OxahY%JRTFd<yL;)NSQLB47?K|a#TP|@J7zGLaj@z!Y+B;vtUNi#Pg3-Vu>S)s
> Cro3tZ
>
> literal 0
> HcmV?d00001
>
> diff --git a/tests/data/acpi/q35/DSDT.smm-compat-nosmm b/tests/data/acpi/q35/DSDT.smm-compat-nosmm
> new file mode 100644
> index 0000000000000000000000000000000000000000..c1965f6051ef2af81dd8412abe169d87845bb033
> GIT binary patch
> literal 8289
> zcmb7JOKcm*8J^`!tL0K!Qk3OaY{E(UN|8{0Bx#EVC3pF<L~6yQ;si9nrRB7;og#}k
> z2J%1vSpgEqhoT9aphr4TfZp0uuQkw1d-JUUdg`H<T#F(`4`IK5h9l3A6cF>U+JE-@
> z{(rvNo&8obUf^~51;&j3l{egaP$<9Ry9N9V#u%N`U#F3{%(}Z?xz;n%v4qjRo#y8_
> zl+FB)z4BJg`29}!c^JO+QE2odcI6A_vn&1RgFE3BMxa|)BFmx^r?Sus%DwKMYx!=Y
> zX!hz2&n`W%Ota^Tv$)wSd2MF)wi+JGug~>10ylB@26MejtHV}uu#;V~oNn`<=e{|8
> z@)w_9daHE*=l}TS-5XW{fV22(;_tbL4&i&Dbt)V>pAN1W?-QM0TOBTaI^dT@n?qNk
> zkXr89qKQ(i?%(L{z38<|F7IQ;Z}~;HxQc$c?I3&FI{DEGV>S&A{r)r>js7A|nez^F
> znx;@$G3$P%BUKvEMyk5Ib-&YOHe(OIO|wMzwnOpK%axW_@Y`Omkbk}xbV@9umN25G
> z{=1>&ghTt2LC6MSdNkT+!-Y=<efGP)&HnY@<UZTC7DeB(*20JL)Rza}vIJx3&G(+A
> z-q3h=_l`G$QjZTY%AZD8{6>2-W`&mRtSvqlmq0>w_s*}CJ%GhMilg`Fl`M1ATCN!(
> z3z=cmjH~P_{+@}UT6gcM=El|mYjH_qnO5=)jZk;*?7H7smAMn*ej6Iru`)H|?fBbq
> z(>$}wGoN)gng^UD&=}1boQLs;ab})zIOpkh$35sxdVK$Q>WD?mFwZapL)6MX8lzp`
> z4LU~pzHOPfH59lQyR8BaUZJ}iR4!r`{LQv-<I)tk<znR`E|go%wvm1yXcV~R)>gCN
> zH@sI0U8B72uCe^nzFWB%>pn@*XcX-bB6`QT#wbVk`_#P8^3RmOnT4WU5go!YHq3h|
> z-wT=x!}amhc<{pC{~cU-xB1D+*Ue*pb(<08di~eo@X5h-Has@CX2mcA-sjJejmLJx
> z_Oo&0HXYc#mErQ>x-}Q&k};NH{V2TCXKcT3`VF_r@^%k@jcA7==Qpn!^sqSY*L))T
> z?T(*YySbZ7C-8K#_10R2iE{(zRhF}<-HIWo$smrP&T^Rq`hl4waN~$r04|7YoCl~3
> ziHZCi8{<r1#}P3lG{!g+P|ie1O!S6h<D4mb5NE`c(70d%%9#j>DXU;!2`tZ(;7kck
> z2&U{jLRDu{)0yN<2~7&7>^wqMXG+tV;!Fum={garI_ET<bDGXMT_-|Sr>W^QHJzre
> z6QQaTZy;r)=QW-4x=w_uPD|5iX*w-kCqh+cTGN@<bf$Hk2vwbU7b^GD)^yssPK2t?
> zjHWZA>CEUl5vn>DG@T2Y&IMg3LRIIYrgKr#xv1+zsOoeyosOo{(RCtJb!Ii4SxskF
> z*NITonbUOUG@UtJCqh-{lBRP>)48PUM5yY_YdZ6q&b+P@p{jFP)48naT-J3WRCONF
> zbRN-k9?^9oRCVG@0#BcO53OiAS9F~SRh>sQokumDM|GVDRh`E;vowAa9^=gN_+@uY
> zFx^KXF}*SNxW+uLF^}s^gevod#yp`hPv}g9D)XeqJgG5H>P&<x^9halgvNYAXChRY
> zr#Mr(%qh;4@Ay-KDPP<Oi7D^kX|3jIt>$UHCPGougn^b61FZ!Ol;&n?;2ed=28sY>
> zMG!|Ii^4z!j$4w!h$Z`Hps0Wz7$`z14F)Q((m)j`8K{6B7$`#YMjEKVjw7n68mNFC
> z7$`#Yh+|=(0y~bz8ab2<R6u2@>V$!cw44b8RiI>`2&F5Mfg+STVW0xbnJ`cVN(L&R
> zye1haLa7r5DzKah16818paRO7WS|J8P8g`bawZH^fs%m=C})y^B9!+N1}d<e2?JH2
> zWS|1dnPi{{rA`>Az;Y%GRDqI#3Mglifg+STVW0xbnJ`cVN(L&RoJj_XQ0jz%3M^;B
> zKouw%sDN@N87M-j69y`<oCyO}pk$x|%9&)K2&GOKsK9b23{-)VfeI*Rl7S+WI$@v!
> z%b74x1xf}gpqxnticso=feI{V!ax-$8K{7ACK)I~sS^e&u$&14RiI>`0?L_Wpa`W-
> z7^uK<CJa=8l7R{+XOe*;lsaLc0?U~&Pz6c`DxjQ628vMXgn<eyXTm@gC>f}LawZul
> zLa7r5DzKah16818paRO7WS|J8P8g`bawZH^fs%m=C})y^B9uB|paRR8Fi-_b1}dPO
> zNd}5g>V$y`EN8+%6(|{~fN~}oC_<?d28u{AP(-SMB2*0&p<<v469%d<$v_n*8K}a9
> zfhtTGsKO)zRhVR;3KIsZFkzqylMGa0l7T8r7^uR8fhtTgP=!ebsxV=oh~(Xcfg-{k
> z<AX^CiV(L!hQyR(3j;+Y#})>PNRBNTC_*{5WS|JKRCK%t3uQxl!2em@r+-NArRYzo
> zd;6!)#p%CPTGgQS4#RJ6mf*OXWjeTY@Jxoam(2>DSLslrL*2|TH8!ytFr0tS+TFn-
> z%ly8T&Yy2=y6t%Y+QsaGmHs%z=J`s{JM1pCSxFol(R(}ABBL{OqK&1O^*MYal;o0!
> zjpZ6z3^LK}AbZ4G`gnoO$Kh@a?{9`TF;*|~i+mkupSpnFl=9i0*9h4AbZ+hPmPJ~R
> zVnDcU9<TI*c3|Ay8TWz8Q~S7jd7?TNPrh^YvQoXwtC!I~wR$-}yL!31*Cg#?DGkeg
> zW9?S#G0MA2d6$=WC(65rly}GFy$SIa7PP*zdQU0u@$%k8dGC<&-ne{avV7t(%2$-~
> z6<)qFQND6W`O3I_b+UZ&G0In!@>O2GI#IrQNcrlxd~LFP>M_dKl=3xRzBW<5c1Zc!
> zxO{!G{M=)duPf#2ynKD4eEpE}b(Bxgt8B8oBg)H{2R<t>-NpK?-j+}CDUUxiugB>o
> zr?HjQ)8SiVDxGMXnQm%c=Ja&<0GUcB+GeJknrB!7rg<iX;j3gSooJhxZff4-^>p}D
> znMx<xW~Q5(2g`aoe7{Vk6KyloO+D8~^mO>BnMx<xW~Q5ZPFM7F_|ln5C))IM&WT6s
> z*?WsYvy814Y^&IDtob_|FNxiWx^?-{iof5k1oA1hFgf8(8Q0$`)Zch3di~a~3U9u4
> z^Nm|?ZohVubq&{FUmHKI8Oy2}U)f*ThK*HycoHq0e`Q;C_x2AcD6xX;S6YVKXa$Db
> zZoX__0lY|us=?x}+w`!=o+D)34Jzvez`atZfVJjEt6@fr8u8ShyUg{VL!y(JlIu5$
> z#nmEpLu?!+^I5l3eKj_;20QFSw^%G*%hyv_y)VsopS=8BLT+u4P!d4P?~~0a7O`-6
> zd@y-|Bt+ICmffeWtgr2d`DT)2JzgPWG8Hn+%%86waRawy9wNhZTa`<>*eGJ#k#Y44
> zFE_YqMC@v0gc0k1v2Oo%5E`FtqbZEGCrfg{la073!<Ek_TX9>qzZ}jF`ql_#zKmvF
> zA3ilTa&+IL?K{-RKD*UNukO7tyf6jhPX=z^wiS=21_l?wyR}Uli<N}fS)_zl*f!mA
> zXxr|t&K5V73;nruW%e*P=iQB<V;?fiv!9l!{209G+KjP@tk`5LL9b6XVwh+4uKU4@
> z^h{&^<A>>i=i1z-ryDb%S?XldmdUW%K;NPH1#Fsj(j<oMT)Un>fyq<zE4@nbEE~^w
> znn?6aIU5PO#3%lEP8FYL`JVv0%4i@Cb_B(amD1q5E#6ZN;WU@UOy!$Ge6RFk+WPaI
> z42xlj0KX9(uw(eperOve+6}yu@cRarAKC|T275@1{fBR|^6T_jJQ~qwG5ump+kQ2%
> zjrB)yh5bRhav%G$--;{uU%LAYwrt1QL>rA3?SWz7v>(N^N$DmqIAWKY?*NxDIO5ev
> z?aDh*Y+R;=gY$P{Ayr5je5dnb!ms;nF~qcu{3r<qX~z3?I@f*szHJ=EHsud5qkM3#
> zmrErK^d0BtdpR><#Vjo1A-X_UNQv{aN4KH7_iXi&D||1rS!r(JF*-|VZ04#xc9Kq#
> z-r`OxahY%JRTFd<yL;)NSQLB47?K|a#TP|@J7zGLaj@z!Y+B;vtUNi#Pg3-Vu>S)s
> Cro3tZ
>
> literal 0
> HcmV?d00001
>
> diff --git a/tests/data/acpi/q35/DSDT.tis.tpm12 b/tests/data/acpi/q35/DSDT.tis.tpm12
> index c96b5277a14ae98174408d690d6e0246bd932623..0ebdf6fbd77967f1ab5d5337b7b1fed314cfaca8 100644
> GIT binary patch
> delta 24
> gcmdnzy3du%CD<iopArKDqxwXyD~xg*@84Gh0A(f!W&i*H
>
> delta 24
> gcmdnzy3du%CD<iopArKDquNBSD~$3R@84Gh0A(QvW&i*H
>
> diff --git a/tests/data/acpi/q35/DSDT.tis.tpm2 b/tests/data/acpi/q35/DSDT.tis.tpm2
> index c92d4d29c79352a60974ea9f665d0b9a410a4bac..dcbb7f0af377425db53130e8ba1c62c09c22e006 100644
> GIT binary patch
> delta 24
> gcmdnzy3du%CD<iopArKD<D-dOR~Y3s-oLL10Bm##ApigX
>
> delta 24
> gcmdnzy3du%CD<iopArKD<HLzuR~Y3t-oLL10BmmwApigX
>
> diff --git a/tests/data/acpi/q35/DSDT.xapic b/tests/data/acpi/q35/DSDT.xapic
> index 119fc90f1f8a7b6934df6fd95609446e627ce15d..17552ce363ae81985f69f9ae85837a1540b79ae0 100644
> GIT binary patch
> delta 26
> icmX>yjp@iVCN7s?mk^h31_s6r6S=N1%5A)#+64f6_X&Rh
>
> delta 26
> icmX>yjp@iVCN7s?mk^h31_s9U6S=N1%5S`%+64f6@(F(c
>
> --
> 2.27.0
>
>
^ permalink raw reply [flat|nested] 24+ messages in thread
* Re: [PATCH for 6.2 v2 3/5] bios-tables-test: Allow changes in DSDT ACPI tables
2021-11-10 21:11 ` [PATCH for 6.2 v2 3/5] bios-tables-test: Allow changes in DSDT ACPI tables Igor Mammedov
@ 2021-11-11 5:55 ` Ani Sinha
0 siblings, 0 replies; 24+ messages in thread
From: Ani Sinha @ 2021-11-11 5:55 UTC (permalink / raw)
To: Igor Mammedov; +Cc: mapfelba, mst, jusual, qemu-devel, kraxel, ani
On Wed, 10 Nov 2021, Igor Mammedov wrote:
> From: Julia Suvorova <jusual@redhat.com>
>
> Prepare for changing the _OSC method in q35 DSDT.
>
> Signed-off-by: Julia Suvorova <jusual@redhat.com>
> Signed-off-by: Igor Mammedov <imammedo@redhat.com>
Acked-by: Ani Sinha <ani@anisinha.ca>
> ---
> tests/qtest/bios-tables-test-allowed-diff.h | 16 ++++++++++++++++
> 1 file changed, 16 insertions(+)
>
> diff --git a/tests/qtest/bios-tables-test-allowed-diff.h b/tests/qtest/bios-tables-test-allowed-diff.h
> index dfb8523c8b..48e5634d4b 100644
> --- a/tests/qtest/bios-tables-test-allowed-diff.h
> +++ b/tests/qtest/bios-tables-test-allowed-diff.h
> @@ -1 +1,17 @@
> /* List of comma-separated changed AML files to ignore */
> +"tests/data/acpi/q35/DSDT",
> +"tests/data/acpi/q35/DSDT.tis",
> +"tests/data/acpi/q35/DSDT.bridge",
> +"tests/data/acpi/q35/DSDT.mmio64",
> +"tests/data/acpi/q35/DSDT.ipmibt",
> +"tests/data/acpi/q35/DSDT.cphp",
> +"tests/data/acpi/q35/DSDT.memhp",
> +"tests/data/acpi/q35/DSDT.acpihmat",
> +"tests/data/acpi/q35/DSDT.numamem",
> +"tests/data/acpi/q35/DSDT.dimmpxm",
> +"tests/data/acpi/q35/DSDT.nohpet",
> +"tests/data/acpi/q35/DSDT.tis.tpm2",
> +"tests/data/acpi/q35/DSDT.tis.tpm12",
> +"tests/data/acpi/q35/DSDT.multi-bridge",
> +"tests/data/acpi/q35/DSDT.ivrs",
> +"tests/data/acpi/q35/DSDT.xapic",
> --
> 2.27.0
>
>
^ permalink raw reply [flat|nested] 24+ messages in thread
* Re: [PATCH for 6.2 v2 5/5] bios-tables-test: Update golden binaries
2021-11-10 21:11 ` [PATCH for 6.2 v2 5/5] bios-tables-test: Update golden binaries Igor Mammedov
2021-11-11 5:51 ` Ani Sinha
@ 2021-11-11 8:34 ` Michael S. Tsirkin
2021-11-11 9:27 ` Ani Sinha
2021-11-11 11:32 ` Igor Mammedov
1 sibling, 2 replies; 24+ messages in thread
From: Michael S. Tsirkin @ 2021-11-11 8:34 UTC (permalink / raw)
To: Igor Mammedov; +Cc: ani, mapfelba, jusual, qemu-devel, kraxel
On Wed, Nov 10, 2021 at 04:11:40PM -0500, Igor Mammedov wrote:
> From: Julia Suvorova <jusual@redhat.com>
>
> The changes are the result of
> 'hw/i386/acpi-build: Deny control on PCIe Native Hot-Plug in _OSC'
> and listed here:
>
> Method (_OSC, 4, NotSerialized) // _OSC: Operating System Capabilities
> {
> CreateDWordField (Arg3, Zero, CDW1)
> If ((Arg0 == ToUUID ("33db4d5b-1ff7-401c-9657-7441c03dd766") /* PCI Host Bridge Device */))
> {
> CreateDWordField (Arg3, 0x04, CDW2)
> CreateDWordField (Arg3, 0x08, CDW3)
> Local0 = CDW3 /* \_SB_.PCI0._OSC.CDW3 */
> - Local0 &= 0x1F
> + Local0 &= 0x1E
>
> Signed-off-by: Julia Suvorova <jusual@redhat.com>
> Signed-off-by: Igor Mammedov <imammedo@redhat.com>
> ---
> tests/qtest/bios-tables-test-allowed-diff.h | 16 ----------------
> tests/data/acpi/q35/DSDT | Bin 8289 -> 8289 bytes
> tests/data/acpi/q35/DSDT.acpihmat | Bin 9614 -> 9614 bytes
> tests/data/acpi/q35/DSDT.bridge | Bin 11003 -> 11003 bytes
> tests/data/acpi/q35/DSDT.cphp | Bin 8753 -> 8753 bytes
> tests/data/acpi/q35/DSDT.dimmpxm | Bin 9943 -> 9943 bytes
> tests/data/acpi/q35/DSDT.dmar | Bin 0 -> 8289 bytes
> tests/data/acpi/q35/DSDT.ipmibt | Bin 8364 -> 8364 bytes
> tests/data/acpi/q35/DSDT.ivrs | Bin 8306 -> 8306 bytes
> tests/data/acpi/q35/DSDT.memhp | Bin 9648 -> 9648 bytes
> tests/data/acpi/q35/DSDT.mmio64 | Bin 9419 -> 9419 bytes
> tests/data/acpi/q35/DSDT.multi-bridge | Bin 8583 -> 8583 bytes
> tests/data/acpi/q35/DSDT.nohpet | Bin 8147 -> 8147 bytes
> tests/data/acpi/q35/DSDT.nosmm | Bin 0 -> 8289 bytes
> tests/data/acpi/q35/DSDT.numamem | Bin 8295 -> 8295 bytes
> tests/data/acpi/q35/DSDT.smm-compat | Bin 0 -> 8289 bytes
> tests/data/acpi/q35/DSDT.smm-compat-nosmm | Bin 0 -> 8289 bytes
> tests/data/acpi/q35/DSDT.tis.tpm12 | Bin 8894 -> 8894 bytes
> tests/data/acpi/q35/DSDT.tis.tpm2 | Bin 8894 -> 8894 bytes
> tests/data/acpi/q35/DSDT.xapic | Bin 35652 -> 35652 bytes
Why do we have all the new files? What is going on here?
> 20 files changed, 16 deletions(-)
> create mode 100644 tests/data/acpi/q35/DSDT.dmar
> create mode 100644 tests/data/acpi/q35/DSDT.nosmm
> create mode 100644 tests/data/acpi/q35/DSDT.smm-compat
> create mode 100644 tests/data/acpi/q35/DSDT.smm-compat-nosmm
>
> diff --git a/tests/qtest/bios-tables-test-allowed-diff.h b/tests/qtest/bios-tables-test-allowed-diff.h
> index 48e5634d4b..dfb8523c8b 100644
> --- a/tests/qtest/bios-tables-test-allowed-diff.h
> +++ b/tests/qtest/bios-tables-test-allowed-diff.h
> @@ -1,17 +1 @@
> /* List of comma-separated changed AML files to ignore */
> -"tests/data/acpi/q35/DSDT",
> -"tests/data/acpi/q35/DSDT.tis",
> -"tests/data/acpi/q35/DSDT.bridge",
> -"tests/data/acpi/q35/DSDT.mmio64",
> -"tests/data/acpi/q35/DSDT.ipmibt",
> -"tests/data/acpi/q35/DSDT.cphp",
> -"tests/data/acpi/q35/DSDT.memhp",
> -"tests/data/acpi/q35/DSDT.acpihmat",
> -"tests/data/acpi/q35/DSDT.numamem",
> -"tests/data/acpi/q35/DSDT.dimmpxm",
> -"tests/data/acpi/q35/DSDT.nohpet",
> -"tests/data/acpi/q35/DSDT.tis.tpm2",
> -"tests/data/acpi/q35/DSDT.tis.tpm12",
> -"tests/data/acpi/q35/DSDT.multi-bridge",
> -"tests/data/acpi/q35/DSDT.ivrs",
> -"tests/data/acpi/q35/DSDT.xapic",
> diff --git a/tests/data/acpi/q35/DSDT b/tests/data/acpi/q35/DSDT
> index 281fc82c03b2562d2e6b7caec0d817b034a47138..c1965f6051ef2af81dd8412abe169d87845bb033 100644
> GIT binary patch
> delta 24
> gcmaFp@X&$FCD<h-QGtPh@z+GID~xg*?>ET<0BnZ{w*UYD
>
> delta 24
> gcmaFp@X&$FCD<h-QGtPh@#jRYD~$3R?>ET<0BnK?w*UYD
>
> diff --git a/tests/data/acpi/q35/DSDT.acpihmat b/tests/data/acpi/q35/DSDT.acpihmat
> index 8c1e05a11a328ec1cc6f86e36e52c28f41f9744e..f24d4874bff8d327a165ed7c36de507aea114edd 100644
> GIT binary patch
> delta 24
> fcmeD4?(^ny33dtTQ)OUa+&+=(3ZvY{`|DKzU@Hhn
>
> delta 24
> fcmeD4?(^ny33dtTQ)OUa+%}Qx3ZwkS`|DKzU?vDi
>
> diff --git a/tests/data/acpi/q35/DSDT.bridge b/tests/data/acpi/q35/DSDT.bridge
> index 6f1464b6c712d7f33cb4b891b7ce76fe228f44c9..424d51bd1cb39ea73501ef7d0044ee52cec5bdac 100644
> GIT binary patch
> delta 24
> gcmewz`a6`%CD<k8w-y5fBg;gtD~xg*@5^Wb0CWThXaE2J
>
> delta 24
> gcmewz`a6`%CD<k8w-y5fBlASAD~$3R@5^Wb0CWEcXaE2J
>
> diff --git a/tests/data/acpi/q35/DSDT.cphp b/tests/data/acpi/q35/DSDT.cphp
> index f8337ff5191a37a47dcf7c09a6c39c4e704a15bf..f1275606f68eeba54bfb11e63d818420385a62b9 100644
> GIT binary patch
> delta 24
> fcmdn!veAXhCD<jzP>F$oF>WH)6-K#@_k$DxTWtqt
>
> delta 24
> fcmdn!veAXhCD<jzP>F$oF?J%?6-N1u_k$DxTWAMo
>
> diff --git a/tests/data/acpi/q35/DSDT.dimmpxm b/tests/data/acpi/q35/DSDT.dimmpxm
> index fe5820d93d057ef09a001662369b15afbc5b87e2..76e451e829ec4c245315f7eed8731aa1be45a747 100644
> GIT binary patch
> delta 24
> gcmccad)=4ICD<k8x*7umqsK(9D~xg*@BdH*0B$o00{{R3
>
> delta 24
> gcmccad)=4ICD<k8x*7umqx(dzD~$3R@BdH*0B$Y`0{{R3
>
> diff --git a/tests/data/acpi/q35/DSDT.dmar b/tests/data/acpi/q35/DSDT.dmar
> new file mode 100644
> index 0000000000000000000000000000000000000000..c1965f6051ef2af81dd8412abe169d87845bb033
> GIT binary patch
> literal 8289
> zcmb7JOKcm*8J^`!tL0K!Qk3OaY{E(UN|8{0Bx#EVC3pF<L~6yQ;si9nrRB7;og#}k
> z2J%1vSpgEqhoT9aphr4TfZp0uuQkw1d-JUUdg`H<T#F(`4`IK5h9l3A6cF>U+JE-@
> z{(rvNo&8obUf^~51;&j3l{egaP$<9Ry9N9V#u%N`U#F3{%(}Z?xz;n%v4qjRo#y8_
> zl+FB)z4BJg`29}!c^JO+QE2odcI6A_vn&1RgFE3BMxa|)BFmx^r?Sus%DwKMYx!=Y
> zX!hz2&n`W%Ota^Tv$)wSd2MF)wi+JGug~>10ylB@26MejtHV}uu#;V~oNn`<=e{|8
> z@)w_9daHE*=l}TS-5XW{fV22(;_tbL4&i&Dbt)V>pAN1W?-QM0TOBTaI^dT@n?qNk
> zkXr89qKQ(i?%(L{z38<|F7IQ;Z}~;HxQc$c?I3&FI{DEGV>S&A{r)r>js7A|nez^F
> znx;@$G3$P%BUKvEMyk5Ib-&YOHe(OIO|wMzwnOpK%axW_@Y`Omkbk}xbV@9umN25G
> z{=1>&ghTt2LC6MSdNkT+!-Y=<efGP)&HnY@<UZTC7DeB(*20JL)Rza}vIJx3&G(+A
> z-q3h=_l`G$QjZTY%AZD8{6>2-W`&mRtSvqlmq0>w_s*}CJ%GhMilg`Fl`M1ATCN!(
> z3z=cmjH~P_{+@}UT6gcM=El|mYjH_qnO5=)jZk;*?7H7smAMn*ej6Iru`)H|?fBbq
> z(>$}wGoN)gng^UD&=}1boQLs;ab})zIOpkh$35sxdVK$Q>WD?mFwZapL)6MX8lzp`
> z4LU~pzHOPfH59lQyR8BaUZJ}iR4!r`{LQv-<I)tk<znR`E|go%wvm1yXcV~R)>gCN
> zH@sI0U8B72uCe^nzFWB%>pn@*XcX-bB6`QT#wbVk`_#P8^3RmOnT4WU5go!YHq3h|
> z-wT=x!}amhc<{pC{~cU-xB1D+*Ue*pb(<08di~eo@X5h-Has@CX2mcA-sjJejmLJx
> z_Oo&0HXYc#mErQ>x-}Q&k};NH{V2TCXKcT3`VF_r@^%k@jcA7==Qpn!^sqSY*L))T
> z?T(*YySbZ7C-8K#_10R2iE{(zRhF}<-HIWo$smrP&T^Rq`hl4waN~$r04|7YoCl~3
> ziHZCi8{<r1#}P3lG{!g+P|ie1O!S6h<D4mb5NE`c(70d%%9#j>DXU;!2`tZ(;7kck
> z2&U{jLRDu{)0yN<2~7&7>^wqMXG+tV;!Fum={garI_ET<bDGXMT_-|Sr>W^QHJzre
> z6QQaTZy;r)=QW-4x=w_uPD|5iX*w-kCqh+cTGN@<bf$Hk2vwbU7b^GD)^yssPK2t?
> zjHWZA>CEUl5vn>DG@T2Y&IMg3LRIIYrgKr#xv1+zsOoeyosOo{(RCtJb!Ii4SxskF
> z*NITonbUOUG@UtJCqh-{lBRP>)48PUM5yY_YdZ6q&b+P@p{jFP)48naT-J3WRCONF
> zbRN-k9?^9oRCVG@0#BcO53OiAS9F~SRh>sQokumDM|GVDRh`E;vowAa9^=gN_+@uY
> zFx^KXF}*SNxW+uLF^}s^gevod#yp`hPv}g9D)XeqJgG5H>P&<x^9halgvNYAXChRY
> zr#Mr(%qh;4@Ay-KDPP<Oi7D^kX|3jIt>$UHCPGougn^b61FZ!Ol;&n?;2ed=28sY>
> zMG!|Ii^4z!j$4w!h$Z`Hps0Wz7$`z14F)Q((m)j`8K{6B7$`#YMjEKVjw7n68mNFC
> z7$`#Yh+|=(0y~bz8ab2<R6u2@>V$!cw44b8RiI>`2&F5Mfg+STVW0xbnJ`cVN(L&R
> zye1haLa7r5DzKah16818paRO7WS|J8P8g`bawZH^fs%m=C})y^B9!+N1}d<e2?JH2
> zWS|1dnPi{{rA`>Az;Y%GRDqI#3Mglifg+STVW0xbnJ`cVN(L&RoJj_XQ0jz%3M^;B
> zKouw%sDN@N87M-j69y`<oCyO}pk$x|%9&)K2&GOKsK9b23{-)VfeI*Rl7S+WI$@v!
> z%b74x1xf}gpqxnticso=feI{V!ax-$8K{7ACK)I~sS^e&u$&14RiI>`0?L_Wpa`W-
> z7^uK<CJa=8l7R{+XOe*;lsaLc0?U~&Pz6c`DxjQ628vMXgn<eyXTm@gC>f}LawZul
> zLa7r5DzKah16818paRO7WS|J8P8g`bawZH^fs%m=C})y^B9uB|paRR8Fi-_b1}dPO
> zNd}5g>V$y`EN8+%6(|{~fN~}oC_<?d28u{AP(-SMB2*0&p<<v469%d<$v_n*8K}a9
> zfhtTGsKO)zRhVR;3KIsZFkzqylMGa0l7T8r7^uR8fhtTgP=!ebsxV=oh~(Xcfg-{k
> z<AX^CiV(L!hQyR(3j;+Y#})>PNRBNTC_*{5WS|JKRCK%t3uQxl!2em@r+-NArRYzo
> zd;6!)#p%CPTGgQS4#RJ6mf*OXWjeTY@Jxoam(2>DSLslrL*2|TH8!ytFr0tS+TFn-
> z%ly8T&Yy2=y6t%Y+QsaGmHs%z=J`s{JM1pCSxFol(R(}ABBL{OqK&1O^*MYal;o0!
> zjpZ6z3^LK}AbZ4G`gnoO$Kh@a?{9`TF;*|~i+mkupSpnFl=9i0*9h4AbZ+hPmPJ~R
> zVnDcU9<TI*c3|Ay8TWz8Q~S7jd7?TNPrh^YvQoXwtC!I~wR$-}yL!31*Cg#?DGkeg
> zW9?S#G0MA2d6$=WC(65rly}GFy$SIa7PP*zdQU0u@$%k8dGC<&-ne{avV7t(%2$-~
> z6<)qFQND6W`O3I_b+UZ&G0In!@>O2GI#IrQNcrlxd~LFP>M_dKl=3xRzBW<5c1Zc!
> zxO{!G{M=)duPf#2ynKD4eEpE}b(Bxgt8B8oBg)H{2R<t>-NpK?-j+}CDUUxiugB>o
> zr?HjQ)8SiVDxGMXnQm%c=Ja&<0GUcB+GeJknrB!7rg<iX;j3gSooJhxZff4-^>p}D
> znMx<xW~Q5(2g`aoe7{Vk6KyloO+D8~^mO>BnMx<xW~Q5ZPFM7F_|ln5C))IM&WT6s
> z*?WsYvy814Y^&IDtob_|FNxiWx^?-{iof5k1oA1hFgf8(8Q0$`)Zch3di~a~3U9u4
> z^Nm|?ZohVubq&{FUmHKI8Oy2}U)f*ThK*HycoHq0e`Q;C_x2AcD6xX;S6YVKXa$Db
> zZoX__0lY|us=?x}+w`!=o+D)34Jzvez`atZfVJjEt6@fr8u8ShyUg{VL!y(JlIu5$
> z#nmEpLu?!+^I5l3eKj_;20QFSw^%G*%hyv_y)VsopS=8BLT+u4P!d4P?~~0a7O`-6
> zd@y-|Bt+ICmffeWtgr2d`DT)2JzgPWG8Hn+%%86waRawy9wNhZTa`<>*eGJ#k#Y44
> zFE_YqMC@v0gc0k1v2Oo%5E`FtqbZEGCrfg{la073!<Ek_TX9>qzZ}jF`ql_#zKmvF
> zA3ilTa&+IL?K{-RKD*UNukO7tyf6jhPX=z^wiS=21_l?wyR}Uli<N}fS)_zl*f!mA
> zXxr|t&K5V73;nruW%e*P=iQB<V;?fiv!9l!{209G+KjP@tk`5LL9b6XVwh+4uKU4@
> z^h{&^<A>>i=i1z-ryDb%S?XldmdUW%K;NPH1#Fsj(j<oMT)Un>fyq<zE4@nbEE~^w
> znn?6aIU5PO#3%lEP8FYL`JVv0%4i@Cb_B(amD1q5E#6ZN;WU@UOy!$Ge6RFk+WPaI
> z42xlj0KX9(uw(eperOve+6}yu@cRarAKC|T275@1{fBR|^6T_jJQ~qwG5ump+kQ2%
> zjrB)yh5bRhav%G$--;{uU%LAYwrt1QL>rA3?SWz7v>(N^N$DmqIAWKY?*NxDIO5ev
> z?aDh*Y+R;=gY$P{Ayr5je5dnb!ms;nF~qcu{3r<qX~z3?I@f*szHJ=EHsud5qkM3#
> zmrErK^d0BtdpR><#Vjo1A-X_UNQv{aN4KH7_iXi&D||1rS!r(JF*-|VZ04#xc9Kq#
> z-r`OxahY%JRTFd<yL;)NSQLB47?K|a#TP|@J7zGLaj@z!Y+B;vtUNi#Pg3-Vu>S)s
> Cro3tZ
>
> literal 0
> HcmV?d00001
>
> diff --git a/tests/data/acpi/q35/DSDT.ipmibt b/tests/data/acpi/q35/DSDT.ipmibt
> index 631741065860fd5036aa303904dabd1d2839f9c6..6ad2411d0ec95f204cfc64b430c537bce09c35bd 100644
> GIT binary patch
> delta 24
> gcmZ4ExW<voCD<iojRFG$quxZWD~xg*@1K<i0AMf(82|tP
>
> delta 24
> gcmZ4ExW<voCD<iojRFG$qwYkmD~$3R@1K<i0AMQ!82|tP
>
> diff --git a/tests/data/acpi/q35/DSDT.ivrs b/tests/data/acpi/q35/DSDT.ivrs
> index b0eafe90e5832935557ec5e6802c0147c88f379c..cad26e3f0c27a40a33101155a5282ed9bcb1d441 100644
> GIT binary patch
> delta 24
> gcmez5@X3M8CD<jTNP&TYan?kxD~xg*?@yKo0BrUMn*aa+
>
> delta 24
> gcmez5@X3M8CD<jTNP&TYappv>D~$3R?@yKo0BrFHn*aa+
>
> diff --git a/tests/data/acpi/q35/DSDT.memhp b/tests/data/acpi/q35/DSDT.memhp
> index 9bc11518fc57687ca789dc70793b48b29a0d74ed..4e9cb3dc6896bb79ccac0fe342a404549f6610e8 100644
> GIT binary patch
> delta 24
> gcmdnsy}_HyCD<iogDL|9<C}?GR~Y3s-oK~<0BV~F1poj5
>
> delta 24
> gcmdnsy}_HyCD<iogDL|9<LilBR~Y3t-oK~<0BV*A1poj5
>
> diff --git a/tests/data/acpi/q35/DSDT.mmio64 b/tests/data/acpi/q35/DSDT.mmio64
> index 713288a12ef2b70a20b4e8836c036ba4db3a57a8..eb5a1c7171c02d153487bfcecfb7019b7c1bf406 100644
> GIT binary patch
> delta 24
> gcmX@@dD@f9CD<k8v<d?Q<BEw~R~Y3s-hZPE0B$h}CjbBd
>
> delta 24
> gcmX@@dD@f9CD<k8v<d?Q<MN4IR~Y3t-hZPE0B$S^CjbBd
>
> diff --git a/tests/data/acpi/q35/DSDT.multi-bridge b/tests/data/acpi/q35/DSDT.multi-bridge
> index a24c713d22102a1a1583b5c902edffe1694e5cfe..45808eb03b78d07ebbe853f674abfed589d35e26 100644
> GIT binary patch
> delta 24
> fcmZp7Zg=K#33dr-S7cyd?3>7Sg;8$f{S^uTTRaEr
>
> delta 24
> fcmZp7Zg=K#33dr-S7cyd?48JUg;9Rv{S^uTTQ>*m
>
> diff --git a/tests/data/acpi/q35/DSDT.nohpet b/tests/data/acpi/q35/DSDT.nohpet
> index e8202e6ddfbe96071f32f1ec05758f650569943e..83d1aa00ac5686df479673fb0d7830f946e25dea 100644
> GIT binary patch
> delta 24
> gcmca?f7zbPCD<k8vOEI=<B^G6R~Y3s-v1&80B=4CMF0Q*
>
> delta 24
> gcmca?f7zbPCD<k8vOEI=<Kc;1R~Y3t-v1&80B<=7MF0Q*
>
> diff --git a/tests/data/acpi/q35/DSDT.nosmm b/tests/data/acpi/q35/DSDT.nosmm
> new file mode 100644
> index 0000000000000000000000000000000000000000..c1965f6051ef2af81dd8412abe169d87845bb033
> GIT binary patch
> literal 8289
> zcmb7JOKcm*8J^`!tL0K!Qk3OaY{E(UN|8{0Bx#EVC3pF<L~6yQ;si9nrRB7;og#}k
> z2J%1vSpgEqhoT9aphr4TfZp0uuQkw1d-JUUdg`H<T#F(`4`IK5h9l3A6cF>U+JE-@
> z{(rvNo&8obUf^~51;&j3l{egaP$<9Ry9N9V#u%N`U#F3{%(}Z?xz;n%v4qjRo#y8_
> zl+FB)z4BJg`29}!c^JO+QE2odcI6A_vn&1RgFE3BMxa|)BFmx^r?Sus%DwKMYx!=Y
> zX!hz2&n`W%Ota^Tv$)wSd2MF)wi+JGug~>10ylB@26MejtHV}uu#;V~oNn`<=e{|8
> z@)w_9daHE*=l}TS-5XW{fV22(;_tbL4&i&Dbt)V>pAN1W?-QM0TOBTaI^dT@n?qNk
> zkXr89qKQ(i?%(L{z38<|F7IQ;Z}~;HxQc$c?I3&FI{DEGV>S&A{r)r>js7A|nez^F
> znx;@$G3$P%BUKvEMyk5Ib-&YOHe(OIO|wMzwnOpK%axW_@Y`Omkbk}xbV@9umN25G
> z{=1>&ghTt2LC6MSdNkT+!-Y=<efGP)&HnY@<UZTC7DeB(*20JL)Rza}vIJx3&G(+A
> z-q3h=_l`G$QjZTY%AZD8{6>2-W`&mRtSvqlmq0>w_s*}CJ%GhMilg`Fl`M1ATCN!(
> z3z=cmjH~P_{+@}UT6gcM=El|mYjH_qnO5=)jZk;*?7H7smAMn*ej6Iru`)H|?fBbq
> z(>$}wGoN)gng^UD&=}1boQLs;ab})zIOpkh$35sxdVK$Q>WD?mFwZapL)6MX8lzp`
> z4LU~pzHOPfH59lQyR8BaUZJ}iR4!r`{LQv-<I)tk<znR`E|go%wvm1yXcV~R)>gCN
> zH@sI0U8B72uCe^nzFWB%>pn@*XcX-bB6`QT#wbVk`_#P8^3RmOnT4WU5go!YHq3h|
> z-wT=x!}amhc<{pC{~cU-xB1D+*Ue*pb(<08di~eo@X5h-Has@CX2mcA-sjJejmLJx
> z_Oo&0HXYc#mErQ>x-}Q&k};NH{V2TCXKcT3`VF_r@^%k@jcA7==Qpn!^sqSY*L))T
> z?T(*YySbZ7C-8K#_10R2iE{(zRhF}<-HIWo$smrP&T^Rq`hl4waN~$r04|7YoCl~3
> ziHZCi8{<r1#}P3lG{!g+P|ie1O!S6h<D4mb5NE`c(70d%%9#j>DXU;!2`tZ(;7kck
> z2&U{jLRDu{)0yN<2~7&7>^wqMXG+tV;!Fum={garI_ET<bDGXMT_-|Sr>W^QHJzre
> z6QQaTZy;r)=QW-4x=w_uPD|5iX*w-kCqh+cTGN@<bf$Hk2vwbU7b^GD)^yssPK2t?
> zjHWZA>CEUl5vn>DG@T2Y&IMg3LRIIYrgKr#xv1+zsOoeyosOo{(RCtJb!Ii4SxskF
> z*NITonbUOUG@UtJCqh-{lBRP>)48PUM5yY_YdZ6q&b+P@p{jFP)48naT-J3WRCONF
> zbRN-k9?^9oRCVG@0#BcO53OiAS9F~SRh>sQokumDM|GVDRh`E;vowAa9^=gN_+@uY
> zFx^KXF}*SNxW+uLF^}s^gevod#yp`hPv}g9D)XeqJgG5H>P&<x^9halgvNYAXChRY
> zr#Mr(%qh;4@Ay-KDPP<Oi7D^kX|3jIt>$UHCPGougn^b61FZ!Ol;&n?;2ed=28sY>
> zMG!|Ii^4z!j$4w!h$Z`Hps0Wz7$`z14F)Q((m)j`8K{6B7$`#YMjEKVjw7n68mNFC
> z7$`#Yh+|=(0y~bz8ab2<R6u2@>V$!cw44b8RiI>`2&F5Mfg+STVW0xbnJ`cVN(L&R
> zye1haLa7r5DzKah16818paRO7WS|J8P8g`bawZH^fs%m=C})y^B9!+N1}d<e2?JH2
> zWS|1dnPi{{rA`>Az;Y%GRDqI#3Mglifg+STVW0xbnJ`cVN(L&RoJj_XQ0jz%3M^;B
> zKouw%sDN@N87M-j69y`<oCyO}pk$x|%9&)K2&GOKsK9b23{-)VfeI*Rl7S+WI$@v!
> z%b74x1xf}gpqxnticso=feI{V!ax-$8K{7ACK)I~sS^e&u$&14RiI>`0?L_Wpa`W-
> z7^uK<CJa=8l7R{+XOe*;lsaLc0?U~&Pz6c`DxjQ628vMXgn<eyXTm@gC>f}LawZul
> zLa7r5DzKah16818paRO7WS|J8P8g`bawZH^fs%m=C})y^B9uB|paRR8Fi-_b1}dPO
> zNd}5g>V$y`EN8+%6(|{~fN~}oC_<?d28u{AP(-SMB2*0&p<<v469%d<$v_n*8K}a9
> zfhtTGsKO)zRhVR;3KIsZFkzqylMGa0l7T8r7^uR8fhtTgP=!ebsxV=oh~(Xcfg-{k
> z<AX^CiV(L!hQyR(3j;+Y#})>PNRBNTC_*{5WS|JKRCK%t3uQxl!2em@r+-NArRYzo
> zd;6!)#p%CPTGgQS4#RJ6mf*OXWjeTY@Jxoam(2>DSLslrL*2|TH8!ytFr0tS+TFn-
> z%ly8T&Yy2=y6t%Y+QsaGmHs%z=J`s{JM1pCSxFol(R(}ABBL{OqK&1O^*MYal;o0!
> zjpZ6z3^LK}AbZ4G`gnoO$Kh@a?{9`TF;*|~i+mkupSpnFl=9i0*9h4AbZ+hPmPJ~R
> zVnDcU9<TI*c3|Ay8TWz8Q~S7jd7?TNPrh^YvQoXwtC!I~wR$-}yL!31*Cg#?DGkeg
> zW9?S#G0MA2d6$=WC(65rly}GFy$SIa7PP*zdQU0u@$%k8dGC<&-ne{avV7t(%2$-~
> z6<)qFQND6W`O3I_b+UZ&G0In!@>O2GI#IrQNcrlxd~LFP>M_dKl=3xRzBW<5c1Zc!
> zxO{!G{M=)duPf#2ynKD4eEpE}b(Bxgt8B8oBg)H{2R<t>-NpK?-j+}CDUUxiugB>o
> zr?HjQ)8SiVDxGMXnQm%c=Ja&<0GUcB+GeJknrB!7rg<iX;j3gSooJhxZff4-^>p}D
> znMx<xW~Q5(2g`aoe7{Vk6KyloO+D8~^mO>BnMx<xW~Q5ZPFM7F_|ln5C))IM&WT6s
> z*?WsYvy814Y^&IDtob_|FNxiWx^?-{iof5k1oA1hFgf8(8Q0$`)Zch3di~a~3U9u4
> z^Nm|?ZohVubq&{FUmHKI8Oy2}U)f*ThK*HycoHq0e`Q;C_x2AcD6xX;S6YVKXa$Db
> zZoX__0lY|us=?x}+w`!=o+D)34Jzvez`atZfVJjEt6@fr8u8ShyUg{VL!y(JlIu5$
> z#nmEpLu?!+^I5l3eKj_;20QFSw^%G*%hyv_y)VsopS=8BLT+u4P!d4P?~~0a7O`-6
> zd@y-|Bt+ICmffeWtgr2d`DT)2JzgPWG8Hn+%%86waRawy9wNhZTa`<>*eGJ#k#Y44
> zFE_YqMC@v0gc0k1v2Oo%5E`FtqbZEGCrfg{la073!<Ek_TX9>qzZ}jF`ql_#zKmvF
> zA3ilTa&+IL?K{-RKD*UNukO7tyf6jhPX=z^wiS=21_l?wyR}Uli<N}fS)_zl*f!mA
> zXxr|t&K5V73;nruW%e*P=iQB<V;?fiv!9l!{209G+KjP@tk`5LL9b6XVwh+4uKU4@
> z^h{&^<A>>i=i1z-ryDb%S?XldmdUW%K;NPH1#Fsj(j<oMT)Un>fyq<zE4@nbEE~^w
> znn?6aIU5PO#3%lEP8FYL`JVv0%4i@Cb_B(amD1q5E#6ZN;WU@UOy!$Ge6RFk+WPaI
> z42xlj0KX9(uw(eperOve+6}yu@cRarAKC|T275@1{fBR|^6T_jJQ~qwG5ump+kQ2%
> zjrB)yh5bRhav%G$--;{uU%LAYwrt1QL>rA3?SWz7v>(N^N$DmqIAWKY?*NxDIO5ev
> z?aDh*Y+R;=gY$P{Ayr5je5dnb!ms;nF~qcu{3r<qX~z3?I@f*szHJ=EHsud5qkM3#
> zmrErK^d0BtdpR><#Vjo1A-X_UNQv{aN4KH7_iXi&D||1rS!r(JF*-|VZ04#xc9Kq#
> z-r`OxahY%JRTFd<yL;)NSQLB47?K|a#TP|@J7zGLaj@z!Y+B;vtUNi#Pg3-Vu>S)s
> Cro3tZ
>
> literal 0
> HcmV?d00001
>
> diff --git a/tests/data/acpi/q35/DSDT.numamem b/tests/data/acpi/q35/DSDT.numamem
> index 151e7cf42953f3f5fe61ff0140ab7b976fe9e5b8..050aaa237b466b0bda8cca5cfaa06f84661d622e 100644
> GIT binary patch
> delta 24
> gcmaFv@Z5pRCD<h-U4emtamhrkD~xg*?{~-p0BWTOc>n+a
>
> delta 24
> gcmaFv@Z5pRCD<h-U4emtaq&d1D~$3R?{~-p0BWEJc>n+a
>
> diff --git a/tests/data/acpi/q35/DSDT.smm-compat b/tests/data/acpi/q35/DSDT.smm-compat
> new file mode 100644
> index 0000000000000000000000000000000000000000..c1965f6051ef2af81dd8412abe169d87845bb033
> GIT binary patch
> literal 8289
> zcmb7JOKcm*8J^`!tL0K!Qk3OaY{E(UN|8{0Bx#EVC3pF<L~6yQ;si9nrRB7;og#}k
> z2J%1vSpgEqhoT9aphr4TfZp0uuQkw1d-JUUdg`H<T#F(`4`IK5h9l3A6cF>U+JE-@
> z{(rvNo&8obUf^~51;&j3l{egaP$<9Ry9N9V#u%N`U#F3{%(}Z?xz;n%v4qjRo#y8_
> zl+FB)z4BJg`29}!c^JO+QE2odcI6A_vn&1RgFE3BMxa|)BFmx^r?Sus%DwKMYx!=Y
> zX!hz2&n`W%Ota^Tv$)wSd2MF)wi+JGug~>10ylB@26MejtHV}uu#;V~oNn`<=e{|8
> z@)w_9daHE*=l}TS-5XW{fV22(;_tbL4&i&Dbt)V>pAN1W?-QM0TOBTaI^dT@n?qNk
> zkXr89qKQ(i?%(L{z38<|F7IQ;Z}~;HxQc$c?I3&FI{DEGV>S&A{r)r>js7A|nez^F
> znx;@$G3$P%BUKvEMyk5Ib-&YOHe(OIO|wMzwnOpK%axW_@Y`Omkbk}xbV@9umN25G
> z{=1>&ghTt2LC6MSdNkT+!-Y=<efGP)&HnY@<UZTC7DeB(*20JL)Rza}vIJx3&G(+A
> z-q3h=_l`G$QjZTY%AZD8{6>2-W`&mRtSvqlmq0>w_s*}CJ%GhMilg`Fl`M1ATCN!(
> z3z=cmjH~P_{+@}UT6gcM=El|mYjH_qnO5=)jZk;*?7H7smAMn*ej6Iru`)H|?fBbq
> z(>$}wGoN)gng^UD&=}1boQLs;ab})zIOpkh$35sxdVK$Q>WD?mFwZapL)6MX8lzp`
> z4LU~pzHOPfH59lQyR8BaUZJ}iR4!r`{LQv-<I)tk<znR`E|go%wvm1yXcV~R)>gCN
> zH@sI0U8B72uCe^nzFWB%>pn@*XcX-bB6`QT#wbVk`_#P8^3RmOnT4WU5go!YHq3h|
> z-wT=x!}amhc<{pC{~cU-xB1D+*Ue*pb(<08di~eo@X5h-Has@CX2mcA-sjJejmLJx
> z_Oo&0HXYc#mErQ>x-}Q&k};NH{V2TCXKcT3`VF_r@^%k@jcA7==Qpn!^sqSY*L))T
> z?T(*YySbZ7C-8K#_10R2iE{(zRhF}<-HIWo$smrP&T^Rq`hl4waN~$r04|7YoCl~3
> ziHZCi8{<r1#}P3lG{!g+P|ie1O!S6h<D4mb5NE`c(70d%%9#j>DXU;!2`tZ(;7kck
> z2&U{jLRDu{)0yN<2~7&7>^wqMXG+tV;!Fum={garI_ET<bDGXMT_-|Sr>W^QHJzre
> z6QQaTZy;r)=QW-4x=w_uPD|5iX*w-kCqh+cTGN@<bf$Hk2vwbU7b^GD)^yssPK2t?
> zjHWZA>CEUl5vn>DG@T2Y&IMg3LRIIYrgKr#xv1+zsOoeyosOo{(RCtJb!Ii4SxskF
> z*NITonbUOUG@UtJCqh-{lBRP>)48PUM5yY_YdZ6q&b+P@p{jFP)48naT-J3WRCONF
> zbRN-k9?^9oRCVG@0#BcO53OiAS9F~SRh>sQokumDM|GVDRh`E;vowAa9^=gN_+@uY
> zFx^KXF}*SNxW+uLF^}s^gevod#yp`hPv}g9D)XeqJgG5H>P&<x^9halgvNYAXChRY
> zr#Mr(%qh;4@Ay-KDPP<Oi7D^kX|3jIt>$UHCPGougn^b61FZ!Ol;&n?;2ed=28sY>
> zMG!|Ii^4z!j$4w!h$Z`Hps0Wz7$`z14F)Q((m)j`8K{6B7$`#YMjEKVjw7n68mNFC
> z7$`#Yh+|=(0y~bz8ab2<R6u2@>V$!cw44b8RiI>`2&F5Mfg+STVW0xbnJ`cVN(L&R
> zye1haLa7r5DzKah16818paRO7WS|J8P8g`bawZH^fs%m=C})y^B9!+N1}d<e2?JH2
> zWS|1dnPi{{rA`>Az;Y%GRDqI#3Mglifg+STVW0xbnJ`cVN(L&RoJj_XQ0jz%3M^;B
> zKouw%sDN@N87M-j69y`<oCyO}pk$x|%9&)K2&GOKsK9b23{-)VfeI*Rl7S+WI$@v!
> z%b74x1xf}gpqxnticso=feI{V!ax-$8K{7ACK)I~sS^e&u$&14RiI>`0?L_Wpa`W-
> z7^uK<CJa=8l7R{+XOe*;lsaLc0?U~&Pz6c`DxjQ628vMXgn<eyXTm@gC>f}LawZul
> zLa7r5DzKah16818paRO7WS|J8P8g`bawZH^fs%m=C})y^B9uB|paRR8Fi-_b1}dPO
> zNd}5g>V$y`EN8+%6(|{~fN~}oC_<?d28u{AP(-SMB2*0&p<<v469%d<$v_n*8K}a9
> zfhtTGsKO)zRhVR;3KIsZFkzqylMGa0l7T8r7^uR8fhtTgP=!ebsxV=oh~(Xcfg-{k
> z<AX^CiV(L!hQyR(3j;+Y#})>PNRBNTC_*{5WS|JKRCK%t3uQxl!2em@r+-NArRYzo
> zd;6!)#p%CPTGgQS4#RJ6mf*OXWjeTY@Jxoam(2>DSLslrL*2|TH8!ytFr0tS+TFn-
> z%ly8T&Yy2=y6t%Y+QsaGmHs%z=J`s{JM1pCSxFol(R(}ABBL{OqK&1O^*MYal;o0!
> zjpZ6z3^LK}AbZ4G`gnoO$Kh@a?{9`TF;*|~i+mkupSpnFl=9i0*9h4AbZ+hPmPJ~R
> zVnDcU9<TI*c3|Ay8TWz8Q~S7jd7?TNPrh^YvQoXwtC!I~wR$-}yL!31*Cg#?DGkeg
> zW9?S#G0MA2d6$=WC(65rly}GFy$SIa7PP*zdQU0u@$%k8dGC<&-ne{avV7t(%2$-~
> z6<)qFQND6W`O3I_b+UZ&G0In!@>O2GI#IrQNcrlxd~LFP>M_dKl=3xRzBW<5c1Zc!
> zxO{!G{M=)duPf#2ynKD4eEpE}b(Bxgt8B8oBg)H{2R<t>-NpK?-j+}CDUUxiugB>o
> zr?HjQ)8SiVDxGMXnQm%c=Ja&<0GUcB+GeJknrB!7rg<iX;j3gSooJhxZff4-^>p}D
> znMx<xW~Q5(2g`aoe7{Vk6KyloO+D8~^mO>BnMx<xW~Q5ZPFM7F_|ln5C))IM&WT6s
> z*?WsYvy814Y^&IDtob_|FNxiWx^?-{iof5k1oA1hFgf8(8Q0$`)Zch3di~a~3U9u4
> z^Nm|?ZohVubq&{FUmHKI8Oy2}U)f*ThK*HycoHq0e`Q;C_x2AcD6xX;S6YVKXa$Db
> zZoX__0lY|us=?x}+w`!=o+D)34Jzvez`atZfVJjEt6@fr8u8ShyUg{VL!y(JlIu5$
> z#nmEpLu?!+^I5l3eKj_;20QFSw^%G*%hyv_y)VsopS=8BLT+u4P!d4P?~~0a7O`-6
> zd@y-|Bt+ICmffeWtgr2d`DT)2JzgPWG8Hn+%%86waRawy9wNhZTa`<>*eGJ#k#Y44
> zFE_YqMC@v0gc0k1v2Oo%5E`FtqbZEGCrfg{la073!<Ek_TX9>qzZ}jF`ql_#zKmvF
> zA3ilTa&+IL?K{-RKD*UNukO7tyf6jhPX=z^wiS=21_l?wyR}Uli<N}fS)_zl*f!mA
> zXxr|t&K5V73;nruW%e*P=iQB<V;?fiv!9l!{209G+KjP@tk`5LL9b6XVwh+4uKU4@
> z^h{&^<A>>i=i1z-ryDb%S?XldmdUW%K;NPH1#Fsj(j<oMT)Un>fyq<zE4@nbEE~^w
> znn?6aIU5PO#3%lEP8FYL`JVv0%4i@Cb_B(amD1q5E#6ZN;WU@UOy!$Ge6RFk+WPaI
> z42xlj0KX9(uw(eperOve+6}yu@cRarAKC|T275@1{fBR|^6T_jJQ~qwG5ump+kQ2%
> zjrB)yh5bRhav%G$--;{uU%LAYwrt1QL>rA3?SWz7v>(N^N$DmqIAWKY?*NxDIO5ev
> z?aDh*Y+R;=gY$P{Ayr5je5dnb!ms;nF~qcu{3r<qX~z3?I@f*szHJ=EHsud5qkM3#
> zmrErK^d0BtdpR><#Vjo1A-X_UNQv{aN4KH7_iXi&D||1rS!r(JF*-|VZ04#xc9Kq#
> z-r`OxahY%JRTFd<yL;)NSQLB47?K|a#TP|@J7zGLaj@z!Y+B;vtUNi#Pg3-Vu>S)s
> Cro3tZ
>
> literal 0
> HcmV?d00001
>
> diff --git a/tests/data/acpi/q35/DSDT.smm-compat-nosmm b/tests/data/acpi/q35/DSDT.smm-compat-nosmm
> new file mode 100644
> index 0000000000000000000000000000000000000000..c1965f6051ef2af81dd8412abe169d87845bb033
> GIT binary patch
> literal 8289
> zcmb7JOKcm*8J^`!tL0K!Qk3OaY{E(UN|8{0Bx#EVC3pF<L~6yQ;si9nrRB7;og#}k
> z2J%1vSpgEqhoT9aphr4TfZp0uuQkw1d-JUUdg`H<T#F(`4`IK5h9l3A6cF>U+JE-@
> z{(rvNo&8obUf^~51;&j3l{egaP$<9Ry9N9V#u%N`U#F3{%(}Z?xz;n%v4qjRo#y8_
> zl+FB)z4BJg`29}!c^JO+QE2odcI6A_vn&1RgFE3BMxa|)BFmx^r?Sus%DwKMYx!=Y
> zX!hz2&n`W%Ota^Tv$)wSd2MF)wi+JGug~>10ylB@26MejtHV}uu#;V~oNn`<=e{|8
> z@)w_9daHE*=l}TS-5XW{fV22(;_tbL4&i&Dbt)V>pAN1W?-QM0TOBTaI^dT@n?qNk
> zkXr89qKQ(i?%(L{z38<|F7IQ;Z}~;HxQc$c?I3&FI{DEGV>S&A{r)r>js7A|nez^F
> znx;@$G3$P%BUKvEMyk5Ib-&YOHe(OIO|wMzwnOpK%axW_@Y`Omkbk}xbV@9umN25G
> z{=1>&ghTt2LC6MSdNkT+!-Y=<efGP)&HnY@<UZTC7DeB(*20JL)Rza}vIJx3&G(+A
> z-q3h=_l`G$QjZTY%AZD8{6>2-W`&mRtSvqlmq0>w_s*}CJ%GhMilg`Fl`M1ATCN!(
> z3z=cmjH~P_{+@}UT6gcM=El|mYjH_qnO5=)jZk;*?7H7smAMn*ej6Iru`)H|?fBbq
> z(>$}wGoN)gng^UD&=}1boQLs;ab})zIOpkh$35sxdVK$Q>WD?mFwZapL)6MX8lzp`
> z4LU~pzHOPfH59lQyR8BaUZJ}iR4!r`{LQv-<I)tk<znR`E|go%wvm1yXcV~R)>gCN
> zH@sI0U8B72uCe^nzFWB%>pn@*XcX-bB6`QT#wbVk`_#P8^3RmOnT4WU5go!YHq3h|
> z-wT=x!}amhc<{pC{~cU-xB1D+*Ue*pb(<08di~eo@X5h-Has@CX2mcA-sjJejmLJx
> z_Oo&0HXYc#mErQ>x-}Q&k};NH{V2TCXKcT3`VF_r@^%k@jcA7==Qpn!^sqSY*L))T
> z?T(*YySbZ7C-8K#_10R2iE{(zRhF}<-HIWo$smrP&T^Rq`hl4waN~$r04|7YoCl~3
> ziHZCi8{<r1#}P3lG{!g+P|ie1O!S6h<D4mb5NE`c(70d%%9#j>DXU;!2`tZ(;7kck
> z2&U{jLRDu{)0yN<2~7&7>^wqMXG+tV;!Fum={garI_ET<bDGXMT_-|Sr>W^QHJzre
> z6QQaTZy;r)=QW-4x=w_uPD|5iX*w-kCqh+cTGN@<bf$Hk2vwbU7b^GD)^yssPK2t?
> zjHWZA>CEUl5vn>DG@T2Y&IMg3LRIIYrgKr#xv1+zsOoeyosOo{(RCtJb!Ii4SxskF
> z*NITonbUOUG@UtJCqh-{lBRP>)48PUM5yY_YdZ6q&b+P@p{jFP)48naT-J3WRCONF
> zbRN-k9?^9oRCVG@0#BcO53OiAS9F~SRh>sQokumDM|GVDRh`E;vowAa9^=gN_+@uY
> zFx^KXF}*SNxW+uLF^}s^gevod#yp`hPv}g9D)XeqJgG5H>P&<x^9halgvNYAXChRY
> zr#Mr(%qh;4@Ay-KDPP<Oi7D^kX|3jIt>$UHCPGougn^b61FZ!Ol;&n?;2ed=28sY>
> zMG!|Ii^4z!j$4w!h$Z`Hps0Wz7$`z14F)Q((m)j`8K{6B7$`#YMjEKVjw7n68mNFC
> z7$`#Yh+|=(0y~bz8ab2<R6u2@>V$!cw44b8RiI>`2&F5Mfg+STVW0xbnJ`cVN(L&R
> zye1haLa7r5DzKah16818paRO7WS|J8P8g`bawZH^fs%m=C})y^B9!+N1}d<e2?JH2
> zWS|1dnPi{{rA`>Az;Y%GRDqI#3Mglifg+STVW0xbnJ`cVN(L&RoJj_XQ0jz%3M^;B
> zKouw%sDN@N87M-j69y`<oCyO}pk$x|%9&)K2&GOKsK9b23{-)VfeI*Rl7S+WI$@v!
> z%b74x1xf}gpqxnticso=feI{V!ax-$8K{7ACK)I~sS^e&u$&14RiI>`0?L_Wpa`W-
> z7^uK<CJa=8l7R{+XOe*;lsaLc0?U~&Pz6c`DxjQ628vMXgn<eyXTm@gC>f}LawZul
> zLa7r5DzKah16818paRO7WS|J8P8g`bawZH^fs%m=C})y^B9uB|paRR8Fi-_b1}dPO
> zNd}5g>V$y`EN8+%6(|{~fN~}oC_<?d28u{AP(-SMB2*0&p<<v469%d<$v_n*8K}a9
> zfhtTGsKO)zRhVR;3KIsZFkzqylMGa0l7T8r7^uR8fhtTgP=!ebsxV=oh~(Xcfg-{k
> z<AX^CiV(L!hQyR(3j;+Y#})>PNRBNTC_*{5WS|JKRCK%t3uQxl!2em@r+-NArRYzo
> zd;6!)#p%CPTGgQS4#RJ6mf*OXWjeTY@Jxoam(2>DSLslrL*2|TH8!ytFr0tS+TFn-
> z%ly8T&Yy2=y6t%Y+QsaGmHs%z=J`s{JM1pCSxFol(R(}ABBL{OqK&1O^*MYal;o0!
> zjpZ6z3^LK}AbZ4G`gnoO$Kh@a?{9`TF;*|~i+mkupSpnFl=9i0*9h4AbZ+hPmPJ~R
> zVnDcU9<TI*c3|Ay8TWz8Q~S7jd7?TNPrh^YvQoXwtC!I~wR$-}yL!31*Cg#?DGkeg
> zW9?S#G0MA2d6$=WC(65rly}GFy$SIa7PP*zdQU0u@$%k8dGC<&-ne{avV7t(%2$-~
> z6<)qFQND6W`O3I_b+UZ&G0In!@>O2GI#IrQNcrlxd~LFP>M_dKl=3xRzBW<5c1Zc!
> zxO{!G{M=)duPf#2ynKD4eEpE}b(Bxgt8B8oBg)H{2R<t>-NpK?-j+}CDUUxiugB>o
> zr?HjQ)8SiVDxGMXnQm%c=Ja&<0GUcB+GeJknrB!7rg<iX;j3gSooJhxZff4-^>p}D
> znMx<xW~Q5(2g`aoe7{Vk6KyloO+D8~^mO>BnMx<xW~Q5ZPFM7F_|ln5C))IM&WT6s
> z*?WsYvy814Y^&IDtob_|FNxiWx^?-{iof5k1oA1hFgf8(8Q0$`)Zch3di~a~3U9u4
> z^Nm|?ZohVubq&{FUmHKI8Oy2}U)f*ThK*HycoHq0e`Q;C_x2AcD6xX;S6YVKXa$Db
> zZoX__0lY|us=?x}+w`!=o+D)34Jzvez`atZfVJjEt6@fr8u8ShyUg{VL!y(JlIu5$
> z#nmEpLu?!+^I5l3eKj_;20QFSw^%G*%hyv_y)VsopS=8BLT+u4P!d4P?~~0a7O`-6
> zd@y-|Bt+ICmffeWtgr2d`DT)2JzgPWG8Hn+%%86waRawy9wNhZTa`<>*eGJ#k#Y44
> zFE_YqMC@v0gc0k1v2Oo%5E`FtqbZEGCrfg{la073!<Ek_TX9>qzZ}jF`ql_#zKmvF
> zA3ilTa&+IL?K{-RKD*UNukO7tyf6jhPX=z^wiS=21_l?wyR}Uli<N}fS)_zl*f!mA
> zXxr|t&K5V73;nruW%e*P=iQB<V;?fiv!9l!{209G+KjP@tk`5LL9b6XVwh+4uKU4@
> z^h{&^<A>>i=i1z-ryDb%S?XldmdUW%K;NPH1#Fsj(j<oMT)Un>fyq<zE4@nbEE~^w
> znn?6aIU5PO#3%lEP8FYL`JVv0%4i@Cb_B(amD1q5E#6ZN;WU@UOy!$Ge6RFk+WPaI
> z42xlj0KX9(uw(eperOve+6}yu@cRarAKC|T275@1{fBR|^6T_jJQ~qwG5ump+kQ2%
> zjrB)yh5bRhav%G$--;{uU%LAYwrt1QL>rA3?SWz7v>(N^N$DmqIAWKY?*NxDIO5ev
> z?aDh*Y+R;=gY$P{Ayr5je5dnb!ms;nF~qcu{3r<qX~z3?I@f*szHJ=EHsud5qkM3#
> zmrErK^d0BtdpR><#Vjo1A-X_UNQv{aN4KH7_iXi&D||1rS!r(JF*-|VZ04#xc9Kq#
> z-r`OxahY%JRTFd<yL;)NSQLB47?K|a#TP|@J7zGLaj@z!Y+B;vtUNi#Pg3-Vu>S)s
> Cro3tZ
>
> literal 0
> HcmV?d00001
>
> diff --git a/tests/data/acpi/q35/DSDT.tis.tpm12 b/tests/data/acpi/q35/DSDT.tis.tpm12
> index c96b5277a14ae98174408d690d6e0246bd932623..0ebdf6fbd77967f1ab5d5337b7b1fed314cfaca8 100644
> GIT binary patch
> delta 24
> gcmdnzy3du%CD<iopArKDqxwXyD~xg*@84Gh0A(f!W&i*H
>
> delta 24
> gcmdnzy3du%CD<iopArKDquNBSD~$3R@84Gh0A(QvW&i*H
>
> diff --git a/tests/data/acpi/q35/DSDT.tis.tpm2 b/tests/data/acpi/q35/DSDT.tis.tpm2
> index c92d4d29c79352a60974ea9f665d0b9a410a4bac..dcbb7f0af377425db53130e8ba1c62c09c22e006 100644
> GIT binary patch
> delta 24
> gcmdnzy3du%CD<iopArKD<D-dOR~Y3s-oLL10Bm##ApigX
>
> delta 24
> gcmdnzy3du%CD<iopArKD<HLzuR~Y3t-oLL10BmmwApigX
>
> diff --git a/tests/data/acpi/q35/DSDT.xapic b/tests/data/acpi/q35/DSDT.xapic
> index 119fc90f1f8a7b6934df6fd95609446e627ce15d..17552ce363ae81985f69f9ae85837a1540b79ae0 100644
> GIT binary patch
> delta 26
> icmX>yjp@iVCN7s?mk^h31_s6r6S=N1%5A)#+64f6_X&Rh
>
> delta 26
> icmX>yjp@iVCN7s?mk^h31_s9U6S=N1%5S`%+64f6@(F(c
>
> --
> 2.27.0
^ permalink raw reply [flat|nested] 24+ messages in thread
* Re: [PATCH for 6.2 v2 5/5] bios-tables-test: Update golden binaries
2021-11-11 8:34 ` Michael S. Tsirkin
@ 2021-11-11 9:27 ` Ani Sinha
2021-11-11 9:44 ` Ani Sinha
2021-11-11 11:32 ` Igor Mammedov
1 sibling, 1 reply; 24+ messages in thread
From: Ani Sinha @ 2021-11-11 9:27 UTC (permalink / raw)
To: Michael S. Tsirkin
Cc: mapfelba, jusual, qemu-devel, kraxel, ani, Igor Mammedov
On Thu, 11 Nov 2021, Michael S. Tsirkin wrote:
> On Wed, Nov 10, 2021 at 04:11:40PM -0500, Igor Mammedov wrote:
> > From: Julia Suvorova <jusual@redhat.com>
> >
> > The changes are the result of
> > 'hw/i386/acpi-build: Deny control on PCIe Native Hot-Plug in _OSC'
> > and listed here:
> >
> > Method (_OSC, 4, NotSerialized) // _OSC: Operating System Capabilities
> > {
> > CreateDWordField (Arg3, Zero, CDW1)
> > If ((Arg0 == ToUUID ("33db4d5b-1ff7-401c-9657-7441c03dd766") /* PCI Host Bridge Device */))
> > {
> > CreateDWordField (Arg3, 0x04, CDW2)
> > CreateDWordField (Arg3, 0x08, CDW3)
> > Local0 = CDW3 /* \_SB_.PCI0._OSC.CDW3 */
> > - Local0 &= 0x1F
> > + Local0 &= 0x1E
> >
> > Signed-off-by: Julia Suvorova <jusual@redhat.com>
> > Signed-off-by: Igor Mammedov <imammedo@redhat.com>
> > ---
> > tests/qtest/bios-tables-test-allowed-diff.h | 16 ----------------
> > tests/data/acpi/q35/DSDT | Bin 8289 -> 8289 bytes
> > tests/data/acpi/q35/DSDT.acpihmat | Bin 9614 -> 9614 bytes
> > tests/data/acpi/q35/DSDT.bridge | Bin 11003 -> 11003 bytes
> > tests/data/acpi/q35/DSDT.cphp | Bin 8753 -> 8753 bytes
> > tests/data/acpi/q35/DSDT.dimmpxm | Bin 9943 -> 9943 bytes
> > tests/data/acpi/q35/DSDT.dmar | Bin 0 -> 8289 bytes
> > tests/data/acpi/q35/DSDT.ipmibt | Bin 8364 -> 8364 bytes
> > tests/data/acpi/q35/DSDT.ivrs | Bin 8306 -> 8306 bytes
> > tests/data/acpi/q35/DSDT.memhp | Bin 9648 -> 9648 bytes
> > tests/data/acpi/q35/DSDT.mmio64 | Bin 9419 -> 9419 bytes
> > tests/data/acpi/q35/DSDT.multi-bridge | Bin 8583 -> 8583 bytes
> > tests/data/acpi/q35/DSDT.nohpet | Bin 8147 -> 8147 bytes
> > tests/data/acpi/q35/DSDT.nosmm | Bin 0 -> 8289 bytes
> > tests/data/acpi/q35/DSDT.numamem | Bin 8295 -> 8295 bytes
> > tests/data/acpi/q35/DSDT.smm-compat | Bin 0 -> 8289 bytes
> > tests/data/acpi/q35/DSDT.smm-compat-nosmm | Bin 0 -> 8289 bytes
> > tests/data/acpi/q35/DSDT.tis.tpm12 | Bin 8894 -> 8894 bytes
> > tests/data/acpi/q35/DSDT.tis.tpm2 | Bin 8894 -> 8894 bytes
> > tests/data/acpi/q35/DSDT.xapic | Bin 35652 -> 35652 bytes
>
> Why do we have all the new files? What is going on here?
Good catch. I saw those files even in my workspace and failed to notice
that they were being newly created in this patch and they did not exist
previously:
https://git.qemu.org/?p=qemu.git;a=tree;f=tests/data/acpi/q35;h=e9d1edd2671997a3e7fe278018313bcbfcfb0850;hb=HEAD
>
> > 20 files changed, 16 deletions(-)
> > create mode 100644 tests/data/acpi/q35/DSDT.dmar
The corresponding change that adds the test is :
commit 0ff92b6d99011c8de57321503c0eb655c461a217
Author: Igor Mammedov <imammedo@redhat.com>
Date: Thu Sep 2 07:35:43 2021 -0400
tests: acpi: add testcase for intel_iommu (DMAR table)
Igor has updated the DMAR table blob here:
commit 44d3bdd8a6f1ae2a5ca417251736a033900d4c08
Author: Igor Mammedov <imammedo@redhat.com>
Date: Thu Sep 2 07:35:44 2021 -0400
tests: acpi: add expected blob for DMAR table
but maybe the test also introduced changes in DSDT table as well?
Needs more investigation.
> > create mode 100644 tests/data/acpi/q35/DSDT.nosmm
> > create mode 100644 tests/data/acpi/q35/DSDT.smm-compat
> > create mode 100644 tests/data/acpi/q35/DSDT.smm-compat-nosmm
The corresponding tests for these files were added in this commit:
commit 0dabb2e802437c2e578dc72bd0bdf3380a25ec96
Author: Isaku Yamahata <isaku.yamahata@intel.com>
Date: Wed Feb 17 21:51:14 2021 -0800
BUT it seems that by mistake the table blobs were not added when the
following commit was made:
commit 7b630d937a6c73fb145746fb31e0fb4b08f0cf0e
Author: Isaku Yamahata <isaku.yamahata@intel.com>
Date: Wed Feb 17 21:51:18 2021 -0800
qtest/acpi/bios-tables-test: update acpi tables
Sadly, the above commit does update tests/data/acpi/q35/DSDT which I
believe includes the changes for the above tests. The commit message
does not add the ASL diff which the tests introduces.
I believe at some point I did TEST_ACPI_REBUILD_AML which regenrated those
files in my workspace and hence they were there. Same could be true for
Igor and got added when he generated the commit.
> >
> > diff --git a/tests/qtest/bios-tables-test-allowed-diff.h b/tests/qtest/bios-tables-test-allowed-diff.h
> > index 48e5634d4b..dfb8523c8b 100644
> > --- a/tests/qtest/bios-tables-test-allowed-diff.h
> > +++ b/tests/qtest/bios-tables-test-allowed-diff.h
> > @@ -1,17 +1 @@
> > /* List of comma-separated changed AML files to ignore */
> > -"tests/data/acpi/q35/DSDT",
> > -"tests/data/acpi/q35/DSDT.tis",
> > -"tests/data/acpi/q35/DSDT.bridge",
> > -"tests/data/acpi/q35/DSDT.mmio64",
> > -"tests/data/acpi/q35/DSDT.ipmibt",
> > -"tests/data/acpi/q35/DSDT.cphp",
> > -"tests/data/acpi/q35/DSDT.memhp",
> > -"tests/data/acpi/q35/DSDT.acpihmat",
> > -"tests/data/acpi/q35/DSDT.numamem",
> > -"tests/data/acpi/q35/DSDT.dimmpxm",
> > -"tests/data/acpi/q35/DSDT.nohpet",
> > -"tests/data/acpi/q35/DSDT.tis.tpm2",
> > -"tests/data/acpi/q35/DSDT.tis.tpm12",
> > -"tests/data/acpi/q35/DSDT.multi-bridge",
> > -"tests/data/acpi/q35/DSDT.ivrs",
> > -"tests/data/acpi/q35/DSDT.xapic",
> > diff --git a/tests/data/acpi/q35/DSDT b/tests/data/acpi/q35/DSDT
> > index 281fc82c03b2562d2e6b7caec0d817b034a47138..c1965f6051ef2af81dd8412abe169d87845bb033 100644
> > GIT binary patch
> > delta 24
> > gcmaFp@X&$FCD<h-QGtPh@z+GID~xg*?>ET<0BnZ{w*UYD
> >
> > delta 24
> > gcmaFp@X&$FCD<h-QGtPh@#jRYD~$3R?>ET<0BnK?w*UYD
> >
> > diff --git a/tests/data/acpi/q35/DSDT.acpihmat b/tests/data/acpi/q35/DSDT.acpihmat
> > index 8c1e05a11a328ec1cc6f86e36e52c28f41f9744e..f24d4874bff8d327a165ed7c36de507aea114edd 100644
> > GIT binary patch
> > delta 24
> > fcmeD4?(^ny33dtTQ)OUa+&+=(3ZvY{`|DKzU@Hhn
> >
> > delta 24
> > fcmeD4?(^ny33dtTQ)OUa+%}Qx3ZwkS`|DKzU?vDi
> >
> > diff --git a/tests/data/acpi/q35/DSDT.bridge b/tests/data/acpi/q35/DSDT.bridge
> > index 6f1464b6c712d7f33cb4b891b7ce76fe228f44c9..424d51bd1cb39ea73501ef7d0044ee52cec5bdac 100644
> > GIT binary patch
> > delta 24
> > gcmewz`a6`%CD<k8w-y5fBg;gtD~xg*@5^Wb0CWThXaE2J
> >
> > delta 24
> > gcmewz`a6`%CD<k8w-y5fBlASAD~$3R@5^Wb0CWEcXaE2J
> >
> > diff --git a/tests/data/acpi/q35/DSDT.cphp b/tests/data/acpi/q35/DSDT.cphp
> > index f8337ff5191a37a47dcf7c09a6c39c4e704a15bf..f1275606f68eeba54bfb11e63d818420385a62b9 100644
> > GIT binary patch
> > delta 24
> > fcmdn!veAXhCD<jzP>F$oF>WH)6-K#@_k$DxTWtqt
> >
> > delta 24
> > fcmdn!veAXhCD<jzP>F$oF?J%?6-N1u_k$DxTWAMo
> >
> > diff --git a/tests/data/acpi/q35/DSDT.dimmpxm b/tests/data/acpi/q35/DSDT.dimmpxm
> > index fe5820d93d057ef09a001662369b15afbc5b87e2..76e451e829ec4c245315f7eed8731aa1be45a747 100644
> > GIT binary patch
> > delta 24
> > gcmccad)=4ICD<k8x*7umqsK(9D~xg*@BdH*0B$o00{{R3
> >
> > delta 24
> > gcmccad)=4ICD<k8x*7umqx(dzD~$3R@BdH*0B$Y`0{{R3
> >
> > diff --git a/tests/data/acpi/q35/DSDT.dmar b/tests/data/acpi/q35/DSDT.dmar
> > new file mode 100644
> > index 0000000000000000000000000000000000000000..c1965f6051ef2af81dd8412abe169d87845bb033
> > GIT binary patch
> > literal 8289
> > zcmb7JOKcm*8J^`!tL0K!Qk3OaY{E(UN|8{0Bx#EVC3pF<L~6yQ;si9nrRB7;og#}k
> > z2J%1vSpgEqhoT9aphr4TfZp0uuQkw1d-JUUdg`H<T#F(`4`IK5h9l3A6cF>U+JE-@
> > z{(rvNo&8obUf^~51;&j3l{egaP$<9Ry9N9V#u%N`U#F3{%(}Z?xz;n%v4qjRo#y8_
> > zl+FB)z4BJg`29}!c^JO+QE2odcI6A_vn&1RgFE3BMxa|)BFmx^r?Sus%DwKMYx!=Y
> > zX!hz2&n`W%Ota^Tv$)wSd2MF)wi+JGug~>10ylB@26MejtHV}uu#;V~oNn`<=e{|8
> > z@)w_9daHE*=l}TS-5XW{fV22(;_tbL4&i&Dbt)V>pAN1W?-QM0TOBTaI^dT@n?qNk
> > zkXr89qKQ(i?%(L{z38<|F7IQ;Z}~;HxQc$c?I3&FI{DEGV>S&A{r)r>js7A|nez^F
> > znx;@$G3$P%BUKvEMyk5Ib-&YOHe(OIO|wMzwnOpK%axW_@Y`Omkbk}xbV@9umN25G
> > z{=1>&ghTt2LC6MSdNkT+!-Y=<efGP)&HnY@<UZTC7DeB(*20JL)Rza}vIJx3&G(+A
> > z-q3h=_l`G$QjZTY%AZD8{6>2-W`&mRtSvqlmq0>w_s*}CJ%GhMilg`Fl`M1ATCN!(
> > z3z=cmjH~P_{+@}UT6gcM=El|mYjH_qnO5=)jZk;*?7H7smAMn*ej6Iru`)H|?fBbq
> > z(>$}wGoN)gng^UD&=}1boQLs;ab})zIOpkh$35sxdVK$Q>WD?mFwZapL)6MX8lzp`
> > z4LU~pzHOPfH59lQyR8BaUZJ}iR4!r`{LQv-<I)tk<znR`E|go%wvm1yXcV~R)>gCN
> > zH@sI0U8B72uCe^nzFWB%>pn@*XcX-bB6`QT#wbVk`_#P8^3RmOnT4WU5go!YHq3h|
> > z-wT=x!}amhc<{pC{~cU-xB1D+*Ue*pb(<08di~eo@X5h-Has@CX2mcA-sjJejmLJx
> > z_Oo&0HXYc#mErQ>x-}Q&k};NH{V2TCXKcT3`VF_r@^%k@jcA7==Qpn!^sqSY*L))T
> > z?T(*YySbZ7C-8K#_10R2iE{(zRhF}<-HIWo$smrP&T^Rq`hl4waN~$r04|7YoCl~3
> > ziHZCi8{<r1#}P3lG{!g+P|ie1O!S6h<D4mb5NE`c(70d%%9#j>DXU;!2`tZ(;7kck
> > z2&U{jLRDu{)0yN<2~7&7>^wqMXG+tV;!Fum={garI_ET<bDGXMT_-|Sr>W^QHJzre
> > z6QQaTZy;r)=QW-4x=w_uPD|5iX*w-kCqh+cTGN@<bf$Hk2vwbU7b^GD)^yssPK2t?
> > zjHWZA>CEUl5vn>DG@T2Y&IMg3LRIIYrgKr#xv1+zsOoeyosOo{(RCtJb!Ii4SxskF
> > z*NITonbUOUG@UtJCqh-{lBRP>)48PUM5yY_YdZ6q&b+P@p{jFP)48naT-J3WRCONF
> > zbRN-k9?^9oRCVG@0#BcO53OiAS9F~SRh>sQokumDM|GVDRh`E;vowAa9^=gN_+@uY
> > zFx^KXF}*SNxW+uLF^}s^gevod#yp`hPv}g9D)XeqJgG5H>P&<x^9halgvNYAXChRY
> > zr#Mr(%qh;4@Ay-KDPP<Oi7D^kX|3jIt>$UHCPGougn^b61FZ!Ol;&n?;2ed=28sY>
> > zMG!|Ii^4z!j$4w!h$Z`Hps0Wz7$`z14F)Q((m)j`8K{6B7$`#YMjEKVjw7n68mNFC
> > z7$`#Yh+|=(0y~bz8ab2<R6u2@>V$!cw44b8RiI>`2&F5Mfg+STVW0xbnJ`cVN(L&R
> > zye1haLa7r5DzKah16818paRO7WS|J8P8g`bawZH^fs%m=C})y^B9!+N1}d<e2?JH2
> > zWS|1dnPi{{rA`>Az;Y%GRDqI#3Mglifg+STVW0xbnJ`cVN(L&RoJj_XQ0jz%3M^;B
> > zKouw%sDN@N87M-j69y`<oCyO}pk$x|%9&)K2&GOKsK9b23{-)VfeI*Rl7S+WI$@v!
> > z%b74x1xf}gpqxnticso=feI{V!ax-$8K{7ACK)I~sS^e&u$&14RiI>`0?L_Wpa`W-
> > z7^uK<CJa=8l7R{+XOe*;lsaLc0?U~&Pz6c`DxjQ628vMXgn<eyXTm@gC>f}LawZul
> > zLa7r5DzKah16818paRO7WS|J8P8g`bawZH^fs%m=C})y^B9uB|paRR8Fi-_b1}dPO
> > zNd}5g>V$y`EN8+%6(|{~fN~}oC_<?d28u{AP(-SMB2*0&p<<v469%d<$v_n*8K}a9
> > zfhtTGsKO)zRhVR;3KIsZFkzqylMGa0l7T8r7^uR8fhtTgP=!ebsxV=oh~(Xcfg-{k
> > z<AX^CiV(L!hQyR(3j;+Y#})>PNRBNTC_*{5WS|JKRCK%t3uQxl!2em@r+-NArRYzo
> > zd;6!)#p%CPTGgQS4#RJ6mf*OXWjeTY@Jxoam(2>DSLslrL*2|TH8!ytFr0tS+TFn-
> > z%ly8T&Yy2=y6t%Y+QsaGmHs%z=J`s{JM1pCSxFol(R(}ABBL{OqK&1O^*MYal;o0!
> > zjpZ6z3^LK}AbZ4G`gnoO$Kh@a?{9`TF;*|~i+mkupSpnFl=9i0*9h4AbZ+hPmPJ~R
> > zVnDcU9<TI*c3|Ay8TWz8Q~S7jd7?TNPrh^YvQoXwtC!I~wR$-}yL!31*Cg#?DGkeg
> > zW9?S#G0MA2d6$=WC(65rly}GFy$SIa7PP*zdQU0u@$%k8dGC<&-ne{avV7t(%2$-~
> > z6<)qFQND6W`O3I_b+UZ&G0In!@>O2GI#IrQNcrlxd~LFP>M_dKl=3xRzBW<5c1Zc!
> > zxO{!G{M=)duPf#2ynKD4eEpE}b(Bxgt8B8oBg)H{2R<t>-NpK?-j+}CDUUxiugB>o
> > zr?HjQ)8SiVDxGMXnQm%c=Ja&<0GUcB+GeJknrB!7rg<iX;j3gSooJhxZff4-^>p}D
> > znMx<xW~Q5(2g`aoe7{Vk6KyloO+D8~^mO>BnMx<xW~Q5ZPFM7F_|ln5C))IM&WT6s
> > z*?WsYvy814Y^&IDtob_|FNxiWx^?-{iof5k1oA1hFgf8(8Q0$`)Zch3di~a~3U9u4
> > z^Nm|?ZohVubq&{FUmHKI8Oy2}U)f*ThK*HycoHq0e`Q;C_x2AcD6xX;S6YVKXa$Db
> > zZoX__0lY|us=?x}+w`!=o+D)34Jzvez`atZfVJjEt6@fr8u8ShyUg{VL!y(JlIu5$
> > z#nmEpLu?!+^I5l3eKj_;20QFSw^%G*%hyv_y)VsopS=8BLT+u4P!d4P?~~0a7O`-6
> > zd@y-|Bt+ICmffeWtgr2d`DT)2JzgPWG8Hn+%%86waRawy9wNhZTa`<>*eGJ#k#Y44
> > zFE_YqMC@v0gc0k1v2Oo%5E`FtqbZEGCrfg{la073!<Ek_TX9>qzZ}jF`ql_#zKmvF
> > zA3ilTa&+IL?K{-RKD*UNukO7tyf6jhPX=z^wiS=21_l?wyR}Uli<N}fS)_zl*f!mA
> > zXxr|t&K5V73;nruW%e*P=iQB<V;?fiv!9l!{209G+KjP@tk`5LL9b6XVwh+4uKU4@
> > z^h{&^<A>>i=i1z-ryDb%S?XldmdUW%K;NPH1#Fsj(j<oMT)Un>fyq<zE4@nbEE~^w
> > znn?6aIU5PO#3%lEP8FYL`JVv0%4i@Cb_B(amD1q5E#6ZN;WU@UOy!$Ge6RFk+WPaI
> > z42xlj0KX9(uw(eperOve+6}yu@cRarAKC|T275@1{fBR|^6T_jJQ~qwG5ump+kQ2%
> > zjrB)yh5bRhav%G$--;{uU%LAYwrt1QL>rA3?SWz7v>(N^N$DmqIAWKY?*NxDIO5ev
> > z?aDh*Y+R;=gY$P{Ayr5je5dnb!ms;nF~qcu{3r<qX~z3?I@f*szHJ=EHsud5qkM3#
> > zmrErK^d0BtdpR><#Vjo1A-X_UNQv{aN4KH7_iXi&D||1rS!r(JF*-|VZ04#xc9Kq#
> > z-r`OxahY%JRTFd<yL;)NSQLB47?K|a#TP|@J7zGLaj@z!Y+B;vtUNi#Pg3-Vu>S)s
> > Cro3tZ
> >
> > literal 0
> > HcmV?d00001
> >
> > diff --git a/tests/data/acpi/q35/DSDT.ipmibt b/tests/data/acpi/q35/DSDT.ipmibt
> > index 631741065860fd5036aa303904dabd1d2839f9c6..6ad2411d0ec95f204cfc64b430c537bce09c35bd 100644
> > GIT binary patch
> > delta 24
> > gcmZ4ExW<voCD<iojRFG$quxZWD~xg*@1K<i0AMf(82|tP
> >
> > delta 24
> > gcmZ4ExW<voCD<iojRFG$qwYkmD~$3R@1K<i0AMQ!82|tP
> >
> > diff --git a/tests/data/acpi/q35/DSDT.ivrs b/tests/data/acpi/q35/DSDT.ivrs
> > index b0eafe90e5832935557ec5e6802c0147c88f379c..cad26e3f0c27a40a33101155a5282ed9bcb1d441 100644
> > GIT binary patch
> > delta 24
> > gcmez5@X3M8CD<jTNP&TYan?kxD~xg*?@yKo0BrUMn*aa+
> >
> > delta 24
> > gcmez5@X3M8CD<jTNP&TYappv>D~$3R?@yKo0BrFHn*aa+
> >
> > diff --git a/tests/data/acpi/q35/DSDT.memhp b/tests/data/acpi/q35/DSDT.memhp
> > index 9bc11518fc57687ca789dc70793b48b29a0d74ed..4e9cb3dc6896bb79ccac0fe342a404549f6610e8 100644
> > GIT binary patch
> > delta 24
> > gcmdnsy}_HyCD<iogDL|9<C}?GR~Y3s-oK~<0BV~F1poj5
> >
> > delta 24
> > gcmdnsy}_HyCD<iogDL|9<LilBR~Y3t-oK~<0BV*A1poj5
> >
> > diff --git a/tests/data/acpi/q35/DSDT.mmio64 b/tests/data/acpi/q35/DSDT.mmio64
> > index 713288a12ef2b70a20b4e8836c036ba4db3a57a8..eb5a1c7171c02d153487bfcecfb7019b7c1bf406 100644
> > GIT binary patch
> > delta 24
> > gcmX@@dD@f9CD<k8v<d?Q<BEw~R~Y3s-hZPE0B$h}CjbBd
> >
> > delta 24
> > gcmX@@dD@f9CD<k8v<d?Q<MN4IR~Y3t-hZPE0B$S^CjbBd
> >
> > diff --git a/tests/data/acpi/q35/DSDT.multi-bridge b/tests/data/acpi/q35/DSDT.multi-bridge
> > index a24c713d22102a1a1583b5c902edffe1694e5cfe..45808eb03b78d07ebbe853f674abfed589d35e26 100644
> > GIT binary patch
> > delta 24
> > fcmZp7Zg=K#33dr-S7cyd?3>7Sg;8$f{S^uTTRaEr
> >
> > delta 24
> > fcmZp7Zg=K#33dr-S7cyd?48JUg;9Rv{S^uTTQ>*m
> >
> > diff --git a/tests/data/acpi/q35/DSDT.nohpet b/tests/data/acpi/q35/DSDT.nohpet
> > index e8202e6ddfbe96071f32f1ec05758f650569943e..83d1aa00ac5686df479673fb0d7830f946e25dea 100644
> > GIT binary patch
> > delta 24
> > gcmca?f7zbPCD<k8vOEI=<B^G6R~Y3s-v1&80B=4CMF0Q*
> >
> > delta 24
> > gcmca?f7zbPCD<k8vOEI=<Kc;1R~Y3t-v1&80B<=7MF0Q*
> >
> > diff --git a/tests/data/acpi/q35/DSDT.nosmm b/tests/data/acpi/q35/DSDT.nosmm
> > new file mode 100644
> > index 0000000000000000000000000000000000000000..c1965f6051ef2af81dd8412abe169d87845bb033
> > GIT binary patch
> > literal 8289
> > zcmb7JOKcm*8J^`!tL0K!Qk3OaY{E(UN|8{0Bx#EVC3pF<L~6yQ;si9nrRB7;og#}k
> > z2J%1vSpgEqhoT9aphr4TfZp0uuQkw1d-JUUdg`H<T#F(`4`IK5h9l3A6cF>U+JE-@
> > z{(rvNo&8obUf^~51;&j3l{egaP$<9Ry9N9V#u%N`U#F3{%(}Z?xz;n%v4qjRo#y8_
> > zl+FB)z4BJg`29}!c^JO+QE2odcI6A_vn&1RgFE3BMxa|)BFmx^r?Sus%DwKMYx!=Y
> > zX!hz2&n`W%Ota^Tv$)wSd2MF)wi+JGug~>10ylB@26MejtHV}uu#;V~oNn`<=e{|8
> > z@)w_9daHE*=l}TS-5XW{fV22(;_tbL4&i&Dbt)V>pAN1W?-QM0TOBTaI^dT@n?qNk
> > zkXr89qKQ(i?%(L{z38<|F7IQ;Z}~;HxQc$c?I3&FI{DEGV>S&A{r)r>js7A|nez^F
> > znx;@$G3$P%BUKvEMyk5Ib-&YOHe(OIO|wMzwnOpK%axW_@Y`Omkbk}xbV@9umN25G
> > z{=1>&ghTt2LC6MSdNkT+!-Y=<efGP)&HnY@<UZTC7DeB(*20JL)Rza}vIJx3&G(+A
> > z-q3h=_l`G$QjZTY%AZD8{6>2-W`&mRtSvqlmq0>w_s*}CJ%GhMilg`Fl`M1ATCN!(
> > z3z=cmjH~P_{+@}UT6gcM=El|mYjH_qnO5=)jZk;*?7H7smAMn*ej6Iru`)H|?fBbq
> > z(>$}wGoN)gng^UD&=}1boQLs;ab})zIOpkh$35sxdVK$Q>WD?mFwZapL)6MX8lzp`
> > z4LU~pzHOPfH59lQyR8BaUZJ}iR4!r`{LQv-<I)tk<znR`E|go%wvm1yXcV~R)>gCN
> > zH@sI0U8B72uCe^nzFWB%>pn@*XcX-bB6`QT#wbVk`_#P8^3RmOnT4WU5go!YHq3h|
> > z-wT=x!}amhc<{pC{~cU-xB1D+*Ue*pb(<08di~eo@X5h-Has@CX2mcA-sjJejmLJx
> > z_Oo&0HXYc#mErQ>x-}Q&k};NH{V2TCXKcT3`VF_r@^%k@jcA7==Qpn!^sqSY*L))T
> > z?T(*YySbZ7C-8K#_10R2iE{(zRhF}<-HIWo$smrP&T^Rq`hl4waN~$r04|7YoCl~3
> > ziHZCi8{<r1#}P3lG{!g+P|ie1O!S6h<D4mb5NE`c(70d%%9#j>DXU;!2`tZ(;7kck
> > z2&U{jLRDu{)0yN<2~7&7>^wqMXG+tV;!Fum={garI_ET<bDGXMT_-|Sr>W^QHJzre
> > z6QQaTZy;r)=QW-4x=w_uPD|5iX*w-kCqh+cTGN@<bf$Hk2vwbU7b^GD)^yssPK2t?
> > zjHWZA>CEUl5vn>DG@T2Y&IMg3LRIIYrgKr#xv1+zsOoeyosOo{(RCtJb!Ii4SxskF
> > z*NITonbUOUG@UtJCqh-{lBRP>)48PUM5yY_YdZ6q&b+P@p{jFP)48naT-J3WRCONF
> > zbRN-k9?^9oRCVG@0#BcO53OiAS9F~SRh>sQokumDM|GVDRh`E;vowAa9^=gN_+@uY
> > zFx^KXF}*SNxW+uLF^}s^gevod#yp`hPv}g9D)XeqJgG5H>P&<x^9halgvNYAXChRY
> > zr#Mr(%qh;4@Ay-KDPP<Oi7D^kX|3jIt>$UHCPGougn^b61FZ!Ol;&n?;2ed=28sY>
> > zMG!|Ii^4z!j$4w!h$Z`Hps0Wz7$`z14F)Q((m)j`8K{6B7$`#YMjEKVjw7n68mNFC
> > z7$`#Yh+|=(0y~bz8ab2<R6u2@>V$!cw44b8RiI>`2&F5Mfg+STVW0xbnJ`cVN(L&R
> > zye1haLa7r5DzKah16818paRO7WS|J8P8g`bawZH^fs%m=C})y^B9!+N1}d<e2?JH2
> > zWS|1dnPi{{rA`>Az;Y%GRDqI#3Mglifg+STVW0xbnJ`cVN(L&RoJj_XQ0jz%3M^;B
> > zKouw%sDN@N87M-j69y`<oCyO}pk$x|%9&)K2&GOKsK9b23{-)VfeI*Rl7S+WI$@v!
> > z%b74x1xf}gpqxnticso=feI{V!ax-$8K{7ACK)I~sS^e&u$&14RiI>`0?L_Wpa`W-
> > z7^uK<CJa=8l7R{+XOe*;lsaLc0?U~&Pz6c`DxjQ628vMXgn<eyXTm@gC>f}LawZul
> > zLa7r5DzKah16818paRO7WS|J8P8g`bawZH^fs%m=C})y^B9uB|paRR8Fi-_b1}dPO
> > zNd}5g>V$y`EN8+%6(|{~fN~}oC_<?d28u{AP(-SMB2*0&p<<v469%d<$v_n*8K}a9
> > zfhtTGsKO)zRhVR;3KIsZFkzqylMGa0l7T8r7^uR8fhtTgP=!ebsxV=oh~(Xcfg-{k
> > z<AX^CiV(L!hQyR(3j;+Y#})>PNRBNTC_*{5WS|JKRCK%t3uQxl!2em@r+-NArRYzo
> > zd;6!)#p%CPTGgQS4#RJ6mf*OXWjeTY@Jxoam(2>DSLslrL*2|TH8!ytFr0tS+TFn-
> > z%ly8T&Yy2=y6t%Y+QsaGmHs%z=J`s{JM1pCSxFol(R(}ABBL{OqK&1O^*MYal;o0!
> > zjpZ6z3^LK}AbZ4G`gnoO$Kh@a?{9`TF;*|~i+mkupSpnFl=9i0*9h4AbZ+hPmPJ~R
> > zVnDcU9<TI*c3|Ay8TWz8Q~S7jd7?TNPrh^YvQoXwtC!I~wR$-}yL!31*Cg#?DGkeg
> > zW9?S#G0MA2d6$=WC(65rly}GFy$SIa7PP*zdQU0u@$%k8dGC<&-ne{avV7t(%2$-~
> > z6<)qFQND6W`O3I_b+UZ&G0In!@>O2GI#IrQNcrlxd~LFP>M_dKl=3xRzBW<5c1Zc!
> > zxO{!G{M=)duPf#2ynKD4eEpE}b(Bxgt8B8oBg)H{2R<t>-NpK?-j+}CDUUxiugB>o
> > zr?HjQ)8SiVDxGMXnQm%c=Ja&<0GUcB+GeJknrB!7rg<iX;j3gSooJhxZff4-^>p}D
> > znMx<xW~Q5(2g`aoe7{Vk6KyloO+D8~^mO>BnMx<xW~Q5ZPFM7F_|ln5C))IM&WT6s
> > z*?WsYvy814Y^&IDtob_|FNxiWx^?-{iof5k1oA1hFgf8(8Q0$`)Zch3di~a~3U9u4
> > z^Nm|?ZohVubq&{FUmHKI8Oy2}U)f*ThK*HycoHq0e`Q;C_x2AcD6xX;S6YVKXa$Db
> > zZoX__0lY|us=?x}+w`!=o+D)34Jzvez`atZfVJjEt6@fr8u8ShyUg{VL!y(JlIu5$
> > z#nmEpLu?!+^I5l3eKj_;20QFSw^%G*%hyv_y)VsopS=8BLT+u4P!d4P?~~0a7O`-6
> > zd@y-|Bt+ICmffeWtgr2d`DT)2JzgPWG8Hn+%%86waRawy9wNhZTa`<>*eGJ#k#Y44
> > zFE_YqMC@v0gc0k1v2Oo%5E`FtqbZEGCrfg{la073!<Ek_TX9>qzZ}jF`ql_#zKmvF
> > zA3ilTa&+IL?K{-RKD*UNukO7tyf6jhPX=z^wiS=21_l?wyR}Uli<N}fS)_zl*f!mA
> > zXxr|t&K5V73;nruW%e*P=iQB<V;?fiv!9l!{209G+KjP@tk`5LL9b6XVwh+4uKU4@
> > z^h{&^<A>>i=i1z-ryDb%S?XldmdUW%K;NPH1#Fsj(j<oMT)Un>fyq<zE4@nbEE~^w
> > znn?6aIU5PO#3%lEP8FYL`JVv0%4i@Cb_B(amD1q5E#6ZN;WU@UOy!$Ge6RFk+WPaI
> > z42xlj0KX9(uw(eperOve+6}yu@cRarAKC|T275@1{fBR|^6T_jJQ~qwG5ump+kQ2%
> > zjrB)yh5bRhav%G$--;{uU%LAYwrt1QL>rA3?SWz7v>(N^N$DmqIAWKY?*NxDIO5ev
> > z?aDh*Y+R;=gY$P{Ayr5je5dnb!ms;nF~qcu{3r<qX~z3?I@f*szHJ=EHsud5qkM3#
> > zmrErK^d0BtdpR><#Vjo1A-X_UNQv{aN4KH7_iXi&D||1rS!r(JF*-|VZ04#xc9Kq#
> > z-r`OxahY%JRTFd<yL;)NSQLB47?K|a#TP|@J7zGLaj@z!Y+B;vtUNi#Pg3-Vu>S)s
> > Cro3tZ
> >
> > literal 0
> > HcmV?d00001
> >
> > diff --git a/tests/data/acpi/q35/DSDT.numamem b/tests/data/acpi/q35/DSDT.numamem
> > index 151e7cf42953f3f5fe61ff0140ab7b976fe9e5b8..050aaa237b466b0bda8cca5cfaa06f84661d622e 100644
> > GIT binary patch
> > delta 24
> > gcmaFv@Z5pRCD<h-U4emtamhrkD~xg*?{~-p0BWTOc>n+a
> >
> > delta 24
> > gcmaFv@Z5pRCD<h-U4emtaq&d1D~$3R?{~-p0BWEJc>n+a
> >
> > diff --git a/tests/data/acpi/q35/DSDT.smm-compat b/tests/data/acpi/q35/DSDT.smm-compat
> > new file mode 100644
> > index 0000000000000000000000000000000000000000..c1965f6051ef2af81dd8412abe169d87845bb033
> > GIT binary patch
> > literal 8289
> > zcmb7JOKcm*8J^`!tL0K!Qk3OaY{E(UN|8{0Bx#EVC3pF<L~6yQ;si9nrRB7;og#}k
> > z2J%1vSpgEqhoT9aphr4TfZp0uuQkw1d-JUUdg`H<T#F(`4`IK5h9l3A6cF>U+JE-@
> > z{(rvNo&8obUf^~51;&j3l{egaP$<9Ry9N9V#u%N`U#F3{%(}Z?xz;n%v4qjRo#y8_
> > zl+FB)z4BJg`29}!c^JO+QE2odcI6A_vn&1RgFE3BMxa|)BFmx^r?Sus%DwKMYx!=Y
> > zX!hz2&n`W%Ota^Tv$)wSd2MF)wi+JGug~>10ylB@26MejtHV}uu#;V~oNn`<=e{|8
> > z@)w_9daHE*=l}TS-5XW{fV22(;_tbL4&i&Dbt)V>pAN1W?-QM0TOBTaI^dT@n?qNk
> > zkXr89qKQ(i?%(L{z38<|F7IQ;Z}~;HxQc$c?I3&FI{DEGV>S&A{r)r>js7A|nez^F
> > znx;@$G3$P%BUKvEMyk5Ib-&YOHe(OIO|wMzwnOpK%axW_@Y`Omkbk}xbV@9umN25G
> > z{=1>&ghTt2LC6MSdNkT+!-Y=<efGP)&HnY@<UZTC7DeB(*20JL)Rza}vIJx3&G(+A
> > z-q3h=_l`G$QjZTY%AZD8{6>2-W`&mRtSvqlmq0>w_s*}CJ%GhMilg`Fl`M1ATCN!(
> > z3z=cmjH~P_{+@}UT6gcM=El|mYjH_qnO5=)jZk;*?7H7smAMn*ej6Iru`)H|?fBbq
> > z(>$}wGoN)gng^UD&=}1boQLs;ab})zIOpkh$35sxdVK$Q>WD?mFwZapL)6MX8lzp`
> > z4LU~pzHOPfH59lQyR8BaUZJ}iR4!r`{LQv-<I)tk<znR`E|go%wvm1yXcV~R)>gCN
> > zH@sI0U8B72uCe^nzFWB%>pn@*XcX-bB6`QT#wbVk`_#P8^3RmOnT4WU5go!YHq3h|
> > z-wT=x!}amhc<{pC{~cU-xB1D+*Ue*pb(<08di~eo@X5h-Has@CX2mcA-sjJejmLJx
> > z_Oo&0HXYc#mErQ>x-}Q&k};NH{V2TCXKcT3`VF_r@^%k@jcA7==Qpn!^sqSY*L))T
> > z?T(*YySbZ7C-8K#_10R2iE{(zRhF}<-HIWo$smrP&T^Rq`hl4waN~$r04|7YoCl~3
> > ziHZCi8{<r1#}P3lG{!g+P|ie1O!S6h<D4mb5NE`c(70d%%9#j>DXU;!2`tZ(;7kck
> > z2&U{jLRDu{)0yN<2~7&7>^wqMXG+tV;!Fum={garI_ET<bDGXMT_-|Sr>W^QHJzre
> > z6QQaTZy;r)=QW-4x=w_uPD|5iX*w-kCqh+cTGN@<bf$Hk2vwbU7b^GD)^yssPK2t?
> > zjHWZA>CEUl5vn>DG@T2Y&IMg3LRIIYrgKr#xv1+zsOoeyosOo{(RCtJb!Ii4SxskF
> > z*NITonbUOUG@UtJCqh-{lBRP>)48PUM5yY_YdZ6q&b+P@p{jFP)48naT-J3WRCONF
> > zbRN-k9?^9oRCVG@0#BcO53OiAS9F~SRh>sQokumDM|GVDRh`E;vowAa9^=gN_+@uY
> > zFx^KXF}*SNxW+uLF^}s^gevod#yp`hPv}g9D)XeqJgG5H>P&<x^9halgvNYAXChRY
> > zr#Mr(%qh;4@Ay-KDPP<Oi7D^kX|3jIt>$UHCPGougn^b61FZ!Ol;&n?;2ed=28sY>
> > zMG!|Ii^4z!j$4w!h$Z`Hps0Wz7$`z14F)Q((m)j`8K{6B7$`#YMjEKVjw7n68mNFC
> > z7$`#Yh+|=(0y~bz8ab2<R6u2@>V$!cw44b8RiI>`2&F5Mfg+STVW0xbnJ`cVN(L&R
> > zye1haLa7r5DzKah16818paRO7WS|J8P8g`bawZH^fs%m=C})y^B9!+N1}d<e2?JH2
> > zWS|1dnPi{{rA`>Az;Y%GRDqI#3Mglifg+STVW0xbnJ`cVN(L&RoJj_XQ0jz%3M^;B
> > zKouw%sDN@N87M-j69y`<oCyO}pk$x|%9&)K2&GOKsK9b23{-)VfeI*Rl7S+WI$@v!
> > z%b74x1xf}gpqxnticso=feI{V!ax-$8K{7ACK)I~sS^e&u$&14RiI>`0?L_Wpa`W-
> > z7^uK<CJa=8l7R{+XOe*;lsaLc0?U~&Pz6c`DxjQ628vMXgn<eyXTm@gC>f}LawZul
> > zLa7r5DzKah16818paRO7WS|J8P8g`bawZH^fs%m=C})y^B9uB|paRR8Fi-_b1}dPO
> > zNd}5g>V$y`EN8+%6(|{~fN~}oC_<?d28u{AP(-SMB2*0&p<<v469%d<$v_n*8K}a9
> > zfhtTGsKO)zRhVR;3KIsZFkzqylMGa0l7T8r7^uR8fhtTgP=!ebsxV=oh~(Xcfg-{k
> > z<AX^CiV(L!hQyR(3j;+Y#})>PNRBNTC_*{5WS|JKRCK%t3uQxl!2em@r+-NArRYzo
> > zd;6!)#p%CPTGgQS4#RJ6mf*OXWjeTY@Jxoam(2>DSLslrL*2|TH8!ytFr0tS+TFn-
> > z%ly8T&Yy2=y6t%Y+QsaGmHs%z=J`s{JM1pCSxFol(R(}ABBL{OqK&1O^*MYal;o0!
> > zjpZ6z3^LK}AbZ4G`gnoO$Kh@a?{9`TF;*|~i+mkupSpnFl=9i0*9h4AbZ+hPmPJ~R
> > zVnDcU9<TI*c3|Ay8TWz8Q~S7jd7?TNPrh^YvQoXwtC!I~wR$-}yL!31*Cg#?DGkeg
> > zW9?S#G0MA2d6$=WC(65rly}GFy$SIa7PP*zdQU0u@$%k8dGC<&-ne{avV7t(%2$-~
> > z6<)qFQND6W`O3I_b+UZ&G0In!@>O2GI#IrQNcrlxd~LFP>M_dKl=3xRzBW<5c1Zc!
> > zxO{!G{M=)duPf#2ynKD4eEpE}b(Bxgt8B8oBg)H{2R<t>-NpK?-j+}CDUUxiugB>o
> > zr?HjQ)8SiVDxGMXnQm%c=Ja&<0GUcB+GeJknrB!7rg<iX;j3gSooJhxZff4-^>p}D
> > znMx<xW~Q5(2g`aoe7{Vk6KyloO+D8~^mO>BnMx<xW~Q5ZPFM7F_|ln5C))IM&WT6s
> > z*?WsYvy814Y^&IDtob_|FNxiWx^?-{iof5k1oA1hFgf8(8Q0$`)Zch3di~a~3U9u4
> > z^Nm|?ZohVubq&{FUmHKI8Oy2}U)f*ThK*HycoHq0e`Q;C_x2AcD6xX;S6YVKXa$Db
> > zZoX__0lY|us=?x}+w`!=o+D)34Jzvez`atZfVJjEt6@fr8u8ShyUg{VL!y(JlIu5$
> > z#nmEpLu?!+^I5l3eKj_;20QFSw^%G*%hyv_y)VsopS=8BLT+u4P!d4P?~~0a7O`-6
> > zd@y-|Bt+ICmffeWtgr2d`DT)2JzgPWG8Hn+%%86waRawy9wNhZTa`<>*eGJ#k#Y44
> > zFE_YqMC@v0gc0k1v2Oo%5E`FtqbZEGCrfg{la073!<Ek_TX9>qzZ}jF`ql_#zKmvF
> > zA3ilTa&+IL?K{-RKD*UNukO7tyf6jhPX=z^wiS=21_l?wyR}Uli<N}fS)_zl*f!mA
> > zXxr|t&K5V73;nruW%e*P=iQB<V;?fiv!9l!{209G+KjP@tk`5LL9b6XVwh+4uKU4@
> > z^h{&^<A>>i=i1z-ryDb%S?XldmdUW%K;NPH1#Fsj(j<oMT)Un>fyq<zE4@nbEE~^w
> > znn?6aIU5PO#3%lEP8FYL`JVv0%4i@Cb_B(amD1q5E#6ZN;WU@UOy!$Ge6RFk+WPaI
> > z42xlj0KX9(uw(eperOve+6}yu@cRarAKC|T275@1{fBR|^6T_jJQ~qwG5ump+kQ2%
> > zjrB)yh5bRhav%G$--;{uU%LAYwrt1QL>rA3?SWz7v>(N^N$DmqIAWKY?*NxDIO5ev
> > z?aDh*Y+R;=gY$P{Ayr5je5dnb!ms;nF~qcu{3r<qX~z3?I@f*szHJ=EHsud5qkM3#
> > zmrErK^d0BtdpR><#Vjo1A-X_UNQv{aN4KH7_iXi&D||1rS!r(JF*-|VZ04#xc9Kq#
> > z-r`OxahY%JRTFd<yL;)NSQLB47?K|a#TP|@J7zGLaj@z!Y+B;vtUNi#Pg3-Vu>S)s
> > Cro3tZ
> >
> > literal 0
> > HcmV?d00001
> >
> > diff --git a/tests/data/acpi/q35/DSDT.smm-compat-nosmm b/tests/data/acpi/q35/DSDT.smm-compat-nosmm
> > new file mode 100644
> > index 0000000000000000000000000000000000000000..c1965f6051ef2af81dd8412abe169d87845bb033
> > GIT binary patch
> > literal 8289
> > zcmb7JOKcm*8J^`!tL0K!Qk3OaY{E(UN|8{0Bx#EVC3pF<L~6yQ;si9nrRB7;og#}k
> > z2J%1vSpgEqhoT9aphr4TfZp0uuQkw1d-JUUdg`H<T#F(`4`IK5h9l3A6cF>U+JE-@
> > z{(rvNo&8obUf^~51;&j3l{egaP$<9Ry9N9V#u%N`U#F3{%(}Z?xz;n%v4qjRo#y8_
> > zl+FB)z4BJg`29}!c^JO+QE2odcI6A_vn&1RgFE3BMxa|)BFmx^r?Sus%DwKMYx!=Y
> > zX!hz2&n`W%Ota^Tv$)wSd2MF)wi+JGug~>10ylB@26MejtHV}uu#;V~oNn`<=e{|8
> > z@)w_9daHE*=l}TS-5XW{fV22(;_tbL4&i&Dbt)V>pAN1W?-QM0TOBTaI^dT@n?qNk
> > zkXr89qKQ(i?%(L{z38<|F7IQ;Z}~;HxQc$c?I3&FI{DEGV>S&A{r)r>js7A|nez^F
> > znx;@$G3$P%BUKvEMyk5Ib-&YOHe(OIO|wMzwnOpK%axW_@Y`Omkbk}xbV@9umN25G
> > z{=1>&ghTt2LC6MSdNkT+!-Y=<efGP)&HnY@<UZTC7DeB(*20JL)Rza}vIJx3&G(+A
> > z-q3h=_l`G$QjZTY%AZD8{6>2-W`&mRtSvqlmq0>w_s*}CJ%GhMilg`Fl`M1ATCN!(
> > z3z=cmjH~P_{+@}UT6gcM=El|mYjH_qnO5=)jZk;*?7H7smAMn*ej6Iru`)H|?fBbq
> > z(>$}wGoN)gng^UD&=}1boQLs;ab})zIOpkh$35sxdVK$Q>WD?mFwZapL)6MX8lzp`
> > z4LU~pzHOPfH59lQyR8BaUZJ}iR4!r`{LQv-<I)tk<znR`E|go%wvm1yXcV~R)>gCN
> > zH@sI0U8B72uCe^nzFWB%>pn@*XcX-bB6`QT#wbVk`_#P8^3RmOnT4WU5go!YHq3h|
> > z-wT=x!}amhc<{pC{~cU-xB1D+*Ue*pb(<08di~eo@X5h-Has@CX2mcA-sjJejmLJx
> > z_Oo&0HXYc#mErQ>x-}Q&k};NH{V2TCXKcT3`VF_r@^%k@jcA7==Qpn!^sqSY*L))T
> > z?T(*YySbZ7C-8K#_10R2iE{(zRhF}<-HIWo$smrP&T^Rq`hl4waN~$r04|7YoCl~3
> > ziHZCi8{<r1#}P3lG{!g+P|ie1O!S6h<D4mb5NE`c(70d%%9#j>DXU;!2`tZ(;7kck
> > z2&U{jLRDu{)0yN<2~7&7>^wqMXG+tV;!Fum={garI_ET<bDGXMT_-|Sr>W^QHJzre
> > z6QQaTZy;r)=QW-4x=w_uPD|5iX*w-kCqh+cTGN@<bf$Hk2vwbU7b^GD)^yssPK2t?
> > zjHWZA>CEUl5vn>DG@T2Y&IMg3LRIIYrgKr#xv1+zsOoeyosOo{(RCtJb!Ii4SxskF
> > z*NITonbUOUG@UtJCqh-{lBRP>)48PUM5yY_YdZ6q&b+P@p{jFP)48naT-J3WRCONF
> > zbRN-k9?^9oRCVG@0#BcO53OiAS9F~SRh>sQokumDM|GVDRh`E;vowAa9^=gN_+@uY
> > zFx^KXF}*SNxW+uLF^}s^gevod#yp`hPv}g9D)XeqJgG5H>P&<x^9halgvNYAXChRY
> > zr#Mr(%qh;4@Ay-KDPP<Oi7D^kX|3jIt>$UHCPGougn^b61FZ!Ol;&n?;2ed=28sY>
> > zMG!|Ii^4z!j$4w!h$Z`Hps0Wz7$`z14F)Q((m)j`8K{6B7$`#YMjEKVjw7n68mNFC
> > z7$`#Yh+|=(0y~bz8ab2<R6u2@>V$!cw44b8RiI>`2&F5Mfg+STVW0xbnJ`cVN(L&R
> > zye1haLa7r5DzKah16818paRO7WS|J8P8g`bawZH^fs%m=C})y^B9!+N1}d<e2?JH2
> > zWS|1dnPi{{rA`>Az;Y%GRDqI#3Mglifg+STVW0xbnJ`cVN(L&RoJj_XQ0jz%3M^;B
> > zKouw%sDN@N87M-j69y`<oCyO}pk$x|%9&)K2&GOKsK9b23{-)VfeI*Rl7S+WI$@v!
> > z%b74x1xf}gpqxnticso=feI{V!ax-$8K{7ACK)I~sS^e&u$&14RiI>`0?L_Wpa`W-
> > z7^uK<CJa=8l7R{+XOe*;lsaLc0?U~&Pz6c`DxjQ628vMXgn<eyXTm@gC>f}LawZul
> > zLa7r5DzKah16818paRO7WS|J8P8g`bawZH^fs%m=C})y^B9uB|paRR8Fi-_b1}dPO
> > zNd}5g>V$y`EN8+%6(|{~fN~}oC_<?d28u{AP(-SMB2*0&p<<v469%d<$v_n*8K}a9
> > zfhtTGsKO)zRhVR;3KIsZFkzqylMGa0l7T8r7^uR8fhtTgP=!ebsxV=oh~(Xcfg-{k
> > z<AX^CiV(L!hQyR(3j;+Y#})>PNRBNTC_*{5WS|JKRCK%t3uQxl!2em@r+-NArRYzo
> > zd;6!)#p%CPTGgQS4#RJ6mf*OXWjeTY@Jxoam(2>DSLslrL*2|TH8!ytFr0tS+TFn-
> > z%ly8T&Yy2=y6t%Y+QsaGmHs%z=J`s{JM1pCSxFol(R(}ABBL{OqK&1O^*MYal;o0!
> > zjpZ6z3^LK}AbZ4G`gnoO$Kh@a?{9`TF;*|~i+mkupSpnFl=9i0*9h4AbZ+hPmPJ~R
> > zVnDcU9<TI*c3|Ay8TWz8Q~S7jd7?TNPrh^YvQoXwtC!I~wR$-}yL!31*Cg#?DGkeg
> > zW9?S#G0MA2d6$=WC(65rly}GFy$SIa7PP*zdQU0u@$%k8dGC<&-ne{avV7t(%2$-~
> > z6<)qFQND6W`O3I_b+UZ&G0In!@>O2GI#IrQNcrlxd~LFP>M_dKl=3xRzBW<5c1Zc!
> > zxO{!G{M=)duPf#2ynKD4eEpE}b(Bxgt8B8oBg)H{2R<t>-NpK?-j+}CDUUxiugB>o
> > zr?HjQ)8SiVDxGMXnQm%c=Ja&<0GUcB+GeJknrB!7rg<iX;j3gSooJhxZff4-^>p}D
> > znMx<xW~Q5(2g`aoe7{Vk6KyloO+D8~^mO>BnMx<xW~Q5ZPFM7F_|ln5C))IM&WT6s
> > z*?WsYvy814Y^&IDtob_|FNxiWx^?-{iof5k1oA1hFgf8(8Q0$`)Zch3di~a~3U9u4
> > z^Nm|?ZohVubq&{FUmHKI8Oy2}U)f*ThK*HycoHq0e`Q;C_x2AcD6xX;S6YVKXa$Db
> > zZoX__0lY|us=?x}+w`!=o+D)34Jzvez`atZfVJjEt6@fr8u8ShyUg{VL!y(JlIu5$
> > z#nmEpLu?!+^I5l3eKj_;20QFSw^%G*%hyv_y)VsopS=8BLT+u4P!d4P?~~0a7O`-6
> > zd@y-|Bt+ICmffeWtgr2d`DT)2JzgPWG8Hn+%%86waRawy9wNhZTa`<>*eGJ#k#Y44
> > zFE_YqMC@v0gc0k1v2Oo%5E`FtqbZEGCrfg{la073!<Ek_TX9>qzZ}jF`ql_#zKmvF
> > zA3ilTa&+IL?K{-RKD*UNukO7tyf6jhPX=z^wiS=21_l?wyR}Uli<N}fS)_zl*f!mA
> > zXxr|t&K5V73;nruW%e*P=iQB<V;?fiv!9l!{209G+KjP@tk`5LL9b6XVwh+4uKU4@
> > z^h{&^<A>>i=i1z-ryDb%S?XldmdUW%K;NPH1#Fsj(j<oMT)Un>fyq<zE4@nbEE~^w
> > znn?6aIU5PO#3%lEP8FYL`JVv0%4i@Cb_B(amD1q5E#6ZN;WU@UOy!$Ge6RFk+WPaI
> > z42xlj0KX9(uw(eperOve+6}yu@cRarAKC|T275@1{fBR|^6T_jJQ~qwG5ump+kQ2%
> > zjrB)yh5bRhav%G$--;{uU%LAYwrt1QL>rA3?SWz7v>(N^N$DmqIAWKY?*NxDIO5ev
> > z?aDh*Y+R;=gY$P{Ayr5je5dnb!ms;nF~qcu{3r<qX~z3?I@f*szHJ=EHsud5qkM3#
> > zmrErK^d0BtdpR><#Vjo1A-X_UNQv{aN4KH7_iXi&D||1rS!r(JF*-|VZ04#xc9Kq#
> > z-r`OxahY%JRTFd<yL;)NSQLB47?K|a#TP|@J7zGLaj@z!Y+B;vtUNi#Pg3-Vu>S)s
> > Cro3tZ
> >
> > literal 0
> > HcmV?d00001
> >
> > diff --git a/tests/data/acpi/q35/DSDT.tis.tpm12 b/tests/data/acpi/q35/DSDT.tis.tpm12
> > index c96b5277a14ae98174408d690d6e0246bd932623..0ebdf6fbd77967f1ab5d5337b7b1fed314cfaca8 100644
> > GIT binary patch
> > delta 24
> > gcmdnzy3du%CD<iopArKDqxwXyD~xg*@84Gh0A(f!W&i*H
> >
> > delta 24
> > gcmdnzy3du%CD<iopArKDquNBSD~$3R@84Gh0A(QvW&i*H
> >
> > diff --git a/tests/data/acpi/q35/DSDT.tis.tpm2 b/tests/data/acpi/q35/DSDT.tis.tpm2
> > index c92d4d29c79352a60974ea9f665d0b9a410a4bac..dcbb7f0af377425db53130e8ba1c62c09c22e006 100644
> > GIT binary patch
> > delta 24
> > gcmdnzy3du%CD<iopArKD<D-dOR~Y3s-oLL10Bm##ApigX
> >
> > delta 24
> > gcmdnzy3du%CD<iopArKD<HLzuR~Y3t-oLL10BmmwApigX
> >
> > diff --git a/tests/data/acpi/q35/DSDT.xapic b/tests/data/acpi/q35/DSDT.xapic
> > index 119fc90f1f8a7b6934df6fd95609446e627ce15d..17552ce363ae81985f69f9ae85837a1540b79ae0 100644
> > GIT binary patch
> > delta 26
> > icmX>yjp@iVCN7s?mk^h31_s6r6S=N1%5A)#+64f6_X&Rh
> >
> > delta 26
> > icmX>yjp@iVCN7s?mk^h31_s9U6S=N1%5S`%+64f6@(F(c
> >
> > --
> > 2.27.0
>
>
^ permalink raw reply [flat|nested] 24+ messages in thread
* Re: [PATCH for 6.2 v2 5/5] bios-tables-test: Update golden binaries
2021-11-11 9:27 ` Ani Sinha
@ 2021-11-11 9:44 ` Ani Sinha
2021-11-12 8:56 ` Ani Sinha
0 siblings, 1 reply; 24+ messages in thread
From: Ani Sinha @ 2021-11-11 9:44 UTC (permalink / raw)
To: Ani Sinha
Cc: mapfelba, Michael S. Tsirkin, jusual, qemu-devel, kraxel, Igor Mammedov
On Thu, 11 Nov 2021, Ani Sinha wrote:
>
>
> On Thu, 11 Nov 2021, Michael S. Tsirkin wrote:
>
> > On Wed, Nov 10, 2021 at 04:11:40PM -0500, Igor Mammedov wrote:
> > > From: Julia Suvorova <jusual@redhat.com>
> > >
> > > The changes are the result of
> > > 'hw/i386/acpi-build: Deny control on PCIe Native Hot-Plug in _OSC'
> > > and listed here:
> > >
> > > Method (_OSC, 4, NotSerialized) // _OSC: Operating System Capabilities
> > > {
> > > CreateDWordField (Arg3, Zero, CDW1)
> > > If ((Arg0 == ToUUID ("33db4d5b-1ff7-401c-9657-7441c03dd766") /* PCI Host Bridge Device */))
> > > {
> > > CreateDWordField (Arg3, 0x04, CDW2)
> > > CreateDWordField (Arg3, 0x08, CDW3)
> > > Local0 = CDW3 /* \_SB_.PCI0._OSC.CDW3 */
> > > - Local0 &= 0x1F
> > > + Local0 &= 0x1E
> > >
> > > Signed-off-by: Julia Suvorova <jusual@redhat.com>
> > > Signed-off-by: Igor Mammedov <imammedo@redhat.com>
> > > ---
> > > tests/qtest/bios-tables-test-allowed-diff.h | 16 ----------------
> > > tests/data/acpi/q35/DSDT | Bin 8289 -> 8289 bytes
> > > tests/data/acpi/q35/DSDT.acpihmat | Bin 9614 -> 9614 bytes
> > > tests/data/acpi/q35/DSDT.bridge | Bin 11003 -> 11003 bytes
> > > tests/data/acpi/q35/DSDT.cphp | Bin 8753 -> 8753 bytes
> > > tests/data/acpi/q35/DSDT.dimmpxm | Bin 9943 -> 9943 bytes
> > > tests/data/acpi/q35/DSDT.dmar | Bin 0 -> 8289 bytes
> > > tests/data/acpi/q35/DSDT.ipmibt | Bin 8364 -> 8364 bytes
> > > tests/data/acpi/q35/DSDT.ivrs | Bin 8306 -> 8306 bytes
> > > tests/data/acpi/q35/DSDT.memhp | Bin 9648 -> 9648 bytes
> > > tests/data/acpi/q35/DSDT.mmio64 | Bin 9419 -> 9419 bytes
> > > tests/data/acpi/q35/DSDT.multi-bridge | Bin 8583 -> 8583 bytes
> > > tests/data/acpi/q35/DSDT.nohpet | Bin 8147 -> 8147 bytes
> > > tests/data/acpi/q35/DSDT.nosmm | Bin 0 -> 8289 bytes
> > > tests/data/acpi/q35/DSDT.numamem | Bin 8295 -> 8295 bytes
> > > tests/data/acpi/q35/DSDT.smm-compat | Bin 0 -> 8289 bytes
> > > tests/data/acpi/q35/DSDT.smm-compat-nosmm | Bin 0 -> 8289 bytes
> > > tests/data/acpi/q35/DSDT.tis.tpm12 | Bin 8894 -> 8894 bytes
> > > tests/data/acpi/q35/DSDT.tis.tpm2 | Bin 8894 -> 8894 bytes
> > > tests/data/acpi/q35/DSDT.xapic | Bin 35652 -> 35652 bytes
> >
> > Why do we have all the new files? What is going on here?
>
> Good catch. I saw those files even in my workspace and failed to notice
> that they were being newly created in this patch and they did not exist
> previously:
> https://git.qemu.org/?p=qemu.git;a=tree;f=tests/data/acpi/q35;h=e9d1edd2671997a3e7fe278018313bcbfcfb0850;hb=HEAD
>
>
> >
> > > 20 files changed, 16 deletions(-)
> > > create mode 100644 tests/data/acpi/q35/DSDT.dmar
>
> The corresponding change that adds the test is :
>
> commit 0ff92b6d99011c8de57321503c0eb655c461a217
> Author: Igor Mammedov <imammedo@redhat.com>
> Date: Thu Sep 2 07:35:43 2021 -0400
>
> tests: acpi: add testcase for intel_iommu (DMAR table)
>
> Igor has updated the DMAR table blob here:
>
> commit 44d3bdd8a6f1ae2a5ca417251736a033900d4c08
> Author: Igor Mammedov <imammedo@redhat.com>
> Date: Thu Sep 2 07:35:44 2021 -0400
>
> tests: acpi: add expected blob for DMAR table
>
> but maybe the test also introduced changes in DSDT table as well?
> Needs more investigation.
Actually I am pretty sure that no changes in DSDT was introduced with the
above test. If it did, the tests would be broken because Igor did not
update the DSDT table blob. So we should not commit the
tests/data/acpi/q35/DSDT.dmar
table blob here.
>
> > > create mode 100644 tests/data/acpi/q35/DSDT.nosmm
> > > create mode 100644 tests/data/acpi/q35/DSDT.smm-compat
> > > create mode 100644 tests/data/acpi/q35/DSDT.smm-compat-nosmm
>
> The corresponding tests for these files were added in this commit:
>
> commit 0dabb2e802437c2e578dc72bd0bdf3380a25ec96
> Author: Isaku Yamahata <isaku.yamahata@intel.com>
> Date: Wed Feb 17 21:51:14 2021 -0800
>
> BUT it seems that by mistake the table blobs were not added when the
> following commit was made:
>
> commit 7b630d937a6c73fb145746fb31e0fb4b08f0cf0e
> Author: Isaku Yamahata <isaku.yamahata@intel.com>
> Date: Wed Feb 17 21:51:18 2021 -0800
>
> qtest/acpi/bios-tables-test: update acpi tables
>
> Sadly, the above commit does update tests/data/acpi/q35/DSDT which I
> believe includes the changes for the above tests. The commit message
> does not add the ASL diff which the tests introduces.
We need to check this one. If the above commit did indeed introduce
changes in DSDT blob which it should have done tgrough those additional
table blob files.
>
> I believe at some point I did TEST_ACPI_REBUILD_AML which regenrated those
> files in my workspace and hence they were there. Same could be true for
> Igor and got added when he generated the commit.
>
> > >
> > > diff --git a/tests/qtest/bios-tables-test-allowed-diff.h b/tests/qtest/bios-tables-test-allowed-diff.h
> > > index 48e5634d4b..dfb8523c8b 100644
> > > --- a/tests/qtest/bios-tables-test-allowed-diff.h
> > > +++ b/tests/qtest/bios-tables-test-allowed-diff.h
> > > @@ -1,17 +1 @@
> > > /* List of comma-separated changed AML files to ignore */
> > > -"tests/data/acpi/q35/DSDT",
> > > -"tests/data/acpi/q35/DSDT.tis",
> > > -"tests/data/acpi/q35/DSDT.bridge",
> > > -"tests/data/acpi/q35/DSDT.mmio64",
> > > -"tests/data/acpi/q35/DSDT.ipmibt",
> > > -"tests/data/acpi/q35/DSDT.cphp",
> > > -"tests/data/acpi/q35/DSDT.memhp",
> > > -"tests/data/acpi/q35/DSDT.acpihmat",
> > > -"tests/data/acpi/q35/DSDT.numamem",
> > > -"tests/data/acpi/q35/DSDT.dimmpxm",
> > > -"tests/data/acpi/q35/DSDT.nohpet",
> > > -"tests/data/acpi/q35/DSDT.tis.tpm2",
> > > -"tests/data/acpi/q35/DSDT.tis.tpm12",
> > > -"tests/data/acpi/q35/DSDT.multi-bridge",
> > > -"tests/data/acpi/q35/DSDT.ivrs",
> > > -"tests/data/acpi/q35/DSDT.xapic",
> > > diff --git a/tests/data/acpi/q35/DSDT b/tests/data/acpi/q35/DSDT
> > > index 281fc82c03b2562d2e6b7caec0d817b034a47138..c1965f6051ef2af81dd8412abe169d87845bb033 100644
> > > GIT binary patch
> > > delta 24
> > > gcmaFp@X&$FCD<h-QGtPh@z+GID~xg*?>ET<0BnZ{w*UYD
> > >
> > > delta 24
> > > gcmaFp@X&$FCD<h-QGtPh@#jRYD~$3R?>ET<0BnK?w*UYD
> > >
> > > diff --git a/tests/data/acpi/q35/DSDT.acpihmat b/tests/data/acpi/q35/DSDT.acpihmat
> > > index 8c1e05a11a328ec1cc6f86e36e52c28f41f9744e..f24d4874bff8d327a165ed7c36de507aea114edd 100644
> > > GIT binary patch
> > > delta 24
> > > fcmeD4?(^ny33dtTQ)OUa+&+=(3ZvY{`|DKzU@Hhn
> > >
> > > delta 24
> > > fcmeD4?(^ny33dtTQ)OUa+%}Qx3ZwkS`|DKzU?vDi
> > >
> > > diff --git a/tests/data/acpi/q35/DSDT.bridge b/tests/data/acpi/q35/DSDT.bridge
> > > index 6f1464b6c712d7f33cb4b891b7ce76fe228f44c9..424d51bd1cb39ea73501ef7d0044ee52cec5bdac 100644
> > > GIT binary patch
> > > delta 24
> > > gcmewz`a6`%CD<k8w-y5fBg;gtD~xg*@5^Wb0CWThXaE2J
> > >
> > > delta 24
> > > gcmewz`a6`%CD<k8w-y5fBlASAD~$3R@5^Wb0CWEcXaE2J
> > >
> > > diff --git a/tests/data/acpi/q35/DSDT.cphp b/tests/data/acpi/q35/DSDT.cphp
> > > index f8337ff5191a37a47dcf7c09a6c39c4e704a15bf..f1275606f68eeba54bfb11e63d818420385a62b9 100644
> > > GIT binary patch
> > > delta 24
> > > fcmdn!veAXhCD<jzP>F$oF>WH)6-K#@_k$DxTWtqt
> > >
> > > delta 24
> > > fcmdn!veAXhCD<jzP>F$oF?J%?6-N1u_k$DxTWAMo
> > >
> > > diff --git a/tests/data/acpi/q35/DSDT.dimmpxm b/tests/data/acpi/q35/DSDT.dimmpxm
> > > index fe5820d93d057ef09a001662369b15afbc5b87e2..76e451e829ec4c245315f7eed8731aa1be45a747 100644
> > > GIT binary patch
> > > delta 24
> > > gcmccad)=4ICD<k8x*7umqsK(9D~xg*@BdH*0B$o00{{R3
> > >
> > > delta 24
> > > gcmccad)=4ICD<k8x*7umqx(dzD~$3R@BdH*0B$Y`0{{R3
> > >
> > > diff --git a/tests/data/acpi/q35/DSDT.dmar b/tests/data/acpi/q35/DSDT.dmar
> > > new file mode 100644
> > > index 0000000000000000000000000000000000000000..c1965f6051ef2af81dd8412abe169d87845bb033
> > > GIT binary patch
> > > literal 8289
> > > zcmb7JOKcm*8J^`!tL0K!Qk3OaY{E(UN|8{0Bx#EVC3pF<L~6yQ;si9nrRB7;og#}k
> > > z2J%1vSpgEqhoT9aphr4TfZp0uuQkw1d-JUUdg`H<T#F(`4`IK5h9l3A6cF>U+JE-@
> > > z{(rvNo&8obUf^~51;&j3l{egaP$<9Ry9N9V#u%N`U#F3{%(}Z?xz;n%v4qjRo#y8_
> > > zl+FB)z4BJg`29}!c^JO+QE2odcI6A_vn&1RgFE3BMxa|)BFmx^r?Sus%DwKMYx!=Y
> > > zX!hz2&n`W%Ota^Tv$)wSd2MF)wi+JGug~>10ylB@26MejtHV}uu#;V~oNn`<=e{|8
> > > z@)w_9daHE*=l}TS-5XW{fV22(;_tbL4&i&Dbt)V>pAN1W?-QM0TOBTaI^dT@n?qNk
> > > zkXr89qKQ(i?%(L{z38<|F7IQ;Z}~;HxQc$c?I3&FI{DEGV>S&A{r)r>js7A|nez^F
> > > znx;@$G3$P%BUKvEMyk5Ib-&YOHe(OIO|wMzwnOpK%axW_@Y`Omkbk}xbV@9umN25G
> > > z{=1>&ghTt2LC6MSdNkT+!-Y=<efGP)&HnY@<UZTC7DeB(*20JL)Rza}vIJx3&G(+A
> > > z-q3h=_l`G$QjZTY%AZD8{6>2-W`&mRtSvqlmq0>w_s*}CJ%GhMilg`Fl`M1ATCN!(
> > > z3z=cmjH~P_{+@}UT6gcM=El|mYjH_qnO5=)jZk;*?7H7smAMn*ej6Iru`)H|?fBbq
> > > z(>$}wGoN)gng^UD&=}1boQLs;ab})zIOpkh$35sxdVK$Q>WD?mFwZapL)6MX8lzp`
> > > z4LU~pzHOPfH59lQyR8BaUZJ}iR4!r`{LQv-<I)tk<znR`E|go%wvm1yXcV~R)>gCN
> > > zH@sI0U8B72uCe^nzFWB%>pn@*XcX-bB6`QT#wbVk`_#P8^3RmOnT4WU5go!YHq3h|
> > > z-wT=x!}amhc<{pC{~cU-xB1D+*Ue*pb(<08di~eo@X5h-Has@CX2mcA-sjJejmLJx
> > > z_Oo&0HXYc#mErQ>x-}Q&k};NH{V2TCXKcT3`VF_r@^%k@jcA7==Qpn!^sqSY*L))T
> > > z?T(*YySbZ7C-8K#_10R2iE{(zRhF}<-HIWo$smrP&T^Rq`hl4waN~$r04|7YoCl~3
> > > ziHZCi8{<r1#}P3lG{!g+P|ie1O!S6h<D4mb5NE`c(70d%%9#j>DXU;!2`tZ(;7kck
> > > z2&U{jLRDu{)0yN<2~7&7>^wqMXG+tV;!Fum={garI_ET<bDGXMT_-|Sr>W^QHJzre
> > > z6QQaTZy;r)=QW-4x=w_uPD|5iX*w-kCqh+cTGN@<bf$Hk2vwbU7b^GD)^yssPK2t?
> > > zjHWZA>CEUl5vn>DG@T2Y&IMg3LRIIYrgKr#xv1+zsOoeyosOo{(RCtJb!Ii4SxskF
> > > z*NITonbUOUG@UtJCqh-{lBRP>)48PUM5yY_YdZ6q&b+P@p{jFP)48naT-J3WRCONF
> > > zbRN-k9?^9oRCVG@0#BcO53OiAS9F~SRh>sQokumDM|GVDRh`E;vowAa9^=gN_+@uY
> > > zFx^KXF}*SNxW+uLF^}s^gevod#yp`hPv}g9D)XeqJgG5H>P&<x^9halgvNYAXChRY
> > > zr#Mr(%qh;4@Ay-KDPP<Oi7D^kX|3jIt>$UHCPGougn^b61FZ!Ol;&n?;2ed=28sY>
> > > zMG!|Ii^4z!j$4w!h$Z`Hps0Wz7$`z14F)Q((m)j`8K{6B7$`#YMjEKVjw7n68mNFC
> > > z7$`#Yh+|=(0y~bz8ab2<R6u2@>V$!cw44b8RiI>`2&F5Mfg+STVW0xbnJ`cVN(L&R
> > > zye1haLa7r5DzKah16818paRO7WS|J8P8g`bawZH^fs%m=C})y^B9!+N1}d<e2?JH2
> > > zWS|1dnPi{{rA`>Az;Y%GRDqI#3Mglifg+STVW0xbnJ`cVN(L&RoJj_XQ0jz%3M^;B
> > > zKouw%sDN@N87M-j69y`<oCyO}pk$x|%9&)K2&GOKsK9b23{-)VfeI*Rl7S+WI$@v!
> > > z%b74x1xf}gpqxnticso=feI{V!ax-$8K{7ACK)I~sS^e&u$&14RiI>`0?L_Wpa`W-
> > > z7^uK<CJa=8l7R{+XOe*;lsaLc0?U~&Pz6c`DxjQ628vMXgn<eyXTm@gC>f}LawZul
> > > zLa7r5DzKah16818paRO7WS|J8P8g`bawZH^fs%m=C})y^B9uB|paRR8Fi-_b1}dPO
> > > zNd}5g>V$y`EN8+%6(|{~fN~}oC_<?d28u{AP(-SMB2*0&p<<v469%d<$v_n*8K}a9
> > > zfhtTGsKO)zRhVR;3KIsZFkzqylMGa0l7T8r7^uR8fhtTgP=!ebsxV=oh~(Xcfg-{k
> > > z<AX^CiV(L!hQyR(3j;+Y#})>PNRBNTC_*{5WS|JKRCK%t3uQxl!2em@r+-NArRYzo
> > > zd;6!)#p%CPTGgQS4#RJ6mf*OXWjeTY@Jxoam(2>DSLslrL*2|TH8!ytFr0tS+TFn-
> > > z%ly8T&Yy2=y6t%Y+QsaGmHs%z=J`s{JM1pCSxFol(R(}ABBL{OqK&1O^*MYal;o0!
> > > zjpZ6z3^LK}AbZ4G`gnoO$Kh@a?{9`TF;*|~i+mkupSpnFl=9i0*9h4AbZ+hPmPJ~R
> > > zVnDcU9<TI*c3|Ay8TWz8Q~S7jd7?TNPrh^YvQoXwtC!I~wR$-}yL!31*Cg#?DGkeg
> > > zW9?S#G0MA2d6$=WC(65rly}GFy$SIa7PP*zdQU0u@$%k8dGC<&-ne{avV7t(%2$-~
> > > z6<)qFQND6W`O3I_b+UZ&G0In!@>O2GI#IrQNcrlxd~LFP>M_dKl=3xRzBW<5c1Zc!
> > > zxO{!G{M=)duPf#2ynKD4eEpE}b(Bxgt8B8oBg)H{2R<t>-NpK?-j+}CDUUxiugB>o
> > > zr?HjQ)8SiVDxGMXnQm%c=Ja&<0GUcB+GeJknrB!7rg<iX;j3gSooJhxZff4-^>p}D
> > > znMx<xW~Q5(2g`aoe7{Vk6KyloO+D8~^mO>BnMx<xW~Q5ZPFM7F_|ln5C))IM&WT6s
> > > z*?WsYvy814Y^&IDtob_|FNxiWx^?-{iof5k1oA1hFgf8(8Q0$`)Zch3di~a~3U9u4
> > > z^Nm|?ZohVubq&{FUmHKI8Oy2}U)f*ThK*HycoHq0e`Q;C_x2AcD6xX;S6YVKXa$Db
> > > zZoX__0lY|us=?x}+w`!=o+D)34Jzvez`atZfVJjEt6@fr8u8ShyUg{VL!y(JlIu5$
> > > z#nmEpLu?!+^I5l3eKj_;20QFSw^%G*%hyv_y)VsopS=8BLT+u4P!d4P?~~0a7O`-6
> > > zd@y-|Bt+ICmffeWtgr2d`DT)2JzgPWG8Hn+%%86waRawy9wNhZTa`<>*eGJ#k#Y44
> > > zFE_YqMC@v0gc0k1v2Oo%5E`FtqbZEGCrfg{la073!<Ek_TX9>qzZ}jF`ql_#zKmvF
> > > zA3ilTa&+IL?K{-RKD*UNukO7tyf6jhPX=z^wiS=21_l?wyR}Uli<N}fS)_zl*f!mA
> > > zXxr|t&K5V73;nruW%e*P=iQB<V;?fiv!9l!{209G+KjP@tk`5LL9b6XVwh+4uKU4@
> > > z^h{&^<A>>i=i1z-ryDb%S?XldmdUW%K;NPH1#Fsj(j<oMT)Un>fyq<zE4@nbEE~^w
> > > znn?6aIU5PO#3%lEP8FYL`JVv0%4i@Cb_B(amD1q5E#6ZN;WU@UOy!$Ge6RFk+WPaI
> > > z42xlj0KX9(uw(eperOve+6}yu@cRarAKC|T275@1{fBR|^6T_jJQ~qwG5ump+kQ2%
> > > zjrB)yh5bRhav%G$--;{uU%LAYwrt1QL>rA3?SWz7v>(N^N$DmqIAWKY?*NxDIO5ev
> > > z?aDh*Y+R;=gY$P{Ayr5je5dnb!ms;nF~qcu{3r<qX~z3?I@f*szHJ=EHsud5qkM3#
> > > zmrErK^d0BtdpR><#Vjo1A-X_UNQv{aN4KH7_iXi&D||1rS!r(JF*-|VZ04#xc9Kq#
> > > z-r`OxahY%JRTFd<yL;)NSQLB47?K|a#TP|@J7zGLaj@z!Y+B;vtUNi#Pg3-Vu>S)s
> > > Cro3tZ
> > >
> > > literal 0
> > > HcmV?d00001
> > >
> > > diff --git a/tests/data/acpi/q35/DSDT.ipmibt b/tests/data/acpi/q35/DSDT.ipmibt
> > > index 631741065860fd5036aa303904dabd1d2839f9c6..6ad2411d0ec95f204cfc64b430c537bce09c35bd 100644
> > > GIT binary patch
> > > delta 24
> > > gcmZ4ExW<voCD<iojRFG$quxZWD~xg*@1K<i0AMf(82|tP
> > >
> > > delta 24
> > > gcmZ4ExW<voCD<iojRFG$qwYkmD~$3R@1K<i0AMQ!82|tP
> > >
> > > diff --git a/tests/data/acpi/q35/DSDT.ivrs b/tests/data/acpi/q35/DSDT.ivrs
> > > index b0eafe90e5832935557ec5e6802c0147c88f379c..cad26e3f0c27a40a33101155a5282ed9bcb1d441 100644
> > > GIT binary patch
> > > delta 24
> > > gcmez5@X3M8CD<jTNP&TYan?kxD~xg*?@yKo0BrUMn*aa+
> > >
> > > delta 24
> > > gcmez5@X3M8CD<jTNP&TYappv>D~$3R?@yKo0BrFHn*aa+
> > >
> > > diff --git a/tests/data/acpi/q35/DSDT.memhp b/tests/data/acpi/q35/DSDT.memhp
> > > index 9bc11518fc57687ca789dc70793b48b29a0d74ed..4e9cb3dc6896bb79ccac0fe342a404549f6610e8 100644
> > > GIT binary patch
> > > delta 24
> > > gcmdnsy}_HyCD<iogDL|9<C}?GR~Y3s-oK~<0BV~F1poj5
> > >
> > > delta 24
> > > gcmdnsy}_HyCD<iogDL|9<LilBR~Y3t-oK~<0BV*A1poj5
> > >
> > > diff --git a/tests/data/acpi/q35/DSDT.mmio64 b/tests/data/acpi/q35/DSDT.mmio64
> > > index 713288a12ef2b70a20b4e8836c036ba4db3a57a8..eb5a1c7171c02d153487bfcecfb7019b7c1bf406 100644
> > > GIT binary patch
> > > delta 24
> > > gcmX@@dD@f9CD<k8v<d?Q<BEw~R~Y3s-hZPE0B$h}CjbBd
> > >
> > > delta 24
> > > gcmX@@dD@f9CD<k8v<d?Q<MN4IR~Y3t-hZPE0B$S^CjbBd
> > >
> > > diff --git a/tests/data/acpi/q35/DSDT.multi-bridge b/tests/data/acpi/q35/DSDT.multi-bridge
> > > index a24c713d22102a1a1583b5c902edffe1694e5cfe..45808eb03b78d07ebbe853f674abfed589d35e26 100644
> > > GIT binary patch
> > > delta 24
> > > fcmZp7Zg=K#33dr-S7cyd?3>7Sg;8$f{S^uTTRaEr
> > >
> > > delta 24
> > > fcmZp7Zg=K#33dr-S7cyd?48JUg;9Rv{S^uTTQ>*m
> > >
> > > diff --git a/tests/data/acpi/q35/DSDT.nohpet b/tests/data/acpi/q35/DSDT.nohpet
> > > index e8202e6ddfbe96071f32f1ec05758f650569943e..83d1aa00ac5686df479673fb0d7830f946e25dea 100644
> > > GIT binary patch
> > > delta 24
> > > gcmca?f7zbPCD<k8vOEI=<B^G6R~Y3s-v1&80B=4CMF0Q*
> > >
> > > delta 24
> > > gcmca?f7zbPCD<k8vOEI=<Kc;1R~Y3t-v1&80B<=7MF0Q*
> > >
> > > diff --git a/tests/data/acpi/q35/DSDT.nosmm b/tests/data/acpi/q35/DSDT.nosmm
> > > new file mode 100644
> > > index 0000000000000000000000000000000000000000..c1965f6051ef2af81dd8412abe169d87845bb033
> > > GIT binary patch
> > > literal 8289
> > > zcmb7JOKcm*8J^`!tL0K!Qk3OaY{E(UN|8{0Bx#EVC3pF<L~6yQ;si9nrRB7;og#}k
> > > z2J%1vSpgEqhoT9aphr4TfZp0uuQkw1d-JUUdg`H<T#F(`4`IK5h9l3A6cF>U+JE-@
> > > z{(rvNo&8obUf^~51;&j3l{egaP$<9Ry9N9V#u%N`U#F3{%(}Z?xz;n%v4qjRo#y8_
> > > zl+FB)z4BJg`29}!c^JO+QE2odcI6A_vn&1RgFE3BMxa|)BFmx^r?Sus%DwKMYx!=Y
> > > zX!hz2&n`W%Ota^Tv$)wSd2MF)wi+JGug~>10ylB@26MejtHV}uu#;V~oNn`<=e{|8
> > > z@)w_9daHE*=l}TS-5XW{fV22(;_tbL4&i&Dbt)V>pAN1W?-QM0TOBTaI^dT@n?qNk
> > > zkXr89qKQ(i?%(L{z38<|F7IQ;Z}~;HxQc$c?I3&FI{DEGV>S&A{r)r>js7A|nez^F
> > > znx;@$G3$P%BUKvEMyk5Ib-&YOHe(OIO|wMzwnOpK%axW_@Y`Omkbk}xbV@9umN25G
> > > z{=1>&ghTt2LC6MSdNkT+!-Y=<efGP)&HnY@<UZTC7DeB(*20JL)Rza}vIJx3&G(+A
> > > z-q3h=_l`G$QjZTY%AZD8{6>2-W`&mRtSvqlmq0>w_s*}CJ%GhMilg`Fl`M1ATCN!(
> > > z3z=cmjH~P_{+@}UT6gcM=El|mYjH_qnO5=)jZk;*?7H7smAMn*ej6Iru`)H|?fBbq
> > > z(>$}wGoN)gng^UD&=}1boQLs;ab})zIOpkh$35sxdVK$Q>WD?mFwZapL)6MX8lzp`
> > > z4LU~pzHOPfH59lQyR8BaUZJ}iR4!r`{LQv-<I)tk<znR`E|go%wvm1yXcV~R)>gCN
> > > zH@sI0U8B72uCe^nzFWB%>pn@*XcX-bB6`QT#wbVk`_#P8^3RmOnT4WU5go!YHq3h|
> > > z-wT=x!}amhc<{pC{~cU-xB1D+*Ue*pb(<08di~eo@X5h-Has@CX2mcA-sjJejmLJx
> > > z_Oo&0HXYc#mErQ>x-}Q&k};NH{V2TCXKcT3`VF_r@^%k@jcA7==Qpn!^sqSY*L))T
> > > z?T(*YySbZ7C-8K#_10R2iE{(zRhF}<-HIWo$smrP&T^Rq`hl4waN~$r04|7YoCl~3
> > > ziHZCi8{<r1#}P3lG{!g+P|ie1O!S6h<D4mb5NE`c(70d%%9#j>DXU;!2`tZ(;7kck
> > > z2&U{jLRDu{)0yN<2~7&7>^wqMXG+tV;!Fum={garI_ET<bDGXMT_-|Sr>W^QHJzre
> > > z6QQaTZy;r)=QW-4x=w_uPD|5iX*w-kCqh+cTGN@<bf$Hk2vwbU7b^GD)^yssPK2t?
> > > zjHWZA>CEUl5vn>DG@T2Y&IMg3LRIIYrgKr#xv1+zsOoeyosOo{(RCtJb!Ii4SxskF
> > > z*NITonbUOUG@UtJCqh-{lBRP>)48PUM5yY_YdZ6q&b+P@p{jFP)48naT-J3WRCONF
> > > zbRN-k9?^9oRCVG@0#BcO53OiAS9F~SRh>sQokumDM|GVDRh`E;vowAa9^=gN_+@uY
> > > zFx^KXF}*SNxW+uLF^}s^gevod#yp`hPv}g9D)XeqJgG5H>P&<x^9halgvNYAXChRY
> > > zr#Mr(%qh;4@Ay-KDPP<Oi7D^kX|3jIt>$UHCPGougn^b61FZ!Ol;&n?;2ed=28sY>
> > > zMG!|Ii^4z!j$4w!h$Z`Hps0Wz7$`z14F)Q((m)j`8K{6B7$`#YMjEKVjw7n68mNFC
> > > z7$`#Yh+|=(0y~bz8ab2<R6u2@>V$!cw44b8RiI>`2&F5Mfg+STVW0xbnJ`cVN(L&R
> > > zye1haLa7r5DzKah16818paRO7WS|J8P8g`bawZH^fs%m=C})y^B9!+N1}d<e2?JH2
> > > zWS|1dnPi{{rA`>Az;Y%GRDqI#3Mglifg+STVW0xbnJ`cVN(L&RoJj_XQ0jz%3M^;B
> > > zKouw%sDN@N87M-j69y`<oCyO}pk$x|%9&)K2&GOKsK9b23{-)VfeI*Rl7S+WI$@v!
> > > z%b74x1xf}gpqxnticso=feI{V!ax-$8K{7ACK)I~sS^e&u$&14RiI>`0?L_Wpa`W-
> > > z7^uK<CJa=8l7R{+XOe*;lsaLc0?U~&Pz6c`DxjQ628vMXgn<eyXTm@gC>f}LawZul
> > > zLa7r5DzKah16818paRO7WS|J8P8g`bawZH^fs%m=C})y^B9uB|paRR8Fi-_b1}dPO
> > > zNd}5g>V$y`EN8+%6(|{~fN~}oC_<?d28u{AP(-SMB2*0&p<<v469%d<$v_n*8K}a9
> > > zfhtTGsKO)zRhVR;3KIsZFkzqylMGa0l7T8r7^uR8fhtTgP=!ebsxV=oh~(Xcfg-{k
> > > z<AX^CiV(L!hQyR(3j;+Y#})>PNRBNTC_*{5WS|JKRCK%t3uQxl!2em@r+-NArRYzo
> > > zd;6!)#p%CPTGgQS4#RJ6mf*OXWjeTY@Jxoam(2>DSLslrL*2|TH8!ytFr0tS+TFn-
> > > z%ly8T&Yy2=y6t%Y+QsaGmHs%z=J`s{JM1pCSxFol(R(}ABBL{OqK&1O^*MYal;o0!
> > > zjpZ6z3^LK}AbZ4G`gnoO$Kh@a?{9`TF;*|~i+mkupSpnFl=9i0*9h4AbZ+hPmPJ~R
> > > zVnDcU9<TI*c3|Ay8TWz8Q~S7jd7?TNPrh^YvQoXwtC!I~wR$-}yL!31*Cg#?DGkeg
> > > zW9?S#G0MA2d6$=WC(65rly}GFy$SIa7PP*zdQU0u@$%k8dGC<&-ne{avV7t(%2$-~
> > > z6<)qFQND6W`O3I_b+UZ&G0In!@>O2GI#IrQNcrlxd~LFP>M_dKl=3xRzBW<5c1Zc!
> > > zxO{!G{M=)duPf#2ynKD4eEpE}b(Bxgt8B8oBg)H{2R<t>-NpK?-j+}CDUUxiugB>o
> > > zr?HjQ)8SiVDxGMXnQm%c=Ja&<0GUcB+GeJknrB!7rg<iX;j3gSooJhxZff4-^>p}D
> > > znMx<xW~Q5(2g`aoe7{Vk6KyloO+D8~^mO>BnMx<xW~Q5ZPFM7F_|ln5C))IM&WT6s
> > > z*?WsYvy814Y^&IDtob_|FNxiWx^?-{iof5k1oA1hFgf8(8Q0$`)Zch3di~a~3U9u4
> > > z^Nm|?ZohVubq&{FUmHKI8Oy2}U)f*ThK*HycoHq0e`Q;C_x2AcD6xX;S6YVKXa$Db
> > > zZoX__0lY|us=?x}+w`!=o+D)34Jzvez`atZfVJjEt6@fr8u8ShyUg{VL!y(JlIu5$
> > > z#nmEpLu?!+^I5l3eKj_;20QFSw^%G*%hyv_y)VsopS=8BLT+u4P!d4P?~~0a7O`-6
> > > zd@y-|Bt+ICmffeWtgr2d`DT)2JzgPWG8Hn+%%86waRawy9wNhZTa`<>*eGJ#k#Y44
> > > zFE_YqMC@v0gc0k1v2Oo%5E`FtqbZEGCrfg{la073!<Ek_TX9>qzZ}jF`ql_#zKmvF
> > > zA3ilTa&+IL?K{-RKD*UNukO7tyf6jhPX=z^wiS=21_l?wyR}Uli<N}fS)_zl*f!mA
> > > zXxr|t&K5V73;nruW%e*P=iQB<V;?fiv!9l!{209G+KjP@tk`5LL9b6XVwh+4uKU4@
> > > z^h{&^<A>>i=i1z-ryDb%S?XldmdUW%K;NPH1#Fsj(j<oMT)Un>fyq<zE4@nbEE~^w
> > > znn?6aIU5PO#3%lEP8FYL`JVv0%4i@Cb_B(amD1q5E#6ZN;WU@UOy!$Ge6RFk+WPaI
> > > z42xlj0KX9(uw(eperOve+6}yu@cRarAKC|T275@1{fBR|^6T_jJQ~qwG5ump+kQ2%
> > > zjrB)yh5bRhav%G$--;{uU%LAYwrt1QL>rA3?SWz7v>(N^N$DmqIAWKY?*NxDIO5ev
> > > z?aDh*Y+R;=gY$P{Ayr5je5dnb!ms;nF~qcu{3r<qX~z3?I@f*szHJ=EHsud5qkM3#
> > > zmrErK^d0BtdpR><#Vjo1A-X_UNQv{aN4KH7_iXi&D||1rS!r(JF*-|VZ04#xc9Kq#
> > > z-r`OxahY%JRTFd<yL;)NSQLB47?K|a#TP|@J7zGLaj@z!Y+B;vtUNi#Pg3-Vu>S)s
> > > Cro3tZ
> > >
> > > literal 0
> > > HcmV?d00001
> > >
> > > diff --git a/tests/data/acpi/q35/DSDT.numamem b/tests/data/acpi/q35/DSDT.numamem
> > > index 151e7cf42953f3f5fe61ff0140ab7b976fe9e5b8..050aaa237b466b0bda8cca5cfaa06f84661d622e 100644
> > > GIT binary patch
> > > delta 24
> > > gcmaFv@Z5pRCD<h-U4emtamhrkD~xg*?{~-p0BWTOc>n+a
> > >
> > > delta 24
> > > gcmaFv@Z5pRCD<h-U4emtaq&d1D~$3R?{~-p0BWEJc>n+a
> > >
> > > diff --git a/tests/data/acpi/q35/DSDT.smm-compat b/tests/data/acpi/q35/DSDT.smm-compat
> > > new file mode 100644
> > > index 0000000000000000000000000000000000000000..c1965f6051ef2af81dd8412abe169d87845bb033
> > > GIT binary patch
> > > literal 8289
> > > zcmb7JOKcm*8J^`!tL0K!Qk3OaY{E(UN|8{0Bx#EVC3pF<L~6yQ;si9nrRB7;og#}k
> > > z2J%1vSpgEqhoT9aphr4TfZp0uuQkw1d-JUUdg`H<T#F(`4`IK5h9l3A6cF>U+JE-@
> > > z{(rvNo&8obUf^~51;&j3l{egaP$<9Ry9N9V#u%N`U#F3{%(}Z?xz;n%v4qjRo#y8_
> > > zl+FB)z4BJg`29}!c^JO+QE2odcI6A_vn&1RgFE3BMxa|)BFmx^r?Sus%DwKMYx!=Y
> > > zX!hz2&n`W%Ota^Tv$)wSd2MF)wi+JGug~>10ylB@26MejtHV}uu#;V~oNn`<=e{|8
> > > z@)w_9daHE*=l}TS-5XW{fV22(;_tbL4&i&Dbt)V>pAN1W?-QM0TOBTaI^dT@n?qNk
> > > zkXr89qKQ(i?%(L{z38<|F7IQ;Z}~;HxQc$c?I3&FI{DEGV>S&A{r)r>js7A|nez^F
> > > znx;@$G3$P%BUKvEMyk5Ib-&YOHe(OIO|wMzwnOpK%axW_@Y`Omkbk}xbV@9umN25G
> > > z{=1>&ghTt2LC6MSdNkT+!-Y=<efGP)&HnY@<UZTC7DeB(*20JL)Rza}vIJx3&G(+A
> > > z-q3h=_l`G$QjZTY%AZD8{6>2-W`&mRtSvqlmq0>w_s*}CJ%GhMilg`Fl`M1ATCN!(
> > > z3z=cmjH~P_{+@}UT6gcM=El|mYjH_qnO5=)jZk;*?7H7smAMn*ej6Iru`)H|?fBbq
> > > z(>$}wGoN)gng^UD&=}1boQLs;ab})zIOpkh$35sxdVK$Q>WD?mFwZapL)6MX8lzp`
> > > z4LU~pzHOPfH59lQyR8BaUZJ}iR4!r`{LQv-<I)tk<znR`E|go%wvm1yXcV~R)>gCN
> > > zH@sI0U8B72uCe^nzFWB%>pn@*XcX-bB6`QT#wbVk`_#P8^3RmOnT4WU5go!YHq3h|
> > > z-wT=x!}amhc<{pC{~cU-xB1D+*Ue*pb(<08di~eo@X5h-Has@CX2mcA-sjJejmLJx
> > > z_Oo&0HXYc#mErQ>x-}Q&k};NH{V2TCXKcT3`VF_r@^%k@jcA7==Qpn!^sqSY*L))T
> > > z?T(*YySbZ7C-8K#_10R2iE{(zRhF}<-HIWo$smrP&T^Rq`hl4waN~$r04|7YoCl~3
> > > ziHZCi8{<r1#}P3lG{!g+P|ie1O!S6h<D4mb5NE`c(70d%%9#j>DXU;!2`tZ(;7kck
> > > z2&U{jLRDu{)0yN<2~7&7>^wqMXG+tV;!Fum={garI_ET<bDGXMT_-|Sr>W^QHJzre
> > > z6QQaTZy;r)=QW-4x=w_uPD|5iX*w-kCqh+cTGN@<bf$Hk2vwbU7b^GD)^yssPK2t?
> > > zjHWZA>CEUl5vn>DG@T2Y&IMg3LRIIYrgKr#xv1+zsOoeyosOo{(RCtJb!Ii4SxskF
> > > z*NITonbUOUG@UtJCqh-{lBRP>)48PUM5yY_YdZ6q&b+P@p{jFP)48naT-J3WRCONF
> > > zbRN-k9?^9oRCVG@0#BcO53OiAS9F~SRh>sQokumDM|GVDRh`E;vowAa9^=gN_+@uY
> > > zFx^KXF}*SNxW+uLF^}s^gevod#yp`hPv}g9D)XeqJgG5H>P&<x^9halgvNYAXChRY
> > > zr#Mr(%qh;4@Ay-KDPP<Oi7D^kX|3jIt>$UHCPGougn^b61FZ!Ol;&n?;2ed=28sY>
> > > zMG!|Ii^4z!j$4w!h$Z`Hps0Wz7$`z14F)Q((m)j`8K{6B7$`#YMjEKVjw7n68mNFC
> > > z7$`#Yh+|=(0y~bz8ab2<R6u2@>V$!cw44b8RiI>`2&F5Mfg+STVW0xbnJ`cVN(L&R
> > > zye1haLa7r5DzKah16818paRO7WS|J8P8g`bawZH^fs%m=C})y^B9!+N1}d<e2?JH2
> > > zWS|1dnPi{{rA`>Az;Y%GRDqI#3Mglifg+STVW0xbnJ`cVN(L&RoJj_XQ0jz%3M^;B
> > > zKouw%sDN@N87M-j69y`<oCyO}pk$x|%9&)K2&GOKsK9b23{-)VfeI*Rl7S+WI$@v!
> > > z%b74x1xf}gpqxnticso=feI{V!ax-$8K{7ACK)I~sS^e&u$&14RiI>`0?L_Wpa`W-
> > > z7^uK<CJa=8l7R{+XOe*;lsaLc0?U~&Pz6c`DxjQ628vMXgn<eyXTm@gC>f}LawZul
> > > zLa7r5DzKah16818paRO7WS|J8P8g`bawZH^fs%m=C})y^B9uB|paRR8Fi-_b1}dPO
> > > zNd}5g>V$y`EN8+%6(|{~fN~}oC_<?d28u{AP(-SMB2*0&p<<v469%d<$v_n*8K}a9
> > > zfhtTGsKO)zRhVR;3KIsZFkzqylMGa0l7T8r7^uR8fhtTgP=!ebsxV=oh~(Xcfg-{k
> > > z<AX^CiV(L!hQyR(3j;+Y#})>PNRBNTC_*{5WS|JKRCK%t3uQxl!2em@r+-NArRYzo
> > > zd;6!)#p%CPTGgQS4#RJ6mf*OXWjeTY@Jxoam(2>DSLslrL*2|TH8!ytFr0tS+TFn-
> > > z%ly8T&Yy2=y6t%Y+QsaGmHs%z=J`s{JM1pCSxFol(R(}ABBL{OqK&1O^*MYal;o0!
> > > zjpZ6z3^LK}AbZ4G`gnoO$Kh@a?{9`TF;*|~i+mkupSpnFl=9i0*9h4AbZ+hPmPJ~R
> > > zVnDcU9<TI*c3|Ay8TWz8Q~S7jd7?TNPrh^YvQoXwtC!I~wR$-}yL!31*Cg#?DGkeg
> > > zW9?S#G0MA2d6$=WC(65rly}GFy$SIa7PP*zdQU0u@$%k8dGC<&-ne{avV7t(%2$-~
> > > z6<)qFQND6W`O3I_b+UZ&G0In!@>O2GI#IrQNcrlxd~LFP>M_dKl=3xRzBW<5c1Zc!
> > > zxO{!G{M=)duPf#2ynKD4eEpE}b(Bxgt8B8oBg)H{2R<t>-NpK?-j+}CDUUxiugB>o
> > > zr?HjQ)8SiVDxGMXnQm%c=Ja&<0GUcB+GeJknrB!7rg<iX;j3gSooJhxZff4-^>p}D
> > > znMx<xW~Q5(2g`aoe7{Vk6KyloO+D8~^mO>BnMx<xW~Q5ZPFM7F_|ln5C))IM&WT6s
> > > z*?WsYvy814Y^&IDtob_|FNxiWx^?-{iof5k1oA1hFgf8(8Q0$`)Zch3di~a~3U9u4
> > > z^Nm|?ZohVubq&{FUmHKI8Oy2}U)f*ThK*HycoHq0e`Q;C_x2AcD6xX;S6YVKXa$Db
> > > zZoX__0lY|us=?x}+w`!=o+D)34Jzvez`atZfVJjEt6@fr8u8ShyUg{VL!y(JlIu5$
> > > z#nmEpLu?!+^I5l3eKj_;20QFSw^%G*%hyv_y)VsopS=8BLT+u4P!d4P?~~0a7O`-6
> > > zd@y-|Bt+ICmffeWtgr2d`DT)2JzgPWG8Hn+%%86waRawy9wNhZTa`<>*eGJ#k#Y44
> > > zFE_YqMC@v0gc0k1v2Oo%5E`FtqbZEGCrfg{la073!<Ek_TX9>qzZ}jF`ql_#zKmvF
> > > zA3ilTa&+IL?K{-RKD*UNukO7tyf6jhPX=z^wiS=21_l?wyR}Uli<N}fS)_zl*f!mA
> > > zXxr|t&K5V73;nruW%e*P=iQB<V;?fiv!9l!{209G+KjP@tk`5LL9b6XVwh+4uKU4@
> > > z^h{&^<A>>i=i1z-ryDb%S?XldmdUW%K;NPH1#Fsj(j<oMT)Un>fyq<zE4@nbEE~^w
> > > znn?6aIU5PO#3%lEP8FYL`JVv0%4i@Cb_B(amD1q5E#6ZN;WU@UOy!$Ge6RFk+WPaI
> > > z42xlj0KX9(uw(eperOve+6}yu@cRarAKC|T275@1{fBR|^6T_jJQ~qwG5ump+kQ2%
> > > zjrB)yh5bRhav%G$--;{uU%LAYwrt1QL>rA3?SWz7v>(N^N$DmqIAWKY?*NxDIO5ev
> > > z?aDh*Y+R;=gY$P{Ayr5je5dnb!ms;nF~qcu{3r<qX~z3?I@f*szHJ=EHsud5qkM3#
> > > zmrErK^d0BtdpR><#Vjo1A-X_UNQv{aN4KH7_iXi&D||1rS!r(JF*-|VZ04#xc9Kq#
> > > z-r`OxahY%JRTFd<yL;)NSQLB47?K|a#TP|@J7zGLaj@z!Y+B;vtUNi#Pg3-Vu>S)s
> > > Cro3tZ
> > >
> > > literal 0
> > > HcmV?d00001
> > >
> > > diff --git a/tests/data/acpi/q35/DSDT.smm-compat-nosmm b/tests/data/acpi/q35/DSDT.smm-compat-nosmm
> > > new file mode 100644
> > > index 0000000000000000000000000000000000000000..c1965f6051ef2af81dd8412abe169d87845bb033
> > > GIT binary patch
> > > literal 8289
> > > zcmb7JOKcm*8J^`!tL0K!Qk3OaY{E(UN|8{0Bx#EVC3pF<L~6yQ;si9nrRB7;og#}k
> > > z2J%1vSpgEqhoT9aphr4TfZp0uuQkw1d-JUUdg`H<T#F(`4`IK5h9l3A6cF>U+JE-@
> > > z{(rvNo&8obUf^~51;&j3l{egaP$<9Ry9N9V#u%N`U#F3{%(}Z?xz;n%v4qjRo#y8_
> > > zl+FB)z4BJg`29}!c^JO+QE2odcI6A_vn&1RgFE3BMxa|)BFmx^r?Sus%DwKMYx!=Y
> > > zX!hz2&n`W%Ota^Tv$)wSd2MF)wi+JGug~>10ylB@26MejtHV}uu#;V~oNn`<=e{|8
> > > z@)w_9daHE*=l}TS-5XW{fV22(;_tbL4&i&Dbt)V>pAN1W?-QM0TOBTaI^dT@n?qNk
> > > zkXr89qKQ(i?%(L{z38<|F7IQ;Z}~;HxQc$c?I3&FI{DEGV>S&A{r)r>js7A|nez^F
> > > znx;@$G3$P%BUKvEMyk5Ib-&YOHe(OIO|wMzwnOpK%axW_@Y`Omkbk}xbV@9umN25G
> > > z{=1>&ghTt2LC6MSdNkT+!-Y=<efGP)&HnY@<UZTC7DeB(*20JL)Rza}vIJx3&G(+A
> > > z-q3h=_l`G$QjZTY%AZD8{6>2-W`&mRtSvqlmq0>w_s*}CJ%GhMilg`Fl`M1ATCN!(
> > > z3z=cmjH~P_{+@}UT6gcM=El|mYjH_qnO5=)jZk;*?7H7smAMn*ej6Iru`)H|?fBbq
> > > z(>$}wGoN)gng^UD&=}1boQLs;ab})zIOpkh$35sxdVK$Q>WD?mFwZapL)6MX8lzp`
> > > z4LU~pzHOPfH59lQyR8BaUZJ}iR4!r`{LQv-<I)tk<znR`E|go%wvm1yXcV~R)>gCN
> > > zH@sI0U8B72uCe^nzFWB%>pn@*XcX-bB6`QT#wbVk`_#P8^3RmOnT4WU5go!YHq3h|
> > > z-wT=x!}amhc<{pC{~cU-xB1D+*Ue*pb(<08di~eo@X5h-Has@CX2mcA-sjJejmLJx
> > > z_Oo&0HXYc#mErQ>x-}Q&k};NH{V2TCXKcT3`VF_r@^%k@jcA7==Qpn!^sqSY*L))T
> > > z?T(*YySbZ7C-8K#_10R2iE{(zRhF}<-HIWo$smrP&T^Rq`hl4waN~$r04|7YoCl~3
> > > ziHZCi8{<r1#}P3lG{!g+P|ie1O!S6h<D4mb5NE`c(70d%%9#j>DXU;!2`tZ(;7kck
> > > z2&U{jLRDu{)0yN<2~7&7>^wqMXG+tV;!Fum={garI_ET<bDGXMT_-|Sr>W^QHJzre
> > > z6QQaTZy;r)=QW-4x=w_uPD|5iX*w-kCqh+cTGN@<bf$Hk2vwbU7b^GD)^yssPK2t?
> > > zjHWZA>CEUl5vn>DG@T2Y&IMg3LRIIYrgKr#xv1+zsOoeyosOo{(RCtJb!Ii4SxskF
> > > z*NITonbUOUG@UtJCqh-{lBRP>)48PUM5yY_YdZ6q&b+P@p{jFP)48naT-J3WRCONF
> > > zbRN-k9?^9oRCVG@0#BcO53OiAS9F~SRh>sQokumDM|GVDRh`E;vowAa9^=gN_+@uY
> > > zFx^KXF}*SNxW+uLF^}s^gevod#yp`hPv}g9D)XeqJgG5H>P&<x^9halgvNYAXChRY
> > > zr#Mr(%qh;4@Ay-KDPP<Oi7D^kX|3jIt>$UHCPGougn^b61FZ!Ol;&n?;2ed=28sY>
> > > zMG!|Ii^4z!j$4w!h$Z`Hps0Wz7$`z14F)Q((m)j`8K{6B7$`#YMjEKVjw7n68mNFC
> > > z7$`#Yh+|=(0y~bz8ab2<R6u2@>V$!cw44b8RiI>`2&F5Mfg+STVW0xbnJ`cVN(L&R
> > > zye1haLa7r5DzKah16818paRO7WS|J8P8g`bawZH^fs%m=C})y^B9!+N1}d<e2?JH2
> > > zWS|1dnPi{{rA`>Az;Y%GRDqI#3Mglifg+STVW0xbnJ`cVN(L&RoJj_XQ0jz%3M^;B
> > > zKouw%sDN@N87M-j69y`<oCyO}pk$x|%9&)K2&GOKsK9b23{-)VfeI*Rl7S+WI$@v!
> > > z%b74x1xf}gpqxnticso=feI{V!ax-$8K{7ACK)I~sS^e&u$&14RiI>`0?L_Wpa`W-
> > > z7^uK<CJa=8l7R{+XOe*;lsaLc0?U~&Pz6c`DxjQ628vMXgn<eyXTm@gC>f}LawZul
> > > zLa7r5DzKah16818paRO7WS|J8P8g`bawZH^fs%m=C})y^B9uB|paRR8Fi-_b1}dPO
> > > zNd}5g>V$y`EN8+%6(|{~fN~}oC_<?d28u{AP(-SMB2*0&p<<v469%d<$v_n*8K}a9
> > > zfhtTGsKO)zRhVR;3KIsZFkzqylMGa0l7T8r7^uR8fhtTgP=!ebsxV=oh~(Xcfg-{k
> > > z<AX^CiV(L!hQyR(3j;+Y#})>PNRBNTC_*{5WS|JKRCK%t3uQxl!2em@r+-NArRYzo
> > > zd;6!)#p%CPTGgQS4#RJ6mf*OXWjeTY@Jxoam(2>DSLslrL*2|TH8!ytFr0tS+TFn-
> > > z%ly8T&Yy2=y6t%Y+QsaGmHs%z=J`s{JM1pCSxFol(R(}ABBL{OqK&1O^*MYal;o0!
> > > zjpZ6z3^LK}AbZ4G`gnoO$Kh@a?{9`TF;*|~i+mkupSpnFl=9i0*9h4AbZ+hPmPJ~R
> > > zVnDcU9<TI*c3|Ay8TWz8Q~S7jd7?TNPrh^YvQoXwtC!I~wR$-}yL!31*Cg#?DGkeg
> > > zW9?S#G0MA2d6$=WC(65rly}GFy$SIa7PP*zdQU0u@$%k8dGC<&-ne{avV7t(%2$-~
> > > z6<)qFQND6W`O3I_b+UZ&G0In!@>O2GI#IrQNcrlxd~LFP>M_dKl=3xRzBW<5c1Zc!
> > > zxO{!G{M=)duPf#2ynKD4eEpE}b(Bxgt8B8oBg)H{2R<t>-NpK?-j+}CDUUxiugB>o
> > > zr?HjQ)8SiVDxGMXnQm%c=Ja&<0GUcB+GeJknrB!7rg<iX;j3gSooJhxZff4-^>p}D
> > > znMx<xW~Q5(2g`aoe7{Vk6KyloO+D8~^mO>BnMx<xW~Q5ZPFM7F_|ln5C))IM&WT6s
> > > z*?WsYvy814Y^&IDtob_|FNxiWx^?-{iof5k1oA1hFgf8(8Q0$`)Zch3di~a~3U9u4
> > > z^Nm|?ZohVubq&{FUmHKI8Oy2}U)f*ThK*HycoHq0e`Q;C_x2AcD6xX;S6YVKXa$Db
> > > zZoX__0lY|us=?x}+w`!=o+D)34Jzvez`atZfVJjEt6@fr8u8ShyUg{VL!y(JlIu5$
> > > z#nmEpLu?!+^I5l3eKj_;20QFSw^%G*%hyv_y)VsopS=8BLT+u4P!d4P?~~0a7O`-6
> > > zd@y-|Bt+ICmffeWtgr2d`DT)2JzgPWG8Hn+%%86waRawy9wNhZTa`<>*eGJ#k#Y44
> > > zFE_YqMC@v0gc0k1v2Oo%5E`FtqbZEGCrfg{la073!<Ek_TX9>qzZ}jF`ql_#zKmvF
> > > zA3ilTa&+IL?K{-RKD*UNukO7tyf6jhPX=z^wiS=21_l?wyR}Uli<N}fS)_zl*f!mA
> > > zXxr|t&K5V73;nruW%e*P=iQB<V;?fiv!9l!{209G+KjP@tk`5LL9b6XVwh+4uKU4@
> > > z^h{&^<A>>i=i1z-ryDb%S?XldmdUW%K;NPH1#Fsj(j<oMT)Un>fyq<zE4@nbEE~^w
> > > znn?6aIU5PO#3%lEP8FYL`JVv0%4i@Cb_B(amD1q5E#6ZN;WU@UOy!$Ge6RFk+WPaI
> > > z42xlj0KX9(uw(eperOve+6}yu@cRarAKC|T275@1{fBR|^6T_jJQ~qwG5ump+kQ2%
> > > zjrB)yh5bRhav%G$--;{uU%LAYwrt1QL>rA3?SWz7v>(N^N$DmqIAWKY?*NxDIO5ev
> > > z?aDh*Y+R;=gY$P{Ayr5je5dnb!ms;nF~qcu{3r<qX~z3?I@f*szHJ=EHsud5qkM3#
> > > zmrErK^d0BtdpR><#Vjo1A-X_UNQv{aN4KH7_iXi&D||1rS!r(JF*-|VZ04#xc9Kq#
> > > z-r`OxahY%JRTFd<yL;)NSQLB47?K|a#TP|@J7zGLaj@z!Y+B;vtUNi#Pg3-Vu>S)s
> > > Cro3tZ
> > >
> > > literal 0
> > > HcmV?d00001
> > >
> > > diff --git a/tests/data/acpi/q35/DSDT.tis.tpm12 b/tests/data/acpi/q35/DSDT.tis.tpm12
> > > index c96b5277a14ae98174408d690d6e0246bd932623..0ebdf6fbd77967f1ab5d5337b7b1fed314cfaca8 100644
> > > GIT binary patch
> > > delta 24
> > > gcmdnzy3du%CD<iopArKDqxwXyD~xg*@84Gh0A(f!W&i*H
> > >
> > > delta 24
> > > gcmdnzy3du%CD<iopArKDquNBSD~$3R@84Gh0A(QvW&i*H
> > >
> > > diff --git a/tests/data/acpi/q35/DSDT.tis.tpm2 b/tests/data/acpi/q35/DSDT.tis.tpm2
> > > index c92d4d29c79352a60974ea9f665d0b9a410a4bac..dcbb7f0af377425db53130e8ba1c62c09c22e006 100644
> > > GIT binary patch
> > > delta 24
> > > gcmdnzy3du%CD<iopArKD<D-dOR~Y3s-oLL10Bm##ApigX
> > >
> > > delta 24
> > > gcmdnzy3du%CD<iopArKD<HLzuR~Y3t-oLL10BmmwApigX
> > >
> > > diff --git a/tests/data/acpi/q35/DSDT.xapic b/tests/data/acpi/q35/DSDT.xapic
> > > index 119fc90f1f8a7b6934df6fd95609446e627ce15d..17552ce363ae81985f69f9ae85837a1540b79ae0 100644
> > > GIT binary patch
> > > delta 26
> > > icmX>yjp@iVCN7s?mk^h31_s6r6S=N1%5A)#+64f6_X&Rh
> > >
> > > delta 26
> > > icmX>yjp@iVCN7s?mk^h31_s9U6S=N1%5S`%+64f6@(F(c
> > >
> > > --
> > > 2.27.0
> >
> >
>
^ permalink raw reply [flat|nested] 24+ messages in thread
* Re: [PATCH for 6.2 v2 5/5] bios-tables-test: Update golden binaries
2021-11-11 8:34 ` Michael S. Tsirkin
2021-11-11 9:27 ` Ani Sinha
@ 2021-11-11 11:32 ` Igor Mammedov
2021-11-11 13:47 ` Thomas Lamprecht
2021-11-11 15:31 ` Michael S. Tsirkin
1 sibling, 2 replies; 24+ messages in thread
From: Igor Mammedov @ 2021-11-11 11:32 UTC (permalink / raw)
To: Michael S. Tsirkin; +Cc: ani, mapfelba, jusual, qemu-devel, kraxel
On Thu, 11 Nov 2021 03:34:37 -0500
"Michael S. Tsirkin" <mst@redhat.com> wrote:
> On Wed, Nov 10, 2021 at 04:11:40PM -0500, Igor Mammedov wrote:
> > From: Julia Suvorova <jusual@redhat.com>
> >
> > The changes are the result of
> > 'hw/i386/acpi-build: Deny control on PCIe Native Hot-Plug in _OSC'
> > and listed here:
> >
> > Method (_OSC, 4, NotSerialized) // _OSC: Operating System Capabilities
> > {
> > CreateDWordField (Arg3, Zero, CDW1)
> > If ((Arg0 == ToUUID ("33db4d5b-1ff7-401c-9657-7441c03dd766") /* PCI Host Bridge Device */))
> > {
> > CreateDWordField (Arg3, 0x04, CDW2)
> > CreateDWordField (Arg3, 0x08, CDW3)
> > Local0 = CDW3 /* \_SB_.PCI0._OSC.CDW3 */
> > - Local0 &= 0x1F
> > + Local0 &= 0x1E
> >
> > Signed-off-by: Julia Suvorova <jusual@redhat.com>
> > Signed-off-by: Igor Mammedov <imammedo@redhat.com>
> > ---
> > tests/qtest/bios-tables-test-allowed-diff.h | 16 ----------------
> > tests/data/acpi/q35/DSDT | Bin 8289 -> 8289 bytes
> > tests/data/acpi/q35/DSDT.acpihmat | Bin 9614 -> 9614 bytes
> > tests/data/acpi/q35/DSDT.bridge | Bin 11003 -> 11003 bytes
> > tests/data/acpi/q35/DSDT.cphp | Bin 8753 -> 8753 bytes
> > tests/data/acpi/q35/DSDT.dimmpxm | Bin 9943 -> 9943 bytes
> > tests/data/acpi/q35/DSDT.dmar | Bin 0 -> 8289 bytes
> > tests/data/acpi/q35/DSDT.ipmibt | Bin 8364 -> 8364 bytes
> > tests/data/acpi/q35/DSDT.ivrs | Bin 8306 -> 8306 bytes
> > tests/data/acpi/q35/DSDT.memhp | Bin 9648 -> 9648 bytes
> > tests/data/acpi/q35/DSDT.mmio64 | Bin 9419 -> 9419 bytes
> > tests/data/acpi/q35/DSDT.multi-bridge | Bin 8583 -> 8583 bytes
> > tests/data/acpi/q35/DSDT.nohpet | Bin 8147 -> 8147 bytes
> > tests/data/acpi/q35/DSDT.nosmm | Bin 0 -> 8289 bytes
> > tests/data/acpi/q35/DSDT.numamem | Bin 8295 -> 8295 bytes
> > tests/data/acpi/q35/DSDT.smm-compat | Bin 0 -> 8289 bytes
> > tests/data/acpi/q35/DSDT.smm-compat-nosmm | Bin 0 -> 8289 bytes
> > tests/data/acpi/q35/DSDT.tis.tpm12 | Bin 8894 -> 8894 bytes
> > tests/data/acpi/q35/DSDT.tis.tpm2 | Bin 8894 -> 8894 bytes
> > tests/data/acpi/q35/DSDT.xapic | Bin 35652 -> 35652 bytes
>
> Why do we have all the new files? What is going on here?
I think new files are not necessary.
I can update patch if we decide to keep ACPI enabled by default.
So question is:
do we revert to native pcie or stay with apci hootplug for 6.2?
>
> > 20 files changed, 16 deletions(-)
> > create mode 100644 tests/data/acpi/q35/DSDT.dmar
> > create mode 100644 tests/data/acpi/q35/DSDT.nosmm
> > create mode 100644 tests/data/acpi/q35/DSDT.smm-compat
> > create mode 100644 tests/data/acpi/q35/DSDT.smm-compat-nosmm
> >
> > diff --git a/tests/qtest/bios-tables-test-allowed-diff.h b/tests/qtest/bios-tables-test-allowed-diff.h
> > index 48e5634d4b..dfb8523c8b 100644
> > --- a/tests/qtest/bios-tables-test-allowed-diff.h
> > +++ b/tests/qtest/bios-tables-test-allowed-diff.h
> > @@ -1,17 +1 @@
> > /* List of comma-separated changed AML files to ignore */
> > -"tests/data/acpi/q35/DSDT",
> > -"tests/data/acpi/q35/DSDT.tis",
> > -"tests/data/acpi/q35/DSDT.bridge",
> > -"tests/data/acpi/q35/DSDT.mmio64",
> > -"tests/data/acpi/q35/DSDT.ipmibt",
> > -"tests/data/acpi/q35/DSDT.cphp",
> > -"tests/data/acpi/q35/DSDT.memhp",
> > -"tests/data/acpi/q35/DSDT.acpihmat",
> > -"tests/data/acpi/q35/DSDT.numamem",
> > -"tests/data/acpi/q35/DSDT.dimmpxm",
> > -"tests/data/acpi/q35/DSDT.nohpet",
> > -"tests/data/acpi/q35/DSDT.tis.tpm2",
> > -"tests/data/acpi/q35/DSDT.tis.tpm12",
> > -"tests/data/acpi/q35/DSDT.multi-bridge",
> > -"tests/data/acpi/q35/DSDT.ivrs",
> > -"tests/data/acpi/q35/DSDT.xapic",
> > diff --git a/tests/data/acpi/q35/DSDT b/tests/data/acpi/q35/DSDT
> > index 281fc82c03b2562d2e6b7caec0d817b034a47138..c1965f6051ef2af81dd8412abe169d87845bb033 100644
> > GIT binary patch
> > delta 24
> > gcmaFp@X&$FCD<h-QGtPh@z+GID~xg*?>ET<0BnZ{w*UYD
> >
> > delta 24
> > gcmaFp@X&$FCD<h-QGtPh@#jRYD~$3R?>ET<0BnK?w*UYD
> >
> > diff --git a/tests/data/acpi/q35/DSDT.acpihmat b/tests/data/acpi/q35/DSDT.acpihmat
> > index 8c1e05a11a328ec1cc6f86e36e52c28f41f9744e..f24d4874bff8d327a165ed7c36de507aea114edd 100644
> > GIT binary patch
> > delta 24
> > fcmeD4?(^ny33dtTQ)OUa+&+=(3ZvY{`|DKzU@Hhn
> >
> > delta 24
> > fcmeD4?(^ny33dtTQ)OUa+%}Qx3ZwkS`|DKzU?vDi
> >
> > diff --git a/tests/data/acpi/q35/DSDT.bridge b/tests/data/acpi/q35/DSDT.bridge
> > index 6f1464b6c712d7f33cb4b891b7ce76fe228f44c9..424d51bd1cb39ea73501ef7d0044ee52cec5bdac 100644
> > GIT binary patch
> > delta 24
> > gcmewz`a6`%CD<k8w-y5fBg;gtD~xg*@5^Wb0CWThXaE2J
> >
> > delta 24
> > gcmewz`a6`%CD<k8w-y5fBlASAD~$3R@5^Wb0CWEcXaE2J
> >
> > diff --git a/tests/data/acpi/q35/DSDT.cphp b/tests/data/acpi/q35/DSDT.cphp
> > index f8337ff5191a37a47dcf7c09a6c39c4e704a15bf..f1275606f68eeba54bfb11e63d818420385a62b9 100644
> > GIT binary patch
> > delta 24
> > fcmdn!veAXhCD<jzP>F$oF>WH)6-K#@_k$DxTWtqt
> >
> > delta 24
> > fcmdn!veAXhCD<jzP>F$oF?J%?6-N1u_k$DxTWAMo
> >
> > diff --git a/tests/data/acpi/q35/DSDT.dimmpxm b/tests/data/acpi/q35/DSDT.dimmpxm
> > index fe5820d93d057ef09a001662369b15afbc5b87e2..76e451e829ec4c245315f7eed8731aa1be45a747 100644
> > GIT binary patch
> > delta 24
> > gcmccad)=4ICD<k8x*7umqsK(9D~xg*@BdH*0B$o00{{R3
> >
> > delta 24
> > gcmccad)=4ICD<k8x*7umqx(dzD~$3R@BdH*0B$Y`0{{R3
> >
> > diff --git a/tests/data/acpi/q35/DSDT.dmar b/tests/data/acpi/q35/DSDT.dmar
> > new file mode 100644
> > index 0000000000000000000000000000000000000000..c1965f6051ef2af81dd8412abe169d87845bb033
> > GIT binary patch
> > literal 8289
> > zcmb7JOKcm*8J^`!tL0K!Qk3OaY{E(UN|8{0Bx#EVC3pF<L~6yQ;si9nrRB7;og#}k
> > z2J%1vSpgEqhoT9aphr4TfZp0uuQkw1d-JUUdg`H<T#F(`4`IK5h9l3A6cF>U+JE-@
> > z{(rvNo&8obUf^~51;&j3l{egaP$<9Ry9N9V#u%N`U#F3{%(}Z?xz;n%v4qjRo#y8_
> > zl+FB)z4BJg`29}!c^JO+QE2odcI6A_vn&1RgFE3BMxa|)BFmx^r?Sus%DwKMYx!=Y
> > zX!hz2&n`W%Ota^Tv$)wSd2MF)wi+JGug~>10ylB@26MejtHV}uu#;V~oNn`<=e{|8
> > z@)w_9daHE*=l}TS-5XW{fV22(;_tbL4&i&Dbt)V>pAN1W?-QM0TOBTaI^dT@n?qNk
> > zkXr89qKQ(i?%(L{z38<|F7IQ;Z}~;HxQc$c?I3&FI{DEGV>S&A{r)r>js7A|nez^F
> > znx;@$G3$P%BUKvEMyk5Ib-&YOHe(OIO|wMzwnOpK%axW_@Y`Omkbk}xbV@9umN25G
> > z{=1>&ghTt2LC6MSdNkT+!-Y=<efGP)&HnY@<UZTC7DeB(*20JL)Rza}vIJx3&G(+A
> > z-q3h=_l`G$QjZTY%AZD8{6>2-W`&mRtSvqlmq0>w_s*}CJ%GhMilg`Fl`M1ATCN!(
> > z3z=cmjH~P_{+@}UT6gcM=El|mYjH_qnO5=)jZk;*?7H7smAMn*ej6Iru`)H|?fBbq
> > z(>$}wGoN)gng^UD&=}1boQLs;ab})zIOpkh$35sxdVK$Q>WD?mFwZapL)6MX8lzp`
> > z4LU~pzHOPfH59lQyR8BaUZJ}iR4!r`{LQv-<I)tk<znR`E|go%wvm1yXcV~R)>gCN
> > zH@sI0U8B72uCe^nzFWB%>pn@*XcX-bB6`QT#wbVk`_#P8^3RmOnT4WU5go!YHq3h|
> > z-wT=x!}amhc<{pC{~cU-xB1D+*Ue*pb(<08di~eo@X5h-Has@CX2mcA-sjJejmLJx
> > z_Oo&0HXYc#mErQ>x-}Q&k};NH{V2TCXKcT3`VF_r@^%k@jcA7==Qpn!^sqSY*L))T
> > z?T(*YySbZ7C-8K#_10R2iE{(zRhF}<-HIWo$smrP&T^Rq`hl4waN~$r04|7YoCl~3
> > ziHZCi8{<r1#}P3lG{!g+P|ie1O!S6h<D4mb5NE`c(70d%%9#j>DXU;!2`tZ(;7kck
> > z2&U{jLRDu{)0yN<2~7&7>^wqMXG+tV;!Fum={garI_ET<bDGXMT_-|Sr>W^QHJzre
> > z6QQaTZy;r)=QW-4x=w_uPD|5iX*w-kCqh+cTGN@<bf$Hk2vwbU7b^GD)^yssPK2t?
> > zjHWZA>CEUl5vn>DG@T2Y&IMg3LRIIYrgKr#xv1+zsOoeyosOo{(RCtJb!Ii4SxskF
> > z*NITonbUOUG@UtJCqh-{lBRP>)48PUM5yY_YdZ6q&b+P@p{jFP)48naT-J3WRCONF
> > zbRN-k9?^9oRCVG@0#BcO53OiAS9F~SRh>sQokumDM|GVDRh`E;vowAa9^=gN_+@uY
> > zFx^KXF}*SNxW+uLF^}s^gevod#yp`hPv}g9D)XeqJgG5H>P&<x^9halgvNYAXChRY
> > zr#Mr(%qh;4@Ay-KDPP<Oi7D^kX|3jIt>$UHCPGougn^b61FZ!Ol;&n?;2ed=28sY>
> > zMG!|Ii^4z!j$4w!h$Z`Hps0Wz7$`z14F)Q((m)j`8K{6B7$`#YMjEKVjw7n68mNFC
> > z7$`#Yh+|=(0y~bz8ab2<R6u2@>V$!cw44b8RiI>`2&F5Mfg+STVW0xbnJ`cVN(L&R
> > zye1haLa7r5DzKah16818paRO7WS|J8P8g`bawZH^fs%m=C})y^B9!+N1}d<e2?JH2
> > zWS|1dnPi{{rA`>Az;Y%GRDqI#3Mglifg+STVW0xbnJ`cVN(L&RoJj_XQ0jz%3M^;B
> > zKouw%sDN@N87M-j69y`<oCyO}pk$x|%9&)K2&GOKsK9b23{-)VfeI*Rl7S+WI$@v!
> > z%b74x1xf}gpqxnticso=feI{V!ax-$8K{7ACK)I~sS^e&u$&14RiI>`0?L_Wpa`W-
> > z7^uK<CJa=8l7R{+XOe*;lsaLc0?U~&Pz6c`DxjQ628vMXgn<eyXTm@gC>f}LawZul
> > zLa7r5DzKah16818paRO7WS|J8P8g`bawZH^fs%m=C})y^B9uB|paRR8Fi-_b1}dPO
> > zNd}5g>V$y`EN8+%6(|{~fN~}oC_<?d28u{AP(-SMB2*0&p<<v469%d<$v_n*8K}a9
> > zfhtTGsKO)zRhVR;3KIsZFkzqylMGa0l7T8r7^uR8fhtTgP=!ebsxV=oh~(Xcfg-{k
> > z<AX^CiV(L!hQyR(3j;+Y#})>PNRBNTC_*{5WS|JKRCK%t3uQxl!2em@r+-NArRYzo
> > zd;6!)#p%CPTGgQS4#RJ6mf*OXWjeTY@Jxoam(2>DSLslrL*2|TH8!ytFr0tS+TFn-
> > z%ly8T&Yy2=y6t%Y+QsaGmHs%z=J`s{JM1pCSxFol(R(}ABBL{OqK&1O^*MYal;o0!
> > zjpZ6z3^LK}AbZ4G`gnoO$Kh@a?{9`TF;*|~i+mkupSpnFl=9i0*9h4AbZ+hPmPJ~R
> > zVnDcU9<TI*c3|Ay8TWz8Q~S7jd7?TNPrh^YvQoXwtC!I~wR$-}yL!31*Cg#?DGkeg
> > zW9?S#G0MA2d6$=WC(65rly}GFy$SIa7PP*zdQU0u@$%k8dGC<&-ne{avV7t(%2$-~
> > z6<)qFQND6W`O3I_b+UZ&G0In!@>O2GI#IrQNcrlxd~LFP>M_dKl=3xRzBW<5c1Zc!
> > zxO{!G{M=)duPf#2ynKD4eEpE}b(Bxgt8B8oBg)H{2R<t>-NpK?-j+}CDUUxiugB>o
> > zr?HjQ)8SiVDxGMXnQm%c=Ja&<0GUcB+GeJknrB!7rg<iX;j3gSooJhxZff4-^>p}D
> > znMx<xW~Q5(2g`aoe7{Vk6KyloO+D8~^mO>BnMx<xW~Q5ZPFM7F_|ln5C))IM&WT6s
> > z*?WsYvy814Y^&IDtob_|FNxiWx^?-{iof5k1oA1hFgf8(8Q0$`)Zch3di~a~3U9u4
> > z^Nm|?ZohVubq&{FUmHKI8Oy2}U)f*ThK*HycoHq0e`Q;C_x2AcD6xX;S6YVKXa$Db
> > zZoX__0lY|us=?x}+w`!=o+D)34Jzvez`atZfVJjEt6@fr8u8ShyUg{VL!y(JlIu5$
> > z#nmEpLu?!+^I5l3eKj_;20QFSw^%G*%hyv_y)VsopS=8BLT+u4P!d4P?~~0a7O`-6
> > zd@y-|Bt+ICmffeWtgr2d`DT)2JzgPWG8Hn+%%86waRawy9wNhZTa`<>*eGJ#k#Y44
> > zFE_YqMC@v0gc0k1v2Oo%5E`FtqbZEGCrfg{la073!<Ek_TX9>qzZ}jF`ql_#zKmvF
> > zA3ilTa&+IL?K{-RKD*UNukO7tyf6jhPX=z^wiS=21_l?wyR}Uli<N}fS)_zl*f!mA
> > zXxr|t&K5V73;nruW%e*P=iQB<V;?fiv!9l!{209G+KjP@tk`5LL9b6XVwh+4uKU4@
> > z^h{&^<A>>i=i1z-ryDb%S?XldmdUW%K;NPH1#Fsj(j<oMT)Un>fyq<zE4@nbEE~^w
> > znn?6aIU5PO#3%lEP8FYL`JVv0%4i@Cb_B(amD1q5E#6ZN;WU@UOy!$Ge6RFk+WPaI
> > z42xlj0KX9(uw(eperOve+6}yu@cRarAKC|T275@1{fBR|^6T_jJQ~qwG5ump+kQ2%
> > zjrB)yh5bRhav%G$--;{uU%LAYwrt1QL>rA3?SWz7v>(N^N$DmqIAWKY?*NxDIO5ev
> > z?aDh*Y+R;=gY$P{Ayr5je5dnb!ms;nF~qcu{3r<qX~z3?I@f*szHJ=EHsud5qkM3#
> > zmrErK^d0BtdpR><#Vjo1A-X_UNQv{aN4KH7_iXi&D||1rS!r(JF*-|VZ04#xc9Kq#
> > z-r`OxahY%JRTFd<yL;)NSQLB47?K|a#TP|@J7zGLaj@z!Y+B;vtUNi#Pg3-Vu>S)s
> > Cro3tZ
> >
> > literal 0
> > HcmV?d00001
> >
> > diff --git a/tests/data/acpi/q35/DSDT.ipmibt b/tests/data/acpi/q35/DSDT.ipmibt
> > index 631741065860fd5036aa303904dabd1d2839f9c6..6ad2411d0ec95f204cfc64b430c537bce09c35bd 100644
> > GIT binary patch
> > delta 24
> > gcmZ4ExW<voCD<iojRFG$quxZWD~xg*@1K<i0AMf(82|tP
> >
> > delta 24
> > gcmZ4ExW<voCD<iojRFG$qwYkmD~$3R@1K<i0AMQ!82|tP
> >
> > diff --git a/tests/data/acpi/q35/DSDT.ivrs b/tests/data/acpi/q35/DSDT.ivrs
> > index b0eafe90e5832935557ec5e6802c0147c88f379c..cad26e3f0c27a40a33101155a5282ed9bcb1d441 100644
> > GIT binary patch
> > delta 24
> > gcmez5@X3M8CD<jTNP&TYan?kxD~xg*?@yKo0BrUMn*aa+
> >
> > delta 24
> > gcmez5@X3M8CD<jTNP&TYappv>D~$3R?@yKo0BrFHn*aa+
> >
> > diff --git a/tests/data/acpi/q35/DSDT.memhp b/tests/data/acpi/q35/DSDT.memhp
> > index 9bc11518fc57687ca789dc70793b48b29a0d74ed..4e9cb3dc6896bb79ccac0fe342a404549f6610e8 100644
> > GIT binary patch
> > delta 24
> > gcmdnsy}_HyCD<iogDL|9<C}?GR~Y3s-oK~<0BV~F1poj5
> >
> > delta 24
> > gcmdnsy}_HyCD<iogDL|9<LilBR~Y3t-oK~<0BV*A1poj5
> >
> > diff --git a/tests/data/acpi/q35/DSDT.mmio64 b/tests/data/acpi/q35/DSDT.mmio64
> > index 713288a12ef2b70a20b4e8836c036ba4db3a57a8..eb5a1c7171c02d153487bfcecfb7019b7c1bf406 100644
> > GIT binary patch
> > delta 24
> > gcmX@@dD@f9CD<k8v<d?Q<BEw~R~Y3s-hZPE0B$h}CjbBd
> >
> > delta 24
> > gcmX@@dD@f9CD<k8v<d?Q<MN4IR~Y3t-hZPE0B$S^CjbBd
> >
> > diff --git a/tests/data/acpi/q35/DSDT.multi-bridge b/tests/data/acpi/q35/DSDT.multi-bridge
> > index a24c713d22102a1a1583b5c902edffe1694e5cfe..45808eb03b78d07ebbe853f674abfed589d35e26 100644
> > GIT binary patch
> > delta 24
> > fcmZp7Zg=K#33dr-S7cyd?3>7Sg;8$f{S^uTTRaEr
> >
> > delta 24
> > fcmZp7Zg=K#33dr-S7cyd?48JUg;9Rv{S^uTTQ>*m
> >
> > diff --git a/tests/data/acpi/q35/DSDT.nohpet b/tests/data/acpi/q35/DSDT.nohpet
> > index e8202e6ddfbe96071f32f1ec05758f650569943e..83d1aa00ac5686df479673fb0d7830f946e25dea 100644
> > GIT binary patch
> > delta 24
> > gcmca?f7zbPCD<k8vOEI=<B^G6R~Y3s-v1&80B=4CMF0Q*
> >
> > delta 24
> > gcmca?f7zbPCD<k8vOEI=<Kc;1R~Y3t-v1&80B<=7MF0Q*
> >
> > diff --git a/tests/data/acpi/q35/DSDT.nosmm b/tests/data/acpi/q35/DSDT.nosmm
> > new file mode 100644
> > index 0000000000000000000000000000000000000000..c1965f6051ef2af81dd8412abe169d87845bb033
> > GIT binary patch
> > literal 8289
> > zcmb7JOKcm*8J^`!tL0K!Qk3OaY{E(UN|8{0Bx#EVC3pF<L~6yQ;si9nrRB7;og#}k
> > z2J%1vSpgEqhoT9aphr4TfZp0uuQkw1d-JUUdg`H<T#F(`4`IK5h9l3A6cF>U+JE-@
> > z{(rvNo&8obUf^~51;&j3l{egaP$<9Ry9N9V#u%N`U#F3{%(}Z?xz;n%v4qjRo#y8_
> > zl+FB)z4BJg`29}!c^JO+QE2odcI6A_vn&1RgFE3BMxa|)BFmx^r?Sus%DwKMYx!=Y
> > zX!hz2&n`W%Ota^Tv$)wSd2MF)wi+JGug~>10ylB@26MejtHV}uu#;V~oNn`<=e{|8
> > z@)w_9daHE*=l}TS-5XW{fV22(;_tbL4&i&Dbt)V>pAN1W?-QM0TOBTaI^dT@n?qNk
> > zkXr89qKQ(i?%(L{z38<|F7IQ;Z}~;HxQc$c?I3&FI{DEGV>S&A{r)r>js7A|nez^F
> > znx;@$G3$P%BUKvEMyk5Ib-&YOHe(OIO|wMzwnOpK%axW_@Y`Omkbk}xbV@9umN25G
> > z{=1>&ghTt2LC6MSdNkT+!-Y=<efGP)&HnY@<UZTC7DeB(*20JL)Rza}vIJx3&G(+A
> > z-q3h=_l`G$QjZTY%AZD8{6>2-W`&mRtSvqlmq0>w_s*}CJ%GhMilg`Fl`M1ATCN!(
> > z3z=cmjH~P_{+@}UT6gcM=El|mYjH_qnO5=)jZk;*?7H7smAMn*ej6Iru`)H|?fBbq
> > z(>$}wGoN)gng^UD&=}1boQLs;ab})zIOpkh$35sxdVK$Q>WD?mFwZapL)6MX8lzp`
> > z4LU~pzHOPfH59lQyR8BaUZJ}iR4!r`{LQv-<I)tk<znR`E|go%wvm1yXcV~R)>gCN
> > zH@sI0U8B72uCe^nzFWB%>pn@*XcX-bB6`QT#wbVk`_#P8^3RmOnT4WU5go!YHq3h|
> > z-wT=x!}amhc<{pC{~cU-xB1D+*Ue*pb(<08di~eo@X5h-Has@CX2mcA-sjJejmLJx
> > z_Oo&0HXYc#mErQ>x-}Q&k};NH{V2TCXKcT3`VF_r@^%k@jcA7==Qpn!^sqSY*L))T
> > z?T(*YySbZ7C-8K#_10R2iE{(zRhF}<-HIWo$smrP&T^Rq`hl4waN~$r04|7YoCl~3
> > ziHZCi8{<r1#}P3lG{!g+P|ie1O!S6h<D4mb5NE`c(70d%%9#j>DXU;!2`tZ(;7kck
> > z2&U{jLRDu{)0yN<2~7&7>^wqMXG+tV;!Fum={garI_ET<bDGXMT_-|Sr>W^QHJzre
> > z6QQaTZy;r)=QW-4x=w_uPD|5iX*w-kCqh+cTGN@<bf$Hk2vwbU7b^GD)^yssPK2t?
> > zjHWZA>CEUl5vn>DG@T2Y&IMg3LRIIYrgKr#xv1+zsOoeyosOo{(RCtJb!Ii4SxskF
> > z*NITonbUOUG@UtJCqh-{lBRP>)48PUM5yY_YdZ6q&b+P@p{jFP)48naT-J3WRCONF
> > zbRN-k9?^9oRCVG@0#BcO53OiAS9F~SRh>sQokumDM|GVDRh`E;vowAa9^=gN_+@uY
> > zFx^KXF}*SNxW+uLF^}s^gevod#yp`hPv}g9D)XeqJgG5H>P&<x^9halgvNYAXChRY
> > zr#Mr(%qh;4@Ay-KDPP<Oi7D^kX|3jIt>$UHCPGougn^b61FZ!Ol;&n?;2ed=28sY>
> > zMG!|Ii^4z!j$4w!h$Z`Hps0Wz7$`z14F)Q((m)j`8K{6B7$`#YMjEKVjw7n68mNFC
> > z7$`#Yh+|=(0y~bz8ab2<R6u2@>V$!cw44b8RiI>`2&F5Mfg+STVW0xbnJ`cVN(L&R
> > zye1haLa7r5DzKah16818paRO7WS|J8P8g`bawZH^fs%m=C})y^B9!+N1}d<e2?JH2
> > zWS|1dnPi{{rA`>Az;Y%GRDqI#3Mglifg+STVW0xbnJ`cVN(L&RoJj_XQ0jz%3M^;B
> > zKouw%sDN@N87M-j69y`<oCyO}pk$x|%9&)K2&GOKsK9b23{-)VfeI*Rl7S+WI$@v!
> > z%b74x1xf}gpqxnticso=feI{V!ax-$8K{7ACK)I~sS^e&u$&14RiI>`0?L_Wpa`W-
> > z7^uK<CJa=8l7R{+XOe*;lsaLc0?U~&Pz6c`DxjQ628vMXgn<eyXTm@gC>f}LawZul
> > zLa7r5DzKah16818paRO7WS|J8P8g`bawZH^fs%m=C})y^B9uB|paRR8Fi-_b1}dPO
> > zNd}5g>V$y`EN8+%6(|{~fN~}oC_<?d28u{AP(-SMB2*0&p<<v469%d<$v_n*8K}a9
> > zfhtTGsKO)zRhVR;3KIsZFkzqylMGa0l7T8r7^uR8fhtTgP=!ebsxV=oh~(Xcfg-{k
> > z<AX^CiV(L!hQyR(3j;+Y#})>PNRBNTC_*{5WS|JKRCK%t3uQxl!2em@r+-NArRYzo
> > zd;6!)#p%CPTGgQS4#RJ6mf*OXWjeTY@Jxoam(2>DSLslrL*2|TH8!ytFr0tS+TFn-
> > z%ly8T&Yy2=y6t%Y+QsaGmHs%z=J`s{JM1pCSxFol(R(}ABBL{OqK&1O^*MYal;o0!
> > zjpZ6z3^LK}AbZ4G`gnoO$Kh@a?{9`TF;*|~i+mkupSpnFl=9i0*9h4AbZ+hPmPJ~R
> > zVnDcU9<TI*c3|Ay8TWz8Q~S7jd7?TNPrh^YvQoXwtC!I~wR$-}yL!31*Cg#?DGkeg
> > zW9?S#G0MA2d6$=WC(65rly}GFy$SIa7PP*zdQU0u@$%k8dGC<&-ne{avV7t(%2$-~
> > z6<)qFQND6W`O3I_b+UZ&G0In!@>O2GI#IrQNcrlxd~LFP>M_dKl=3xRzBW<5c1Zc!
> > zxO{!G{M=)duPf#2ynKD4eEpE}b(Bxgt8B8oBg)H{2R<t>-NpK?-j+}CDUUxiugB>o
> > zr?HjQ)8SiVDxGMXnQm%c=Ja&<0GUcB+GeJknrB!7rg<iX;j3gSooJhxZff4-^>p}D
> > znMx<xW~Q5(2g`aoe7{Vk6KyloO+D8~^mO>BnMx<xW~Q5ZPFM7F_|ln5C))IM&WT6s
> > z*?WsYvy814Y^&IDtob_|FNxiWx^?-{iof5k1oA1hFgf8(8Q0$`)Zch3di~a~3U9u4
> > z^Nm|?ZohVubq&{FUmHKI8Oy2}U)f*ThK*HycoHq0e`Q;C_x2AcD6xX;S6YVKXa$Db
> > zZoX__0lY|us=?x}+w`!=o+D)34Jzvez`atZfVJjEt6@fr8u8ShyUg{VL!y(JlIu5$
> > z#nmEpLu?!+^I5l3eKj_;20QFSw^%G*%hyv_y)VsopS=8BLT+u4P!d4P?~~0a7O`-6
> > zd@y-|Bt+ICmffeWtgr2d`DT)2JzgPWG8Hn+%%86waRawy9wNhZTa`<>*eGJ#k#Y44
> > zFE_YqMC@v0gc0k1v2Oo%5E`FtqbZEGCrfg{la073!<Ek_TX9>qzZ}jF`ql_#zKmvF
> > zA3ilTa&+IL?K{-RKD*UNukO7tyf6jhPX=z^wiS=21_l?wyR}Uli<N}fS)_zl*f!mA
> > zXxr|t&K5V73;nruW%e*P=iQB<V;?fiv!9l!{209G+KjP@tk`5LL9b6XVwh+4uKU4@
> > z^h{&^<A>>i=i1z-ryDb%S?XldmdUW%K;NPH1#Fsj(j<oMT)Un>fyq<zE4@nbEE~^w
> > znn?6aIU5PO#3%lEP8FYL`JVv0%4i@Cb_B(amD1q5E#6ZN;WU@UOy!$Ge6RFk+WPaI
> > z42xlj0KX9(uw(eperOve+6}yu@cRarAKC|T275@1{fBR|^6T_jJQ~qwG5ump+kQ2%
> > zjrB)yh5bRhav%G$--;{uU%LAYwrt1QL>rA3?SWz7v>(N^N$DmqIAWKY?*NxDIO5ev
> > z?aDh*Y+R;=gY$P{Ayr5je5dnb!ms;nF~qcu{3r<qX~z3?I@f*szHJ=EHsud5qkM3#
> > zmrErK^d0BtdpR><#Vjo1A-X_UNQv{aN4KH7_iXi&D||1rS!r(JF*-|VZ04#xc9Kq#
> > z-r`OxahY%JRTFd<yL;)NSQLB47?K|a#TP|@J7zGLaj@z!Y+B;vtUNi#Pg3-Vu>S)s
> > Cro3tZ
> >
> > literal 0
> > HcmV?d00001
> >
> > diff --git a/tests/data/acpi/q35/DSDT.numamem b/tests/data/acpi/q35/DSDT.numamem
> > index 151e7cf42953f3f5fe61ff0140ab7b976fe9e5b8..050aaa237b466b0bda8cca5cfaa06f84661d622e 100644
> > GIT binary patch
> > delta 24
> > gcmaFv@Z5pRCD<h-U4emtamhrkD~xg*?{~-p0BWTOc>n+a
> >
> > delta 24
> > gcmaFv@Z5pRCD<h-U4emtaq&d1D~$3R?{~-p0BWEJc>n+a
> >
> > diff --git a/tests/data/acpi/q35/DSDT.smm-compat b/tests/data/acpi/q35/DSDT.smm-compat
> > new file mode 100644
> > index 0000000000000000000000000000000000000000..c1965f6051ef2af81dd8412abe169d87845bb033
> > GIT binary patch
> > literal 8289
> > zcmb7JOKcm*8J^`!tL0K!Qk3OaY{E(UN|8{0Bx#EVC3pF<L~6yQ;si9nrRB7;og#}k
> > z2J%1vSpgEqhoT9aphr4TfZp0uuQkw1d-JUUdg`H<T#F(`4`IK5h9l3A6cF>U+JE-@
> > z{(rvNo&8obUf^~51;&j3l{egaP$<9Ry9N9V#u%N`U#F3{%(}Z?xz;n%v4qjRo#y8_
> > zl+FB)z4BJg`29}!c^JO+QE2odcI6A_vn&1RgFE3BMxa|)BFmx^r?Sus%DwKMYx!=Y
> > zX!hz2&n`W%Ota^Tv$)wSd2MF)wi+JGug~>10ylB@26MejtHV}uu#;V~oNn`<=e{|8
> > z@)w_9daHE*=l}TS-5XW{fV22(;_tbL4&i&Dbt)V>pAN1W?-QM0TOBTaI^dT@n?qNk
> > zkXr89qKQ(i?%(L{z38<|F7IQ;Z}~;HxQc$c?I3&FI{DEGV>S&A{r)r>js7A|nez^F
> > znx;@$G3$P%BUKvEMyk5Ib-&YOHe(OIO|wMzwnOpK%axW_@Y`Omkbk}xbV@9umN25G
> > z{=1>&ghTt2LC6MSdNkT+!-Y=<efGP)&HnY@<UZTC7DeB(*20JL)Rza}vIJx3&G(+A
> > z-q3h=_l`G$QjZTY%AZD8{6>2-W`&mRtSvqlmq0>w_s*}CJ%GhMilg`Fl`M1ATCN!(
> > z3z=cmjH~P_{+@}UT6gcM=El|mYjH_qnO5=)jZk;*?7H7smAMn*ej6Iru`)H|?fBbq
> > z(>$}wGoN)gng^UD&=}1boQLs;ab})zIOpkh$35sxdVK$Q>WD?mFwZapL)6MX8lzp`
> > z4LU~pzHOPfH59lQyR8BaUZJ}iR4!r`{LQv-<I)tk<znR`E|go%wvm1yXcV~R)>gCN
> > zH@sI0U8B72uCe^nzFWB%>pn@*XcX-bB6`QT#wbVk`_#P8^3RmOnT4WU5go!YHq3h|
> > z-wT=x!}amhc<{pC{~cU-xB1D+*Ue*pb(<08di~eo@X5h-Has@CX2mcA-sjJejmLJx
> > z_Oo&0HXYc#mErQ>x-}Q&k};NH{V2TCXKcT3`VF_r@^%k@jcA7==Qpn!^sqSY*L))T
> > z?T(*YySbZ7C-8K#_10R2iE{(zRhF}<-HIWo$smrP&T^Rq`hl4waN~$r04|7YoCl~3
> > ziHZCi8{<r1#}P3lG{!g+P|ie1O!S6h<D4mb5NE`c(70d%%9#j>DXU;!2`tZ(;7kck
> > z2&U{jLRDu{)0yN<2~7&7>^wqMXG+tV;!Fum={garI_ET<bDGXMT_-|Sr>W^QHJzre
> > z6QQaTZy;r)=QW-4x=w_uPD|5iX*w-kCqh+cTGN@<bf$Hk2vwbU7b^GD)^yssPK2t?
> > zjHWZA>CEUl5vn>DG@T2Y&IMg3LRIIYrgKr#xv1+zsOoeyosOo{(RCtJb!Ii4SxskF
> > z*NITonbUOUG@UtJCqh-{lBRP>)48PUM5yY_YdZ6q&b+P@p{jFP)48naT-J3WRCONF
> > zbRN-k9?^9oRCVG@0#BcO53OiAS9F~SRh>sQokumDM|GVDRh`E;vowAa9^=gN_+@uY
> > zFx^KXF}*SNxW+uLF^}s^gevod#yp`hPv}g9D)XeqJgG5H>P&<x^9halgvNYAXChRY
> > zr#Mr(%qh;4@Ay-KDPP<Oi7D^kX|3jIt>$UHCPGougn^b61FZ!Ol;&n?;2ed=28sY>
> > zMG!|Ii^4z!j$4w!h$Z`Hps0Wz7$`z14F)Q((m)j`8K{6B7$`#YMjEKVjw7n68mNFC
> > z7$`#Yh+|=(0y~bz8ab2<R6u2@>V$!cw44b8RiI>`2&F5Mfg+STVW0xbnJ`cVN(L&R
> > zye1haLa7r5DzKah16818paRO7WS|J8P8g`bawZH^fs%m=C})y^B9!+N1}d<e2?JH2
> > zWS|1dnPi{{rA`>Az;Y%GRDqI#3Mglifg+STVW0xbnJ`cVN(L&RoJj_XQ0jz%3M^;B
> > zKouw%sDN@N87M-j69y`<oCyO}pk$x|%9&)K2&GOKsK9b23{-)VfeI*Rl7S+WI$@v!
> > z%b74x1xf}gpqxnticso=feI{V!ax-$8K{7ACK)I~sS^e&u$&14RiI>`0?L_Wpa`W-
> > z7^uK<CJa=8l7R{+XOe*;lsaLc0?U~&Pz6c`DxjQ628vMXgn<eyXTm@gC>f}LawZul
> > zLa7r5DzKah16818paRO7WS|J8P8g`bawZH^fs%m=C})y^B9uB|paRR8Fi-_b1}dPO
> > zNd}5g>V$y`EN8+%6(|{~fN~}oC_<?d28u{AP(-SMB2*0&p<<v469%d<$v_n*8K}a9
> > zfhtTGsKO)zRhVR;3KIsZFkzqylMGa0l7T8r7^uR8fhtTgP=!ebsxV=oh~(Xcfg-{k
> > z<AX^CiV(L!hQyR(3j;+Y#})>PNRBNTC_*{5WS|JKRCK%t3uQxl!2em@r+-NArRYzo
> > zd;6!)#p%CPTGgQS4#RJ6mf*OXWjeTY@Jxoam(2>DSLslrL*2|TH8!ytFr0tS+TFn-
> > z%ly8T&Yy2=y6t%Y+QsaGmHs%z=J`s{JM1pCSxFol(R(}ABBL{OqK&1O^*MYal;o0!
> > zjpZ6z3^LK}AbZ4G`gnoO$Kh@a?{9`TF;*|~i+mkupSpnFl=9i0*9h4AbZ+hPmPJ~R
> > zVnDcU9<TI*c3|Ay8TWz8Q~S7jd7?TNPrh^YvQoXwtC!I~wR$-}yL!31*Cg#?DGkeg
> > zW9?S#G0MA2d6$=WC(65rly}GFy$SIa7PP*zdQU0u@$%k8dGC<&-ne{avV7t(%2$-~
> > z6<)qFQND6W`O3I_b+UZ&G0In!@>O2GI#IrQNcrlxd~LFP>M_dKl=3xRzBW<5c1Zc!
> > zxO{!G{M=)duPf#2ynKD4eEpE}b(Bxgt8B8oBg)H{2R<t>-NpK?-j+}CDUUxiugB>o
> > zr?HjQ)8SiVDxGMXnQm%c=Ja&<0GUcB+GeJknrB!7rg<iX;j3gSooJhxZff4-^>p}D
> > znMx<xW~Q5(2g`aoe7{Vk6KyloO+D8~^mO>BnMx<xW~Q5ZPFM7F_|ln5C))IM&WT6s
> > z*?WsYvy814Y^&IDtob_|FNxiWx^?-{iof5k1oA1hFgf8(8Q0$`)Zch3di~a~3U9u4
> > z^Nm|?ZohVubq&{FUmHKI8Oy2}U)f*ThK*HycoHq0e`Q;C_x2AcD6xX;S6YVKXa$Db
> > zZoX__0lY|us=?x}+w`!=o+D)34Jzvez`atZfVJjEt6@fr8u8ShyUg{VL!y(JlIu5$
> > z#nmEpLu?!+^I5l3eKj_;20QFSw^%G*%hyv_y)VsopS=8BLT+u4P!d4P?~~0a7O`-6
> > zd@y-|Bt+ICmffeWtgr2d`DT)2JzgPWG8Hn+%%86waRawy9wNhZTa`<>*eGJ#k#Y44
> > zFE_YqMC@v0gc0k1v2Oo%5E`FtqbZEGCrfg{la073!<Ek_TX9>qzZ}jF`ql_#zKmvF
> > zA3ilTa&+IL?K{-RKD*UNukO7tyf6jhPX=z^wiS=21_l?wyR}Uli<N}fS)_zl*f!mA
> > zXxr|t&K5V73;nruW%e*P=iQB<V;?fiv!9l!{209G+KjP@tk`5LL9b6XVwh+4uKU4@
> > z^h{&^<A>>i=i1z-ryDb%S?XldmdUW%K;NPH1#Fsj(j<oMT)Un>fyq<zE4@nbEE~^w
> > znn?6aIU5PO#3%lEP8FYL`JVv0%4i@Cb_B(amD1q5E#6ZN;WU@UOy!$Ge6RFk+WPaI
> > z42xlj0KX9(uw(eperOve+6}yu@cRarAKC|T275@1{fBR|^6T_jJQ~qwG5ump+kQ2%
> > zjrB)yh5bRhav%G$--;{uU%LAYwrt1QL>rA3?SWz7v>(N^N$DmqIAWKY?*NxDIO5ev
> > z?aDh*Y+R;=gY$P{Ayr5je5dnb!ms;nF~qcu{3r<qX~z3?I@f*szHJ=EHsud5qkM3#
> > zmrErK^d0BtdpR><#Vjo1A-X_UNQv{aN4KH7_iXi&D||1rS!r(JF*-|VZ04#xc9Kq#
> > z-r`OxahY%JRTFd<yL;)NSQLB47?K|a#TP|@J7zGLaj@z!Y+B;vtUNi#Pg3-Vu>S)s
> > Cro3tZ
> >
> > literal 0
> > HcmV?d00001
> >
> > diff --git a/tests/data/acpi/q35/DSDT.smm-compat-nosmm b/tests/data/acpi/q35/DSDT.smm-compat-nosmm
> > new file mode 100644
> > index 0000000000000000000000000000000000000000..c1965f6051ef2af81dd8412abe169d87845bb033
> > GIT binary patch
> > literal 8289
> > zcmb7JOKcm*8J^`!tL0K!Qk3OaY{E(UN|8{0Bx#EVC3pF<L~6yQ;si9nrRB7;og#}k
> > z2J%1vSpgEqhoT9aphr4TfZp0uuQkw1d-JUUdg`H<T#F(`4`IK5h9l3A6cF>U+JE-@
> > z{(rvNo&8obUf^~51;&j3l{egaP$<9Ry9N9V#u%N`U#F3{%(}Z?xz;n%v4qjRo#y8_
> > zl+FB)z4BJg`29}!c^JO+QE2odcI6A_vn&1RgFE3BMxa|)BFmx^r?Sus%DwKMYx!=Y
> > zX!hz2&n`W%Ota^Tv$)wSd2MF)wi+JGug~>10ylB@26MejtHV}uu#;V~oNn`<=e{|8
> > z@)w_9daHE*=l}TS-5XW{fV22(;_tbL4&i&Dbt)V>pAN1W?-QM0TOBTaI^dT@n?qNk
> > zkXr89qKQ(i?%(L{z38<|F7IQ;Z}~;HxQc$c?I3&FI{DEGV>S&A{r)r>js7A|nez^F
> > znx;@$G3$P%BUKvEMyk5Ib-&YOHe(OIO|wMzwnOpK%axW_@Y`Omkbk}xbV@9umN25G
> > z{=1>&ghTt2LC6MSdNkT+!-Y=<efGP)&HnY@<UZTC7DeB(*20JL)Rza}vIJx3&G(+A
> > z-q3h=_l`G$QjZTY%AZD8{6>2-W`&mRtSvqlmq0>w_s*}CJ%GhMilg`Fl`M1ATCN!(
> > z3z=cmjH~P_{+@}UT6gcM=El|mYjH_qnO5=)jZk;*?7H7smAMn*ej6Iru`)H|?fBbq
> > z(>$}wGoN)gng^UD&=}1boQLs;ab})zIOpkh$35sxdVK$Q>WD?mFwZapL)6MX8lzp`
> > z4LU~pzHOPfH59lQyR8BaUZJ}iR4!r`{LQv-<I)tk<znR`E|go%wvm1yXcV~R)>gCN
> > zH@sI0U8B72uCe^nzFWB%>pn@*XcX-bB6`QT#wbVk`_#P8^3RmOnT4WU5go!YHq3h|
> > z-wT=x!}amhc<{pC{~cU-xB1D+*Ue*pb(<08di~eo@X5h-Has@CX2mcA-sjJejmLJx
> > z_Oo&0HXYc#mErQ>x-}Q&k};NH{V2TCXKcT3`VF_r@^%k@jcA7==Qpn!^sqSY*L))T
> > z?T(*YySbZ7C-8K#_10R2iE{(zRhF}<-HIWo$smrP&T^Rq`hl4waN~$r04|7YoCl~3
> > ziHZCi8{<r1#}P3lG{!g+P|ie1O!S6h<D4mb5NE`c(70d%%9#j>DXU;!2`tZ(;7kck
> > z2&U{jLRDu{)0yN<2~7&7>^wqMXG+tV;!Fum={garI_ET<bDGXMT_-|Sr>W^QHJzre
> > z6QQaTZy;r)=QW-4x=w_uPD|5iX*w-kCqh+cTGN@<bf$Hk2vwbU7b^GD)^yssPK2t?
> > zjHWZA>CEUl5vn>DG@T2Y&IMg3LRIIYrgKr#xv1+zsOoeyosOo{(RCtJb!Ii4SxskF
> > z*NITonbUOUG@UtJCqh-{lBRP>)48PUM5yY_YdZ6q&b+P@p{jFP)48naT-J3WRCONF
> > zbRN-k9?^9oRCVG@0#BcO53OiAS9F~SRh>sQokumDM|GVDRh`E;vowAa9^=gN_+@uY
> > zFx^KXF}*SNxW+uLF^}s^gevod#yp`hPv}g9D)XeqJgG5H>P&<x^9halgvNYAXChRY
> > zr#Mr(%qh;4@Ay-KDPP<Oi7D^kX|3jIt>$UHCPGougn^b61FZ!Ol;&n?;2ed=28sY>
> > zMG!|Ii^4z!j$4w!h$Z`Hps0Wz7$`z14F)Q((m)j`8K{6B7$`#YMjEKVjw7n68mNFC
> > z7$`#Yh+|=(0y~bz8ab2<R6u2@>V$!cw44b8RiI>`2&F5Mfg+STVW0xbnJ`cVN(L&R
> > zye1haLa7r5DzKah16818paRO7WS|J8P8g`bawZH^fs%m=C})y^B9!+N1}d<e2?JH2
> > zWS|1dnPi{{rA`>Az;Y%GRDqI#3Mglifg+STVW0xbnJ`cVN(L&RoJj_XQ0jz%3M^;B
> > zKouw%sDN@N87M-j69y`<oCyO}pk$x|%9&)K2&GOKsK9b23{-)VfeI*Rl7S+WI$@v!
> > z%b74x1xf}gpqxnticso=feI{V!ax-$8K{7ACK)I~sS^e&u$&14RiI>`0?L_Wpa`W-
> > z7^uK<CJa=8l7R{+XOe*;lsaLc0?U~&Pz6c`DxjQ628vMXgn<eyXTm@gC>f}LawZul
> > zLa7r5DzKah16818paRO7WS|J8P8g`bawZH^fs%m=C})y^B9uB|paRR8Fi-_b1}dPO
> > zNd}5g>V$y`EN8+%6(|{~fN~}oC_<?d28u{AP(-SMB2*0&p<<v469%d<$v_n*8K}a9
> > zfhtTGsKO)zRhVR;3KIsZFkzqylMGa0l7T8r7^uR8fhtTgP=!ebsxV=oh~(Xcfg-{k
> > z<AX^CiV(L!hQyR(3j;+Y#})>PNRBNTC_*{5WS|JKRCK%t3uQxl!2em@r+-NArRYzo
> > zd;6!)#p%CPTGgQS4#RJ6mf*OXWjeTY@Jxoam(2>DSLslrL*2|TH8!ytFr0tS+TFn-
> > z%ly8T&Yy2=y6t%Y+QsaGmHs%z=J`s{JM1pCSxFol(R(}ABBL{OqK&1O^*MYal;o0!
> > zjpZ6z3^LK}AbZ4G`gnoO$Kh@a?{9`TF;*|~i+mkupSpnFl=9i0*9h4AbZ+hPmPJ~R
> > zVnDcU9<TI*c3|Ay8TWz8Q~S7jd7?TNPrh^YvQoXwtC!I~wR$-}yL!31*Cg#?DGkeg
> > zW9?S#G0MA2d6$=WC(65rly}GFy$SIa7PP*zdQU0u@$%k8dGC<&-ne{avV7t(%2$-~
> > z6<)qFQND6W`O3I_b+UZ&G0In!@>O2GI#IrQNcrlxd~LFP>M_dKl=3xRzBW<5c1Zc!
> > zxO{!G{M=)duPf#2ynKD4eEpE}b(Bxgt8B8oBg)H{2R<t>-NpK?-j+}CDUUxiugB>o
> > zr?HjQ)8SiVDxGMXnQm%c=Ja&<0GUcB+GeJknrB!7rg<iX;j3gSooJhxZff4-^>p}D
> > znMx<xW~Q5(2g`aoe7{Vk6KyloO+D8~^mO>BnMx<xW~Q5ZPFM7F_|ln5C))IM&WT6s
> > z*?WsYvy814Y^&IDtob_|FNxiWx^?-{iof5k1oA1hFgf8(8Q0$`)Zch3di~a~3U9u4
> > z^Nm|?ZohVubq&{FUmHKI8Oy2}U)f*ThK*HycoHq0e`Q;C_x2AcD6xX;S6YVKXa$Db
> > zZoX__0lY|us=?x}+w`!=o+D)34Jzvez`atZfVJjEt6@fr8u8ShyUg{VL!y(JlIu5$
> > z#nmEpLu?!+^I5l3eKj_;20QFSw^%G*%hyv_y)VsopS=8BLT+u4P!d4P?~~0a7O`-6
> > zd@y-|Bt+ICmffeWtgr2d`DT)2JzgPWG8Hn+%%86waRawy9wNhZTa`<>*eGJ#k#Y44
> > zFE_YqMC@v0gc0k1v2Oo%5E`FtqbZEGCrfg{la073!<Ek_TX9>qzZ}jF`ql_#zKmvF
> > zA3ilTa&+IL?K{-RKD*UNukO7tyf6jhPX=z^wiS=21_l?wyR}Uli<N}fS)_zl*f!mA
> > zXxr|t&K5V73;nruW%e*P=iQB<V;?fiv!9l!{209G+KjP@tk`5LL9b6XVwh+4uKU4@
> > z^h{&^<A>>i=i1z-ryDb%S?XldmdUW%K;NPH1#Fsj(j<oMT)Un>fyq<zE4@nbEE~^w
> > znn?6aIU5PO#3%lEP8FYL`JVv0%4i@Cb_B(amD1q5E#6ZN;WU@UOy!$Ge6RFk+WPaI
> > z42xlj0KX9(uw(eperOve+6}yu@cRarAKC|T275@1{fBR|^6T_jJQ~qwG5ump+kQ2%
> > zjrB)yh5bRhav%G$--;{uU%LAYwrt1QL>rA3?SWz7v>(N^N$DmqIAWKY?*NxDIO5ev
> > z?aDh*Y+R;=gY$P{Ayr5je5dnb!ms;nF~qcu{3r<qX~z3?I@f*szHJ=EHsud5qkM3#
> > zmrErK^d0BtdpR><#Vjo1A-X_UNQv{aN4KH7_iXi&D||1rS!r(JF*-|VZ04#xc9Kq#
> > z-r`OxahY%JRTFd<yL;)NSQLB47?K|a#TP|@J7zGLaj@z!Y+B;vtUNi#Pg3-Vu>S)s
> > Cro3tZ
> >
> > literal 0
> > HcmV?d00001
> >
> > diff --git a/tests/data/acpi/q35/DSDT.tis.tpm12 b/tests/data/acpi/q35/DSDT.tis.tpm12
> > index c96b5277a14ae98174408d690d6e0246bd932623..0ebdf6fbd77967f1ab5d5337b7b1fed314cfaca8 100644
> > GIT binary patch
> > delta 24
> > gcmdnzy3du%CD<iopArKDqxwXyD~xg*@84Gh0A(f!W&i*H
> >
> > delta 24
> > gcmdnzy3du%CD<iopArKDquNBSD~$3R@84Gh0A(QvW&i*H
> >
> > diff --git a/tests/data/acpi/q35/DSDT.tis.tpm2 b/tests/data/acpi/q35/DSDT.tis.tpm2
> > index c92d4d29c79352a60974ea9f665d0b9a410a4bac..dcbb7f0af377425db53130e8ba1c62c09c22e006 100644
> > GIT binary patch
> > delta 24
> > gcmdnzy3du%CD<iopArKD<D-dOR~Y3s-oLL10Bm##ApigX
> >
> > delta 24
> > gcmdnzy3du%CD<iopArKD<HLzuR~Y3t-oLL10BmmwApigX
> >
> > diff --git a/tests/data/acpi/q35/DSDT.xapic b/tests/data/acpi/q35/DSDT.xapic
> > index 119fc90f1f8a7b6934df6fd95609446e627ce15d..17552ce363ae81985f69f9ae85837a1540b79ae0 100644
> > GIT binary patch
> > delta 26
> > icmX>yjp@iVCN7s?mk^h31_s6r6S=N1%5A)#+64f6_X&Rh
> >
> > delta 26
> > icmX>yjp@iVCN7s?mk^h31_s9U6S=N1%5S`%+64f6@(F(c
> >
> > --
> > 2.27.0
>
^ permalink raw reply [flat|nested] 24+ messages in thread
* Re: [PATCH for 6.2 v2 5/5] bios-tables-test: Update golden binaries
2021-11-11 11:32 ` Igor Mammedov
@ 2021-11-11 13:47 ` Thomas Lamprecht
2021-11-11 15:31 ` Michael S. Tsirkin
1 sibling, 0 replies; 24+ messages in thread
From: Thomas Lamprecht @ 2021-11-11 13:47 UTC (permalink / raw)
To: Igor Mammedov, Michael S. Tsirkin
Cc: ani, mapfelba, jusual, qemu-devel, kraxel
On 11.11.21 12:32, Igor Mammedov wrote:
> On Thu, 11 Nov 2021 03:34:37 -0500
> "Michael S. Tsirkin" <mst@redhat.com> wrote:
>
>> On Wed, Nov 10, 2021 at 04:11:40PM -0500, Igor Mammedov wrote:
>>> From: Julia Suvorova <jusual@redhat.com>
>>>
>>> The changes are the result of
>>> 'hw/i386/acpi-build: Deny control on PCIe Native Hot-Plug in _OSC'
>>> and listed here:
>>>
>>> Method (_OSC, 4, NotSerialized) // _OSC: Operating System Capabilities
>>> {
>>> CreateDWordField (Arg3, Zero, CDW1)
>>> If ((Arg0 == ToUUID ("33db4d5b-1ff7-401c-9657-7441c03dd766") /* PCI Host Bridge Device */))
>>> {
>>> CreateDWordField (Arg3, 0x04, CDW2)
>>> CreateDWordField (Arg3, 0x08, CDW3)
>>> Local0 = CDW3 /* \_SB_.PCI0._OSC.CDW3 */
>>> - Local0 &= 0x1F
>>> + Local0 &= 0x1E
>>>
>>> Signed-off-by: Julia Suvorova <jusual@redhat.com>
>>> Signed-off-by: Igor Mammedov <imammedo@redhat.com>
>>> ---
>>> tests/qtest/bios-tables-test-allowed-diff.h | 16 ----------------
>>> tests/data/acpi/q35/DSDT | Bin 8289 -> 8289 bytes
>>> tests/data/acpi/q35/DSDT.acpihmat | Bin 9614 -> 9614 bytes
>>> tests/data/acpi/q35/DSDT.bridge | Bin 11003 -> 11003 bytes
>>> tests/data/acpi/q35/DSDT.cphp | Bin 8753 -> 8753 bytes
>>> tests/data/acpi/q35/DSDT.dimmpxm | Bin 9943 -> 9943 bytes
>>> tests/data/acpi/q35/DSDT.dmar | Bin 0 -> 8289 bytes
>>> tests/data/acpi/q35/DSDT.ipmibt | Bin 8364 -> 8364 bytes
>>> tests/data/acpi/q35/DSDT.ivrs | Bin 8306 -> 8306 bytes
>>> tests/data/acpi/q35/DSDT.memhp | Bin 9648 -> 9648 bytes
>>> tests/data/acpi/q35/DSDT.mmio64 | Bin 9419 -> 9419 bytes
>>> tests/data/acpi/q35/DSDT.multi-bridge | Bin 8583 -> 8583 bytes
>>> tests/data/acpi/q35/DSDT.nohpet | Bin 8147 -> 8147 bytes
>>> tests/data/acpi/q35/DSDT.nosmm | Bin 0 -> 8289 bytes
>>> tests/data/acpi/q35/DSDT.numamem | Bin 8295 -> 8295 bytes
>>> tests/data/acpi/q35/DSDT.smm-compat | Bin 0 -> 8289 bytes
>>> tests/data/acpi/q35/DSDT.smm-compat-nosmm | Bin 0 -> 8289 bytes
>>> tests/data/acpi/q35/DSDT.tis.tpm12 | Bin 8894 -> 8894 bytes
>>> tests/data/acpi/q35/DSDT.tis.tpm2 | Bin 8894 -> 8894 bytes
>>> tests/data/acpi/q35/DSDT.xapic | Bin 35652 -> 35652 bytes
>> Why do we have all the new files? What is going on here?
> I think new files are not necessary.
>
> I can update patch if we decide to keep ACPI enabled by default.
>
> So question is:
> do we revert to native pcie or stay with apci hootplug for 6.2?
>
FWIW, we had to add some compat handling in Proxmox VE for the original change
as we do not pin Linux VM machines between cold-starts (they normally do not care
much about some HW/CPU bits added/dropped/moved) and the change here messed a bit
with the guest OS network configuration, as systemd's predictable interface naming
changed the name from, e.g., enp18 to ens6p18.
I mean, we wondered a bit over the original change here and contemplated reverting
it in our downstream build. While we read the reasons got a report of any of that
problems happen from our upper 6 digit count of systems reporting to our repos.
Ultimately we did not went with the revert to avoid problems if this was QEMU's
way forward, wrong choice it seems, and it now additionally seems that ACPI hotplug
produces boot-loops in some guests with seabios and serial or no display.
Anyhow (sorry for the whole back-story/rambling), if QEMU reverts this for 6.2 I
think we'd pull the line now and revert it in our 6.1 build we plan to fully roll
out soon, to avoid this whole mess for most of our user base in the first place..
- Thomas
^ permalink raw reply [flat|nested] 24+ messages in thread
* Re: [PATCH for 6.2 v2 5/5] bios-tables-test: Update golden binaries
2021-11-11 11:32 ` Igor Mammedov
2021-11-11 13:47 ` Thomas Lamprecht
@ 2021-11-11 15:31 ` Michael S. Tsirkin
1 sibling, 0 replies; 24+ messages in thread
From: Michael S. Tsirkin @ 2021-11-11 15:31 UTC (permalink / raw)
To: Igor Mammedov; +Cc: ani, mapfelba, jusual, qemu-devel, kraxel
On Thu, Nov 11, 2021 at 12:32:36PM +0100, Igor Mammedov wrote:
> On Thu, 11 Nov 2021 03:34:37 -0500
> "Michael S. Tsirkin" <mst@redhat.com> wrote:
>
> > On Wed, Nov 10, 2021 at 04:11:40PM -0500, Igor Mammedov wrote:
> > > From: Julia Suvorova <jusual@redhat.com>
> > >
> > > The changes are the result of
> > > 'hw/i386/acpi-build: Deny control on PCIe Native Hot-Plug in _OSC'
> > > and listed here:
> > >
> > > Method (_OSC, 4, NotSerialized) // _OSC: Operating System Capabilities
> > > {
> > > CreateDWordField (Arg3, Zero, CDW1)
> > > If ((Arg0 == ToUUID ("33db4d5b-1ff7-401c-9657-7441c03dd766") /* PCI Host Bridge Device */))
> > > {
> > > CreateDWordField (Arg3, 0x04, CDW2)
> > > CreateDWordField (Arg3, 0x08, CDW3)
> > > Local0 = CDW3 /* \_SB_.PCI0._OSC.CDW3 */
> > > - Local0 &= 0x1F
> > > + Local0 &= 0x1E
> > >
> > > Signed-off-by: Julia Suvorova <jusual@redhat.com>
> > > Signed-off-by: Igor Mammedov <imammedo@redhat.com>
> > > ---
> > > tests/qtest/bios-tables-test-allowed-diff.h | 16 ----------------
> > > tests/data/acpi/q35/DSDT | Bin 8289 -> 8289 bytes
> > > tests/data/acpi/q35/DSDT.acpihmat | Bin 9614 -> 9614 bytes
> > > tests/data/acpi/q35/DSDT.bridge | Bin 11003 -> 11003 bytes
> > > tests/data/acpi/q35/DSDT.cphp | Bin 8753 -> 8753 bytes
> > > tests/data/acpi/q35/DSDT.dimmpxm | Bin 9943 -> 9943 bytes
> > > tests/data/acpi/q35/DSDT.dmar | Bin 0 -> 8289 bytes
> > > tests/data/acpi/q35/DSDT.ipmibt | Bin 8364 -> 8364 bytes
> > > tests/data/acpi/q35/DSDT.ivrs | Bin 8306 -> 8306 bytes
> > > tests/data/acpi/q35/DSDT.memhp | Bin 9648 -> 9648 bytes
> > > tests/data/acpi/q35/DSDT.mmio64 | Bin 9419 -> 9419 bytes
> > > tests/data/acpi/q35/DSDT.multi-bridge | Bin 8583 -> 8583 bytes
> > > tests/data/acpi/q35/DSDT.nohpet | Bin 8147 -> 8147 bytes
> > > tests/data/acpi/q35/DSDT.nosmm | Bin 0 -> 8289 bytes
> > > tests/data/acpi/q35/DSDT.numamem | Bin 8295 -> 8295 bytes
> > > tests/data/acpi/q35/DSDT.smm-compat | Bin 0 -> 8289 bytes
> > > tests/data/acpi/q35/DSDT.smm-compat-nosmm | Bin 0 -> 8289 bytes
> > > tests/data/acpi/q35/DSDT.tis.tpm12 | Bin 8894 -> 8894 bytes
> > > tests/data/acpi/q35/DSDT.tis.tpm2 | Bin 8894 -> 8894 bytes
> > > tests/data/acpi/q35/DSDT.xapic | Bin 35652 -> 35652 bytes
> >
> > Why do we have all the new files? What is going on here?
>
> I think new files are not necessary.
>
> I can update patch if we decide to keep ACPI enabled by default.
>
> So question is:
> do we revert to native pcie or stay with apci hootplug for 6.2?
Switching to native after rc0 seems too risky given
we stayed with ACPI for all of the devel cycle.
> >
> > > 20 files changed, 16 deletions(-)
> > > create mode 100644 tests/data/acpi/q35/DSDT.dmar
> > > create mode 100644 tests/data/acpi/q35/DSDT.nosmm
> > > create mode 100644 tests/data/acpi/q35/DSDT.smm-compat
> > > create mode 100644 tests/data/acpi/q35/DSDT.smm-compat-nosmm
> > >
> > > diff --git a/tests/qtest/bios-tables-test-allowed-diff.h b/tests/qtest/bios-tables-test-allowed-diff.h
> > > index 48e5634d4b..dfb8523c8b 100644
> > > --- a/tests/qtest/bios-tables-test-allowed-diff.h
> > > +++ b/tests/qtest/bios-tables-test-allowed-diff.h
> > > @@ -1,17 +1 @@
> > > /* List of comma-separated changed AML files to ignore */
> > > -"tests/data/acpi/q35/DSDT",
> > > -"tests/data/acpi/q35/DSDT.tis",
> > > -"tests/data/acpi/q35/DSDT.bridge",
> > > -"tests/data/acpi/q35/DSDT.mmio64",
> > > -"tests/data/acpi/q35/DSDT.ipmibt",
> > > -"tests/data/acpi/q35/DSDT.cphp",
> > > -"tests/data/acpi/q35/DSDT.memhp",
> > > -"tests/data/acpi/q35/DSDT.acpihmat",
> > > -"tests/data/acpi/q35/DSDT.numamem",
> > > -"tests/data/acpi/q35/DSDT.dimmpxm",
> > > -"tests/data/acpi/q35/DSDT.nohpet",
> > > -"tests/data/acpi/q35/DSDT.tis.tpm2",
> > > -"tests/data/acpi/q35/DSDT.tis.tpm12",
> > > -"tests/data/acpi/q35/DSDT.multi-bridge",
> > > -"tests/data/acpi/q35/DSDT.ivrs",
> > > -"tests/data/acpi/q35/DSDT.xapic",
> > > diff --git a/tests/data/acpi/q35/DSDT b/tests/data/acpi/q35/DSDT
> > > index 281fc82c03b2562d2e6b7caec0d817b034a47138..c1965f6051ef2af81dd8412abe169d87845bb033 100644
> > > GIT binary patch
> > > delta 24
> > > gcmaFp@X&$FCD<h-QGtPh@z+GID~xg*?>ET<0BnZ{w*UYD
> > >
> > > delta 24
> > > gcmaFp@X&$FCD<h-QGtPh@#jRYD~$3R?>ET<0BnK?w*UYD
> > >
> > > diff --git a/tests/data/acpi/q35/DSDT.acpihmat b/tests/data/acpi/q35/DSDT.acpihmat
> > > index 8c1e05a11a328ec1cc6f86e36e52c28f41f9744e..f24d4874bff8d327a165ed7c36de507aea114edd 100644
> > > GIT binary patch
> > > delta 24
> > > fcmeD4?(^ny33dtTQ)OUa+&+=(3ZvY{`|DKzU@Hhn
> > >
> > > delta 24
> > > fcmeD4?(^ny33dtTQ)OUa+%}Qx3ZwkS`|DKzU?vDi
> > >
> > > diff --git a/tests/data/acpi/q35/DSDT.bridge b/tests/data/acpi/q35/DSDT.bridge
> > > index 6f1464b6c712d7f33cb4b891b7ce76fe228f44c9..424d51bd1cb39ea73501ef7d0044ee52cec5bdac 100644
> > > GIT binary patch
> > > delta 24
> > > gcmewz`a6`%CD<k8w-y5fBg;gtD~xg*@5^Wb0CWThXaE2J
> > >
> > > delta 24
> > > gcmewz`a6`%CD<k8w-y5fBlASAD~$3R@5^Wb0CWEcXaE2J
> > >
> > > diff --git a/tests/data/acpi/q35/DSDT.cphp b/tests/data/acpi/q35/DSDT.cphp
> > > index f8337ff5191a37a47dcf7c09a6c39c4e704a15bf..f1275606f68eeba54bfb11e63d818420385a62b9 100644
> > > GIT binary patch
> > > delta 24
> > > fcmdn!veAXhCD<jzP>F$oF>WH)6-K#@_k$DxTWtqt
> > >
> > > delta 24
> > > fcmdn!veAXhCD<jzP>F$oF?J%?6-N1u_k$DxTWAMo
> > >
> > > diff --git a/tests/data/acpi/q35/DSDT.dimmpxm b/tests/data/acpi/q35/DSDT.dimmpxm
> > > index fe5820d93d057ef09a001662369b15afbc5b87e2..76e451e829ec4c245315f7eed8731aa1be45a747 100644
> > > GIT binary patch
> > > delta 24
> > > gcmccad)=4ICD<k8x*7umqsK(9D~xg*@BdH*0B$o00{{R3
> > >
> > > delta 24
> > > gcmccad)=4ICD<k8x*7umqx(dzD~$3R@BdH*0B$Y`0{{R3
> > >
> > > diff --git a/tests/data/acpi/q35/DSDT.dmar b/tests/data/acpi/q35/DSDT.dmar
> > > new file mode 100644
> > > index 0000000000000000000000000000000000000000..c1965f6051ef2af81dd8412abe169d87845bb033
> > > GIT binary patch
> > > literal 8289
> > > zcmb7JOKcm*8J^`!tL0K!Qk3OaY{E(UN|8{0Bx#EVC3pF<L~6yQ;si9nrRB7;og#}k
> > > z2J%1vSpgEqhoT9aphr4TfZp0uuQkw1d-JUUdg`H<T#F(`4`IK5h9l3A6cF>U+JE-@
> > > z{(rvNo&8obUf^~51;&j3l{egaP$<9Ry9N9V#u%N`U#F3{%(}Z?xz;n%v4qjRo#y8_
> > > zl+FB)z4BJg`29}!c^JO+QE2odcI6A_vn&1RgFE3BMxa|)BFmx^r?Sus%DwKMYx!=Y
> > > zX!hz2&n`W%Ota^Tv$)wSd2MF)wi+JGug~>10ylB@26MejtHV}uu#;V~oNn`<=e{|8
> > > z@)w_9daHE*=l}TS-5XW{fV22(;_tbL4&i&Dbt)V>pAN1W?-QM0TOBTaI^dT@n?qNk
> > > zkXr89qKQ(i?%(L{z38<|F7IQ;Z}~;HxQc$c?I3&FI{DEGV>S&A{r)r>js7A|nez^F
> > > znx;@$G3$P%BUKvEMyk5Ib-&YOHe(OIO|wMzwnOpK%axW_@Y`Omkbk}xbV@9umN25G
> > > z{=1>&ghTt2LC6MSdNkT+!-Y=<efGP)&HnY@<UZTC7DeB(*20JL)Rza}vIJx3&G(+A
> > > z-q3h=_l`G$QjZTY%AZD8{6>2-W`&mRtSvqlmq0>w_s*}CJ%GhMilg`Fl`M1ATCN!(
> > > z3z=cmjH~P_{+@}UT6gcM=El|mYjH_qnO5=)jZk;*?7H7smAMn*ej6Iru`)H|?fBbq
> > > z(>$}wGoN)gng^UD&=}1boQLs;ab})zIOpkh$35sxdVK$Q>WD?mFwZapL)6MX8lzp`
> > > z4LU~pzHOPfH59lQyR8BaUZJ}iR4!r`{LQv-<I)tk<znR`E|go%wvm1yXcV~R)>gCN
> > > zH@sI0U8B72uCe^nzFWB%>pn@*XcX-bB6`QT#wbVk`_#P8^3RmOnT4WU5go!YHq3h|
> > > z-wT=x!}amhc<{pC{~cU-xB1D+*Ue*pb(<08di~eo@X5h-Has@CX2mcA-sjJejmLJx
> > > z_Oo&0HXYc#mErQ>x-}Q&k};NH{V2TCXKcT3`VF_r@^%k@jcA7==Qpn!^sqSY*L))T
> > > z?T(*YySbZ7C-8K#_10R2iE{(zRhF}<-HIWo$smrP&T^Rq`hl4waN~$r04|7YoCl~3
> > > ziHZCi8{<r1#}P3lG{!g+P|ie1O!S6h<D4mb5NE`c(70d%%9#j>DXU;!2`tZ(;7kck
> > > z2&U{jLRDu{)0yN<2~7&7>^wqMXG+tV;!Fum={garI_ET<bDGXMT_-|Sr>W^QHJzre
> > > z6QQaTZy;r)=QW-4x=w_uPD|5iX*w-kCqh+cTGN@<bf$Hk2vwbU7b^GD)^yssPK2t?
> > > zjHWZA>CEUl5vn>DG@T2Y&IMg3LRIIYrgKr#xv1+zsOoeyosOo{(RCtJb!Ii4SxskF
> > > z*NITonbUOUG@UtJCqh-{lBRP>)48PUM5yY_YdZ6q&b+P@p{jFP)48naT-J3WRCONF
> > > zbRN-k9?^9oRCVG@0#BcO53OiAS9F~SRh>sQokumDM|GVDRh`E;vowAa9^=gN_+@uY
> > > zFx^KXF}*SNxW+uLF^}s^gevod#yp`hPv}g9D)XeqJgG5H>P&<x^9halgvNYAXChRY
> > > zr#Mr(%qh;4@Ay-KDPP<Oi7D^kX|3jIt>$UHCPGougn^b61FZ!Ol;&n?;2ed=28sY>
> > > zMG!|Ii^4z!j$4w!h$Z`Hps0Wz7$`z14F)Q((m)j`8K{6B7$`#YMjEKVjw7n68mNFC
> > > z7$`#Yh+|=(0y~bz8ab2<R6u2@>V$!cw44b8RiI>`2&F5Mfg+STVW0xbnJ`cVN(L&R
> > > zye1haLa7r5DzKah16818paRO7WS|J8P8g`bawZH^fs%m=C})y^B9!+N1}d<e2?JH2
> > > zWS|1dnPi{{rA`>Az;Y%GRDqI#3Mglifg+STVW0xbnJ`cVN(L&RoJj_XQ0jz%3M^;B
> > > zKouw%sDN@N87M-j69y`<oCyO}pk$x|%9&)K2&GOKsK9b23{-)VfeI*Rl7S+WI$@v!
> > > z%b74x1xf}gpqxnticso=feI{V!ax-$8K{7ACK)I~sS^e&u$&14RiI>`0?L_Wpa`W-
> > > z7^uK<CJa=8l7R{+XOe*;lsaLc0?U~&Pz6c`DxjQ628vMXgn<eyXTm@gC>f}LawZul
> > > zLa7r5DzKah16818paRO7WS|J8P8g`bawZH^fs%m=C})y^B9uB|paRR8Fi-_b1}dPO
> > > zNd}5g>V$y`EN8+%6(|{~fN~}oC_<?d28u{AP(-SMB2*0&p<<v469%d<$v_n*8K}a9
> > > zfhtTGsKO)zRhVR;3KIsZFkzqylMGa0l7T8r7^uR8fhtTgP=!ebsxV=oh~(Xcfg-{k
> > > z<AX^CiV(L!hQyR(3j;+Y#})>PNRBNTC_*{5WS|JKRCK%t3uQxl!2em@r+-NArRYzo
> > > zd;6!)#p%CPTGgQS4#RJ6mf*OXWjeTY@Jxoam(2>DSLslrL*2|TH8!ytFr0tS+TFn-
> > > z%ly8T&Yy2=y6t%Y+QsaGmHs%z=J`s{JM1pCSxFol(R(}ABBL{OqK&1O^*MYal;o0!
> > > zjpZ6z3^LK}AbZ4G`gnoO$Kh@a?{9`TF;*|~i+mkupSpnFl=9i0*9h4AbZ+hPmPJ~R
> > > zVnDcU9<TI*c3|Ay8TWz8Q~S7jd7?TNPrh^YvQoXwtC!I~wR$-}yL!31*Cg#?DGkeg
> > > zW9?S#G0MA2d6$=WC(65rly}GFy$SIa7PP*zdQU0u@$%k8dGC<&-ne{avV7t(%2$-~
> > > z6<)qFQND6W`O3I_b+UZ&G0In!@>O2GI#IrQNcrlxd~LFP>M_dKl=3xRzBW<5c1Zc!
> > > zxO{!G{M=)duPf#2ynKD4eEpE}b(Bxgt8B8oBg)H{2R<t>-NpK?-j+}CDUUxiugB>o
> > > zr?HjQ)8SiVDxGMXnQm%c=Ja&<0GUcB+GeJknrB!7rg<iX;j3gSooJhxZff4-^>p}D
> > > znMx<xW~Q5(2g`aoe7{Vk6KyloO+D8~^mO>BnMx<xW~Q5ZPFM7F_|ln5C))IM&WT6s
> > > z*?WsYvy814Y^&IDtob_|FNxiWx^?-{iof5k1oA1hFgf8(8Q0$`)Zch3di~a~3U9u4
> > > z^Nm|?ZohVubq&{FUmHKI8Oy2}U)f*ThK*HycoHq0e`Q;C_x2AcD6xX;S6YVKXa$Db
> > > zZoX__0lY|us=?x}+w`!=o+D)34Jzvez`atZfVJjEt6@fr8u8ShyUg{VL!y(JlIu5$
> > > z#nmEpLu?!+^I5l3eKj_;20QFSw^%G*%hyv_y)VsopS=8BLT+u4P!d4P?~~0a7O`-6
> > > zd@y-|Bt+ICmffeWtgr2d`DT)2JzgPWG8Hn+%%86waRawy9wNhZTa`<>*eGJ#k#Y44
> > > zFE_YqMC@v0gc0k1v2Oo%5E`FtqbZEGCrfg{la073!<Ek_TX9>qzZ}jF`ql_#zKmvF
> > > zA3ilTa&+IL?K{-RKD*UNukO7tyf6jhPX=z^wiS=21_l?wyR}Uli<N}fS)_zl*f!mA
> > > zXxr|t&K5V73;nruW%e*P=iQB<V;?fiv!9l!{209G+KjP@tk`5LL9b6XVwh+4uKU4@
> > > z^h{&^<A>>i=i1z-ryDb%S?XldmdUW%K;NPH1#Fsj(j<oMT)Un>fyq<zE4@nbEE~^w
> > > znn?6aIU5PO#3%lEP8FYL`JVv0%4i@Cb_B(amD1q5E#6ZN;WU@UOy!$Ge6RFk+WPaI
> > > z42xlj0KX9(uw(eperOve+6}yu@cRarAKC|T275@1{fBR|^6T_jJQ~qwG5ump+kQ2%
> > > zjrB)yh5bRhav%G$--;{uU%LAYwrt1QL>rA3?SWz7v>(N^N$DmqIAWKY?*NxDIO5ev
> > > z?aDh*Y+R;=gY$P{Ayr5je5dnb!ms;nF~qcu{3r<qX~z3?I@f*szHJ=EHsud5qkM3#
> > > zmrErK^d0BtdpR><#Vjo1A-X_UNQv{aN4KH7_iXi&D||1rS!r(JF*-|VZ04#xc9Kq#
> > > z-r`OxahY%JRTFd<yL;)NSQLB47?K|a#TP|@J7zGLaj@z!Y+B;vtUNi#Pg3-Vu>S)s
> > > Cro3tZ
> > >
> > > literal 0
> > > HcmV?d00001
> > >
> > > diff --git a/tests/data/acpi/q35/DSDT.ipmibt b/tests/data/acpi/q35/DSDT.ipmibt
> > > index 631741065860fd5036aa303904dabd1d2839f9c6..6ad2411d0ec95f204cfc64b430c537bce09c35bd 100644
> > > GIT binary patch
> > > delta 24
> > > gcmZ4ExW<voCD<iojRFG$quxZWD~xg*@1K<i0AMf(82|tP
> > >
> > > delta 24
> > > gcmZ4ExW<voCD<iojRFG$qwYkmD~$3R@1K<i0AMQ!82|tP
> > >
> > > diff --git a/tests/data/acpi/q35/DSDT.ivrs b/tests/data/acpi/q35/DSDT.ivrs
> > > index b0eafe90e5832935557ec5e6802c0147c88f379c..cad26e3f0c27a40a33101155a5282ed9bcb1d441 100644
> > > GIT binary patch
> > > delta 24
> > > gcmez5@X3M8CD<jTNP&TYan?kxD~xg*?@yKo0BrUMn*aa+
> > >
> > > delta 24
> > > gcmez5@X3M8CD<jTNP&TYappv>D~$3R?@yKo0BrFHn*aa+
> > >
> > > diff --git a/tests/data/acpi/q35/DSDT.memhp b/tests/data/acpi/q35/DSDT.memhp
> > > index 9bc11518fc57687ca789dc70793b48b29a0d74ed..4e9cb3dc6896bb79ccac0fe342a404549f6610e8 100644
> > > GIT binary patch
> > > delta 24
> > > gcmdnsy}_HyCD<iogDL|9<C}?GR~Y3s-oK~<0BV~F1poj5
> > >
> > > delta 24
> > > gcmdnsy}_HyCD<iogDL|9<LilBR~Y3t-oK~<0BV*A1poj5
> > >
> > > diff --git a/tests/data/acpi/q35/DSDT.mmio64 b/tests/data/acpi/q35/DSDT.mmio64
> > > index 713288a12ef2b70a20b4e8836c036ba4db3a57a8..eb5a1c7171c02d153487bfcecfb7019b7c1bf406 100644
> > > GIT binary patch
> > > delta 24
> > > gcmX@@dD@f9CD<k8v<d?Q<BEw~R~Y3s-hZPE0B$h}CjbBd
> > >
> > > delta 24
> > > gcmX@@dD@f9CD<k8v<d?Q<MN4IR~Y3t-hZPE0B$S^CjbBd
> > >
> > > diff --git a/tests/data/acpi/q35/DSDT.multi-bridge b/tests/data/acpi/q35/DSDT.multi-bridge
> > > index a24c713d22102a1a1583b5c902edffe1694e5cfe..45808eb03b78d07ebbe853f674abfed589d35e26 100644
> > > GIT binary patch
> > > delta 24
> > > fcmZp7Zg=K#33dr-S7cyd?3>7Sg;8$f{S^uTTRaEr
> > >
> > > delta 24
> > > fcmZp7Zg=K#33dr-S7cyd?48JUg;9Rv{S^uTTQ>*m
> > >
> > > diff --git a/tests/data/acpi/q35/DSDT.nohpet b/tests/data/acpi/q35/DSDT.nohpet
> > > index e8202e6ddfbe96071f32f1ec05758f650569943e..83d1aa00ac5686df479673fb0d7830f946e25dea 100644
> > > GIT binary patch
> > > delta 24
> > > gcmca?f7zbPCD<k8vOEI=<B^G6R~Y3s-v1&80B=4CMF0Q*
> > >
> > > delta 24
> > > gcmca?f7zbPCD<k8vOEI=<Kc;1R~Y3t-v1&80B<=7MF0Q*
> > >
> > > diff --git a/tests/data/acpi/q35/DSDT.nosmm b/tests/data/acpi/q35/DSDT.nosmm
> > > new file mode 100644
> > > index 0000000000000000000000000000000000000000..c1965f6051ef2af81dd8412abe169d87845bb033
> > > GIT binary patch
> > > literal 8289
> > > zcmb7JOKcm*8J^`!tL0K!Qk3OaY{E(UN|8{0Bx#EVC3pF<L~6yQ;si9nrRB7;og#}k
> > > z2J%1vSpgEqhoT9aphr4TfZp0uuQkw1d-JUUdg`H<T#F(`4`IK5h9l3A6cF>U+JE-@
> > > z{(rvNo&8obUf^~51;&j3l{egaP$<9Ry9N9V#u%N`U#F3{%(}Z?xz;n%v4qjRo#y8_
> > > zl+FB)z4BJg`29}!c^JO+QE2odcI6A_vn&1RgFE3BMxa|)BFmx^r?Sus%DwKMYx!=Y
> > > zX!hz2&n`W%Ota^Tv$)wSd2MF)wi+JGug~>10ylB@26MejtHV}uu#;V~oNn`<=e{|8
> > > z@)w_9daHE*=l}TS-5XW{fV22(;_tbL4&i&Dbt)V>pAN1W?-QM0TOBTaI^dT@n?qNk
> > > zkXr89qKQ(i?%(L{z38<|F7IQ;Z}~;HxQc$c?I3&FI{DEGV>S&A{r)r>js7A|nez^F
> > > znx;@$G3$P%BUKvEMyk5Ib-&YOHe(OIO|wMzwnOpK%axW_@Y`Omkbk}xbV@9umN25G
> > > z{=1>&ghTt2LC6MSdNkT+!-Y=<efGP)&HnY@<UZTC7DeB(*20JL)Rza}vIJx3&G(+A
> > > z-q3h=_l`G$QjZTY%AZD8{6>2-W`&mRtSvqlmq0>w_s*}CJ%GhMilg`Fl`M1ATCN!(
> > > z3z=cmjH~P_{+@}UT6gcM=El|mYjH_qnO5=)jZk;*?7H7smAMn*ej6Iru`)H|?fBbq
> > > z(>$}wGoN)gng^UD&=}1boQLs;ab})zIOpkh$35sxdVK$Q>WD?mFwZapL)6MX8lzp`
> > > z4LU~pzHOPfH59lQyR8BaUZJ}iR4!r`{LQv-<I)tk<znR`E|go%wvm1yXcV~R)>gCN
> > > zH@sI0U8B72uCe^nzFWB%>pn@*XcX-bB6`QT#wbVk`_#P8^3RmOnT4WU5go!YHq3h|
> > > z-wT=x!}amhc<{pC{~cU-xB1D+*Ue*pb(<08di~eo@X5h-Has@CX2mcA-sjJejmLJx
> > > z_Oo&0HXYc#mErQ>x-}Q&k};NH{V2TCXKcT3`VF_r@^%k@jcA7==Qpn!^sqSY*L))T
> > > z?T(*YySbZ7C-8K#_10R2iE{(zRhF}<-HIWo$smrP&T^Rq`hl4waN~$r04|7YoCl~3
> > > ziHZCi8{<r1#}P3lG{!g+P|ie1O!S6h<D4mb5NE`c(70d%%9#j>DXU;!2`tZ(;7kck
> > > z2&U{jLRDu{)0yN<2~7&7>^wqMXG+tV;!Fum={garI_ET<bDGXMT_-|Sr>W^QHJzre
> > > z6QQaTZy;r)=QW-4x=w_uPD|5iX*w-kCqh+cTGN@<bf$Hk2vwbU7b^GD)^yssPK2t?
> > > zjHWZA>CEUl5vn>DG@T2Y&IMg3LRIIYrgKr#xv1+zsOoeyosOo{(RCtJb!Ii4SxskF
> > > z*NITonbUOUG@UtJCqh-{lBRP>)48PUM5yY_YdZ6q&b+P@p{jFP)48naT-J3WRCONF
> > > zbRN-k9?^9oRCVG@0#BcO53OiAS9F~SRh>sQokumDM|GVDRh`E;vowAa9^=gN_+@uY
> > > zFx^KXF}*SNxW+uLF^}s^gevod#yp`hPv}g9D)XeqJgG5H>P&<x^9halgvNYAXChRY
> > > zr#Mr(%qh;4@Ay-KDPP<Oi7D^kX|3jIt>$UHCPGougn^b61FZ!Ol;&n?;2ed=28sY>
> > > zMG!|Ii^4z!j$4w!h$Z`Hps0Wz7$`z14F)Q((m)j`8K{6B7$`#YMjEKVjw7n68mNFC
> > > z7$`#Yh+|=(0y~bz8ab2<R6u2@>V$!cw44b8RiI>`2&F5Mfg+STVW0xbnJ`cVN(L&R
> > > zye1haLa7r5DzKah16818paRO7WS|J8P8g`bawZH^fs%m=C})y^B9!+N1}d<e2?JH2
> > > zWS|1dnPi{{rA`>Az;Y%GRDqI#3Mglifg+STVW0xbnJ`cVN(L&RoJj_XQ0jz%3M^;B
> > > zKouw%sDN@N87M-j69y`<oCyO}pk$x|%9&)K2&GOKsK9b23{-)VfeI*Rl7S+WI$@v!
> > > z%b74x1xf}gpqxnticso=feI{V!ax-$8K{7ACK)I~sS^e&u$&14RiI>`0?L_Wpa`W-
> > > z7^uK<CJa=8l7R{+XOe*;lsaLc0?U~&Pz6c`DxjQ628vMXgn<eyXTm@gC>f}LawZul
> > > zLa7r5DzKah16818paRO7WS|J8P8g`bawZH^fs%m=C})y^B9uB|paRR8Fi-_b1}dPO
> > > zNd}5g>V$y`EN8+%6(|{~fN~}oC_<?d28u{AP(-SMB2*0&p<<v469%d<$v_n*8K}a9
> > > zfhtTGsKO)zRhVR;3KIsZFkzqylMGa0l7T8r7^uR8fhtTgP=!ebsxV=oh~(Xcfg-{k
> > > z<AX^CiV(L!hQyR(3j;+Y#})>PNRBNTC_*{5WS|JKRCK%t3uQxl!2em@r+-NArRYzo
> > > zd;6!)#p%CPTGgQS4#RJ6mf*OXWjeTY@Jxoam(2>DSLslrL*2|TH8!ytFr0tS+TFn-
> > > z%ly8T&Yy2=y6t%Y+QsaGmHs%z=J`s{JM1pCSxFol(R(}ABBL{OqK&1O^*MYal;o0!
> > > zjpZ6z3^LK}AbZ4G`gnoO$Kh@a?{9`TF;*|~i+mkupSpnFl=9i0*9h4AbZ+hPmPJ~R
> > > zVnDcU9<TI*c3|Ay8TWz8Q~S7jd7?TNPrh^YvQoXwtC!I~wR$-}yL!31*Cg#?DGkeg
> > > zW9?S#G0MA2d6$=WC(65rly}GFy$SIa7PP*zdQU0u@$%k8dGC<&-ne{avV7t(%2$-~
> > > z6<)qFQND6W`O3I_b+UZ&G0In!@>O2GI#IrQNcrlxd~LFP>M_dKl=3xRzBW<5c1Zc!
> > > zxO{!G{M=)duPf#2ynKD4eEpE}b(Bxgt8B8oBg)H{2R<t>-NpK?-j+}CDUUxiugB>o
> > > zr?HjQ)8SiVDxGMXnQm%c=Ja&<0GUcB+GeJknrB!7rg<iX;j3gSooJhxZff4-^>p}D
> > > znMx<xW~Q5(2g`aoe7{Vk6KyloO+D8~^mO>BnMx<xW~Q5ZPFM7F_|ln5C))IM&WT6s
> > > z*?WsYvy814Y^&IDtob_|FNxiWx^?-{iof5k1oA1hFgf8(8Q0$`)Zch3di~a~3U9u4
> > > z^Nm|?ZohVubq&{FUmHKI8Oy2}U)f*ThK*HycoHq0e`Q;C_x2AcD6xX;S6YVKXa$Db
> > > zZoX__0lY|us=?x}+w`!=o+D)34Jzvez`atZfVJjEt6@fr8u8ShyUg{VL!y(JlIu5$
> > > z#nmEpLu?!+^I5l3eKj_;20QFSw^%G*%hyv_y)VsopS=8BLT+u4P!d4P?~~0a7O`-6
> > > zd@y-|Bt+ICmffeWtgr2d`DT)2JzgPWG8Hn+%%86waRawy9wNhZTa`<>*eGJ#k#Y44
> > > zFE_YqMC@v0gc0k1v2Oo%5E`FtqbZEGCrfg{la073!<Ek_TX9>qzZ}jF`ql_#zKmvF
> > > zA3ilTa&+IL?K{-RKD*UNukO7tyf6jhPX=z^wiS=21_l?wyR}Uli<N}fS)_zl*f!mA
> > > zXxr|t&K5V73;nruW%e*P=iQB<V;?fiv!9l!{209G+KjP@tk`5LL9b6XVwh+4uKU4@
> > > z^h{&^<A>>i=i1z-ryDb%S?XldmdUW%K;NPH1#Fsj(j<oMT)Un>fyq<zE4@nbEE~^w
> > > znn?6aIU5PO#3%lEP8FYL`JVv0%4i@Cb_B(amD1q5E#6ZN;WU@UOy!$Ge6RFk+WPaI
> > > z42xlj0KX9(uw(eperOve+6}yu@cRarAKC|T275@1{fBR|^6T_jJQ~qwG5ump+kQ2%
> > > zjrB)yh5bRhav%G$--;{uU%LAYwrt1QL>rA3?SWz7v>(N^N$DmqIAWKY?*NxDIO5ev
> > > z?aDh*Y+R;=gY$P{Ayr5je5dnb!ms;nF~qcu{3r<qX~z3?I@f*szHJ=EHsud5qkM3#
> > > zmrErK^d0BtdpR><#Vjo1A-X_UNQv{aN4KH7_iXi&D||1rS!r(JF*-|VZ04#xc9Kq#
> > > z-r`OxahY%JRTFd<yL;)NSQLB47?K|a#TP|@J7zGLaj@z!Y+B;vtUNi#Pg3-Vu>S)s
> > > Cro3tZ
> > >
> > > literal 0
> > > HcmV?d00001
> > >
> > > diff --git a/tests/data/acpi/q35/DSDT.numamem b/tests/data/acpi/q35/DSDT.numamem
> > > index 151e7cf42953f3f5fe61ff0140ab7b976fe9e5b8..050aaa237b466b0bda8cca5cfaa06f84661d622e 100644
> > > GIT binary patch
> > > delta 24
> > > gcmaFv@Z5pRCD<h-U4emtamhrkD~xg*?{~-p0BWTOc>n+a
> > >
> > > delta 24
> > > gcmaFv@Z5pRCD<h-U4emtaq&d1D~$3R?{~-p0BWEJc>n+a
> > >
> > > diff --git a/tests/data/acpi/q35/DSDT.smm-compat b/tests/data/acpi/q35/DSDT.smm-compat
> > > new file mode 100644
> > > index 0000000000000000000000000000000000000000..c1965f6051ef2af81dd8412abe169d87845bb033
> > > GIT binary patch
> > > literal 8289
> > > zcmb7JOKcm*8J^`!tL0K!Qk3OaY{E(UN|8{0Bx#EVC3pF<L~6yQ;si9nrRB7;og#}k
> > > z2J%1vSpgEqhoT9aphr4TfZp0uuQkw1d-JUUdg`H<T#F(`4`IK5h9l3A6cF>U+JE-@
> > > z{(rvNo&8obUf^~51;&j3l{egaP$<9Ry9N9V#u%N`U#F3{%(}Z?xz;n%v4qjRo#y8_
> > > zl+FB)z4BJg`29}!c^JO+QE2odcI6A_vn&1RgFE3BMxa|)BFmx^r?Sus%DwKMYx!=Y
> > > zX!hz2&n`W%Ota^Tv$)wSd2MF)wi+JGug~>10ylB@26MejtHV}uu#;V~oNn`<=e{|8
> > > z@)w_9daHE*=l}TS-5XW{fV22(;_tbL4&i&Dbt)V>pAN1W?-QM0TOBTaI^dT@n?qNk
> > > zkXr89qKQ(i?%(L{z38<|F7IQ;Z}~;HxQc$c?I3&FI{DEGV>S&A{r)r>js7A|nez^F
> > > znx;@$G3$P%BUKvEMyk5Ib-&YOHe(OIO|wMzwnOpK%axW_@Y`Omkbk}xbV@9umN25G
> > > z{=1>&ghTt2LC6MSdNkT+!-Y=<efGP)&HnY@<UZTC7DeB(*20JL)Rza}vIJx3&G(+A
> > > z-q3h=_l`G$QjZTY%AZD8{6>2-W`&mRtSvqlmq0>w_s*}CJ%GhMilg`Fl`M1ATCN!(
> > > z3z=cmjH~P_{+@}UT6gcM=El|mYjH_qnO5=)jZk;*?7H7smAMn*ej6Iru`)H|?fBbq
> > > z(>$}wGoN)gng^UD&=}1boQLs;ab})zIOpkh$35sxdVK$Q>WD?mFwZapL)6MX8lzp`
> > > z4LU~pzHOPfH59lQyR8BaUZJ}iR4!r`{LQv-<I)tk<znR`E|go%wvm1yXcV~R)>gCN
> > > zH@sI0U8B72uCe^nzFWB%>pn@*XcX-bB6`QT#wbVk`_#P8^3RmOnT4WU5go!YHq3h|
> > > z-wT=x!}amhc<{pC{~cU-xB1D+*Ue*pb(<08di~eo@X5h-Has@CX2mcA-sjJejmLJx
> > > z_Oo&0HXYc#mErQ>x-}Q&k};NH{V2TCXKcT3`VF_r@^%k@jcA7==Qpn!^sqSY*L))T
> > > z?T(*YySbZ7C-8K#_10R2iE{(zRhF}<-HIWo$smrP&T^Rq`hl4waN~$r04|7YoCl~3
> > > ziHZCi8{<r1#}P3lG{!g+P|ie1O!S6h<D4mb5NE`c(70d%%9#j>DXU;!2`tZ(;7kck
> > > z2&U{jLRDu{)0yN<2~7&7>^wqMXG+tV;!Fum={garI_ET<bDGXMT_-|Sr>W^QHJzre
> > > z6QQaTZy;r)=QW-4x=w_uPD|5iX*w-kCqh+cTGN@<bf$Hk2vwbU7b^GD)^yssPK2t?
> > > zjHWZA>CEUl5vn>DG@T2Y&IMg3LRIIYrgKr#xv1+zsOoeyosOo{(RCtJb!Ii4SxskF
> > > z*NITonbUOUG@UtJCqh-{lBRP>)48PUM5yY_YdZ6q&b+P@p{jFP)48naT-J3WRCONF
> > > zbRN-k9?^9oRCVG@0#BcO53OiAS9F~SRh>sQokumDM|GVDRh`E;vowAa9^=gN_+@uY
> > > zFx^KXF}*SNxW+uLF^}s^gevod#yp`hPv}g9D)XeqJgG5H>P&<x^9halgvNYAXChRY
> > > zr#Mr(%qh;4@Ay-KDPP<Oi7D^kX|3jIt>$UHCPGougn^b61FZ!Ol;&n?;2ed=28sY>
> > > zMG!|Ii^4z!j$4w!h$Z`Hps0Wz7$`z14F)Q((m)j`8K{6B7$`#YMjEKVjw7n68mNFC
> > > z7$`#Yh+|=(0y~bz8ab2<R6u2@>V$!cw44b8RiI>`2&F5Mfg+STVW0xbnJ`cVN(L&R
> > > zye1haLa7r5DzKah16818paRO7WS|J8P8g`bawZH^fs%m=C})y^B9!+N1}d<e2?JH2
> > > zWS|1dnPi{{rA`>Az;Y%GRDqI#3Mglifg+STVW0xbnJ`cVN(L&RoJj_XQ0jz%3M^;B
> > > zKouw%sDN@N87M-j69y`<oCyO}pk$x|%9&)K2&GOKsK9b23{-)VfeI*Rl7S+WI$@v!
> > > z%b74x1xf}gpqxnticso=feI{V!ax-$8K{7ACK)I~sS^e&u$&14RiI>`0?L_Wpa`W-
> > > z7^uK<CJa=8l7R{+XOe*;lsaLc0?U~&Pz6c`DxjQ628vMXgn<eyXTm@gC>f}LawZul
> > > zLa7r5DzKah16818paRO7WS|J8P8g`bawZH^fs%m=C})y^B9uB|paRR8Fi-_b1}dPO
> > > zNd}5g>V$y`EN8+%6(|{~fN~}oC_<?d28u{AP(-SMB2*0&p<<v469%d<$v_n*8K}a9
> > > zfhtTGsKO)zRhVR;3KIsZFkzqylMGa0l7T8r7^uR8fhtTgP=!ebsxV=oh~(Xcfg-{k
> > > z<AX^CiV(L!hQyR(3j;+Y#})>PNRBNTC_*{5WS|JKRCK%t3uQxl!2em@r+-NArRYzo
> > > zd;6!)#p%CPTGgQS4#RJ6mf*OXWjeTY@Jxoam(2>DSLslrL*2|TH8!ytFr0tS+TFn-
> > > z%ly8T&Yy2=y6t%Y+QsaGmHs%z=J`s{JM1pCSxFol(R(}ABBL{OqK&1O^*MYal;o0!
> > > zjpZ6z3^LK}AbZ4G`gnoO$Kh@a?{9`TF;*|~i+mkupSpnFl=9i0*9h4AbZ+hPmPJ~R
> > > zVnDcU9<TI*c3|Ay8TWz8Q~S7jd7?TNPrh^YvQoXwtC!I~wR$-}yL!31*Cg#?DGkeg
> > > zW9?S#G0MA2d6$=WC(65rly}GFy$SIa7PP*zdQU0u@$%k8dGC<&-ne{avV7t(%2$-~
> > > z6<)qFQND6W`O3I_b+UZ&G0In!@>O2GI#IrQNcrlxd~LFP>M_dKl=3xRzBW<5c1Zc!
> > > zxO{!G{M=)duPf#2ynKD4eEpE}b(Bxgt8B8oBg)H{2R<t>-NpK?-j+}CDUUxiugB>o
> > > zr?HjQ)8SiVDxGMXnQm%c=Ja&<0GUcB+GeJknrB!7rg<iX;j3gSooJhxZff4-^>p}D
> > > znMx<xW~Q5(2g`aoe7{Vk6KyloO+D8~^mO>BnMx<xW~Q5ZPFM7F_|ln5C))IM&WT6s
> > > z*?WsYvy814Y^&IDtob_|FNxiWx^?-{iof5k1oA1hFgf8(8Q0$`)Zch3di~a~3U9u4
> > > z^Nm|?ZohVubq&{FUmHKI8Oy2}U)f*ThK*HycoHq0e`Q;C_x2AcD6xX;S6YVKXa$Db
> > > zZoX__0lY|us=?x}+w`!=o+D)34Jzvez`atZfVJjEt6@fr8u8ShyUg{VL!y(JlIu5$
> > > z#nmEpLu?!+^I5l3eKj_;20QFSw^%G*%hyv_y)VsopS=8BLT+u4P!d4P?~~0a7O`-6
> > > zd@y-|Bt+ICmffeWtgr2d`DT)2JzgPWG8Hn+%%86waRawy9wNhZTa`<>*eGJ#k#Y44
> > > zFE_YqMC@v0gc0k1v2Oo%5E`FtqbZEGCrfg{la073!<Ek_TX9>qzZ}jF`ql_#zKmvF
> > > zA3ilTa&+IL?K{-RKD*UNukO7tyf6jhPX=z^wiS=21_l?wyR}Uli<N}fS)_zl*f!mA
> > > zXxr|t&K5V73;nruW%e*P=iQB<V;?fiv!9l!{209G+KjP@tk`5LL9b6XVwh+4uKU4@
> > > z^h{&^<A>>i=i1z-ryDb%S?XldmdUW%K;NPH1#Fsj(j<oMT)Un>fyq<zE4@nbEE~^w
> > > znn?6aIU5PO#3%lEP8FYL`JVv0%4i@Cb_B(amD1q5E#6ZN;WU@UOy!$Ge6RFk+WPaI
> > > z42xlj0KX9(uw(eperOve+6}yu@cRarAKC|T275@1{fBR|^6T_jJQ~qwG5ump+kQ2%
> > > zjrB)yh5bRhav%G$--;{uU%LAYwrt1QL>rA3?SWz7v>(N^N$DmqIAWKY?*NxDIO5ev
> > > z?aDh*Y+R;=gY$P{Ayr5je5dnb!ms;nF~qcu{3r<qX~z3?I@f*szHJ=EHsud5qkM3#
> > > zmrErK^d0BtdpR><#Vjo1A-X_UNQv{aN4KH7_iXi&D||1rS!r(JF*-|VZ04#xc9Kq#
> > > z-r`OxahY%JRTFd<yL;)NSQLB47?K|a#TP|@J7zGLaj@z!Y+B;vtUNi#Pg3-Vu>S)s
> > > Cro3tZ
> > >
> > > literal 0
> > > HcmV?d00001
> > >
> > > diff --git a/tests/data/acpi/q35/DSDT.smm-compat-nosmm b/tests/data/acpi/q35/DSDT.smm-compat-nosmm
> > > new file mode 100644
> > > index 0000000000000000000000000000000000000000..c1965f6051ef2af81dd8412abe169d87845bb033
> > > GIT binary patch
> > > literal 8289
> > > zcmb7JOKcm*8J^`!tL0K!Qk3OaY{E(UN|8{0Bx#EVC3pF<L~6yQ;si9nrRB7;og#}k
> > > z2J%1vSpgEqhoT9aphr4TfZp0uuQkw1d-JUUdg`H<T#F(`4`IK5h9l3A6cF>U+JE-@
> > > z{(rvNo&8obUf^~51;&j3l{egaP$<9Ry9N9V#u%N`U#F3{%(}Z?xz;n%v4qjRo#y8_
> > > zl+FB)z4BJg`29}!c^JO+QE2odcI6A_vn&1RgFE3BMxa|)BFmx^r?Sus%DwKMYx!=Y
> > > zX!hz2&n`W%Ota^Tv$)wSd2MF)wi+JGug~>10ylB@26MejtHV}uu#;V~oNn`<=e{|8
> > > z@)w_9daHE*=l}TS-5XW{fV22(;_tbL4&i&Dbt)V>pAN1W?-QM0TOBTaI^dT@n?qNk
> > > zkXr89qKQ(i?%(L{z38<|F7IQ;Z}~;HxQc$c?I3&FI{DEGV>S&A{r)r>js7A|nez^F
> > > znx;@$G3$P%BUKvEMyk5Ib-&YOHe(OIO|wMzwnOpK%axW_@Y`Omkbk}xbV@9umN25G
> > > z{=1>&ghTt2LC6MSdNkT+!-Y=<efGP)&HnY@<UZTC7DeB(*20JL)Rza}vIJx3&G(+A
> > > z-q3h=_l`G$QjZTY%AZD8{6>2-W`&mRtSvqlmq0>w_s*}CJ%GhMilg`Fl`M1ATCN!(
> > > z3z=cmjH~P_{+@}UT6gcM=El|mYjH_qnO5=)jZk;*?7H7smAMn*ej6Iru`)H|?fBbq
> > > z(>$}wGoN)gng^UD&=}1boQLs;ab})zIOpkh$35sxdVK$Q>WD?mFwZapL)6MX8lzp`
> > > z4LU~pzHOPfH59lQyR8BaUZJ}iR4!r`{LQv-<I)tk<znR`E|go%wvm1yXcV~R)>gCN
> > > zH@sI0U8B72uCe^nzFWB%>pn@*XcX-bB6`QT#wbVk`_#P8^3RmOnT4WU5go!YHq3h|
> > > z-wT=x!}amhc<{pC{~cU-xB1D+*Ue*pb(<08di~eo@X5h-Has@CX2mcA-sjJejmLJx
> > > z_Oo&0HXYc#mErQ>x-}Q&k};NH{V2TCXKcT3`VF_r@^%k@jcA7==Qpn!^sqSY*L))T
> > > z?T(*YySbZ7C-8K#_10R2iE{(zRhF}<-HIWo$smrP&T^Rq`hl4waN~$r04|7YoCl~3
> > > ziHZCi8{<r1#}P3lG{!g+P|ie1O!S6h<D4mb5NE`c(70d%%9#j>DXU;!2`tZ(;7kck
> > > z2&U{jLRDu{)0yN<2~7&7>^wqMXG+tV;!Fum={garI_ET<bDGXMT_-|Sr>W^QHJzre
> > > z6QQaTZy;r)=QW-4x=w_uPD|5iX*w-kCqh+cTGN@<bf$Hk2vwbU7b^GD)^yssPK2t?
> > > zjHWZA>CEUl5vn>DG@T2Y&IMg3LRIIYrgKr#xv1+zsOoeyosOo{(RCtJb!Ii4SxskF
> > > z*NITonbUOUG@UtJCqh-{lBRP>)48PUM5yY_YdZ6q&b+P@p{jFP)48naT-J3WRCONF
> > > zbRN-k9?^9oRCVG@0#BcO53OiAS9F~SRh>sQokumDM|GVDRh`E;vowAa9^=gN_+@uY
> > > zFx^KXF}*SNxW+uLF^}s^gevod#yp`hPv}g9D)XeqJgG5H>P&<x^9halgvNYAXChRY
> > > zr#Mr(%qh;4@Ay-KDPP<Oi7D^kX|3jIt>$UHCPGougn^b61FZ!Ol;&n?;2ed=28sY>
> > > zMG!|Ii^4z!j$4w!h$Z`Hps0Wz7$`z14F)Q((m)j`8K{6B7$`#YMjEKVjw7n68mNFC
> > > z7$`#Yh+|=(0y~bz8ab2<R6u2@>V$!cw44b8RiI>`2&F5Mfg+STVW0xbnJ`cVN(L&R
> > > zye1haLa7r5DzKah16818paRO7WS|J8P8g`bawZH^fs%m=C})y^B9!+N1}d<e2?JH2
> > > zWS|1dnPi{{rA`>Az;Y%GRDqI#3Mglifg+STVW0xbnJ`cVN(L&RoJj_XQ0jz%3M^;B
> > > zKouw%sDN@N87M-j69y`<oCyO}pk$x|%9&)K2&GOKsK9b23{-)VfeI*Rl7S+WI$@v!
> > > z%b74x1xf}gpqxnticso=feI{V!ax-$8K{7ACK)I~sS^e&u$&14RiI>`0?L_Wpa`W-
> > > z7^uK<CJa=8l7R{+XOe*;lsaLc0?U~&Pz6c`DxjQ628vMXgn<eyXTm@gC>f}LawZul
> > > zLa7r5DzKah16818paRO7WS|J8P8g`bawZH^fs%m=C})y^B9uB|paRR8Fi-_b1}dPO
> > > zNd}5g>V$y`EN8+%6(|{~fN~}oC_<?d28u{AP(-SMB2*0&p<<v469%d<$v_n*8K}a9
> > > zfhtTGsKO)zRhVR;3KIsZFkzqylMGa0l7T8r7^uR8fhtTgP=!ebsxV=oh~(Xcfg-{k
> > > z<AX^CiV(L!hQyR(3j;+Y#})>PNRBNTC_*{5WS|JKRCK%t3uQxl!2em@r+-NArRYzo
> > > zd;6!)#p%CPTGgQS4#RJ6mf*OXWjeTY@Jxoam(2>DSLslrL*2|TH8!ytFr0tS+TFn-
> > > z%ly8T&Yy2=y6t%Y+QsaGmHs%z=J`s{JM1pCSxFol(R(}ABBL{OqK&1O^*MYal;o0!
> > > zjpZ6z3^LK}AbZ4G`gnoO$Kh@a?{9`TF;*|~i+mkupSpnFl=9i0*9h4AbZ+hPmPJ~R
> > > zVnDcU9<TI*c3|Ay8TWz8Q~S7jd7?TNPrh^YvQoXwtC!I~wR$-}yL!31*Cg#?DGkeg
> > > zW9?S#G0MA2d6$=WC(65rly}GFy$SIa7PP*zdQU0u@$%k8dGC<&-ne{avV7t(%2$-~
> > > z6<)qFQND6W`O3I_b+UZ&G0In!@>O2GI#IrQNcrlxd~LFP>M_dKl=3xRzBW<5c1Zc!
> > > zxO{!G{M=)duPf#2ynKD4eEpE}b(Bxgt8B8oBg)H{2R<t>-NpK?-j+}CDUUxiugB>o
> > > zr?HjQ)8SiVDxGMXnQm%c=Ja&<0GUcB+GeJknrB!7rg<iX;j3gSooJhxZff4-^>p}D
> > > znMx<xW~Q5(2g`aoe7{Vk6KyloO+D8~^mO>BnMx<xW~Q5ZPFM7F_|ln5C))IM&WT6s
> > > z*?WsYvy814Y^&IDtob_|FNxiWx^?-{iof5k1oA1hFgf8(8Q0$`)Zch3di~a~3U9u4
> > > z^Nm|?ZohVubq&{FUmHKI8Oy2}U)f*ThK*HycoHq0e`Q;C_x2AcD6xX;S6YVKXa$Db
> > > zZoX__0lY|us=?x}+w`!=o+D)34Jzvez`atZfVJjEt6@fr8u8ShyUg{VL!y(JlIu5$
> > > z#nmEpLu?!+^I5l3eKj_;20QFSw^%G*%hyv_y)VsopS=8BLT+u4P!d4P?~~0a7O`-6
> > > zd@y-|Bt+ICmffeWtgr2d`DT)2JzgPWG8Hn+%%86waRawy9wNhZTa`<>*eGJ#k#Y44
> > > zFE_YqMC@v0gc0k1v2Oo%5E`FtqbZEGCrfg{la073!<Ek_TX9>qzZ}jF`ql_#zKmvF
> > > zA3ilTa&+IL?K{-RKD*UNukO7tyf6jhPX=z^wiS=21_l?wyR}Uli<N}fS)_zl*f!mA
> > > zXxr|t&K5V73;nruW%e*P=iQB<V;?fiv!9l!{209G+KjP@tk`5LL9b6XVwh+4uKU4@
> > > z^h{&^<A>>i=i1z-ryDb%S?XldmdUW%K;NPH1#Fsj(j<oMT)Un>fyq<zE4@nbEE~^w
> > > znn?6aIU5PO#3%lEP8FYL`JVv0%4i@Cb_B(amD1q5E#6ZN;WU@UOy!$Ge6RFk+WPaI
> > > z42xlj0KX9(uw(eperOve+6}yu@cRarAKC|T275@1{fBR|^6T_jJQ~qwG5ump+kQ2%
> > > zjrB)yh5bRhav%G$--;{uU%LAYwrt1QL>rA3?SWz7v>(N^N$DmqIAWKY?*NxDIO5ev
> > > z?aDh*Y+R;=gY$P{Ayr5je5dnb!ms;nF~qcu{3r<qX~z3?I@f*szHJ=EHsud5qkM3#
> > > zmrErK^d0BtdpR><#Vjo1A-X_UNQv{aN4KH7_iXi&D||1rS!r(JF*-|VZ04#xc9Kq#
> > > z-r`OxahY%JRTFd<yL;)NSQLB47?K|a#TP|@J7zGLaj@z!Y+B;vtUNi#Pg3-Vu>S)s
> > > Cro3tZ
> > >
> > > literal 0
> > > HcmV?d00001
> > >
> > > diff --git a/tests/data/acpi/q35/DSDT.tis.tpm12 b/tests/data/acpi/q35/DSDT.tis.tpm12
> > > index c96b5277a14ae98174408d690d6e0246bd932623..0ebdf6fbd77967f1ab5d5337b7b1fed314cfaca8 100644
> > > GIT binary patch
> > > delta 24
> > > gcmdnzy3du%CD<iopArKDqxwXyD~xg*@84Gh0A(f!W&i*H
> > >
> > > delta 24
> > > gcmdnzy3du%CD<iopArKDquNBSD~$3R@84Gh0A(QvW&i*H
> > >
> > > diff --git a/tests/data/acpi/q35/DSDT.tis.tpm2 b/tests/data/acpi/q35/DSDT.tis.tpm2
> > > index c92d4d29c79352a60974ea9f665d0b9a410a4bac..dcbb7f0af377425db53130e8ba1c62c09c22e006 100644
> > > GIT binary patch
> > > delta 24
> > > gcmdnzy3du%CD<iopArKD<D-dOR~Y3s-oLL10Bm##ApigX
> > >
> > > delta 24
> > > gcmdnzy3du%CD<iopArKD<HLzuR~Y3t-oLL10BmmwApigX
> > >
> > > diff --git a/tests/data/acpi/q35/DSDT.xapic b/tests/data/acpi/q35/DSDT.xapic
> > > index 119fc90f1f8a7b6934df6fd95609446e627ce15d..17552ce363ae81985f69f9ae85837a1540b79ae0 100644
> > > GIT binary patch
> > > delta 26
> > > icmX>yjp@iVCN7s?mk^h31_s6r6S=N1%5A)#+64f6_X&Rh
> > >
> > > delta 26
> > > icmX>yjp@iVCN7s?mk^h31_s9U6S=N1%5S`%+64f6@(F(c
> > >
> > > --
> > > 2.27.0
> >
^ permalink raw reply [flat|nested] 24+ messages in thread
* Re: [PATCH for 6.2 v2 5/5] bios-tables-test: Update golden binaries
2021-11-11 9:44 ` Ani Sinha
@ 2021-11-12 8:56 ` Ani Sinha
0 siblings, 0 replies; 24+ messages in thread
From: Ani Sinha @ 2021-11-12 8:56 UTC (permalink / raw)
To: Ani Sinha
Cc: mapfelba, Michael S. Tsirkin, jusual, qemu-devel, kraxel, Igor Mammedov
On Thu, 11 Nov 2021, Ani Sinha wrote:
>
>
> On Thu, 11 Nov 2021, Ani Sinha wrote:
>
> >
> >
> > On Thu, 11 Nov 2021, Michael S. Tsirkin wrote:
> >
> > > On Wed, Nov 10, 2021 at 04:11:40PM -0500, Igor Mammedov wrote:
> > > > From: Julia Suvorova <jusual@redhat.com>
> > > >
> > > > The changes are the result of
> > > > 'hw/i386/acpi-build: Deny control on PCIe Native Hot-Plug in _OSC'
> > > > and listed here:
> > > >
> > > > Method (_OSC, 4, NotSerialized) // _OSC: Operating System Capabilities
> > > > {
> > > > CreateDWordField (Arg3, Zero, CDW1)
> > > > If ((Arg0 == ToUUID ("33db4d5b-1ff7-401c-9657-7441c03dd766") /* PCI Host Bridge Device */))
> > > > {
> > > > CreateDWordField (Arg3, 0x04, CDW2)
> > > > CreateDWordField (Arg3, 0x08, CDW3)
> > > > Local0 = CDW3 /* \_SB_.PCI0._OSC.CDW3 */
> > > > - Local0 &= 0x1F
> > > > + Local0 &= 0x1E
> > > >
> > > > Signed-off-by: Julia Suvorova <jusual@redhat.com>
> > > > Signed-off-by: Igor Mammedov <imammedo@redhat.com>
> > > > ---
> > > > tests/qtest/bios-tables-test-allowed-diff.h | 16 ----------------
> > > > tests/data/acpi/q35/DSDT | Bin 8289 -> 8289 bytes
> > > > tests/data/acpi/q35/DSDT.acpihmat | Bin 9614 -> 9614 bytes
> > > > tests/data/acpi/q35/DSDT.bridge | Bin 11003 -> 11003 bytes
> > > > tests/data/acpi/q35/DSDT.cphp | Bin 8753 -> 8753 bytes
> > > > tests/data/acpi/q35/DSDT.dimmpxm | Bin 9943 -> 9943 bytes
> > > > tests/data/acpi/q35/DSDT.dmar | Bin 0 -> 8289 bytes
> > > > tests/data/acpi/q35/DSDT.ipmibt | Bin 8364 -> 8364 bytes
> > > > tests/data/acpi/q35/DSDT.ivrs | Bin 8306 -> 8306 bytes
> > > > tests/data/acpi/q35/DSDT.memhp | Bin 9648 -> 9648 bytes
> > > > tests/data/acpi/q35/DSDT.mmio64 | Bin 9419 -> 9419 bytes
> > > > tests/data/acpi/q35/DSDT.multi-bridge | Bin 8583 -> 8583 bytes
> > > > tests/data/acpi/q35/DSDT.nohpet | Bin 8147 -> 8147 bytes
> > > > tests/data/acpi/q35/DSDT.nosmm | Bin 0 -> 8289 bytes
> > > > tests/data/acpi/q35/DSDT.numamem | Bin 8295 -> 8295 bytes
> > > > tests/data/acpi/q35/DSDT.smm-compat | Bin 0 -> 8289 bytes
> > > > tests/data/acpi/q35/DSDT.smm-compat-nosmm | Bin 0 -> 8289 bytes
> > > > tests/data/acpi/q35/DSDT.tis.tpm12 | Bin 8894 -> 8894 bytes
> > > > tests/data/acpi/q35/DSDT.tis.tpm2 | Bin 8894 -> 8894 bytes
> > > > tests/data/acpi/q35/DSDT.xapic | Bin 35652 -> 35652 bytes
> > >
> > > Why do we have all the new files? What is going on here?
> >
> > Good catch. I saw those files even in my workspace and failed to notice
> > that they were being newly created in this patch and they did not exist
> > previously:
> > https://git.qemu.org/?p=qemu.git;a=tree;f=tests/data/acpi/q35;h=e9d1edd2671997a3e7fe278018313bcbfcfb0850;hb=HEAD
> >
> >
> > >
> > > > 20 files changed, 16 deletions(-)
> > > > create mode 100644 tests/data/acpi/q35/DSDT.dmar
> >
> > The corresponding change that adds the test is :
> >
> > commit 0ff92b6d99011c8de57321503c0eb655c461a217
> > Author: Igor Mammedov <imammedo@redhat.com>
> > Date: Thu Sep 2 07:35:43 2021 -0400
> >
> > tests: acpi: add testcase for intel_iommu (DMAR table)
> >
> > Igor has updated the DMAR table blob here:
> >
> > commit 44d3bdd8a6f1ae2a5ca417251736a033900d4c08
> > Author: Igor Mammedov <imammedo@redhat.com>
> > Date: Thu Sep 2 07:35:44 2021 -0400
> >
> > tests: acpi: add expected blob for DMAR table
> >
> > but maybe the test also introduced changes in DSDT table as well?
> > Needs more investigation.
>
> Actually I am pretty sure that no changes in DSDT was introduced with the
> above test. If it did, the tests would be broken because Igor did not
> update the DSDT table blob. So we should not commit the
> tests/data/acpi/q35/DSDT.dmar
>
> table blob here.
>
>
> >
> > > > create mode 100644 tests/data/acpi/q35/DSDT.nosmm
> > > > create mode 100644 tests/data/acpi/q35/DSDT.smm-compat
> > > > create mode 100644 tests/data/acpi/q35/DSDT.smm-compat-nosmm
> >
> > The corresponding tests for these files were added in this commit:
> >
> > commit 0dabb2e802437c2e578dc72bd0bdf3380a25ec96
> > Author: Isaku Yamahata <isaku.yamahata@intel.com>
> > Date: Wed Feb 17 21:51:14 2021 -0800
> >
> > BUT it seems that by mistake the table blobs were not added when the
> > following commit was made:
> >
> > commit 7b630d937a6c73fb145746fb31e0fb4b08f0cf0e
> > Author: Isaku Yamahata <isaku.yamahata@intel.com>
> > Date: Wed Feb 17 21:51:18 2021 -0800
> >
> > qtest/acpi/bios-tables-test: update acpi tables
> >
> > Sadly, the above commit does update tests/data/acpi/q35/DSDT which I
> > believe includes the changes for the above tests. The commit message
> > does not add the ASL diff which the tests introduces.
>
> We need to check this one. If the above commit did indeed introduce
> changes in DSDT blob which it should have done tgrough those additional
> table blob files.
This commit introduced the changes that affected the tables:
commit e3fb55f06501b7cffd1df2223eeadaa60e25565d
Author: Isaku Yamahata <isaku.yamahata@intel.com>
Date: Wed Feb 17 21:51:15 2021 -0800
hw/i386: declare ACPI mother board resource for MMCONFIG region
In particular, the function build_q35_dram_controller().
From what I see, the ASL diff introduced by the updated table blobs is the
following:
--- /home/anisinha/temp/DSDT.orig 2021-11-12 09:57:15.410455265 +0530
+++ tests/data/acpi/q35/DSDT.dsl 2021-11-12 09:58:19.566901164 +0530
@@ -5,13 +5,13 @@
*
* Disassembling to symbolic ASL+ operators
*
- * Disassembly of tests/data/acpi/q35/DSDT, Fri Nov 12 09:57:15 2021
+ * Disassembly of tests/data/acpi/q35/DSDT, Fri Nov 12 09:58:19 2021
*
* Original Table Header:
* Signature "DSDT"
- * Length 0x00001E79 (7801)
+ * Length 0x00001EB3 (7859)
* Revision 0x01 **** 32-bit table (V1), no 64-bit math support
- * Checksum 0xA5
+ * Checksum 0xEE
* OEM ID "BOCHS "
* OEM Table ID "BXPC "
* OEM Revision 0x00000001 (1)
@@ -81,6 +81,21 @@
Return (Arg3)
}
}
+
+ Device (DRAC)
+ {
+ Name (_HID, "PNP0C01" /* System Board */) // _HID: Hardware ID
+ Name (_CRS, ResourceTemplate () // _CRS: Current Resource Settings
+ {
+ DWordMemory (ResourceProducer, PosDecode, MinFixed, MaxFixed, NonCacheable, ReadWrite,
+ 0x00000000, // Granularity
+ 0xB0000000, // Range Minimum
+ 0xBFFFFFFF, // Range Maximum
+ 0x00000000, // Translation Offset
+ 0x10000000, // Length
+ ,, , AddressRangeMemory, TypeStatic)
+ })
+ }
}
Scope (_SB)
which is consistent with what commit e3fb55f06501b7cff mentions.
Therefore yes as Igor mentions, we do not need to add any additional table
blobs for those tests. Also if only 7b630d937a also added the above info, we would be less
confused.
>
> >
> > I believe at some point I did TEST_ACPI_REBUILD_AML which regenrated those
> > files in my workspace and hence they were there. Same could be true for
> > Igor and got added when he generated the commit.
> >
> > > >
> > > > diff --git a/tests/qtest/bios-tables-test-allowed-diff.h b/tests/qtest/bios-tables-test-allowed-diff.h
> > > > index 48e5634d4b..dfb8523c8b 100644
> > > > --- a/tests/qtest/bios-tables-test-allowed-diff.h
> > > > +++ b/tests/qtest/bios-tables-test-allowed-diff.h
> > > > @@ -1,17 +1 @@
> > > > /* List of comma-separated changed AML files to ignore */
> > > > -"tests/data/acpi/q35/DSDT",
> > > > -"tests/data/acpi/q35/DSDT.tis",
> > > > -"tests/data/acpi/q35/DSDT.bridge",
> > > > -"tests/data/acpi/q35/DSDT.mmio64",
> > > > -"tests/data/acpi/q35/DSDT.ipmibt",
> > > > -"tests/data/acpi/q35/DSDT.cphp",
> > > > -"tests/data/acpi/q35/DSDT.memhp",
> > > > -"tests/data/acpi/q35/DSDT.acpihmat",
> > > > -"tests/data/acpi/q35/DSDT.numamem",
> > > > -"tests/data/acpi/q35/DSDT.dimmpxm",
> > > > -"tests/data/acpi/q35/DSDT.nohpet",
> > > > -"tests/data/acpi/q35/DSDT.tis.tpm2",
> > > > -"tests/data/acpi/q35/DSDT.tis.tpm12",
> > > > -"tests/data/acpi/q35/DSDT.multi-bridge",
> > > > -"tests/data/acpi/q35/DSDT.ivrs",
> > > > -"tests/data/acpi/q35/DSDT.xapic",
> > > > diff --git a/tests/data/acpi/q35/DSDT b/tests/data/acpi/q35/DSDT
> > > > index 281fc82c03b2562d2e6b7caec0d817b034a47138..c1965f6051ef2af81dd8412abe169d87845bb033 100644
> > > > GIT binary patch
> > > > delta 24
> > > > gcmaFp@X&$FCD<h-QGtPh@z+GID~xg*?>ET<0BnZ{w*UYD
> > > >
> > > > delta 24
> > > > gcmaFp@X&$FCD<h-QGtPh@#jRYD~$3R?>ET<0BnK?w*UYD
> > > >
> > > > diff --git a/tests/data/acpi/q35/DSDT.acpihmat b/tests/data/acpi/q35/DSDT.acpihmat
> > > > index 8c1e05a11a328ec1cc6f86e36e52c28f41f9744e..f24d4874bff8d327a165ed7c36de507aea114edd 100644
> > > > GIT binary patch
> > > > delta 24
> > > > fcmeD4?(^ny33dtTQ)OUa+&+=(3ZvY{`|DKzU@Hhn
> > > >
> > > > delta 24
> > > > fcmeD4?(^ny33dtTQ)OUa+%}Qx3ZwkS`|DKzU?vDi
> > > >
> > > > diff --git a/tests/data/acpi/q35/DSDT.bridge b/tests/data/acpi/q35/DSDT.bridge
> > > > index 6f1464b6c712d7f33cb4b891b7ce76fe228f44c9..424d51bd1cb39ea73501ef7d0044ee52cec5bdac 100644
> > > > GIT binary patch
> > > > delta 24
> > > > gcmewz`a6`%CD<k8w-y5fBg;gtD~xg*@5^Wb0CWThXaE2J
> > > >
> > > > delta 24
> > > > gcmewz`a6`%CD<k8w-y5fBlASAD~$3R@5^Wb0CWEcXaE2J
> > > >
> > > > diff --git a/tests/data/acpi/q35/DSDT.cphp b/tests/data/acpi/q35/DSDT.cphp
> > > > index f8337ff5191a37a47dcf7c09a6c39c4e704a15bf..f1275606f68eeba54bfb11e63d818420385a62b9 100644
> > > > GIT binary patch
> > > > delta 24
> > > > fcmdn!veAXhCD<jzP>F$oF>WH)6-K#@_k$DxTWtqt
> > > >
> > > > delta 24
> > > > fcmdn!veAXhCD<jzP>F$oF?J%?6-N1u_k$DxTWAMo
> > > >
> > > > diff --git a/tests/data/acpi/q35/DSDT.dimmpxm b/tests/data/acpi/q35/DSDT.dimmpxm
> > > > index fe5820d93d057ef09a001662369b15afbc5b87e2..76e451e829ec4c245315f7eed8731aa1be45a747 100644
> > > > GIT binary patch
> > > > delta 24
> > > > gcmccad)=4ICD<k8x*7umqsK(9D~xg*@BdH*0B$o00{{R3
> > > >
> > > > delta 24
> > > > gcmccad)=4ICD<k8x*7umqx(dzD~$3R@BdH*0B$Y`0{{R3
> > > >
> > > > diff --git a/tests/data/acpi/q35/DSDT.dmar b/tests/data/acpi/q35/DSDT.dmar
> > > > new file mode 100644
> > > > index 0000000000000000000000000000000000000000..c1965f6051ef2af81dd8412abe169d87845bb033
> > > > GIT binary patch
> > > > literal 8289
> > > > zcmb7JOKcm*8J^`!tL0K!Qk3OaY{E(UN|8{0Bx#EVC3pF<L~6yQ;si9nrRB7;og#}k
> > > > z2J%1vSpgEqhoT9aphr4TfZp0uuQkw1d-JUUdg`H<T#F(`4`IK5h9l3A6cF>U+JE-@
> > > > z{(rvNo&8obUf^~51;&j3l{egaP$<9Ry9N9V#u%N`U#F3{%(}Z?xz;n%v4qjRo#y8_
> > > > zl+FB)z4BJg`29}!c^JO+QE2odcI6A_vn&1RgFE3BMxa|)BFmx^r?Sus%DwKMYx!=Y
> > > > zX!hz2&n`W%Ota^Tv$)wSd2MF)wi+JGug~>10ylB@26MejtHV}uu#;V~oNn`<=e{|8
> > > > z@)w_9daHE*=l}TS-5XW{fV22(;_tbL4&i&Dbt)V>pAN1W?-QM0TOBTaI^dT@n?qNk
> > > > zkXr89qKQ(i?%(L{z38<|F7IQ;Z}~;HxQc$c?I3&FI{DEGV>S&A{r)r>js7A|nez^F
> > > > znx;@$G3$P%BUKvEMyk5Ib-&YOHe(OIO|wMzwnOpK%axW_@Y`Omkbk}xbV@9umN25G
> > > > z{=1>&ghTt2LC6MSdNkT+!-Y=<efGP)&HnY@<UZTC7DeB(*20JL)Rza}vIJx3&G(+A
> > > > z-q3h=_l`G$QjZTY%AZD8{6>2-W`&mRtSvqlmq0>w_s*}CJ%GhMilg`Fl`M1ATCN!(
> > > > z3z=cmjH~P_{+@}UT6gcM=El|mYjH_qnO5=)jZk;*?7H7smAMn*ej6Iru`)H|?fBbq
> > > > z(>$}wGoN)gng^UD&=}1boQLs;ab})zIOpkh$35sxdVK$Q>WD?mFwZapL)6MX8lzp`
> > > > z4LU~pzHOPfH59lQyR8BaUZJ}iR4!r`{LQv-<I)tk<znR`E|go%wvm1yXcV~R)>gCN
> > > > zH@sI0U8B72uCe^nzFWB%>pn@*XcX-bB6`QT#wbVk`_#P8^3RmOnT4WU5go!YHq3h|
> > > > z-wT=x!}amhc<{pC{~cU-xB1D+*Ue*pb(<08di~eo@X5h-Has@CX2mcA-sjJejmLJx
> > > > z_Oo&0HXYc#mErQ>x-}Q&k};NH{V2TCXKcT3`VF_r@^%k@jcA7==Qpn!^sqSY*L))T
> > > > z?T(*YySbZ7C-8K#_10R2iE{(zRhF}<-HIWo$smrP&T^Rq`hl4waN~$r04|7YoCl~3
> > > > ziHZCi8{<r1#}P3lG{!g+P|ie1O!S6h<D4mb5NE`c(70d%%9#j>DXU;!2`tZ(;7kck
> > > > z2&U{jLRDu{)0yN<2~7&7>^wqMXG+tV;!Fum={garI_ET<bDGXMT_-|Sr>W^QHJzre
> > > > z6QQaTZy;r)=QW-4x=w_uPD|5iX*w-kCqh+cTGN@<bf$Hk2vwbU7b^GD)^yssPK2t?
> > > > zjHWZA>CEUl5vn>DG@T2Y&IMg3LRIIYrgKr#xv1+zsOoeyosOo{(RCtJb!Ii4SxskF
> > > > z*NITonbUOUG@UtJCqh-{lBRP>)48PUM5yY_YdZ6q&b+P@p{jFP)48naT-J3WRCONF
> > > > zbRN-k9?^9oRCVG@0#BcO53OiAS9F~SRh>sQokumDM|GVDRh`E;vowAa9^=gN_+@uY
> > > > zFx^KXF}*SNxW+uLF^}s^gevod#yp`hPv}g9D)XeqJgG5H>P&<x^9halgvNYAXChRY
> > > > zr#Mr(%qh;4@Ay-KDPP<Oi7D^kX|3jIt>$UHCPGougn^b61FZ!Ol;&n?;2ed=28sY>
> > > > zMG!|Ii^4z!j$4w!h$Z`Hps0Wz7$`z14F)Q((m)j`8K{6B7$`#YMjEKVjw7n68mNFC
> > > > z7$`#Yh+|=(0y~bz8ab2<R6u2@>V$!cw44b8RiI>`2&F5Mfg+STVW0xbnJ`cVN(L&R
> > > > zye1haLa7r5DzKah16818paRO7WS|J8P8g`bawZH^fs%m=C})y^B9!+N1}d<e2?JH2
> > > > zWS|1dnPi{{rA`>Az;Y%GRDqI#3Mglifg+STVW0xbnJ`cVN(L&RoJj_XQ0jz%3M^;B
> > > > zKouw%sDN@N87M-j69y`<oCyO}pk$x|%9&)K2&GOKsK9b23{-)VfeI*Rl7S+WI$@v!
> > > > z%b74x1xf}gpqxnticso=feI{V!ax-$8K{7ACK)I~sS^e&u$&14RiI>`0?L_Wpa`W-
> > > > z7^uK<CJa=8l7R{+XOe*;lsaLc0?U~&Pz6c`DxjQ628vMXgn<eyXTm@gC>f}LawZul
> > > > zLa7r5DzKah16818paRO7WS|J8P8g`bawZH^fs%m=C})y^B9uB|paRR8Fi-_b1}dPO
> > > > zNd}5g>V$y`EN8+%6(|{~fN~}oC_<?d28u{AP(-SMB2*0&p<<v469%d<$v_n*8K}a9
> > > > zfhtTGsKO)zRhVR;3KIsZFkzqylMGa0l7T8r7^uR8fhtTgP=!ebsxV=oh~(Xcfg-{k
> > > > z<AX^CiV(L!hQyR(3j;+Y#})>PNRBNTC_*{5WS|JKRCK%t3uQxl!2em@r+-NArRYzo
> > > > zd;6!)#p%CPTGgQS4#RJ6mf*OXWjeTY@Jxoam(2>DSLslrL*2|TH8!ytFr0tS+TFn-
> > > > z%ly8T&Yy2=y6t%Y+QsaGmHs%z=J`s{JM1pCSxFol(R(}ABBL{OqK&1O^*MYal;o0!
> > > > zjpZ6z3^LK}AbZ4G`gnoO$Kh@a?{9`TF;*|~i+mkupSpnFl=9i0*9h4AbZ+hPmPJ~R
> > > > zVnDcU9<TI*c3|Ay8TWz8Q~S7jd7?TNPrh^YvQoXwtC!I~wR$-}yL!31*Cg#?DGkeg
> > > > zW9?S#G0MA2d6$=WC(65rly}GFy$SIa7PP*zdQU0u@$%k8dGC<&-ne{avV7t(%2$-~
> > > > z6<)qFQND6W`O3I_b+UZ&G0In!@>O2GI#IrQNcrlxd~LFP>M_dKl=3xRzBW<5c1Zc!
> > > > zxO{!G{M=)duPf#2ynKD4eEpE}b(Bxgt8B8oBg)H{2R<t>-NpK?-j+}CDUUxiugB>o
> > > > zr?HjQ)8SiVDxGMXnQm%c=Ja&<0GUcB+GeJknrB!7rg<iX;j3gSooJhxZff4-^>p}D
> > > > znMx<xW~Q5(2g`aoe7{Vk6KyloO+D8~^mO>BnMx<xW~Q5ZPFM7F_|ln5C))IM&WT6s
> > > > z*?WsYvy814Y^&IDtob_|FNxiWx^?-{iof5k1oA1hFgf8(8Q0$`)Zch3di~a~3U9u4
> > > > z^Nm|?ZohVubq&{FUmHKI8Oy2}U)f*ThK*HycoHq0e`Q;C_x2AcD6xX;S6YVKXa$Db
> > > > zZoX__0lY|us=?x}+w`!=o+D)34Jzvez`atZfVJjEt6@fr8u8ShyUg{VL!y(JlIu5$
> > > > z#nmEpLu?!+^I5l3eKj_;20QFSw^%G*%hyv_y)VsopS=8BLT+u4P!d4P?~~0a7O`-6
> > > > zd@y-|Bt+ICmffeWtgr2d`DT)2JzgPWG8Hn+%%86waRawy9wNhZTa`<>*eGJ#k#Y44
> > > > zFE_YqMC@v0gc0k1v2Oo%5E`FtqbZEGCrfg{la073!<Ek_TX9>qzZ}jF`ql_#zKmvF
> > > > zA3ilTa&+IL?K{-RKD*UNukO7tyf6jhPX=z^wiS=21_l?wyR}Uli<N}fS)_zl*f!mA
> > > > zXxr|t&K5V73;nruW%e*P=iQB<V;?fiv!9l!{209G+KjP@tk`5LL9b6XVwh+4uKU4@
> > > > z^h{&^<A>>i=i1z-ryDb%S?XldmdUW%K;NPH1#Fsj(j<oMT)Un>fyq<zE4@nbEE~^w
> > > > znn?6aIU5PO#3%lEP8FYL`JVv0%4i@Cb_B(amD1q5E#6ZN;WU@UOy!$Ge6RFk+WPaI
> > > > z42xlj0KX9(uw(eperOve+6}yu@cRarAKC|T275@1{fBR|^6T_jJQ~qwG5ump+kQ2%
> > > > zjrB)yh5bRhav%G$--;{uU%LAYwrt1QL>rA3?SWz7v>(N^N$DmqIAWKY?*NxDIO5ev
> > > > z?aDh*Y+R;=gY$P{Ayr5je5dnb!ms;nF~qcu{3r<qX~z3?I@f*szHJ=EHsud5qkM3#
> > > > zmrErK^d0BtdpR><#Vjo1A-X_UNQv{aN4KH7_iXi&D||1rS!r(JF*-|VZ04#xc9Kq#
> > > > z-r`OxahY%JRTFd<yL;)NSQLB47?K|a#TP|@J7zGLaj@z!Y+B;vtUNi#Pg3-Vu>S)s
> > > > Cro3tZ
> > > >
> > > > literal 0
> > > > HcmV?d00001
> > > >
> > > > diff --git a/tests/data/acpi/q35/DSDT.ipmibt b/tests/data/acpi/q35/DSDT.ipmibt
> > > > index 631741065860fd5036aa303904dabd1d2839f9c6..6ad2411d0ec95f204cfc64b430c537bce09c35bd 100644
> > > > GIT binary patch
> > > > delta 24
> > > > gcmZ4ExW<voCD<iojRFG$quxZWD~xg*@1K<i0AMf(82|tP
> > > >
> > > > delta 24
> > > > gcmZ4ExW<voCD<iojRFG$qwYkmD~$3R@1K<i0AMQ!82|tP
> > > >
> > > > diff --git a/tests/data/acpi/q35/DSDT.ivrs b/tests/data/acpi/q35/DSDT.ivrs
> > > > index b0eafe90e5832935557ec5e6802c0147c88f379c..cad26e3f0c27a40a33101155a5282ed9bcb1d441 100644
> > > > GIT binary patch
> > > > delta 24
> > > > gcmez5@X3M8CD<jTNP&TYan?kxD~xg*?@yKo0BrUMn*aa+
> > > >
> > > > delta 24
> > > > gcmez5@X3M8CD<jTNP&TYappv>D~$3R?@yKo0BrFHn*aa+
> > > >
> > > > diff --git a/tests/data/acpi/q35/DSDT.memhp b/tests/data/acpi/q35/DSDT.memhp
> > > > index 9bc11518fc57687ca789dc70793b48b29a0d74ed..4e9cb3dc6896bb79ccac0fe342a404549f6610e8 100644
> > > > GIT binary patch
> > > > delta 24
> > > > gcmdnsy}_HyCD<iogDL|9<C}?GR~Y3s-oK~<0BV~F1poj5
> > > >
> > > > delta 24
> > > > gcmdnsy}_HyCD<iogDL|9<LilBR~Y3t-oK~<0BV*A1poj5
> > > >
> > > > diff --git a/tests/data/acpi/q35/DSDT.mmio64 b/tests/data/acpi/q35/DSDT.mmio64
> > > > index 713288a12ef2b70a20b4e8836c036ba4db3a57a8..eb5a1c7171c02d153487bfcecfb7019b7c1bf406 100644
> > > > GIT binary patch
> > > > delta 24
> > > > gcmX@@dD@f9CD<k8v<d?Q<BEw~R~Y3s-hZPE0B$h}CjbBd
> > > >
> > > > delta 24
> > > > gcmX@@dD@f9CD<k8v<d?Q<MN4IR~Y3t-hZPE0B$S^CjbBd
> > > >
> > > > diff --git a/tests/data/acpi/q35/DSDT.multi-bridge b/tests/data/acpi/q35/DSDT.multi-bridge
> > > > index a24c713d22102a1a1583b5c902edffe1694e5cfe..45808eb03b78d07ebbe853f674abfed589d35e26 100644
> > > > GIT binary patch
> > > > delta 24
> > > > fcmZp7Zg=K#33dr-S7cyd?3>7Sg;8$f{S^uTTRaEr
> > > >
> > > > delta 24
> > > > fcmZp7Zg=K#33dr-S7cyd?48JUg;9Rv{S^uTTQ>*m
> > > >
> > > > diff --git a/tests/data/acpi/q35/DSDT.nohpet b/tests/data/acpi/q35/DSDT.nohpet
> > > > index e8202e6ddfbe96071f32f1ec05758f650569943e..83d1aa00ac5686df479673fb0d7830f946e25dea 100644
> > > > GIT binary patch
> > > > delta 24
> > > > gcmca?f7zbPCD<k8vOEI=<B^G6R~Y3s-v1&80B=4CMF0Q*
> > > >
> > > > delta 24
> > > > gcmca?f7zbPCD<k8vOEI=<Kc;1R~Y3t-v1&80B<=7MF0Q*
> > > >
> > > > diff --git a/tests/data/acpi/q35/DSDT.nosmm b/tests/data/acpi/q35/DSDT.nosmm
> > > > new file mode 100644
> > > > index 0000000000000000000000000000000000000000..c1965f6051ef2af81dd8412abe169d87845bb033
> > > > GIT binary patch
> > > > literal 8289
> > > > zcmb7JOKcm*8J^`!tL0K!Qk3OaY{E(UN|8{0Bx#EVC3pF<L~6yQ;si9nrRB7;og#}k
> > > > z2J%1vSpgEqhoT9aphr4TfZp0uuQkw1d-JUUdg`H<T#F(`4`IK5h9l3A6cF>U+JE-@
> > > > z{(rvNo&8obUf^~51;&j3l{egaP$<9Ry9N9V#u%N`U#F3{%(}Z?xz;n%v4qjRo#y8_
> > > > zl+FB)z4BJg`29}!c^JO+QE2odcI6A_vn&1RgFE3BMxa|)BFmx^r?Sus%DwKMYx!=Y
> > > > zX!hz2&n`W%Ota^Tv$)wSd2MF)wi+JGug~>10ylB@26MejtHV}uu#;V~oNn`<=e{|8
> > > > z@)w_9daHE*=l}TS-5XW{fV22(;_tbL4&i&Dbt)V>pAN1W?-QM0TOBTaI^dT@n?qNk
> > > > zkXr89qKQ(i?%(L{z38<|F7IQ;Z}~;HxQc$c?I3&FI{DEGV>S&A{r)r>js7A|nez^F
> > > > znx;@$G3$P%BUKvEMyk5Ib-&YOHe(OIO|wMzwnOpK%axW_@Y`Omkbk}xbV@9umN25G
> > > > z{=1>&ghTt2LC6MSdNkT+!-Y=<efGP)&HnY@<UZTC7DeB(*20JL)Rza}vIJx3&G(+A
> > > > z-q3h=_l`G$QjZTY%AZD8{6>2-W`&mRtSvqlmq0>w_s*}CJ%GhMilg`Fl`M1ATCN!(
> > > > z3z=cmjH~P_{+@}UT6gcM=El|mYjH_qnO5=)jZk;*?7H7smAMn*ej6Iru`)H|?fBbq
> > > > z(>$}wGoN)gng^UD&=}1boQLs;ab})zIOpkh$35sxdVK$Q>WD?mFwZapL)6MX8lzp`
> > > > z4LU~pzHOPfH59lQyR8BaUZJ}iR4!r`{LQv-<I)tk<znR`E|go%wvm1yXcV~R)>gCN
> > > > zH@sI0U8B72uCe^nzFWB%>pn@*XcX-bB6`QT#wbVk`_#P8^3RmOnT4WU5go!YHq3h|
> > > > z-wT=x!}amhc<{pC{~cU-xB1D+*Ue*pb(<08di~eo@X5h-Has@CX2mcA-sjJejmLJx
> > > > z_Oo&0HXYc#mErQ>x-}Q&k};NH{V2TCXKcT3`VF_r@^%k@jcA7==Qpn!^sqSY*L))T
> > > > z?T(*YySbZ7C-8K#_10R2iE{(zRhF}<-HIWo$smrP&T^Rq`hl4waN~$r04|7YoCl~3
> > > > ziHZCi8{<r1#}P3lG{!g+P|ie1O!S6h<D4mb5NE`c(70d%%9#j>DXU;!2`tZ(;7kck
> > > > z2&U{jLRDu{)0yN<2~7&7>^wqMXG+tV;!Fum={garI_ET<bDGXMT_-|Sr>W^QHJzre
> > > > z6QQaTZy;r)=QW-4x=w_uPD|5iX*w-kCqh+cTGN@<bf$Hk2vwbU7b^GD)^yssPK2t?
> > > > zjHWZA>CEUl5vn>DG@T2Y&IMg3LRIIYrgKr#xv1+zsOoeyosOo{(RCtJb!Ii4SxskF
> > > > z*NITonbUOUG@UtJCqh-{lBRP>)48PUM5yY_YdZ6q&b+P@p{jFP)48naT-J3WRCONF
> > > > zbRN-k9?^9oRCVG@0#BcO53OiAS9F~SRh>sQokumDM|GVDRh`E;vowAa9^=gN_+@uY
> > > > zFx^KXF}*SNxW+uLF^}s^gevod#yp`hPv}g9D)XeqJgG5H>P&<x^9halgvNYAXChRY
> > > > zr#Mr(%qh;4@Ay-KDPP<Oi7D^kX|3jIt>$UHCPGougn^b61FZ!Ol;&n?;2ed=28sY>
> > > > zMG!|Ii^4z!j$4w!h$Z`Hps0Wz7$`z14F)Q((m)j`8K{6B7$`#YMjEKVjw7n68mNFC
> > > > z7$`#Yh+|=(0y~bz8ab2<R6u2@>V$!cw44b8RiI>`2&F5Mfg+STVW0xbnJ`cVN(L&R
> > > > zye1haLa7r5DzKah16818paRO7WS|J8P8g`bawZH^fs%m=C})y^B9!+N1}d<e2?JH2
> > > > zWS|1dnPi{{rA`>Az;Y%GRDqI#3Mglifg+STVW0xbnJ`cVN(L&RoJj_XQ0jz%3M^;B
> > > > zKouw%sDN@N87M-j69y`<oCyO}pk$x|%9&)K2&GOKsK9b23{-)VfeI*Rl7S+WI$@v!
> > > > z%b74x1xf}gpqxnticso=feI{V!ax-$8K{7ACK)I~sS^e&u$&14RiI>`0?L_Wpa`W-
> > > > z7^uK<CJa=8l7R{+XOe*;lsaLc0?U~&Pz6c`DxjQ628vMXgn<eyXTm@gC>f}LawZul
> > > > zLa7r5DzKah16818paRO7WS|J8P8g`bawZH^fs%m=C})y^B9uB|paRR8Fi-_b1}dPO
> > > > zNd}5g>V$y`EN8+%6(|{~fN~}oC_<?d28u{AP(-SMB2*0&p<<v469%d<$v_n*8K}a9
> > > > zfhtTGsKO)zRhVR;3KIsZFkzqylMGa0l7T8r7^uR8fhtTgP=!ebsxV=oh~(Xcfg-{k
> > > > z<AX^CiV(L!hQyR(3j;+Y#})>PNRBNTC_*{5WS|JKRCK%t3uQxl!2em@r+-NArRYzo
> > > > zd;6!)#p%CPTGgQS4#RJ6mf*OXWjeTY@Jxoam(2>DSLslrL*2|TH8!ytFr0tS+TFn-
> > > > z%ly8T&Yy2=y6t%Y+QsaGmHs%z=J`s{JM1pCSxFol(R(}ABBL{OqK&1O^*MYal;o0!
> > > > zjpZ6z3^LK}AbZ4G`gnoO$Kh@a?{9`TF;*|~i+mkupSpnFl=9i0*9h4AbZ+hPmPJ~R
> > > > zVnDcU9<TI*c3|Ay8TWz8Q~S7jd7?TNPrh^YvQoXwtC!I~wR$-}yL!31*Cg#?DGkeg
> > > > zW9?S#G0MA2d6$=WC(65rly}GFy$SIa7PP*zdQU0u@$%k8dGC<&-ne{avV7t(%2$-~
> > > > z6<)qFQND6W`O3I_b+UZ&G0In!@>O2GI#IrQNcrlxd~LFP>M_dKl=3xRzBW<5c1Zc!
> > > > zxO{!G{M=)duPf#2ynKD4eEpE}b(Bxgt8B8oBg)H{2R<t>-NpK?-j+}CDUUxiugB>o
> > > > zr?HjQ)8SiVDxGMXnQm%c=Ja&<0GUcB+GeJknrB!7rg<iX;j3gSooJhxZff4-^>p}D
> > > > znMx<xW~Q5(2g`aoe7{Vk6KyloO+D8~^mO>BnMx<xW~Q5ZPFM7F_|ln5C))IM&WT6s
> > > > z*?WsYvy814Y^&IDtob_|FNxiWx^?-{iof5k1oA1hFgf8(8Q0$`)Zch3di~a~3U9u4
> > > > z^Nm|?ZohVubq&{FUmHKI8Oy2}U)f*ThK*HycoHq0e`Q;C_x2AcD6xX;S6YVKXa$Db
> > > > zZoX__0lY|us=?x}+w`!=o+D)34Jzvez`atZfVJjEt6@fr8u8ShyUg{VL!y(JlIu5$
> > > > z#nmEpLu?!+^I5l3eKj_;20QFSw^%G*%hyv_y)VsopS=8BLT+u4P!d4P?~~0a7O`-6
> > > > zd@y-|Bt+ICmffeWtgr2d`DT)2JzgPWG8Hn+%%86waRawy9wNhZTa`<>*eGJ#k#Y44
> > > > zFE_YqMC@v0gc0k1v2Oo%5E`FtqbZEGCrfg{la073!<Ek_TX9>qzZ}jF`ql_#zKmvF
> > > > zA3ilTa&+IL?K{-RKD*UNukO7tyf6jhPX=z^wiS=21_l?wyR}Uli<N}fS)_zl*f!mA
> > > > zXxr|t&K5V73;nruW%e*P=iQB<V;?fiv!9l!{209G+KjP@tk`5LL9b6XVwh+4uKU4@
> > > > z^h{&^<A>>i=i1z-ryDb%S?XldmdUW%K;NPH1#Fsj(j<oMT)Un>fyq<zE4@nbEE~^w
> > > > znn?6aIU5PO#3%lEP8FYL`JVv0%4i@Cb_B(amD1q5E#6ZN;WU@UOy!$Ge6RFk+WPaI
> > > > z42xlj0KX9(uw(eperOve+6}yu@cRarAKC|T275@1{fBR|^6T_jJQ~qwG5ump+kQ2%
> > > > zjrB)yh5bRhav%G$--;{uU%LAYwrt1QL>rA3?SWz7v>(N^N$DmqIAWKY?*NxDIO5ev
> > > > z?aDh*Y+R;=gY$P{Ayr5je5dnb!ms;nF~qcu{3r<qX~z3?I@f*szHJ=EHsud5qkM3#
> > > > zmrErK^d0BtdpR><#Vjo1A-X_UNQv{aN4KH7_iXi&D||1rS!r(JF*-|VZ04#xc9Kq#
> > > > z-r`OxahY%JRTFd<yL;)NSQLB47?K|a#TP|@J7zGLaj@z!Y+B;vtUNi#Pg3-Vu>S)s
> > > > Cro3tZ
> > > >
> > > > literal 0
> > > > HcmV?d00001
> > > >
> > > > diff --git a/tests/data/acpi/q35/DSDT.numamem b/tests/data/acpi/q35/DSDT.numamem
> > > > index 151e7cf42953f3f5fe61ff0140ab7b976fe9e5b8..050aaa237b466b0bda8cca5cfaa06f84661d622e 100644
> > > > GIT binary patch
> > > > delta 24
> > > > gcmaFv@Z5pRCD<h-U4emtamhrkD~xg*?{~-p0BWTOc>n+a
> > > >
> > > > delta 24
> > > > gcmaFv@Z5pRCD<h-U4emtaq&d1D~$3R?{~-p0BWEJc>n+a
> > > >
> > > > diff --git a/tests/data/acpi/q35/DSDT.smm-compat b/tests/data/acpi/q35/DSDT.smm-compat
> > > > new file mode 100644
> > > > index 0000000000000000000000000000000000000000..c1965f6051ef2af81dd8412abe169d87845bb033
> > > > GIT binary patch
> > > > literal 8289
> > > > zcmb7JOKcm*8J^`!tL0K!Qk3OaY{E(UN|8{0Bx#EVC3pF<L~6yQ;si9nrRB7;og#}k
> > > > z2J%1vSpgEqhoT9aphr4TfZp0uuQkw1d-JUUdg`H<T#F(`4`IK5h9l3A6cF>U+JE-@
> > > > z{(rvNo&8obUf^~51;&j3l{egaP$<9Ry9N9V#u%N`U#F3{%(}Z?xz;n%v4qjRo#y8_
> > > > zl+FB)z4BJg`29}!c^JO+QE2odcI6A_vn&1RgFE3BMxa|)BFmx^r?Sus%DwKMYx!=Y
> > > > zX!hz2&n`W%Ota^Tv$)wSd2MF)wi+JGug~>10ylB@26MejtHV}uu#;V~oNn`<=e{|8
> > > > z@)w_9daHE*=l}TS-5XW{fV22(;_tbL4&i&Dbt)V>pAN1W?-QM0TOBTaI^dT@n?qNk
> > > > zkXr89qKQ(i?%(L{z38<|F7IQ;Z}~;HxQc$c?I3&FI{DEGV>S&A{r)r>js7A|nez^F
> > > > znx;@$G3$P%BUKvEMyk5Ib-&YOHe(OIO|wMzwnOpK%axW_@Y`Omkbk}xbV@9umN25G
> > > > z{=1>&ghTt2LC6MSdNkT+!-Y=<efGP)&HnY@<UZTC7DeB(*20JL)Rza}vIJx3&G(+A
> > > > z-q3h=_l`G$QjZTY%AZD8{6>2-W`&mRtSvqlmq0>w_s*}CJ%GhMilg`Fl`M1ATCN!(
> > > > z3z=cmjH~P_{+@}UT6gcM=El|mYjH_qnO5=)jZk;*?7H7smAMn*ej6Iru`)H|?fBbq
> > > > z(>$}wGoN)gng^UD&=}1boQLs;ab})zIOpkh$35sxdVK$Q>WD?mFwZapL)6MX8lzp`
> > > > z4LU~pzHOPfH59lQyR8BaUZJ}iR4!r`{LQv-<I)tk<znR`E|go%wvm1yXcV~R)>gCN
> > > > zH@sI0U8B72uCe^nzFWB%>pn@*XcX-bB6`QT#wbVk`_#P8^3RmOnT4WU5go!YHq3h|
> > > > z-wT=x!}amhc<{pC{~cU-xB1D+*Ue*pb(<08di~eo@X5h-Has@CX2mcA-sjJejmLJx
> > > > z_Oo&0HXYc#mErQ>x-}Q&k};NH{V2TCXKcT3`VF_r@^%k@jcA7==Qpn!^sqSY*L))T
> > > > z?T(*YySbZ7C-8K#_10R2iE{(zRhF}<-HIWo$smrP&T^Rq`hl4waN~$r04|7YoCl~3
> > > > ziHZCi8{<r1#}P3lG{!g+P|ie1O!S6h<D4mb5NE`c(70d%%9#j>DXU;!2`tZ(;7kck
> > > > z2&U{jLRDu{)0yN<2~7&7>^wqMXG+tV;!Fum={garI_ET<bDGXMT_-|Sr>W^QHJzre
> > > > z6QQaTZy;r)=QW-4x=w_uPD|5iX*w-kCqh+cTGN@<bf$Hk2vwbU7b^GD)^yssPK2t?
> > > > zjHWZA>CEUl5vn>DG@T2Y&IMg3LRIIYrgKr#xv1+zsOoeyosOo{(RCtJb!Ii4SxskF
> > > > z*NITonbUOUG@UtJCqh-{lBRP>)48PUM5yY_YdZ6q&b+P@p{jFP)48naT-J3WRCONF
> > > > zbRN-k9?^9oRCVG@0#BcO53OiAS9F~SRh>sQokumDM|GVDRh`E;vowAa9^=gN_+@uY
> > > > zFx^KXF}*SNxW+uLF^}s^gevod#yp`hPv}g9D)XeqJgG5H>P&<x^9halgvNYAXChRY
> > > > zr#Mr(%qh;4@Ay-KDPP<Oi7D^kX|3jIt>$UHCPGougn^b61FZ!Ol;&n?;2ed=28sY>
> > > > zMG!|Ii^4z!j$4w!h$Z`Hps0Wz7$`z14F)Q((m)j`8K{6B7$`#YMjEKVjw7n68mNFC
> > > > z7$`#Yh+|=(0y~bz8ab2<R6u2@>V$!cw44b8RiI>`2&F5Mfg+STVW0xbnJ`cVN(L&R
> > > > zye1haLa7r5DzKah16818paRO7WS|J8P8g`bawZH^fs%m=C})y^B9!+N1}d<e2?JH2
> > > > zWS|1dnPi{{rA`>Az;Y%GRDqI#3Mglifg+STVW0xbnJ`cVN(L&RoJj_XQ0jz%3M^;B
> > > > zKouw%sDN@N87M-j69y`<oCyO}pk$x|%9&)K2&GOKsK9b23{-)VfeI*Rl7S+WI$@v!
> > > > z%b74x1xf}gpqxnticso=feI{V!ax-$8K{7ACK)I~sS^e&u$&14RiI>`0?L_Wpa`W-
> > > > z7^uK<CJa=8l7R{+XOe*;lsaLc0?U~&Pz6c`DxjQ628vMXgn<eyXTm@gC>f}LawZul
> > > > zLa7r5DzKah16818paRO7WS|J8P8g`bawZH^fs%m=C})y^B9uB|paRR8Fi-_b1}dPO
> > > > zNd}5g>V$y`EN8+%6(|{~fN~}oC_<?d28u{AP(-SMB2*0&p<<v469%d<$v_n*8K}a9
> > > > zfhtTGsKO)zRhVR;3KIsZFkzqylMGa0l7T8r7^uR8fhtTgP=!ebsxV=oh~(Xcfg-{k
> > > > z<AX^CiV(L!hQyR(3j;+Y#})>PNRBNTC_*{5WS|JKRCK%t3uQxl!2em@r+-NArRYzo
> > > > zd;6!)#p%CPTGgQS4#RJ6mf*OXWjeTY@Jxoam(2>DSLslrL*2|TH8!ytFr0tS+TFn-
> > > > z%ly8T&Yy2=y6t%Y+QsaGmHs%z=J`s{JM1pCSxFol(R(}ABBL{OqK&1O^*MYal;o0!
> > > > zjpZ6z3^LK}AbZ4G`gnoO$Kh@a?{9`TF;*|~i+mkupSpnFl=9i0*9h4AbZ+hPmPJ~R
> > > > zVnDcU9<TI*c3|Ay8TWz8Q~S7jd7?TNPrh^YvQoXwtC!I~wR$-}yL!31*Cg#?DGkeg
> > > > zW9?S#G0MA2d6$=WC(65rly}GFy$SIa7PP*zdQU0u@$%k8dGC<&-ne{avV7t(%2$-~
> > > > z6<)qFQND6W`O3I_b+UZ&G0In!@>O2GI#IrQNcrlxd~LFP>M_dKl=3xRzBW<5c1Zc!
> > > > zxO{!G{M=)duPf#2ynKD4eEpE}b(Bxgt8B8oBg)H{2R<t>-NpK?-j+}CDUUxiugB>o
> > > > zr?HjQ)8SiVDxGMXnQm%c=Ja&<0GUcB+GeJknrB!7rg<iX;j3gSooJhxZff4-^>p}D
> > > > znMx<xW~Q5(2g`aoe7{Vk6KyloO+D8~^mO>BnMx<xW~Q5ZPFM7F_|ln5C))IM&WT6s
> > > > z*?WsYvy814Y^&IDtob_|FNxiWx^?-{iof5k1oA1hFgf8(8Q0$`)Zch3di~a~3U9u4
> > > > z^Nm|?ZohVubq&{FUmHKI8Oy2}U)f*ThK*HycoHq0e`Q;C_x2AcD6xX;S6YVKXa$Db
> > > > zZoX__0lY|us=?x}+w`!=o+D)34Jzvez`atZfVJjEt6@fr8u8ShyUg{VL!y(JlIu5$
> > > > z#nmEpLu?!+^I5l3eKj_;20QFSw^%G*%hyv_y)VsopS=8BLT+u4P!d4P?~~0a7O`-6
> > > > zd@y-|Bt+ICmffeWtgr2d`DT)2JzgPWG8Hn+%%86waRawy9wNhZTa`<>*eGJ#k#Y44
> > > > zFE_YqMC@v0gc0k1v2Oo%5E`FtqbZEGCrfg{la073!<Ek_TX9>qzZ}jF`ql_#zKmvF
> > > > zA3ilTa&+IL?K{-RKD*UNukO7tyf6jhPX=z^wiS=21_l?wyR}Uli<N}fS)_zl*f!mA
> > > > zXxr|t&K5V73;nruW%e*P=iQB<V;?fiv!9l!{209G+KjP@tk`5LL9b6XVwh+4uKU4@
> > > > z^h{&^<A>>i=i1z-ryDb%S?XldmdUW%K;NPH1#Fsj(j<oMT)Un>fyq<zE4@nbEE~^w
> > > > znn?6aIU5PO#3%lEP8FYL`JVv0%4i@Cb_B(amD1q5E#6ZN;WU@UOy!$Ge6RFk+WPaI
> > > > z42xlj0KX9(uw(eperOve+6}yu@cRarAKC|T275@1{fBR|^6T_jJQ~qwG5ump+kQ2%
> > > > zjrB)yh5bRhav%G$--;{uU%LAYwrt1QL>rA3?SWz7v>(N^N$DmqIAWKY?*NxDIO5ev
> > > > z?aDh*Y+R;=gY$P{Ayr5je5dnb!ms;nF~qcu{3r<qX~z3?I@f*szHJ=EHsud5qkM3#
> > > > zmrErK^d0BtdpR><#Vjo1A-X_UNQv{aN4KH7_iXi&D||1rS!r(JF*-|VZ04#xc9Kq#
> > > > z-r`OxahY%JRTFd<yL;)NSQLB47?K|a#TP|@J7zGLaj@z!Y+B;vtUNi#Pg3-Vu>S)s
> > > > Cro3tZ
> > > >
> > > > literal 0
> > > > HcmV?d00001
> > > >
> > > > diff --git a/tests/data/acpi/q35/DSDT.smm-compat-nosmm b/tests/data/acpi/q35/DSDT.smm-compat-nosmm
> > > > new file mode 100644
> > > > index 0000000000000000000000000000000000000000..c1965f6051ef2af81dd8412abe169d87845bb033
> > > > GIT binary patch
> > > > literal 8289
> > > > zcmb7JOKcm*8J^`!tL0K!Qk3OaY{E(UN|8{0Bx#EVC3pF<L~6yQ;si9nrRB7;og#}k
> > > > z2J%1vSpgEqhoT9aphr4TfZp0uuQkw1d-JUUdg`H<T#F(`4`IK5h9l3A6cF>U+JE-@
> > > > z{(rvNo&8obUf^~51;&j3l{egaP$<9Ry9N9V#u%N`U#F3{%(}Z?xz;n%v4qjRo#y8_
> > > > zl+FB)z4BJg`29}!c^JO+QE2odcI6A_vn&1RgFE3BMxa|)BFmx^r?Sus%DwKMYx!=Y
> > > > zX!hz2&n`W%Ota^Tv$)wSd2MF)wi+JGug~>10ylB@26MejtHV}uu#;V~oNn`<=e{|8
> > > > z@)w_9daHE*=l}TS-5XW{fV22(;_tbL4&i&Dbt)V>pAN1W?-QM0TOBTaI^dT@n?qNk
> > > > zkXr89qKQ(i?%(L{z38<|F7IQ;Z}~;HxQc$c?I3&FI{DEGV>S&A{r)r>js7A|nez^F
> > > > znx;@$G3$P%BUKvEMyk5Ib-&YOHe(OIO|wMzwnOpK%axW_@Y`Omkbk}xbV@9umN25G
> > > > z{=1>&ghTt2LC6MSdNkT+!-Y=<efGP)&HnY@<UZTC7DeB(*20JL)Rza}vIJx3&G(+A
> > > > z-q3h=_l`G$QjZTY%AZD8{6>2-W`&mRtSvqlmq0>w_s*}CJ%GhMilg`Fl`M1ATCN!(
> > > > z3z=cmjH~P_{+@}UT6gcM=El|mYjH_qnO5=)jZk;*?7H7smAMn*ej6Iru`)H|?fBbq
> > > > z(>$}wGoN)gng^UD&=}1boQLs;ab})zIOpkh$35sxdVK$Q>WD?mFwZapL)6MX8lzp`
> > > > z4LU~pzHOPfH59lQyR8BaUZJ}iR4!r`{LQv-<I)tk<znR`E|go%wvm1yXcV~R)>gCN
> > > > zH@sI0U8B72uCe^nzFWB%>pn@*XcX-bB6`QT#wbVk`_#P8^3RmOnT4WU5go!YHq3h|
> > > > z-wT=x!}amhc<{pC{~cU-xB1D+*Ue*pb(<08di~eo@X5h-Has@CX2mcA-sjJejmLJx
> > > > z_Oo&0HXYc#mErQ>x-}Q&k};NH{V2TCXKcT3`VF_r@^%k@jcA7==Qpn!^sqSY*L))T
> > > > z?T(*YySbZ7C-8K#_10R2iE{(zRhF}<-HIWo$smrP&T^Rq`hl4waN~$r04|7YoCl~3
> > > > ziHZCi8{<r1#}P3lG{!g+P|ie1O!S6h<D4mb5NE`c(70d%%9#j>DXU;!2`tZ(;7kck
> > > > z2&U{jLRDu{)0yN<2~7&7>^wqMXG+tV;!Fum={garI_ET<bDGXMT_-|Sr>W^QHJzre
> > > > z6QQaTZy;r)=QW-4x=w_uPD|5iX*w-kCqh+cTGN@<bf$Hk2vwbU7b^GD)^yssPK2t?
> > > > zjHWZA>CEUl5vn>DG@T2Y&IMg3LRIIYrgKr#xv1+zsOoeyosOo{(RCtJb!Ii4SxskF
> > > > z*NITonbUOUG@UtJCqh-{lBRP>)48PUM5yY_YdZ6q&b+P@p{jFP)48naT-J3WRCONF
> > > > zbRN-k9?^9oRCVG@0#BcO53OiAS9F~SRh>sQokumDM|GVDRh`E;vowAa9^=gN_+@uY
> > > > zFx^KXF}*SNxW+uLF^}s^gevod#yp`hPv}g9D)XeqJgG5H>P&<x^9halgvNYAXChRY
> > > > zr#Mr(%qh;4@Ay-KDPP<Oi7D^kX|3jIt>$UHCPGougn^b61FZ!Ol;&n?;2ed=28sY>
> > > > zMG!|Ii^4z!j$4w!h$Z`Hps0Wz7$`z14F)Q((m)j`8K{6B7$`#YMjEKVjw7n68mNFC
> > > > z7$`#Yh+|=(0y~bz8ab2<R6u2@>V$!cw44b8RiI>`2&F5Mfg+STVW0xbnJ`cVN(L&R
> > > > zye1haLa7r5DzKah16818paRO7WS|J8P8g`bawZH^fs%m=C})y^B9!+N1}d<e2?JH2
> > > > zWS|1dnPi{{rA`>Az;Y%GRDqI#3Mglifg+STVW0xbnJ`cVN(L&RoJj_XQ0jz%3M^;B
> > > > zKouw%sDN@N87M-j69y`<oCyO}pk$x|%9&)K2&GOKsK9b23{-)VfeI*Rl7S+WI$@v!
> > > > z%b74x1xf}gpqxnticso=feI{V!ax-$8K{7ACK)I~sS^e&u$&14RiI>`0?L_Wpa`W-
> > > > z7^uK<CJa=8l7R{+XOe*;lsaLc0?U~&Pz6c`DxjQ628vMXgn<eyXTm@gC>f}LawZul
> > > > zLa7r5DzKah16818paRO7WS|J8P8g`bawZH^fs%m=C})y^B9uB|paRR8Fi-_b1}dPO
> > > > zNd}5g>V$y`EN8+%6(|{~fN~}oC_<?d28u{AP(-SMB2*0&p<<v469%d<$v_n*8K}a9
> > > > zfhtTGsKO)zRhVR;3KIsZFkzqylMGa0l7T8r7^uR8fhtTgP=!ebsxV=oh~(Xcfg-{k
> > > > z<AX^CiV(L!hQyR(3j;+Y#})>PNRBNTC_*{5WS|JKRCK%t3uQxl!2em@r+-NArRYzo
> > > > zd;6!)#p%CPTGgQS4#RJ6mf*OXWjeTY@Jxoam(2>DSLslrL*2|TH8!ytFr0tS+TFn-
> > > > z%ly8T&Yy2=y6t%Y+QsaGmHs%z=J`s{JM1pCSxFol(R(}ABBL{OqK&1O^*MYal;o0!
> > > > zjpZ6z3^LK}AbZ4G`gnoO$Kh@a?{9`TF;*|~i+mkupSpnFl=9i0*9h4AbZ+hPmPJ~R
> > > > zVnDcU9<TI*c3|Ay8TWz8Q~S7jd7?TNPrh^YvQoXwtC!I~wR$-}yL!31*Cg#?DGkeg
> > > > zW9?S#G0MA2d6$=WC(65rly}GFy$SIa7PP*zdQU0u@$%k8dGC<&-ne{avV7t(%2$-~
> > > > z6<)qFQND6W`O3I_b+UZ&G0In!@>O2GI#IrQNcrlxd~LFP>M_dKl=3xRzBW<5c1Zc!
> > > > zxO{!G{M=)duPf#2ynKD4eEpE}b(Bxgt8B8oBg)H{2R<t>-NpK?-j+}CDUUxiugB>o
> > > > zr?HjQ)8SiVDxGMXnQm%c=Ja&<0GUcB+GeJknrB!7rg<iX;j3gSooJhxZff4-^>p}D
> > > > znMx<xW~Q5(2g`aoe7{Vk6KyloO+D8~^mO>BnMx<xW~Q5ZPFM7F_|ln5C))IM&WT6s
> > > > z*?WsYvy814Y^&IDtob_|FNxiWx^?-{iof5k1oA1hFgf8(8Q0$`)Zch3di~a~3U9u4
> > > > z^Nm|?ZohVubq&{FUmHKI8Oy2}U)f*ThK*HycoHq0e`Q;C_x2AcD6xX;S6YVKXa$Db
> > > > zZoX__0lY|us=?x}+w`!=o+D)34Jzvez`atZfVJjEt6@fr8u8ShyUg{VL!y(JlIu5$
> > > > z#nmEpLu?!+^I5l3eKj_;20QFSw^%G*%hyv_y)VsopS=8BLT+u4P!d4P?~~0a7O`-6
> > > > zd@y-|Bt+ICmffeWtgr2d`DT)2JzgPWG8Hn+%%86waRawy9wNhZTa`<>*eGJ#k#Y44
> > > > zFE_YqMC@v0gc0k1v2Oo%5E`FtqbZEGCrfg{la073!<Ek_TX9>qzZ}jF`ql_#zKmvF
> > > > zA3ilTa&+IL?K{-RKD*UNukO7tyf6jhPX=z^wiS=21_l?wyR}Uli<N}fS)_zl*f!mA
> > > > zXxr|t&K5V73;nruW%e*P=iQB<V;?fiv!9l!{209G+KjP@tk`5LL9b6XVwh+4uKU4@
> > > > z^h{&^<A>>i=i1z-ryDb%S?XldmdUW%K;NPH1#Fsj(j<oMT)Un>fyq<zE4@nbEE~^w
> > > > znn?6aIU5PO#3%lEP8FYL`JVv0%4i@Cb_B(amD1q5E#6ZN;WU@UOy!$Ge6RFk+WPaI
> > > > z42xlj0KX9(uw(eperOve+6}yu@cRarAKC|T275@1{fBR|^6T_jJQ~qwG5ump+kQ2%
> > > > zjrB)yh5bRhav%G$--;{uU%LAYwrt1QL>rA3?SWz7v>(N^N$DmqIAWKY?*NxDIO5ev
> > > > z?aDh*Y+R;=gY$P{Ayr5je5dnb!ms;nF~qcu{3r<qX~z3?I@f*szHJ=EHsud5qkM3#
> > > > zmrErK^d0BtdpR><#Vjo1A-X_UNQv{aN4KH7_iXi&D||1rS!r(JF*-|VZ04#xc9Kq#
> > > > z-r`OxahY%JRTFd<yL;)NSQLB47?K|a#TP|@J7zGLaj@z!Y+B;vtUNi#Pg3-Vu>S)s
> > > > Cro3tZ
> > > >
> > > > literal 0
> > > > HcmV?d00001
> > > >
> > > > diff --git a/tests/data/acpi/q35/DSDT.tis.tpm12 b/tests/data/acpi/q35/DSDT.tis.tpm12
> > > > index c96b5277a14ae98174408d690d6e0246bd932623..0ebdf6fbd77967f1ab5d5337b7b1fed314cfaca8 100644
> > > > GIT binary patch
> > > > delta 24
> > > > gcmdnzy3du%CD<iopArKDqxwXyD~xg*@84Gh0A(f!W&i*H
> > > >
> > > > delta 24
> > > > gcmdnzy3du%CD<iopArKDquNBSD~$3R@84Gh0A(QvW&i*H
> > > >
> > > > diff --git a/tests/data/acpi/q35/DSDT.tis.tpm2 b/tests/data/acpi/q35/DSDT.tis.tpm2
> > > > index c92d4d29c79352a60974ea9f665d0b9a410a4bac..dcbb7f0af377425db53130e8ba1c62c09c22e006 100644
> > > > GIT binary patch
> > > > delta 24
> > > > gcmdnzy3du%CD<iopArKD<D-dOR~Y3s-oLL10Bm##ApigX
> > > >
> > > > delta 24
> > > > gcmdnzy3du%CD<iopArKD<HLzuR~Y3t-oLL10BmmwApigX
> > > >
> > > > diff --git a/tests/data/acpi/q35/DSDT.xapic b/tests/data/acpi/q35/DSDT.xapic
> > > > index 119fc90f1f8a7b6934df6fd95609446e627ce15d..17552ce363ae81985f69f9ae85837a1540b79ae0 100644
> > > > GIT binary patch
> > > > delta 26
> > > > icmX>yjp@iVCN7s?mk^h31_s6r6S=N1%5A)#+64f6_X&Rh
> > > >
> > > > delta 26
> > > > icmX>yjp@iVCN7s?mk^h31_s9U6S=N1%5S`%+64f6@(F(c
> > > >
> > > > --
> > > > 2.27.0
> > >
> > >
> >
>
^ permalink raw reply [flat|nested] 24+ messages in thread
* Re: [PATCH for 6.2 v2 0/5] Fix Q35 ACPI PCI Hot-plug I/O issues
2021-11-10 21:11 [PATCH for 6.2 v2 0/5] Fix Q35 ACPI PCI Hot-plug I/O issues Igor Mammedov
` (4 preceding siblings ...)
2021-11-10 21:11 ` [PATCH for 6.2 v2 5/5] bios-tables-test: Update golden binaries Igor Mammedov
@ 2021-11-12 9:47 ` Michael S. Tsirkin
2021-11-12 10:17 ` Igor Mammedov
5 siblings, 1 reply; 24+ messages in thread
From: Michael S. Tsirkin @ 2021-11-12 9:47 UTC (permalink / raw)
To: Igor Mammedov; +Cc: ani, mapfelba, jusual, qemu-devel, kraxel
On Wed, Nov 10, 2021 at 04:11:35PM -0500, Igor Mammedov wrote:
> Changelog:
> v2:
> * simplify [1/5] and rename property to x-native-hotplug (CC stable)
> * [4/5]
> - rename function parameter to reflect actual action
> - drop local 'hotplug' variable and opencode statement
> * test with SeaBIOS/OVMF and Linux guest,
> Windows also works with SeaBIOS, can't install it in EFI
> mode on current master (it's stuck when formatting disk/or
> copying files to hdd).
>
> Attempt [1] to fix I/O allocation with the 'reserve-io' hint on each
> pcie-root-port resulted in regression [2-3]. This patchset aims to fix
> it by addressing the root cause of the problem - the disabled PCIe
> Slot HPC bit.
>
> [1] 'hw/pcie-root-port: Fix hotplug for PCI devices requiring IO'
> [2] https://gitlab.com/qemu-project/qemu/-/issues/641
> [3] https://bugzilla.redhat.com/show_bug.cgi?id=2006409
>
> CC: kraxel@redhat.com
Igor are you going to post v3 with a fixup of the expected tables?
Thanks!
> Igor Mammedov (1):
> pcie: rename 'native-hotplug' to 'x-native-hotplug'
>
> Julia Suvorova (4):
> hw/acpi/ich9: Add compat prop to keep HPC bit set for 6.1 machine type
> bios-tables-test: Allow changes in DSDT ACPI tables
> hw/i386/acpi-build: Deny control on PCIe Native Hot-plug in _OSC
> bios-tables-test: Update golden binaries
>
> include/hw/acpi/ich9.h | 1 +
> hw/acpi/ich9.c | 18 ++++++++++++++++++
> hw/i386/acpi-build.c | 12 ++++++++----
> hw/i386/pc.c | 2 ++
> hw/i386/pc_q35.c | 9 +++++++--
> hw/pci/pcie_port.c | 2 +-
> tests/data/acpi/q35/DSDT | Bin 8289 -> 8289 bytes
> tests/data/acpi/q35/DSDT.acpihmat | Bin 9614 -> 9614 bytes
> tests/data/acpi/q35/DSDT.bridge | Bin 11003 -> 11003 bytes
> tests/data/acpi/q35/DSDT.cphp | Bin 8753 -> 8753 bytes
> tests/data/acpi/q35/DSDT.dimmpxm | Bin 9943 -> 9943 bytes
> tests/data/acpi/q35/DSDT.dmar | Bin 0 -> 8289 bytes
> tests/data/acpi/q35/DSDT.ipmibt | Bin 8364 -> 8364 bytes
> tests/data/acpi/q35/DSDT.ivrs | Bin 8306 -> 8306 bytes
> tests/data/acpi/q35/DSDT.memhp | Bin 9648 -> 9648 bytes
> tests/data/acpi/q35/DSDT.mmio64 | Bin 9419 -> 9419 bytes
> tests/data/acpi/q35/DSDT.multi-bridge | Bin 8583 -> 8583 bytes
> tests/data/acpi/q35/DSDT.nohpet | Bin 8147 -> 8147 bytes
> tests/data/acpi/q35/DSDT.nosmm | Bin 0 -> 8289 bytes
> tests/data/acpi/q35/DSDT.numamem | Bin 8295 -> 8295 bytes
> tests/data/acpi/q35/DSDT.smm-compat | Bin 0 -> 8289 bytes
> tests/data/acpi/q35/DSDT.smm-compat-nosmm | Bin 0 -> 8289 bytes
> tests/data/acpi/q35/DSDT.tis.tpm12 | Bin 8894 -> 8894 bytes
> tests/data/acpi/q35/DSDT.tis.tpm2 | Bin 8894 -> 8894 bytes
> tests/data/acpi/q35/DSDT.xapic | Bin 35652 -> 35652 bytes
> 25 files changed, 37 insertions(+), 7 deletions(-)
> create mode 100644 tests/data/acpi/q35/DSDT.dmar
> create mode 100644 tests/data/acpi/q35/DSDT.nosmm
> create mode 100644 tests/data/acpi/q35/DSDT.smm-compat
> create mode 100644 tests/data/acpi/q35/DSDT.smm-compat-nosmm
>
> --
> 2.27.0
^ permalink raw reply [flat|nested] 24+ messages in thread
* Re: [PATCH for 6.2 v2 0/5] Fix Q35 ACPI PCI Hot-plug I/O issues
2021-11-12 9:47 ` [PATCH for 6.2 v2 0/5] Fix Q35 ACPI PCI Hot-plug I/O issues Michael S. Tsirkin
@ 2021-11-12 10:17 ` Igor Mammedov
0 siblings, 0 replies; 24+ messages in thread
From: Igor Mammedov @ 2021-11-12 10:17 UTC (permalink / raw)
To: Michael S. Tsirkin; +Cc: ani, mapfelba, jusual, qemu-devel, kraxel
On Fri, 12 Nov 2021 04:47:05 -0500
"Michael S. Tsirkin" <mst@redhat.com> wrote:
> On Wed, Nov 10, 2021 at 04:11:35PM -0500, Igor Mammedov wrote:
> > Changelog:
> > v2:
> > * simplify [1/5] and rename property to x-native-hotplug (CC stable)
> > * [4/5]
> > - rename function parameter to reflect actual action
> > - drop local 'hotplug' variable and opencode statement
> > * test with SeaBIOS/OVMF and Linux guest,
> > Windows also works with SeaBIOS, can't install it in EFI
> > mode on current master (it's stuck when formatting disk/or
> > copying files to hdd).
> >
> > Attempt [1] to fix I/O allocation with the 'reserve-io' hint on each
> > pcie-root-port resulted in regression [2-3]. This patchset aims to fix
> > it by addressing the root cause of the problem - the disabled PCIe
> > Slot HPC bit.
> >
> > [1] 'hw/pcie-root-port: Fix hotplug for PCI devices requiring IO'
> > [2] https://gitlab.com/qemu-project/qemu/-/issues/641
> > [3] https://bugzilla.redhat.com/show_bug.cgi?id=2006409
> >
> > CC: kraxel@redhat.com
>
> Igor are you going to post v3 with a fixup of the expected tables?
> Thanks!
I'll post in a short while,
it seems going ahead with this is less risky as it resolves remaining
issues (hotplug with edk2 and seabios boot loop) than just
reverting to native and bringing back old issues.
> > Igor Mammedov (1):
> > pcie: rename 'native-hotplug' to 'x-native-hotplug'
> >
> > Julia Suvorova (4):
> > hw/acpi/ich9: Add compat prop to keep HPC bit set for 6.1 machine type
> > bios-tables-test: Allow changes in DSDT ACPI tables
> > hw/i386/acpi-build: Deny control on PCIe Native Hot-plug in _OSC
> > bios-tables-test: Update golden binaries
> >
> > include/hw/acpi/ich9.h | 1 +
> > hw/acpi/ich9.c | 18 ++++++++++++++++++
> > hw/i386/acpi-build.c | 12 ++++++++----
> > hw/i386/pc.c | 2 ++
> > hw/i386/pc_q35.c | 9 +++++++--
> > hw/pci/pcie_port.c | 2 +-
> > tests/data/acpi/q35/DSDT | Bin 8289 -> 8289 bytes
> > tests/data/acpi/q35/DSDT.acpihmat | Bin 9614 -> 9614 bytes
> > tests/data/acpi/q35/DSDT.bridge | Bin 11003 -> 11003 bytes
> > tests/data/acpi/q35/DSDT.cphp | Bin 8753 -> 8753 bytes
> > tests/data/acpi/q35/DSDT.dimmpxm | Bin 9943 -> 9943 bytes
> > tests/data/acpi/q35/DSDT.dmar | Bin 0 -> 8289 bytes
> > tests/data/acpi/q35/DSDT.ipmibt | Bin 8364 -> 8364 bytes
> > tests/data/acpi/q35/DSDT.ivrs | Bin 8306 -> 8306 bytes
> > tests/data/acpi/q35/DSDT.memhp | Bin 9648 -> 9648 bytes
> > tests/data/acpi/q35/DSDT.mmio64 | Bin 9419 -> 9419 bytes
> > tests/data/acpi/q35/DSDT.multi-bridge | Bin 8583 -> 8583 bytes
> > tests/data/acpi/q35/DSDT.nohpet | Bin 8147 -> 8147 bytes
> > tests/data/acpi/q35/DSDT.nosmm | Bin 0 -> 8289 bytes
> > tests/data/acpi/q35/DSDT.numamem | Bin 8295 -> 8295 bytes
> > tests/data/acpi/q35/DSDT.smm-compat | Bin 0 -> 8289 bytes
> > tests/data/acpi/q35/DSDT.smm-compat-nosmm | Bin 0 -> 8289 bytes
> > tests/data/acpi/q35/DSDT.tis.tpm12 | Bin 8894 -> 8894 bytes
> > tests/data/acpi/q35/DSDT.tis.tpm2 | Bin 8894 -> 8894 bytes
> > tests/data/acpi/q35/DSDT.xapic | Bin 35652 -> 35652 bytes
> > 25 files changed, 37 insertions(+), 7 deletions(-)
> > create mode 100644 tests/data/acpi/q35/DSDT.dmar
> > create mode 100644 tests/data/acpi/q35/DSDT.nosmm
> > create mode 100644 tests/data/acpi/q35/DSDT.smm-compat
> > create mode 100644 tests/data/acpi/q35/DSDT.smm-compat-nosmm
> >
> > --
> > 2.27.0
>
^ permalink raw reply [flat|nested] 24+ messages in thread
* Re: [PATCH for 6.2 v2 1/5] pcie: rename 'native-hotplug' to 'x-native-hotplug'
2021-11-11 3:25 ` Ani Sinha
@ 2021-11-12 10:47 ` Igor Mammedov
2021-11-15 10:01 ` Ani Sinha
0 siblings, 1 reply; 24+ messages in thread
From: Igor Mammedov @ 2021-11-12 10:47 UTC (permalink / raw)
To: Ani Sinha; +Cc: mapfelba, mst, jusual, qemu-devel, qemu-stable, kraxel
On Thu, 11 Nov 2021 08:55:24 +0530 (IST)
Ani Sinha <ani@anisinha.ca> wrote:
> On Wed, 10 Nov 2021, Igor Mammedov wrote:
>
> > Mark property as experimental/internal adding 'x-' prefix.
> >
> > Property was introduced in 6.1 and it should have provided
> > ability to turn on native PCIE hotplug on port even when
> > ACPI PCI hotplug is in use is user explicitly sets property
> > on CLI. However that never worked since slot is wired to
> > ACPI hotplug controller.
> > Another non-intended usecase: disable native hotplug on slot
> > when APCI based hotplug is disabled, which works but slot has
> > 'hotplug' property for this taks.
> >
> > It should be relatively safe to rename it to experimental
> > as no users should exist for it and given that the property
> > is broken we don't really want to leave it around for much
> > longer lest users start using it.
> >
> > Signed-off-by: Igor Mammedov <imammedo@redhat.com>
>
> Barring the comment below,
>
> Reviewed-by: Ani Sinha <ani@anisinha.ca>
Thanks!
>
> > ---
> > CC: qemu-stable@nongnu.org
> > ---
> > hw/i386/pc_q35.c | 2 +-
> > hw/pci/pcie_port.c | 2 +-
> > 2 files changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/hw/i386/pc_q35.c b/hw/i386/pc_q35.c
> > index 797e09500b..fc34b905ee 100644
> > --- a/hw/i386/pc_q35.c
> > +++ b/hw/i386/pc_q35.c
> > @@ -243,7 +243,7 @@ static void pc_q35_init(MachineState *machine)
> > NULL);
> >
> > if (acpi_pcihp) {
> > - object_register_sugar_prop(TYPE_PCIE_SLOT, "native-hotplug",
> > + object_register_sugar_prop(TYPE_PCIE_SLOT, "x-native-hotplug",
> > "false", true);
>
> Let us document the fact that this property is experimental. It was not at
> once obvious to me that an "x-" prefix meant to indicate experimental
> status.
it's common knowledge, but quick grep shows we only documented
x- prefix for qmp commands but not for properties even though
properties were the first to use it. So we probably should
document it somewhere.
I thought we have acceptable property name format documented
but I couldn't find it quickly (that would be a good place
to document it).
Care to post a patch?
>
>
> > }
> >
> > diff --git a/hw/pci/pcie_port.c b/hw/pci/pcie_port.c
> > index da850e8dde..e95c1e5519 100644
> > --- a/hw/pci/pcie_port.c
> > +++ b/hw/pci/pcie_port.c
> > @@ -148,7 +148,7 @@ static Property pcie_slot_props[] = {
> > DEFINE_PROP_UINT8("chassis", PCIESlot, chassis, 0),
> > DEFINE_PROP_UINT16("slot", PCIESlot, slot, 0),
> > DEFINE_PROP_BOOL("hotplug", PCIESlot, hotplug, true),
> > - DEFINE_PROP_BOOL("native-hotplug", PCIESlot, native_hotplug, true),
> > + DEFINE_PROP_BOOL("x-native-hotplug", PCIESlot, native_hotplug, true),
> > DEFINE_PROP_END_OF_LIST()
> > };
> >
> > --
> > 2.27.0
> >
> >
>
^ permalink raw reply [flat|nested] 24+ messages in thread
* Re: [PATCH for 6.2 v2 4/5] hw/i386/acpi-build: Deny control on PCIe Native Hot-plug in _OSC
2021-11-11 5:49 ` Ani Sinha
@ 2021-11-12 10:51 ` Igor Mammedov
0 siblings, 0 replies; 24+ messages in thread
From: Igor Mammedov @ 2021-11-12 10:51 UTC (permalink / raw)
To: Ani Sinha; +Cc: mapfelba, kraxel, jusual, qemu-devel, mst
On Thu, 11 Nov 2021 11:19:30 +0530 (IST)
Ani Sinha <ani@anisinha.ca> wrote:
> On Wed, 10 Nov 2021, Igor Mammedov wrote:
>
> > From: Julia Suvorova <jusual@redhat.com>
> >
> > There are two ways to enable ACPI PCI Hot-plug:
> >
> > * Disable the Hot-plug Capable bit on PCIe slots.
> >
> > This was the first approach which led to regression [1-2], as
> > I/O space for a port is allocated only when it is hot-pluggable,
> > which is determined by HPC bit.
> >
> > * Leave the HPC bit on and disable PCIe Native Hot-plug in _OSC
> > method.
> >
> > This removes the (future) ability of hot-plugging switches with PCIe
> > Native hotplug since ACPI PCI Hot-plug only works with cold-plugged
> > bridges. If the user wants to explicitely use this feature, they can
> > disable ACPI PCI Hot-plug with:
> > --global ICH9-LPC.acpi-pci-hotplug-with-bridge-support=off
> >
> > Change the bit in _OSC method so that the OS selects ACPI PCI Hot-plug
> > instead of PCIe Native.
> >
> > [1] https://gitlab.com/qemu-project/qemu/-/issues/641
> > [2] https://bugzilla.redhat.com/show_bug.cgi?id=2006409
> >
> > Signed-off-by: Julia Suvorova <jusual@redhat.com>
> > Signed-off-by: Igor Mammedov <imammedo@redhat.com>
> > ---
> > v2:
> > - (mst)
> > * drop local hotplug var and opencode it
> > * rename acpi_pcihp parameter to enable_native_pcie_hotplug
> > to reflect what it actually does
> >
> > tested:
> > with hotplugging nic into 1 root port with seabios/ovmf/Fedora34
> > Windows tested only with seabios (using exiting images)
> > (installer fails to install regardless on bios)
> > ---
> > hw/i386/acpi-build.c | 12 ++++++++----
> > 1 file changed, 8 insertions(+), 4 deletions(-)
> >
> > diff --git a/hw/i386/acpi-build.c b/hw/i386/acpi-build.c
> > index a3ad6abd33..a99c6e4fe3 100644
> > --- a/hw/i386/acpi-build.c
> > +++ b/hw/i386/acpi-build.c
> > @@ -1337,7 +1337,7 @@ static void build_x86_acpi_pci_hotplug(Aml *table, uint64_t pcihp_addr)
> > aml_append(table, scope);
> > }
> >
> > -static Aml *build_q35_osc_method(void)
> > +static Aml *build_q35_osc_method(bool enable_native_pcie_hotplug)
> > {
> > Aml *if_ctx;
> > Aml *if_ctx2;
> > @@ -1359,8 +1359,10 @@ static Aml *build_q35_osc_method(void)
> > /*
> > * Always allow native PME, AER (no dependencies)
> > * Allow SHPC (PCI bridges can have SHPC controller)
> > + * Disable PCIe Native Hot-plug if ACPI PCI Hot-plug is enabled.
> > */
>
> Based on v2, I think its more useful to have this comment where the
> function is called.
I'd leave it as is, which is consistent with other bits described here
>
> > - aml_append(if_ctx, aml_and(a_ctrl, aml_int(0x1F), a_ctrl));
> > + aml_append(if_ctx, aml_and(a_ctrl,
> > + aml_int(0x1E | (enable_native_pcie_hotplug ? 0x1 : 0x0)), a_ctrl));
> >
> > if_ctx2 = aml_if(aml_lnot(aml_equal(aml_arg(1), aml_int(1))));
> > /* Unknown revision */
> > @@ -1449,7 +1451,7 @@ build_dsdt(GArray *table_data, BIOSLinker *linker,
> > aml_append(dev, aml_name_decl("_CID", aml_eisaid("PNP0A03")));
> > aml_append(dev, aml_name_decl("_ADR", aml_int(0)));
> > aml_append(dev, aml_name_decl("_UID", aml_int(pcmc->pci_root_uid)));
> > - aml_append(dev, build_q35_osc_method());
> > + aml_append(dev, build_q35_osc_method(!pm->pcihp_bridge_en));
>
> See above. I think it helps to add a comment here saying native hotplug is
> enabled when acpi hotplug is disabled for cold plugged bridges.
>
>
> > aml_append(sb_scope, dev);
> > if (mcfg_valid) {
> > aml_append(sb_scope, build_q35_dram_controller(&mcfg));
> > @@ -1565,7 +1567,9 @@ build_dsdt(GArray *table_data, BIOSLinker *linker,
> > if (pci_bus_is_express(bus)) {
> > aml_append(dev, aml_name_decl("_HID", aml_eisaid("PNP0A08")));
> > aml_append(dev, aml_name_decl("_CID", aml_eisaid("PNP0A03")));
> > - aml_append(dev, build_q35_osc_method());
> > +
> > + /* Expander bridges do not have ACPI PCI Hot-plug enabled */
> > + aml_append(dev, build_q35_osc_method(true));
> > } else {
> > aml_append(dev, aml_name_decl("_HID", aml_eisaid("PNP0A03")));
> > }
> > --
> > 2.27.0
> >
> >
>
^ permalink raw reply [flat|nested] 24+ messages in thread
* Re: [PATCH for 6.2 v2 1/5] pcie: rename 'native-hotplug' to 'x-native-hotplug'
2021-11-12 10:47 ` Igor Mammedov
@ 2021-11-15 10:01 ` Ani Sinha
0 siblings, 0 replies; 24+ messages in thread
From: Ani Sinha @ 2021-11-15 10:01 UTC (permalink / raw)
To: Igor Mammedov
Cc: mapfelba, mst, jusual, qemu-devel, qemu-stable, kraxel, Ani Sinha
On Fri, 12 Nov 2021, Igor Mammedov wrote:
> On Thu, 11 Nov 2021 08:55:24 +0530 (IST)
> Ani Sinha <ani@anisinha.ca> wrote:
>
> > On Wed, 10 Nov 2021, Igor Mammedov wrote:
> >
> > > Mark property as experimental/internal adding 'x-' prefix.
> > >
> > > Property was introduced in 6.1 and it should have provided
> > > ability to turn on native PCIE hotplug on port even when
> > > ACPI PCI hotplug is in use is user explicitly sets property
> > > on CLI. However that never worked since slot is wired to
> > > ACPI hotplug controller.
> > > Another non-intended usecase: disable native hotplug on slot
> > > when APCI based hotplug is disabled, which works but slot has
> > > 'hotplug' property for this taks.
> > >
> > > It should be relatively safe to rename it to experimental
> > > as no users should exist for it and given that the property
> > > is broken we don't really want to leave it around for much
> > > longer lest users start using it.
> > >
> > > Signed-off-by: Igor Mammedov <imammedo@redhat.com>
> >
> > Barring the comment below,
> >
> > Reviewed-by: Ani Sinha <ani@anisinha.ca>
>
> Thanks!
>
> >
> > > ---
> > > CC: qemu-stable@nongnu.org
> > > ---
> > > hw/i386/pc_q35.c | 2 +-
> > > hw/pci/pcie_port.c | 2 +-
> > > 2 files changed, 2 insertions(+), 2 deletions(-)
> > >
> > > diff --git a/hw/i386/pc_q35.c b/hw/i386/pc_q35.c
> > > index 797e09500b..fc34b905ee 100644
> > > --- a/hw/i386/pc_q35.c
> > > +++ b/hw/i386/pc_q35.c
> > > @@ -243,7 +243,7 @@ static void pc_q35_init(MachineState *machine)
> > > NULL);
> > >
> > > if (acpi_pcihp) {
> > > - object_register_sugar_prop(TYPE_PCIE_SLOT, "native-hotplug",
> > > + object_register_sugar_prop(TYPE_PCIE_SLOT, "x-native-hotplug",
> > > "false", true);
> >
> > Let us document the fact that this property is experimental. It was not at
> > once obvious to me that an "x-" prefix meant to indicate experimental
> > status.
>
> it's common knowledge, but quick grep shows we only documented
> x- prefix for qmp commands but not for properties even though
> properties were the first to use it. So we probably should
> document it somewhere.
> I thought we have acceptable property name format documented
sadly I could not find it either.
> but I couldn't find it quickly (that would be a good place
> to document it).
> Care to post a patch?
>
> >
> >
> > > }
> > >
> > > diff --git a/hw/pci/pcie_port.c b/hw/pci/pcie_port.c
> > > index da850e8dde..e95c1e5519 100644
> > > --- a/hw/pci/pcie_port.c
> > > +++ b/hw/pci/pcie_port.c
> > > @@ -148,7 +148,7 @@ static Property pcie_slot_props[] = {
> > > DEFINE_PROP_UINT8("chassis", PCIESlot, chassis, 0),
> > > DEFINE_PROP_UINT16("slot", PCIESlot, slot, 0),
> > > DEFINE_PROP_BOOL("hotplug", PCIESlot, hotplug, true),
> > > - DEFINE_PROP_BOOL("native-hotplug", PCIESlot, native_hotplug, true),
> > > + DEFINE_PROP_BOOL("x-native-hotplug", PCIESlot, native_hotplug, true),
> > > DEFINE_PROP_END_OF_LIST()
> > > };
> > >
> > > --
> > > 2.27.0
> > >
> > >
> >
>
>
^ permalink raw reply [flat|nested] 24+ messages in thread
* Re: [PATCH for 6.2 v2 2/5] hw/acpi/ich9: Add compat prop to keep HPC bit set for 6.1 machine type
2021-11-10 21:11 ` [PATCH for 6.2 v2 2/5] hw/acpi/ich9: Add compat prop to keep HPC bit set for 6.1 machine type Igor Mammedov
@ 2021-11-15 10:05 ` Ani Sinha
2021-11-16 8:02 ` Ani Sinha
0 siblings, 1 reply; 24+ messages in thread
From: Ani Sinha @ 2021-11-15 10:05 UTC (permalink / raw)
To: Igor Mammedov; +Cc: mapfelba, mst, jusual, qemu-devel, kraxel, ani
On Wed, 10 Nov 2021, Igor Mammedov wrote:
> From: Julia Suvorova <jusual@redhat.com>
>
> To solve issues [1-2] the Hot Plug Capable bit in PCIe Slots will be
> turned on, while the switch to ACPI Hot-plug will be done in the
> DSDT table.
>
> Introducing 'x-keep-native-hpc' property disables the HPC bit only
> in 6.1 and as a result keeps the forced 'reserve-io' on
> pcie-root-ports in 6.1 too.
>
> [1] https://gitlab.com/qemu-project/qemu/-/issues/641
> [2] https://bugzilla.redhat.com/show_bug.cgi?id=2006409
>
> Signed-off-by: Julia Suvorova <jusual@redhat.com>
> Signed-off-by: Igor Mammedov <imammedo@redhat.com>
This patch is a little bit hard to read ... but ...
> ---
> v2:
> * s/native-hpc-bit/x-native-hotplug/ to fix conflict
> ---
> include/hw/acpi/ich9.h | 1 +
> hw/acpi/ich9.c | 18 ++++++++++++++++++
> hw/i386/pc.c | 2 ++
> hw/i386/pc_q35.c | 7 ++++++-
> 4 files changed, 27 insertions(+), 1 deletion(-)
>
> diff --git a/include/hw/acpi/ich9.h b/include/hw/acpi/ich9.h
> index f04f1791bd..7ca92843c6 100644
> --- a/include/hw/acpi/ich9.h
> +++ b/include/hw/acpi/ich9.h
> @@ -56,6 +56,7 @@ typedef struct ICH9LPCPMRegs {
> AcpiCpuHotplug gpe_cpu;
> CPUHotplugState cpuhp_state;
>
> + bool keep_pci_slot_hpc;
> bool use_acpi_hotplug_bridge;
> AcpiPciHpState acpi_pci_hotplug;
> MemHotplugState acpi_memory_hotplug;
> diff --git a/hw/acpi/ich9.c b/hw/acpi/ich9.c
> index 1ee2ba2c50..ebe08ed831 100644
> --- a/hw/acpi/ich9.c
> +++ b/hw/acpi/ich9.c
> @@ -419,6 +419,20 @@ static void ich9_pm_set_acpi_pci_hotplug(Object *obj, bool value, Error **errp)
> s->pm.use_acpi_hotplug_bridge = value;
> }
>
> +static bool ich9_pm_get_keep_pci_slot_hpc(Object *obj, Error **errp)
> +{
> + ICH9LPCState *s = ICH9_LPC_DEVICE(obj);
> +
> + return s->pm.keep_pci_slot_hpc;
> +}
> +
> +static void ich9_pm_set_keep_pci_slot_hpc(Object *obj, bool value, Error **errp)
> +{
> + ICH9LPCState *s = ICH9_LPC_DEVICE(obj);
> +
> + s->pm.keep_pci_slot_hpc = value;
> +}
> +
> void ich9_pm_add_properties(Object *obj, ICH9LPCPMRegs *pm)
> {
> static const uint32_t gpe0_len = ICH9_PMIO_GPE0_LEN;
> @@ -428,6 +442,7 @@ void ich9_pm_add_properties(Object *obj, ICH9LPCPMRegs *pm)
> pm->disable_s4 = 0;
> pm->s4_val = 2;
> pm->use_acpi_hotplug_bridge = true;
> + pm->keep_pci_slot_hpc = true;
>
> object_property_add_uint32_ptr(obj, ACPI_PM_PROP_PM_IO_BASE,
> &pm->pm_io_base, OBJ_PROP_FLAG_READ);
> @@ -454,6 +469,9 @@ void ich9_pm_add_properties(Object *obj, ICH9LPCPMRegs *pm)
> object_property_add_bool(obj, ACPI_PM_PROP_ACPI_PCIHP_BRIDGE,
> ich9_pm_get_acpi_pci_hotplug,
> ich9_pm_set_acpi_pci_hotplug);
> + object_property_add_bool(obj, "x-keep-pci-slot-hpc",
> + ich9_pm_get_keep_pci_slot_hpc,
> + ich9_pm_set_keep_pci_slot_hpc);
> }
>
> void ich9_pm_device_pre_plug_cb(HotplugHandler *hotplug_dev, DeviceState *dev,
> diff --git a/hw/i386/pc.c b/hw/i386/pc.c
> index 2592a82148..a2ef40ecbc 100644
> --- a/hw/i386/pc.c
> +++ b/hw/i386/pc.c
> @@ -98,6 +98,7 @@ GlobalProperty pc_compat_6_1[] = {
> { TYPE_X86_CPU, "hv-version-id-build", "0x1bbc" },
> { TYPE_X86_CPU, "hv-version-id-major", "0x0006" },
> { TYPE_X86_CPU, "hv-version-id-minor", "0x0001" },
> + { "ICH9-LPC", "x-keep-pci-slot-hpc", "false" },
> };
> const size_t pc_compat_6_1_len = G_N_ELEMENTS(pc_compat_6_1);
>
> @@ -107,6 +108,7 @@ GlobalProperty pc_compat_6_0[] = {
> { "qemu64" "-" TYPE_X86_CPU, "stepping", "3" },
> { TYPE_X86_CPU, "x-vendor-cpuid-only", "off" },
> { "ICH9-LPC", ACPI_PM_PROP_ACPI_PCIHP_BRIDGE, "off" },
> + { "ICH9-LPC", "x-keep-pci-slot-hpc", "true" },
> };
> const size_t pc_compat_6_0_len = G_N_ELEMENTS(pc_compat_6_0);
>
> diff --git a/hw/i386/pc_q35.c b/hw/i386/pc_q35.c
> index fc34b905ee..e1e100316d 100644
> --- a/hw/i386/pc_q35.c
> +++ b/hw/i386/pc_q35.c
> @@ -137,6 +137,7 @@ static void pc_q35_init(MachineState *machine)
> DriveInfo *hd[MAX_SATA_PORTS];
> MachineClass *mc = MACHINE_GET_CLASS(machine);
> bool acpi_pcihp;
> + bool keep_pci_slot_hpc;
>
> /* Check whether RAM fits below 4G (leaving 1/2 GByte for IO memory
> * and 256 Mbytes for PCI Express Enhanced Configuration Access Mapping
> @@ -242,7 +243,11 @@ static void pc_q35_init(MachineState *machine)
> ACPI_PM_PROP_ACPI_PCIHP_BRIDGE,
> NULL);
>
> - if (acpi_pcihp) {
> + keep_pci_slot_hpc = object_property_get_bool(OBJECT(lpc),
> + "x-keep-pci-slot-hpc",
> + NULL);
> +
> + if (!keep_pci_slot_hpc && acpi_pcihp) {
Does this mean we are adding "x-native-hotplug" property for pcie
slots only for 6.1 by default unless users pass x-keep-pci-slot-hpc =
false manually?
> object_register_sugar_prop(TYPE_PCIE_SLOT, "x-native-hotplug",
> "false", true);
> }
> --
> 2.27.0
>
>
^ permalink raw reply [flat|nested] 24+ messages in thread
* Re: [PATCH for 6.2 v2 2/5] hw/acpi/ich9: Add compat prop to keep HPC bit set for 6.1 machine type
2021-11-15 10:05 ` Ani Sinha
@ 2021-11-16 8:02 ` Ani Sinha
0 siblings, 0 replies; 24+ messages in thread
From: Ani Sinha @ 2021-11-16 8:02 UTC (permalink / raw)
To: Igor Mammedov; +Cc: mapfelba, kraxel, jusual, qemu-devel, mst
On Mon, Nov 15, 2021 at 3:35 PM Ani Sinha <ani@anisinha.ca> wrote:
>
>
>
> On Wed, 10 Nov 2021, Igor Mammedov wrote:
>
> > From: Julia Suvorova <jusual@redhat.com>
> >
> > To solve issues [1-2] the Hot Plug Capable bit in PCIe Slots will be
> > turned on, while the switch to ACPI Hot-plug will be done in the
> > DSDT table.
> >
> > Introducing 'x-keep-native-hpc' property disables the HPC bit only
> > in 6.1 and as a result keeps the forced 'reserve-io' on
> > pcie-root-ports in 6.1 too.
> >
> > [1] https://gitlab.com/qemu-project/qemu/-/issues/641
> > [2] https://bugzilla.redhat.com/show_bug.cgi?id=2006409
> >
> > Signed-off-by: Julia Suvorova <jusual@redhat.com>
> > Signed-off-by: Igor Mammedov <imammedo@redhat.com>
>
> This patch is a little bit hard to read ... but ...
>
> > ---
> > v2:
> > * s/native-hpc-bit/x-native-hotplug/ to fix conflict
> > ---
> > include/hw/acpi/ich9.h | 1 +
> > hw/acpi/ich9.c | 18 ++++++++++++++++++
> > hw/i386/pc.c | 2 ++
> > hw/i386/pc_q35.c | 7 ++++++-
> > 4 files changed, 27 insertions(+), 1 deletion(-)
> >
> > diff --git a/include/hw/acpi/ich9.h b/include/hw/acpi/ich9.h
> > index f04f1791bd..7ca92843c6 100644
> > --- a/include/hw/acpi/ich9.h
> > +++ b/include/hw/acpi/ich9.h
> > @@ -56,6 +56,7 @@ typedef struct ICH9LPCPMRegs {
> > AcpiCpuHotplug gpe_cpu;
> > CPUHotplugState cpuhp_state;
> >
> > + bool keep_pci_slot_hpc;
> > bool use_acpi_hotplug_bridge;
> > AcpiPciHpState acpi_pci_hotplug;
> > MemHotplugState acpi_memory_hotplug;
> > diff --git a/hw/acpi/ich9.c b/hw/acpi/ich9.c
> > index 1ee2ba2c50..ebe08ed831 100644
> > --- a/hw/acpi/ich9.c
> > +++ b/hw/acpi/ich9.c
> > @@ -419,6 +419,20 @@ static void ich9_pm_set_acpi_pci_hotplug(Object *obj, bool value, Error **errp)
> > s->pm.use_acpi_hotplug_bridge = value;
> > }
> >
> > +static bool ich9_pm_get_keep_pci_slot_hpc(Object *obj, Error **errp)
> > +{
> > + ICH9LPCState *s = ICH9_LPC_DEVICE(obj);
> > +
> > + return s->pm.keep_pci_slot_hpc;
> > +}
> > +
> > +static void ich9_pm_set_keep_pci_slot_hpc(Object *obj, bool value, Error **errp)
> > +{
> > + ICH9LPCState *s = ICH9_LPC_DEVICE(obj);
> > +
> > + s->pm.keep_pci_slot_hpc = value;
> > +}
> > +
> > void ich9_pm_add_properties(Object *obj, ICH9LPCPMRegs *pm)
> > {
> > static const uint32_t gpe0_len = ICH9_PMIO_GPE0_LEN;
> > @@ -428,6 +442,7 @@ void ich9_pm_add_properties(Object *obj, ICH9LPCPMRegs *pm)
> > pm->disable_s4 = 0;
> > pm->s4_val = 2;
> > pm->use_acpi_hotplug_bridge = true;
> > + pm->keep_pci_slot_hpc = true;
> >
> > object_property_add_uint32_ptr(obj, ACPI_PM_PROP_PM_IO_BASE,
> > &pm->pm_io_base, OBJ_PROP_FLAG_READ);
> > @@ -454,6 +469,9 @@ void ich9_pm_add_properties(Object *obj, ICH9LPCPMRegs *pm)
> > object_property_add_bool(obj, ACPI_PM_PROP_ACPI_PCIHP_BRIDGE,
> > ich9_pm_get_acpi_pci_hotplug,
> > ich9_pm_set_acpi_pci_hotplug);
> > + object_property_add_bool(obj, "x-keep-pci-slot-hpc",
> > + ich9_pm_get_keep_pci_slot_hpc,
> > + ich9_pm_set_keep_pci_slot_hpc);
> > }
> >
> > void ich9_pm_device_pre_plug_cb(HotplugHandler *hotplug_dev, DeviceState *dev,
> > diff --git a/hw/i386/pc.c b/hw/i386/pc.c
> > index 2592a82148..a2ef40ecbc 100644
> > --- a/hw/i386/pc.c
> > +++ b/hw/i386/pc.c
> > @@ -98,6 +98,7 @@ GlobalProperty pc_compat_6_1[] = {
> > { TYPE_X86_CPU, "hv-version-id-build", "0x1bbc" },
> > { TYPE_X86_CPU, "hv-version-id-major", "0x0006" },
> > { TYPE_X86_CPU, "hv-version-id-minor", "0x0001" },
> > + { "ICH9-LPC", "x-keep-pci-slot-hpc", "false" },
> > };
> > const size_t pc_compat_6_1_len = G_N_ELEMENTS(pc_compat_6_1);
> >
> > @@ -107,6 +108,7 @@ GlobalProperty pc_compat_6_0[] = {
> > { "qemu64" "-" TYPE_X86_CPU, "stepping", "3" },
> > { TYPE_X86_CPU, "x-vendor-cpuid-only", "off" },
> > { "ICH9-LPC", ACPI_PM_PROP_ACPI_PCIHP_BRIDGE, "off" },
> > + { "ICH9-LPC", "x-keep-pci-slot-hpc", "true" },
> > };
> > const size_t pc_compat_6_0_len = G_N_ELEMENTS(pc_compat_6_0);
> >
> > diff --git a/hw/i386/pc_q35.c b/hw/i386/pc_q35.c
> > index fc34b905ee..e1e100316d 100644
> > --- a/hw/i386/pc_q35.c
> > +++ b/hw/i386/pc_q35.c
> > @@ -137,6 +137,7 @@ static void pc_q35_init(MachineState *machine)
> > DriveInfo *hd[MAX_SATA_PORTS];
> > MachineClass *mc = MACHINE_GET_CLASS(machine);
> > bool acpi_pcihp;
> > + bool keep_pci_slot_hpc;
> >
> > /* Check whether RAM fits below 4G (leaving 1/2 GByte for IO memory
> > * and 256 Mbytes for PCI Express Enhanced Configuration Access Mapping
> > @@ -242,7 +243,11 @@ static void pc_q35_init(MachineState *machine)
> > ACPI_PM_PROP_ACPI_PCIHP_BRIDGE,
> > NULL);
> >
> > - if (acpi_pcihp) {
> > + keep_pci_slot_hpc = object_property_get_bool(OBJECT(lpc),
> > + "x-keep-pci-slot-hpc",
> > + NULL);
> > +
> > + if (!keep_pci_slot_hpc && acpi_pcihp) {
>
> Does this mean we are adding "x-native-hotplug" property for pcie
> slots only for 6.1 by default unless users pass x-keep-pci-slot-hpc =
> false manually?
Ok I get this now. Previously, we were disabling Hot-plug capable
(HPC) bit for PCIE slots unconditionally when ACPI hotplug was
enabled. Now, we do this only for 6.1. For 6.0 and 6.2 and above, we
keep HPC bit ON *but* disable native hotplug advertisement from ACPI
OSC method. The OSC advertisement change is only for 6.2 and above. So
basically if I am not mistaken, we keep 6.1 behavior unchanged.
Am I getting all the parts right?
>
> > object_register_sugar_prop(TYPE_PCIE_SLOT, "x-native-hotplug",
> > "false", true);
> > }
> > --
> > 2.27.0
> >
> >
^ permalink raw reply [flat|nested] 24+ messages in thread
end of thread, other threads:[~2021-11-16 8:04 UTC | newest]
Thread overview: 24+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-11-10 21:11 [PATCH for 6.2 v2 0/5] Fix Q35 ACPI PCI Hot-plug I/O issues Igor Mammedov
2021-11-10 21:11 ` [PATCH for 6.2 v2 1/5] pcie: rename 'native-hotplug' to 'x-native-hotplug' Igor Mammedov
2021-11-11 3:25 ` Ani Sinha
2021-11-12 10:47 ` Igor Mammedov
2021-11-15 10:01 ` Ani Sinha
2021-11-10 21:11 ` [PATCH for 6.2 v2 2/5] hw/acpi/ich9: Add compat prop to keep HPC bit set for 6.1 machine type Igor Mammedov
2021-11-15 10:05 ` Ani Sinha
2021-11-16 8:02 ` Ani Sinha
2021-11-10 21:11 ` [PATCH for 6.2 v2 3/5] bios-tables-test: Allow changes in DSDT ACPI tables Igor Mammedov
2021-11-11 5:55 ` Ani Sinha
2021-11-10 21:11 ` [PATCH for 6.2 v2 4/5] hw/i386/acpi-build: Deny control on PCIe Native Hot-plug in _OSC Igor Mammedov
2021-11-11 5:49 ` Ani Sinha
2021-11-12 10:51 ` Igor Mammedov
2021-11-10 21:11 ` [PATCH for 6.2 v2 5/5] bios-tables-test: Update golden binaries Igor Mammedov
2021-11-11 5:51 ` Ani Sinha
2021-11-11 8:34 ` Michael S. Tsirkin
2021-11-11 9:27 ` Ani Sinha
2021-11-11 9:44 ` Ani Sinha
2021-11-12 8:56 ` Ani Sinha
2021-11-11 11:32 ` Igor Mammedov
2021-11-11 13:47 ` Thomas Lamprecht
2021-11-11 15:31 ` Michael S. Tsirkin
2021-11-12 9:47 ` [PATCH for 6.2 v2 0/5] Fix Q35 ACPI PCI Hot-plug I/O issues Michael S. Tsirkin
2021-11-12 10:17 ` Igor Mammedov
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).