From: Laszlo Ersek <lersek@redhat.com>
To: Andrew Jones <drjones@redhat.com>, Igor Mammedov <imammedo@redhat.com>
Cc: peter.maydell@linaro.org, ard.biesheuvel@arm.com,
"Michael S. Tsirkin" <mst@redhat.com>,
qemu-devel@nongnu.org, shannon.zhaosl@gmail.com,
qemu-arm@nongnu.org, eric.auger@redhat.com, philmd@redhat.com
Subject: Re: [PATCH 3/4] hw/arm/virt-acpi-build: Only expose flash on older machine types
Date: Wed, 15 Jul 2020 14:26:19 +0200 [thread overview]
Message-ID: <b1593635-54aa-fd8c-951d-c2ef648ec6c9@redhat.com> (raw)
In-Reply-To: <20200715063648.rigcdnaxveened6u@kamzik.brq.redhat.com>
Hi Drew,
On 07/15/20 08:36, Andrew Jones wrote:
> So it sounds to me like we have some flexibility in our versioned machine
> maintenance. We can choose to forgo the usual compat code when the risk is
> deemed low enough. And, if somebody screams, we can always fix it later.
> I can live with that. I'll go ahead and respin without the versioning.
In that case, please don't simply remove the acpi_dsdt_add_flash() call
from build_dsdt(), because then "git blame" won't be able to help later.
Can you please replace the call with a comment instead, similar to the
RTC comment from commit 67736a25f865 ("ARM: virt: Don't generate RTC
ACPI device when using UEFI", 2016-01-15)?
Thanks!
Laszlo
next prev parent reply other threads:[~2020-07-15 12:27 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-29 14:09 [PATCH 0/4] hw/arm/virt-acpi-build: Only expose flash on older machine types Andrew Jones
2020-06-29 14:09 ` [PATCH 1/4] tests/acpi: remove stale allowed tables Andrew Jones
2020-06-29 15:06 ` Michael S. Tsirkin
2020-06-29 14:09 ` [PATCH 2/4] tests/acpi: virt: allow DSDT acpi table changes Andrew Jones
2020-06-29 14:09 ` [PATCH 3/4] hw/arm/virt-acpi-build: Only expose flash on older machine types Andrew Jones
2020-06-29 14:18 ` Philippe Mathieu-Daudé
2020-07-02 9:48 ` Laszlo Ersek
2020-07-02 9:53 ` Michael S. Tsirkin
2020-07-02 10:16 ` Peter Maydell
2020-07-02 11:13 ` Michael S. Tsirkin
2020-07-13 8:49 ` Igor Mammedov
2020-07-14 5:51 ` Andrew Jones
2020-07-14 8:57 ` Michael S. Tsirkin
2020-07-14 9:23 ` Andrew Jones
2020-07-14 9:31 ` Michael S. Tsirkin
2020-07-14 14:41 ` Igor Mammedov
2020-07-15 6:36 ` Andrew Jones
2020-07-15 9:37 ` Andrew Jones
2020-07-15 12:26 ` Laszlo Ersek [this message]
2020-07-15 13:05 ` Andrew Jones
2020-06-29 14:09 ` [PATCH 4/4] tests/acpi: virt: update golden masters for DSDT Andrew Jones
2020-07-02 9:49 ` Laszlo Ersek
2020-06-29 15:21 ` [PATCH 0/4] hw/arm/virt-acpi-build: Only expose flash on older machine types Michael S. Tsirkin
2020-07-02 19:26 ` Auger Eric
2020-07-03 13:02 ` Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b1593635-54aa-fd8c-951d-c2ef648ec6c9@redhat.com \
--to=lersek@redhat.com \
--cc=ard.biesheuvel@arm.com \
--cc=drjones@redhat.com \
--cc=eric.auger@redhat.com \
--cc=imammedo@redhat.com \
--cc=mst@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=philmd@redhat.com \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=shannon.zhaosl@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).