From: Eric Blake <eblake@redhat.com>
To: John Snow <jsnow@redhat.com>,
qemu-block@nongnu.org, qemu-devel@nongnu.org
Cc: Fam Zheng <fam@euphon.net>, Kevin Wolf <kwolf@redhat.com>,
vsementsov@virtuozzo.com, aihua liang <aliang@redhat.com>,
Markus Armbruster <armbru@redhat.com>,
Max Reitz <mreitz@redhat.com>
Subject: Re: [PATCH 0/5] block/dirty-bitmap: check number and size constraints against queued bitmaps
Date: Wed, 9 Oct 2019 13:57:12 -0500 [thread overview]
Message-ID: <ba9b72f0-42b4-f295-78e4-454cc2992346@redhat.com> (raw)
In-Reply-To: <20190606184159.979-1-jsnow@redhat.com>
On 6/6/19 1:41 PM, John Snow wrote:
> When adding new persistent dirty bitmaps, we only check constraints
> against currently stored bitmaps, and ignore the pending number and size
> of any bitmaps yet to be stored.
>
> Rework the "can_store" and "remove" interface to explicit "add" and "remove",
> and begin keeping track of the queued burden when adding new bitmaps.
>
> Reported-by: aihua liang <aliang@redhat.com>
> Fixes: https://bugzilla.redhat.com/show_bug.cgi?id=1712636
>
> John Snow (5):
> block/qcow2-bitmap: allow bitmap_list_load to return an error code
> block/dirty-bitmap: Refactor bdrv_can_store_new_bitmap
> block/dirty-bitmap: rework bdrv_remove_persistent_dirty_bitmap
> block/qcow2-bitmap: Count queued bitmaps towards nb_bitmaps
> block/qcow2-bitmap: Count queued bitmaps towards directory_size
Is this series worth reviving as a v2, as it solves a corner-case bug?
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3226
Virtualization: qemu.org | libvirt.org
next prev parent reply other threads:[~2019-10-09 21:08 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-06 18:41 [Qemu-devel] [PATCH 0/5] block/dirty-bitmap: check number and size constraints against queued bitmaps John Snow
2019-06-06 18:41 ` [Qemu-devel] [PATCH 1/5] block/qcow2-bitmap: allow bitmap_list_load to return an error code John Snow
2019-06-07 2:07 ` Eric Blake
2019-06-07 12:36 ` Vladimir Sementsov-Ogievskiy
2019-06-06 18:41 ` [Qemu-devel] [PATCH 2/5] block/dirty-bitmap: Refactor bdrv_can_store_new_bitmap John Snow
2019-06-07 2:16 ` Eric Blake
2019-06-07 14:29 ` Vladimir Sementsov-Ogievskiy
2019-06-07 18:10 ` John Snow
2019-06-07 18:15 ` Eric Blake
2019-06-07 18:17 ` Vladimir Sementsov-Ogievskiy
2019-06-07 18:23 ` Vladimir Sementsov-Ogievskiy
2019-06-07 22:08 ` John Snow
2019-06-10 9:29 ` Vladimir Sementsov-Ogievskiy
2019-06-06 18:41 ` [Qemu-devel] [PATCH 3/5] block/dirty-bitmap: rework bdrv_remove_persistent_dirty_bitmap John Snow
2019-06-07 2:24 ` Eric Blake
2019-06-07 14:41 ` Vladimir Sementsov-Ogievskiy
2019-06-07 18:16 ` John Snow
2019-06-06 18:41 ` [Qemu-devel] [PATCH 4/5] block/qcow2-bitmap: Count queued bitmaps towards nb_bitmaps John Snow
2019-06-07 2:27 ` Eric Blake
2019-06-07 18:04 ` John Snow
2019-06-07 14:58 ` Vladimir Sementsov-Ogievskiy
2019-06-07 18:24 ` John Snow
2019-06-06 18:41 ` [Qemu-devel] [PATCH 5/5] block/qcow2-bitmap: Count queued bitmaps towards directory_size John Snow
2019-06-07 2:30 ` Eric Blake
2019-06-07 19:24 ` John Snow
2019-06-06 21:54 ` [Qemu-devel] [PATCH 0/5] block/dirty-bitmap: check number and size constraints against queued bitmaps no-reply
2019-06-06 22:26 ` John Snow
2019-10-09 18:57 ` Eric Blake [this message]
2019-10-09 20:44 ` John Snow
2019-10-10 6:23 ` Vladimir Sementsov-Ogievskiy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ba9b72f0-42b4-f295-78e4-454cc2992346@redhat.com \
--to=eblake@redhat.com \
--cc=aliang@redhat.com \
--cc=armbru@redhat.com \
--cc=fam@euphon.net \
--cc=jsnow@redhat.com \
--cc=kwolf@redhat.com \
--cc=mreitz@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=vsementsov@virtuozzo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).