* [PATCH 04/12] scsi: Remove superfluous breaks
@ 2020-07-13 9:04 Yi Wang
2020-07-13 9:33 ` Thomas Huth
0 siblings, 1 reply; 3+ messages in thread
From: Yi Wang @ 2020-07-13 9:04 UTC (permalink / raw)
To: qemu-devel; +Cc: wang.yi59, Liao Pingfang, wang.liang82, xue.zhihong
From: Liao Pingfang <liao.pingfang@zte.com.cn>
Remove superfluous breaks, as there is a "return" before them.
Signed-off-by: Liao Pingfang <liao.pingfang@zte.com.cn>
Signed-off-by: Yi Wang <wang.yi59@zte.com.cn>
Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
---
scsi/utils.c | 4 ----
1 file changed, 4 deletions(-)
diff --git a/scsi/utils.c b/scsi/utils.c
index c50e81f..b37c283 100644
--- a/scsi/utils.c
+++ b/scsi/utils.c
@@ -32,17 +32,13 @@ uint32_t scsi_cdb_xfer(uint8_t *buf)
switch (buf[0] >> 5) {
case 0:
return buf[4];
- break;
case 1:
case 2:
return lduw_be_p(&buf[7]);
- break;
case 4:
return ldl_be_p(&buf[10]) & 0xffffffffULL;
- break;
case 5:
return ldl_be_p(&buf[6]) & 0xffffffffULL;
- break;
default:
return -1;
}
--
2.9.5
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH 04/12] scsi: Remove superfluous breaks
2020-07-13 9:04 [PATCH 04/12] scsi: Remove superfluous breaks Yi Wang
@ 2020-07-13 9:33 ` Thomas Huth
2020-09-01 6:35 ` Laurent Vivier
0 siblings, 1 reply; 3+ messages in thread
From: Thomas Huth @ 2020-07-13 9:33 UTC (permalink / raw)
To: Yi Wang, qemu-devel
Cc: xue.zhihong, QEMU Trivial, wang.liang82, Liao Pingfang, Paolo Bonzini
On 13/07/2020 11.04, Yi Wang wrote:
> From: Liao Pingfang <liao.pingfang@zte.com.cn>
>
> Remove superfluous breaks, as there is a "return" before them.
>
> Signed-off-by: Liao Pingfang <liao.pingfang@zte.com.cn>
> Signed-off-by: Yi Wang <wang.yi59@zte.com.cn>
> Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
> ---
> scsi/utils.c | 4 ----
> 1 file changed, 4 deletions(-)
>
> diff --git a/scsi/utils.c b/scsi/utils.c
> index c50e81f..b37c283 100644
> --- a/scsi/utils.c
> +++ b/scsi/utils.c
> @@ -32,17 +32,13 @@ uint32_t scsi_cdb_xfer(uint8_t *buf)
> switch (buf[0] >> 5) {
> case 0:
> return buf[4];
> - break;
> case 1:
> case 2:
> return lduw_be_p(&buf[7]);
> - break;
> case 4:
> return ldl_be_p(&buf[10]) & 0xffffffffULL;
> - break;
> case 5:
> return ldl_be_p(&buf[6]) & 0xffffffffULL;
> - break;
> default:
> return -1;
> }
>
Reviewed-by: Thomas Huth <thuth@redhat.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH 04/12] scsi: Remove superfluous breaks
2020-07-13 9:33 ` Thomas Huth
@ 2020-09-01 6:35 ` Laurent Vivier
0 siblings, 0 replies; 3+ messages in thread
From: Laurent Vivier @ 2020-09-01 6:35 UTC (permalink / raw)
To: Thomas Huth, Yi Wang, qemu-devel
Cc: QEMU Trivial, Paolo Bonzini, Liao Pingfang, wang.liang82, xue.zhihong
Le 13/07/2020 à 11:33, Thomas Huth a écrit :
> On 13/07/2020 11.04, Yi Wang wrote:
>> From: Liao Pingfang <liao.pingfang@zte.com.cn>
>>
>> Remove superfluous breaks, as there is a "return" before them.
>>
>> Signed-off-by: Liao Pingfang <liao.pingfang@zte.com.cn>
>> Signed-off-by: Yi Wang <wang.yi59@zte.com.cn>
>> Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
>> ---
>> scsi/utils.c | 4 ----
>> 1 file changed, 4 deletions(-)
>>
>> diff --git a/scsi/utils.c b/scsi/utils.c
>> index c50e81f..b37c283 100644
>> --- a/scsi/utils.c
>> +++ b/scsi/utils.c
>> @@ -32,17 +32,13 @@ uint32_t scsi_cdb_xfer(uint8_t *buf)
>> switch (buf[0] >> 5) {
>> case 0:
>> return buf[4];
>> - break;
>> case 1:
>> case 2:
>> return lduw_be_p(&buf[7]);
>> - break;
>> case 4:
>> return ldl_be_p(&buf[10]) & 0xffffffffULL;
>> - break;
>> case 5:
>> return ldl_be_p(&buf[6]) & 0xffffffffULL;
>> - break;
>> default:
>> return -1;
>> }
>>
>
> Reviewed-by: Thomas Huth <thuth@redhat.com>
>
>
Applied to my trivial-patches branch.
Thanks,
Laurent
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-09-01 6:36 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-07-13 9:04 [PATCH 04/12] scsi: Remove superfluous breaks Yi Wang
2020-07-13 9:33 ` Thomas Huth
2020-09-01 6:35 ` Laurent Vivier
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).