* [PATCH v2] qobject: json-streamer: Change bracket_count to brace_count
@ 2020-04-02 17:19 Simran Singhal
2020-04-02 17:44 ` Eric Blake
0 siblings, 1 reply; 2+ messages in thread
From: Simran Singhal @ 2020-04-02 17:19 UTC (permalink / raw)
To: qemu-devel, Markus Armbruster; +Cc: Stefan Hajnoczi, Julia Suvorova
Change the "parser->bracket_count >= 0" to "parser->brace_count >= 0"
to fix the typo.
Signed-off-by: Simran Singhal <singhalsimran0@gmail.com>
---
Changes in v2:
-No need to remove the duplicate occurence of "parser->bracket_count >= 0"
but actually it is a typo and one occurence should be "parser->brace_count >= 0".
qobject/json-streamer.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/qobject/json-streamer.c b/qobject/json-streamer.c
index 47dd7ea576..b93d97b995 100644
--- a/qobject/json-streamer.c
+++ b/qobject/json-streamer.c
@@ -85,7 +85,7 @@ void json_message_process_token(JSONLexer *lexer, GString *input,
g_queue_push_tail(&parser->tokens, token);
if ((parser->brace_count > 0 || parser->bracket_count > 0)
- && parser->bracket_count >= 0 && parser->bracket_count >= 0) {
+ && parser->brace_count >= 0 && parser->bracket_count >= 0) {
return;
}
--
2.17.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH v2] qobject: json-streamer: Change bracket_count to brace_count
2020-04-02 17:19 [PATCH v2] qobject: json-streamer: Change bracket_count to brace_count Simran Singhal
@ 2020-04-02 17:44 ` Eric Blake
0 siblings, 0 replies; 2+ messages in thread
From: Eric Blake @ 2020-04-02 17:44 UTC (permalink / raw)
To: Simran Singhal, qemu-devel, Markus Armbruster
Cc: Stefan Hajnoczi, Julia Suvorova
On 4/2/20 12:19 PM, Simran Singhal wrote:
> Change the "parser->bracket_count >= 0" to "parser->brace_count >= 0"
> to fix the typo.
>
> Signed-off-by: Simran Singhal <singhalsimran0@gmail.com>
Please add:
Fixes: 8d3265b3
at which point you can also add:
Reviewed-by: Eric Blake <eblake@redhat.com>
> ---
> Changes in v2:
> -No need to remove the duplicate occurence of "parser->bracket_count >= 0"
> but actually it is a typo and one occurence should be "parser->brace_count >= 0".
occurrence (but at least this typo won't make it into git)
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3226
Virtualization: qemu.org | libvirt.org
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-04-02 17:46 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-04-02 17:19 [PATCH v2] qobject: json-streamer: Change bracket_count to brace_count Simran Singhal
2020-04-02 17:44 ` Eric Blake
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).