From: Claudio Fontana <cfontana@suse.de>
To: qemu-devel@nongnu.org
Cc: lvivier@redhat.com, peter.maydell@linaro.org, thuth@redhat.com,
ehabkost@redhat.com, philmd@redhat.com, mtosatti@redhat.com,
r.bolshakov@yadro.com, wenchao.wang@intel.com,
haxm-team@intel.com, colin.xu@intel.com, pbonzini@redhat.com,
sunilmut@microsoft.com, alex.bennee@linaro.org, rth@twiddle.net
Subject: Re: [RFC v3 0/4] QEMU cpus.c refactoring
Date: Tue, 26 May 2020 14:57:55 +0200 [thread overview]
Message-ID: <bf1987f6-c21f-d7dd-8be8-00eba1bc1bda@suse.de> (raw)
In-Reply-To: <159044748030.3999.4835684679891787464@45ef0f9c86ae>
Some comments on patchew output:
On 5/26/20 12:58 AM, no-reply@patchew.org wrote:
> Patchew URL: https://patchew.org/QEMU/20200525145440.29728-1-cfontana@suse.de/
>
>
>
> Hi,
>
> This series seems to have some coding style problems. See output below for
> more information:
>
> Message-id: 20200525145440.29728-1-cfontana@suse.de
> Subject: [RFC v3 0/4] QEMU cpus.c refactoring
> Type: series
>
> === TEST SCRIPT BEGIN ===
> #!/bin/bash
> git rev-parse base > /dev/null || exit 0
> git config --local diff.renamelimit 0
> git config --local diff.renames True
> git config --local diff.algorithm histogram
> ./scripts/checkpatch.pl --mailback base..
> === TEST SCRIPT END ===
>
> Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
> From https://github.com/patchew-project/qemu
> - [tag update] patchew/20200525111001.8147-1-f4bug@amsat.org -> patchew/20200525111001.8147-1-f4bug@amsat.org
> Switched to a new branch 'test'
> 0f5db0e cpus: extract out accel-specific code to each accel
> 1b135cf cpu-timers, icount: new modules
> cb5c834 cpu-throttle: new module, extracted from cpus.c
> 3d5a04d softmmu: move softmmu only files from root
>
> === OUTPUT BEGIN ===
> 1/4 Checking commit 3d5a04d99492 (softmmu: move softmmu only files from root)
> WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
> #112:
> rename from arch_init.c
>
> total: 0 errors, 1 warnings, 77 lines checked
I am not sure who the maintainer of arch_init would be.
get_maintainer.pl: No maintainers found, printing recent contributors.
>
> Patch 1/4 has style problems, please review. If any of these errors
> are false positives report them to the maintainer, see
> CHECKPATCH in MAINTAINERS.
> 2/4 Checking commit cb5c834770dd (cpu-throttle: new module, extracted from cpus.c)
> WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
> #110:
> new file mode 100644
>
> total: 0 errors, 1 warnings, 386 lines checked
I assumed this would be Paolo, since he maintains related components (and the cpus.c it came from)
>
> Patch 2/4 has style problems, please review. If any of these errors
> are false positives report them to the maintainer, see
> CHECKPATCH in MAINTAINERS.
> 3/4 Checking commit 1b135cfa40c8 (cpu-timers, icount: new modules)
> WARNING: line over 80 characters
> #94: FILE: accel/tcg/cpu-exec.c:107:
> + qemu_printf("Warning: The guest is now late by %.1f to %.1f seconds\n",
Here I would ignore the warning for the benefit of readability of the printf string.
>
> ERROR: line over 90 characters
> #265: FILE: hw/core/ptimer.c:137:
> + if (s->enabled == 1 && (delta * period < 10000) && !icount_enabled() && !qtest_enabled()) {
this I should fix
>
> ERROR: line over 90 characters
> #274: FILE: hw/core/ptimer.c:220:
> + if (!oneshot && (s->delta * period < 10000) && !icount_enabled() && !qtest_enabled()) {
>
this I should fix
> WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
> #384:
> new file mode 100644
>
> total: 2 errors, 2 warnings, 2331 lines checked
>
> Patch 3/4 has style problems, please review. If any of these errors
> are false positives report them to the maintainer, see
> CHECKPATCH in MAINTAINERS.
>
> 4/4 Checking commit 0f5db0e76127 (cpus: extract out accel-specific code to each accel)
> WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
> #86:
> new file mode 100644
>
> total: 0 errors, 1 warnings, 2463 lines checked
>
> Patch 4/4 has style problems, please review. If any of these errors
> are false positives report them to the maintainer, see
> CHECKPATCH in MAINTAINERS.
> === OUTPUT END ===
I am adding the new accelerator interfaces to the respective accelerator maintainers.
>
> Test command exited with code: 1
>
>
> The full log is available at
> http://patchew.org/logs/20200525145440.29728-1-cfontana@suse.de/testing.checkpatch/?type=message.
> ---
> Email generated automatically by Patchew [https://patchew.org/].
> Please send your feedback to patchew-devel@redhat.com
>
prev parent reply other threads:[~2020-05-26 12:58 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-25 14:54 [RFC v3 0/4] QEMU cpus.c refactoring Claudio Fontana
2020-05-25 14:54 ` [RFC v3 1/4] softmmu: move softmmu only files from root Claudio Fontana
2020-05-25 15:12 ` Philippe Mathieu-Daudé
2020-05-25 15:37 ` Claudio Fontana
2020-05-25 17:32 ` Philippe Mathieu-Daudé
2020-05-25 14:54 ` [RFC v3 2/4] cpu-throttle: new module, extracted from cpus.c Claudio Fontana
2020-05-25 15:14 ` Philippe Mathieu-Daudé
2020-05-25 15:42 ` Claudio Fontana
2020-05-25 14:54 ` [RFC v3 3/4] cpu-timers, icount: new modules Claudio Fontana
2020-05-25 15:16 ` Philippe Mathieu-Daudé
2020-05-25 15:43 ` Claudio Fontana
2020-05-25 14:54 ` [RFC v3 4/4] cpus: extract out accel-specific code to each accel Claudio Fontana
2020-05-25 15:22 ` Philippe Mathieu-Daudé
2020-05-25 15:37 ` Claudio Fontana
2020-05-26 19:16 ` Roman Bolshakov
2020-05-27 13:42 ` Claudio Fontana
2020-05-25 22:58 ` [RFC v3 0/4] QEMU cpus.c refactoring no-reply
2020-05-26 12:57 ` Claudio Fontana [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bf1987f6-c21f-d7dd-8be8-00eba1bc1bda@suse.de \
--to=cfontana@suse.de \
--cc=alex.bennee@linaro.org \
--cc=colin.xu@intel.com \
--cc=ehabkost@redhat.com \
--cc=haxm-team@intel.com \
--cc=lvivier@redhat.com \
--cc=mtosatti@redhat.com \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=philmd@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=r.bolshakov@yadro.com \
--cc=rth@twiddle.net \
--cc=sunilmut@microsoft.com \
--cc=thuth@redhat.com \
--cc=wenchao.wang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).