From: "Philippe Mathieu-Daudé" <philmd@redhat.com>
To: "Claudio Fontana" <cfontana@suse.de>,
"Paolo Bonzini" <pbonzini@redhat.com>,
"Thomas Huth" <thuth@redhat.com>,
"Alex Bennée" <alex.bennee@linaro.org>,
"Peter Maydell" <peter.maydell@linaro.org>
Cc: Laurent Vivier <lvivier@redhat.com>,
Eduardo Habkost <ehabkost@redhat.com>,
Marcelo Tosatti <mtosatti@redhat.com>,
qemu-devel@nongnu.org, Roman Bolshakov <r.bolshakov@yadro.com>,
haxm-team@intel.com, Wenchao Wang <wenchao.wang@intel.com>,
Sunil Muthuswamy <sunilmut@microsoft.com>,
Richard Henderson <rth@twiddle.net>,
Colin Xu <colin.xu@intel.com>
Subject: Re: [RFC v3 1/4] softmmu: move softmmu only files from root
Date: Mon, 25 May 2020 19:32:49 +0200 [thread overview]
Message-ID: <cce25784-949f-38eb-e380-fdbe5d7d8c53@redhat.com> (raw)
In-Reply-To: <f886b539-6dcf-80b3-6cbc-8b6e7ed26109@suse.de>
On 5/25/20 5:37 PM, Claudio Fontana wrote:
> On 5/25/20 5:12 PM, Philippe Mathieu-Daudé wrote:
>> On 5/25/20 4:54 PM, Claudio Fontana wrote:
>>> move arch_init, balloon, cpus, ioport, memory, memory_mapping, qtest.
>>>
>>> They are all specific to CONFIG_SOFTMMU.
>>>
>>> Signed-off-by: Claudio Fontana <cfontana@suse.de>
>>> ---
>>> MAINTAINERS | 12 ++++++------
>>> Makefile.target | 7 ++-----
>>> softmmu/Makefile.objs | 10 ++++++++++
>>> arch_init.c => softmmu/arch_init.c | 0
>>
>> OK.
>>
>>> balloon.c => softmmu/balloon.c | 0
>>
>> OK
>>
>>> cpus.c => softmmu/cpus.c | 0
>>
>> I'm still not 100% convinced.
>
> Hi Philippe, do you see a reason to keep cpus.c in the top_srcdir?
>
> The way I see it, it belongs in softmmu/,
>
> we have a separate cpu-common.c that is target-indep and in common between user and softmmu,
> while cpus.c is softmmu-only right?
Sorry, I meant to say I need to look more in details at this file uses
and will do a second review pass on your series.
>
>
>>
>>> ioport.c => softmmu/ioport.c | 0
>>
>> OK
>>
>>> memory.c => softmmu/memory.c | 0
>>
>> OK
>>
>>> memory_mapping.c => softmmu/memory_mapping.c | 0
>>
>> I am not sure (yet).
>
> headers are already in sysemu (sysemu/memory_mapping.h)
>
>>
>>> qtest.c => softmmu/qtest.c | 0
>>
>> This one seems to belong to accel/
>
> We already have accel/qtest.c , that is the qtest AccelClass.
>
> Here we are talking about qtest.c from the top_srcdir, which it the
> qtest server and is built with softmmu code, with header in sysemu/qtest.h
I haven't looked at it in detail but will.
>
> Thomas?
>
>>> 10 files changed, 18 insertions(+), 11 deletions(-)
>>> rename arch_init.c => softmmu/arch_init.c (100%)
>>> rename balloon.c => softmmu/balloon.c (100%)
>>> rename cpus.c => softmmu/cpus.c (100%)
>>> rename ioport.c => softmmu/ioport.c (100%)
>>> rename memory.c => softmmu/memory.c (100%)
>>> rename memory_mapping.c => softmmu/memory_mapping.c (100%)
>>> rename qtest.c => softmmu/qtest.c (100%)
>>
>> What about the corresponding headers?
>
> headers already in sysemu/ :
>
> sysemu/arch_init.h
> sysemu/balloon.h
> sysemu/cpus.h
> sysemu/qtest.h - (again, for the qtest server)
> sysemu/memory_mapping.h
>
> headers currently in exec/ :
>
> exec/memory.h
> exec/ioport.h
Yes, if you want a clean separation, I'd rather restrict
include/softmmu/ to softmmu builds. user-mode and tools builds shouldn't
access these headers.
>
> Paolo?
>
>>
>> [...]
>>
>
next prev parent reply other threads:[~2020-05-25 17:33 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-25 14:54 [RFC v3 0/4] QEMU cpus.c refactoring Claudio Fontana
2020-05-25 14:54 ` [RFC v3 1/4] softmmu: move softmmu only files from root Claudio Fontana
2020-05-25 15:12 ` Philippe Mathieu-Daudé
2020-05-25 15:37 ` Claudio Fontana
2020-05-25 17:32 ` Philippe Mathieu-Daudé [this message]
2020-05-25 14:54 ` [RFC v3 2/4] cpu-throttle: new module, extracted from cpus.c Claudio Fontana
2020-05-25 15:14 ` Philippe Mathieu-Daudé
2020-05-25 15:42 ` Claudio Fontana
2020-05-25 14:54 ` [RFC v3 3/4] cpu-timers, icount: new modules Claudio Fontana
2020-05-25 15:16 ` Philippe Mathieu-Daudé
2020-05-25 15:43 ` Claudio Fontana
2020-05-25 14:54 ` [RFC v3 4/4] cpus: extract out accel-specific code to each accel Claudio Fontana
2020-05-25 15:22 ` Philippe Mathieu-Daudé
2020-05-25 15:37 ` Claudio Fontana
2020-05-26 19:16 ` Roman Bolshakov
2020-05-27 13:42 ` Claudio Fontana
2020-05-25 22:58 ` [RFC v3 0/4] QEMU cpus.c refactoring no-reply
2020-05-26 12:57 ` Claudio Fontana
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cce25784-949f-38eb-e380-fdbe5d7d8c53@redhat.com \
--to=philmd@redhat.com \
--cc=alex.bennee@linaro.org \
--cc=cfontana@suse.de \
--cc=colin.xu@intel.com \
--cc=ehabkost@redhat.com \
--cc=haxm-team@intel.com \
--cc=lvivier@redhat.com \
--cc=mtosatti@redhat.com \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=r.bolshakov@yadro.com \
--cc=rth@twiddle.net \
--cc=sunilmut@microsoft.com \
--cc=thuth@redhat.com \
--cc=wenchao.wang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).