From: Eric Blake <eblake@redhat.com>
To: Laurent Vivier <lvivier@redhat.com>, qemu-devel@nongnu.org
Cc: "Fam Zheng" <fam@euphon.net>, "Kevin Wolf" <kwolf@redhat.com>,
"Thomas Huth" <thuth@redhat.com>,
qemu-block@nongnu.org, "David Hildenbrand" <david@redhat.com>,
"Markus Armbruster" <armbru@redhat.com>,
"Jason Wang" <jasowang@redhat.com>,
"Michael S. Tsirkin" <mst@redhat.com>,
"Michael Roth" <mdroth@linux.vnet.ibm.com>,
"Amit Shah" <amit@kernel.org>, "Max Reitz" <mreitz@redhat.com>,
"Eric Auger" <eric.auger@redhat.com>,
"Gerd Hoffmann" <kraxel@redhat.com>,
"Stefan Hajnoczi" <stefanha@redhat.com>,
"Marc-André Lureau" <marcandre.lureau@redhat.com>,
"Paolo Bonzini" <pbonzini@redhat.com>,
"Dr. David Alan Gilbert" <dgilbert@redhat.com>
Subject: Re: [RFC v3 1/6] qmp: add QMP command x-debug-query-virtio
Date: Thu, 7 May 2020 10:38:24 -0500 [thread overview]
Message-ID: <c496da5b-447b-eb09-5a18-f51229f489d9@redhat.com> (raw)
In-Reply-To: <20200507114927.6733-2-lvivier@redhat.com>
On 5/7/20 6:49 AM, Laurent Vivier wrote:
> This new command lists all the instances of VirtIODevice with
> their path and virtio type
>
> Signed-off-by: Laurent Vivier <lvivier@redhat.com>
> ---
> +++ b/qapi/virtio.json
> @@ -0,0 +1,68 @@
> +##
> +# = Virtio devices
> +##
> +
> +##
> +# @VirtioType:
> +#
> +# An enumeration of Virtio device types.
> +#
> +# Since: 5.1.0
Inconsistent on x.y.z vs.
> +##
> +{ 'enum': 'VirtioType',
> + 'data': [ 'unknown', 'virtio-9p', 'virtio-blk', 'virtio-serial',
> + 'virtio-gpu', 'virtio-input', 'virtio-net', 'virtio-scsi',
> + 'vhost-user-fs', 'vhost-vsock', 'virtio-balloon', 'virtio-crypto',
> + 'virtio-iommu', 'virtio-pmem', 'virtio-rng' ]
> +}
> +
> +##
> +# @VirtioInfo:
> +#
> +# Information about a given VirtIODevice
> +#
> +# @path: VirtIO device canonical path.
> +#
> +# @type: VirtIO device type.
> +#
> +# Since: 5.1
x.y. Most of our QAPI seems to have settled on just x.y these days.
The x-debug- prefix is nice; it gives us more flexibility to mess with
this later as needed.
Otherwise:
Reviewed-by: Eric Blake <eblake@redhat.com>
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3226
Virtualization: qemu.org | libvirt.org
next parent reply other threads:[~2020-05-07 15:39 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20200507114927.6733-1-lvivier@redhat.com>
[not found] ` <20200507114927.6733-2-lvivier@redhat.com>
2020-05-07 15:38 ` Eric Blake [this message]
[not found] ` <20200507114927.6733-4-lvivier@redhat.com>
2020-05-07 15:47 ` [RFC v3 3/6] qmp: decode feature bits in virtio-status Eric Blake
2020-05-08 2:54 ` Jason Wang
[not found] ` <20200507114927.6733-7-lvivier@redhat.com>
2020-05-07 15:51 ` [RFC v3 6/6] hmp: add x-debug-virtio commands Eric Blake
[not found] ` <20200507114927.6733-5-lvivier@redhat.com>
2020-05-08 2:57 ` [RFC v3 4/6] qmp: add QMP command x-debug-virtio-queue-status Jason Wang
2020-05-15 15:16 ` Laurent Vivier
2020-05-18 3:31 ` Jason Wang
[not found] ` <20200507114927.6733-6-lvivier@redhat.com>
2020-05-08 3:03 ` [RFC v3 5/6] qmp: add QMP command x-debug-virtio-queue-element Jason Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c496da5b-447b-eb09-5a18-f51229f489d9@redhat.com \
--to=eblake@redhat.com \
--cc=amit@kernel.org \
--cc=armbru@redhat.com \
--cc=david@redhat.com \
--cc=dgilbert@redhat.com \
--cc=eric.auger@redhat.com \
--cc=fam@euphon.net \
--cc=jasowang@redhat.com \
--cc=kraxel@redhat.com \
--cc=kwolf@redhat.com \
--cc=lvivier@redhat.com \
--cc=marcandre.lureau@redhat.com \
--cc=mdroth@linux.vnet.ibm.com \
--cc=mreitz@redhat.com \
--cc=mst@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).