From: Eric Blake <eblake@redhat.com>
To: Laurent Vivier <lvivier@redhat.com>, qemu-devel@nongnu.org
Cc: "Fam Zheng" <fam@euphon.net>, "Kevin Wolf" <kwolf@redhat.com>,
"Thomas Huth" <thuth@redhat.com>,
qemu-block@nongnu.org, "David Hildenbrand" <david@redhat.com>,
"Markus Armbruster" <armbru@redhat.com>,
"Jason Wang" <jasowang@redhat.com>,
"Michael S. Tsirkin" <mst@redhat.com>,
"Michael Roth" <mdroth@linux.vnet.ibm.com>,
"Amit Shah" <amit@kernel.org>, "Max Reitz" <mreitz@redhat.com>,
"Eric Auger" <eric.auger@redhat.com>,
"Gerd Hoffmann" <kraxel@redhat.com>,
"Stefan Hajnoczi" <stefanha@redhat.com>,
"Marc-André Lureau" <marcandre.lureau@redhat.com>,
"Paolo Bonzini" <pbonzini@redhat.com>,
"Dr. David Alan Gilbert" <dgilbert@redhat.com>
Subject: Re: [RFC v3 3/6] qmp: decode feature bits in virtio-status
Date: Thu, 7 May 2020 10:47:33 -0500 [thread overview]
Message-ID: <f9120022-8e07-fed9-8817-46a76db7e5e5@redhat.com> (raw)
In-Reply-To: <20200507114927.6733-4-lvivier@redhat.com>
On 5/7/20 6:49 AM, Laurent Vivier wrote:
> Display feature names instead of a features bitmap for host, guest
> and backend.
>
> Decode features according device type, transport features are
> on the first line. Undecoded bits (if any) are stored in a separate
> field.
>
> Signed-off-by: Laurent Vivier <lvivier@redhat.com>
> ---
I didn't closely review the code, but for the QAPI parts:
> +++ b/qapi/virtio.json
> +##
> +# @VirtioBlkFeature:
> +#
> +# An enumeration of Virtio block features
> +#
> +# Since: 5.1
> +##
> +
> +{ 'enum': 'VirtioBlkFeature',
> + 'data': [ 'size-max', 'seg-max', 'geometry', 'ro', 'blk-size', 'topology', 'mq', 'discard', 'write-zeroes', 'barrier', 'scsi', 'flush',
Missing newline.
> +##
> +# @VirtioDeviceFeatures:
> +#
> +# An union to define the list of features for a virtio device
s/An/A/ (in English, 'an' goes with soft u, 'a' goes with pronounced u.
You can remember with "a unicorn gets an umbrella")
> +#
> +# Since: 5.1
> +##
> +
> +{ 'union': 'VirtioDeviceFeatures',
> + 'data': {
> + 'virtio-serial': [ 'VirtioSerialFeature' ],
> + 'virtio-blk': [ 'VirtioBlkFeature' ],
> + 'virtio-gpu': [ 'VirtioGpuFeature' ],
> + 'virtio-net': [ 'VirtioNetFeature' ],
> + 'virtio-scsi': [ 'VirtioScsiFeature' ],
> + 'virtio-balloon': [ 'VirtioBalloonFeature' ],
> + 'virtio-iommu': [ 'VirtioIommuFeature' ]
> + }
> +}
This is a legacy union rather than a flat union, which results in more
{} in the QMP wire format. Is it worth trying to make this a flat
union, by labeling an appropriate member as 'discriminator'?
> +
> +##
> +# @VirtioStatusFeatures:
> +#
> +# @transport: the list of transport features of the virtio device
> +#
> +# @device: the list of the virtio device specific features
> +#
> +# @unknown: virtio bitmap of the undecoded features
> +#
> +# Since: 5.1
> +##
> +
> +{ 'struct': 'VirtioStatusFeatures',
> + 'data': { 'transport': [ 'VirtioTransportFeature' ],
> + 'device': 'VirtioDeviceFeatures',
> + 'unknown': 'uint64' }
> +}
> +
> ##
> # @VirtioStatus:
> #
> @@ -101,9 +245,9 @@
> 'data': {
> 'device-id': 'int',
> 'device-endian': 'VirtioStatusEndianness',
> - 'guest-features': 'uint64',
> - 'host-features': 'uint64',
> - 'backend-features': 'uint64',
> + 'guest-features': 'VirtioStatusFeatures',
> + 'host-features': 'VirtioStatusFeatures',
> + 'backend-features': 'VirtioStatusFeatures',
This is intra-series churn. Should we be trying to get the right types
in place from the get-go? Or at least clarify in the commit message of
the earlier patch that the format will be incrementally improved later?
> 'num-vqs': 'uint16'
> }
> }
> @@ -123,18 +267,40 @@
> #
> # -> { "execute": "x-debug-virtio-status",
> # "arguments": {
> -# "path": "/machine/peripheral-anon/device[3]/virtio-backend"
> +# "path": "/machine/peripheral-anon/device[1]/virtio-backend"
> # }
> # }
> # <- { "return": {
> -# "backend-features": 0,
> -# "guest-features": 5111807911,
> -# "num-vqs": 3,
> -# "host-features": 6337593319,
> # "device-endian": "little",
> -# "device-id": 1
> +# "device-id": 3,
> +# "backend-features": {
> +# "device": {
> +# "type": "virtio-serial",
> +# "data": []
> +# },
> +# "unknown": 0,
> +# "transport": []
> +# },
If we use a flat union, this could look like:
"backend-feature": {
"type": "virtio-serial",
"features": [],
"unknown": 0,
"transport": []
},
Should 'unknown' be optional so it can be omitted when zero? Should it
be named 'unknown-features'?
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3226
Virtualization: qemu.org | libvirt.org
next prev parent reply other threads:[~2020-05-07 15:49 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20200507114927.6733-1-lvivier@redhat.com>
[not found] ` <20200507114927.6733-2-lvivier@redhat.com>
2020-05-07 15:38 ` [RFC v3 1/6] qmp: add QMP command x-debug-query-virtio Eric Blake
[not found] ` <20200507114927.6733-4-lvivier@redhat.com>
2020-05-07 15:47 ` Eric Blake [this message]
2020-05-08 2:54 ` [RFC v3 3/6] qmp: decode feature bits in virtio-status Jason Wang
[not found] ` <20200507114927.6733-7-lvivier@redhat.com>
2020-05-07 15:51 ` [RFC v3 6/6] hmp: add x-debug-virtio commands Eric Blake
[not found] ` <20200507114927.6733-5-lvivier@redhat.com>
2020-05-08 2:57 ` [RFC v3 4/6] qmp: add QMP command x-debug-virtio-queue-status Jason Wang
2020-05-15 15:16 ` Laurent Vivier
2020-05-18 3:31 ` Jason Wang
[not found] ` <20200507114927.6733-6-lvivier@redhat.com>
2020-05-08 3:03 ` [RFC v3 5/6] qmp: add QMP command x-debug-virtio-queue-element Jason Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f9120022-8e07-fed9-8817-46a76db7e5e5@redhat.com \
--to=eblake@redhat.com \
--cc=amit@kernel.org \
--cc=armbru@redhat.com \
--cc=david@redhat.com \
--cc=dgilbert@redhat.com \
--cc=eric.auger@redhat.com \
--cc=fam@euphon.net \
--cc=jasowang@redhat.com \
--cc=kraxel@redhat.com \
--cc=kwolf@redhat.com \
--cc=lvivier@redhat.com \
--cc=marcandre.lureau@redhat.com \
--cc=mdroth@linux.vnet.ibm.com \
--cc=mreitz@redhat.com \
--cc=mst@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).