qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: "Philippe Mathieu-Daudé" <philmd@redhat.com>
To: Richard Henderson <richard.henderson@linaro.org>, qemu-devel@nongnu.org
Cc: "Marek Vasut" <marex@denx.de>,
	"Peter Maydell" <peter.maydell@linaro.org>,
	"Thomas Huth" <thuth@redhat.com>,
	qemu-riscv@nongnu.org,
	"Sagar Karandikar" <sagark@eecs.berkeley.edu>,
	"Bastian Koppelmann" <kbastian@mail.uni-paderborn.de>,
	"Chris Wulff" <crwulff@gmail.com>,
	"Laurent Vivier" <laurent@vivier.eu>,
	"Max Filippov" <jcmvbkbc@gmail.com>,
	"Aleksandar Markovic" <aleksandar.qemu.devel@gmail.com>,
	qemu-arm@nongnu.org, "Palmer Dabbelt" <palmer@dabbelt.com>,
	"Michael Walle" <michael@walle.cc>,
	"Paolo Bonzini" <pbonzini@redhat.com>,
	"Alistair Francis" <Alistair.Francis@wdc.com>,
	"Alex Bennée" <alex.bennee@linaro.org>,
	"Aleksandar Rikalo" <aleksandar.rikalo@rt-rk.com>,
	"Aurelien Jarno" <aurelien@aurel32.net>,
	"Richard Henderson" <rth@twiddle.net>
Subject: Re: [PATCH v3 09/11] rules.mak: Add base-arch() rule
Date: Fri, 22 May 2020 17:15:33 +0200	[thread overview]
Message-ID: <c96d1032-d702-c957-f85b-82ac4663c859@redhat.com> (raw)
In-Reply-To: <ccd78343-795e-8874-e4f3-bb6861ea64f0@linaro.org>

On 5/22/20 6:24 AM, Richard Henderson wrote:
> On 5/21/20 12:59 PM, Philippe Mathieu-Daudé wrote:
>> +		$(if $(findstring risc,$1),risc,\
> 
> Eh?  riscv{32,64} vs openrisc.

Nice catch, because with this patch openrisc builds with a riscv
config-devices.h =)

> 
>> +		$(if $(findstring x86,$1),i386,\
> 
> Do we really not need an exact match for x86_64?

OK.

> 
>> +		$(if $(findstring aarch64,$1),arm,$1)))))))
> 
> Exact match?

OK.

> 
> 
> r~
> 



  reply	other threads:[~2020-05-22 15:16 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-05-21 19:59 [PATCH v3 00/11] accel: Allow targets to use Kconfig, disable semihosting by default Philippe Mathieu-Daudé
2020-05-21 19:59 ` [PATCH v3 01/11] MAINTAINERS: Fix KVM path expansion glob Philippe Mathieu-Daudé
2020-05-21 19:59 ` [PATCH v3 02/11] MAINTAINERS: Add an 'overall' entry for accelerators Philippe Mathieu-Daudé
2020-05-21 19:59 ` [PATCH v3 03/11] MAINTAINERS: Add an entry for the HAX accelerator Philippe Mathieu-Daudé
2020-05-21 19:59 ` [PATCH v3 04/11] accel/tcg: Add stub for probe_access() Philippe Mathieu-Daudé
2020-06-17 13:51   ` Stefan Hajnoczi
2020-05-21 19:59 ` [PATCH v3 05/11] Makefile: Remove dangerous EOL trailing backslash Philippe Mathieu-Daudé
2020-05-21 19:59 ` [PATCH v3 06/11] Makefile: Write MINIKCONF variables as one entry per line Philippe Mathieu-Daudé
2020-05-21 19:59 ` [PATCH v3 07/11] accel/Kconfig: Extract accel selectors into their own config Philippe Mathieu-Daudé
2020-05-21 19:59 ` [PATCH v3 08/11] accel/Kconfig: Add the TCG selector Philippe Mathieu-Daudé
2020-05-21 19:59 ` [PATCH v3 09/11] rules.mak: Add base-arch() rule Philippe Mathieu-Daudé
2020-05-22  4:24   ` Richard Henderson
2020-05-22 15:15     ` Philippe Mathieu-Daudé [this message]
2020-05-21 19:59 ` [PATCH v3 10/11] Makefile: Allow target-specific optional Kconfig Philippe Mathieu-Daudé
2020-05-21 19:59 ` [PATCH v3 11/11] hw/semihosting: Make the feature depend of TCG, and allow to disable it Philippe Mathieu-Daudé
2020-05-22  4:26   ` Richard Henderson
2020-05-22 15:11     ` Philippe Mathieu-Daudé
2020-05-22 15:12   ` Philippe Mathieu-Daudé
2020-05-22  2:30 ` [PATCH v3 00/11] accel: Allow targets to use Kconfig, disable semihosting by default no-reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=c96d1032-d702-c957-f85b-82ac4663c859@redhat.com \
    --to=philmd@redhat.com \
    --cc=Alistair.Francis@wdc.com \
    --cc=aleksandar.qemu.devel@gmail.com \
    --cc=aleksandar.rikalo@rt-rk.com \
    --cc=alex.bennee@linaro.org \
    --cc=aurelien@aurel32.net \
    --cc=crwulff@gmail.com \
    --cc=jcmvbkbc@gmail.com \
    --cc=kbastian@mail.uni-paderborn.de \
    --cc=laurent@vivier.eu \
    --cc=marex@denx.de \
    --cc=michael@walle.cc \
    --cc=palmer@dabbelt.com \
    --cc=pbonzini@redhat.com \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-arm@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-riscv@nongnu.org \
    --cc=richard.henderson@linaro.org \
    --cc=rth@twiddle.net \
    --cc=sagark@eecs.berkeley.edu \
    --cc=thuth@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).