From: "Philippe Mathieu-Daudé" <philmd@redhat.com>
To: Richard Henderson <richard.henderson@linaro.org>,
qemu-devel@nongnu.org, Paolo Bonzini <pbonzini@redhat.com>
Cc: "Marek Vasut" <marex@denx.de>,
"Peter Maydell" <peter.maydell@linaro.org>,
"Thomas Huth" <thuth@redhat.com>,
qemu-riscv@nongnu.org,
"Sagar Karandikar" <sagark@eecs.berkeley.edu>,
"Bastian Koppelmann" <kbastian@mail.uni-paderborn.de>,
"Chris Wulff" <crwulff@gmail.com>,
"Laurent Vivier" <laurent@vivier.eu>,
"Max Filippov" <jcmvbkbc@gmail.com>,
"Aleksandar Markovic" <aleksandar.qemu.devel@gmail.com>,
qemu-arm@nongnu.org, "Palmer Dabbelt" <palmer@dabbelt.com>,
"Michael Walle" <michael@walle.cc>,
"Alistair Francis" <Alistair.Francis@wdc.com>,
"Aleksandar Rikalo" <aleksandar.rikalo@rt-rk.com>,
"Alex Bennée" <alex.bennee@linaro.org>,
"Aurelien Jarno" <aurelien@aurel32.net>,
"Richard Henderson" <rth@twiddle.net>
Subject: Re: [PATCH v3 11/11] hw/semihosting: Make the feature depend of TCG, and allow to disable it
Date: Fri, 22 May 2020 17:11:37 +0200 [thread overview]
Message-ID: <d7635637-2b34-fd4b-ee90-945c4c9fc9f3@redhat.com> (raw)
In-Reply-To: <36db7554-dcc0-6b8c-e7b7-628c105d8fc7@linaro.org>
On 5/22/20 6:26 AM, Richard Henderson wrote:
> On 5/21/20 12:59 PM, Philippe Mathieu-Daudé wrote:
>> +++ b/hw/semihosting/Kconfig
>> @@ -1,3 +1,5 @@
>>
>> +# default is 'n'
>> config SEMIHOSTING
>> - bool
>> + bool
>> + depends on TCG
>> diff --git a/target/arm/Kconfig b/target/arm/Kconfig
>> new file mode 100644
>> index 0000000000..035592dd86
>> --- /dev/null
>> +++ b/target/arm/Kconfig
>> @@ -0,0 +1,2 @@
>> +config SEMIHOSTING
>> + default y if TCG
>
> Did you answer my question about replicating the TCG test? If you did, I
> missed it...
Shortly before posting this series:
https://www.mail-archive.com/qemu-devel@nongnu.org/msg705992.html
There is indeed something wrong with this patch, but I'm not seeing it.
- semihosting only makes sense with TCG accelerator
This is the "depends on TCG"
- some targets (if built with TCG enabled) require semihosting
This would be a per-target "select SEMIHOSTING if TCG"
Another problem is some targets only require semihosting in system-mode;
and this approach select it for both system/user modes.
Paolo... help!
next prev parent reply other threads:[~2020-05-22 15:13 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-21 19:59 [PATCH v3 00/11] accel: Allow targets to use Kconfig, disable semihosting by default Philippe Mathieu-Daudé
2020-05-21 19:59 ` [PATCH v3 01/11] MAINTAINERS: Fix KVM path expansion glob Philippe Mathieu-Daudé
2020-05-21 19:59 ` [PATCH v3 02/11] MAINTAINERS: Add an 'overall' entry for accelerators Philippe Mathieu-Daudé
2020-05-21 19:59 ` [PATCH v3 03/11] MAINTAINERS: Add an entry for the HAX accelerator Philippe Mathieu-Daudé
2020-05-21 19:59 ` [PATCH v3 04/11] accel/tcg: Add stub for probe_access() Philippe Mathieu-Daudé
2020-06-17 13:51 ` Stefan Hajnoczi
2020-05-21 19:59 ` [PATCH v3 05/11] Makefile: Remove dangerous EOL trailing backslash Philippe Mathieu-Daudé
2020-05-21 19:59 ` [PATCH v3 06/11] Makefile: Write MINIKCONF variables as one entry per line Philippe Mathieu-Daudé
2020-05-21 19:59 ` [PATCH v3 07/11] accel/Kconfig: Extract accel selectors into their own config Philippe Mathieu-Daudé
2020-05-21 19:59 ` [PATCH v3 08/11] accel/Kconfig: Add the TCG selector Philippe Mathieu-Daudé
2020-05-21 19:59 ` [PATCH v3 09/11] rules.mak: Add base-arch() rule Philippe Mathieu-Daudé
2020-05-22 4:24 ` Richard Henderson
2020-05-22 15:15 ` Philippe Mathieu-Daudé
2020-05-21 19:59 ` [PATCH v3 10/11] Makefile: Allow target-specific optional Kconfig Philippe Mathieu-Daudé
2020-05-21 19:59 ` [PATCH v3 11/11] hw/semihosting: Make the feature depend of TCG, and allow to disable it Philippe Mathieu-Daudé
2020-05-22 4:26 ` Richard Henderson
2020-05-22 15:11 ` Philippe Mathieu-Daudé [this message]
2020-05-22 15:12 ` Philippe Mathieu-Daudé
2020-05-22 2:30 ` [PATCH v3 00/11] accel: Allow targets to use Kconfig, disable semihosting by default no-reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d7635637-2b34-fd4b-ee90-945c4c9fc9f3@redhat.com \
--to=philmd@redhat.com \
--cc=Alistair.Francis@wdc.com \
--cc=aleksandar.qemu.devel@gmail.com \
--cc=aleksandar.rikalo@rt-rk.com \
--cc=alex.bennee@linaro.org \
--cc=aurelien@aurel32.net \
--cc=crwulff@gmail.com \
--cc=jcmvbkbc@gmail.com \
--cc=kbastian@mail.uni-paderborn.de \
--cc=laurent@vivier.eu \
--cc=marex@denx.de \
--cc=michael@walle.cc \
--cc=palmer@dabbelt.com \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-riscv@nongnu.org \
--cc=richard.henderson@linaro.org \
--cc=rth@twiddle.net \
--cc=sagark@eecs.berkeley.edu \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).