From: Laurent Vivier <lvivier@redhat.com>
To: Markus Armbruster <armbru@redhat.com>
Cc: Kevin Wolf <kwolf@redhat.com>, Thomas Huth <thuth@redhat.com>,
qemu-block@nongnu.org, "Michael S. Tsirkin" <mst@redhat.com>,
qemu-devel@nongnu.org, Hanna Reitz <hreitz@redhat.com>,
Paolo Bonzini <pbonzini@redhat.com>
Subject: Re: [PATCH 1/3] qdict: make available dump_qobject(), dump_qdict(), dump_qlist()
Date: Wed, 10 Nov 2021 18:11:43 +0100 [thread overview]
Message-ID: <d78f3993-cba2-fd06-fbc9-5d5fbb7550ee@redhat.com> (raw)
In-Reply-To: <87bl2sugs0.fsf@dusky.pond.sub.org>
On 10/11/2021 17:17, Markus Armbruster wrote:
> Laurent Vivier <lvivier@redhat.com> writes:
>
>> move them from block/qapi.c to qobject/qdict.c, qobject/qlist.c,
>> qobject/qobject.c
>>
>> This is useful to debug qobjects
>>
>> Signed-off-by: Laurent Vivier <lvivier@redhat.com>
>
> I think qobject_to_json_pretty() is better suited to debugging, because
> it preserves differences like the one between the string "1" and the
> number 1.
>
Yes, you're right. I didn't think about this solution.
So we can drop this patch.
Thanks,
Laurent
next prev parent reply other threads:[~2021-11-10 17:15 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-10 13:56 [PATCH 0/3] tests/qtest: add some tests for virtio-net failover Laurent Vivier
2021-11-10 13:56 ` [PATCH 1/3] qdict: make available dump_qobject(), dump_qdict(), dump_qlist() Laurent Vivier
2021-11-10 16:17 ` Markus Armbruster
2021-11-10 17:11 ` Laurent Vivier [this message]
2021-11-10 13:56 ` [PATCH 2/3] qtest/libqos: add a function to initialize secondary PCI buses Laurent Vivier
2021-11-10 13:56 ` [PATCH 3/3] tests/qtest: add some tests for virtio-net failover Laurent Vivier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d78f3993-cba2-fd06-fbc9-5d5fbb7550ee@redhat.com \
--to=lvivier@redhat.com \
--cc=armbru@redhat.com \
--cc=hreitz@redhat.com \
--cc=kwolf@redhat.com \
--cc=mst@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).