* [Qemu-devel] [PATCH] block/null: Expose read-zeroes option in QAPI schema
@ 2019-06-17 11:57 Kevin Wolf
2019-06-17 12:28 ` Max Reitz
2019-06-24 9:11 ` Andrey Shinkevich
0 siblings, 2 replies; 3+ messages in thread
From: Kevin Wolf @ 2019-06-17 11:57 UTC (permalink / raw)
To: qemu-block; +Cc: kwolf, andrey.shinkevich, qemu-devel, mreitz
Commit cd219eb1e55 added the read-zeroes option for the null-co and
null-aio block driver, but forgot to add them to the QAPI schema.
Therefore, this option wasn't available in -blockdev and blockdev-add
until now.
Add the missing option in the schema to make it available there, too.
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
---
qapi/block-core.json | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/qapi/block-core.json b/qapi/block-core.json
index 61124431d8..0d43d4f37c 100644
--- a/qapi/block-core.json
+++ b/qapi/block-core.json
@@ -2890,11 +2890,13 @@
# @latency-ns: emulated latency (in nanoseconds) in processing
# requests. Default to zero which completes requests immediately.
# (Since 2.4)
+# @read-zeroes: if true, reads from the device produce zeroes; if false, the
+# buffer is left unchanged. (default: false; since: 4.1)
#
# Since: 2.9
##
{ 'struct': 'BlockdevOptionsNull',
- 'data': { '*size': 'int', '*latency-ns': 'uint64' } }
+ 'data': { '*size': 'int', '*latency-ns': 'uint64', '*read-zeroes': 'bool' } }
##
# @BlockdevOptionsNVMe:
--
2.20.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [Qemu-devel] [PATCH] block/null: Expose read-zeroes option in QAPI schema
2019-06-17 11:57 [Qemu-devel] [PATCH] block/null: Expose read-zeroes option in QAPI schema Kevin Wolf
@ 2019-06-17 12:28 ` Max Reitz
2019-06-24 9:11 ` Andrey Shinkevich
1 sibling, 0 replies; 3+ messages in thread
From: Max Reitz @ 2019-06-17 12:28 UTC (permalink / raw)
To: Kevin Wolf, qemu-block; +Cc: andrey.shinkevich, qemu-devel
[-- Attachment #1.1: Type: text/plain, Size: 534 bytes --]
On 17.06.19 13:57, Kevin Wolf wrote:
> Commit cd219eb1e55 added the read-zeroes option for the null-co and
> null-aio block driver, but forgot to add them to the QAPI schema.
> Therefore, this option wasn't available in -blockdev and blockdev-add
> until now.
>
> Add the missing option in the schema to make it available there, too.
>
> Signed-off-by: Kevin Wolf <kwolf@redhat.com>
> ---
> qapi/block-core.json | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
Reviewed-by: Max Reitz <mreitz@redhat.com>
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [Qemu-devel] [PATCH] block/null: Expose read-zeroes option in QAPI schema
2019-06-17 11:57 [Qemu-devel] [PATCH] block/null: Expose read-zeroes option in QAPI schema Kevin Wolf
2019-06-17 12:28 ` Max Reitz
@ 2019-06-24 9:11 ` Andrey Shinkevich
1 sibling, 0 replies; 3+ messages in thread
From: Andrey Shinkevich @ 2019-06-24 9:11 UTC (permalink / raw)
To: Kevin Wolf, qemu-block; +Cc: qemu-devel, mreitz
On 17/06/2019 14:57, Kevin Wolf wrote:
> Commit cd219eb1e55 added the read-zeroes option for the null-co and
> null-aio block driver, but forgot to add them to the QAPI schema.
> Therefore, this option wasn't available in -blockdev and blockdev-add
> until now.
>
> Add the missing option in the schema to make it available there, too.
>
> Signed-off-by: Kevin Wolf <kwolf@redhat.com>
> ---
> qapi/block-core.json | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/qapi/block-core.json b/qapi/block-core.json
> index 61124431d8..0d43d4f37c 100644
> --- a/qapi/block-core.json
> +++ b/qapi/block-core.json
> @@ -2890,11 +2890,13 @@
> # @latency-ns: emulated latency (in nanoseconds) in processing
> # requests. Default to zero which completes requests immediately.
> # (Since 2.4)
> +# @read-zeroes: if true, reads from the device produce zeroes; if false, the
> +# buffer is left unchanged. (default: false; since: 4.1)
> #
> # Since: 2.9
> ##
> { 'struct': 'BlockdevOptionsNull',
> - 'data': { '*size': 'int', '*latency-ns': 'uint64' } }
> + 'data': { '*size': 'int', '*latency-ns': 'uint64', '*read-zeroes': 'bool' } }
>
> ##
> # @BlockdevOptionsNVMe:
>
Reviewed-by: Andrey Shinkevich <andrey.shinkevich@virtuozzo.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-06-24 9:14 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-06-17 11:57 [Qemu-devel] [PATCH] block/null: Expose read-zeroes option in QAPI schema Kevin Wolf
2019-06-17 12:28 ` Max Reitz
2019-06-24 9:11 ` Andrey Shinkevich
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).