From: "Philippe Mathieu-Daudé" <philmd@redhat.com>
To: Damien Hedde <damien.hedde@greensocs.com>,
Peter Maydell <peter.maydell@linaro.org>
Cc: "Daniel P. Berrange" <berrange@redhat.com>,
"Eduardo Habkost" <ehabkost@redhat.com>,
"Alistair Francis" <alistair@alistair23.me>,
"Mark Burton" <mark.burton@greensocs.com>,
"QEMU Developers" <qemu-devel@nongnu.org>,
"Marc-André Lureau" <marcandre.lureau@redhat.com>,
qemu-arm <qemu-arm@nongnu.org>,
"Paolo Bonzini" <pbonzini@redhat.com>,
"Edgar E. Iglesias" <edgar.iglesias@gmail.com>
Subject: Re: [PATCH v6 9/9] hw/arm/xilinx_zynq: connect uart clocks to slcr
Date: Tue, 3 Dec 2019 16:29:13 +0100 [thread overview]
Message-ID: <db2836fa-e2f1-d1ab-88be-1b24f5a18302@redhat.com> (raw)
In-Reply-To: <f373af20-0df4-384f-b1a3-10bf873c315e@greensocs.com>
On 12/3/19 3:59 PM, Damien Hedde wrote:
> On 12/2/19 4:34 PM, Peter Maydell wrote:
>> On Wed, 4 Sep 2019 at 13:56, Damien Hedde <damien.hedde@greensocs.com> wrote:
>>>
>>> Add the connection between the slcr's output clocks and the uarts inputs.
>>>
>>> Also add the main board clock 'ps_clk', which is hard-coded to 33.33MHz
>>> (the default frequency). This clock is used to feed the slcr's input
>>> clock.
>>>
>>> Signed-off-by: Damien Hedde <damien.hedde@greensocs.com>
>>
>> Nothing obviously wrong in the body of the patch, but as with
>> 7 and 8, review from a Xilinx person would be helpful.
>>
>> /* board base frequency: 33.333333 MHz */
>> #define PS_CLK_FREQUENCY (100 * 1000 * 1000 / 3)
>>
>> This is interesting, because it's not an integer... I'll come back
>> to this topic in a reply to the cover letter in a moment.
>
> For this precise case, what I wanted is the resulting integer which I
> got from the device trees in linux (btw I should probably add this point
> in comment). Just thought it was more readable this way than "33333333".
FWIW I'm auditing if it is possible to use the float type for
frequencies (before to ask on the list if this makes sense), because in
hw/core/ptimer we use timers with periods, and loose some precision
using 1/freq again.
Also we have MiB/KiB in "qemu/units.h" and I'd like to introduce MHz/KHz.
next prev parent reply other threads:[~2019-12-03 16:07 UTC|newest]
Thread overview: 46+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-04 12:55 [Qemu-devel] [PATCH v6 0/9] Clock framework API Damien Hedde
2019-09-04 12:55 ` [Qemu-devel] [PATCH v6 1/9] hw/core/clock: introduce clock objects Damien Hedde
2019-11-25 13:07 ` Philippe Mathieu-Daudé
2019-11-25 13:37 ` Philippe Mathieu-Daudé
2019-12-03 15:14 ` Damien Hedde
2019-12-02 13:42 ` Peter Maydell
2019-12-03 15:28 ` Damien Hedde
2019-09-04 12:55 ` [Qemu-devel] [PATCH v6 2/9] hw/core/clock-vmstate: define a vmstate entry for clock state Damien Hedde
2019-11-25 13:05 ` Philippe Mathieu-Daudé
2019-12-02 13:44 ` Peter Maydell
2019-09-04 12:55 ` [Qemu-devel] [PATCH v6 3/9] qdev: add clock input&output support to devices Damien Hedde
2019-11-25 13:30 ` Philippe Mathieu-Daudé
2019-12-03 15:35 ` Damien Hedde
2019-12-02 14:34 ` Peter Maydell
2019-12-04 9:05 ` Damien Hedde
2019-12-04 9:53 ` Philippe Mathieu-Daudé
2019-12-04 11:58 ` Damien Hedde
2019-09-04 12:55 ` [Qemu-devel] [PATCH v6 4/9] qdev-monitor: print the device's clock with info qtree Damien Hedde
2019-12-02 14:35 ` Peter Maydell
2019-09-04 12:55 ` [Qemu-devel] [PATCH v6 5/9] qdev-clock: introduce an init array to ease the device construction Damien Hedde
2019-12-02 15:13 ` Peter Maydell
2019-12-04 11:04 ` Damien Hedde
2019-09-04 12:55 ` [Qemu-devel] [PATCH v6 6/9] docs/clocks: add device's clock documentation Damien Hedde
2019-12-02 15:17 ` Peter Maydell
2019-12-04 12:11 ` Damien Hedde
2019-09-04 12:55 ` [Qemu-devel] [PATCH v6 7/9] hw/misc/zynq_slcr: add clock generation for uarts Damien Hedde
2019-12-02 15:20 ` Peter Maydell
2019-12-04 12:51 ` Damien Hedde
2019-09-04 12:55 ` [Qemu-devel] [PATCH v6 8/9] hw/char/cadence_uart: add clock support Damien Hedde
2019-12-02 15:24 ` Peter Maydell
2019-12-04 13:35 ` Damien Hedde
2019-09-04 12:55 ` [Qemu-devel] [PATCH v6 9/9] hw/arm/xilinx_zynq: connect uart clocks to slcr Damien Hedde
2019-12-02 15:34 ` Peter Maydell
2019-12-03 14:59 ` Damien Hedde
2019-12-03 15:29 ` Philippe Mathieu-Daudé [this message]
2019-12-02 16:15 ` [PATCH v6 0/9] Clock framework API Peter Maydell
2019-12-04 16:40 ` Damien Hedde
2019-12-04 20:34 ` Philippe Mathieu-Daudé
2019-12-05 9:36 ` Damien Hedde
2019-12-05 9:59 ` Philippe Mathieu-Daudé
2019-12-05 10:21 ` Dr. David Alan Gilbert
2019-12-05 10:44 ` Philippe Mathieu-Daudé
2019-12-05 10:56 ` Dr. David Alan Gilbert
2019-12-05 11:01 ` Philippe Mathieu-Daudé
2019-12-06 12:46 ` Cleber Rosa
2019-12-06 13:48 ` Dr. David Alan Gilbert
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=db2836fa-e2f1-d1ab-88be-1b24f5a18302@redhat.com \
--to=philmd@redhat.com \
--cc=alistair@alistair23.me \
--cc=berrange@redhat.com \
--cc=damien.hedde@greensocs.com \
--cc=edgar.iglesias@gmail.com \
--cc=ehabkost@redhat.com \
--cc=marcandre.lureau@redhat.com \
--cc=mark.burton@greensocs.com \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).