"make check" broken with everything but tools disabled

"make check" broken with everything but tools disabled

[Markus Armbruster]

Watch this:

    $ mkdir bld-tools
    $ cd bld-tools
    $ ../configure --disable-system --disable-user --enable-tools
    $ make check
    [...]
    make: *** No rule to make target 'tests/qemu-iotests/socket_scm_helper', needed by 'check-block'.  Stop.

Re: "make check" broken with everything but tools disabled

[John Snow]

On 3/16/21 9:28 AM, Markus Armbruster wrote:
> Watch this:
> 
>      $ mkdir bld-tools
>      $ cd bld-tools
>      $ ../configure --disable-system --disable-user --enable-tools
>      $ make check
>      [...]
>      make: *** No rule to make target 'tests/qemu-iotests/socket_scm_helper', needed by 'check-block'.  Stop.
> 
> 

One more thing to add a CI job to check, I suppose.

--js

Re: "make check" broken with everything but tools disabled

[Philippe Mathieu-Daudé]

On 3/17/21 11:35 PM, John Snow wrote:
> On 3/16/21 9:28 AM, Markus Armbruster wrote:
>> Watch this:
>>
>>      $ mkdir bld-tools
>>      $ cd bld-tools
>>      $ ../configure --disable-system --disable-user --enable-tools
>>      $ make check
>>      [...]
>>      make: *** No rule to make target
>> 'tests/qemu-iotests/socket_scm_helper', needed by 'check-block'.  Stop.
>>
>>
> 
> One more thing to add a CI job to check, I suppose.

We have the 'build-tools-and-docs-debian' job, but
lack the 'check-tools-and-docs-debian' one.

Re: "make check" broken with everything but tools disabled

[Claudio Fontana]

On 3/16/21 2:28 PM, Markus Armbruster wrote:
> Watch this:
> 
>     $ mkdir bld-tools
>     $ cd bld-tools
>     $ ../configure --disable-system --disable-user --enable-tools
>     $ make check
>     [...]
>     make: *** No rule to make target 'tests/qemu-iotests/socket_scm_helper', needed by 'check-block'.  Stop.
> 
> 

Hi Markus,

I can reproduce this error too.

When looking at the sequence of commands I was almost sure it was due to a missing "make" before the "make check",
as my experience with the new build system (meson-based), is that I have to do:

make

first, and then

make check

later, or bugs start happening, build can end up doing the wrong things.
I thought this was a known limitation and I am currently just dealing with it.

But then I tried to apply this to your specific case, and I get the same error nevertheless.

make: *** No rule to make target 'tests/qemu-iotests/socket_scm_helper', needed by 'check-block'.  Stop.

Ciao,

CLaudio

Re: "make check" broken with everything but tools disabled

[Paolo Bonzini]

On 18/03/21 10:16, Claudio Fontana wrote:
> my experience with the new build system (meson-based), is that I have to do:
> 
> make
> 
> first, and then
> 
> make check
> 
> later, or bugs start happening

This shouldn't be needed.

Paolo

Re: "make check" broken with everything but tools disabled

[Philippe Mathieu-Daudé]

On 3/18/21 10:16 AM, Claudio Fontana wrote:
> On 3/16/21 2:28 PM, Markus Armbruster wrote:
>> Watch this:
>>
>>     $ mkdir bld-tools
>>     $ cd bld-tools
>>     $ ../configure --disable-system --disable-user --enable-tools
>>     $ make check
>>     [...]
>>     make: *** No rule to make target 'tests/qemu-iotests/socket_scm_helper', needed by 'check-block'.  Stop.
>>
>>
> 
> Hi Markus,
> 
> I can reproduce this error too.

I'm having a slightly different one:

$ make check-block
/home/phil/.local/bin/meson introspect --targets --tests --benchmarks |
/usr/bin/python3 -B scripts/mtest2make.py > Makefile.mtest
  GIT     ui/keycodemapdb tests/fp/berkeley-testfloat-3
tests/fp/berkeley-softfloat-3 dtc capstone slirp
No such file: tests/qemu-iotests/../../qemu-img
make: *** [/home/phil/source/qemu/tests/Makefile.include:148:
check-block] Error 1

Apparently I was luckier because still having an old socket_scm_helper
built, not sure this is a good thing or not...

$ ls -l tests/qemu-iotests/socket_scm_helper
-rwxr-xr-x. 1 phil root   28824 Mar  3 15:50
tests/qemu-iotests/socket_scm_helper

Re: "make check" broken with everything but tools disabled

[Claudio Fontana]

On 3/18/21 11:03 AM, Paolo Bonzini wrote:
> On 18/03/21 10:16, Claudio Fontana wrote:
>> my experience with the new build system (meson-based), is that I have to do:
>>
>> make
>>
>> first, and then
>>
>> make check
>>
>> later, or bugs start happening
> 
> This shouldn't be needed.
> 
> Paolo
> 

I am pretty sure it didn't work in some cases, maybe with check-tcg only.. will keep an eye on this.

Ciao,

Claudio