* [PATCH 11/12] target/sh4: Remove superfluous breaks
@ 2020-07-13 9:05 Yi Wang
2020-07-13 9:38 ` Thomas Huth
2020-07-13 10:36 ` Philippe Mathieu-Daudé
0 siblings, 2 replies; 4+ messages in thread
From: Yi Wang @ 2020-07-13 9:05 UTC (permalink / raw)
To: qemu-devel; +Cc: wang.yi59, Liao Pingfang, wang.liang82, xue.zhihong
From: Liao Pingfang <liao.pingfang@zte.com.cn>
Remove superfluous breaks, as there is a "return" before them.
Signed-off-by: Liao Pingfang <liao.pingfang@zte.com.cn>
Signed-off-by: Yi Wang <wang.yi59@zte.com.cn>
Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
---
target/sh4/translate.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/target/sh4/translate.c b/target/sh4/translate.c
index 6192d83..60c863d 100644
--- a/target/sh4/translate.c
+++ b/target/sh4/translate.c
@@ -1542,7 +1542,6 @@ static void _decode_opc(DisasContext * ctx)
tcg_gen_qemu_ld_i32(REG(0), REG(B11_8), ctx->memidx,
MO_TEUL | MO_UNALN);
return;
- break;
case 0x40e9: /* movua.l @Rm+,R0 */
CHECK_SH4A
/* Load non-boundary-aligned data */
@@ -1550,7 +1549,6 @@ static void _decode_opc(DisasContext * ctx)
MO_TEUL | MO_UNALN);
tcg_gen_addi_i32(REG(B11_8), REG(B11_8), 4);
return;
- break;
case 0x0029: /* movt Rn */
tcg_gen_mov_i32(REG(B11_8), cpu_sr_t);
return;
@@ -1638,7 +1636,6 @@ static void _decode_opc(DisasContext * ctx)
CHECK_SH4A
tcg_gen_mb(TCG_MO_ALL | TCG_BAR_SC);
return;
- break;
case 0x4024: /* rotcl Rn */
{
TCGv tmp = tcg_temp_new();
--
2.9.5
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH 11/12] target/sh4: Remove superfluous breaks
2020-07-13 9:05 [PATCH 11/12] target/sh4: Remove superfluous breaks Yi Wang
@ 2020-07-13 9:38 ` Thomas Huth
2020-09-01 6:38 ` Laurent Vivier
2020-07-13 10:36 ` Philippe Mathieu-Daudé
1 sibling, 1 reply; 4+ messages in thread
From: Thomas Huth @ 2020-07-13 9:38 UTC (permalink / raw)
To: Yi Wang, qemu-devel
Cc: xue.zhihong, QEMU Trivial, wang.liang82, Liao Pingfang, Yoshinori Sato
On 13/07/2020 11.05, Yi Wang wrote:
> From: Liao Pingfang <liao.pingfang@zte.com.cn>
>
> Remove superfluous breaks, as there is a "return" before them.
>
> Signed-off-by: Liao Pingfang <liao.pingfang@zte.com.cn>
> Signed-off-by: Yi Wang <wang.yi59@zte.com.cn>
> Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
> ---
> target/sh4/translate.c | 3 ---
> 1 file changed, 3 deletions(-)
>
> diff --git a/target/sh4/translate.c b/target/sh4/translate.c
> index 6192d83..60c863d 100644
> --- a/target/sh4/translate.c
> +++ b/target/sh4/translate.c
> @@ -1542,7 +1542,6 @@ static void _decode_opc(DisasContext * ctx)
> tcg_gen_qemu_ld_i32(REG(0), REG(B11_8), ctx->memidx,
> MO_TEUL | MO_UNALN);
> return;
> - break;
> case 0x40e9: /* movua.l @Rm+,R0 */
> CHECK_SH4A
> /* Load non-boundary-aligned data */
> @@ -1550,7 +1549,6 @@ static void _decode_opc(DisasContext * ctx)
> MO_TEUL | MO_UNALN);
> tcg_gen_addi_i32(REG(B11_8), REG(B11_8), 4);
> return;
> - break;
> case 0x0029: /* movt Rn */
> tcg_gen_mov_i32(REG(B11_8), cpu_sr_t);
> return;
> @@ -1638,7 +1636,6 @@ static void _decode_opc(DisasContext * ctx)
> CHECK_SH4A
> tcg_gen_mb(TCG_MO_ALL | TCG_BAR_SC);
> return;
> - break;
> case 0x4024: /* rotcl Rn */
> {
> TCGv tmp = tcg_temp_new();
>
Reviewed-by: Thomas Huth <thuth@redhat.com>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH 11/12] target/sh4: Remove superfluous breaks
2020-07-13 9:05 [PATCH 11/12] target/sh4: Remove superfluous breaks Yi Wang
2020-07-13 9:38 ` Thomas Huth
@ 2020-07-13 10:36 ` Philippe Mathieu-Daudé
1 sibling, 0 replies; 4+ messages in thread
From: Philippe Mathieu-Daudé @ 2020-07-13 10:36 UTC (permalink / raw)
To: Yi Wang, qemu-devel; +Cc: xue.zhihong, wang.liang82, Liao Pingfang
On 7/13/20 11:05 AM, Yi Wang wrote:
> From: Liao Pingfang <liao.pingfang@zte.com.cn>
>
> Remove superfluous breaks, as there is a "return" before them.
>
> Signed-off-by: Liao Pingfang <liao.pingfang@zte.com.cn>
> Signed-off-by: Yi Wang <wang.yi59@zte.com.cn>
> Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
I hadn't reviewed this patch, but now I did.
> ---
> target/sh4/translate.c | 3 ---
> 1 file changed, 3 deletions(-)
>
> diff --git a/target/sh4/translate.c b/target/sh4/translate.c
> index 6192d83..60c863d 100644
> --- a/target/sh4/translate.c
> +++ b/target/sh4/translate.c
> @@ -1542,7 +1542,6 @@ static void _decode_opc(DisasContext * ctx)
> tcg_gen_qemu_ld_i32(REG(0), REG(B11_8), ctx->memidx,
> MO_TEUL | MO_UNALN);
> return;
> - break;
> case 0x40e9: /* movua.l @Rm+,R0 */
> CHECK_SH4A
> /* Load non-boundary-aligned data */
> @@ -1550,7 +1549,6 @@ static void _decode_opc(DisasContext * ctx)
> MO_TEUL | MO_UNALN);
> tcg_gen_addi_i32(REG(B11_8), REG(B11_8), 4);
> return;
> - break;
> case 0x0029: /* movt Rn */
> tcg_gen_mov_i32(REG(B11_8), cpu_sr_t);
> return;
> @@ -1638,7 +1636,6 @@ static void _decode_opc(DisasContext * ctx)
> CHECK_SH4A
> tcg_gen_mb(TCG_MO_ALL | TCG_BAR_SC);
> return;
> - break;
> case 0x4024: /* rotcl Rn */
> {
> TCGv tmp = tcg_temp_new();
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH 11/12] target/sh4: Remove superfluous breaks
2020-07-13 9:38 ` Thomas Huth
@ 2020-09-01 6:38 ` Laurent Vivier
0 siblings, 0 replies; 4+ messages in thread
From: Laurent Vivier @ 2020-09-01 6:38 UTC (permalink / raw)
To: Thomas Huth, Yi Wang, qemu-devel
Cc: QEMU Trivial, Liao Pingfang, wang.liang82, xue.zhihong, Yoshinori Sato
Le 13/07/2020 à 11:38, Thomas Huth a écrit :
> On 13/07/2020 11.05, Yi Wang wrote:
>> From: Liao Pingfang <liao.pingfang@zte.com.cn>
>>
>> Remove superfluous breaks, as there is a "return" before them.
>>
>> Signed-off-by: Liao Pingfang <liao.pingfang@zte.com.cn>
>> Signed-off-by: Yi Wang <wang.yi59@zte.com.cn>
>> Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
>> ---
>> target/sh4/translate.c | 3 ---
>> 1 file changed, 3 deletions(-)
>>
>> diff --git a/target/sh4/translate.c b/target/sh4/translate.c
>> index 6192d83..60c863d 100644
>> --- a/target/sh4/translate.c
>> +++ b/target/sh4/translate.c
>> @@ -1542,7 +1542,6 @@ static void _decode_opc(DisasContext * ctx)
>> tcg_gen_qemu_ld_i32(REG(0), REG(B11_8), ctx->memidx,
>> MO_TEUL | MO_UNALN);
>> return;
>> - break;
>> case 0x40e9: /* movua.l @Rm+,R0 */
>> CHECK_SH4A
>> /* Load non-boundary-aligned data */
>> @@ -1550,7 +1549,6 @@ static void _decode_opc(DisasContext * ctx)
>> MO_TEUL | MO_UNALN);
>> tcg_gen_addi_i32(REG(B11_8), REG(B11_8), 4);
>> return;
>> - break;
>> case 0x0029: /* movt Rn */
>> tcg_gen_mov_i32(REG(B11_8), cpu_sr_t);
>> return;
>> @@ -1638,7 +1636,6 @@ static void _decode_opc(DisasContext * ctx)
>> CHECK_SH4A
>> tcg_gen_mb(TCG_MO_ALL | TCG_BAR_SC);
>> return;
>> - break;
>> case 0x4024: /* rotcl Rn */
>> {
>> TCGv tmp = tcg_temp_new();
>>
>
> Reviewed-by: Thomas Huth <thuth@redhat.com>
>
>
Applied to my trivial-patches branch.
Thanks,
Laurent
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2020-09-01 6:40 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-07-13 9:05 [PATCH 11/12] target/sh4: Remove superfluous breaks Yi Wang
2020-07-13 9:38 ` Thomas Huth
2020-09-01 6:38 ` Laurent Vivier
2020-07-13 10:36 ` Philippe Mathieu-Daudé
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).