* [PATCH] Fix typo in CFI build documentation
@ 2021-04-22 8:33 Serge Guelton
2021-04-30 13:20 ` Laurent Vivier
0 siblings, 1 reply; 4+ messages in thread
From: Serge Guelton @ 2021-04-22 8:33 UTC (permalink / raw)
To: qemu-devel; +Cc: qemu-trivial, philmd, serge-sans-paille
From: serge-sans-paille <sguelton@redhat.com>
Signed-off-by: Serge Guelton <sguelton@redhat.com>
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
---
docs/devel/control-flow-integrity.rst | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/docs/devel/control-flow-integrity.rst b/docs/devel/control-flow-integrity.rst
index d89d707..e6b73a4 100644
--- a/docs/devel/control-flow-integrity.rst
+++ b/docs/devel/control-flow-integrity.rst
@@ -39,7 +39,7 @@ later).
Given the use of LTO, a version of AR that supports LLVM IR is required.
The easies way of doing this is by selecting the AR provided by LLVM::
- AR=llvm-ar-9 CC=clang-9 CXX=lang++-9 /path/to/configure --enable-cfi
+ AR=llvm-ar-9 CC=clang-9 CXX=clang++-9 /path/to/configure --enable-cfi
CFI is enabled on every binary produced.
@@ -131,7 +131,7 @@ lld with version 11+.
In other words, to compile with fuzzing and CFI, clang 11+ is required, and
lld needs to be used as a linker::
- AR=llvm-ar-11 CC=clang-11 CXX=lang++-11 /path/to/configure --enable-cfi \
+ AR=llvm-ar-11 CC=clang-11 CXX=clang++-11 /path/to/configure --enable-cfi \
-enable-fuzzing --extra-ldflags="-fuse-ld=lld"
and then, compile the fuzzers as usual.
--
1.8.3.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] Fix typo in CFI build documentation
2021-04-22 8:33 [PATCH] Fix typo in CFI build documentation Serge Guelton
@ 2021-04-30 13:20 ` Laurent Vivier
0 siblings, 0 replies; 4+ messages in thread
From: Laurent Vivier @ 2021-04-30 13:20 UTC (permalink / raw)
To: Serge Guelton, qemu-devel; +Cc: qemu-trivial, philmd
Le 22/04/2021 à 10:33, Serge Guelton a écrit :
> From: serge-sans-paille <sguelton@redhat.com>
>
> Signed-off-by: Serge Guelton <sguelton@redhat.com>
"If you wrote the patch, make sure your "From:" and "Signed-off-by:" lines use the same spelling."
https://wiki.qemu.org/Contribute/SubmitAPatch#Patch_emails_must_include_a_Signed-off-by:_line
Please fix this.
Thanks,
Laurent
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] Fix typo in CFI build documentation
2021-04-20 15:48 serge-sans-paille
@ 2021-04-21 13:55 ` Philippe Mathieu-Daudé
0 siblings, 0 replies; 4+ messages in thread
From: Philippe Mathieu-Daudé @ 2021-04-21 13:55 UTC (permalink / raw)
To: Serge Guelton, qemu-devel; +Cc: QEMU Trivial
Hi Serge,
Cc'ing qemu-trivial@
On 4/20/21 5:48 PM, serge-sans-paille wrote:
> Signed-off-by: serge-sans-paille <sguelton@redhat.com>
It looks your git-config is misconfigured... Maybe you used
an incorrect profile :) Can you repost please?
> ---
> docs/devel/control-flow-integrity.rst | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
For the fix:
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
>
> diff --git a/docs/devel/control-flow-integrity.rst b/docs/devel/control-flow-integrity.rst
> index d89d707..e6b73a4 100644
> --- a/docs/devel/control-flow-integrity.rst
> +++ b/docs/devel/control-flow-integrity.rst
> @@ -39,7 +39,7 @@ later).
> Given the use of LTO, a version of AR that supports LLVM IR is required.
> The easies way of doing this is by selecting the AR provided by LLVM::
>
> - AR=llvm-ar-9 CC=clang-9 CXX=lang++-9 /path/to/configure --enable-cfi
> + AR=llvm-ar-9 CC=clang-9 CXX=clang++-9 /path/to/configure --enable-cfi
>
> CFI is enabled on every binary produced.
>
> @@ -131,7 +131,7 @@ lld with version 11+.
> In other words, to compile with fuzzing and CFI, clang 11+ is required, and
> lld needs to be used as a linker::
>
> - AR=llvm-ar-11 CC=clang-11 CXX=lang++-11 /path/to/configure --enable-cfi \
> + AR=llvm-ar-11 CC=clang-11 CXX=clang++-11 /path/to/configure --enable-cfi \
> -enable-fuzzing --extra-ldflags="-fuse-ld=lld"
>
> and then, compile the fuzzers as usual.
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH] Fix typo in CFI build documentation
@ 2021-04-20 15:48 serge-sans-paille
2021-04-21 13:55 ` Philippe Mathieu-Daudé
0 siblings, 1 reply; 4+ messages in thread
From: serge-sans-paille @ 2021-04-20 15:48 UTC (permalink / raw)
To: qemu-devel; +Cc: serge-sans-paille
Signed-off-by: serge-sans-paille <sguelton@redhat.com>
---
docs/devel/control-flow-integrity.rst | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/docs/devel/control-flow-integrity.rst b/docs/devel/control-flow-integrity.rst
index d89d707..e6b73a4 100644
--- a/docs/devel/control-flow-integrity.rst
+++ b/docs/devel/control-flow-integrity.rst
@@ -39,7 +39,7 @@ later).
Given the use of LTO, a version of AR that supports LLVM IR is required.
The easies way of doing this is by selecting the AR provided by LLVM::
- AR=llvm-ar-9 CC=clang-9 CXX=lang++-9 /path/to/configure --enable-cfi
+ AR=llvm-ar-9 CC=clang-9 CXX=clang++-9 /path/to/configure --enable-cfi
CFI is enabled on every binary produced.
@@ -131,7 +131,7 @@ lld with version 11+.
In other words, to compile with fuzzing and CFI, clang 11+ is required, and
lld needs to be used as a linker::
- AR=llvm-ar-11 CC=clang-11 CXX=lang++-11 /path/to/configure --enable-cfi \
+ AR=llvm-ar-11 CC=clang-11 CXX=clang++-11 /path/to/configure --enable-cfi \
-enable-fuzzing --extra-ldflags="-fuse-ld=lld"
and then, compile the fuzzers as usual.
--
1.8.3.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
end of thread, other threads:[~2021-04-30 13:22 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-04-22 8:33 [PATCH] Fix typo in CFI build documentation Serge Guelton
2021-04-30 13:20 ` Laurent Vivier
-- strict thread matches above, loose matches on Subject: below --
2021-04-20 15:48 serge-sans-paille
2021-04-21 13:55 ` Philippe Mathieu-Daudé
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).