From: Claudio Fontana <cfontana@suse.de>
To: Eduardo Habkost <ehabkost@redhat.com>,
Paolo Bonzini <pbonzini@redhat.com>
Cc: "Peter Maydell" <peter.maydell@linaro.org>,
"Vitaly Kuznetsov" <vkuznets@redhat.com>,
"Philippe Mathieu-Daudé" <philmd@redhat.com>,
qemu-devel@nongnu.org, "Richard Henderson" <rth@twiddle.net>
Subject: Re: [PULL 07/17] i386: move hyperv_vendor_id initialization to x86_cpu_realizefn()
Date: Thu, 17 Dec 2020 23:33:57 +0100 [thread overview]
Message-ID: <e3168f16-b338-d758-34f6-ee5bff41e918@suse.de> (raw)
In-Reply-To: <20201217184620.3945917-8-ehabkost@redhat.com>
Hello all,
On 12/17/20 7:46 PM, Eduardo Habkost wrote:
> From: Vitaly Kuznetsov <vkuznets@redhat.com>
>
> As a preparation to expanding Hyper-V CPU features early, move
> hyperv_vendor_id initialization to x86_cpu_realizefn(). Introduce
> x86_cpu_hyperv_realize() to not not pollute x86_cpu_realizefn()
> itself.
this seems to fit very well the ongoing work on separating accelerator specific realize functions;
related to the previous discussions about the class hierarchies,
do you think that we should have a separate class in target/i386/kvm/ for a hyperv variant of the kvm-cpu.c?
Should it be a separate class or a subclass of "kvm-accel-x86_64-cpu" ?
Thanks,
Claudio
> Signed-off-by: Vitaly Kuznetsov <vkuznets@redhat.com>
> Message-Id: <20201119103221.1665171-2-vkuznets@redhat.com>
> Signed-off-by: Eduardo Habkost <ehabkost@redhat.com>
> ---
> target/i386/cpu.h | 3 ++-
> target/i386/cpu.c | 23 ++++++++++++++++++++++-
> target/i386/kvm/kvm.c | 25 ++++++++++---------------
> 3 files changed, 34 insertions(+), 17 deletions(-)
>
> diff --git a/target/i386/cpu.h b/target/i386/cpu.h
> index 343e51baab..ad9ef559fc 100644
> --- a/target/i386/cpu.h
> +++ b/target/i386/cpu.h
> @@ -1659,11 +1659,12 @@ struct X86CPU {
> uint64_t ucode_rev;
>
> uint32_t hyperv_spinlock_attempts;
> - char *hyperv_vendor_id;
> + char *hyperv_vendor;
> bool hyperv_synic_kvm_only;
> uint64_t hyperv_features;
> bool hyperv_passthrough;
> OnOffAuto hyperv_no_nonarch_cs;
> + uint32_t hyperv_vendor_id[3];
>
> bool check_cpuid;
> bool enforce_cpuid;
> diff --git a/target/i386/cpu.c b/target/i386/cpu.c
> index 77f0e44df8..599526406a 100644
> --- a/target/i386/cpu.c
> +++ b/target/i386/cpu.c
> @@ -6544,6 +6544,25 @@ static void x86_cpu_filter_features(X86CPU *cpu, bool verbose)
> }
> }
>
> +static void x86_cpu_hyperv_realize(X86CPU *cpu)
> +{
> + size_t len;
> +
> + /* Hyper-V vendor id */
> + if (!cpu->hyperv_vendor) {
> + memcpy(cpu->hyperv_vendor_id, "Microsoft Hv", 12);
> + } else {
> + len = strlen(cpu->hyperv_vendor);
> +
> + if (len > 12) {
> + warn_report("hv-vendor-id truncated to 12 characters");
> + len = 12;
> + }
> + memset(cpu->hyperv_vendor_id, 0, 12);
> + memcpy(cpu->hyperv_vendor_id, cpu->hyperv_vendor, len);
> + }
> +}
> +
> static void x86_cpu_realizefn(DeviceState *dev, Error **errp)
> {
> CPUState *cs = CPU(dev);
> @@ -6715,6 +6734,8 @@ static void x86_cpu_realizefn(DeviceState *dev, Error **errp)
> env->cache_info_amd.l3_cache = &legacy_l3_cache;
> }
>
> + /* Process Hyper-V enlightenments */
> + x86_cpu_hyperv_realize(cpu);
>
> cpu_exec_realizefn(cs, &local_err);
> if (local_err != NULL) {
> @@ -7218,7 +7239,7 @@ static Property x86_cpu_properties[] = {
> DEFINE_PROP_UINT32("min-xlevel2", X86CPU, env.cpuid_min_xlevel2, 0),
> DEFINE_PROP_UINT64("ucode-rev", X86CPU, ucode_rev, 0),
> DEFINE_PROP_BOOL("full-cpuid-auto-level", X86CPU, full_cpuid_auto_level, true),
> - DEFINE_PROP_STRING("hv-vendor-id", X86CPU, hyperv_vendor_id),
> + DEFINE_PROP_STRING("hv-vendor-id", X86CPU, hyperv_vendor),
> DEFINE_PROP_BOOL("cpuid-0xb", X86CPU, enable_cpuid_0xb, true),
> DEFINE_PROP_BOOL("lmce", X86CPU, enable_lmce, false),
> DEFINE_PROP_BOOL("l3-cache", X86CPU, enable_l3_cache, true),
> diff --git a/target/i386/kvm/kvm.c b/target/i386/kvm/kvm.c
> index bcfa4b03e0..6a5d91e39f 100644
> --- a/target/i386/kvm/kvm.c
> +++ b/target/i386/kvm/kvm.c
> @@ -1208,6 +1208,13 @@ static int hyperv_handle_properties(CPUState *cs,
> memcpy(cpuid_ent, &cpuid->entries[0],
> cpuid->nent * sizeof(cpuid->entries[0]));
>
> + c = cpuid_find_entry(cpuid, HV_CPUID_VENDOR_AND_MAX_FUNCTIONS, 0);
> + if (c) {
> + cpu->hyperv_vendor_id[0] = c->ebx;
> + cpu->hyperv_vendor_id[1] = c->ecx;
> + cpu->hyperv_vendor_id[2] = c->edx;
> + }
> +
> c = cpuid_find_entry(cpuid, HV_CPUID_FEATURES, 0);
> if (c) {
> env->features[FEAT_HYPERV_EAX] = c->eax;
> @@ -1282,23 +1289,11 @@ static int hyperv_handle_properties(CPUState *cs,
>
> c = &cpuid_ent[cpuid_i++];
> c->function = HV_CPUID_VENDOR_AND_MAX_FUNCTIONS;
> - if (!cpu->hyperv_vendor_id) {
> - memcpy(signature, "Microsoft Hv", 12);
> - } else {
> - size_t len = strlen(cpu->hyperv_vendor_id);
> -
> - if (len > 12) {
> - error_report("hv-vendor-id truncated to 12 characters");
> - len = 12;
> - }
> - memset(signature, 0, 12);
> - memcpy(signature, cpu->hyperv_vendor_id, len);
> - }
> c->eax = hyperv_feat_enabled(cpu, HYPERV_FEAT_EVMCS) ?
> HV_CPUID_NESTED_FEATURES : HV_CPUID_IMPLEMENT_LIMITS;
> - c->ebx = signature[0];
> - c->ecx = signature[1];
> - c->edx = signature[2];
> + c->ebx = cpu->hyperv_vendor_id[0];
> + c->ecx = cpu->hyperv_vendor_id[1];
> + c->edx = cpu->hyperv_vendor_id[2];
>
> c = &cpuid_ent[cpuid_i++];
> c->function = HV_CPUID_INTERFACE;
>
next prev parent reply other threads:[~2020-12-17 22:35 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-17 18:46 [PULL 00/17] x86 queue, 2020-12-17 Eduardo Habkost
2020-12-17 18:46 ` [PULL 01/17] i386: move kvm accel files into kvm/ Eduardo Habkost
2020-12-17 18:46 ` [PULL 02/17] i386: move whpx accel files into whpx/ Eduardo Habkost
2020-12-17 18:46 ` [PULL 03/17] i386: move hax accel files into hax/ Eduardo Habkost
2020-12-17 18:46 ` [PULL 04/17] i386: hvf: remove stale MAINTAINERS entry for old hvf stubs Eduardo Habkost
2020-12-17 18:46 ` [PULL 05/17] i386: move TCG accel files into tcg/ Eduardo Habkost
2020-12-17 18:46 ` [PULL 06/17] i386: move cpu dump out of helper.c into cpu-dump.c Eduardo Habkost
2020-12-17 18:46 ` [PULL 07/17] i386: move hyperv_vendor_id initialization to x86_cpu_realizefn() Eduardo Habkost
2020-12-17 22:33 ` Claudio Fontana [this message]
2020-12-17 22:53 ` Eduardo Habkost
2020-12-17 23:34 ` Claudio Fontana
2020-12-17 23:47 ` Eduardo Habkost
2020-12-18 0:07 ` Claudio Fontana
2020-12-18 1:05 ` Eduardo Habkost
2020-12-18 8:50 ` Claudio Fontana
2020-12-17 18:46 ` [PULL 08/17] i386: move hyperv_interface_id " Eduardo Habkost
2020-12-17 18:46 ` [PULL 09/17] i386: move hyperv_version_id " Eduardo Habkost
2020-12-17 18:46 ` [PULL 10/17] i386: move hyperv_limits " Eduardo Habkost
2020-12-17 18:46 ` [PULL 11/17] x86/cpu: Add AVX512_FP16 cpu feature Eduardo Habkost
2020-12-17 18:46 ` [PULL 12/17] i386: move TCG cpu class initialization to tcg/ Eduardo Habkost
2020-12-17 18:46 ` [PULL 13/17] i386: tcg: remove inline from cpu_load_eflags Eduardo Habkost
2020-12-17 18:46 ` [PULL 14/17] tcg: cpu_exec_{enter,exit} helpers Eduardo Habkost
2020-12-17 18:46 ` [PULL 15/17] tcg: make CPUClass.cpu_exec_* optional Eduardo Habkost
2020-12-17 18:46 ` [PULL 16/17] tcg: Make CPUClass.debug_excp_handler optional Eduardo Habkost
2020-12-17 18:46 ` [PULL 17/17] cpu: Remove unnecessary noop methods Eduardo Habkost
2020-12-17 20:48 ` [PULL 00/17] x86 queue, 2020-12-17 Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e3168f16-b338-d758-34f6-ee5bff41e918@suse.de \
--to=cfontana@suse.de \
--cc=ehabkost@redhat.com \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=philmd@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=rth@twiddle.net \
--cc=vkuznets@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).