* [PATCH 02/12] target/ppc: Remove superfluous breaks
@ 2020-07-13 9:03 Yi Wang
2020-07-13 9:30 ` Thomas Huth
2020-07-13 10:38 ` Philippe Mathieu-Daudé
0 siblings, 2 replies; 4+ messages in thread
From: Yi Wang @ 2020-07-13 9:03 UTC (permalink / raw)
To: qemu-devel; +Cc: wang.yi59, Liao Pingfang, wang.liang82, xue.zhihong
From: Liao Pingfang <liao.pingfang@zte.com.cn>
Remove superfluous breaks, as there is a "return" before them.
Signed-off-by: Liao Pingfang <liao.pingfang@zte.com.cn>
Signed-off-by: Yi Wang <wang.yi59@zte.com.cn>
Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
---
target/ppc/misc_helper.c | 5 -----
1 file changed, 5 deletions(-)
diff --git a/target/ppc/misc_helper.c b/target/ppc/misc_helper.c
index 55b68d1..e43a3b4 100644
--- a/target/ppc/misc_helper.c
+++ b/target/ppc/misc_helper.c
@@ -234,25 +234,20 @@ target_ulong helper_clcs(CPUPPCState *env, uint32_t arg)
case 0x0CUL:
/* Instruction cache line size */
return env->icache_line_size;
- break;
case 0x0DUL:
/* Data cache line size */
return env->dcache_line_size;
- break;
case 0x0EUL:
/* Minimum cache line size */
return (env->icache_line_size < env->dcache_line_size) ?
env->icache_line_size : env->dcache_line_size;
- break;
case 0x0FUL:
/* Maximum cache line size */
return (env->icache_line_size > env->dcache_line_size) ?
env->icache_line_size : env->dcache_line_size;
- break;
default:
/* Undefined */
return 0;
- break;
}
}
--
2.9.5
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH 02/12] target/ppc: Remove superfluous breaks
2020-07-13 9:03 [PATCH 02/12] target/ppc: Remove superfluous breaks Yi Wang
@ 2020-07-13 9:30 ` Thomas Huth
2020-09-01 6:34 ` Laurent Vivier
2020-07-13 10:38 ` Philippe Mathieu-Daudé
1 sibling, 1 reply; 4+ messages in thread
From: Thomas Huth @ 2020-07-13 9:30 UTC (permalink / raw)
To: Yi Wang, qemu-devel
Cc: wang.liang82, QEMU Trivial, qemu-ppc, xue.zhihong, Liao Pingfang,
David Gibson
On 13/07/2020 11.03, Yi Wang wrote:
> From: Liao Pingfang <liao.pingfang@zte.com.cn>
>
> Remove superfluous breaks, as there is a "return" before them.
>
> Signed-off-by: Liao Pingfang <liao.pingfang@zte.com.cn>
> Signed-off-by: Yi Wang <wang.yi59@zte.com.cn>
> Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
> ---
> target/ppc/misc_helper.c | 5 -----
> 1 file changed, 5 deletions(-)
>
> diff --git a/target/ppc/misc_helper.c b/target/ppc/misc_helper.c
> index 55b68d1..e43a3b4 100644
> --- a/target/ppc/misc_helper.c
> +++ b/target/ppc/misc_helper.c
> @@ -234,25 +234,20 @@ target_ulong helper_clcs(CPUPPCState *env, uint32_t arg)
> case 0x0CUL:
> /* Instruction cache line size */
> return env->icache_line_size;
> - break;
> case 0x0DUL:
> /* Data cache line size */
> return env->dcache_line_size;
> - break;
> case 0x0EUL:
> /* Minimum cache line size */
> return (env->icache_line_size < env->dcache_line_size) ?
> env->icache_line_size : env->dcache_line_size;
> - break;
> case 0x0FUL:
> /* Maximum cache line size */
> return (env->icache_line_size > env->dcache_line_size) ?
> env->icache_line_size : env->dcache_line_size;
> - break;
> default:
> /* Undefined */
> return 0;
> - break;
> }
> }
>
>
Reviewed-by: Thomas Huth <thuth@redhat.com>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH 02/12] target/ppc: Remove superfluous breaks
2020-07-13 9:03 [PATCH 02/12] target/ppc: Remove superfluous breaks Yi Wang
2020-07-13 9:30 ` Thomas Huth
@ 2020-07-13 10:38 ` Philippe Mathieu-Daudé
1 sibling, 0 replies; 4+ messages in thread
From: Philippe Mathieu-Daudé @ 2020-07-13 10:38 UTC (permalink / raw)
To: Yi Wang, qemu-devel; +Cc: xue.zhihong, wang.liang82, Liao Pingfang
On 7/13/20 11:03 AM, Yi Wang wrote:
> From: Liao Pingfang <liao.pingfang@zte.com.cn>
>
> Remove superfluous breaks, as there is a "return" before them.
>
> Signed-off-by: Liao Pingfang <liao.pingfang@zte.com.cn>
> Signed-off-by: Yi Wang <wang.yi59@zte.com.cn>
> Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
I hadn't reviewed this patch, but now I did (you can strip the space
at the end of the line).
> ---
> target/ppc/misc_helper.c | 5 -----
> 1 file changed, 5 deletions(-)
>
> diff --git a/target/ppc/misc_helper.c b/target/ppc/misc_helper.c
> index 55b68d1..e43a3b4 100644
> --- a/target/ppc/misc_helper.c
> +++ b/target/ppc/misc_helper.c
> @@ -234,25 +234,20 @@ target_ulong helper_clcs(CPUPPCState *env, uint32_t arg)
> case 0x0CUL:
> /* Instruction cache line size */
> return env->icache_line_size;
> - break;
> case 0x0DUL:
> /* Data cache line size */
> return env->dcache_line_size;
> - break;
> case 0x0EUL:
> /* Minimum cache line size */
> return (env->icache_line_size < env->dcache_line_size) ?
> env->icache_line_size : env->dcache_line_size;
> - break;
> case 0x0FUL:
> /* Maximum cache line size */
> return (env->icache_line_size > env->dcache_line_size) ?
> env->icache_line_size : env->dcache_line_size;
> - break;
> default:
> /* Undefined */
> return 0;
> - break;
> }
> }
>
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH 02/12] target/ppc: Remove superfluous breaks
2020-07-13 9:30 ` Thomas Huth
@ 2020-09-01 6:34 ` Laurent Vivier
0 siblings, 0 replies; 4+ messages in thread
From: Laurent Vivier @ 2020-09-01 6:34 UTC (permalink / raw)
To: Thomas Huth, Yi Wang, qemu-devel
Cc: wang.liang82, QEMU Trivial, qemu-ppc, xue.zhihong, Liao Pingfang,
David Gibson
Le 13/07/2020 à 11:30, Thomas Huth a écrit :
> On 13/07/2020 11.03, Yi Wang wrote:
>> From: Liao Pingfang <liao.pingfang@zte.com.cn>
>>
>> Remove superfluous breaks, as there is a "return" before them.
>>
>> Signed-off-by: Liao Pingfang <liao.pingfang@zte.com.cn>
>> Signed-off-by: Yi Wang <wang.yi59@zte.com.cn>
>> Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
>> ---
>> target/ppc/misc_helper.c | 5 -----
>> 1 file changed, 5 deletions(-)
>>
>> diff --git a/target/ppc/misc_helper.c b/target/ppc/misc_helper.c
>> index 55b68d1..e43a3b4 100644
>> --- a/target/ppc/misc_helper.c
>> +++ b/target/ppc/misc_helper.c
>> @@ -234,25 +234,20 @@ target_ulong helper_clcs(CPUPPCState *env, uint32_t arg)
>> case 0x0CUL:
>> /* Instruction cache line size */
>> return env->icache_line_size;
>> - break;
>> case 0x0DUL:
>> /* Data cache line size */
>> return env->dcache_line_size;
>> - break;
>> case 0x0EUL:
>> /* Minimum cache line size */
>> return (env->icache_line_size < env->dcache_line_size) ?
>> env->icache_line_size : env->dcache_line_size;
>> - break;
>> case 0x0FUL:
>> /* Maximum cache line size */
>> return (env->icache_line_size > env->dcache_line_size) ?
>> env->icache_line_size : env->dcache_line_size;
>> - break;
>> default:
>> /* Undefined */
>> return 0;
>> - break;
>> }
>> }
>>
>>
>
> Reviewed-by: Thomas Huth <thuth@redhat.com>
>
>
Applied to my trivial-patches branch.
Thanks,
Laurent
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2020-09-01 6:35 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-07-13 9:03 [PATCH 02/12] target/ppc: Remove superfluous breaks Yi Wang
2020-07-13 9:30 ` Thomas Huth
2020-09-01 6:34 ` Laurent Vivier
2020-07-13 10:38 ` Philippe Mathieu-Daudé
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).