qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Tony Nguyen <tony.nguyen@bt.com>
To: qemu-devel@nongnu.org
Cc: Tony Nguyen <tony.nguyen@bt.com>,
	Alex Williamson <alex.williamson@redhat.com>,
	Cornelia Huck <cohuck@redhat.com>,
	Richard Henderson <richard.henderson@linaro.org>
Subject: [Qemu-devel] [PATCH v9 07/20] hw/vfio: Access MemoryRegion with MemOp
Date: Sat, 24 Aug 2019 04:36:45 +1000	[thread overview]
Message-ID: <e70ff5814ac3656974180db6375397c43b0bc8b8.1566466906.git.tony.nguyen@bt.com> (raw)
In-Reply-To: <cover.1566466906.git.tony.nguyen@bt.com>

The memory_region_dispatch_{read|write} operand "unsigned size" is
being converted into a "MemOp op".

Convert interfaces by using no-op size_memop.

After all interfaces are converted, size_memop will be implemented
and the memory_region_dispatch_{read|write} operand "unsigned size"
will be converted into a "MemOp op".

As size_memop is a no-op, this patch does not change any behaviour.

Signed-off-by: Tony Nguyen <tony.nguyen@bt.com>
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
Reviewed-by: Cornelia Huck <cohuck@redhat.com>
---
 hw/vfio/pci-quirks.c | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/hw/vfio/pci-quirks.c b/hw/vfio/pci-quirks.c
index f71aace156..a4e1d2abb5 100644
--- a/hw/vfio/pci-quirks.c
+++ b/hw/vfio/pci-quirks.c
@@ -11,6 +11,7 @@
  */
 
 #include "qemu/osdep.h"
+#include "exec/memop.h"
 #include "qemu/units.h"
 #include "qemu/error-report.h"
 #include "qemu/main-loop.h"
@@ -1073,7 +1074,7 @@ static void vfio_rtl8168_quirk_address_write(void *opaque, hwaddr addr,
 
                 /* Write to the proper guest MSI-X table instead */
                 memory_region_dispatch_write(&vdev->pdev.msix_table_mmio,
-                                             offset, val, size,
+                                             offset, val, size_memop(size),
                                              MEMTXATTRS_UNSPECIFIED);
             }
             return; /* Do not write guest MSI-X data to hardware */
@@ -1104,7 +1105,8 @@ static uint64_t vfio_rtl8168_quirk_data_read(void *opaque,
     if (rtl->enabled && (vdev->pdev.cap_present & QEMU_PCI_CAP_MSIX)) {
         hwaddr offset = rtl->addr & 0xfff;
         memory_region_dispatch_read(&vdev->pdev.msix_table_mmio, offset,
-                                    &data, size, MEMTXATTRS_UNSPECIFIED);
+                                    &data, size_memop(size),
+                                    MEMTXATTRS_UNSPECIFIED);
         trace_vfio_quirk_rtl8168_msix_read(vdev->vbasedev.name, offset, data);
     }
 
-- 
2.23.0



  parent reply	other threads:[~2019-08-23 18:40 UTC|newest]

Thread overview: 29+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-08-23  1:19 [Qemu-devel] [PATCH v9 00/20] Invert Endian bit in SPARCv9 MMU TTE Tony Nguyen
2019-08-23  1:02 ` Tony Nguyen
2019-08-23  2:29 ` Richard Henderson
2019-08-23 12:25   ` tony.nguyen
2019-08-23 16:46     ` Richard Henderson
2019-08-23 18:51     ` Richard Henderson
2019-08-23 18:10 ` [Qemu-devel] [PATCH v9 01/20] tcg: TCGMemOp is now accelerator independent MemOp Tony Nguyen
2019-08-23 18:29 ` [Qemu-devel] [PATCH v9 02/20] memory: Introduce size_memop Tony Nguyen
2019-08-23 18:36 ` [Qemu-devel] [PATCH v9 03/20] target/mips: Access MemoryRegion with MemOp Tony Nguyen
2019-08-23 18:36 ` [Qemu-devel] [PATCH v9 04/20] hw/s390x: " Tony Nguyen
2019-08-23 18:36 ` [Qemu-devel] [PATCH v9 05/20] hw/intc/armv7m_nic: " Tony Nguyen
2019-08-23 18:36 ` [Qemu-devel] [PATCH v9 06/20] hw/virtio: " Tony Nguyen
2019-08-23 18:36 ` Tony Nguyen [this message]
2019-08-23 18:36 ` [Qemu-devel] [PATCH v9 08/20] exec: " Tony Nguyen
2019-08-23 18:36 ` [Qemu-devel] [PATCH v9 09/20] cputlb: " Tony Nguyen
2019-08-23 18:36 ` [Qemu-devel] [PATCH v9 10/20] memory: " Tony Nguyen
2019-08-23 18:36 ` [Qemu-devel] [PATCH v9 11/20] hw/s390x: Hard code size with MO_{8|16|32|64} Tony Nguyen
2019-08-23 18:36 ` [Qemu-devel] [PATCH v9 12/20] target/mips: " Tony Nguyen
2019-08-23 18:36 ` [Qemu-devel] [PATCH v9 13/20] exec: " Tony Nguyen
2019-08-23 18:36 ` [Qemu-devel] [PATCH v9 14/20] memory: Access MemoryRegion with endianness Tony Nguyen
2019-08-23 19:04   ` Richard Henderson
2019-08-23 18:36 ` [Qemu-devel] [PATCH v9 15/20] cputlb: Replace size and endian operands for MemOp Tony Nguyen
2019-08-23 18:36 ` [Qemu-devel] [PATCH v9 16/20] memory: Single byte swap along the I/O path Tony Nguyen
2019-08-23 19:12   ` Richard Henderson
2019-08-23 18:36 ` [Qemu-devel] [PATCH v9 17/20] cpu: TLB_FLAGS_MASK bit to force memory slow path Tony Nguyen
2019-08-23 22:27   ` Richard Henderson
2019-08-23 18:36 ` [Qemu-devel] [PATCH v9 18/20] cputlb: Byte swap memory transaction attribute Tony Nguyen
2019-08-23 18:36 ` [Qemu-devel] [PATCH v9 19/20] target/sparc: Add TLB entry with attributes Tony Nguyen
2019-08-23 18:36 ` [Qemu-devel] [PATCH v9 20/20] target/sparc: sun4u Invert Endian TTE bit Tony Nguyen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=e70ff5814ac3656974180db6375397c43b0bc8b8.1566466906.git.tony.nguyen@bt.com \
    --to=tony.nguyen@bt.com \
    --cc=alex.williamson@redhat.com \
    --cc=cohuck@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=richard.henderson@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).