qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: "Philippe Mathieu-Daudé" <philmd@redhat.com>
To: Thomas Huth <thuth@redhat.com>, qemu-devel@nongnu.org
Cc: "Philippe Mathieu-Daudé" <f4bug@amsat.org>,
	"Wainer dos Santos Moschetta" <wainersm@redhat.com>,
	"Willian Rampazzo" <willianr@redhat.com>,
	"Claudio Fontana" <cfontana@suse.de>,
	"Paolo Bonzini" <pbonzini@redhat.com>,
	"Alex Bennée" <alex.bennee@linaro.org>
Subject: Re: [PATCH 1/1] gitlab-ci: Add KVM x86 cross-build jobs
Date: Wed, 12 May 2021 07:06:34 +0200	[thread overview]
Message-ID: <e8f7ad46-fe09-1027-be13-114003f12fa6@redhat.com> (raw)
In-Reply-To: <cb1077a4-a1ff-b88c-f648-7dfbbfafebc3@redhat.com>

On 5/12/21 6:57 AM, Thomas Huth wrote:
> On 12/05/2021 06.42, Philippe Mathieu-Daudé wrote:
>> Add a new job to cross-build the x86 target without the
>> TCG/XEN accelerators (IOW: only KVM accelerator enabled).
>>
>> Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
>> ---
>>   .gitlab-ci.d/crossbuilds.yml | 8 ++++++++
>>   1 file changed, 8 insertions(+)
>>
>> diff --git a/.gitlab-ci.d/crossbuilds.yml b/.gitlab-ci.d/crossbuilds.yml
>> index e44e4b49a25..a8eac2cddba 100644
>> --- a/.gitlab-ci.d/crossbuilds.yml
>> +++ b/.gitlab-ci.d/crossbuilds.yml
>> @@ -198,6 +198,14 @@ cross-win64-system:
>>     variables:
>>       IMAGE: fedora-win64-cross
>>   +cross-i386-kvm-only:
>> +  extends: .cross_accel_build_job
>> +  needs:
>> +    job: i386-fedora-cross-container
>> +  variables:
>> +    IMAGE: fedora-i386-cross
>> +    ACCEL_CONFIGURE_OPTS: --disable-tcg --disable-xen
> 
> We already have build-tcg-disabled in the main .gitlab-ci.yml file ...
> so I fail to see what additional test coverage we get by this job?

Doh I missed build-tcg-disabled was the x86 job, sorry.

Please disregard this patch!



      reply	other threads:[~2021-05-12  5:07 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-05-12  4:42 [PATCH 0/1] gitlab-ci: Add KVM x86 cross-build jobs Philippe Mathieu-Daudé
2021-05-12  4:42 ` [PATCH 1/1] " Philippe Mathieu-Daudé
2021-05-12  4:57   ` Thomas Huth
2021-05-12  5:06     ` Philippe Mathieu-Daudé [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=e8f7ad46-fe09-1027-be13-114003f12fa6@redhat.com \
    --to=philmd@redhat.com \
    --cc=alex.bennee@linaro.org \
    --cc=cfontana@suse.de \
    --cc=f4bug@amsat.org \
    --cc=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=thuth@redhat.com \
    --cc=wainersm@redhat.com \
    --cc=willianr@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).