[PATCH 0/1] gitlab-ci: Add KVM x86 cross-build jobs

[PATCH 0/1] gitlab-ci: Add KVM x86 cross-build jobs

[Philippe Mathieu-Daudé]

Add a job to avoid breaking x86 KVM-only builds (the feature recently
added by Claudio):
https://gitlab.com/philmd/qemu/-/jobs/1255115665

Paolo, (assuming Thomas Acks the patch), could you queue it on top
of your current pull request?

Based-on: <20210511081350.419428-1-pbonzini@redhat.com>
https://gitlab.com/bonzini/qemu.git tags/for-upstream

Philippe Mathieu-Daudé (1):
  gitlab-ci: Add KVM x86 cross-build jobs

 .gitlab-ci.d/crossbuilds.yml | 8 ++++++++
 1 file changed, 8 insertions(+)

-- 
2.26.3

[PATCH 1/1] gitlab-ci: Add KVM x86 cross-build jobs

[Philippe Mathieu-Daudé]

Add a new job to cross-build the x86 target without the
TCG/XEN accelerators (IOW: only KVM accelerator enabled).

Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
---
 .gitlab-ci.d/crossbuilds.yml | 8 ++++++++
 1 file changed, 8 insertions(+)

diff --git a/.gitlab-ci.d/crossbuilds.yml b/.gitlab-ci.d/crossbuilds.yml
index e44e4b49a25..a8eac2cddba 100644
--- a/.gitlab-ci.d/crossbuilds.yml
+++ b/.gitlab-ci.d/crossbuilds.yml
@@ -198,6 +198,14 @@ cross-win64-system:
   variables:
     IMAGE: fedora-win64-cross
 
+cross-i386-kvm-only:
+  extends: .cross_accel_build_job
+  needs:
+    job: i386-fedora-cross-container
+  variables:
+    IMAGE: fedora-i386-cross
+    ACCEL_CONFIGURE_OPTS: --disable-tcg --disable-xen
+
 cross-amd64-xen-only:
   extends: .cross_accel_build_job
   needs:
-- 
2.26.3

Re: [PATCH 1/1] gitlab-ci: Add KVM x86 cross-build jobs

[Thomas Huth]

On 12/05/2021 06.42, Philippe Mathieu-Daudé wrote:
> Add a new job to cross-build the x86 target without the
> TCG/XEN accelerators (IOW: only KVM accelerator enabled).
> 
> Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
> ---
>   .gitlab-ci.d/crossbuilds.yml | 8 ++++++++
>   1 file changed, 8 insertions(+)
> 
> diff --git a/.gitlab-ci.d/crossbuilds.yml b/.gitlab-ci.d/crossbuilds.yml
> index e44e4b49a25..a8eac2cddba 100644
> --- a/.gitlab-ci.d/crossbuilds.yml
> +++ b/.gitlab-ci.d/crossbuilds.yml
> @@ -198,6 +198,14 @@ cross-win64-system:
>     variables:
>       IMAGE: fedora-win64-cross
>   
> +cross-i386-kvm-only:
> +  extends: .cross_accel_build_job
> +  needs:
> +    job: i386-fedora-cross-container
> +  variables:
> +    IMAGE: fedora-i386-cross
> +    ACCEL_CONFIGURE_OPTS: --disable-tcg --disable-xen

We already have build-tcg-disabled in the main .gitlab-ci.yml file ... so I 
fail to see what additional test coverage we get by this job?

  Thomas

Re: [PATCH 1/1] gitlab-ci: Add KVM x86 cross-build jobs

[Philippe Mathieu-Daudé]

On 5/12/21 6:57 AM, Thomas Huth wrote:
> On 12/05/2021 06.42, Philippe Mathieu-Daudé wrote:
>> Add a new job to cross-build the x86 target without the
>> TCG/XEN accelerators (IOW: only KVM accelerator enabled).
>>
>> Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
>> ---
>>   .gitlab-ci.d/crossbuilds.yml | 8 ++++++++
>>   1 file changed, 8 insertions(+)
>>
>> diff --git a/.gitlab-ci.d/crossbuilds.yml b/.gitlab-ci.d/crossbuilds.yml
>> index e44e4b49a25..a8eac2cddba 100644
>> --- a/.gitlab-ci.d/crossbuilds.yml
>> +++ b/.gitlab-ci.d/crossbuilds.yml
>> @@ -198,6 +198,14 @@ cross-win64-system:
>>     variables:
>>       IMAGE: fedora-win64-cross
>>   +cross-i386-kvm-only:
>> +  extends: .cross_accel_build_job
>> +  needs:
>> +    job: i386-fedora-cross-container
>> +  variables:
>> +    IMAGE: fedora-i386-cross
>> +    ACCEL_CONFIGURE_OPTS: --disable-tcg --disable-xen
> 
> We already have build-tcg-disabled in the main .gitlab-ci.yml file ...
> so I fail to see what additional test coverage we get by this job?

Doh I missed build-tcg-disabled was the x86 job, sorry.

Please disregard this patch!