[PATCH] hw/elf_ops: Fix a typo

[PATCH] hw/elf_ops: Fix a typo

[Philippe Mathieu-Daudé]

g_mapped_file_new_from_fd()'s parameter is named 'writable'.

Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
---
 include/hw/elf_ops.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/include/hw/elf_ops.h b/include/hw/elf_ops.h
index 8e8436831d2..304f266bf3b 100644
--- a/include/hw/elf_ops.h
+++ b/include/hw/elf_ops.h
@@ -417,7 +417,7 @@ static int glue(load_elf, SZ)(const char *name, int fd,
 
     /*
      * Since we want to be able to modify the mapped buffer, we set the
-     * 'writeble' parameter to 'true'. Modifications to the buffer are not
+     * 'writable' parameter to 'true'. Modifications to the buffer are not
      * written back to the file.
      */
     mapped_file = g_mapped_file_new_from_fd(fd, true, NULL);
-- 
2.26.2

Re: [PATCH] hw/elf_ops: Fix a typo

[Stefano Garzarella]

On Thu, Feb 25, 2021 at 07:13:44PM +0100, Philippe Mathieu-Daudé wrote:
>g_mapped_file_new_from_fd()'s parameter is named 'writable'.
>
>Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
>---
> include/hw/elf_ops.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/include/hw/elf_ops.h b/include/hw/elf_ops.h
>index 8e8436831d2..304f266bf3b 100644
>--- a/include/hw/elf_ops.h
>+++ b/include/hw/elf_ops.h
>@@ -417,7 +417,7 @@ static int glue(load_elf, SZ)(const char *name, int fd,
>
>     /*
>      * Since we want to be able to modify the mapped buffer, we set the
>-     * 'writeble' parameter to 'true'. Modifications to the buffer are not
>+     * 'writable' parameter to 'true'. Modifications to the buffer are not

Oooops :-)

Reviewed-by: Stefano Garzarella <sgarzare@redhat.com>

Re: [PATCH] hw/elf_ops: Fix a typo

[David Edmondson]

On Thursday, 2021-02-25 at 19:13:44 +01, Philippe Mathieu-Daudé wrote:

> g_mapped_file_new_from_fd()'s parameter is named 'writable'.
>
> Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>

Reviewed-by: David Edmondson <dme@dme.org>

> ---
>  include/hw/elf_ops.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/include/hw/elf_ops.h b/include/hw/elf_ops.h
> index 8e8436831d2..304f266bf3b 100644
> --- a/include/hw/elf_ops.h
> +++ b/include/hw/elf_ops.h
> @@ -417,7 +417,7 @@ static int glue(load_elf, SZ)(const char *name, int fd,
>  
>      /*
>       * Since we want to be able to modify the mapped buffer, we set the
> -     * 'writeble' parameter to 'true'. Modifications to the buffer are not
> +     * 'writable' parameter to 'true'. Modifications to the buffer are not
>       * written back to the file.
>       */
>      mapped_file = g_mapped_file_new_from_fd(fd, true, NULL);
> -- 
> 2.26.2

dme.
-- 
I've always been mad, I know I've been mad, like the most of us are.

Re: [PATCH] hw/elf_ops: Fix a typo

[Laurent Vivier]

Le 25/02/2021 à 19:13, Philippe Mathieu-Daudé a écrit :
> g_mapped_file_new_from_fd()'s parameter is named 'writable'.
> 
> Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
> ---
>  include/hw/elf_ops.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/include/hw/elf_ops.h b/include/hw/elf_ops.h
> index 8e8436831d2..304f266bf3b 100644
> --- a/include/hw/elf_ops.h
> +++ b/include/hw/elf_ops.h
> @@ -417,7 +417,7 @@ static int glue(load_elf, SZ)(const char *name, int fd,
>  
>      /*
>       * Since we want to be able to modify the mapped buffer, we set the
> -     * 'writeble' parameter to 'true'. Modifications to the buffer are not
> +     * 'writable' parameter to 'true'. Modifications to the buffer are not
>       * written back to the file.
>       */
>      mapped_file = g_mapped_file_new_from_fd(fd, true, NULL);
> 

Applied to my trivial-patches branch.

Thanks,
Laurent