* [PATCH] qemu-options: replace constant 1 with HAS_ARG
@ 2020-02-04 16:56 John Snow
2020-02-04 17:29 ` Eric Blake
` (3 more replies)
0 siblings, 4 replies; 5+ messages in thread
From: John Snow @ 2020-02-04 16:56 UTC (permalink / raw)
To: qemu-devel; +Cc: qemu-trivial, thuth, John Snow, armbru
This is the only instance of a non-zero constant not using a symbolic
constant.
---
qemu-options.hx | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/qemu-options.hx b/qemu-options.hx
index 224a8e8712..ff3e806977 100644
--- a/qemu-options.hx
+++ b/qemu-options.hx
@@ -1955,7 +1955,7 @@ STEXI
Start in full screen.
ETEXI
-DEF("g", 1, QEMU_OPTION_g ,
+DEF("g", HAS_ARG, QEMU_OPTION_g ,
"-g WxH[xDEPTH] Set the initial graphical resolution and depth\n",
QEMU_ARCH_PPC | QEMU_ARCH_SPARC | QEMU_ARCH_M68K)
STEXI
--
2.21.0
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH] qemu-options: replace constant 1 with HAS_ARG
2020-02-04 16:56 [PATCH] qemu-options: replace constant 1 with HAS_ARG John Snow
@ 2020-02-04 17:29 ` Eric Blake
2020-02-04 18:58 ` no-reply
` (2 subsequent siblings)
3 siblings, 0 replies; 5+ messages in thread
From: Eric Blake @ 2020-02-04 17:29 UTC (permalink / raw)
To: John Snow, qemu-devel; +Cc: qemu-trivial, thuth, armbru
On 2/4/20 10:56 AM, John Snow wrote:
> This is the only instance of a non-zero constant not using a symbolic
> constant.
> ---
> qemu-options.hx | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
Reviewed-by: Eric Blake <eblake@redhat.com>
> diff --git a/qemu-options.hx b/qemu-options.hx
> index 224a8e8712..ff3e806977 100644
> --- a/qemu-options.hx
> +++ b/qemu-options.hx
> @@ -1955,7 +1955,7 @@ STEXI
> Start in full screen.
> ETEXI
>
> -DEF("g", 1, QEMU_OPTION_g ,
> +DEF("g", HAS_ARG, QEMU_OPTION_g ,
> "-g WxH[xDEPTH] Set the initial graphical resolution and depth\n",
> QEMU_ARCH_PPC | QEMU_ARCH_SPARC | QEMU_ARCH_M68K)
> STEXI
>
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3226
Virtualization: qemu.org | libvirt.org
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] qemu-options: replace constant 1 with HAS_ARG
2020-02-04 16:56 [PATCH] qemu-options: replace constant 1 with HAS_ARG John Snow
2020-02-04 17:29 ` Eric Blake
@ 2020-02-04 18:58 ` no-reply
2020-02-04 19:06 ` John Snow
2020-02-06 10:09 ` Laurent Vivier
3 siblings, 0 replies; 5+ messages in thread
From: no-reply @ 2020-02-04 18:58 UTC (permalink / raw)
To: jsnow; +Cc: qemu-trivial, thuth, jsnow, qemu-devel, armbru
Patchew URL: https://patchew.org/QEMU/20200204165638.25051-1-jsnow@redhat.com/
Hi,
This series seems to have some coding style problems. See output below for
more information:
Subject: [PATCH] qemu-options: replace constant 1 with HAS_ARG
Message-id: 20200204165638.25051-1-jsnow@redhat.com
Type: series
=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===
Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
Switched to a new branch 'test'
3af73ec qemu-options: replace constant 1 with HAS_ARG
=== OUTPUT BEGIN ===
ERROR: Missing Signed-off-by: line(s)
total: 1 errors, 0 warnings, 8 lines checked
Commit 3af73ec9eaff (qemu-options: replace constant 1 with HAS_ARG) has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
=== OUTPUT END ===
Test command exited with code: 1
The full log is available at
http://patchew.org/logs/20200204165638.25051-1-jsnow@redhat.com/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to patchew-devel@redhat.com
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] qemu-options: replace constant 1 with HAS_ARG
2020-02-04 16:56 [PATCH] qemu-options: replace constant 1 with HAS_ARG John Snow
2020-02-04 17:29 ` Eric Blake
2020-02-04 18:58 ` no-reply
@ 2020-02-04 19:06 ` John Snow
2020-02-06 10:09 ` Laurent Vivier
3 siblings, 0 replies; 5+ messages in thread
From: John Snow @ 2020-02-04 19:06 UTC (permalink / raw)
To: qemu-devel; +Cc: qemu-trivial, thuth, armbru
On 2/4/20 11:56 AM, John Snow wrote:
> This is the only instance of a non-zero constant not using a symbolic
> constant.
Signed-off-by: John Snow <jsnow@redhat.com>
> ---
> qemu-options.hx | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/qemu-options.hx b/qemu-options.hx
> index 224a8e8712..ff3e806977 100644
> --- a/qemu-options.hx
> +++ b/qemu-options.hx
> @@ -1955,7 +1955,7 @@ STEXI
> Start in full screen.
> ETEXI
>
> -DEF("g", 1, QEMU_OPTION_g ,
> +DEF("g", HAS_ARG, QEMU_OPTION_g ,
> "-g WxH[xDEPTH] Set the initial graphical resolution and depth\n",
> QEMU_ARCH_PPC | QEMU_ARCH_SPARC | QEMU_ARCH_M68K)
> STEXI
>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] qemu-options: replace constant 1 with HAS_ARG
2020-02-04 16:56 [PATCH] qemu-options: replace constant 1 with HAS_ARG John Snow
` (2 preceding siblings ...)
2020-02-04 19:06 ` John Snow
@ 2020-02-06 10:09 ` Laurent Vivier
3 siblings, 0 replies; 5+ messages in thread
From: Laurent Vivier @ 2020-02-06 10:09 UTC (permalink / raw)
To: John Snow, qemu-devel; +Cc: qemu-trivial, thuth, armbru
Le 04/02/2020 à 17:56, John Snow a écrit :
> This is the only instance of a non-zero constant not using a symbolic
> constant.
> ---
> qemu-options.hx | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/qemu-options.hx b/qemu-options.hx
> index 224a8e8712..ff3e806977 100644
> --- a/qemu-options.hx
> +++ b/qemu-options.hx
> @@ -1955,7 +1955,7 @@ STEXI
> Start in full screen.
> ETEXI
>
> -DEF("g", 1, QEMU_OPTION_g ,
> +DEF("g", HAS_ARG, QEMU_OPTION_g ,
> "-g WxH[xDEPTH] Set the initial graphical resolution and depth\n",
> QEMU_ARCH_PPC | QEMU_ARCH_SPARC | QEMU_ARCH_M68K)
> STEXI
>
Applied to my trivial-patches branch.
Thanks,
Laurent
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2020-02-06 10:13 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-02-04 16:56 [PATCH] qemu-options: replace constant 1 with HAS_ARG John Snow
2020-02-04 17:29 ` Eric Blake
2020-02-04 18:58 ` no-reply
2020-02-04 19:06 ` John Snow
2020-02-06 10:09 ` Laurent Vivier
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).