* [Qemu-devel] [PATCH] iotests: Fix 205 for concurrent runs
@ 2019-06-18 21:02 Max Reitz
2019-06-18 21:09 ` Eric Blake
2019-06-21 12:40 ` Max Reitz
0 siblings, 2 replies; 3+ messages in thread
From: Max Reitz @ 2019-06-18 21:02 UTC (permalink / raw)
To: qemu-block; +Cc: Kevin Wolf, qemu-devel, Max Reitz
Tests should place their files into the test directory. This includes
Unix sockets. 205 currently fails to do so, which prevents it from
being run concurrently.
Signed-off-by: Max Reitz <mreitz@redhat.com>
---
tests/qemu-iotests/205 | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tests/qemu-iotests/205 b/tests/qemu-iotests/205
index 69f2c1d392..b8a86c446e 100755
--- a/tests/qemu-iotests/205
+++ b/tests/qemu-iotests/205
@@ -24,7 +24,7 @@ import iotests
import time
from iotests import qemu_img_create, qemu_io, filter_qemu_io, QemuIoInteractive
-nbd_sock = 'nbd_sock'
+nbd_sock = os.path.join(iotests.test_dir, 'nbd_sock')
nbd_uri = 'nbd+unix:///exp?socket=' + nbd_sock
disk = os.path.join(iotests.test_dir, 'disk')
--
2.21.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [Qemu-devel] [PATCH] iotests: Fix 205 for concurrent runs
2019-06-18 21:02 [Qemu-devel] [PATCH] iotests: Fix 205 for concurrent runs Max Reitz
@ 2019-06-18 21:09 ` Eric Blake
2019-06-21 12:40 ` Max Reitz
1 sibling, 0 replies; 3+ messages in thread
From: Eric Blake @ 2019-06-18 21:09 UTC (permalink / raw)
To: Max Reitz, qemu-block; +Cc: Kevin Wolf, qemu-devel
[-- Attachment #1.1: Type: text/plain, Size: 1203 bytes --]
On 6/18/19 4:02 PM, Max Reitz wrote:
> Tests should place their files into the test directory. This includes
> Unix sockets. 205 currently fails to do so, which prevents it from
> being run concurrently.
>
> Signed-off-by: Max Reitz <mreitz@redhat.com>
> ---
> tests/qemu-iotests/205 | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Reviewed-by: Eric Blake <eblake@redhat.com>
Feel free to take this through your iotests tree, but I can also stage
it through my NBD tree if I haven't seen it go in by the time of my next
pull request.
>
> diff --git a/tests/qemu-iotests/205 b/tests/qemu-iotests/205
> index 69f2c1d392..b8a86c446e 100755
> --- a/tests/qemu-iotests/205
> +++ b/tests/qemu-iotests/205
> @@ -24,7 +24,7 @@ import iotests
> import time
> from iotests import qemu_img_create, qemu_io, filter_qemu_io, QemuIoInteractive
>
> -nbd_sock = 'nbd_sock'
> +nbd_sock = os.path.join(iotests.test_dir, 'nbd_sock')
> nbd_uri = 'nbd+unix:///exp?socket=' + nbd_sock
> disk = os.path.join(iotests.test_dir, 'disk')
>
>
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3226
Virtualization: qemu.org | libvirt.org
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [Qemu-devel] [PATCH] iotests: Fix 205 for concurrent runs
2019-06-18 21:02 [Qemu-devel] [PATCH] iotests: Fix 205 for concurrent runs Max Reitz
2019-06-18 21:09 ` Eric Blake
@ 2019-06-21 12:40 ` Max Reitz
1 sibling, 0 replies; 3+ messages in thread
From: Max Reitz @ 2019-06-21 12:40 UTC (permalink / raw)
To: qemu-block; +Cc: Kevin Wolf, qemu-devel
[-- Attachment #1.1: Type: text/plain, Size: 415 bytes --]
On 18.06.19 23:02, Max Reitz wrote:
> Tests should place their files into the test directory. This includes
> Unix sockets. 205 currently fails to do so, which prevents it from
> being run concurrently.
>
> Signed-off-by: Max Reitz <mreitz@redhat.com>
> ---
> tests/qemu-iotests/205 | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Thanks for the review, applied to my block branch.
Max
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-06-21 12:42 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-06-18 21:02 [Qemu-devel] [PATCH] iotests: Fix 205 for concurrent runs Max Reitz
2019-06-18 21:09 ` Eric Blake
2019-06-21 12:40 ` Max Reitz
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).