QEMU-Devel Archive on lore.kernel.org
 help / color / Atom feed
From: Laurent Vivier <lvivier@redhat.com>
To: pannengyuan@huawei.com, mst@redhat.com
Cc: liyiting@huawei.com, kuhn.chenqun@huawei.com,
	qemu-devel@nongnu.org, zhang.zhanghailiang@huawei.com
Subject: Re: [PATCH v2 2/3] virtio-balloon: fix memory leak while attach virtio-balloon device
Date: Wed, 4 Dec 2019 11:16:43 +0100
Message-ID: <f1ebd6e5-bc02-e6cc-4adc-f4d2cfb0096b@redhat.com> (raw)
In-Reply-To: <1575444716-17632-2-git-send-email-pannengyuan@huawei.com>

On 04/12/2019 08:31, pannengyuan@huawei.com wrote:
> From: Pan Nengyuan <pannengyuan@huawei.com>
> 
> ivq/dvq/svq/free_page_vq is forgot to cleanup in
> virtio_balloon_device_unrealize, the memory leak stack is as follow:
> 
> Direct leak of 14336 byte(s) in 2 object(s) allocated from:
>     #0 0x7f99fd9d8560 in calloc (/usr/lib64/libasan.so.3+0xc7560)
>     #1 0x7f99fcb20015 in g_malloc0 (/usr/lib64/libglib-2.0.so.0+0x50015)
>     #2 0x557d90638437 in virtio_add_queue hw/virtio/virtio.c:2327
>     #3 0x557d9064401d in virtio_balloon_device_realize hw/virtio/virtio-balloon.c:793
>     #4 0x557d906356f7 in virtio_device_realize hw/virtio/virtio.c:3504
>     #5 0x557d9073f081 in device_set_realized hw/core/qdev.c:876
>     #6 0x557d908b1f4d in property_set_bool qom/object.c:2080
>     #7 0x557d908b655e in object_property_set_qobject qom/qom-qobject.c:26
> 
> Reported-by: Euler Robot <euler.robot@huawei.com>
> Signed-off-by: Pan Nengyuan <pannengyuan@huawei.com>
> ---
> Change v2 to v1:
> - use virtio_delete_queue to cleanup vq through a vq pointer (suggested by
>   Michael S. Tsirkin)
> ---
>  hw/virtio/virtio-balloon.c | 7 +++++++
>  1 file changed, 7 insertions(+)
> 
> diff --git a/hw/virtio/virtio-balloon.c b/hw/virtio/virtio-balloon.c
> index 40b04f5..57f3b9f 100644
> --- a/hw/virtio/virtio-balloon.c
> +++ b/hw/virtio/virtio-balloon.c
> @@ -831,6 +831,13 @@ static void virtio_balloon_device_unrealize(DeviceState *dev, Error **errp)
>      }
>      balloon_stats_destroy_timer(s);
>      qemu_remove_balloon_handler(s);
> +
> +    virtio_delete_queue(s->ivq);
> +    virtio_delete_queue(s->dvq);
> +    virtio_delete_queue(s->svq);
> +    if (s->free_page_vq) {
> +        virtio_delete_queue(s->free_page_vq);
> +    }
>      virtio_cleanup(vdev);
>  }
>  
> 

Reviewed-by: Laurent Vivier <lvivier@redhat.com>



  reply index

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-12-04  7:31 [PATCH v2 1/3] virtio: add ability to delete vq through a pointer pannengyuan
2019-12-04  7:31 ` [PATCH v2 2/3] virtio-balloon: fix memory leak while attach virtio-balloon device pannengyuan
2019-12-04 10:16   ` Laurent Vivier [this message]
2019-12-04  7:31 ` [PATCH v2 3/3] virtio-serial-bus: fix memory leak while attach virtio-serial-bus pannengyuan
2019-12-04 10:17   ` Laurent Vivier
2019-12-04 14:41   ` Eric Blake
2019-12-09 16:51   ` Michael S. Tsirkin
2019-12-04  8:33 ` [PATCH v2 1/3] virtio: add ability to delete vq through a pointer Pankaj Gupta
2019-12-05  2:30   ` Pan Nengyuan
2019-12-05  4:51     ` Pankaj Gupta
2019-12-09 15:58   ` Michael S. Tsirkin
2019-12-04  9:40 ` Laurent Vivier
2019-12-04 14:40 ` Eric Blake
2019-12-05  2:35   ` Pan Nengyuan
2019-12-05 16:45 ` Amit Shah
2019-12-06  2:17   ` Pan Nengyuan
2019-12-06  8:56     ` Amit Shah
2019-12-06  9:00       ` Pan Nengyuan
2019-12-09 16:43 ` Michael S. Tsirkin
2019-12-09 16:58   ` Michael S. Tsirkin
2019-12-10  2:08     ` Pan Nengyuan

Reply instructions:

You may reply publically to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=f1ebd6e5-bc02-e6cc-4adc-f4d2cfb0096b@redhat.com \
    --to=lvivier@redhat.com \
    --cc=kuhn.chenqun@huawei.com \
    --cc=liyiting@huawei.com \
    --cc=mst@redhat.com \
    --cc=pannengyuan@huawei.com \
    --cc=qemu-devel@nongnu.org \
    --cc=zhang.zhanghailiang@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

QEMU-Devel Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/qemu-devel/0 qemu-devel/git/0.git
	git clone --mirror https://lore.kernel.org/qemu-devel/1 qemu-devel/git/1.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 qemu-devel qemu-devel/ https://lore.kernel.org/qemu-devel \
		qemu-devel@nongnu.org
	public-inbox-index qemu-devel

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.nongnu.qemu-devel


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git