From: "Philippe Mathieu-Daudé" <philmd@redhat.com>
To: "Michael S. Tsirkin" <mst@redhat.com>
Cc: qemu-trivial@nongnu.org, Peter Maydell <peter.maydell@linaro.org>,
qemu-devel@nongnu.org, Paolo Bonzini <pbonzini@redhat.com>
Subject: Re: [PATCH] softmmu/memory: Log invalid memory accesses
Date: Mon, 5 Oct 2020 20:11:51 +0200 [thread overview]
Message-ID: <f4efb3e6-d11b-6136-33db-57cd12fe45a9@redhat.com> (raw)
In-Reply-To: <20201005135652-mutt-send-email-mst@kernel.org>
On 10/5/20 7:57 PM, Michael S. Tsirkin wrote:
> On Mon, Oct 05, 2020 at 05:27:25PM +0200, Philippe Mathieu-Daudé wrote:
>> Log invalid memory accesses with as GUEST_ERROR.
>>
>> This is particularly useful since commit 5d971f9e67 which reverted
>> ("memory: accept mismatching sizes in memory_region_access_valid").
>>
>> Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
>
> Reviewed-by: Michael S. Tsirkin <mst@redhat.com>
>
> Paolo's tree I assume?
Or qemu-trivial, whichever is less busy :)
>
>> ---
>> softmmu/memory.c | 16 ++++++++++++++++
>> 1 file changed, 16 insertions(+)
>>
>> diff --git a/softmmu/memory.c b/softmmu/memory.c
>> index fa280a19f7..403ff3abc9 100644
>> --- a/softmmu/memory.c
>> +++ b/softmmu/memory.c
>> @@ -14,6 +14,7 @@
>> */
>>
>> #include "qemu/osdep.h"
>> +#include "qemu/log.h"
>> #include "qapi/error.h"
>> #include "cpu.h"
>> #include "exec/memory.h"
>> @@ -1353,10 +1354,18 @@ bool memory_region_access_valid(MemoryRegion *mr,
>> {
>> if (mr->ops->valid.accepts
>> && !mr->ops->valid.accepts(mr->opaque, addr, size, is_write, attrs)) {
>> + qemu_log_mask(LOG_GUEST_ERROR, "Invalid access at addr "
>> + "0x%" HWADDR_PRIX ", size %u, "
>> + "region '%s', reason: rejected\n",
>> + addr, size, memory_region_name(mr));
>> return false;
>> }
>>
>> if (!mr->ops->valid.unaligned && (addr & (size - 1))) {
>> + qemu_log_mask(LOG_GUEST_ERROR, "Invalid access at addr "
>> + "0x%" HWADDR_PRIX ", size %u, "
>> + "region '%s', reason: unaligned\n",
>> + addr, size, memory_region_name(mr));
>> return false;
>> }
>>
>> @@ -1367,6 +1376,13 @@ bool memory_region_access_valid(MemoryRegion *mr,
>>
>> if (size > mr->ops->valid.max_access_size
>> || size < mr->ops->valid.min_access_size) {
>> + qemu_log_mask(LOG_GUEST_ERROR, "Invalid access at addr "
>> + "0x%" HWADDR_PRIX ", size %u, "
>> + "region '%s', reason: invalid size "
>> + "(min:%u max:%u)\n",
>> + addr, size, memory_region_name(mr),
>> + mr->ops->valid.min_access_size,
>> + mr->ops->valid.max_access_size);
>> return false;
>> }
>> return true;
>> --
>> 2.26.2
>
next prev parent reply other threads:[~2020-10-05 18:13 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-05 15:27 [PATCH] softmmu/memory: Log invalid memory accesses Philippe Mathieu-Daudé
2020-10-05 17:57 ` Michael S. Tsirkin
2020-10-05 18:11 ` Philippe Mathieu-Daudé [this message]
2020-10-12 14:20 ` Laurent Vivier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f4efb3e6-d11b-6136-33db-57cd12fe45a9@redhat.com \
--to=philmd@redhat.com \
--cc=mst@redhat.com \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).