* [PATCH] softmmu/memory: Log invalid memory accesses
@ 2020-10-05 15:27 Philippe Mathieu-Daudé
2020-10-05 17:57 ` Michael S. Tsirkin
2020-10-12 14:20 ` Laurent Vivier
0 siblings, 2 replies; 4+ messages in thread
From: Philippe Mathieu-Daudé @ 2020-10-05 15:27 UTC (permalink / raw)
To: qemu-devel
Cc: qemu-trivial, Peter Maydell, Paolo Bonzini,
Philippe Mathieu-Daudé,
Michael S . Tsirkin
Log invalid memory accesses with as GUEST_ERROR.
This is particularly useful since commit 5d971f9e67 which reverted
("memory: accept mismatching sizes in memory_region_access_valid").
Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
---
softmmu/memory.c | 16 ++++++++++++++++
1 file changed, 16 insertions(+)
diff --git a/softmmu/memory.c b/softmmu/memory.c
index fa280a19f7..403ff3abc9 100644
--- a/softmmu/memory.c
+++ b/softmmu/memory.c
@@ -14,6 +14,7 @@
*/
#include "qemu/osdep.h"
+#include "qemu/log.h"
#include "qapi/error.h"
#include "cpu.h"
#include "exec/memory.h"
@@ -1353,10 +1354,18 @@ bool memory_region_access_valid(MemoryRegion *mr,
{
if (mr->ops->valid.accepts
&& !mr->ops->valid.accepts(mr->opaque, addr, size, is_write, attrs)) {
+ qemu_log_mask(LOG_GUEST_ERROR, "Invalid access at addr "
+ "0x%" HWADDR_PRIX ", size %u, "
+ "region '%s', reason: rejected\n",
+ addr, size, memory_region_name(mr));
return false;
}
if (!mr->ops->valid.unaligned && (addr & (size - 1))) {
+ qemu_log_mask(LOG_GUEST_ERROR, "Invalid access at addr "
+ "0x%" HWADDR_PRIX ", size %u, "
+ "region '%s', reason: unaligned\n",
+ addr, size, memory_region_name(mr));
return false;
}
@@ -1367,6 +1376,13 @@ bool memory_region_access_valid(MemoryRegion *mr,
if (size > mr->ops->valid.max_access_size
|| size < mr->ops->valid.min_access_size) {
+ qemu_log_mask(LOG_GUEST_ERROR, "Invalid access at addr "
+ "0x%" HWADDR_PRIX ", size %u, "
+ "region '%s', reason: invalid size "
+ "(min:%u max:%u)\n",
+ addr, size, memory_region_name(mr),
+ mr->ops->valid.min_access_size,
+ mr->ops->valid.max_access_size);
return false;
}
return true;
--
2.26.2
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] softmmu/memory: Log invalid memory accesses
2020-10-05 15:27 [PATCH] softmmu/memory: Log invalid memory accesses Philippe Mathieu-Daudé
@ 2020-10-05 17:57 ` Michael S. Tsirkin
2020-10-05 18:11 ` Philippe Mathieu-Daudé
2020-10-12 14:20 ` Laurent Vivier
1 sibling, 1 reply; 4+ messages in thread
From: Michael S. Tsirkin @ 2020-10-05 17:57 UTC (permalink / raw)
To: Philippe Mathieu-Daudé
Cc: qemu-trivial, Peter Maydell, qemu-devel, Paolo Bonzini
On Mon, Oct 05, 2020 at 05:27:25PM +0200, Philippe Mathieu-Daudé wrote:
> Log invalid memory accesses with as GUEST_ERROR.
>
> This is particularly useful since commit 5d971f9e67 which reverted
> ("memory: accept mismatching sizes in memory_region_access_valid").
>
> Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Reviewed-by: Michael S. Tsirkin <mst@redhat.com>
Paolo's tree I assume?
> ---
> softmmu/memory.c | 16 ++++++++++++++++
> 1 file changed, 16 insertions(+)
>
> diff --git a/softmmu/memory.c b/softmmu/memory.c
> index fa280a19f7..403ff3abc9 100644
> --- a/softmmu/memory.c
> +++ b/softmmu/memory.c
> @@ -14,6 +14,7 @@
> */
>
> #include "qemu/osdep.h"
> +#include "qemu/log.h"
> #include "qapi/error.h"
> #include "cpu.h"
> #include "exec/memory.h"
> @@ -1353,10 +1354,18 @@ bool memory_region_access_valid(MemoryRegion *mr,
> {
> if (mr->ops->valid.accepts
> && !mr->ops->valid.accepts(mr->opaque, addr, size, is_write, attrs)) {
> + qemu_log_mask(LOG_GUEST_ERROR, "Invalid access at addr "
> + "0x%" HWADDR_PRIX ", size %u, "
> + "region '%s', reason: rejected\n",
> + addr, size, memory_region_name(mr));
> return false;
> }
>
> if (!mr->ops->valid.unaligned && (addr & (size - 1))) {
> + qemu_log_mask(LOG_GUEST_ERROR, "Invalid access at addr "
> + "0x%" HWADDR_PRIX ", size %u, "
> + "region '%s', reason: unaligned\n",
> + addr, size, memory_region_name(mr));
> return false;
> }
>
> @@ -1367,6 +1376,13 @@ bool memory_region_access_valid(MemoryRegion *mr,
>
> if (size > mr->ops->valid.max_access_size
> || size < mr->ops->valid.min_access_size) {
> + qemu_log_mask(LOG_GUEST_ERROR, "Invalid access at addr "
> + "0x%" HWADDR_PRIX ", size %u, "
> + "region '%s', reason: invalid size "
> + "(min:%u max:%u)\n",
> + addr, size, memory_region_name(mr),
> + mr->ops->valid.min_access_size,
> + mr->ops->valid.max_access_size);
> return false;
> }
> return true;
> --
> 2.26.2
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] softmmu/memory: Log invalid memory accesses
2020-10-05 17:57 ` Michael S. Tsirkin
@ 2020-10-05 18:11 ` Philippe Mathieu-Daudé
0 siblings, 0 replies; 4+ messages in thread
From: Philippe Mathieu-Daudé @ 2020-10-05 18:11 UTC (permalink / raw)
To: Michael S. Tsirkin; +Cc: qemu-trivial, Peter Maydell, qemu-devel, Paolo Bonzini
On 10/5/20 7:57 PM, Michael S. Tsirkin wrote:
> On Mon, Oct 05, 2020 at 05:27:25PM +0200, Philippe Mathieu-Daudé wrote:
>> Log invalid memory accesses with as GUEST_ERROR.
>>
>> This is particularly useful since commit 5d971f9e67 which reverted
>> ("memory: accept mismatching sizes in memory_region_access_valid").
>>
>> Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
>
> Reviewed-by: Michael S. Tsirkin <mst@redhat.com>
>
> Paolo's tree I assume?
Or qemu-trivial, whichever is less busy :)
>
>> ---
>> softmmu/memory.c | 16 ++++++++++++++++
>> 1 file changed, 16 insertions(+)
>>
>> diff --git a/softmmu/memory.c b/softmmu/memory.c
>> index fa280a19f7..403ff3abc9 100644
>> --- a/softmmu/memory.c
>> +++ b/softmmu/memory.c
>> @@ -14,6 +14,7 @@
>> */
>>
>> #include "qemu/osdep.h"
>> +#include "qemu/log.h"
>> #include "qapi/error.h"
>> #include "cpu.h"
>> #include "exec/memory.h"
>> @@ -1353,10 +1354,18 @@ bool memory_region_access_valid(MemoryRegion *mr,
>> {
>> if (mr->ops->valid.accepts
>> && !mr->ops->valid.accepts(mr->opaque, addr, size, is_write, attrs)) {
>> + qemu_log_mask(LOG_GUEST_ERROR, "Invalid access at addr "
>> + "0x%" HWADDR_PRIX ", size %u, "
>> + "region '%s', reason: rejected\n",
>> + addr, size, memory_region_name(mr));
>> return false;
>> }
>>
>> if (!mr->ops->valid.unaligned && (addr & (size - 1))) {
>> + qemu_log_mask(LOG_GUEST_ERROR, "Invalid access at addr "
>> + "0x%" HWADDR_PRIX ", size %u, "
>> + "region '%s', reason: unaligned\n",
>> + addr, size, memory_region_name(mr));
>> return false;
>> }
>>
>> @@ -1367,6 +1376,13 @@ bool memory_region_access_valid(MemoryRegion *mr,
>>
>> if (size > mr->ops->valid.max_access_size
>> || size < mr->ops->valid.min_access_size) {
>> + qemu_log_mask(LOG_GUEST_ERROR, "Invalid access at addr "
>> + "0x%" HWADDR_PRIX ", size %u, "
>> + "region '%s', reason: invalid size "
>> + "(min:%u max:%u)\n",
>> + addr, size, memory_region_name(mr),
>> + mr->ops->valid.min_access_size,
>> + mr->ops->valid.max_access_size);
>> return false;
>> }
>> return true;
>> --
>> 2.26.2
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] softmmu/memory: Log invalid memory accesses
2020-10-05 15:27 [PATCH] softmmu/memory: Log invalid memory accesses Philippe Mathieu-Daudé
2020-10-05 17:57 ` Michael S. Tsirkin
@ 2020-10-12 14:20 ` Laurent Vivier
1 sibling, 0 replies; 4+ messages in thread
From: Laurent Vivier @ 2020-10-12 14:20 UTC (permalink / raw)
To: Philippe Mathieu-Daudé, qemu-devel
Cc: qemu-trivial, Peter Maydell, Michael S . Tsirkin, Paolo Bonzini
Le 05/10/2020 à 17:27, Philippe Mathieu-Daudé a écrit :
> Log invalid memory accesses with as GUEST_ERROR.
>
> This is particularly useful since commit 5d971f9e67 which reverted
> ("memory: accept mismatching sizes in memory_region_access_valid").
>
> Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
> ---
> softmmu/memory.c | 16 ++++++++++++++++
> 1 file changed, 16 insertions(+)
>
> diff --git a/softmmu/memory.c b/softmmu/memory.c
> index fa280a19f7..403ff3abc9 100644
> --- a/softmmu/memory.c
> +++ b/softmmu/memory.c
> @@ -14,6 +14,7 @@
> */
>
> #include "qemu/osdep.h"
> +#include "qemu/log.h"
> #include "qapi/error.h"
> #include "cpu.h"
> #include "exec/memory.h"
> @@ -1353,10 +1354,18 @@ bool memory_region_access_valid(MemoryRegion *mr,
> {
> if (mr->ops->valid.accepts
> && !mr->ops->valid.accepts(mr->opaque, addr, size, is_write, attrs)) {
> + qemu_log_mask(LOG_GUEST_ERROR, "Invalid access at addr "
> + "0x%" HWADDR_PRIX ", size %u, "
> + "region '%s', reason: rejected\n",
> + addr, size, memory_region_name(mr));
> return false;
> }
>
> if (!mr->ops->valid.unaligned && (addr & (size - 1))) {
> + qemu_log_mask(LOG_GUEST_ERROR, "Invalid access at addr "
> + "0x%" HWADDR_PRIX ", size %u, "
> + "region '%s', reason: unaligned\n",
> + addr, size, memory_region_name(mr));
> return false;
> }
>
> @@ -1367,6 +1376,13 @@ bool memory_region_access_valid(MemoryRegion *mr,
>
> if (size > mr->ops->valid.max_access_size
> || size < mr->ops->valid.min_access_size) {
> + qemu_log_mask(LOG_GUEST_ERROR, "Invalid access at addr "
> + "0x%" HWADDR_PRIX ", size %u, "
> + "region '%s', reason: invalid size "
> + "(min:%u max:%u)\n",
> + addr, size, memory_region_name(mr),
> + mr->ops->valid.min_access_size,
> + mr->ops->valid.max_access_size);
> return false;
> }
> return true;
>
Applied to my trivial-patches branch.
Thanks,
Laurent
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2020-10-12 14:22 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-10-05 15:27 [PATCH] softmmu/memory: Log invalid memory accesses Philippe Mathieu-Daudé
2020-10-05 17:57 ` Michael S. Tsirkin
2020-10-05 18:11 ` Philippe Mathieu-Daudé
2020-10-12 14:20 ` Laurent Vivier
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).