* [Qemu-devel] [PATCH] virtio-net: remove redundant qdev from VirtIONet
@ 2019-07-16 9:08 Anton Kuchin
2019-07-16 9:13 ` Michael S. Tsirkin
2019-08-21 8:50 ` [Qemu-devel] [Qemu-trivial] " Laurent Vivier
0 siblings, 2 replies; 3+ messages in thread
From: Anton Kuchin @ 2019-07-16 9:08 UTC (permalink / raw)
To: qemu-devel; +Cc: qemu-trivial, Jason Wang, Anton Kuchin, Michael S. Tsirkin
Signed-off-by: Anton Kuchin <antonkuchin@yandex-team.ru>
---
hw/net/virtio-net.c | 3 +--
include/hw/virtio/virtio-net.h | 1 -
2 files changed, 1 insertion(+), 3 deletions(-)
diff --git a/hw/net/virtio-net.c b/hw/net/virtio-net.c
index b9e1cd71cf..16d2ad5927 100644
--- a/hw/net/virtio-net.c
+++ b/hw/net/virtio-net.c
@@ -387,7 +387,7 @@ static void rxfilter_notify(NetClientState *nc)
VirtIONet *n = qemu_get_nic_opaque(nc);
if (nc->rxfilter_notify_enabled) {
- gchar *path = object_get_canonical_path(OBJECT(n->qdev));
+ gchar *path = object_get_canonical_path(OBJECT(n));
qapi_event_send_nic_rx_filter_changed(!!n->netclient_name,
n->netclient_name, path);
g_free(path);
@@ -2759,7 +2759,6 @@ static void virtio_net_device_realize(DeviceState *dev, Error **errp)
nc->rxfilter_notify_enabled = 1;
QTAILQ_INIT(&n->rsc_chains);
- n->qdev = dev;
}
static void virtio_net_device_unrealize(DeviceState *dev, Error **errp)
diff --git a/include/hw/virtio/virtio-net.h b/include/hw/virtio/virtio-net.h
index b96f0c643f..4a1b599d48 100644
--- a/include/hw/virtio/virtio-net.h
+++ b/include/hw/virtio/virtio-net.h
@@ -174,7 +174,6 @@ struct VirtIONet {
uint32_t *vlans;
virtio_net_conf net_conf;
NICConf nic_conf;
- DeviceState *qdev;
int multiqueue;
uint16_t max_queues;
uint16_t curr_queues;
--
2.20.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [Qemu-devel] [PATCH] virtio-net: remove redundant qdev from VirtIONet
2019-07-16 9:08 [Qemu-devel] [PATCH] virtio-net: remove redundant qdev from VirtIONet Anton Kuchin
@ 2019-07-16 9:13 ` Michael S. Tsirkin
2019-08-21 8:50 ` [Qemu-devel] [Qemu-trivial] " Laurent Vivier
1 sibling, 0 replies; 3+ messages in thread
From: Michael S. Tsirkin @ 2019-07-16 9:13 UTC (permalink / raw)
To: Anton Kuchin; +Cc: qemu-trivial, Jason Wang, qemu-devel
On Tue, Jul 16, 2019 at 12:08:39PM +0300, Anton Kuchin wrote:
> Signed-off-by: Anton Kuchin <antonkuchin@yandex-team.ru>
Reviewed-by: Michael S. Tsirkin <mst@redhat.com>
> ---
> hw/net/virtio-net.c | 3 +--
> include/hw/virtio/virtio-net.h | 1 -
> 2 files changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/hw/net/virtio-net.c b/hw/net/virtio-net.c
> index b9e1cd71cf..16d2ad5927 100644
> --- a/hw/net/virtio-net.c
> +++ b/hw/net/virtio-net.c
> @@ -387,7 +387,7 @@ static void rxfilter_notify(NetClientState *nc)
> VirtIONet *n = qemu_get_nic_opaque(nc);
>
> if (nc->rxfilter_notify_enabled) {
> - gchar *path = object_get_canonical_path(OBJECT(n->qdev));
> + gchar *path = object_get_canonical_path(OBJECT(n));
> qapi_event_send_nic_rx_filter_changed(!!n->netclient_name,
> n->netclient_name, path);
> g_free(path);
> @@ -2759,7 +2759,6 @@ static void virtio_net_device_realize(DeviceState *dev, Error **errp)
> nc->rxfilter_notify_enabled = 1;
>
> QTAILQ_INIT(&n->rsc_chains);
> - n->qdev = dev;
> }
>
> static void virtio_net_device_unrealize(DeviceState *dev, Error **errp)
> diff --git a/include/hw/virtio/virtio-net.h b/include/hw/virtio/virtio-net.h
> index b96f0c643f..4a1b599d48 100644
> --- a/include/hw/virtio/virtio-net.h
> +++ b/include/hw/virtio/virtio-net.h
> @@ -174,7 +174,6 @@ struct VirtIONet {
> uint32_t *vlans;
> virtio_net_conf net_conf;
> NICConf nic_conf;
> - DeviceState *qdev;
> int multiqueue;
> uint16_t max_queues;
> uint16_t curr_queues;
> --
> 2.20.1
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [Qemu-devel] [Qemu-trivial] [PATCH] virtio-net: remove redundant qdev from VirtIONet
2019-07-16 9:08 [Qemu-devel] [PATCH] virtio-net: remove redundant qdev from VirtIONet Anton Kuchin
2019-07-16 9:13 ` Michael S. Tsirkin
@ 2019-08-21 8:50 ` Laurent Vivier
1 sibling, 0 replies; 3+ messages in thread
From: Laurent Vivier @ 2019-08-21 8:50 UTC (permalink / raw)
To: Anton Kuchin, qemu-devel; +Cc: qemu-trivial, Jason Wang, Michael S. Tsirkin
Could you add a commit message describing why we can remove the qdev field?
Thanks,
Laurent
Le 16/07/2019 à 11:08, Anton Kuchin a écrit :
> Signed-off-by: Anton Kuchin <antonkuchin@yandex-team.ru>
> ---
> hw/net/virtio-net.c | 3 +--
> include/hw/virtio/virtio-net.h | 1 -
> 2 files changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/hw/net/virtio-net.c b/hw/net/virtio-net.c
> index b9e1cd71cf..16d2ad5927 100644
> --- a/hw/net/virtio-net.c
> +++ b/hw/net/virtio-net.c
> @@ -387,7 +387,7 @@ static void rxfilter_notify(NetClientState *nc)
> VirtIONet *n = qemu_get_nic_opaque(nc);
>
> if (nc->rxfilter_notify_enabled) {
> - gchar *path = object_get_canonical_path(OBJECT(n->qdev));
> + gchar *path = object_get_canonical_path(OBJECT(n));
> qapi_event_send_nic_rx_filter_changed(!!n->netclient_name,
> n->netclient_name, path);
> g_free(path);
> @@ -2759,7 +2759,6 @@ static void virtio_net_device_realize(DeviceState *dev, Error **errp)
> nc->rxfilter_notify_enabled = 1;
>
> QTAILQ_INIT(&n->rsc_chains);
> - n->qdev = dev;
> }
>
> static void virtio_net_device_unrealize(DeviceState *dev, Error **errp)
> diff --git a/include/hw/virtio/virtio-net.h b/include/hw/virtio/virtio-net.h
> index b96f0c643f..4a1b599d48 100644
> --- a/include/hw/virtio/virtio-net.h
> +++ b/include/hw/virtio/virtio-net.h
> @@ -174,7 +174,6 @@ struct VirtIONet {
> uint32_t *vlans;
> virtio_net_conf net_conf;
> NICConf nic_conf;
> - DeviceState *qdev;
> int multiqueue;
> uint16_t max_queues;
> uint16_t curr_queues;
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-08-21 8:52 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-07-16 9:08 [Qemu-devel] [PATCH] virtio-net: remove redundant qdev from VirtIONet Anton Kuchin
2019-07-16 9:13 ` Michael S. Tsirkin
2019-08-21 8:50 ` [Qemu-devel] [Qemu-trivial] " Laurent Vivier
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).