[PATCH] MAINTAINERS: Volunteer for maintaining the Renesas hardware

[PATCH] MAINTAINERS: Volunteer for maintaining the Renesas hardware

[Philippe Mathieu-Daudé]

I don't have much clue about the Renesas hardware, but at least
I know now the source files a little bit, so I volunteer to pick
up patches and send pull-requests for them during my scarce
hobbyist time, until someone else with more knowledge steps up
to do this job instead.

Suggested-by: Alex Bennée <alex.bennee@linaro.org>
Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
---
 MAINTAINERS | 15 +++++++++++++--
 1 file changed, 13 insertions(+), 2 deletions(-)

diff --git a/MAINTAINERS b/MAINTAINERS
index 0944d9c731..cbba3ac757 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -298,9 +298,7 @@ SH4 TCG CPUs
 M: Aurelien Jarno <aurelien@aurel32.net>
 S: Odd Fixes
 F: target/sh4/
-F: hw/sh4/
 F: disas/sh4.c
-F: include/hw/sh4/
 
 SPARC TCG CPUs
 M: Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>
@@ -1238,6 +1236,18 @@ F: pc-bios/canyonlands.dt[sb]
 F: pc-bios/u-boot-sam460ex-20100605.bin
 F: roms/u-boot-sam460ex
 
+Renesas Hardware
+----------------
+SH4 Hardware
+M: Aurelien Jarno <aurelien@aurel32.net>
+M: Philippe Mathieu-Daudé <f4bug@amsat.org>
+S: Odd Fixes
+F: hw/sh4/
+F: hw/char/sh_serial.c
+F: hw/intc/sh_intc.c
+F: hw/timer/sh_timer.c
+F: include/hw/sh4/
+
 SH4 Machines
 ------------
 R2D
@@ -1246,6 +1256,7 @@ S: Maintained
 F: hw/sh4/r2d.c
 F: hw/intc/sh_intc.c
 F: hw/timer/sh_timer.c
+F: include/hw/sh4/sh_intc.h
 
 Shix
 M: Magnus Damm <magnus.damm@gmail.com>
-- 
2.21.3

Re: [PATCH] MAINTAINERS: Volunteer for maintaining the Renesas hardware

[Aleksandar Markovic]

On Mon, Jun 1, 2020 at 11:21 AM Philippe Mathieu-Daudé <f4bug@amsat.org> wrote:
>
> I don't have much clue about the Renesas hardware, but at least
> I know now the source files a little bit, so I volunteer to pick
> up patches and send pull-requests for them during my scarce
> hobbyist time, until someone else with more knowledge steps up
> to do this job instead.
>
> Suggested-by: Alex Bennée <alex.bennee@linaro.org>
> Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
> ---

There is alive and well Renesas target maintainer that obviously has
the access to Renesas hardware, and I have no idea why you should
be the maintainer for something that you say do not have much clue,
while at the same time omitting the original Renesas contributor.

Scandalous.

Regards,
Aleksandar

>  MAINTAINERS | 15 +++++++++++++--
>  1 file changed, 13 insertions(+), 2 deletions(-)
>
> diff --git a/MAINTAINERS b/MAINTAINERS
> index 0944d9c731..cbba3ac757 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -298,9 +298,7 @@ SH4 TCG CPUs
>  M: Aurelien Jarno <aurelien@aurel32.net>
>  S: Odd Fixes
>  F: target/sh4/
> -F: hw/sh4/
>  F: disas/sh4.c
> -F: include/hw/sh4/
>
>  SPARC TCG CPUs
>  M: Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>
> @@ -1238,6 +1236,18 @@ F: pc-bios/canyonlands.dt[sb]
>  F: pc-bios/u-boot-sam460ex-20100605.bin
>  F: roms/u-boot-sam460ex
>
> +Renesas Hardware
> +----------------
> +SH4 Hardware
> +M: Aurelien Jarno <aurelien@aurel32.net>
> +M: Philippe Mathieu-Daudé <f4bug@amsat.org>
> +S: Odd Fixes
> +F: hw/sh4/
> +F: hw/char/sh_serial.c
> +F: hw/intc/sh_intc.c
> +F: hw/timer/sh_timer.c
> +F: include/hw/sh4/
> +
>  SH4 Machines
>  ------------
>  R2D
> @@ -1246,6 +1256,7 @@ S: Maintained
>  F: hw/sh4/r2d.c
>  F: hw/intc/sh_intc.c
>  F: hw/timer/sh_timer.c
> +F: include/hw/sh4/sh_intc.h
>
>  Shix
>  M: Magnus Damm <magnus.damm@gmail.com>
> --
> 2.21.3
>
>

Re: [PATCH] MAINTAINERS: Volunteer for maintaining the Renesas hardware

[Philippe Mathieu-Daudé]

+Peter +Markus as neutral and experienced contributors.

On 6/1/20 11:56 AM, Aleksandar Markovic wrote:
> On Mon, Jun 1, 2020 at 11:21 AM Philippe Mathieu-Daudé <f4bug@amsat.org> wrote:
>>
>> I don't have much clue about the Renesas hardware, but at least
>> I know now the source files a little bit, so I volunteer to pick
>> up patches and send pull-requests for them during my scarce
>> hobbyist time, until someone else with more knowledge steps up
>> to do this job instead.
>>
>> Suggested-by: Alex Bennée <alex.bennee@linaro.org>
>> Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
>> ---
> 
> There is alive and well Renesas target maintainer that obviously has
> the access to Renesas hardware, and I have no idea why you should
> be the maintainer for something that you say do not have much clue,
> while at the same time omitting the original Renesas contributor.

The last time Magnus was active was more than 10years ago...

commit fc8e320ef5831dc0b0d744e369537893a4379753
Author: Magnus Damm <damm@opensource.se>
Date:   Fri Nov 13 18:51:05 2009 +0900

    fix make clean targets

    This patch fixes clean in case of missing directories and
    also adds code to distclean that removes the following files:
     qemu-monitor.texi roms/seabios/config.mak roms/vgabios/config.mak

    Signed-off-by: Magnus Damm <damm@opensource.se>
    Signed-off-by: Aurelien Jarno <aurelien@aurel32.net>

There are SH4 patches on the list:
https://lists.gnu.org/archive/html/qemu-devel/2020-05/msg08519.html

Who is going to pick them?

> 
> Scandalous.

I don't understand your attitude, I'm simply trying to help everyone by
giving time to the project, relieving overloaded maintainers. You only
keep tracking my activity and yelling about all my contributions. What
do you expect with all your critics? They are not very constructive and
don't improve much the project in general.

Regards,

Phil.

> 
> Regards,
> Aleksandar
> 
>>  MAINTAINERS | 15 +++++++++++++--
>>  1 file changed, 13 insertions(+), 2 deletions(-)
>>
>> diff --git a/MAINTAINERS b/MAINTAINERS
>> index 0944d9c731..cbba3ac757 100644
>> --- a/MAINTAINERS
>> +++ b/MAINTAINERS
>> @@ -298,9 +298,7 @@ SH4 TCG CPUs
>>  M: Aurelien Jarno <aurelien@aurel32.net>
>>  S: Odd Fixes
>>  F: target/sh4/
>> -F: hw/sh4/
>>  F: disas/sh4.c
>> -F: include/hw/sh4/
>>
>>  SPARC TCG CPUs
>>  M: Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>
>> @@ -1238,6 +1236,18 @@ F: pc-bios/canyonlands.dt[sb]
>>  F: pc-bios/u-boot-sam460ex-20100605.bin
>>  F: roms/u-boot-sam460ex
>>
>> +Renesas Hardware
>> +----------------
>> +SH4 Hardware
>> +M: Aurelien Jarno <aurelien@aurel32.net>
>> +M: Philippe Mathieu-Daudé <f4bug@amsat.org>
>> +S: Odd Fixes
>> +F: hw/sh4/
>> +F: hw/char/sh_serial.c
>> +F: hw/intc/sh_intc.c
>> +F: hw/timer/sh_timer.c
>> +F: include/hw/sh4/
>> +
>>  SH4 Machines
>>  ------------
>>  R2D
>> @@ -1246,6 +1256,7 @@ S: Maintained
>>  F: hw/sh4/r2d.c
>>  F: hw/intc/sh_intc.c
>>  F: hw/timer/sh_timer.c
>> +F: include/hw/sh4/sh_intc.h
>>
>>  Shix
>>  M: Magnus Damm <magnus.damm@gmail.com>
>> --
>> 2.21.3
>>
>>
> 

Re: [PATCH] MAINTAINERS: Volunteer for maintaining the Renesas hardware

[Aleksandar Markovic]

On Mon, Jun 1, 2020 at 12:23 PM Philippe Mathieu-Daudé <f4bug@amsat.org> wrote:
>
> +Peter +Markus as neutral and experienced contributors.
>
> On 6/1/20 11:56 AM, Aleksandar Markovic wrote:
> > On Mon, Jun 1, 2020 at 11:21 AM Philippe Mathieu-Daudé <f4bug@amsat.org> wrote:
> >>
> >> I don't have much clue about the Renesas hardware, but at least
> >> I know now the source files a little bit, so I volunteer to pick
> >> up patches and send pull-requests for them during my scarce
> >> hobbyist time, until someone else with more knowledge steps up
> >> to do this job instead.
> >>
> >> Suggested-by: Alex Bennée <alex.bennee@linaro.org>
> >> Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
> >> ---
> >
> > There is alive and well Renesas target maintainer that obviously has
> > the access to Renesas hardware, and I have no idea why you should
> > be the maintainer for something that you say do not have much clue,
> > while at the same time omitting the original Renesas contributor.
>
> The last time Magnus was active was more than 10years ago...
>
> commit fc8e320ef5831dc0b0d744e369537893a4379753
> Author: Magnus Damm <damm@opensource.se>
> Date:   Fri Nov 13 18:51:05 2009 +0900
>
>     fix make clean targets
>
>     This patch fixes clean in case of missing directories and
>     also adds code to distclean that removes the following files:
>      qemu-monitor.texi roms/seabios/config.mak roms/vgabios/config.mak
>
>     Signed-off-by: Magnus Damm <damm@opensource.se>
>     Signed-off-by: Aurelien Jarno <aurelien@aurel32.net>
>
> There are SH4 patches on the list:
> https://lists.gnu.org/archive/html/qemu-devel/2020-05/msg08519.html
>
> Who is going to pick them?
>
> >
> > Scandalous.
>
> I don't understand your attitude, I'm simply trying to help everyone by
> giving time to the project, relieving overloaded maintainers. You only
> keep tracking my activity and yelling about all my contributions. What
> do you expect with all your critics? They are not very constructive and
> don't improve much the project in general.
>

You add the utter confusion to a clear thing.

"Renesas" is not the same as "sh4". We had "sh4" as a target since
forever, and now you suddenly want to change "sh4 hardware" to
"Renesas hardware"??

Today, "Renesas", as a company, is more oriented towards architectures
that are similar to "sh4", but not the same - RX architectures. I find it
surprising and interesting you don't know that, since you participated
in introduction of "RX" target. BTW, you also dictate there Yoshimoto
that to do and what not to do. Why?

Aleksandar

> Regards,
>
> Phil.
>
> >
> > Regards,
> > Aleksandar
> >
> >>  MAINTAINERS | 15 +++++++++++++--
> >>  1 file changed, 13 insertions(+), 2 deletions(-)
> >>
> >> diff --git a/MAINTAINERS b/MAINTAINERS
> >> index 0944d9c731..cbba3ac757 100644
> >> --- a/MAINTAINERS
> >> +++ b/MAINTAINERS
> >> @@ -298,9 +298,7 @@ SH4 TCG CPUs
> >>  M: Aurelien Jarno <aurelien@aurel32.net>
> >>  S: Odd Fixes
> >>  F: target/sh4/
> >> -F: hw/sh4/
> >>  F: disas/sh4.c
> >> -F: include/hw/sh4/
> >>
> >>  SPARC TCG CPUs
> >>  M: Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>
> >> @@ -1238,6 +1236,18 @@ F: pc-bios/canyonlands.dt[sb]
> >>  F: pc-bios/u-boot-sam460ex-20100605.bin
> >>  F: roms/u-boot-sam460ex
> >>
> >> +Renesas Hardware
> >> +----------------
> >> +SH4 Hardware
> >> +M: Aurelien Jarno <aurelien@aurel32.net>
> >> +M: Philippe Mathieu-Daudé <f4bug@amsat.org>
> >> +S: Odd Fixes
> >> +F: hw/sh4/
> >> +F: hw/char/sh_serial.c
> >> +F: hw/intc/sh_intc.c
> >> +F: hw/timer/sh_timer.c
> >> +F: include/hw/sh4/
> >> +
> >>  SH4 Machines
> >>  ------------
> >>  R2D
> >> @@ -1246,6 +1256,7 @@ S: Maintained
> >>  F: hw/sh4/r2d.c
> >>  F: hw/intc/sh_intc.c
> >>  F: hw/timer/sh_timer.c
> >> +F: include/hw/sh4/sh_intc.h
> >>
> >>  Shix
> >>  M: Magnus Damm <magnus.damm@gmail.com>
> >> --
> >> 2.21.3
> >>
> >>
> >

Re: [PATCH] MAINTAINERS: Volunteer for maintaining the Renesas hardware

[Peter Maydell]

On Mon, 1 Jun 2020 at 11:34, Aleksandar Markovic
<aleksandar.m.mail@gmail.com> wrote:
> You add the utter confusion to a clear thing.
>
> "Renesas" is not the same as "sh4". We had "sh4" as a target since
> forever, and now you suddenly want to change "sh4 hardware" to
> "Renesas hardware"??

Hi Aleksandar; you seem to be being excessively combative in this
thread -- can you tone it down, please?

thanks
-- PMM

Re: [PATCH] MAINTAINERS: Volunteer for maintaining the Renesas hardware

[Aleksandar Markovic]

On Mon, Jun 1, 2020 at 12:48 PM Peter Maydell <peter.maydell@linaro.org> wrote:
>
> On Mon, 1 Jun 2020 at 11:34, Aleksandar Markovic
> <aleksandar.m.mail@gmail.com> wrote:
> > You add the utter confusion to a clear thing.
> >
> > "Renesas" is not the same as "sh4". We had "sh4" as a target since
> > forever, and now you suddenly want to change "sh4 hardware" to
> > "Renesas hardware"??
>
> Hi Aleksandar; you seem to be being excessively combative in this
> thread -- can you tone it down, please?
>

Yes, of course, I can.

Thanks,
Aleksandar

> thanks
> -- PMM

Re: [PATCH] MAINTAINERS: Volunteer for maintaining the Renesas hardware

[Aurelien Jarno]

On 2020-06-01 11:20, Philippe Mathieu-Daudé wrote:
> I don't have much clue about the Renesas hardware, but at least
> I know now the source files a little bit, so I volunteer to pick
> up patches and send pull-requests for them during my scarce
> hobbyist time, until someone else with more knowledge steps up
> to do this job instead.
> 
> Suggested-by: Alex Bennée <alex.bennee@linaro.org>
> Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
> ---
>  MAINTAINERS | 15 +++++++++++++--
>  1 file changed, 13 insertions(+), 2 deletions(-)
> 
> diff --git a/MAINTAINERS b/MAINTAINERS
> index 0944d9c731..cbba3ac757 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -298,9 +298,7 @@ SH4 TCG CPUs
>  M: Aurelien Jarno <aurelien@aurel32.net>
>  S: Odd Fixes
>  F: target/sh4/
> -F: hw/sh4/
>  F: disas/sh4.c
> -F: include/hw/sh4/
>  
>  SPARC TCG CPUs
>  M: Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>
> @@ -1238,6 +1236,18 @@ F: pc-bios/canyonlands.dt[sb]
>  F: pc-bios/u-boot-sam460ex-20100605.bin
>  F: roms/u-boot-sam460ex
>  
> +Renesas Hardware
> +----------------
> +SH4 Hardware
> +M: Aurelien Jarno <aurelien@aurel32.net>
> +M: Philippe Mathieu-Daudé <f4bug@amsat.org>

That's fine for me, and just to be clear I don't mind being demoted to a
reviewer or even removed from there. I do not really have time to work
on that.

> +S: Odd Fixes
> +F: hw/sh4/
> +F: hw/char/sh_serial.c
> +F: hw/intc/sh_intc.c
> +F: hw/timer/sh_timer.c
> +F: include/hw/sh4/
> +
>  SH4 Machines
>  ------------
>  R2D
> @@ -1246,6 +1256,7 @@ S: Maintained
>  F: hw/sh4/r2d.c
>  F: hw/intc/sh_intc.c
>  F: hw/timer/sh_timer.c
> +F: include/hw/sh4/sh_intc.h
>  
>  Shix
>  M: Magnus Damm <magnus.damm@gmail.com>

Acked-by: Aurelien Jarno <aurelien@aurel32.net>

-- 
Aurelien Jarno                          GPG: 4096R/1DDD8C9B
aurelien@aurel32.net                 http://www.aurel32.net

Re: [PATCH] MAINTAINERS: Volunteer for maintaining the Renesas hardware

[Markus Armbruster]

Philippe Mathieu-Daudé <f4bug@amsat.org> writes:

> I don't have much clue about the Renesas hardware, but at least
> I know now the source files a little bit, so I volunteer to pick
> up patches and send pull-requests for them during my scarce
> hobbyist time, until someone else with more knowledge steps up
> to do this job instead.
>
> Suggested-by: Alex Bennée <alex.bennee@linaro.org>
> Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
> ---
>  MAINTAINERS | 15 +++++++++++++--
>  1 file changed, 13 insertions(+), 2 deletions(-)
>
> diff --git a/MAINTAINERS b/MAINTAINERS
> index 0944d9c731..cbba3ac757 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -298,9 +298,7 @@ SH4 TCG CPUs
>  M: Aurelien Jarno <aurelien@aurel32.net>
>  S: Odd Fixes
>  F: target/sh4/
> -F: hw/sh4/
>  F: disas/sh4.c
> -F: include/hw/sh4/
>  
>  SPARC TCG CPUs
>  M: Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>
> @@ -1238,6 +1236,18 @@ F: pc-bios/canyonlands.dt[sb]
>  F: pc-bios/u-boot-sam460ex-20100605.bin
>  F: roms/u-boot-sam460ex
>  
> +Renesas Hardware
> +----------------
> +SH4 Hardware
> +M: Aurelien Jarno <aurelien@aurel32.net>
> +M: Philippe Mathieu-Daudé <f4bug@amsat.org>
> +S: Odd Fixes
> +F: hw/sh4/
> +F: hw/char/sh_serial.c
> +F: hw/intc/sh_intc.c
> +F: hw/timer/sh_timer.c
> +F: include/hw/sh4/
> +
>  SH4 Machines
>  ------------
>  R2D
> @@ -1246,6 +1256,7 @@ S: Maintained
>  F: hw/sh4/r2d.c
>  F: hw/intc/sh_intc.c
>  F: hw/timer/sh_timer.c
> +F: include/hw/sh4/sh_intc.h
>  
>  Shix
>  M: Magnus Damm <magnus.damm@gmail.com>

hw/sh4 include/hw/sh4/ is Aurelien's "SH4 TCG CPUs" less target/sh4
disas/sh4.c.  Aurelien is fine with this overlap, so no problem.

hw/sh4/r2d.c hw/sh4/shix.c hw/intc/sh_intc.c hw/timer/sh_timer.c overlap
with "R2D" and "Shix".  You pointed out that Magnus hasn't been active
in years.  Having MAINTAINERS claim him even as "odd fixer" is
misleading then.  Have we tried to contact Magnus?

Say we can't reach him, or he instructs us to remove him from
MAINTAINERS.

The only parts of these two sections your new section doesn't claim is
hw/sh4/r2d.c and hw/sh4/shix.c.  Would you be willing to serve as odd
fixer for them, too?  Yes, I understand you don't have access to the
hardware, but how much worse is that for these too files than for the
remainder of hw/sh4/?

Re: [PATCH] MAINTAINERS: Volunteer for maintaining the Renesas hardware

[Philippe Mathieu-Daudé]

On 6/2/20 9:23 AM, Markus Armbruster wrote:
> Philippe Mathieu-Daudé <f4bug@amsat.org> writes:
> 
>> I don't have much clue about the Renesas hardware, but at least
>> I know now the source files a little bit, so I volunteer to pick
>> up patches and send pull-requests for them during my scarce
>> hobbyist time, until someone else with more knowledge steps up
>> to do this job instead.
>>
>> Suggested-by: Alex Bennée <alex.bennee@linaro.org>
>> Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
>> ---
>>  MAINTAINERS | 15 +++++++++++++--
>>  1 file changed, 13 insertions(+), 2 deletions(-)
>>
>> diff --git a/MAINTAINERS b/MAINTAINERS
>> index 0944d9c731..cbba3ac757 100644
>> --- a/MAINTAINERS
>> +++ b/MAINTAINERS
>> @@ -298,9 +298,7 @@ SH4 TCG CPUs
>>  M: Aurelien Jarno <aurelien@aurel32.net>
>>  S: Odd Fixes
>>  F: target/sh4/
>> -F: hw/sh4/
>>  F: disas/sh4.c
>> -F: include/hw/sh4/
>>  
>>  SPARC TCG CPUs
>>  M: Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>
>> @@ -1238,6 +1236,18 @@ F: pc-bios/canyonlands.dt[sb]
>>  F: pc-bios/u-boot-sam460ex-20100605.bin
>>  F: roms/u-boot-sam460ex
>>  
>> +Renesas Hardware
>> +----------------
>> +SH4 Hardware
>> +M: Aurelien Jarno <aurelien@aurel32.net>
>> +M: Philippe Mathieu-Daudé <f4bug@amsat.org>
>> +S: Odd Fixes
>> +F: hw/sh4/
>> +F: hw/char/sh_serial.c
>> +F: hw/intc/sh_intc.c
>> +F: hw/timer/sh_timer.c
>> +F: include/hw/sh4/
>> +
>>  SH4 Machines
>>  ------------
>>  R2D
>> @@ -1246,6 +1256,7 @@ S: Maintained
>>  F: hw/sh4/r2d.c
>>  F: hw/intc/sh_intc.c
>>  F: hw/timer/sh_timer.c
>> +F: include/hw/sh4/sh_intc.h
>>  
>>  Shix
>>  M: Magnus Damm <magnus.damm@gmail.com>
> 
> hw/sh4 include/hw/sh4/ is Aurelien's "SH4 TCG CPUs" less target/sh4
> disas/sh4.c.  Aurelien is fine with this overlap, so no problem.

See the History, generic coverage in SVN commit b6f97c14f59, then commit
fd5d5c566af keep all under target-sh4/, in ddb13561ac4 Aurelien steps
in, 2c9b7d1ab4e degraded to odd-fixes, the in fcf5ef2ab52 Thomas Huth
split hw/ VS target/.

I can read datasheets, so I am confident I can keep an eye to the
hardware and avoid its code to bitrot, highlighting I can only spend
humble hobby time on this.

I have less interest in the TCG code, so I prefer not touch it (thus,
left to Aurelien).

> 
> hw/sh4/r2d.c hw/sh4/shix.c hw/intc/sh_intc.c hw/timer/sh_timer.c overlap
> with "R2D" and "Shix".  You pointed out that Magnus hasn't been active
> in years.  Having MAINTAINERS claim him even as "odd fixer" is
> misleading then.  Have we tried to contact Magnus?

Well, he is automatically Cc'ed when these files are modified, but I
haven't seen him make comment on the list.

> 
> Say we can't reach him, or he instructs us to remove him from
> MAINTAINERS.
> 
> The only parts of these two sections your new section doesn't claim is
> hw/sh4/r2d.c and hw/sh4/shix.c.  Would you be willing to serve as odd
> fixer for them, too?  Yes, I understand you don't have access to the
> hardware, but how much worse is that for these too files than for the
> remainder of hw/sh4/?

As a side note, I once told Yoshinori that Renesas SH4 and Renesas RX
were having almost identical peripheral cores, and he recently sent a
nice series merging both hw:
https://lists.gnu.org/archive/html/qemu-devel/2020-05/msg08584.html

Which is why an unique 'Renesas Hardware' entry might make sense, and I
welcome Yoshinori if he wants to maintain it.

Then SH4/RX machines would be different entries.

After that, hw/sh4/r2d.c and hw/sh4/shix.c are indeed the only files
left in hw/sh4/. I am confident I can keep them in good shape.

I still want to insist that this will be during hobbyist time, based on
best effort. If someone else has time to do this, or can even be paid by
a company to look a it, I am more than happy to let him/her takes the role.

Regards,

Phil.

Re: [PATCH] MAINTAINERS: Volunteer for maintaining the Renesas hardware

[Philippe Mathieu-Daudé]

Hi Aleksandar, Yoshinori, Aurelien.

On 6/1/20 12:34 PM, Aleksandar Markovic wrote:
> On Mon, Jun 1, 2020 at 12:23 PM Philippe Mathieu-Daudé <f4bug@amsat.org> wrote:
>>
>> +Peter +Markus as neutral and experienced contributors.
>>
>> On 6/1/20 11:56 AM, Aleksandar Markovic wrote:
>>> On Mon, Jun 1, 2020 at 11:21 AM Philippe Mathieu-Daudé <f4bug@amsat.org> wrote:
>>>>
>>>> I don't have much clue about the Renesas hardware, but at least
>>>> I know now the source files a little bit, so I volunteer to pick
>>>> up patches and send pull-requests for them during my scarce
>>>> hobbyist time, until someone else with more knowledge steps up
>>>> to do this job instead.
>>>>
>>>> Suggested-by: Alex Bennée <alex.bennee@linaro.org>
>>>> Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
>>>> ---
>>>
>>> There is alive and well Renesas target maintainer that obviously has
>>> the access to Renesas hardware, and I have no idea why you should
>>> be the maintainer for something that you say do not have much clue,
>>> while at the same time omitting the original Renesas contributor.
>>
>> The last time Magnus was active was more than 10years ago...
>>
>> commit fc8e320ef5831dc0b0d744e369537893a4379753
>> Author: Magnus Damm <damm@opensource.se>
>> Date:   Fri Nov 13 18:51:05 2009 +0900
>>
>>     fix make clean targets
>>
>>     This patch fixes clean in case of missing directories and
>>     also adds code to distclean that removes the following files:
>>      qemu-monitor.texi roms/seabios/config.mak roms/vgabios/config.mak
>>
>>     Signed-off-by: Magnus Damm <damm@opensource.se>
>>     Signed-off-by: Aurelien Jarno <aurelien@aurel32.net>
>>
>> There are SH4 patches on the list:
>> https://lists.gnu.org/archive/html/qemu-devel/2020-05/msg08519.html
>>
>> Who is going to pick them?
>>
>>>
>>> Scandalous.
>>
>> I don't understand your attitude, I'm simply trying to help everyone by
>> giving time to the project, relieving overloaded maintainers. You only
>> keep tracking my activity and yelling about all my contributions. What
>> do you expect with all your critics? They are not very constructive and
>> don't improve much the project in general.
>>
> 
> You add the utter confusion to a clear thing.

I find it related.

I don't think what follow is the answer to "What do you expect with all
your critics?".

> 
> "Renesas" is not the same as "sh4". We had "sh4" as a target since
> forever, and now you suddenly want to change "sh4 hardware" to
> "Renesas hardware"??

QEMU makes a difference between hardware (peripherals) and architecture
(mostly ISA).

peripheral hardware is stored in hw/, while ISA in target/.

The SH4 architecture is stored in target/sh4/. The RX architecture is
stored in target/rx/.

Renesas produces chips implementing SH4 or RX.

It is common for a chip producer to reuse peripherals between
components. Renesas reused its UART & timers in its new RX-based
microcontroller series.

From a maintainer point of view, it makes sense to maintain similar
peripherals altogether.

Actually Yoshinori demostrated it, in his latest series:
https://www.mail-archive.com/qemu-devel@nongnu.org/msg708102.html
Yoshinori Sato (10):
  hw/intc: RX62N interrupt controller (ICUa)
  hw/timer: Renesas 8bit timer module.
  hw/timer: Renesas TMU/CMT module.
  hw/char: Renesas SCI module.
  hw/rx: RX MCU and target
  Add rx-softmmu
  hw/sh4: Convert renesas_sci.
  hw/char: remove sh_serial.c
  hw/sh4: Convert to renesas_timer.c
  hw/timer: remove sh_timer.c

In this series the SH4 and RX based machines reuse the same Renesas
peripherals.

> 
> Today, "Renesas", as a company, is more oriented towards architectures
> that are similar to "sh4", but not the same - RX architectures. I find it
> surprising and interesting you don't know that, since you participated
> in introduction of "RX" target. BTW, you also dictate there Yoshimoto
> that to do and what not to do. Why?

I never intended to dictate anything, and I apologize if it sounds like
I did. I'm using my hobbyist free time to help others get their code
integrated into the mainstream QEMU.
I think we all try to do our best. Some contributors joined the project
recently and send big series. If a contributor has more experience,
he/she can suggest changes so the contribution is more likely to be
merged. The project is big and with various APIs, it is hard to see
what side-effect can have a single change that appears isolated on
a remote subsystem.

I spend a lot of my personal time trying to improve Yoshinori work
so while it would be useful for him, it would also help other users.

It took me time because adding a new target/machine involves a lot of
code. But at the end I delivered something, I did not abandon
Yoshinori and his work.

---

Yoshinori, since you have obvious knowledge of the Renesas hardware,
and you might have access to it, do you agree to be listed as its
maintainer?

Aurelien, is that still OK with you?

Thanks,

Phil.

> 
> Aleksandar
> 
>> Regards,
>>
>> Phil.
>>
>>>
>>> Regards,
>>> Aleksandar
>>>
>>>>  MAINTAINERS | 15 +++++++++++++--
>>>>  1 file changed, 13 insertions(+), 2 deletions(-)
>>>>
>>>> diff --git a/MAINTAINERS b/MAINTAINERS
>>>> index 0944d9c731..cbba3ac757 100644
>>>> --- a/MAINTAINERS
>>>> +++ b/MAINTAINERS
>>>> @@ -298,9 +298,7 @@ SH4 TCG CPUs
>>>>  M: Aurelien Jarno <aurelien@aurel32.net>
>>>>  S: Odd Fixes
>>>>  F: target/sh4/
>>>> -F: hw/sh4/
>>>>  F: disas/sh4.c
>>>> -F: include/hw/sh4/
>>>>
>>>>  SPARC TCG CPUs
>>>>  M: Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>
>>>> @@ -1238,6 +1236,18 @@ F: pc-bios/canyonlands.dt[sb]
>>>>  F: pc-bios/u-boot-sam460ex-20100605.bin
>>>>  F: roms/u-boot-sam460ex
>>>>
>>>> +Renesas Hardware
>>>> +----------------
>>>> +SH4 Hardware
>>>> +M: Aurelien Jarno <aurelien@aurel32.net>
>>>> +M: Philippe Mathieu-Daudé <f4bug@amsat.org>
>>>> +S: Odd Fixes
>>>> +F: hw/sh4/
>>>> +F: hw/char/sh_serial.c
>>>> +F: hw/intc/sh_intc.c
>>>> +F: hw/timer/sh_timer.c
>>>> +F: include/hw/sh4/
>>>> +
>>>>  SH4 Machines
>>>>  ------------
>>>>  R2D
>>>> @@ -1246,6 +1256,7 @@ S: Maintained
>>>>  F: hw/sh4/r2d.c
>>>>  F: hw/intc/sh_intc.c
>>>>  F: hw/timer/sh_timer.c
>>>> +F: include/hw/sh4/sh_intc.h
>>>>
>>>>  Shix
>>>>  M: Magnus Damm <magnus.damm@gmail.com>
>>>> --
>>>> 2.21.3
>>>>
>>>>
>>>
> 

Re: [PATCH] MAINTAINERS: Volunteer for maintaining the Renesas hardware

[Philippe Mathieu-Daudé]

Hi Aurelien,

On 6/1/20 11:41 PM, Aurelien Jarno wrote:
> On 2020-06-01 11:20, Philippe Mathieu-Daudé wrote:
>> I don't have much clue about the Renesas hardware, but at least
>> I know now the source files a little bit, so I volunteer to pick
>> up patches and send pull-requests for them during my scarce
>> hobbyist time, until someone else with more knowledge steps up
>> to do this job instead.
>>
>> Suggested-by: Alex Bennée <alex.bennee@linaro.org>
>> Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
>> ---
>>  MAINTAINERS | 15 +++++++++++++--
>>  1 file changed, 13 insertions(+), 2 deletions(-)
>>
>> diff --git a/MAINTAINERS b/MAINTAINERS
>> index 0944d9c731..cbba3ac757 100644
>> --- a/MAINTAINERS
>> +++ b/MAINTAINERS
>> @@ -298,9 +298,7 @@ SH4 TCG CPUs
>>  M: Aurelien Jarno <aurelien@aurel32.net>
>>  S: Odd Fixes
>>  F: target/sh4/
>> -F: hw/sh4/
>>  F: disas/sh4.c
>> -F: include/hw/sh4/
>>  
>>  SPARC TCG CPUs
>>  M: Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>
>> @@ -1238,6 +1236,18 @@ F: pc-bios/canyonlands.dt[sb]
>>  F: pc-bios/u-boot-sam460ex-20100605.bin
>>  F: roms/u-boot-sam460ex
>>  
>> +Renesas Hardware
>> +----------------
>> +SH4 Hardware
>> +M: Aurelien Jarno <aurelien@aurel32.net>
>> +M: Philippe Mathieu-Daudé <f4bug@amsat.org>
> 
> That's fine for me, and just to be clear I don't mind being demoted to a
> reviewer or even removed from there. I do not really have time to work
> on that.

I understand. Aleksandar implicitly NAcked my patch, as there is
another contributor who is a better candidate, Yoshinori Sato.
He recently posted Renesas series:
https://www.mail-archive.com/qemu-devel@nongnu.org/msg708102.html

I'll simply send a patch to make this hardware orphan, and
Yoshinori can maintain it if he has the time and is willing to.

> 
>> +S: Odd Fixes
>> +F: hw/sh4/
>> +F: hw/char/sh_serial.c
>> +F: hw/intc/sh_intc.c
>> +F: hw/timer/sh_timer.c
>> +F: include/hw/sh4/
>> +
>>  SH4 Machines
>>  ------------
>>  R2D
>> @@ -1246,6 +1256,7 @@ S: Maintained
>>  F: hw/sh4/r2d.c
>>  F: hw/intc/sh_intc.c
>>  F: hw/timer/sh_timer.c
>> +F: include/hw/sh4/sh_intc.h
>>  
>>  Shix
>>  M: Magnus Damm <magnus.damm@gmail.com>
> 
> Acked-by: Aurelien Jarno <aurelien@aurel32.net>
> 

Re: [PATCH] MAINTAINERS: Volunteer for maintaining the Renesas hardware

[Yoshinori Sato]

On Mon, 08 Jun 2020 17:28:41 +0900,
Philippe Mathieu-Daudé wrote:
> 
> Hi Aurelien,
> 
> On 6/1/20 11:41 PM, Aurelien Jarno wrote:
> > On 2020-06-01 11:20, Philippe Mathieu-Daudé wrote:
> >> I don't have much clue about the Renesas hardware, but at least
> >> I know now the source files a little bit, so I volunteer to pick
> >> up patches and send pull-requests for them during my scarce
> >> hobbyist time, until someone else with more knowledge steps up
> >> to do this job instead.
> >>
> >> Suggested-by: Alex Bennée <alex.bennee@linaro.org>
> >> Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
> >> ---
> >>  MAINTAINERS | 15 +++++++++++++--
> >>  1 file changed, 13 insertions(+), 2 deletions(-)
> >>
> >> diff --git a/MAINTAINERS b/MAINTAINERS
> >> index 0944d9c731..cbba3ac757 100644
> >> --- a/MAINTAINERS
> >> +++ b/MAINTAINERS
> >> @@ -298,9 +298,7 @@ SH4 TCG CPUs
> >>  M: Aurelien Jarno <aurelien@aurel32.net>
> >>  S: Odd Fixes
> >>  F: target/sh4/
> >> -F: hw/sh4/
> >>  F: disas/sh4.c
> >> -F: include/hw/sh4/
> >>  
> >>  SPARC TCG CPUs
> >>  M: Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>
> >> @@ -1238,6 +1236,18 @@ F: pc-bios/canyonlands.dt[sb]
> >>  F: pc-bios/u-boot-sam460ex-20100605.bin
> >>  F: roms/u-boot-sam460ex
> >>  
> >> +Renesas Hardware
> >> +----------------
> >> +SH4 Hardware
> >> +M: Aurelien Jarno <aurelien@aurel32.net>
> >> +M: Philippe Mathieu-Daudé <f4bug@amsat.org>
> > 
> > That's fine for me, and just to be clear I don't mind being demoted to a
> > reviewer or even removed from there. I do not really have time to work
> > on that.
> 
> I understand. Aleksandar implicitly NAcked my patch, as there is
> another contributor who is a better candidate, Yoshinori Sato.
> He recently posted Renesas series:
> https://www.mail-archive.com/qemu-devel@nongnu.org/msg708102.html
> 
> I'll simply send a patch to make this hardware orphan, and
> Yoshinori can maintain it if he has the time and is willing to.
> 
> > 
> >> +S: Odd Fixes
> >> +F: hw/sh4/
> >> +F: hw/char/sh_serial.c
> >> +F: hw/intc/sh_intc.c
> >> +F: hw/timer/sh_timer.c
> >> +F: include/hw/sh4/
> >> +
> >>  SH4 Machines
> >>  ------------
> >>  R2D
> >> @@ -1246,6 +1256,7 @@ S: Maintained
> >>  F: hw/sh4/r2d.c
> >>  F: hw/intc/sh_intc.c
> >>  F: hw/timer/sh_timer.c
> >> +F: include/hw/sh4/sh_intc.h
> >>  
> >>  Shix
> >>  M: Magnus Damm <magnus.damm@gmail.com>
> > 
> > Acked-by: Aurelien Jarno <aurelien@aurel32.net>
> > 
> 

I agree with the proposal.
Acked-by: Yosinori Sato <ysato@users.sourceforge.jp>

-- 
Yosinori Sato