* Chardev: delete the QemuOpts reserved in vm_config_groups
@ 2021-11-06 10:23 =?gb18030?B?pNe357n9zt662z8/?=
2021-11-08 8:46 ` Marc-André Lureau
0 siblings, 1 reply; 6+ messages in thread
From: =?gb18030?B?pNe357n9zt662z8/?= @ 2021-11-06 10:23 UTC (permalink / raw)
To: =?gb18030?B?bWFyY2FuZHJlLmx1cmVhdQ==?=, =?gb18030?B?cGJvbnppbmk=?=
Cc: =?gb18030?B?cWVtdS1kZXZlbA==?=
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain; charset="gb18030", Size: 3037 bytes --]
We have found that qemu cannot plug in the previously unplugged device.
start qemu with the following command:
./qemu-system-x86_64 -enable-kvm -m 8192 -smp 16 \
-object memory-backend-file,id=mem,size=8192M,mem-path=/dev/hugepages,share=on \
-numa node,memdev=mem -mem-prealloc \
...
-chardev socket,id=drive-virtio-disk1,path=/var/run/spdk/vhost_blk_socket-30dcf467-486a-45cf-b754-093bf5cf24d1,reconnect=10 \
-device vhost-user-blk-pci,chardev=drive-virtio-disk1,num-queues=1,bus=pci.0,addr=0x5,id=virtio-disk1 \
...
(qemu) info chardev
serial0: filename=pty:/dev/pts/0
drive-virtio-disk1: filename=unix:
charmonitor:
filename=unix:/usr/local/var/lib/libvirt/qemu/domain-55-e59039db-d576-40db-a/monitor.sock,server
(qemu) device_del virtio-disk1
(qemu) chardev-remove drive-virtio-disk1
(qemu) info chardev
serial0: filename=pty:/dev/pts/0
charmonitor:
filename=unix:/usr/local/var/lib/libvirt/qemu/domain-55-e59039db-d576-40db-a/monitor.sock,server
(qemu) chardev-add socket,id=drive-virtio-disk1,path=/var/run/spdk/vhost_blk_socket-30dcf467-486a-45cf-b754-093bf5cf24d1,reconnect=10
device failed: Duplicate ID 'drive-virtio-disk1' for chardev Error: Parsing chardev args failed
The root cause of this issue is that the QemuOpts is still reserved in vm_config_groups list,
so qemu_opts_create will fail with the error above. So the QemuOpts should be removed when
invoking qmp_chardev_remove.
Signed-off-by: Zhoujian Yu <windyu@tencent.com>
Reviewed-by: Lei Wang <kaierwang@tencent.com>
Reviewed-by: Xun Ni <richardni@tencent.com>
Reviewed-by: Zhigang Lu <tonnylu@tencent.com>
---
chardev/char.c | 6 ++++++
1 file changed, 6 insertions(+)
diff --git a/chardev/char.c b/chardev/char.c
index 398f09d..d2087bd 100644
--- a/chardev/char.c
+++ b/chardev/char.c
@@ -37,6 +37,7 @@
#include "qemu/help_option.h"
#include "qemu/module.h"
#include "qemu/option.h"
+#include "qemu/option_int.h"
#include "qemu/id.h"
#include "qemu/coroutine.h"
#include "qemu/yank.h"
@@ -1159,6 +1160,7 @@ ChardevReturn *qmp_chardev_change(const char *id, ChardevBackend *backend,
void qmp_chardev_remove(const char *id, Error **errp)
{
Chardev *chr;
+ QemuOpts *opts;
chr = qemu_chr_find(id);
if (chr == NULL) {
@@ -1175,6 +1177,10 @@ void qmp_chardev_remove(const char *id, Error **errp)
return;
}
object_unparent(OBJECT(chr));
+ /* delete the opts reserved in vm_config_groups list. */
+ opts = qemu_opts_find(qemu_find_opts("chardev"), id);
+ if (opts)
+ qemu_opts_del(opts);
}
void qmp_chardev_send_break(const char *id, Error **errp)
--
1.8.3.1
[-- Attachment #2: Type: text/html, Size: 3771 bytes --]
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: Chardev: delete the QemuOpts reserved in vm_config_groups
2021-11-06 10:23 Chardev: delete the QemuOpts reserved in vm_config_groups =?gb18030?B?pNe357n9zt662z8/?=
@ 2021-11-08 8:46 ` Marc-André Lureau
2021-11-09 2:55 ` =?gb18030?B?u9i4tKO6IENoYXJkZXY6IGRlbGV0ZSB0aGUgUWVtdU9wdHMgcmVzZXJ2ZWQgaW4gdm1fY29uZmlnX2dyb3Vwcw==?= =?gb18030?B?pNe357n9zt662z8/?=
2021-11-19 9:27 ` Paolo Bonzini
0 siblings, 2 replies; 6+ messages in thread
From: Marc-André Lureau @ 2021-11-08 8:46 UTC (permalink / raw)
To: ぷ风过无痕??; +Cc: pbonzini, qemu-devel
Hi
On Sat, Nov 6, 2021 at 10:41 PM ぷ风过无痕?? <787738581@qq.com> wrote:
>
> We have found that qemu cannot plug in the previously unplugged device.
> start qemu with the following command:
> ./qemu-system-x86_64 -enable-kvm -m 8192 -smp 16 \
> -object memory-backend-file,id=mem,size=8192M,mem-path=/dev/hugepages,share=on \
> -numa node,memdev=mem -mem-prealloc \
> ...
> -chardev socket,id=drive-virtio-disk1,path=/var/run/spdk/vhost_blk_socket-30dcf467-486a-45cf-b754-093bf5cf24d1,reconnect=10 \
> -device vhost-user-blk-pci,chardev=drive-virtio-disk1,num-queues=1,bus=pci.0,addr=0x5,id=virtio-disk1 \
> ...
>
> (qemu) info chardev
> serial0: filename=pty:/dev/pts/0
> drive-virtio-disk1: filename=unix:
> charmonitor:
> filename=unix:/usr/local/var/lib/libvirt/qemu/domain-55-e59039db-d576-40db-a/monitor.sock,server
> (qemu) device_del virtio-disk1
> (qemu) chardev-remove drive-virtio-disk1
> (qemu) info chardev
> serial0: filename=pty:/dev/pts/0
> charmonitor:
> filename=unix:/usr/local/var/lib/libvirt/qemu/domain-55-e59039db-d576-40db-a/monitor.sock,server
> (qemu) chardev-add socket,id=drive-virtio-disk1,path=/var/run/spdk/vhost_blk_socket-30dcf467-486a-45cf-b754-093bf5cf24d1,reconnect=10
> device failed: Duplicate ID 'drive-virtio-disk1' for chardev Error: Parsing chardev args failed
>
> The root cause of this issue is that the QemuOpts is still reserved in vm_config_groups list,
> so qemu_opts_create will fail with the error above. So the QemuOpts should be removed when
> invoking qmp_chardev_remove.
>
>
> Signed-off-by: Zhoujian Yu <windyu@tencent.com>
> Reviewed-by: Lei Wang <kaierwang@tencent.com>
> Reviewed-by: Xun Ni <richardni@tencent.com>
> Reviewed-by: Zhigang Lu <tonnylu@tencent.com>
> ---
> chardev/char.c | 6 ++++++
> 1 file changed, 6 insertions(+)
>
> diff --git a/chardev/char.c b/chardev/char.c
> index 398f09d..d2087bd 100644
> --- a/chardev/char.c
> +++ b/chardev/char.c
> @@ -37,6 +37,7 @@
> #include "qemu/help_option.h"
> #include "qemu/module.h"
> #include "qemu/option.h"
> +#include "qemu/option_int.h"
> #include "qemu/id.h"
> #include "qemu/coroutine.h"
> #include "qemu/yank.h"
> @@ -1159,6 +1160,7 @@ ChardevReturn *qmp_chardev_change(const char *id, ChardevBackend *backend,
> void qmp_chardev_remove(const char *id, Error **errp)
> {
> Chardev *chr;
> + QemuOpts *opts;
>
> chr = qemu_chr_find(id);
> if (chr == NULL) {
> @@ -1175,6 +1177,10 @@ void qmp_chardev_remove(const char *id, Error **errp)
> return;
> }
> object_unparent(OBJECT(chr));
> + /* delete the opts reserved in vm_config_groups list. */
> + opts = qemu_opts_find(qemu_find_opts("chardev"), id);
> + if (opts)
> + qemu_opts_del(opts);
That seems reasonable to me,
Reviewed-by: Marc-André Lureau <marcandre.lureau@redhat.com>
> }
>
> void qmp_chardev_send_break(const char *id, Error **errp)
> --
> 1.8.3.1
^ permalink raw reply [flat|nested] 6+ messages in thread
* =?gb18030?B?u9i4tKO6IENoYXJkZXY6IGRlbGV0ZSB0aGUgUWVtdU9wdHMgcmVzZXJ2ZWQgaW4gdm1fY29uZmlnX2dyb3Vwcw==?=
2021-11-08 8:46 ` Marc-André Lureau
@ 2021-11-09 2:55 ` =?gb18030?B?pNe357n9zt662z8/?=
2021-11-15 8:14 ` Chardev: delete the QemuOpts reserved in vm_config_groups =?gb18030?B?pNe357n9zt662z8/?=
2021-11-19 9:27 ` Paolo Bonzini
1 sibling, 1 reply; 6+ messages in thread
From: =?gb18030?B?pNe357n9zt662z8/?= @ 2021-11-09 2:55 UTC (permalink / raw)
To: =?gb18030?B?TWFyYy1BbmRyqKYgTHVyZWF1?=
Cc: =?gb18030?B?cGJvbnppbmk=?=, =?gb18030?B?cWVtdS1kZXZlbA==?=
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain; charset="gb18030", Size: 3800 bytes --]
Hi Lureau,
You say that hot-add failare is reasonable after hot-remove? I think it is a clear issue.
>Hi
On Sat, Nov 6, 2021 at 10:41 PM ¤×·ç¹ýÎÞºÛ?? <787738581@qq.com> wrote:
>
> We have found that qemu cannot plug in the previously unplugged device.
> start qemu with the following command:
> ./qemu-system-x86_64 -enable-kvm -m 8192 -smp 16 \
> -object memory-backend-file,id=mem,size=8192M,mem-path=/dev/hugepages,share=on \
> -numa node,memdev=mem -mem-prealloc \
> ...
> -chardev socket,id=drive-virtio-disk1,path=/var/run/spdk/vhost_blk_socket-30dcf467-486a-45cf-b754-093bf5cf24d1,reconnect=10 \
> -device vhost-user-blk-pci,chardev=drive-virtio-disk1,num-queues=1,bus=pci.0,addr=0x5,id=virtio-disk1 \
> ...
>
> (qemu) info chardev
> serial0: filename=pty:/dev/pts/0
> drive-virtio-disk1: filename=unix:
> charmonitor:
> filename=unix:/usr/local/var/lib/libvirt/qemu/domain-55-e59039db-d576-40db-a/monitor.sock,server
> (qemu) device_del virtio-disk1
> (qemu) chardev-remove drive-virtio-disk1
> (qemu) info chardev
> serial0: filename=pty:/dev/pts/0
> charmonitor:
> filename=unix:/usr/local/var/lib/libvirt/qemu/domain-55-e59039db-d576-40db-a/monitor.sock,server
> (qemu) chardev-add socket,id=drive-virtio-disk1,path=/var/run/spdk/vhost_blk_socket-30dcf467-486a-45cf-b754-093bf5cf24d1,reconnect=10
> device failed: Duplicate ID 'drive-virtio-disk1' for chardev Error: Parsing chardev args failed
>
> The root cause of this issue is that the QemuOpts is still reserved in vm_config_groups list,
> so qemu_opts_create will fail with the error above. So the QemuOpts should be removed when
> invoking qmp_chardev_remove.
>
>
> Signed-off-by: Zhoujian Yu <windyu@tencent.com>
> Reviewed-by: Lei Wang <kaierwang@tencent.com>
> Reviewed-by: Xun Ni <richardni@tencent.com>
> Reviewed-by: Zhigang Lu <tonnylu@tencent.com>
> ---
> chardev/char.c | 6 ++++++
> 1 file changed, 6 insertions(+)
>
> diff --git a/chardev/char.c b/chardev/char.c
> index 398f09d..d2087bd 100644
> --- a/chardev/char.c
> +++ b/chardev/char.c
> @@ -37,6 +37,7 @@
> #include "qemu/help_option.h"
> #include "qemu/module.h"
> #include "qemu/option.h"
> +#include "qemu/option_int.h"
> #include "qemu/id.h"
> #include "qemu/coroutine.h"
> #include "qemu/yank.h"
> @@ -1159,6 +1160,7 @@ ChardevReturn *qmp_chardev_change(const char *id, ChardevBackend *backend,
> void qmp_chardev_remove(const char *id, Error **errp)
> {
> Chardev *chr;
> + QemuOpts *opts;
>
> chr = qemu_chr_find(id);
> if (chr == NULL) {
> @@ -1175,6 +1177,10 @@ void qmp_chardev_remove(const char *id, Error **errp)
> return;
> }
> object_unparent(OBJECT(chr));
> + /* delete the opts reserved in vm_config_groups list. */
> + opts = qemu_opts_find(qemu_find_opts("chardev"), id);
> + if (opts)
> + qemu_opts_del(opts);
That seems reasonable to me,
Reviewed-by: Marc-Andr¨¦ Lureau <marcandre.lureau@redhat.com>
> }
>
> void qmp_chardev_send_break(const char *id, Error **errp)
> --
> 1.8.3.1
[-- Attachment #2: Type: text/html, Size: 4085 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread
* Chardev: delete the QemuOpts reserved in vm_config_groups
2021-11-09 2:55 ` =?gb18030?B?u9i4tKO6IENoYXJkZXY6IGRlbGV0ZSB0aGUgUWVtdU9wdHMgcmVzZXJ2ZWQgaW4gdm1fY29uZmlnX2dyb3Vwcw==?= =?gb18030?B?pNe357n9zt662z8/?=
@ 2021-11-15 8:14 ` =?gb18030?B?pNe357n9zt662z8/?=
0 siblings, 0 replies; 6+ messages in thread
From: =?gb18030?B?pNe357n9zt662z8/?= @ 2021-11-15 8:14 UTC (permalink / raw)
To: =?gb18030?B?TWFyYy1BbmRyqKYgTHVyZWF1?=
Cc: =?gb18030?B?cGJvbnppbmk=?=, =?gb18030?B?cWVtdS1kZXZlbA==?=
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain; charset="gb18030", Size: 3745 bytes --]
PING
thanks, Wind Yu
Hi Lureau,
You say that hot-add failare is reasonable after hot-remove? I think it is a clear issue.
>Hi
On Sat, Nov 6, 2021 at 10:41 PM ¤×·ç¹ýÎÞºÛ?? <787738581@qq.com> wrote:
>
> We have found that qemu cannot plug in the previously unplugged device.
> start qemu with the following command:
> ./qemu-system-x86_64 -enable-kvm -m 8192 -smp 16 \
> -object memory-backend-file,id=mem,size=8192M,mem-path=/dev/hugepages,share=on \
> -numa node,memdev=mem -mem-prealloc \
> ...
> -chardev socket,id=drive-virtio-disk1,path=/var/run/spdk/vhost_blk_socket-30dcf467-486a-45cf-b754-093bf5cf24d1,reconnect=10 \
> -device vhost-user-blk-pci,chardev=drive-virtio-disk1,num-queues=1,bus=pci.0,addr=0x5,id=virtio-disk1 \
> ...
>
> (qemu) info chardev
> serial0: filename=pty:/dev/pts/0
> drive-virtio-disk1: filename=unix:
> charmonitor:
> filename=unix:/usr/local/var/lib/libvirt/qemu/domain-55-e59039db-d576-40db-a/monitor.sock,server
> (qemu) device_del virtio-disk1
> (qemu) chardev-remove drive-virtio-disk1
> (qemu) info chardev
> serial0: filename=pty:/dev/pts/0
> charmonitor:
> filename=unix:/usr/local/var/lib/libvirt/qemu/domain-55-e59039db-d576-40db-a/monitor.sock,server
> (qemu) chardev-add socket,id=drive-virtio-disk1,path=/var/run/spdk/vhost_blk_socket-30dcf467-486a-45cf-b754-093bf5cf24d1,reconnect=10
> device failed: Duplicate ID 'drive-virtio-disk1' for chardev Error: Parsing chardev args failed
>
> The root cause of this issue is that the QemuOpts is still reserved in vm_config_groups list,
> so qemu_opts_create will fail with the error above. So the QemuOpts should be removed when
> invoking qmp_chardev_remove.
>
>
> Signed-off-by: Zhoujian Yu <windyu@tencent.com>
> Reviewed-by: Lei Wang <kaierwang@tencent.com>
> Reviewed-by: Xun Ni <richardni@tencent.com>
> Reviewed-by: Zhigang Lu <tonnylu@tencent.com>
> ---
> chardev/char.c | 6 ++++++
> 1 file changed, 6 insertions(+)
>
> diff --git a/chardev/char.c b/chardev/char.c
> index 398f09d..d2087bd 100644
> --- a/chardev/char.c
> +++ b/chardev/char.c
> @@ -37,6 +37,7 @@
> #include "qemu/help_option.h"
> #include "qemu/module.h"
> #include "qemu/option.h"
> +#include "qemu/option_int.h"
> #include "qemu/id.h"
> #include "qemu/coroutine.h"
> #include "qemu/yank.h"
> @@ -1159,6 +1160,7 @@ ChardevReturn *qmp_chardev_change(const char *id, ChardevBackend *backend,
> void qmp_chardev_remove(const char *id, Error **errp)
> {
> Chardev *chr;
> + QemuOpts *opts;
>
> chr = qemu_chr_find(id);
> if (chr == NULL) {
> @@ -1175,6 +1177,10 @@ void qmp_chardev_remove(const char *id, Error **errp)
> return;
> }
> object_unparent(OBJECT(chr));
> + /* delete the opts reserved in vm_config_groups list. */
> + opts = qemu_opts_find(qemu_find_opts("chardev"), id);
> + if (opts)
> + qemu_opts_del(opts);
That seems reasonable to me,
Reviewed-by: Marc-Andr¨¦ Lureau <marcandre.lureau@redhat.com>
> }
>
> void qmp_chardev_send_break(const char *id, Error **errp)
> --
> 1.8.3.1
[-- Attachment #2: Type: text/html, Size: 4079 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: Chardev: delete the QemuOpts reserved in vm_config_groups
2021-11-08 8:46 ` Marc-André Lureau
2021-11-09 2:55 ` =?gb18030?B?u9i4tKO6IENoYXJkZXY6IGRlbGV0ZSB0aGUgUWVtdU9wdHMgcmVzZXJ2ZWQgaW4gdm1fY29uZmlnX2dyb3Vwcw==?= =?gb18030?B?pNe357n9zt662z8/?=
@ 2021-11-19 9:27 ` Paolo Bonzini
2021-11-19 9:55 ` =?gb18030?B?u9i4tKO6IENoYXJkZXY6IGRlbGV0ZSB0aGUgUWVtdU9wdHMgcmVzZXJ2ZWQgaW4gdm1fY29uZmlnX2dyb3Vwcw==?= =?gb18030?B?pNe357n9zt662z8/?=
1 sibling, 1 reply; 6+ messages in thread
From: Paolo Bonzini @ 2021-11-19 9:27 UTC (permalink / raw)
To: Marc-André Lureau, ぷ风过无痕??
Cc: qemu-devel
On 11/8/21 09:46, Marc-André Lureau wrote:
>> + QemuOpts *opts;
>>
>> chr = qemu_chr_find(id);
>> if (chr == NULL) {
>> @@ -1175,6 +1177,10 @@ void qmp_chardev_remove(const char *id, Error **errp)
>> return;
>> }
>> object_unparent(OBJECT(chr));
>> + /* delete the opts reserved in vm_config_groups list. */
>> + opts = qemu_opts_find(qemu_find_opts("chardev"), id);
>> + if (opts)
>> + qemu_opts_del(opts);
> That seems reasonable to me,
> Reviewed-by: Marc-André Lureau<marcandre.lureau@redhat.com>
I think it should be done instead in an unparent function, i.e. with
something like "oc->unparent = chr_unparent;" in char_class_init.
chr_unparent does the qemu_opts_find/qemu_opts_del.
Thanks,
Paolo
^ permalink raw reply [flat|nested] 6+ messages in thread
* =?gb18030?B?u9i4tKO6IENoYXJkZXY6IGRlbGV0ZSB0aGUgUWVtdU9wdHMgcmVzZXJ2ZWQgaW4gdm1fY29uZmlnX2dyb3Vwcw==?=
2021-11-19 9:27 ` Paolo Bonzini
@ 2021-11-19 9:55 ` =?gb18030?B?pNe357n9zt662z8/?=
0 siblings, 0 replies; 6+ messages in thread
From: =?gb18030?B?pNe357n9zt662z8/?= @ 2021-11-19 9:55 UTC (permalink / raw)
To: =?gb18030?B?UGFvbG8gQm9uemluaQ==?=,
=?gb18030?B?TWFyYy1BbmRyqKYgTHVyZWF1?=
Cc: =?gb18030?B?cWVtdS1kZXZlbA==?=
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain; charset="gb18030", Size: 1821 bytes --]
OK, thank you Paolo! I will write a char_unparent as your comment.
Wind Yu
------------------ ÔʼÓʼþ ------------------
·¢¼þÈË: "Paolo Bonzini" <pbonzini@redhat.com>;
·¢ËÍʱ¼ä: 2021Äê11ÔÂ19ÈÕ(ÐÇÆÚÎå) ÏÂÎç5:27
ÊÕ¼þÈË: "Marc-Andr¨¦ Lureau"<marcandre.lureau@redhat.com>;"¤×·ç¹ýÎÞºÛ??"<787738581@qq.com>;
³ËÍ: "qemu-devel"<qemu-devel@nongnu.org>;
Ö÷Ìâ: Re: Chardev: delete the QemuOpts reserved in vm_config_groups
On 11/8/21 09:46, Marc-Andr¨¦ Lureau wrote:
>> + QemuOpts *opts;
>>
>> chr = qemu_chr_find(id);
>> if (chr == NULL) {
>> @@ -1175,6 +1177,10 @@ void qmp_chardev_remove(const char *id, Error **errp)
>> return;
>> }
>> object_unparent(OBJECT(chr));
>> + /* delete the opts reserved in vm_config_groups list. */
>> + opts = qemu_opts_find(qemu_find_opts("chardev"), id);
>> + if (opts)
>> + qemu_opts_del(opts);
> That seems reasonable to me,
> Reviewed-by: Marc-Andr¨¦ Lureau<marcandre.lureau@redhat.com>
I think it should be done instead in an unparent function, i.e. with
something like "oc->unparent = chr_unparent;" in char_class_init.
chr_unparent does the qemu_opts_find/qemu_opts_del.
Thanks,
Paolo
[-- Attachment #2: Type: text/html, Size: 2261 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2021-11-19 9:57 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-11-06 10:23 Chardev: delete the QemuOpts reserved in vm_config_groups =?gb18030?B?pNe357n9zt662z8/?=
2021-11-08 8:46 ` Marc-André Lureau
2021-11-09 2:55 ` =?gb18030?B?u9i4tKO6IENoYXJkZXY6IGRlbGV0ZSB0aGUgUWVtdU9wdHMgcmVzZXJ2ZWQgaW4gdm1fY29uZmlnX2dyb3Vwcw==?= =?gb18030?B?pNe357n9zt662z8/?=
2021-11-15 8:14 ` Chardev: delete the QemuOpts reserved in vm_config_groups =?gb18030?B?pNe357n9zt662z8/?=
2021-11-19 9:27 ` Paolo Bonzini
2021-11-19 9:55 ` =?gb18030?B?u9i4tKO6IENoYXJkZXY6IGRlbGV0ZSB0aGUgUWVtdU9wdHMgcmVzZXJ2ZWQgaW4gdm1fY29uZmlnX2dyb3Vwcw==?= =?gb18030?B?pNe357n9zt662z8/?=
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).