From: Daniel Henrique Barboza <dbarboza@ventanamicro.com>
To: Weiwei Li <liweiwei@iscas.ac.cn>,
qemu-riscv@nongnu.org, qemu-devel@nongnu.org
Cc: palmer@dabbelt.com, alistair.francis@wdc.com,
bin.meng@windriver.com, zhiwei_liu@linux.alibaba.com,
wangjunqiang@iscas.ac.cn, lazyparser@gmail.com
Subject: Re: [PATCH 4/4] target/riscv: Remove redundant assignment to SXL
Date: Tue, 30 May 2023 17:28:24 -0300 [thread overview]
Message-ID: <0b5ea8ce-48fe-22b8-7247-90d8fe727b1d@ventanamicro.com> (raw)
In-Reply-To: <20230529121719.179507-5-liweiwei@iscas.ac.cn>
On 5/29/23 09:17, Weiwei Li wrote:
> SXL is initialized as env->misa_mxl which is also the mxl value.
> So we can just remain it unchanged to keep it read-only.
>
> Signed-off-by: Weiwei Li <liweiwei@iscas.ac.cn>
> Signed-off-by: Junqiang Wang <wangjunqiang@iscas.ac.cn>
> ---
Reviewed-by: Daniel Henrique Barboza <dbarboza@ventanamicro.com>
> target/riscv/csr.c | 4 ----
> 1 file changed, 4 deletions(-)
>
> diff --git a/target/riscv/csr.c b/target/riscv/csr.c
> index 6ac11d1f11..25345f3153 100644
> --- a/target/riscv/csr.c
> +++ b/target/riscv/csr.c
> @@ -1321,10 +1321,6 @@ static RISCVException write_mstatus(CPURISCVState *env, int csrno,
>
> mstatus = (mstatus & ~mask) | (val & mask);
>
> - if (xl > MXL_RV32) {
> - /* SXL field is for now read only */
> - mstatus = set_field(mstatus, MSTATUS64_SXL, xl);
> - }
> env->mstatus = mstatus;
>
> /*
next prev parent reply other threads:[~2023-05-30 20:28 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-29 12:17 [PATCH 0/4] target/riscv: Fix mstatus related problems Weiwei Li
2023-05-29 12:17 ` [PATCH 1/4] target/riscv: Make MPV only work when MPP != PRV_M Weiwei Li
2023-05-30 20:23 ` Daniel Henrique Barboza
2023-05-31 0:27 ` Weiwei Li
2023-05-31 9:28 ` Daniel Henrique Barboza
2023-05-31 9:28 ` Daniel Henrique Barboza
2023-06-01 5:24 ` Alistair Francis
2023-06-12 2:45 ` LIU Zhiwei
2023-06-12 3:10 ` Weiwei Li
2023-06-12 3:30 ` LIU Zhiwei
2023-05-29 12:17 ` [PATCH 2/4] target/riscv: Remove check on mode for MPRV Weiwei Li
2023-05-30 20:25 ` Daniel Henrique Barboza
2023-05-31 9:28 ` Daniel Henrique Barboza
2023-06-01 5:27 ` Alistair Francis
2023-06-01 6:43 ` Weiwei Li
2023-06-01 23:03 ` Alistair Francis
2023-06-02 1:31 ` Weiwei Li
2023-06-02 21:01 ` Richard Henderson
2023-06-03 13:46 ` Weiwei Li
2023-05-29 12:17 ` [PATCH 3/4] target/riscv: Support MSTATUS.MPV/GVA only when RVH is enabled Weiwei Li
2023-05-30 20:26 ` Daniel Henrique Barboza
2023-06-01 5:28 ` Alistair Francis
2023-06-12 3:08 ` LIU Zhiwei
2023-06-12 3:16 ` Weiwei Li
2023-06-12 3:18 ` LIU Zhiwei
2023-06-12 4:35 ` Weiwei Li
2023-06-12 5:40 ` LIU Zhiwei
2023-06-12 7:27 ` Weiwei Li
2023-05-29 12:17 ` [PATCH 4/4] target/riscv: Remove redundant assignment to SXL Weiwei Li
2023-05-30 20:28 ` Daniel Henrique Barboza [this message]
2023-06-01 5:31 ` Alistair Francis
2023-06-12 5:55 ` LIU Zhiwei
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0b5ea8ce-48fe-22b8-7247-90d8fe727b1d@ventanamicro.com \
--to=dbarboza@ventanamicro.com \
--cc=alistair.francis@wdc.com \
--cc=bin.meng@windriver.com \
--cc=lazyparser@gmail.com \
--cc=liweiwei@iscas.ac.cn \
--cc=palmer@dabbelt.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-riscv@nongnu.org \
--cc=wangjunqiang@iscas.ac.cn \
--cc=zhiwei_liu@linux.alibaba.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).