From: Jason Gunthorpe <jgg@nvidia.com> To: iommu@lists.linux.dev, Joerg Roedel <joro@8bytes.org>, linux-arm-kernel@lists.infradead.org, Robin Murphy <robin.murphy@arm.com>, Will Deacon <will@kernel.org> Cc: Eric Auger <eric.auger@redhat.com>, Jean-Philippe Brucker <jean-philippe@linaro.org>, Moritz Fischer <mdf@kernel.org>, Michael Shavit <mshavit@google.com>, Nicolin Chen <nicolinc@nvidia.com>, patches@lists.linux.dev, Shameerali Kolothum Thodi <shameerali.kolothum.thodi@huawei.com> Subject: [PATCH v4 00/27] Update SMMUv3 to the modern iommu API (part 2/3) Date: Fri, 26 Jan 2024 14:15:02 -0400 [thread overview] Message-ID: <0-v4-e7091cdd9e8d+43b1-smmuv3_newapi_p2_jgg@nvidia.com> (raw) Continuing the work of part 1 this focuses on the CD, PASID and SVA components: - attach_dev failure does not change the HW configuration. - Full PASID API support including: - S1/SVA domains attached to PASIDs - IDENTITY/BLOCKED/S1 attached to RID - Change of the RID domain while PASIDs are attached - Streamlined SVA support using the core infrastructure - Hitless, whenever possible, change between two domains Making the CD programming work like the new STE programming allows untangling some of the confusing SVA flows. From there the focus is on building out the core infrastructure for dealing with PASID and CD entries, then keeping track of unique SSID's for ATS invalidation. The ATS ordering is generalized so that the PASID flow can use it and put into a form where it is fully hitless, whenever possible. Care is taken to ensure that ATC flushes are present after any change in translation. Finally we simply kill the entire outdated SVA mmu_notifier implementation in one shot and switch it over to the newly created generic PASID & CD code. This avoids the messy and confusing approach of trying to incrementally untangle this in place. The new code is small and simple enough this is much better than trying to figure out smaller steps. Once SVA is resting on the right CD code it is straightforward to make the PASID interface functionally complete. This depends on part 1 It achieves the same goals as the several series from Michael and the S1DSS series from Nicolin that were trying to improve portions of the API. This is on github: https://github.com/jgunthorpe/linux/commits/smmuv3_newapi v4: - Rebase on v6.8-rc1, adjust to use mm_get_enqcmd_pasid() and eventually remove all references from ARM. Move the new ARM_SMMU_FEAT_STALL_FORCE stuff to arm_smmu_make_sva_cd() - Adjust to use the new shared STE/CD writer logic. Disable some of the sanity checks for the interior of the series - Return ERR_PTR from domain_alloc functions - Move the ATS disablement flow into arm_smmu_attach_prepare()/commit() which lets all the STE update flows use the same sequence. This is needed for nesting in part 3 - Put ssid in attach_state - Replace to_smmu_domain_safe() with to_smmu_domain_devices() v3: https://lore.kernel.org/r/0-v3-9083a9368a5c+23fb-smmuv3_newapi_p2_jgg@nvidia.com - Rebase on the latest part 1 - update comments and commit messages - Fix error exit in arm_smmu_set_pasid() - Fix inverted logic for btm_invalidation - Add missing ATC invalidation on mm release - Add a big comment explaining that BTM is not enabled and what is missing to enable it. v2: https://lore.kernel.org/r/0-v2-16665a652079+5947-smmuv3_newapi_p2_jgg@nvidia.com - Rebased on iommmufd + Joerg's tree - Use sid_smmu_domain consistently to refer to the domain attached to the device (eg the PCIe RID) - Rework how arm_smmu_attach_*() and callers flow to be more careful about ordering around ATC invalidation. The ATC must be invalidated after it is impossible to establish stale entires. - ATS disable is now entirely part of arm_smmu_attach_dev_ste(), which is the only STE type that ever disables ATS. - Remove the 'existing_master_domain' optimization, the code is functionally fine without it. - Whitespace, spelling, and checkpatch related items - Fixed wrong value stored in the xa for the BTM flows - Use pasid more consistently instead of id v1: https://lore.kernel.org/r/0-v1-afbb86647bbd+5-smmuv3_newapi_p2_jgg@nvidia.com Jason Gunthorpe (27): iommu/arm-smmu-v3: Check that the RID domain is S1 in SVA iommu/arm-smmu-v3: Do not allow a SVA domain to be set on the wrong PASID iommu/arm-smmu-v3: Do not ATC invalidate the entire domain iommu/arm-smmu-v3: Add a type for the CD entry iommu/arm-smmu-v3: Make CD programming use arm_smmu_write_entry() iommu/arm-smmu-v3: Consolidate clearing a CD table entry iommu/arm-smmu-v3: Move the CD generation for S1 domains into a function iommu/arm-smmu-v3: Move allocation of the cdtable into arm_smmu_get_cd_ptr() iommu/arm-smmu-v3: Allocate the CD table entry in advance iommu/arm-smmu-v3: Move the CD generation for SVA into a function iommu/arm-smmu-v3: Lift CD programming out of the SVA notifier code iommu/arm-smmu-v3: Build the whole CD in arm_smmu_make_s1_cd() iommu/arm-smmu-v3: Make smmu_domain->devices into an allocated list iommu/arm-smmu-v3: Make changing domains be hitless for ATS iommu/arm-smmu-v3: Add ssid to struct arm_smmu_master_domain iommu/arm-smmu-v3: Keep track of valid CD entries in the cd_table iommu/arm-smmu-v3: Thread SSID through the arm_smmu_attach_*() interface iommu/arm-smmu-v3: Make SVA allocate a normal arm_smmu_domain iommu/arm-smmu-v3: Keep track of arm_smmu_master_domain for SVA iommu: Add ops->domain_alloc_sva() iommu/arm-smmu-v3: Put the SVA mmu notifier in the smmu_domain iommu/arm-smmu-v3: Consolidate freeing the ASID/VMID iommu/arm-smmu-v3: Move the arm_smmu_asid_xa to per-smmu like vmid iommu/arm-smmu-v3: Bring back SVA BTM support iommu/arm-smmu-v3: Allow IDENTITY/BLOCKED to be set while PASID is used iommu/arm-smmu-v3: Allow a PASID to be set when RID is IDENTITY/BLOCKED iommu/arm-smmu-v3: Allow setting a S1 domain to a PASID .../iommu/arm/arm-smmu-v3/arm-smmu-v3-sva.c | 647 ++++++------- drivers/iommu/arm/arm-smmu-v3/arm-smmu-v3.c | 864 +++++++++++------- drivers/iommu/arm/arm-smmu-v3/arm-smmu-v3.h | 79 +- drivers/iommu/iommu-sva.c | 4 +- drivers/iommu/iommu.c | 12 +- include/linux/iommu.h | 3 + 6 files changed, 918 insertions(+), 691 deletions(-) base-commit: 00fd06da33094bc0176fdb22832b49250847b3fe -- 2.43.0
WARNING: multiple messages have this Message-ID (diff)
From: Jason Gunthorpe <jgg@nvidia.com> To: iommu@lists.linux.dev, Joerg Roedel <joro@8bytes.org>, linux-arm-kernel@lists.infradead.org, Robin Murphy <robin.murphy@arm.com>, Will Deacon <will@kernel.org> Cc: Eric Auger <eric.auger@redhat.com>, Jean-Philippe Brucker <jean-philippe@linaro.org>, Moritz Fischer <mdf@kernel.org>, Michael Shavit <mshavit@google.com>, Nicolin Chen <nicolinc@nvidia.com>, patches@lists.linux.dev, Shameerali Kolothum Thodi <shameerali.kolothum.thodi@huawei.com> Subject: [PATCH v4 00/27] Update SMMUv3 to the modern iommu API (part 2/3) Date: Fri, 26 Jan 2024 14:15:02 -0400 [thread overview] Message-ID: <0-v4-e7091cdd9e8d+43b1-smmuv3_newapi_p2_jgg@nvidia.com> (raw) Continuing the work of part 1 this focuses on the CD, PASID and SVA components: - attach_dev failure does not change the HW configuration. - Full PASID API support including: - S1/SVA domains attached to PASIDs - IDENTITY/BLOCKED/S1 attached to RID - Change of the RID domain while PASIDs are attached - Streamlined SVA support using the core infrastructure - Hitless, whenever possible, change between two domains Making the CD programming work like the new STE programming allows untangling some of the confusing SVA flows. From there the focus is on building out the core infrastructure for dealing with PASID and CD entries, then keeping track of unique SSID's for ATS invalidation. The ATS ordering is generalized so that the PASID flow can use it and put into a form where it is fully hitless, whenever possible. Care is taken to ensure that ATC flushes are present after any change in translation. Finally we simply kill the entire outdated SVA mmu_notifier implementation in one shot and switch it over to the newly created generic PASID & CD code. This avoids the messy and confusing approach of trying to incrementally untangle this in place. The new code is small and simple enough this is much better than trying to figure out smaller steps. Once SVA is resting on the right CD code it is straightforward to make the PASID interface functionally complete. This depends on part 1 It achieves the same goals as the several series from Michael and the S1DSS series from Nicolin that were trying to improve portions of the API. This is on github: https://github.com/jgunthorpe/linux/commits/smmuv3_newapi v4: - Rebase on v6.8-rc1, adjust to use mm_get_enqcmd_pasid() and eventually remove all references from ARM. Move the new ARM_SMMU_FEAT_STALL_FORCE stuff to arm_smmu_make_sva_cd() - Adjust to use the new shared STE/CD writer logic. Disable some of the sanity checks for the interior of the series - Return ERR_PTR from domain_alloc functions - Move the ATS disablement flow into arm_smmu_attach_prepare()/commit() which lets all the STE update flows use the same sequence. This is needed for nesting in part 3 - Put ssid in attach_state - Replace to_smmu_domain_safe() with to_smmu_domain_devices() v3: https://lore.kernel.org/r/0-v3-9083a9368a5c+23fb-smmuv3_newapi_p2_jgg@nvidia.com - Rebase on the latest part 1 - update comments and commit messages - Fix error exit in arm_smmu_set_pasid() - Fix inverted logic for btm_invalidation - Add missing ATC invalidation on mm release - Add a big comment explaining that BTM is not enabled and what is missing to enable it. v2: https://lore.kernel.org/r/0-v2-16665a652079+5947-smmuv3_newapi_p2_jgg@nvidia.com - Rebased on iommmufd + Joerg's tree - Use sid_smmu_domain consistently to refer to the domain attached to the device (eg the PCIe RID) - Rework how arm_smmu_attach_*() and callers flow to be more careful about ordering around ATC invalidation. The ATC must be invalidated after it is impossible to establish stale entires. - ATS disable is now entirely part of arm_smmu_attach_dev_ste(), which is the only STE type that ever disables ATS. - Remove the 'existing_master_domain' optimization, the code is functionally fine without it. - Whitespace, spelling, and checkpatch related items - Fixed wrong value stored in the xa for the BTM flows - Use pasid more consistently instead of id v1: https://lore.kernel.org/r/0-v1-afbb86647bbd+5-smmuv3_newapi_p2_jgg@nvidia.com Jason Gunthorpe (27): iommu/arm-smmu-v3: Check that the RID domain is S1 in SVA iommu/arm-smmu-v3: Do not allow a SVA domain to be set on the wrong PASID iommu/arm-smmu-v3: Do not ATC invalidate the entire domain iommu/arm-smmu-v3: Add a type for the CD entry iommu/arm-smmu-v3: Make CD programming use arm_smmu_write_entry() iommu/arm-smmu-v3: Consolidate clearing a CD table entry iommu/arm-smmu-v3: Move the CD generation for S1 domains into a function iommu/arm-smmu-v3: Move allocation of the cdtable into arm_smmu_get_cd_ptr() iommu/arm-smmu-v3: Allocate the CD table entry in advance iommu/arm-smmu-v3: Move the CD generation for SVA into a function iommu/arm-smmu-v3: Lift CD programming out of the SVA notifier code iommu/arm-smmu-v3: Build the whole CD in arm_smmu_make_s1_cd() iommu/arm-smmu-v3: Make smmu_domain->devices into an allocated list iommu/arm-smmu-v3: Make changing domains be hitless for ATS iommu/arm-smmu-v3: Add ssid to struct arm_smmu_master_domain iommu/arm-smmu-v3: Keep track of valid CD entries in the cd_table iommu/arm-smmu-v3: Thread SSID through the arm_smmu_attach_*() interface iommu/arm-smmu-v3: Make SVA allocate a normal arm_smmu_domain iommu/arm-smmu-v3: Keep track of arm_smmu_master_domain for SVA iommu: Add ops->domain_alloc_sva() iommu/arm-smmu-v3: Put the SVA mmu notifier in the smmu_domain iommu/arm-smmu-v3: Consolidate freeing the ASID/VMID iommu/arm-smmu-v3: Move the arm_smmu_asid_xa to per-smmu like vmid iommu/arm-smmu-v3: Bring back SVA BTM support iommu/arm-smmu-v3: Allow IDENTITY/BLOCKED to be set while PASID is used iommu/arm-smmu-v3: Allow a PASID to be set when RID is IDENTITY/BLOCKED iommu/arm-smmu-v3: Allow setting a S1 domain to a PASID .../iommu/arm/arm-smmu-v3/arm-smmu-v3-sva.c | 647 ++++++------- drivers/iommu/arm/arm-smmu-v3/arm-smmu-v3.c | 864 +++++++++++------- drivers/iommu/arm/arm-smmu-v3/arm-smmu-v3.h | 79 +- drivers/iommu/iommu-sva.c | 4 +- drivers/iommu/iommu.c | 12 +- include/linux/iommu.h | 3 + 6 files changed, 918 insertions(+), 691 deletions(-) base-commit: 00fd06da33094bc0176fdb22832b49250847b3fe -- 2.43.0 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next reply other threads:[~2024-01-26 18:15 UTC|newest] Thread overview: 74+ messages / expand[flat|nested] mbox.gz Atom feed top 2024-01-26 18:15 Jason Gunthorpe [this message] 2024-01-26 18:15 ` [PATCH v4 00/27] Update SMMUv3 to the modern iommu API (part 2/3) Jason Gunthorpe 2024-01-26 18:15 ` [PATCH v4 01/27] iommu/arm-smmu-v3: Check that the RID domain is S1 in SVA Jason Gunthorpe 2024-01-26 18:15 ` Jason Gunthorpe 2024-01-30 8:46 ` Shameerali Kolothum Thodi 2024-01-30 8:46 ` Shameerali Kolothum Thodi 2024-01-30 16:04 ` Jason Gunthorpe 2024-01-30 16:04 ` Jason Gunthorpe 2024-01-30 17:11 ` Shameerali Kolothum Thodi 2024-01-30 17:11 ` Shameerali Kolothum Thodi 2024-01-30 19:03 ` Jason Gunthorpe 2024-01-30 19:03 ` Jason Gunthorpe 2024-01-26 18:15 ` [PATCH v4 02/27] iommu/arm-smmu-v3: Do not allow a SVA domain to be set on the wrong PASID Jason Gunthorpe 2024-01-26 18:15 ` Jason Gunthorpe 2024-01-26 18:15 ` [PATCH v4 03/27] iommu/arm-smmu-v3: Do not ATC invalidate the entire domain Jason Gunthorpe 2024-01-26 18:15 ` Jason Gunthorpe 2024-01-26 18:15 ` [PATCH v4 04/27] iommu/arm-smmu-v3: Add a type for the CD entry Jason Gunthorpe 2024-01-26 18:15 ` Jason Gunthorpe 2024-01-26 18:15 ` [PATCH v4 05/27] iommu/arm-smmu-v3: Make CD programming use arm_smmu_write_entry() Jason Gunthorpe 2024-01-26 18:15 ` Jason Gunthorpe 2024-01-26 18:15 ` [PATCH v4 06/27] iommu/arm-smmu-v3: Consolidate clearing a CD table entry Jason Gunthorpe 2024-01-26 18:15 ` Jason Gunthorpe 2024-01-26 18:15 ` [PATCH v4 07/27] iommu/arm-smmu-v3: Move the CD generation for S1 domains into a function Jason Gunthorpe 2024-01-26 18:15 ` Jason Gunthorpe 2024-01-26 18:15 ` [PATCH v4 08/27] iommu/arm-smmu-v3: Move allocation of the cdtable into arm_smmu_get_cd_ptr() Jason Gunthorpe 2024-01-26 18:15 ` Jason Gunthorpe 2024-01-26 18:15 ` [PATCH v4 09/27] iommu/arm-smmu-v3: Allocate the CD table entry in advance Jason Gunthorpe 2024-01-26 18:15 ` Jason Gunthorpe 2024-01-26 18:15 ` [PATCH v4 10/27] iommu/arm-smmu-v3: Move the CD generation for SVA into a function Jason Gunthorpe 2024-01-26 18:15 ` Jason Gunthorpe 2024-01-26 18:15 ` [PATCH v4 11/27] iommu/arm-smmu-v3: Lift CD programming out of the SVA notifier code Jason Gunthorpe 2024-01-26 18:15 ` Jason Gunthorpe 2024-01-26 18:15 ` [PATCH v4 12/27] iommu/arm-smmu-v3: Build the whole CD in arm_smmu_make_s1_cd() Jason Gunthorpe 2024-01-26 18:15 ` Jason Gunthorpe 2024-01-26 18:15 ` [PATCH v4 13/27] iommu/arm-smmu-v3: Make smmu_domain->devices into an allocated list Jason Gunthorpe 2024-01-26 18:15 ` Jason Gunthorpe 2024-01-26 18:15 ` [PATCH v4 14/27] iommu/arm-smmu-v3: Make changing domains be hitless for ATS Jason Gunthorpe 2024-01-26 18:15 ` Jason Gunthorpe 2024-01-31 11:20 ` Shameerali Kolothum Thodi 2024-01-31 11:20 ` Shameerali Kolothum Thodi 2024-01-31 14:12 ` Jason Gunthorpe 2024-01-31 14:12 ` Jason Gunthorpe 2024-01-31 14:29 ` Shameerali Kolothum Thodi 2024-01-31 14:29 ` Shameerali Kolothum Thodi 2024-01-26 18:15 ` [PATCH v4 15/27] iommu/arm-smmu-v3: Add ssid to struct arm_smmu_master_domain Jason Gunthorpe 2024-01-26 18:15 ` Jason Gunthorpe 2024-01-26 18:15 ` [PATCH v4 16/27] iommu/arm-smmu-v3: Keep track of valid CD entries in the cd_table Jason Gunthorpe 2024-01-26 18:15 ` Jason Gunthorpe 2024-01-26 18:15 ` [PATCH v4 17/27] iommu/arm-smmu-v3: Thread SSID through the arm_smmu_attach_*() interface Jason Gunthorpe 2024-01-26 18:15 ` Jason Gunthorpe 2024-01-26 18:15 ` [PATCH v4 18/27] iommu/arm-smmu-v3: Make SVA allocate a normal arm_smmu_domain Jason Gunthorpe 2024-01-26 18:15 ` Jason Gunthorpe 2024-01-26 18:15 ` [PATCH v4 19/27] iommu/arm-smmu-v3: Keep track of arm_smmu_master_domain for SVA Jason Gunthorpe 2024-01-26 18:15 ` Jason Gunthorpe 2024-01-26 18:15 ` [PATCH v4 20/27] iommu: Add ops->domain_alloc_sva() Jason Gunthorpe 2024-01-26 18:15 ` Jason Gunthorpe 2024-02-19 22:47 ` Daniel Mentz 2024-02-19 22:47 ` Daniel Mentz 2024-02-20 14:09 ` Jason Gunthorpe 2024-02-20 14:09 ` Jason Gunthorpe 2024-01-26 18:15 ` [PATCH v4 21/27] iommu/arm-smmu-v3: Put the SVA mmu notifier in the smmu_domain Jason Gunthorpe 2024-01-26 18:15 ` Jason Gunthorpe 2024-01-26 18:15 ` [PATCH v4 22/27] iommu/arm-smmu-v3: Consolidate freeing the ASID/VMID Jason Gunthorpe 2024-01-26 18:15 ` Jason Gunthorpe 2024-01-26 18:15 ` [PATCH v4 23/27] iommu/arm-smmu-v3: Move the arm_smmu_asid_xa to per-smmu like vmid Jason Gunthorpe 2024-01-26 18:15 ` Jason Gunthorpe 2024-01-26 18:15 ` [PATCH v4 24/27] iommu/arm-smmu-v3: Bring back SVA BTM support Jason Gunthorpe 2024-01-26 18:15 ` Jason Gunthorpe 2024-01-26 18:15 ` [PATCH v4 25/27] iommu/arm-smmu-v3: Allow IDENTITY/BLOCKED to be set while PASID is used Jason Gunthorpe 2024-01-26 18:15 ` Jason Gunthorpe 2024-01-26 18:15 ` [PATCH v4 26/27] iommu/arm-smmu-v3: Allow a PASID to be set when RID is IDENTITY/BLOCKED Jason Gunthorpe 2024-01-26 18:15 ` Jason Gunthorpe 2024-01-26 18:15 ` [PATCH v4 27/27] iommu/arm-smmu-v3: Allow setting a S1 domain to a PASID Jason Gunthorpe 2024-01-26 18:15 ` Jason Gunthorpe
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=0-v4-e7091cdd9e8d+43b1-smmuv3_newapi_p2_jgg@nvidia.com \ --to=jgg@nvidia.com \ --cc=eric.auger@redhat.com \ --cc=iommu@lists.linux.dev \ --cc=jean-philippe@linaro.org \ --cc=joro@8bytes.org \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=mdf@kernel.org \ --cc=mshavit@google.com \ --cc=nicolinc@nvidia.com \ --cc=patches@lists.linux.dev \ --cc=robin.murphy@arm.com \ --cc=shameerali.kolothum.thodi@huawei.com \ --cc=will@kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.