From: Chao Yu <chao2.yu@samsung.com> To: "'Jaegeuk Kim'" <jaegeuk@kernel.org> Cc: linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net Subject: RE: [f2fs-dev] [PATCH 1/3] f2fs: check the page status filled from disk Date: Tue, 05 Jan 2016 17:31:51 +0800 [thread overview] Message-ID: <00a101d1479c$02ae9080$080bb180$@samsung.com> (raw) In-Reply-To: <1451784366-14261-1-git-send-email-jaegeuk@kernel.org> Hi Jaegeuk, > -----Original Message----- > From: Jaegeuk Kim [mailto:jaegeuk@kernel.org] > Sent: Sunday, January 03, 2016 9:26 AM > To: linux-kernel@vger.kernel.org; linux-fsdevel@vger.kernel.org; > linux-f2fs-devel@lists.sourceforge.net > Cc: Jaegeuk Kim > Subject: [f2fs-dev] [PATCH 1/3] f2fs: check the page status filled from disk > > After reading a page, we need to check whether there is any error. > > Signed-off-by: Jaegeuk Kim <jaegeuk@kernel.org> > --- > fs/f2fs/data.c | 8 ++++++++ > 1 file changed, 8 insertions(+) > > diff --git a/fs/f2fs/data.c b/fs/f2fs/data.c > index 89a978c..11b2111 100644 > --- a/fs/f2fs/data.c > +++ b/fs/f2fs/data.c > @@ -448,6 +448,14 @@ repeat: > > /* wait for read completion */ > lock_page(page); > + if (unlikely(!PageUptodate(page))) { > + f2fs_put_page(page, 1); > + return ERR_PTR(-EIO); There is a convention in get_new_data_page, anyway we should release ipage if there is any error occurs, but I think it will be ok to return directly since it seems impossible the new dentry page has its real block address. To avoid any bug here or wrong usage, how about add bug_on as following patch? >From d92f0f34493b27ef28da67c446d552ce721b5d6f Mon Sep 17 00:00:00 2001 From: Chao Yu <chao2.yu@samsung.com> Date: Tue, 5 Jan 2016 15:28:56 +0800 Subject: [PATCH] f2fs: add f2fs_bug_on in get_new_data_page In get_new_data_page, locked inode page should not be hold before get_read_data_page, this patch adds f2fs_bug_on to detect this condition. Signed-off-by: Chao Yu <chao2.yu@samsung.com> --- fs/f2fs/data.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/fs/f2fs/data.c b/fs/f2fs/data.c index 48f0bd3..2c5e3f6 100644 --- a/fs/f2fs/data.c +++ b/fs/f2fs/data.c @@ -440,6 +440,8 @@ repeat: zero_user_segment(page, 0, PAGE_CACHE_SIZE); SetPageUptodate(page); } else { + f2fs_bug_on(F2FS_I_SB(inode), ipage); + f2fs_put_page(page, 1); page = get_read_data_page(inode, index, READ_SYNC, true); -- 2.6.3 > + } > + if (unlikely(page->mapping != mapping)) { > + f2fs_put_page(page, 1); > + goto repeat; > + } How about use get_lock_data_page to avoid duplicated code? > } > got_it: > if (new_i_size && i_size_read(inode) < > -- > 2.6.3 > > > ------------------------------------------------------------------------------ > _______________________________________________ > Linux-f2fs-devel mailing list > Linux-f2fs-devel@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel
WARNING: multiple messages have this Message-ID (diff)
From: Chao Yu <chao2.yu@samsung.com> To: 'Jaegeuk Kim' <jaegeuk@kernel.org> Cc: linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net Subject: Re: [PATCH 1/3] f2fs: check the page status filled from disk Date: Tue, 05 Jan 2016 17:31:51 +0800 [thread overview] Message-ID: <00a101d1479c$02ae9080$080bb180$@samsung.com> (raw) In-Reply-To: <1451784366-14261-1-git-send-email-jaegeuk@kernel.org> Hi Jaegeuk, > -----Original Message----- > From: Jaegeuk Kim [mailto:jaegeuk@kernel.org] > Sent: Sunday, January 03, 2016 9:26 AM > To: linux-kernel@vger.kernel.org; linux-fsdevel@vger.kernel.org; > linux-f2fs-devel@lists.sourceforge.net > Cc: Jaegeuk Kim > Subject: [f2fs-dev] [PATCH 1/3] f2fs: check the page status filled from disk > > After reading a page, we need to check whether there is any error. > > Signed-off-by: Jaegeuk Kim <jaegeuk@kernel.org> > --- > fs/f2fs/data.c | 8 ++++++++ > 1 file changed, 8 insertions(+) > > diff --git a/fs/f2fs/data.c b/fs/f2fs/data.c > index 89a978c..11b2111 100644 > --- a/fs/f2fs/data.c > +++ b/fs/f2fs/data.c > @@ -448,6 +448,14 @@ repeat: > > /* wait for read completion */ > lock_page(page); > + if (unlikely(!PageUptodate(page))) { > + f2fs_put_page(page, 1); > + return ERR_PTR(-EIO); There is a convention in get_new_data_page, anyway we should release ipage if there is any error occurs, but I think it will be ok to return directly since it seems impossible the new dentry page has its real block address. To avoid any bug here or wrong usage, how about add bug_on as following patch? >From d92f0f34493b27ef28da67c446d552ce721b5d6f Mon Sep 17 00:00:00 2001 From: Chao Yu <chao2.yu@samsung.com> Date: Tue, 5 Jan 2016 15:28:56 +0800 Subject: [PATCH] f2fs: add f2fs_bug_on in get_new_data_page In get_new_data_page, locked inode page should not be hold before get_read_data_page, this patch adds f2fs_bug_on to detect this condition. Signed-off-by: Chao Yu <chao2.yu@samsung.com> --- fs/f2fs/data.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/fs/f2fs/data.c b/fs/f2fs/data.c index 48f0bd3..2c5e3f6 100644 --- a/fs/f2fs/data.c +++ b/fs/f2fs/data.c @@ -440,6 +440,8 @@ repeat: zero_user_segment(page, 0, PAGE_CACHE_SIZE); SetPageUptodate(page); } else { + f2fs_bug_on(F2FS_I_SB(inode), ipage); + f2fs_put_page(page, 1); page = get_read_data_page(inode, index, READ_SYNC, true); -- 2.6.3 > + } > + if (unlikely(page->mapping != mapping)) { > + f2fs_put_page(page, 1); > + goto repeat; > + } How about use get_lock_data_page to avoid duplicated code? > } > got_it: > if (new_i_size && i_size_read(inode) < > -- > 2.6.3 > > > ------------------------------------------------------------------------------ > _______________________________________________ > Linux-f2fs-devel mailing list > Linux-f2fs-devel@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel ------------------------------------------------------------------------------
next prev parent reply other threads:[~2016-01-05 9:32 UTC|newest] Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top 2016-01-03 1:26 [PATCH 1/3] f2fs: check the page status filled from disk Jaegeuk Kim 2016-01-03 1:26 ` [PATCH 2/3] f2fs: cover more area with nat_tree_lock Jaegeuk Kim 2016-01-03 1:26 ` Jaegeuk Kim 2016-01-05 9:33 ` [f2fs-dev] " Chao Yu 2016-01-05 17:57 ` Jaegeuk Kim 2016-01-05 17:57 ` Jaegeuk Kim 2016-01-06 3:57 ` [f2fs-dev] " Chao Yu 2016-01-06 3:57 ` Chao Yu 2016-01-03 1:26 ` [PATCH 3/3] Revert "f2fs: check the node block address of newly allocated nid" Jaegeuk Kim 2016-01-03 1:26 ` Jaegeuk Kim 2016-01-05 9:31 ` Chao Yu [this message] 2016-01-05 9:31 ` [PATCH 1/3] f2fs: check the page status filled from disk Chao Yu 2016-01-05 17:48 ` [f2fs-dev] " Jaegeuk Kim 2016-01-06 1:21 ` Chao Yu 2016-01-06 2:30 ` Jaegeuk Kim 2016-01-06 2:30 ` Jaegeuk Kim 2016-01-06 4:10 ` [PATCH 1/3 v2] " Jaegeuk Kim 2016-01-06 5:20 ` [f2fs-dev] " Chao Yu 2016-01-06 3:14 [f2fs-dev] [PATCH 1/3] " Chao Yu 2016-01-06 4:02 ` Jaegeuk Kim
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to='00a101d1479c$02ae9080$080bb180$@samsung.com' \ --to=chao2.yu@samsung.com \ --cc=jaegeuk@kernel.org \ --cc=linux-f2fs-devel@lists.sourceforge.net \ --cc=linux-fsdevel@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.