All of lore.kernel.org
 help / color / mirror / Atom feed
From: Alistair Francis <alistair.francis@xilinx.com>
To: qemu-devel@nongnu.org, peter.maydell@linaro.org
Cc: alistair.francis@xilinx.com, alistair23@gmail.com
Subject: [Qemu-devel] [PATCH v1 4/5] cadence_gem: Make the revision a property
Date: Tue, 4 Apr 2017 16:40:11 -0700	[thread overview]
Message-ID: <07368f466735c951eaf53605582085cc7c5feb9b.1491349058.git.alistair.francis@xilinx.com> (raw)
In-Reply-To: <cover.1491349058.git.alistair.francis@xilinx.com>

Expose the Cadence GEM revision as a property.

Signed-off-by: Alistair Francis <alistair.francis@xilinx.com>
---

 hw/net/cadence_gem.c         | 6 +++++-
 include/hw/net/cadence_gem.h | 1 +
 2 files changed, 6 insertions(+), 1 deletion(-)

diff --git a/hw/net/cadence_gem.c b/hw/net/cadence_gem.c
index b9eaed4..7047e02 100644
--- a/hw/net/cadence_gem.c
+++ b/hw/net/cadence_gem.c
@@ -300,6 +300,8 @@
 #define DESC_1_RX_SOF 0x00004000
 #define DESC_1_RX_EOF 0x00008000
 
+#define GEM_MODID_VALUE 0x00020118
+
 static inline unsigned tx_desc_get_buffer(unsigned *desc)
 {
     return desc[0];
@@ -1213,7 +1215,7 @@ static void gem_reset(DeviceState *d)
     s->regs[GEM_TXPAUSE] = 0x0000ffff;
     s->regs[GEM_TXPARTIALSF] = 0x000003ff;
     s->regs[GEM_RXPARTIALSF] = 0x000003ff;
-    s->regs[GEM_MODID] = 0x00020118;
+    s->regs[GEM_MODID] = s->revision;
     s->regs[GEM_DESCONF] = 0x02500111;
     s->regs[GEM_DESCONF2] = 0x2ab13fff;
     s->regs[GEM_DESCONF5] = 0x002f2145;
@@ -1512,6 +1514,8 @@ static const VMStateDescription vmstate_cadence_gem = {
 
 static Property gem_properties[] = {
     DEFINE_NIC_PROPERTIES(CadenceGEMState, conf),
+    DEFINE_PROP_UINT32("revision", CadenceGEMState, revision,
+                       GEM_MODID_VALUE),
     DEFINE_PROP_UINT8("num-priority-queues", CadenceGEMState,
                       num_priority_queues, 1),
     DEFINE_PROP_UINT8("num-type1-screeners", CadenceGEMState,
diff --git a/include/hw/net/cadence_gem.h b/include/hw/net/cadence_gem.h
index c469ffe..35de622 100644
--- a/include/hw/net/cadence_gem.h
+++ b/include/hw/net/cadence_gem.h
@@ -50,6 +50,7 @@ typedef struct CadenceGEMState {
     uint8_t num_priority_queues;
     uint8_t num_type1_screeners;
     uint8_t num_type2_screeners;
+    uint32_t revision;
 
     /* GEM registers backing store */
     uint32_t regs[CADENCE_GEM_MAXREG];
-- 
2.9.3

  parent reply	other threads:[~2017-04-04 23:42 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-04-04 23:40 [Qemu-devel] [PATCH v1 0/5] Improve the Cadence GEM multi-queue support Alistair Francis
2017-04-04 23:40 ` [Qemu-devel] [PATCH v1 1/5] cadence_gem: Read the correct queue descriptor Alistair Francis
2017-04-05 10:54   ` Philippe Mathieu-Daudé
2017-04-10 12:39   ` Peter Maydell
2017-04-04 23:40 ` [Qemu-devel] [PATCH v1 2/5] cadence_gem: Correct the multi-queue can rx logic Alistair Francis
2017-04-10 12:37   ` Peter Maydell
2017-04-10 20:25     ` Alistair Francis
2017-04-04 23:40 ` [Qemu-devel] [PATCH v1 3/5] cadence_gem: Only trigger interrupts if the status register is set Alistair Francis
2017-04-05 11:00   ` Philippe Mathieu-Daudé
2017-04-10 12:44   ` Peter Maydell
2017-04-10 22:23     ` Alistair Francis
2017-04-11  9:05       ` Peter Maydell
2017-04-11 16:00         ` Alistair Francis
2017-04-04 23:40 ` Alistair Francis [this message]
2017-04-05 10:57   ` [Qemu-devel] [PATCH v1 4/5] cadence_gem: Make the revision a property Philippe Mathieu-Daudé
2017-04-10 12:45   ` Peter Maydell
2017-04-04 23:40 ` [Qemu-devel] [PATCH v1 5/5] xlnx-zynqmp: Set the Cadence GEM revision Alistair Francis
2017-04-10 12:38   ` Peter Maydell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=07368f466735c951eaf53605582085cc7c5feb9b.1491349058.git.alistair.francis@xilinx.com \
    --to=alistair.francis@xilinx.com \
    --cc=alistair23@gmail.com \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.