From: Avi Kivity <avi@redhat.com>
To: kvm@vger.kernel.org
Cc: Marcelo Tosatti <mtosatti@redhat.com>,
Joerg Roedel <joerg.roedel@amd.com>,
Sheng Yang <sheng@linux.intel.com>
Subject: [PATCH 1/3] KVM: VMX: Avoid duplicate ept tlb flush when setting cr3
Date: Mon, 1 Jun 2009 16:22:01 +0300 [thread overview]
Message-ID: <1243862524-22120-2-git-send-email-avi@redhat.com> (raw)
In-Reply-To: <1243862524-22120-1-git-send-email-avi@redhat.com>
vmx_set_cr3() will call vmx_tlb_flush(), which will flush the ept context.
So there is no need to call ept_sync_context() explicitly.
Signed-off-by: Avi Kivity <avi@redhat.com>
---
arch/x86/kvm/vmx.c | 1 -
1 files changed, 0 insertions(+), 1 deletions(-)
diff --git a/arch/x86/kvm/vmx.c b/arch/x86/kvm/vmx.c
index 25f1239..5607de8 100644
--- a/arch/x86/kvm/vmx.c
+++ b/arch/x86/kvm/vmx.c
@@ -1642,7 +1642,6 @@ static void vmx_set_cr3(struct kvm_vcpu *vcpu, unsigned long cr3)
if (enable_ept) {
eptp = construct_eptp(cr3);
vmcs_write64(EPT_POINTER, eptp);
- ept_sync_context(eptp);
ept_load_pdptrs(vcpu);
guest_cr3 = is_paging(vcpu) ? vcpu->arch.cr3 :
VMX_EPT_IDENTITY_PAGETABLE_ADDR;
--
1.6.0.6
next prev parent reply other threads:[~2009-06-01 13:22 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-06-01 13:22 [PATCH 0/3] Cache PDPTRs under ept/npt Avi Kivity
2009-06-01 13:22 ` Avi Kivity [this message]
2009-06-01 13:22 ` [PATCH 2/3] KVM: VMX: Simplify pdptr and cr3 management Avi Kivity
2009-06-02 9:22 ` Sheng Yang
2009-06-02 9:26 ` Avi Kivity
2009-06-02 9:30 ` Sheng Yang
2009-06-02 9:46 ` Avi Kivity
2009-06-02 9:56 ` Sheng Yang
2009-06-02 10:16 ` Avi Kivity
2009-06-02 11:31 ` Sheng Yang
2009-06-02 11:44 ` Avi Kivity
2009-06-01 13:22 ` [PATCH 3/3] KVM: Cache pdptrs Avi Kivity
2009-06-02 9:04 ` Joerg Roedel
2009-06-02 9:09 ` Avi Kivity
2009-06-02 9:30 ` Joerg Roedel
2009-06-02 9:44 ` Avi Kivity
2009-06-02 11:50 ` Avi Kivity
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1243862524-22120-2-git-send-email-avi@redhat.com \
--to=avi@redhat.com \
--cc=joerg.roedel@amd.com \
--cc=kvm@vger.kernel.org \
--cc=mtosatti@redhat.com \
--cc=sheng@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.