All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ian Campbell <ian.campbell@citrix.com>
To: linux-kernel@vger.kernel.org
Cc: Ian Campbell <ian.campbell@citrix.com>,
	Thomas Gleixner <tglx@linutronix.de>,
	Dmitry Torokhov <dmitry.torokhov@gmail.com>,
	linux-input@vger.kernel.org
Subject: [PATCH 2/4] ixp4xx-beeper: Use IRQF_NO_SUSPEND not IRQF_TIMER for non-timer interrupt
Date: Thu, 29 Jul 2010 11:16:33 +0100	[thread overview]
Message-ID: <1280398595-29708-2-git-send-email-ian.campbell@citrix.com> (raw)
In-Reply-To: <1280398573.24292.1684.camel@zakaz.uk.xensource.com>

ixp4xx_spkr_interrupt is not a timer interrupt and therefore should
not use IRQF_TIMER. Use the recently introduced IRQF_NO_SUSPEND
instead since that is the actual desired behaviour.

Signed-off-by: Ian Campbell <ian.campbell@citrix.com>
Cc: Thomas Gleixner <tglx@linutronix.de>
Cc: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Cc: linux-input@vger.kernel.org
---
 drivers/input/misc/ixp4xx-beeper.c |    3 ++-
 1 files changed, 2 insertions(+), 1 deletions(-)

diff --git a/drivers/input/misc/ixp4xx-beeper.c b/drivers/input/misc/ixp4xx-beeper.c
index 9946d73..9dfd6e5 100644
--- a/drivers/input/misc/ixp4xx-beeper.c
+++ b/drivers/input/misc/ixp4xx-beeper.c
@@ -115,7 +115,8 @@ static int __devinit ixp4xx_spkr_probe(struct platform_device *dev)
 	input_dev->event = ixp4xx_spkr_event;
 
 	err = request_irq(IRQ_IXP4XX_TIMER2, &ixp4xx_spkr_interrupt,
-			  IRQF_DISABLED | IRQF_TIMER, "ixp4xx-beeper", (void *) dev->id);
+			  IRQF_DISABLED | IRQF_NO_SUSPEND, "ixp4xx-beeper",
+			  (void *) dev->id);
 	if (err)
 		goto err_free_device;
 
-- 
1.5.6.5


  parent reply	other threads:[~2010-07-29 10:16 UTC|newest]

Thread overview: 33+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-07-28 10:54 [GIT/PATCH 0/4] Do not use IRQF_TIMER for non timer interrupts Ian Campbell
2010-07-28 10:54 ` Ian Campbell
2010-07-28 10:54 ` Ian Campbell
2010-07-28 10:54 ` [PATCH 1/4] irq: rename IRQF_TIMER to IRQF_NO_SUSPEND Ian Campbell
2010-07-28 10:54   ` Ian Campbell
2010-07-29  8:49   ` Thomas Gleixner
2010-07-29  8:49     ` Thomas Gleixner
2010-07-29  9:03     ` Ian Campbell
2010-07-29  9:03       ` Ian Campbell
2010-07-29  9:03       ` Ian Campbell
2010-07-29 10:16     ` [GIT/PATCH 0/4] Do not use IRQF_TIMER for non timer interrupts Ian Campbell
2010-07-29 10:16       ` Ian Campbell
2010-07-29 10:16       ` Ian Campbell
2010-07-29 10:16       ` [PATCH 1/4] irq: Add new IRQ flag IRQF_NO_SUSPEND Ian Campbell
2010-07-29 10:16         ` Ian Campbell
2010-07-29 11:30         ` [tip:irq/core] " tip-bot for Ian Campbell
2010-07-30 10:29         ` [PATCH 1/4] " Benjamin Herrenschmidt
2010-07-30 10:29           ` Benjamin Herrenschmidt
2010-07-30 10:29           ` Benjamin Herrenschmidt
2010-07-29 10:16       ` Ian Campbell [this message]
2010-07-29 11:31         ` [tip:irq/core] ixp4xx-beeper: Use IRQF_NO_SUSPEND not IRQF_TIMER for non-timer interrupt tip-bot for Ian Campbell
2010-07-29 10:16       ` [PATCH 3/4] powerpc: Use IRQF_NO_SUSPEND not IRQF_TIMER for non-timer interrupts Ian Campbell
2010-07-29 10:16         ` Ian Campbell
2010-07-29 11:31         ` [tip:irq/core] " tip-bot for Ian Campbell
2010-07-30 10:30         ` [PATCH 3/4] " Benjamin Herrenschmidt
2010-07-30 10:30           ` Benjamin Herrenschmidt
2010-07-30 10:30           ` Benjamin Herrenschmidt
2010-07-29 10:16       ` [PATCH 4/4] xen: do not suspend IPI IRQs Ian Campbell
2010-07-29 11:31         ` [tip:irq/core] xen: Do " tip-bot for Ian Campbell
2010-07-28 10:54 ` [PATCH 2/4] ixp4xx-beeper: Use IRQF_NO_SUSPEND not IRQF_TIMER for non-timer interrupt Ian Campbell
2010-07-28 10:54 ` [PATCH 3/4] powerpc: Use IRQF_NO_SUSPEND not IRQF_TIMER for non-timer interrupts Ian Campbell
2010-07-28 10:54   ` Ian Campbell
2010-07-28 10:54 ` [PATCH 4/4] xen: do not suspend IPI IRQs Ian Campbell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1280398595-29708-2-git-send-email-ian.campbell@citrix.com \
    --to=ian.campbell@citrix.com \
    --cc=dmitry.torokhov@gmail.com \
    --cc=linux-input@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.