From: Paolo Bonzini <pbonzini@redhat.com> To: qemu-devel@nongnu.org Cc: kvm@vger.kernel.org, mst@redhat.com, anthony@codemonkey.ws, kwolf@redhat.com, rusty@rustcorp.com.au Subject: [PATCH 2/2] virtio-blk: disable write cache if not negotiated Date: Tue, 3 Jul 2012 15:20:42 +0200 [thread overview] Message-ID: <1341321642-24598-3-git-send-email-pbonzini@redhat.com> (raw) In-Reply-To: <1341321642-24598-1-git-send-email-pbonzini@redhat.com> If the guest does not support flushes, we should run in writethrough mode. The setting is temporary until the next reset, so that for example the BIOS will run in writethrough mode while Linux will run with a writeback cache. VIRTIO_BLK_F_FLUSH has been introduced in Linux 2.6.32 (in 2009) and was backported to RHEL/CentOS 5.6 (in 2010). The Windows drivers have two bugs, which I reported on the Red Hat Bugzilla as bugs 837321 and 837324. With these patches they will suffer a performance hit but gain correctness. Signed-off-by: Paolo Bonzini <pbonzini@redhat.com> --- hw/virtio-blk.c | 14 ++++++++++++++ 1 file changed, 14 insertions(+) diff --git a/hw/virtio-blk.c b/hw/virtio-blk.c index 280f96d..500e026 100644 --- a/hw/virtio-blk.c +++ b/hw/virtio-blk.c @@ -543,6 +543,19 @@ static uint32_t virtio_blk_get_features(VirtIODevice *vdev, uint32_t features) return features; } +static void virtio_blk_set_status(VirtIODevice *vdev, uint8_t status) +{ + VirtIOBlock *s = to_virtio_blk(vdev); + uint32_t features; + + if (!(status & VIRTIO_CONFIG_S_DRIVER_OK)) { + return; + } + + features = vdev->guest_features; + bdrv_set_enable_write_cache(s->bs, !!(features & (1 << VIRTIO_BLK_F_WCE))); +} + static void virtio_blk_save(QEMUFile *f, void *opaque) { VirtIOBlock *s = opaque; @@ -628,6 +641,7 @@ VirtIODevice *virtio_blk_init(DeviceState *dev, VirtIOBlkConf *blk) s->vdev.get_config = virtio_blk_update_config; s->vdev.set_config = virtio_blk_set_config; s->vdev.get_features = virtio_blk_get_features; + s->vdev.set_status = virtio_blk_set_status; s->vdev.reset = virtio_blk_reset; s->bs = blk->conf.bs; s->conf = &blk->conf; -- 1.7.10.2
WARNING: multiple messages have this Message-ID (diff)
From: Paolo Bonzini <pbonzini@redhat.com> To: qemu-devel@nongnu.org Cc: kwolf@redhat.com, rusty@rustcorp.com.au, anthony@codemonkey.ws, kvm@vger.kernel.org, mst@redhat.com Subject: [Qemu-devel] [PATCH 2/2] virtio-blk: disable write cache if not negotiated Date: Tue, 3 Jul 2012 15:20:42 +0200 [thread overview] Message-ID: <1341321642-24598-3-git-send-email-pbonzini@redhat.com> (raw) In-Reply-To: <1341321642-24598-1-git-send-email-pbonzini@redhat.com> If the guest does not support flushes, we should run in writethrough mode. The setting is temporary until the next reset, so that for example the BIOS will run in writethrough mode while Linux will run with a writeback cache. VIRTIO_BLK_F_FLUSH has been introduced in Linux 2.6.32 (in 2009) and was backported to RHEL/CentOS 5.6 (in 2010). The Windows drivers have two bugs, which I reported on the Red Hat Bugzilla as bugs 837321 and 837324. With these patches they will suffer a performance hit but gain correctness. Signed-off-by: Paolo Bonzini <pbonzini@redhat.com> --- hw/virtio-blk.c | 14 ++++++++++++++ 1 file changed, 14 insertions(+) diff --git a/hw/virtio-blk.c b/hw/virtio-blk.c index 280f96d..500e026 100644 --- a/hw/virtio-blk.c +++ b/hw/virtio-blk.c @@ -543,6 +543,19 @@ static uint32_t virtio_blk_get_features(VirtIODevice *vdev, uint32_t features) return features; } +static void virtio_blk_set_status(VirtIODevice *vdev, uint8_t status) +{ + VirtIOBlock *s = to_virtio_blk(vdev); + uint32_t features; + + if (!(status & VIRTIO_CONFIG_S_DRIVER_OK)) { + return; + } + + features = vdev->guest_features; + bdrv_set_enable_write_cache(s->bs, !!(features & (1 << VIRTIO_BLK_F_WCE))); +} + static void virtio_blk_save(QEMUFile *f, void *opaque) { VirtIOBlock *s = opaque; @@ -628,6 +641,7 @@ VirtIODevice *virtio_blk_init(DeviceState *dev, VirtIOBlkConf *blk) s->vdev.get_config = virtio_blk_update_config; s->vdev.set_config = virtio_blk_set_config; s->vdev.get_features = virtio_blk_get_features; + s->vdev.set_status = virtio_blk_set_status; s->vdev.reset = virtio_blk_reset; s->bs = blk->conf.bs; s->conf = &blk->conf; -- 1.7.10.2
next prev parent reply other threads:[~2012-07-03 13:21 UTC|newest] Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top 2012-07-03 13:20 [QEMU PATCH 0/2] virtio-blk: writeback cache enable improvements Paolo Bonzini 2012-07-03 13:20 ` [Qemu-devel] " Paolo Bonzini 2012-07-03 13:20 ` [PATCH 1/2] virtio-blk: support VIRTIO_BLK_F_CONFIG_WCE Paolo Bonzini 2012-07-03 13:20 ` [Qemu-devel] " Paolo Bonzini 2012-07-03 13:46 ` Kevin Wolf 2012-07-03 13:46 ` [Qemu-devel] " Kevin Wolf 2012-07-03 13:54 ` Paolo Bonzini 2012-07-03 13:54 ` [Qemu-devel] " Paolo Bonzini 2012-07-03 13:20 ` Paolo Bonzini [this message] 2012-07-03 13:20 ` [Qemu-devel] [PATCH 2/2] virtio-blk: disable write cache if not negotiated Paolo Bonzini 2012-07-03 13:49 ` Kevin Wolf 2012-07-03 13:49 ` [Qemu-devel] " Kevin Wolf 2012-07-03 13:51 ` Paolo Bonzini 2012-07-03 13:51 ` [Qemu-devel] " Paolo Bonzini 2012-07-04 10:16 ` Kevin Wolf 2012-07-04 10:16 ` Kevin Wolf 2012-07-04 12:21 ` Paolo Bonzini 2012-07-04 12:21 ` Paolo Bonzini 2012-07-04 12:50 ` Kevin Wolf 2012-07-04 12:50 ` [Qemu-devel] " Kevin Wolf 2012-07-04 13:20 ` Paolo Bonzini 2012-07-04 13:20 ` Paolo Bonzini 2012-07-23 16:32 ` [QEMU PATCH 0/2] virtio-blk: writeback cache enable improvements Paolo Bonzini 2012-07-23 16:32 ` [Qemu-devel] " Paolo Bonzini 2012-08-01 15:52 ` Paolo Bonzini 2012-08-01 15:52 ` [Qemu-devel] " Paolo Bonzini 2012-08-01 16:25 ` Kevin Wolf 2012-08-01 16:25 ` [Qemu-devel] " Kevin Wolf
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=1341321642-24598-3-git-send-email-pbonzini@redhat.com \ --to=pbonzini@redhat.com \ --cc=anthony@codemonkey.ws \ --cc=kvm@vger.kernel.org \ --cc=kwolf@redhat.com \ --cc=mst@redhat.com \ --cc=qemu-devel@nongnu.org \ --cc=rusty@rustcorp.com.au \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.