From: Thomas Abraham <thomas.abraham@linaro.org> To: linux-kernel@vger.kernel.org Cc: linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linus.walleij@linaro.org, grant.likely@secretlab.ca, rob.herring@calxeda.com, kgene.kim@samsung.com, patches@linaro.org Subject: [PATCH v2 3/4] gpio: exynos4: skip gpiolib registration if pinctrl driver is used Date: Thu, 16 Aug 2012 01:27:35 +0530 [thread overview] Message-ID: <1345060656-32201-4-git-send-email-thomas.abraham@linaro.org> (raw) In-Reply-To: <1345060656-32201-1-git-send-email-thomas.abraham@linaro.org> Pinctrl driver, when enabled, registers all the gpio pins and hence the registration of gpio pins by this driver can be skipped. Acked-by: Grant Likely <grant.likely@secretlab.ca> Acked-by: Linus Walleij <linus.walleij@linaro.org> Signed-off-by: Thomas Abraham <thomas.abraham@linaro.org> --- drivers/gpio/gpio-samsung.c | 21 +++++++++++++++++++++ 1 files changed, 21 insertions(+), 0 deletions(-) diff --git a/drivers/gpio/gpio-samsung.c b/drivers/gpio/gpio-samsung.c index 92f7b2b..8e61053 100644 --- a/drivers/gpio/gpio-samsung.c +++ b/drivers/gpio/gpio-samsung.c @@ -2734,6 +2734,27 @@ static __init void exynos4_gpiolib_init(void) int group = 0; void __iomem *gpx_base; +#ifdef CONFIG_OF + /* + * This gpio driver includes support for device tree support and + * there are platforms using it. In order to maintain + * compatibility with those platforms, and to allow non-dt + * Exynos4210 platforms to use this gpiolib support, a check + * is added to find out if there is a active pin-controller + * driver support available. If it is available, this gpiolib + * support is ignored and the gpiolib support available in + * pin-controller driver is used. This is a temporary check and + * will go away when all of the Exynos4210 platforms have + * switched to using device tree and the pin-ctrl driver. + */ + struct device_node *pctrl_np; + const char *pctrl_compat = "samsung,pinctrl-exynos4210"; + pctrl_np = of_find_compatible_node(NULL, NULL, pctrl_compat); + if (pctrl_np) + if (of_device_is_available(pctrl_np)) + return -ENODEV; +#endif + /* gpio part1 */ gpio_base1 = ioremap(EXYNOS4_PA_GPIO1, SZ_4K); if (gpio_base1 == NULL) { -- 1.6.6.rc2
WARNING: multiple messages have this Message-ID (diff)
From: thomas.abraham@linaro.org (Thomas Abraham) To: linux-arm-kernel@lists.infradead.org Subject: [PATCH v2 3/4] gpio: exynos4: skip gpiolib registration if pinctrl driver is used Date: Thu, 16 Aug 2012 01:27:35 +0530 [thread overview] Message-ID: <1345060656-32201-4-git-send-email-thomas.abraham@linaro.org> (raw) In-Reply-To: <1345060656-32201-1-git-send-email-thomas.abraham@linaro.org> Pinctrl driver, when enabled, registers all the gpio pins and hence the registration of gpio pins by this driver can be skipped. Acked-by: Grant Likely <grant.likely@secretlab.ca> Acked-by: Linus Walleij <linus.walleij@linaro.org> Signed-off-by: Thomas Abraham <thomas.abraham@linaro.org> --- drivers/gpio/gpio-samsung.c | 21 +++++++++++++++++++++ 1 files changed, 21 insertions(+), 0 deletions(-) diff --git a/drivers/gpio/gpio-samsung.c b/drivers/gpio/gpio-samsung.c index 92f7b2b..8e61053 100644 --- a/drivers/gpio/gpio-samsung.c +++ b/drivers/gpio/gpio-samsung.c @@ -2734,6 +2734,27 @@ static __init void exynos4_gpiolib_init(void) int group = 0; void __iomem *gpx_base; +#ifdef CONFIG_OF + /* + * This gpio driver includes support for device tree support and + * there are platforms using it. In order to maintain + * compatibility with those platforms, and to allow non-dt + * Exynos4210 platforms to use this gpiolib support, a check + * is added to find out if there is a active pin-controller + * driver support available. If it is available, this gpiolib + * support is ignored and the gpiolib support available in + * pin-controller driver is used. This is a temporary check and + * will go away when all of the Exynos4210 platforms have + * switched to using device tree and the pin-ctrl driver. + */ + struct device_node *pctrl_np; + const char *pctrl_compat = "samsung,pinctrl-exynos4210"; + pctrl_np = of_find_compatible_node(NULL, NULL, pctrl_compat); + if (pctrl_np) + if (of_device_is_available(pctrl_np)) + return -ENODEV; +#endif + /* gpio part1 */ gpio_base1 = ioremap(EXYNOS4_PA_GPIO1, SZ_4K); if (gpio_base1 == NULL) { -- 1.6.6.rc2
next prev parent reply other threads:[~2012-08-15 19:40 UTC|newest] Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top 2012-08-15 19:57 [PATCH v2 0/4] pinctrl: add support for samsung pinctrl driver Thomas Abraham 2012-08-15 19:57 ` Thomas Abraham 2012-08-15 19:57 ` [PATCH v2 1/4] pinctrl: add samsung pinctrl and gpiolib driver Thomas Abraham 2012-08-15 19:57 ` Thomas Abraham 2012-08-21 11:25 ` Linus Walleij 2012-08-21 11:25 ` Linus Walleij 2012-08-21 21:38 ` Stephen Warren 2012-08-21 21:38 ` Stephen Warren 2012-08-22 5:00 ` Thomas Abraham 2012-08-22 5:00 ` Thomas Abraham 2012-08-22 4:22 ` Thomas Abraham 2012-08-22 4:22 ` Thomas Abraham 2012-08-22 4:22 ` Thomas Abraham 2012-08-27 23:22 ` Linus Walleij 2012-08-27 23:22 ` Linus Walleij 2012-08-28 5:25 ` Thomas Abraham 2012-08-28 5:25 ` Thomas Abraham 2012-08-15 19:57 ` [PATCH v2 2/4] pinctrl: add exynos4210 specific extensions for samsung pinctrl driver Thomas Abraham 2012-08-15 19:57 ` Thomas Abraham 2012-08-15 19:57 ` Thomas Abraham 2012-08-21 12:02 ` Linus Walleij 2012-08-21 12:02 ` Linus Walleij 2012-08-22 4:37 ` Thomas Abraham 2012-08-22 4:37 ` Thomas Abraham 2012-08-15 19:57 ` Thomas Abraham [this message] 2012-08-15 19:57 ` [PATCH v2 3/4] gpio: exynos4: skip gpiolib registration if pinctrl driver is used Thomas Abraham 2012-08-21 12:05 ` Linus Walleij 2012-08-21 12:05 ` Linus Walleij 2012-08-22 4:38 ` Thomas Abraham 2012-08-22 4:38 ` Thomas Abraham 2012-08-15 19:57 ` [PATCH v2 4/4] ARM: EXYNOS: skip wakeup interrupt setup " Thomas Abraham 2012-08-15 19:57 ` Thomas Abraham 2012-08-21 12:04 ` Linus Walleij 2012-08-21 12:04 ` Linus Walleij 2012-08-22 4:39 ` Thomas Abraham 2012-08-22 4:39 ` Thomas Abraham
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=1345060656-32201-4-git-send-email-thomas.abraham@linaro.org \ --to=thomas.abraham@linaro.org \ --cc=grant.likely@secretlab.ca \ --cc=kgene.kim@samsung.com \ --cc=linus.walleij@linaro.org \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-samsung-soc@vger.kernel.org \ --cc=patches@linaro.org \ --cc=rob.herring@calxeda.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.