From: Kishon Vijay Abraham I <kishon@ti.com>
To: <grant.likely@secretlab.ca>, <rob.herring@calxeda.com>,
<rob@landley.net>, <kishon@ti.com>, <linux-usb@vger.kernel.org>,
<linux-omap@vger.kernel.org>,
<devicetree-discuss@lists.ozlabs.org>,
<linux-doc@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<linux-arm-kernel@lists.infradead.org>,
<gregkh@linuxfoundation.org>, <balbi@ti.com>
Subject: [PATCH 5/6] usb: dwc3-omap: Minor fixes to get dt working
Date: Fri, 28 Sep 2012 18:23:14 +0530 [thread overview]
Message-ID: <1348836795-4783-6-git-send-email-kishon@ti.com> (raw)
In-Reply-To: <1348836795-4783-1-git-send-email-kishon@ti.com>
Includes few minor fixes in dwc3-omap like populating the compatible
string in a correct way, extracting the utmi-mode property properly and
changing the index of get_irq since irq of core is removed from hwmod
entry.
Signed-off-by: Kishon Vijay Abraham I <kishon@ti.com>
---
drivers/usb/dwc3/dwc3-omap.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/usb/dwc3/dwc3-omap.c b/drivers/usb/dwc3/dwc3-omap.c
index 7ae4d73..e3d9a5f 100644
--- a/drivers/usb/dwc3/dwc3-omap.c
+++ b/drivers/usb/dwc3/dwc3-omap.c
@@ -277,7 +277,7 @@ static int __devinit dwc3_omap_probe(struct platform_device *pdev)
platform_set_drvdata(pdev, omap);
- irq = platform_get_irq(pdev, 1);
+ irq = platform_get_irq(pdev, 0);
if (irq < 0) {
dev_err(dev, "missing IRQ resource\n");
return -EINVAL;
@@ -335,7 +335,7 @@ static int __devinit dwc3_omap_probe(struct platform_device *pdev)
utmi_mode = of_get_property(node, "utmi-mode", &size);
if (utmi_mode && size == sizeof(*utmi_mode)) {
- reg |= *utmi_mode;
+ reg |= be32_to_cpup(utmi_mode);
} else {
if (!pdata) {
dev_dbg(dev, "missing platform data\n");
@@ -403,7 +403,7 @@ static int __devexit dwc3_omap_remove(struct platform_device *pdev)
static const struct of_device_id of_dwc3_matach[] = {
{
- "ti,dwc3",
+ .compatible = "ti,dwc3"
},
{ },
};
--
1.7.10.4
WARNING: multiple messages have this Message-ID (diff)
From: Kishon Vijay Abraham I <kishon@ti.com>
To: grant.likely@secretlab.ca, rob.herring@calxeda.com,
rob@landley.net, kishon@ti.com, linux-usb@vger.kernel.org,
linux-omap@vger.kernel.org, devicetree-discuss@lists.ozlabs.org,
linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, gregkh@linuxfoundation.org,
balbi@ti.com
Subject: [PATCH 5/6] usb: dwc3-omap: Minor fixes to get dt working
Date: Fri, 28 Sep 2012 18:23:14 +0530 [thread overview]
Message-ID: <1348836795-4783-6-git-send-email-kishon@ti.com> (raw)
In-Reply-To: <1348836795-4783-1-git-send-email-kishon@ti.com>
Includes few minor fixes in dwc3-omap like populating the compatible
string in a correct way, extracting the utmi-mode property properly and
changing the index of get_irq since irq of core is removed from hwmod
entry.
Signed-off-by: Kishon Vijay Abraham I <kishon@ti.com>
---
drivers/usb/dwc3/dwc3-omap.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/usb/dwc3/dwc3-omap.c b/drivers/usb/dwc3/dwc3-omap.c
index 7ae4d73..e3d9a5f 100644
--- a/drivers/usb/dwc3/dwc3-omap.c
+++ b/drivers/usb/dwc3/dwc3-omap.c
@@ -277,7 +277,7 @@ static int __devinit dwc3_omap_probe(struct platform_device *pdev)
platform_set_drvdata(pdev, omap);
- irq = platform_get_irq(pdev, 1);
+ irq = platform_get_irq(pdev, 0);
if (irq < 0) {
dev_err(dev, "missing IRQ resource\n");
return -EINVAL;
@@ -335,7 +335,7 @@ static int __devinit dwc3_omap_probe(struct platform_device *pdev)
utmi_mode = of_get_property(node, "utmi-mode", &size);
if (utmi_mode && size == sizeof(*utmi_mode)) {
- reg |= *utmi_mode;
+ reg |= be32_to_cpup(utmi_mode);
} else {
if (!pdata) {
dev_dbg(dev, "missing platform data\n");
@@ -403,7 +403,7 @@ static int __devexit dwc3_omap_remove(struct platform_device *pdev)
static const struct of_device_id of_dwc3_matach[] = {
{
- "ti,dwc3",
+ .compatible = "ti,dwc3"
},
{ },
};
--
1.7.10.4
WARNING: multiple messages have this Message-ID (diff)
From: kishon@ti.com (Kishon Vijay Abraham I)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 5/6] usb: dwc3-omap: Minor fixes to get dt working
Date: Fri, 28 Sep 2012 18:23:14 +0530 [thread overview]
Message-ID: <1348836795-4783-6-git-send-email-kishon@ti.com> (raw)
In-Reply-To: <1348836795-4783-1-git-send-email-kishon@ti.com>
Includes few minor fixes in dwc3-omap like populating the compatible
string in a correct way, extracting the utmi-mode property properly and
changing the index of get_irq since irq of core is removed from hwmod
entry.
Signed-off-by: Kishon Vijay Abraham I <kishon@ti.com>
---
drivers/usb/dwc3/dwc3-omap.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/usb/dwc3/dwc3-omap.c b/drivers/usb/dwc3/dwc3-omap.c
index 7ae4d73..e3d9a5f 100644
--- a/drivers/usb/dwc3/dwc3-omap.c
+++ b/drivers/usb/dwc3/dwc3-omap.c
@@ -277,7 +277,7 @@ static int __devinit dwc3_omap_probe(struct platform_device *pdev)
platform_set_drvdata(pdev, omap);
- irq = platform_get_irq(pdev, 1);
+ irq = platform_get_irq(pdev, 0);
if (irq < 0) {
dev_err(dev, "missing IRQ resource\n");
return -EINVAL;
@@ -335,7 +335,7 @@ static int __devinit dwc3_omap_probe(struct platform_device *pdev)
utmi_mode = of_get_property(node, "utmi-mode", &size);
if (utmi_mode && size == sizeof(*utmi_mode)) {
- reg |= *utmi_mode;
+ reg |= be32_to_cpup(utmi_mode);
} else {
if (!pdata) {
dev_dbg(dev, "missing platform data\n");
@@ -403,7 +403,7 @@ static int __devexit dwc3_omap_remove(struct platform_device *pdev)
static const struct of_device_id of_dwc3_matach[] = {
{
- "ti,dwc3",
+ .compatible = "ti,dwc3"
},
{ },
};
--
1.7.10.4
next prev parent reply other threads:[~2012-09-28 12:53 UTC|newest]
Thread overview: 48+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-28 12:53 [PATCH 0/6] usb: dwc3-omap: add dt support Kishon Vijay Abraham I
2012-09-28 12:53 ` Kishon Vijay Abraham I
2012-09-28 12:53 ` Kishon Vijay Abraham I
2012-09-28 12:53 ` [PATCH 1/6] usb: dwc3-omap: use of_platform API to create dwc3 core pdev Kishon Vijay Abraham I
2012-09-28 12:53 ` Kishon Vijay Abraham I
2012-09-28 12:53 ` Kishon Vijay Abraham I
2012-09-28 12:57 ` Felipe Balbi
2012-09-28 12:57 ` Felipe Balbi
2012-09-28 12:57 ` Felipe Balbi
2012-09-28 13:31 ` ABRAHAM, KISHON VIJAY
2012-09-28 13:31 ` ABRAHAM, KISHON VIJAY
2012-10-01 8:50 ` Felipe Balbi
2012-10-01 8:50 ` Felipe Balbi
2012-09-28 12:53 ` [PATCH 2/6] usb: dwc3-omap: use runtime API's to enable clocks Kishon Vijay Abraham I
2012-09-28 12:53 ` Kishon Vijay Abraham I
2012-09-28 12:53 ` Kishon Vijay Abraham I
2012-09-28 12:58 ` Felipe Balbi
2012-09-28 12:58 ` Felipe Balbi
2012-09-28 12:58 ` Felipe Balbi
2012-09-28 13:31 ` ABRAHAM, KISHON VIJAY
2012-09-28 13:31 ` ABRAHAM, KISHON VIJAY
2012-09-28 13:31 ` ABRAHAM, KISHON VIJAY
2012-09-28 12:53 ` [PATCH 3/6] usb: dwc3-omap: Remove explicit writes to SYSCONFIG register Kishon Vijay Abraham I
2012-09-28 12:53 ` Kishon Vijay Abraham I
2012-09-28 12:53 ` Kishon Vijay Abraham I
2012-09-28 12:53 ` [PATCH 4/6] usb: dwc3-omap: Add an API to write to dwc mailbox Kishon Vijay Abraham I
2012-09-28 12:53 ` Kishon Vijay Abraham I
2012-09-28 12:53 ` Kishon Vijay Abraham I
2012-09-28 12:59 ` Felipe Balbi
2012-09-28 12:59 ` Felipe Balbi
2012-09-28 13:31 ` ABRAHAM, KISHON VIJAY
2012-09-28 13:31 ` ABRAHAM, KISHON VIJAY
2012-09-28 13:31 ` ABRAHAM, KISHON VIJAY
2012-09-28 12:53 ` Kishon Vijay Abraham I [this message]
2012-09-28 12:53 ` [PATCH 5/6] usb: dwc3-omap: Minor fixes to get dt working Kishon Vijay Abraham I
2012-09-28 12:53 ` Kishon Vijay Abraham I
2012-09-28 12:53 ` [PATCH 6/6] usb: dwc3: core: add dt support for dwc3 core Kishon Vijay Abraham I
2012-09-28 12:53 ` Kishon Vijay Abraham I
2012-09-28 12:53 ` Kishon Vijay Abraham I
2012-09-28 13:02 ` Felipe Balbi
2012-09-28 13:02 ` Felipe Balbi
2012-09-28 13:32 ` ABRAHAM, KISHON VIJAY
2012-09-28 13:32 ` ABRAHAM, KISHON VIJAY
2012-09-30 16:47 ` Sergei Shtylyov
2012-09-30 16:47 ` Sergei Shtylyov
2012-10-01 5:10 ` ABRAHAM, KISHON VIJAY
2012-10-01 5:10 ` ABRAHAM, KISHON VIJAY
2012-10-01 5:10 ` ABRAHAM, KISHON VIJAY
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1348836795-4783-6-git-send-email-kishon@ti.com \
--to=kishon@ti.com \
--cc=balbi@ti.com \
--cc=devicetree-discuss@lists.ozlabs.org \
--cc=grant.likely@secretlab.ca \
--cc=gregkh@linuxfoundation.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=rob.herring@calxeda.com \
--cc=rob@landley.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.