All of lore.kernel.org
 help / color / mirror / Atom feed
From: Lokesh Vutla <lokeshvutla@ti.com>
To: <will.deacon@arm.com>
Cc: <dietmar.eggemann@arm.com>,
	<linux-arm-kernel@lists.infradead.org>,
	<linux-kernel@vger.kernel.org>, <linux-omap@vger.kernel.org>,
	<santosh.shilimkar@ti.com>, <lokeshvutla@ti.com>
Subject: [PATCH] ARM: hw_breakpoint: Enable debug powerdown only if system supports 'has_ossr'
Date: Wed, 13 Mar 2013 12:22:33 +0530	[thread overview]
Message-ID: <1363157553-21085-1-git-send-email-lokeshvutla@ti.com> (raw)

Commit {9a6eb31 ARM: hw_breakpoint: Debug powerdown support for self-hosted
debug} introduces debug powerdown support for self-hosted debug.
While merging the patch 'has_ossr' check was removed which
was needed for hardwares which doesn't support self-hosted debug.
Pandaboard (A9) is one such hardware and Dietmar's orginial
patch did mention this issue.
Without that check on Panda with CPUIDLE enabled, a flood of
below messages thrown.

[ 3.597930] hw-breakpoint: CPU 0 failed to disable vector catch
[ 3.597991] hw-breakpoint: CPU 1 failed to disable vector catch

So restore that check back to avoid the mentioned issue.

Cc: Dietmar Eggemann <dietmar.eggemann@arm.com>
Cc: Will Deacon <will.deacon@arm.com>
Reported-by: Santosh Shilimkar <santosh.shilimkar@ti.com>
Acked-by: Santosh Shilimkar <santosh.shilimkar@ti.com>
Signed-off-by: Lokesh Vutla <lokeshvutla@ti.com>
---
 arch/arm/kernel/hw_breakpoint.c |    3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/arch/arm/kernel/hw_breakpoint.c b/arch/arm/kernel/hw_breakpoint.c
index 96093b7..0ba062d 100644
--- a/arch/arm/kernel/hw_breakpoint.c
+++ b/arch/arm/kernel/hw_breakpoint.c
@@ -1049,7 +1049,8 @@ static struct notifier_block __cpuinitdata dbg_cpu_pm_nb = {
 
 static void __init pm_init(void)
 {
-	cpu_pm_register_notifier(&dbg_cpu_pm_nb);
+	if (has_ossr)
+		cpu_pm_register_notifier(&dbg_cpu_pm_nb);
 }
 #else
 static inline void pm_init(void)
-- 
1.7.9.5


WARNING: multiple messages have this Message-ID (diff)
From: Lokesh Vutla <lokeshvutla@ti.com>
To: will.deacon@arm.com
Cc: dietmar.eggemann@arm.com, linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org, linux-omap@vger.kernel.org,
	santosh.shilimkar@ti.com, lokeshvutla@ti.com
Subject: [PATCH] ARM: hw_breakpoint: Enable debug powerdown only if system supports 'has_ossr'
Date: Wed, 13 Mar 2013 12:22:33 +0530	[thread overview]
Message-ID: <1363157553-21085-1-git-send-email-lokeshvutla@ti.com> (raw)

Commit {9a6eb31 ARM: hw_breakpoint: Debug powerdown support for self-hosted
debug} introduces debug powerdown support for self-hosted debug.
While merging the patch 'has_ossr' check was removed which
was needed for hardwares which doesn't support self-hosted debug.
Pandaboard (A9) is one such hardware and Dietmar's orginial
patch did mention this issue.
Without that check on Panda with CPUIDLE enabled, a flood of
below messages thrown.

[ 3.597930] hw-breakpoint: CPU 0 failed to disable vector catch
[ 3.597991] hw-breakpoint: CPU 1 failed to disable vector catch

So restore that check back to avoid the mentioned issue.

Cc: Dietmar Eggemann <dietmar.eggemann@arm.com>
Cc: Will Deacon <will.deacon@arm.com>
Reported-by: Santosh Shilimkar <santosh.shilimkar@ti.com>
Acked-by: Santosh Shilimkar <santosh.shilimkar@ti.com>
Signed-off-by: Lokesh Vutla <lokeshvutla@ti.com>
---
 arch/arm/kernel/hw_breakpoint.c |    3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/arch/arm/kernel/hw_breakpoint.c b/arch/arm/kernel/hw_breakpoint.c
index 96093b7..0ba062d 100644
--- a/arch/arm/kernel/hw_breakpoint.c
+++ b/arch/arm/kernel/hw_breakpoint.c
@@ -1049,7 +1049,8 @@ static struct notifier_block __cpuinitdata dbg_cpu_pm_nb = {
 
 static void __init pm_init(void)
 {
-	cpu_pm_register_notifier(&dbg_cpu_pm_nb);
+	if (has_ossr)
+		cpu_pm_register_notifier(&dbg_cpu_pm_nb);
 }
 #else
 static inline void pm_init(void)
-- 
1.7.9.5

WARNING: multiple messages have this Message-ID (diff)
From: lokeshvutla@ti.com (Lokesh Vutla)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: hw_breakpoint: Enable debug powerdown only if system supports 'has_ossr'
Date: Wed, 13 Mar 2013 12:22:33 +0530	[thread overview]
Message-ID: <1363157553-21085-1-git-send-email-lokeshvutla@ti.com> (raw)

Commit {9a6eb31 ARM: hw_breakpoint: Debug powerdown support for self-hosted
debug} introduces debug powerdown support for self-hosted debug.
While merging the patch 'has_ossr' check was removed which
was needed for hardwares which doesn't support self-hosted debug.
Pandaboard (A9) is one such hardware and Dietmar's orginial
patch did mention this issue.
Without that check on Panda with CPUIDLE enabled, a flood of
below messages thrown.

[ 3.597930] hw-breakpoint: CPU 0 failed to disable vector catch
[ 3.597991] hw-breakpoint: CPU 1 failed to disable vector catch

So restore that check back to avoid the mentioned issue.

Cc: Dietmar Eggemann <dietmar.eggemann@arm.com>
Cc: Will Deacon <will.deacon@arm.com>
Reported-by: Santosh Shilimkar <santosh.shilimkar@ti.com>
Acked-by: Santosh Shilimkar <santosh.shilimkar@ti.com>
Signed-off-by: Lokesh Vutla <lokeshvutla@ti.com>
---
 arch/arm/kernel/hw_breakpoint.c |    3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/arch/arm/kernel/hw_breakpoint.c b/arch/arm/kernel/hw_breakpoint.c
index 96093b7..0ba062d 100644
--- a/arch/arm/kernel/hw_breakpoint.c
+++ b/arch/arm/kernel/hw_breakpoint.c
@@ -1049,7 +1049,8 @@ static struct notifier_block __cpuinitdata dbg_cpu_pm_nb = {
 
 static void __init pm_init(void)
 {
-	cpu_pm_register_notifier(&dbg_cpu_pm_nb);
+	if (has_ossr)
+		cpu_pm_register_notifier(&dbg_cpu_pm_nb);
 }
 #else
 static inline void pm_init(void)
-- 
1.7.9.5

             reply	other threads:[~2013-03-13  6:52 UTC|newest]

Thread overview: 47+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-03-13  6:52 Lokesh Vutla [this message]
2013-03-13  6:52 ` [PATCH] ARM: hw_breakpoint: Enable debug powerdown only if system supports 'has_ossr' Lokesh Vutla
2013-03-13  6:52 ` Lokesh Vutla
2013-03-13 12:05 ` Dietmar Eggemann
2013-03-13 12:05   ` Dietmar Eggemann
2013-03-13 12:05   ` Dietmar Eggemann
2013-03-13 12:29   ` Lokesh Vutla
2013-03-13 12:29     ` Lokesh Vutla
2013-03-13 12:29     ` Lokesh Vutla
2013-03-14  7:38     ` Santosh Shilimkar
2013-03-14  7:38       ` Santosh Shilimkar
2013-03-14  7:38       ` Santosh Shilimkar
2013-03-15  5:00       ` Will Deacon
2013-03-15  5:00         ` Will Deacon
2013-03-18  6:51         ` Santosh Shilimkar
2013-03-18  6:51           ` Santosh Shilimkar
2013-03-18  6:51           ` Santosh Shilimkar
2013-03-18 15:07           ` Will Deacon
2013-03-18 15:07             ` Will Deacon
2013-03-18 15:07             ` Will Deacon
2013-03-18 15:46             ` Santosh Shilimkar
2013-03-18 15:46               ` Santosh Shilimkar
2013-03-18 15:46               ` Santosh Shilimkar
2013-03-18 17:06               ` Will Deacon
2013-03-18 17:06                 ` Will Deacon
2013-03-18 17:06                 ` Will Deacon
2013-03-19  6:39                 ` Santosh Shilimkar
2013-03-19  6:39                   ` Santosh Shilimkar
2013-03-19  6:39                   ` Santosh Shilimkar
2013-03-19 10:28                   ` Will Deacon
2013-03-19 10:28                     ` Will Deacon
2013-03-19 10:28                     ` Will Deacon
2013-03-25  9:11                     ` Santosh Shilimkar
2013-03-25  9:11                       ` Santosh Shilimkar
2013-03-25  9:11                       ` Santosh Shilimkar
2013-03-25 10:49                       ` Will Deacon
2013-03-25 10:49                         ` Will Deacon
2013-03-25 10:49                         ` Will Deacon
2013-03-25 10:55                         ` Santosh Shilimkar
2013-03-25 10:55                           ` Santosh Shilimkar
2013-03-25 10:55                           ` Santosh Shilimkar
2013-03-28 11:59                     ` Dietmar Eggemann
2013-03-28 11:59                       ` Dietmar Eggemann
2013-03-28 11:59                       ` Dietmar Eggemann
2013-03-14 17:38 ` Kevin Hilman
2013-03-14 17:38   ` Kevin Hilman
2013-03-14 17:38   ` Kevin Hilman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1363157553-21085-1-git-send-email-lokeshvutla@ti.com \
    --to=lokeshvutla@ti.com \
    --cc=dietmar.eggemann@arm.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-omap@vger.kernel.org \
    --cc=santosh.shilimkar@ti.com \
    --cc=will.deacon@arm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.