All of lore.kernel.org
 help / color / mirror / Atom feed
From: Daniel Vetter <daniel.vetter@ffwll.ch>
To: Intel Graphics Development <intel-gfx@lists.freedesktop.org>
Cc: Daniel Vetter <daniel.vetter@ffwll.ch>
Subject: [PATCH 01/15] drm/i915: fixup 12bpc hdmi dotclock handling
Date: Fri, 19 Apr 2013 11:24:33 +0200	[thread overview]
Message-ID: <1366363487-15926-2-git-send-email-daniel.vetter@ffwll.ch> (raw)
In-Reply-To: <1366363487-15926-1-git-send-email-daniel.vetter@ffwll.ch>

We need to multiply the hdmi port dotclock by 1.5x since it's not
really a dotclock, but the 10/8 encoding bitclock divided by 10.

Also add correct limit checks for the dotclock and reject modes which
don't fit. HDMI 1.4 would allow more, but our hw doesn't support that
unfortunately :(

Somehow I suspect 12bpc hdmi output never really worked - we really
need an i-g-t testcase to check all the different pixel modes and
outputs.

v2: Fixup the adjusted port clock handling - we need to make sure that
the fdi link code still gets the real pixelclock.

v3: g4x/vlv don't support 12bpc hdmi output so drop the bogus comment.

Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch>
---
 drivers/gpu/drm/i915/intel_hdmi.c | 17 +++++++++++++++--
 1 file changed, 15 insertions(+), 2 deletions(-)

diff --git a/drivers/gpu/drm/i915/intel_hdmi.c b/drivers/gpu/drm/i915/intel_hdmi.c
index 53ce8a5..a8273c7 100644
--- a/drivers/gpu/drm/i915/intel_hdmi.c
+++ b/drivers/gpu/drm/i915/intel_hdmi.c
@@ -783,6 +783,7 @@ bool intel_hdmi_compute_config(struct intel_encoder *encoder,
 	struct intel_hdmi *intel_hdmi = enc_to_intel_hdmi(&encoder->base);
 	struct drm_device *dev = encoder->base.dev;
 	struct drm_display_mode *adjusted_mode = &pipe_config->adjusted_mode;
+	int clock_12bpc = pipe_config->requested_mode.clock * 3 / 2;
 
 	if (intel_hdmi->color_range_auto) {
 		/* See CEA-861-E - 5.1 Default Encoding Parameters */
@@ -802,16 +803,28 @@ bool intel_hdmi_compute_config(struct intel_encoder *encoder,
 	/*
 	 * HDMI is either 12 or 8, so if the display lets 10bpc sneak
 	 * through, clamp it down. Note that g4x/vlv don't support 12bpc hdmi
-	 * outputs.
+	 * outputs. We also need to check that the higher clock still fits
+	 * within limits.
 	 */
-	if (pipe_config->pipe_bpp > 8*3 && HAS_PCH_SPLIT(dev)) {
+	if (pipe_config->pipe_bpp > 8*3 && clock_12bpc < 225000
+	    && HAS_PCH_SPLIT(dev)) {
 		DRM_DEBUG_KMS("forcing bpc to 12 for HDMI\n");
 		pipe_config->pipe_bpp = 12*3;
+
+		/* Need to adjust the port link by 1.5x for 12bpc. */
+		adjusted_mode->clock = clock_12bpc;
+		pipe_config->pixel_target_clock =
+			pipe_config->requested_mode.clock;
 	} else {
 		DRM_DEBUG_KMS("forcing bpc to 8 for HDMI\n");
 		pipe_config->pipe_bpp = 8*3;
 	}
 
+	if (adjusted_mode->clock > 225000) {
+		DRM_DEBUG_KMS("too high HDMI clock, rejecting mode\n");
+		return false;
+	}
+
 	return true;
 }
 
-- 
1.7.11.7

  reply	other threads:[~2013-04-19  9:24 UTC|newest]

Thread overview: 59+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-04-19  9:24 [PATCH 00/15] high-bpp fixes and fdi auto dithering Daniel Vetter
2013-04-19  9:24 ` Daniel Vetter [this message]
2013-04-23 15:02   ` [PATCH 01/15] drm/i915: fixup 12bpc hdmi dotclock handling Ville Syrjälä
2013-04-23 15:37     ` Daniel Vetter
2013-04-19  9:24 ` [PATCH 02/15] drm/i915: Disable high-bpc on pre-1.4 EDID screens Daniel Vetter
2013-04-23 15:07   ` Ville Syrjälä
2013-04-24 10:54     ` Daniel Vetter
2013-04-19  9:24 ` [PATCH 03/15] drm/i915: force bpp for eDP panels Daniel Vetter
2013-04-19 20:31   ` [PATCH] " Daniel Vetter
2013-04-19  9:24 ` [PATCH 04/15] drm/i915: drop adjusted_mode from *_set_pipeconf functions Daniel Vetter
2013-04-23 15:12   ` Ville Syrjälä
2013-04-19  9:24 ` [PATCH 05/15] drm/i915: implement high-bpc + pipeconf-dither support for g4x/vlv Daniel Vetter
2013-04-19 16:39   ` Jesse Barnes
2013-04-19 18:17     ` [PATCH] " Daniel Vetter
2013-04-19 18:39       ` Jesse Barnes
2013-04-19 19:29         ` Daniel Vetter
2013-04-23 15:27       ` Ville Syrjälä
2013-04-23 20:39         ` Daniel Vetter
2013-04-23 22:27           ` Daniel Vetter
2013-04-24 11:07             ` Ville Syrjälä
2013-04-23 22:30         ` Daniel Vetter
2013-04-24 11:11           ` Ville Syrjälä
2013-04-24 12:57             ` Daniel Vetter
2013-04-24 13:07               ` Ville Syrjälä
2013-04-19  9:24 ` [PATCH 06/15] drm/i915: allow high-bpc modes on DP Daniel Vetter
2013-04-29 10:16   ` Imre Deak
2013-04-19  9:24 ` [PATCH 07/15] drm/i915: Fixup non-24bpp support for VGA screens on Haswell Daniel Vetter
2013-04-24 11:12   ` Ville Syrjälä
2013-04-24 12:50     ` Daniel Vetter
2013-04-19  9:24 ` [PATCH 08/15] drm/i915: move intel_crtc->fdi_lanes to pipe_config Daniel Vetter
2013-04-29 10:17   ` Imre Deak
2013-04-19  9:24 ` [PATCH 09/15] drm/i915: hw state readout support for pipe_config->fdi_lanes Daniel Vetter
2013-04-24 11:23   ` Ville Syrjälä
2013-04-24 12:49     ` Daniel Vetter
2013-04-24 13:30     ` [PATCH] " Daniel Vetter
2013-04-29 10:22       ` Imre Deak
2013-04-29 17:33         ` [PATCH] drm/i915: put the right cpu_transcoder into pipe_config for hw state readout Daniel Vetter
2013-04-29 17:33         ` [PATCH] drm/i915: hw state readout support for pipe_config->fdi_lanes Daniel Vetter
2013-04-19  9:24 ` [PATCH 10/15] drm/i915: split up fdi_set_m_n into computation and hw setup Daniel Vetter
2013-04-24 11:26   ` Ville Syrjälä
2013-04-19  9:24 ` [PATCH 11/15] drm/i915: compute fdi lane config earlier Daniel Vetter
2013-04-29 12:13   ` Imre Deak
2013-04-19  9:24 ` [PATCH 12/15] drm/i915: Split up ironlake_check_fdi_lanes Daniel Vetter
2013-04-29 12:19   ` Imre Deak
2013-04-19  9:24 ` [PATCH 13/15] drm/i915: move fdi lane configuration checks ahead Daniel Vetter
2013-04-22 10:32   ` Ville Syrjälä
2013-04-22 15:13     ` [PATCH] " Daniel Vetter
2013-04-29 12:31       ` Imre Deak
2013-04-29 17:34         ` Daniel Vetter
2013-04-19  9:24 ` [PATCH 14/15] drm/i915: don't count cpu ports for fdi B/C lane sharing Daniel Vetter
2013-04-29 13:00   ` Imre Deak
2013-04-19  9:24 ` [PATCH 15/15] drm/i915: implement fdi auto-dithering Daniel Vetter
2013-04-29 14:02   ` Imre Deak
2013-04-29 14:43     ` Daniel Vetter
2013-04-29 14:59       ` Imre Deak
2013-04-29 19:35         ` Daniel Vetter
2013-04-19 15:05 ` [PATCH 00/15] high-bpp fixes and fdi auto dithering Chris Wilson
2013-04-25 10:28 ` Jani Nikula
2013-04-29 19:51   ` Daniel Vetter

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1366363487-15926-2-git-send-email-daniel.vetter@ffwll.ch \
    --to=daniel.vetter@ffwll.ch \
    --cc=intel-gfx@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.