All of lore.kernel.org
 help / color / mirror / Atom feed
From: Chris Wilson <chris@chris-wilson.co.uk>
To: dri-devel@lists.freedesktop.org
Cc: Dave Airlie <airlied@redhat.com>
Subject: [PATCH 1/8] drm: Clean up debugfs upon shutdown
Date: Sun,  7 Jul 2013 20:02:18 +0100	[thread overview]
Message-ID: <1373223745-9095-1-git-send-email-chris@chris-wilson.co.uk> (raw)

Driver authors are a forgetful breed, and having to manually clean up
all inodes from debugfs during module unload is tedious and rarely
encountered by users; leftover inodes fester. But behold, the drm core
already tracks all inodes created under the DRI debugfs minor so that we
can do all the teardown ourselves.

Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
Cc: Dave Airlie <airlied@redhat.com>
---
 drivers/gpu/drm/drm_debugfs.c | 11 ++++++++++-
 1 file changed, 10 insertions(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/drm_debugfs.c b/drivers/gpu/drm/drm_debugfs.c
index a05087c..b855fd7 100644
--- a/drivers/gpu/drm/drm_debugfs.c
+++ b/drivers/gpu/drm/drm_debugfs.c
@@ -229,7 +229,16 @@ int drm_debugfs_cleanup(struct drm_minor *minor)
 	if (dev->driver->debugfs_cleanup)
 		dev->driver->debugfs_cleanup(minor);
 
-	drm_debugfs_remove_files(drm_debugfs_list, DRM_DEBUGFS_ENTRIES, minor);
+	while (!list_empty(&minor->debugfs_list)) {
+		struct drm_info_node *node =
+			list_first_entry(&minor->debugfs_list,
+					 struct drm_info_node,
+					 list);
+
+		debugfs_remove(node->dent);
+		list_del(&node->list);
+		kfree(node);
+	}
 
 	debugfs_remove(minor->debugfs_root);
 	minor->debugfs_root = NULL;
-- 
1.8.3.2

             reply	other threads:[~2013-07-07 19:02 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-07-07 19:02 Chris Wilson [this message]
2013-07-07 19:02 ` [PATCH 2/8] drm/i915: Remove redundant debugfs cleanup Chris Wilson
2013-07-07 19:02 ` [PATCH 3/8] drm/nouveau: " Chris Wilson
2013-07-07 19:02 ` [PATCH 4/8] drm/omap: " Chris Wilson
2013-07-07 23:40   ` Rob Clark
2013-07-07 19:02 ` [PATCH 5/8] drm/qxl: " Chris Wilson
2013-07-07 19:02 ` [PATCH 6/8] drm/radeon: " Chris Wilson
2013-07-07 19:02 ` [PATCH 7/8] drm/tiledc: " Chris Wilson
2013-07-07 23:40   ` Rob Clark
2013-07-07 19:02 ` [PATCH 8/8] drm: Remove debugfs_cleanup callback from drivers Chris Wilson
2013-07-08 20:21   ` Daniel Vetter
2013-07-07 23:39 ` [PATCH 1/8] drm: Clean up debugfs upon shutdown Rob Clark

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1373223745-9095-1-git-send-email-chris@chris-wilson.co.uk \
    --to=chris@chris-wilson.co.uk \
    --cc=airlied@redhat.com \
    --cc=dri-devel@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.