All of lore.kernel.org
 help / color / mirror / Atom feed
From: Sylwester Nawrocki <s.nawrocki@samsung.com>
To: kishon@ti.com
Cc: gregkh@linuxfoundation.org, linux-arm-kernel@lists.infradead.org,
	linux-samsung-soc@vger.kernel.org,
	Sylwester Nawrocki <s.nawrocki@samsung.com>
Subject: [PATCH] phy: exynos-mipi-video: Fix phy_power_off() callback
Date: Wed, 16 Oct 2013 19:03:45 +0200	[thread overview]
Message-ID: <1381943025-1036-1-git-send-email-s.nawrocki@samsung.com> (raw)
In-Reply-To: <1381940896-9355-1-git-send-email-kishon@ti.com>

Fix argument passed to the register setup helper function so
the phy is actually disabled. Now due to cut&paste error 1 is
passed to both phy_power_on() and phy_power_off().

Reported by: Kyungmin Park <kyungmin.park@samsung.com>
Signed-off-by: Sylwester Nawrocki <s.nawrocki@samsung.com>
---

This fixes a cut&paste typo which snicked in while doing very last
adaptation to latest version of the phy framework.

Thanks,
Sylwester
---
 drivers/phy/phy-exynos-mipi-video.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/phy/phy-exynos-mipi-video.c b/drivers/phy/phy-exynos-mipi-video.c
index b73b86a..0c5efab 100644
--- a/drivers/phy/phy-exynos-mipi-video.c
+++ b/drivers/phy/phy-exynos-mipi-video.c
@@ -93,7 +93,7 @@ static int exynos_mipi_video_phy_power_off(struct phy *phy)
 	struct video_phy_desc *phy_desc = phy_get_drvdata(phy);
 	struct exynos_mipi_video_phy *state = to_mipi_video_phy(phy_desc);
 
-	return __set_phy_state(state, phy_desc->index, 1);
+	return __set_phy_state(state, phy_desc->index, 0);
 }
 
 static struct phy *exynos_mipi_video_phy_xlate(struct device *dev,
-- 
1.7.9.5

WARNING: multiple messages have this Message-ID (diff)
From: s.nawrocki@samsung.com (Sylwester Nawrocki)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] phy: exynos-mipi-video: Fix phy_power_off() callback
Date: Wed, 16 Oct 2013 19:03:45 +0200	[thread overview]
Message-ID: <1381943025-1036-1-git-send-email-s.nawrocki@samsung.com> (raw)
In-Reply-To: <1381940896-9355-1-git-send-email-kishon@ti.com>

Fix argument passed to the register setup helper function so
the phy is actually disabled. Now due to cut&paste error 1 is
passed to both phy_power_on() and phy_power_off().

Reported by: Kyungmin Park <kyungmin.park@samsung.com>
Signed-off-by: Sylwester Nawrocki <s.nawrocki@samsung.com>
---

This fixes a cut&paste typo which snicked in while doing very last
adaptation to latest version of the phy framework.

Thanks,
Sylwester
---
 drivers/phy/phy-exynos-mipi-video.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/phy/phy-exynos-mipi-video.c b/drivers/phy/phy-exynos-mipi-video.c
index b73b86a..0c5efab 100644
--- a/drivers/phy/phy-exynos-mipi-video.c
+++ b/drivers/phy/phy-exynos-mipi-video.c
@@ -93,7 +93,7 @@ static int exynos_mipi_video_phy_power_off(struct phy *phy)
 	struct video_phy_desc *phy_desc = phy_get_drvdata(phy);
 	struct exynos_mipi_video_phy *state = to_mipi_video_phy(phy_desc);
 
-	return __set_phy_state(state, phy_desc->index, 1);
+	return __set_phy_state(state, phy_desc->index, 0);
 }
 
 static struct phy *exynos_mipi_video_phy_xlate(struct device *dev,
-- 
1.7.9.5

  parent reply	other threads:[~2013-10-16 17:03 UTC|newest]

Thread overview: 80+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-10-16 16:28 [PATCH 0/7] video phy's adaptation to *generic phy framework* Kishon Vijay Abraham I
2013-10-16 16:40 ` Kishon Vijay Abraham I
2013-10-16 16:28 ` Kishon Vijay Abraham I
2013-10-16 16:28 ` Kishon Vijay Abraham I
2013-10-16 16:28 ` [PATCH 1/7] phy: Add driver for Exynos MIPI CSIS/DSIM DPHYs Kishon Vijay Abraham I
2013-10-16 16:40   ` Kishon Vijay Abraham I
2013-10-16 16:28   ` Kishon Vijay Abraham I
2013-10-16 16:28   ` Kishon Vijay Abraham I
2013-10-16 16:28 ` [PATCH 2/7] exynos4-is: Use the generic MIPI CSIS PHY driver Kishon Vijay Abraham I
2013-10-16 16:40   ` Kishon Vijay Abraham I
2013-10-16 16:28   ` Kishon Vijay Abraham I
2013-10-16 16:28   ` Kishon Vijay Abraham I
2013-10-16 16:28 ` [PATCH 3/7] video: exynos_mipi_dsim: Use the generic " Kishon Vijay Abraham I
2013-10-16 16:40   ` Kishon Vijay Abraham I
2013-10-16 16:28   ` Kishon Vijay Abraham I
2013-10-16 16:28   ` Kishon Vijay Abraham I
2013-10-24 14:30   ` Olof Johansson
2013-10-24 14:30     ` Olof Johansson
2013-10-24 14:30     ` Olof Johansson
2013-10-24 15:27     ` [PATCH] drivers: video: exynos: Fix compiler Warning Kishon Vijay Abraham I
2013-10-24 15:39       ` Kishon Vijay Abraham I
2013-10-24 15:27       ` Kishon Vijay Abraham I
2013-10-24 15:27       ` Kishon Vijay Abraham I
2013-10-24 15:31       ` Felipe Balbi
2013-10-24 15:31         ` Felipe Balbi
2013-10-24 15:31         ` Felipe Balbi
2013-10-24 15:31         ` Felipe Balbi
2013-10-24 15:42     ` [PATCH 3/7] video: exynos_mipi_dsim: Use the generic PHY driver Sachin Kamat
2013-10-24 15:54       ` Sachin Kamat
2013-10-24 15:42       ` Sachin Kamat
2013-10-24 15:57       ` Kishon Vijay Abraham I
2013-10-24 15:57         ` Kishon Vijay Abraham I
2013-10-24 15:57         ` Kishon Vijay Abraham I
2013-10-24 15:57         ` Kishon Vijay Abraham I
2013-10-24 21:57         ` Sylwester Nawrocki
2013-10-24 21:57           ` Sylwester Nawrocki
2013-10-24 21:57           ` Sylwester Nawrocki
2013-10-28  6:12           ` Donghwa Lee
2013-10-28  6:12             ` Donghwa Lee
2013-10-28  6:12             ` Donghwa Lee
2013-10-28 12:24             ` Tomasz Figa
2013-10-28 12:24               ` Tomasz Figa
2013-10-28 12:24               ` Tomasz Figa
2013-10-29  8:38               ` Donghwa Lee
2013-10-29  8:38                 ` Donghwa Lee
2013-10-29  8:38                 ` Donghwa Lee
2013-10-30  0:43                 ` Sylwester Nawrocki
2013-10-30  0:43                   ` Sylwester Nawrocki
2013-10-30  0:43                   ` Sylwester Nawrocki
2013-10-24 17:06       ` Olof Johansson
2013-10-24 17:06         ` Olof Johansson
2013-10-24 17:06         ` Olof Johansson
2013-10-16 16:28 ` [PATCH 4/7] ARM: Samsung: Remove the MIPI PHY setup code Kishon Vijay Abraham I
2013-10-16 16:40   ` Kishon Vijay Abraham I
2013-10-16 16:28   ` Kishon Vijay Abraham I
2013-10-16 16:28   ` Kishon Vijay Abraham I
2013-10-16 16:28 ` [PATCH 5/7] phy: Add driver for Exynos DP PHY Kishon Vijay Abraham I
2013-10-16 16:40   ` Kishon Vijay Abraham I
2013-10-16 16:28   ` Kishon Vijay Abraham I
2013-10-16 16:28   ` Kishon Vijay Abraham I
2013-10-24 15:13   ` Tomasz Stanislawski
2013-10-24 15:13     ` Tomasz Stanislawski
2013-10-24 15:13     ` Tomasz Stanislawski
2013-10-16 16:28 ` [PATCH 6/7] video: exynos_dp: remove non-DT support for Exynos Display Port Kishon Vijay Abraham I
2013-10-16 16:40   ` Kishon Vijay Abraham I
2013-10-16 16:28   ` Kishon Vijay Abraham I
2013-10-16 16:28   ` Kishon Vijay Abraham I
2013-10-16 16:28 ` [PATCH 7/7] video: exynos_dp: Use the generic PHY driver Kishon Vijay Abraham I
2013-10-16 16:40   ` Kishon Vijay Abraham I
2013-10-16 16:28   ` Kishon Vijay Abraham I
2013-10-16 16:28   ` Kishon Vijay Abraham I
2013-10-16 17:03 ` Sylwester Nawrocki [this message]
2013-10-16 17:03   ` [PATCH] phy: exynos-mipi-video: Fix phy_power_off() callback Sylwester Nawrocki
2013-10-16 23:10   ` Jingoo Han
2013-10-16 23:10     ` Jingoo Han
2013-10-18  5:31   ` Kishon Vijay Abraham I
2013-10-18  5:31     ` Kishon Vijay Abraham I
2013-10-16 20:49 ` [PATCH 0/7] video phy's adaptation to *generic phy framework* Greg KH
2013-10-16 20:49   ` Greg KH
2013-10-16 20:49   ` Greg KH

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1381943025-1036-1-git-send-email-s.nawrocki@samsung.com \
    --to=s.nawrocki@samsung.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=kishon@ti.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-samsung-soc@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.