From: Stephen Boyd <sboyd@codeaurora.org> To: linux-edac@vger.kernel.org Cc: linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Russell King <linux@arm.linux.org.uk> Subject: [PATCH 3/6] ARM: Add Krait L2 accessor functions Date: Mon, 28 Oct 2013 17:31:27 -0700 [thread overview] Message-ID: <1383006690-6754-4-git-send-email-sboyd@codeaurora.org> (raw) In-Reply-To: <1383006690-6754-1-git-send-email-sboyd@codeaurora.org> Qualcomm's Krait CPUs have a handful of L2 cache controller registers that live behind a cp15 based indirection register. First you program the indirection register (l2cpselr) to point the L2 'window' register (l2cpdr) at what you want to read/write. Then you read/write the 'window' register to do what you want. The l2cpselr register is not banked per-cpu so we must lock around accesses to it to prevent other CPUs from re-pointing l2cpdr underneath us. Cc: Russell King <linux@arm.linux.org.uk> Signed-off-by: Stephen Boyd <sboyd@codeaurora.org> --- arch/arm/common/Kconfig | 3 ++ arch/arm/common/Makefile | 1 + arch/arm/common/krait-l2-accessors.c | 52 +++++++++++++++++++++++++++++++ arch/arm/include/asm/krait-l2-accessors.h | 20 ++++++++++++ 4 files changed, 76 insertions(+) create mode 100644 arch/arm/common/krait-l2-accessors.c create mode 100644 arch/arm/include/asm/krait-l2-accessors.h diff --git a/arch/arm/common/Kconfig b/arch/arm/common/Kconfig index c3a4e9c..9da52dc 100644 --- a/arch/arm/common/Kconfig +++ b/arch/arm/common/Kconfig @@ -9,6 +9,9 @@ config DMABOUNCE bool select ZONE_DMA +config KRAIT_L2_ACCESSORS + bool + config SHARP_LOCOMO bool diff --git a/arch/arm/common/Makefile b/arch/arm/common/Makefile index 8c60f47..606131a 100644 --- a/arch/arm/common/Makefile +++ b/arch/arm/common/Makefile @@ -8,6 +8,7 @@ obj-$(CONFIG_ICST) += icst.o obj-$(CONFIG_SA1111) += sa1111.o obj-$(CONFIG_PCI_HOST_VIA82C505) += via82c505.o obj-$(CONFIG_DMABOUNCE) += dmabounce.o +obj-$(CONFIG_KRAIT_L2_ACCESSORS) += krait-l2-accessors.o obj-$(CONFIG_SHARP_LOCOMO) += locomo.o obj-$(CONFIG_SHARP_PARAM) += sharpsl_param.o obj-$(CONFIG_SHARP_SCOOP) += scoop.o diff --git a/arch/arm/common/krait-l2-accessors.c b/arch/arm/common/krait-l2-accessors.c new file mode 100644 index 0000000..c579794 --- /dev/null +++ b/arch/arm/common/krait-l2-accessors.c @@ -0,0 +1,52 @@ +/* + * Copyright (c) 2011-2013, The Linux Foundation. All rights reserved. + * + * This program is free software; you can redistribute it and/or modify + * it under the terms of the GNU General Public License version 2 and + * only version 2 as published by the Free Software Foundation. + * + * This program is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the + * GNU General Public License for more details. + */ + +#include <linux/spinlock.h> +#include <linux/export.h> + +#include <asm/barrier.h> +#include <asm/krait-l2-accessors.h> + +static DEFINE_RAW_SPINLOCK(krait_l2_lock); + +void set_l2_indirect_reg(u32 addr, u32 val) +{ + unsigned long flags; + + raw_spin_lock_irqsave(&krait_l2_lock, flags); + + asm volatile ("mcr p15, 3, %0, c15, c0, 6" : : "r" (addr)); + isb(); + asm volatile ("mcr p15, 3, %0, c15, c0, 7" : : "r" (val)); + isb(); + + raw_spin_unlock_irqrestore(&krait_l2_lock, flags); +} +EXPORT_SYMBOL(set_l2_indirect_reg); + +u32 get_l2_indirect_reg(u32 addr) +{ + u32 val; + unsigned long flags; + + raw_spin_lock_irqsave(&krait_l2_lock, flags); + + asm volatile ("mcr p15, 3, %0, c15, c0, 6" : : "r" (addr)); + isb(); + asm volatile ("mrc p15, 3, %0, c15, c0, 7" : "=r" (val)); + + raw_spin_unlock_irqrestore(&krait_l2_lock, flags); + + return val; +} +EXPORT_SYMBOL(get_l2_indirect_reg); diff --git a/arch/arm/include/asm/krait-l2-accessors.h b/arch/arm/include/asm/krait-l2-accessors.h new file mode 100644 index 0000000..d5305c4 --- /dev/null +++ b/arch/arm/include/asm/krait-l2-accessors.h @@ -0,0 +1,20 @@ +/* + * Copyright (c) 2011-2013, The Linux Foundation. All rights reserved. + * + * This program is free software; you can redistribute it and/or modify + * it under the terms of the GNU General Public License version 2 and + * only version 2 as published by the Free Software Foundation. + * + * This program is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the + * GNU General Public License for more details. + */ + +#ifndef __ASMARM_KRAIT_L2_ACCESSORS_H +#define __ASMARM_KRAIT_L2_ACCESSORS_H + +extern void set_l2_indirect_reg(u32 addr, u32 val); +extern u32 get_l2_indirect_reg(u32 addr); + +#endif -- The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, hosted by The Linux Foundation
WARNING: multiple messages have this Message-ID (diff)
From: sboyd@codeaurora.org (Stephen Boyd) To: linux-arm-kernel@lists.infradead.org Subject: [PATCH 3/6] ARM: Add Krait L2 accessor functions Date: Mon, 28 Oct 2013 17:31:27 -0700 [thread overview] Message-ID: <1383006690-6754-4-git-send-email-sboyd@codeaurora.org> (raw) In-Reply-To: <1383006690-6754-1-git-send-email-sboyd@codeaurora.org> Qualcomm's Krait CPUs have a handful of L2 cache controller registers that live behind a cp15 based indirection register. First you program the indirection register (l2cpselr) to point the L2 'window' register (l2cpdr) at what you want to read/write. Then you read/write the 'window' register to do what you want. The l2cpselr register is not banked per-cpu so we must lock around accesses to it to prevent other CPUs from re-pointing l2cpdr underneath us. Cc: Russell King <linux@arm.linux.org.uk> Signed-off-by: Stephen Boyd <sboyd@codeaurora.org> --- arch/arm/common/Kconfig | 3 ++ arch/arm/common/Makefile | 1 + arch/arm/common/krait-l2-accessors.c | 52 +++++++++++++++++++++++++++++++ arch/arm/include/asm/krait-l2-accessors.h | 20 ++++++++++++ 4 files changed, 76 insertions(+) create mode 100644 arch/arm/common/krait-l2-accessors.c create mode 100644 arch/arm/include/asm/krait-l2-accessors.h diff --git a/arch/arm/common/Kconfig b/arch/arm/common/Kconfig index c3a4e9c..9da52dc 100644 --- a/arch/arm/common/Kconfig +++ b/arch/arm/common/Kconfig @@ -9,6 +9,9 @@ config DMABOUNCE bool select ZONE_DMA +config KRAIT_L2_ACCESSORS + bool + config SHARP_LOCOMO bool diff --git a/arch/arm/common/Makefile b/arch/arm/common/Makefile index 8c60f47..606131a 100644 --- a/arch/arm/common/Makefile +++ b/arch/arm/common/Makefile @@ -8,6 +8,7 @@ obj-$(CONFIG_ICST) += icst.o obj-$(CONFIG_SA1111) += sa1111.o obj-$(CONFIG_PCI_HOST_VIA82C505) += via82c505.o obj-$(CONFIG_DMABOUNCE) += dmabounce.o +obj-$(CONFIG_KRAIT_L2_ACCESSORS) += krait-l2-accessors.o obj-$(CONFIG_SHARP_LOCOMO) += locomo.o obj-$(CONFIG_SHARP_PARAM) += sharpsl_param.o obj-$(CONFIG_SHARP_SCOOP) += scoop.o diff --git a/arch/arm/common/krait-l2-accessors.c b/arch/arm/common/krait-l2-accessors.c new file mode 100644 index 0000000..c579794 --- /dev/null +++ b/arch/arm/common/krait-l2-accessors.c @@ -0,0 +1,52 @@ +/* + * Copyright (c) 2011-2013, The Linux Foundation. All rights reserved. + * + * This program is free software; you can redistribute it and/or modify + * it under the terms of the GNU General Public License version 2 and + * only version 2 as published by the Free Software Foundation. + * + * This program is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the + * GNU General Public License for more details. + */ + +#include <linux/spinlock.h> +#include <linux/export.h> + +#include <asm/barrier.h> +#include <asm/krait-l2-accessors.h> + +static DEFINE_RAW_SPINLOCK(krait_l2_lock); + +void set_l2_indirect_reg(u32 addr, u32 val) +{ + unsigned long flags; + + raw_spin_lock_irqsave(&krait_l2_lock, flags); + + asm volatile ("mcr p15, 3, %0, c15, c0, 6" : : "r" (addr)); + isb(); + asm volatile ("mcr p15, 3, %0, c15, c0, 7" : : "r" (val)); + isb(); + + raw_spin_unlock_irqrestore(&krait_l2_lock, flags); +} +EXPORT_SYMBOL(set_l2_indirect_reg); + +u32 get_l2_indirect_reg(u32 addr) +{ + u32 val; + unsigned long flags; + + raw_spin_lock_irqsave(&krait_l2_lock, flags); + + asm volatile ("mcr p15, 3, %0, c15, c0, 6" : : "r" (addr)); + isb(); + asm volatile ("mrc p15, 3, %0, c15, c0, 7" : "=r" (val)); + + raw_spin_unlock_irqrestore(&krait_l2_lock, flags); + + return val; +} +EXPORT_SYMBOL(get_l2_indirect_reg); diff --git a/arch/arm/include/asm/krait-l2-accessors.h b/arch/arm/include/asm/krait-l2-accessors.h new file mode 100644 index 0000000..d5305c4 --- /dev/null +++ b/arch/arm/include/asm/krait-l2-accessors.h @@ -0,0 +1,20 @@ +/* + * Copyright (c) 2011-2013, The Linux Foundation. All rights reserved. + * + * This program is free software; you can redistribute it and/or modify + * it under the terms of the GNU General Public License version 2 and + * only version 2 as published by the Free Software Foundation. + * + * This program is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the + * GNU General Public License for more details. + */ + +#ifndef __ASMARM_KRAIT_L2_ACCESSORS_H +#define __ASMARM_KRAIT_L2_ACCESSORS_H + +extern void set_l2_indirect_reg(u32 addr, u32 val); +extern u32 get_l2_indirect_reg(u32 addr); + +#endif -- The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, hosted by The Linux Foundation
next prev parent reply other threads:[~2013-10-29 0:31 UTC|newest] Thread overview: 61+ messages / expand[flat|nested] mbox.gz Atom feed top 2013-10-29 0:31 [PATCH 0/6] Krait L1/L2 EDAC driver Stephen Boyd 2013-10-29 0:31 ` Stephen Boyd 2013-10-29 0:31 ` [PATCH 1/6] edac: Don't try to cancel workqueue when it's never setup Stephen Boyd 2013-10-29 0:31 ` Stephen Boyd 2013-10-29 20:48 ` Borislav Petkov 2013-10-29 20:48 ` Borislav Petkov 2013-10-29 20:51 ` Stephen Boyd 2013-10-29 20:51 ` Stephen Boyd 2013-10-29 0:31 ` [PATCH 2/6] genirq: export percpu irq functions for module usage Stephen Boyd 2013-10-29 0:31 ` Stephen Boyd 2013-10-29 12:54 ` Thomas Gleixner 2013-10-29 12:54 ` Thomas Gleixner 2013-10-29 0:31 ` Stephen Boyd [this message] 2013-10-29 0:31 ` [PATCH 3/6] ARM: Add Krait L2 accessor functions Stephen Boyd 2013-10-29 1:19 ` Mark Rutland 2013-10-29 1:19 ` Mark Rutland 2013-10-29 1:19 ` Mark Rutland 2013-10-29 1:21 ` Stephen Boyd 2013-10-29 1:21 ` Stephen Boyd 2013-10-29 1:21 ` Stephen Boyd 2013-10-29 1:32 ` Mark Rutland 2013-10-29 1:32 ` Mark Rutland 2013-10-29 1:32 ` Mark Rutland 2013-10-29 5:05 ` Stephen Boyd 2013-10-29 5:05 ` Stephen Boyd 2013-10-29 5:05 ` Stephen Boyd 2013-10-29 0:31 ` [PATCH 4/6] edac: Document Krait L1/L2 EDAC driver binding Stephen Boyd 2013-10-29 0:31 ` Stephen Boyd 2013-10-29 0:31 ` Stephen Boyd 2013-10-29 1:34 ` Mark Rutland 2013-10-29 1:34 ` Mark Rutland 2013-10-29 1:34 ` Mark Rutland 2013-10-29 5:06 ` Stephen Boyd 2013-10-29 5:06 ` Stephen Boyd 2013-10-29 5:06 ` Stephen Boyd 2013-10-30 0:34 ` Mark Rutland 2013-10-30 0:34 ` Mark Rutland 2013-10-30 0:34 ` Mark Rutland [not found] ` <1383006690-6754-5-git-send-email-sboyd-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org> 2013-10-29 8:21 ` Kumar Gala 2013-10-29 8:21 ` Kumar Gala 2013-10-29 8:21 ` Kumar Gala 2013-10-29 18:00 ` Stephen Boyd 2013-10-29 18:00 ` Stephen Boyd 2013-10-29 20:22 ` Olof Johansson 2013-10-29 20:22 ` Olof Johansson 2013-10-29 20:22 ` Olof Johansson 2013-10-30 0:07 ` Stephen Boyd 2013-10-30 0:07 ` Stephen Boyd 2013-10-30 0:38 ` Mark Rutland 2013-10-30 0:38 ` Mark Rutland 2013-10-30 0:38 ` Mark Rutland 2013-10-30 7:19 ` Kumar Gala 2013-10-30 7:19 ` Kumar Gala 2013-10-30 7:19 ` Kumar Gala 2013-10-29 0:31 ` [PATCH 5/6] edac: Add support for Krait CPU cache error detection Stephen Boyd 2013-10-29 0:31 ` Stephen Boyd 2013-10-29 1:28 ` Mark Rutland 2013-10-29 1:28 ` Mark Rutland 2013-10-29 1:28 ` Mark Rutland 2013-10-29 0:31 ` [PATCH 6/6] ARM: dts: msm: Add Krait edac node Stephen Boyd 2013-10-29 0:31 ` Stephen Boyd
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=1383006690-6754-4-git-send-email-sboyd@codeaurora.org \ --to=sboyd@codeaurora.org \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-arm-msm@vger.kernel.org \ --cc=linux-edac@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux@arm.linux.org.uk \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.