All of lore.kernel.org
 help / color / mirror / Atom feed
From: Chanwoo Choi <cw00.choi@samsung.com>
To: kgene.kim@samsung.com, t.figa@samsung.com
Cc: linux-kernel@vger.kernel.org, linux@arm.linux.org.uk,
	ben-linux@fluff.org, arnd@arndb.de, olof@lixom.net,
	marc.zyngier@arm.com, thomas.abraham@linaro.org,
	kyungmin.park@samsung.com, cw00.choi@samsung.com,
	inki.dae@samsung.com, sw0312.kim@samsung.com,
	hyunhee.kim@samsung.com, yj44.cho@samsung.com,
	chanho61.park@samsung.com, sajjan.linux@gmail.com,
	tushar.behera@linaro.org, sachin.kamat@linaro.org,
	linux-samsung-soc@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org
Subject: [PATCHv4 2/7] ARM: EXYNOS: Support secondary CPU boot of Exynos4212
Date: Fri, 25 Apr 2014 10:16:07 +0900	[thread overview]
Message-ID: <1398388572-30239-3-git-send-email-cw00.choi@samsung.com> (raw)
In-Reply-To: <1398388572-30239-1-git-send-email-cw00.choi@samsung.com>

From: Kyungmin Park <kyungmin.park@samsung.com>

This patch fix the offset of CPU boot address and change parameter of smc call
of SMC_CMD_CPU1BOOT command for Exynos4212.

Signed-off-by: Kyungmin Park <kyungmin.park@samsung.com>
Signed-off-by: Chanwoo Choi <cw00.choi@samsung.com>
---
 arch/arm/mach-exynos/firmware.c | 15 ++++++++++++++-
 1 file changed, 14 insertions(+), 1 deletion(-)

diff --git a/arch/arm/mach-exynos/firmware.c b/arch/arm/mach-exynos/firmware.c
index 932129e..aa01c42 100644
--- a/arch/arm/mach-exynos/firmware.c
+++ b/arch/arm/mach-exynos/firmware.c
@@ -18,6 +18,8 @@
 
 #include <mach/map.h>
 
+#include <plat/cpu.h>
+
 #include "smc.h"
 
 static int exynos_do_idle(void)
@@ -28,13 +30,24 @@ static int exynos_do_idle(void)
 
 static int exynos_cpu_boot(int cpu)
 {
+	/*
+	 * The second parameter of SMC_CMD_CPU1BOOT command means CPU id.
+	 * But, Exynos4212 has only one secondary CPU so second parameter
+	 * isn't used for informing secure firmware about CPU id.
+	 */
+	if (soc_is_exynos4212())
+		cpu = 0;
+
 	exynos_smc(SMC_CMD_CPU1BOOT, cpu, 0, 0);
 	return 0;
 }
 
 static int exynos_set_cpu_boot_addr(int cpu, unsigned long boot_addr)
 {
-	void __iomem *boot_reg = S5P_VA_SYSRAM_NS + 0x1c + 4*cpu;
+	void __iomem *boot_reg = S5P_VA_SYSRAM_NS + 0x1c;
+
+	if (!soc_is_exynos4212())
+		boot_reg += 4*cpu;
 
 	__raw_writel(boot_addr, boot_reg);
 	return 0;
-- 
1.8.0


WARNING: multiple messages have this Message-ID (diff)
From: cw00.choi@samsung.com (Chanwoo Choi)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCHv4 2/7] ARM: EXYNOS: Support secondary CPU boot of Exynos4212
Date: Fri, 25 Apr 2014 10:16:07 +0900	[thread overview]
Message-ID: <1398388572-30239-3-git-send-email-cw00.choi@samsung.com> (raw)
In-Reply-To: <1398388572-30239-1-git-send-email-cw00.choi@samsung.com>

From: Kyungmin Park <kyungmin.park@samsung.com>

This patch fix the offset of CPU boot address and change parameter of smc call
of SMC_CMD_CPU1BOOT command for Exynos4212.

Signed-off-by: Kyungmin Park <kyungmin.park@samsung.com>
Signed-off-by: Chanwoo Choi <cw00.choi@samsung.com>
---
 arch/arm/mach-exynos/firmware.c | 15 ++++++++++++++-
 1 file changed, 14 insertions(+), 1 deletion(-)

diff --git a/arch/arm/mach-exynos/firmware.c b/arch/arm/mach-exynos/firmware.c
index 932129e..aa01c42 100644
--- a/arch/arm/mach-exynos/firmware.c
+++ b/arch/arm/mach-exynos/firmware.c
@@ -18,6 +18,8 @@
 
 #include <mach/map.h>
 
+#include <plat/cpu.h>
+
 #include "smc.h"
 
 static int exynos_do_idle(void)
@@ -28,13 +30,24 @@ static int exynos_do_idle(void)
 
 static int exynos_cpu_boot(int cpu)
 {
+	/*
+	 * The second parameter of SMC_CMD_CPU1BOOT command means CPU id.
+	 * But, Exynos4212 has only one secondary CPU so second parameter
+	 * isn't used for informing secure firmware about CPU id.
+	 */
+	if (soc_is_exynos4212())
+		cpu = 0;
+
 	exynos_smc(SMC_CMD_CPU1BOOT, cpu, 0, 0);
 	return 0;
 }
 
 static int exynos_set_cpu_boot_addr(int cpu, unsigned long boot_addr)
 {
-	void __iomem *boot_reg = S5P_VA_SYSRAM_NS + 0x1c + 4*cpu;
+	void __iomem *boot_reg = S5P_VA_SYSRAM_NS + 0x1c;
+
+	if (!soc_is_exynos4212())
+		boot_reg += 4*cpu;
 
 	__raw_writel(boot_addr, boot_reg);
 	return 0;
-- 
1.8.0

  parent reply	other threads:[~2014-04-25  1:17 UTC|newest]

Thread overview: 80+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-04-25  1:16 [PATCHv4 0/7] Support new Exynos3250 SoC based on Cortex-A7 dual core Chanwoo Choi
2014-04-25  1:16 ` Chanwoo Choi
2014-04-25  1:16 ` [PATCHv4 1/7] ARM: EXYNOS: Add Exynos3250 SoC ID Chanwoo Choi
2014-04-25  1:16   ` Chanwoo Choi
2014-04-25  1:16   ` Chanwoo Choi
2014-04-26  0:40   ` Tomasz Figa
2014-04-26  0:40     ` Tomasz Figa
2014-04-25  1:16 ` Chanwoo Choi [this message]
2014-04-25  1:16   ` [PATCHv4 2/7] ARM: EXYNOS: Support secondary CPU boot of Exynos4212 Chanwoo Choi
2014-04-26  0:42   ` Tomasz Figa
2014-04-26  0:42     ` Tomasz Figa
2014-04-26 10:49     ` Kukjin Kim
2014-04-26 10:49       ` Kukjin Kim
2014-04-26 10:49       ` Kukjin Kim
2014-04-25  1:16 ` [PATCHv4 3/7] ARM: EXYNOS: Support secondary CPU boot of Exynos3250 Chanwoo Choi
2014-04-25  1:16   ` Chanwoo Choi
2014-04-25  4:30   ` Tushar Behera
2014-04-25  4:30     ` Tushar Behera
2014-04-25  5:43     ` Chanwoo Choi
2014-04-25  5:43       ` Chanwoo Choi
2014-04-25  5:54       ` Tushar Behera
2014-04-25  5:54         ` Tushar Behera
2014-04-25  5:56         ` Chanwoo Choi
2014-04-25  5:56           ` Chanwoo Choi
2014-04-25  1:16 ` [PATCHv4 4/7] ARM: EXYNOS: Enter a15 lowpower mode for Exynos3250 based on Cortex-a7 Chanwoo Choi
2014-04-25  1:16   ` Chanwoo Choi
2014-04-25  1:16   ` Chanwoo Choi
2014-04-26  0:25   ` Tomasz Figa
2014-04-26  0:25     ` Tomasz Figa
2014-04-26  0:25     ` Tomasz Figa
2014-04-26  0:30     ` Russell King - ARM Linux
2014-04-26  0:30       ` Russell King - ARM Linux
2014-04-30  8:00     ` Chanwoo Choi
2014-04-30  8:00       ` Chanwoo Choi
2014-04-25  1:16 ` [PATCHv4 5/7] clk: samsung: exynos3250: Add clocks using common clock framework Chanwoo Choi
2014-04-25  1:16   ` Chanwoo Choi
2014-04-25  1:16   ` Chanwoo Choi
2014-04-26  0:39   ` Tomasz Figa
2014-04-26  0:39     ` Tomasz Figa
2014-04-26  0:39     ` Tomasz Figa
2014-05-13 11:49     ` Chanwoo Choi
2014-05-13 11:49       ` Chanwoo Choi
2014-05-13 16:28       ` Tomasz Figa
2014-05-13 16:28         ` Tomasz Figa
2014-05-13 16:28         ` Tomasz Figa
2014-05-14  6:57         ` Chanwoo Choi
2014-05-14  6:57           ` Chanwoo Choi
2014-05-14  6:57           ` Chanwoo Choi
2014-05-14 13:45           ` Tomasz Figa
2014-05-14 13:45             ` Tomasz Figa
2014-05-14 13:45             ` Tomasz Figa
2014-04-25  1:16 ` [PATCHv4 6/7] dt-bindings: add documentation for Exynos3250 clock controller Chanwoo Choi
2014-04-25  1:16   ` Chanwoo Choi
2014-04-25  1:16   ` Chanwoo Choi
2014-04-25  1:16 ` [PATCHv4 7/7] ARM: dts: Add device tree sources for Exynos3250 Chanwoo Choi
2014-04-25  1:16   ` Chanwoo Choi
2014-04-25  4:38   ` Tushar Behera
2014-04-25  4:38     ` Tushar Behera
2014-04-25  5:03     ` Chanwoo Choi
2014-04-25  5:03       ` Chanwoo Choi
2014-04-26  0:51   ` Tomasz Figa
2014-04-26  0:51     ` Tomasz Figa
2014-04-26 11:38     ` Tomasz Figa
2014-04-26 11:38       ` Tomasz Figa
2014-04-26 11:38       ` Tomasz Figa
2014-05-09  6:49       ` Chanwoo Choi
2014-05-09  6:49         ` Chanwoo Choi
2014-05-09  8:01         ` Tomasz Figa
2014-05-09  8:01           ` Tomasz Figa
2014-05-09  8:15           ` Chanwoo Choi
2014-05-09  8:15             ` Chanwoo Choi
2014-05-09  1:06     ` Chanwoo Choi
2014-05-09  1:06       ` Chanwoo Choi
2014-05-09  5:02       ` Tomasz Figa
2014-05-09  5:02         ` Tomasz Figa
2014-05-09  7:10         ` Chanwoo Choi
2014-05-09  7:10           ` Chanwoo Choi
2014-05-09  8:01           ` Tomasz Figa
2014-05-09  8:01             ` Tomasz Figa
2014-05-09  8:01             ` Tomasz Figa

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1398388572-30239-3-git-send-email-cw00.choi@samsung.com \
    --to=cw00.choi@samsung.com \
    --cc=arnd@arndb.de \
    --cc=ben-linux@fluff.org \
    --cc=chanho61.park@samsung.com \
    --cc=devicetree@vger.kernel.org \
    --cc=hyunhee.kim@samsung.com \
    --cc=inki.dae@samsung.com \
    --cc=kgene.kim@samsung.com \
    --cc=kyungmin.park@samsung.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-samsung-soc@vger.kernel.org \
    --cc=linux@arm.linux.org.uk \
    --cc=marc.zyngier@arm.com \
    --cc=olof@lixom.net \
    --cc=sachin.kamat@linaro.org \
    --cc=sajjan.linux@gmail.com \
    --cc=sw0312.kim@samsung.com \
    --cc=t.figa@samsung.com \
    --cc=thomas.abraham@linaro.org \
    --cc=tushar.behera@linaro.org \
    --cc=yj44.cho@samsung.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.