From: Zach Brown <zab@zabbo.net>
To: linux-btrfs@vger.kernel.org, David Sterba <dsterba@suse.cz>
Subject: [PATCH 3/4] btrfs-progs: fix show super unknown flag output
Date: Wed, 15 Oct 2014 16:14:20 -0700 [thread overview]
Message-ID: <1413414861-28097-4-git-send-email-zab@zabbo.net> (raw)
In-Reply-To: <1413414861-28097-1-git-send-email-zab@zabbo.net>
coverity pointed out that unknown flag printing in show super had some
dead code. It turns out that first was reset when the first flag was
tested, not when it was output. We only want to clear it if the first
matching bit is output. If there are no matching bits then we'll want
to output the unknown flag first.
Signed-off-by: Zach Brown <zab@zabbo.net>
---
btrfs-show-super.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/btrfs-show-super.c b/btrfs-show-super.c
index 456dbd8..2b48f44 100644
--- a/btrfs-show-super.c
+++ b/btrfs-show-super.c
@@ -324,8 +324,8 @@ static void print_readable_incompat_flag(u64 flag)
printf("%s ", entry->output);
else
printf("|\n\t\t\t %s ", entry->output);
+ first = 0;
}
- first = 0;
}
flag &= ~BTRFS_FEATURE_INCOMPAT_SUPP;
if (flag) {
--
1.9.3
next prev parent reply other threads:[~2014-10-15 23:14 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-15 23:14 [PATCH 0/4] some btrfs-progs coverity fixes Zach Brown
2014-10-15 23:14 ` [PATCH 1/4] btrfs-progs: check sscanf return code Zach Brown
2014-10-15 23:14 ` [PATCH 2/4] btrfs-progs: check read extent errors when mapping Zach Brown
2014-10-15 23:14 ` Zach Brown [this message]
2014-10-15 23:14 ` [PATCH 4/4] btrfs-progs: fix csum root copy-n-paste error Zach Brown
2014-10-16 10:55 ` David Sterba
2014-10-16 11:46 ` [PATCH 0/4] some btrfs-progs coverity fixes David Sterba
2014-10-16 13:33 ` Eric Sandeen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1413414861-28097-4-git-send-email-zab@zabbo.net \
--to=zab@zabbo.net \
--cc=dsterba@suse.cz \
--cc=linux-btrfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.