All of lore.kernel.org
 help / color / mirror / Atom feed
From: Hans de Goede <hdegoede@redhat.com>
To: Darren Hart <dvhart@infradead.org>,
	"Rafael J. Wysocki" <rjw@rjwysocki.net>
Cc: "Ben Skeggs" <bskeggs@redhat.com>,
	"Azael Avalos" <coproscefalo@gmail.com>,
	"Corentin Chary" <corentin.chary@gmail.com>,
	"Lee Chun-Yi" <jlee@suse.com>,
	"Cezary Jackiewicz" <cezary.jackiewicz@gmail.com>,
	"Matthew Garrett" <mjg59@srcf.ucam.org>,
	"Pali Rohár" <pali.rohar@gmail.com>,
	"Ike Panhc" <ike.pan@canonical.com>,
	"Anisse Astier" <anisse@astier.eu>,
	"Mattia Dongili" <malattia@linux.it>,
	"Henrique de Moraes Holschuh" <ibm-acpi@hmh.eng.br>,
	platform-driver-x86@vger.kernel.org,
	ibm-acpi-devel@lists.sourceforge.net,
	acpi4asus-user@lists.sourceforge.net,
	dri-devel@lists.freedesktop.org, "Aaron Lu" <aaron.lu@intel.com>,
	linux-acpi@vger.kernel.org, "Hans de Goede" <hdegoede@redhat.com>
Subject: [PATCH v2 09/32] drm: i915: Port to new backlight interface selection API
Date: Fri, 12 Jun 2015 13:23:28 +0200	[thread overview]
Message-ID: <1434108231-12323-10-git-send-email-hdegoede@redhat.com> (raw)
In-Reply-To: <1434108231-12323-1-git-send-email-hdegoede@redhat.com>

This results in a nice cleanup, as we can replace the complicated logic
from should_ignore_backlight_request() with a simple check for the type
being native.

Signed-off-by: Hans de Goede <hdegoede@redhat.com>
---
 drivers/gpu/drm/i915/intel_opregion.c | 12 +-----------
 1 file changed, 1 insertion(+), 11 deletions(-)

diff --git a/drivers/gpu/drm/i915/intel_opregion.c b/drivers/gpu/drm/i915/intel_opregion.c
index 71e87ab..4813374 100644
--- a/drivers/gpu/drm/i915/intel_opregion.c
+++ b/drivers/gpu/drm/i915/intel_opregion.c
@@ -396,16 +396,6 @@ int intel_opregion_notify_adapter(struct drm_device *dev, pci_power_t state)
 	return -EINVAL;
 }
 
-/*
- * If the vendor backlight interface is not in use and ACPI backlight interface
- * is broken, do not bother processing backlight change requests from firmware.
- */
-static bool should_ignore_backlight_request(void)
-{
-	return acpi_video_backlight_support() &&
-	       !acpi_video_verify_backlight_support();
-}
-
 static u32 asle_set_backlight(struct drm_device *dev, u32 bclp)
 {
 	struct drm_i915_private *dev_priv = dev->dev_private;
@@ -414,7 +404,7 @@ static u32 asle_set_backlight(struct drm_device *dev, u32 bclp)
 
 	DRM_DEBUG_DRIVER("bclp = 0x%08x\n", bclp);
 
-	if (should_ignore_backlight_request()) {
+	if (acpi_video_get_backlight_type() == acpi_backlight_native) {
 		DRM_DEBUG_KMS("opregion backlight request ignored\n");
 		return 0;
 	}
-- 
2.4.2


  parent reply	other threads:[~2015-06-12 11:24 UTC|newest]

Thread overview: 39+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-06-12 11:23 [PATCH v2 00/32] acpi-video: Rewrite backlight interface selection logic Hans de Goede
2015-06-12 11:23 ` [PATCH v2 01/32] apple-gmux: Stop using acpi_video_dmi_demote_vendor() Hans de Goede
2015-06-12 11:23 ` [PATCH v2 02/32] acpi-video-detect: Remove the unused acpi_video_dmi_demote_vendor() function Hans de Goede
2015-06-12 11:23 ` [PATCH v2 03/32] acpi-video-detect: Make acpi_video_get_capabilities a private function Hans de Goede
2015-06-12 11:23 ` [PATCH v2 04/32] acpi-video-detect: Move acpi_is_video_device() to acpi/scan.c Hans de Goede
2015-06-12 11:23 ` [PATCH v2 05/32] acpi-video-detect: Move acpi_osi_is_win8 to osl.c Hans de Goede
2015-06-12 11:23 ` [PATCH v2 06/32] acpi-video-detect: video: Make video_detect code part of the video module Hans de Goede
2015-06-12 11:23 ` [PATCH v2 07/32] acpi-video-detect: Rewrite backlight interface selection logic Hans de Goede
2015-06-12 11:23 ` [PATCH v2 08/32] acpi-video-detect: Unregister acpi_video backlight when dmi quirks are added Hans de Goede
2015-06-12 11:23 ` Hans de Goede [this message]
2015-06-12 11:23 ` [PATCH v2 10/32] acpi-video: Port to new backlight interface selection API Hans de Goede
2015-06-12 11:23 ` [PATCH v2 11/32] acpi-video: Move backlight notifier to video_detect.c Hans de Goede
2015-06-12 11:23 ` [PATCH v2 12/32] acpi-video: Move dmi_check_system from module_init to acpi_video_register Hans de Goede
2015-06-12 11:23 ` [PATCH v2 13/32] acpi-video: Fix acpi_video _register vs _unregister_backlight race Hans de Goede
2015-06-12 11:23 ` [PATCH v2 14/32] acer-wmi: Port to new backlight interface selection API Hans de Goede
2015-06-12 11:23 ` [PATCH v2 15/32] apple-gmux: " Hans de Goede
2015-06-12 11:23 ` [PATCH v2 16/32] asus-laptop: " Hans de Goede
2015-06-12 11:23 ` [PATCH v2 17/32] asus-wmi: " Hans de Goede
2015-06-12 11:23 ` [PATCH v2 18/32] compal-laptop: " Hans de Goede
2015-06-12 11:23 ` [PATCH v2 19/32] dell-laptop: " Hans de Goede
2015-06-12 11:23 ` [PATCH v2 20/32] dell-wmi: " Hans de Goede
2015-06-12 11:23 ` [PATCH v2 21/32] eeepc-laptop: " Hans de Goede
2015-06-12 11:23 ` [PATCH v2 22/32] fujitsu-laptop: " Hans de Goede
2015-06-12 11:23 ` [PATCH v2 23/32] ideapad-laptop: " Hans de Goede
2015-06-12 11:23 ` [PATCH v2 24/32] intel-oaktrail: " Hans de Goede
2015-06-12 11:23 ` [PATCH v2 25/32] msi-laptop: " Hans de Goede
2015-06-12 11:23 ` [PATCH v2 26/32] msi-wmi: " Hans de Goede
2015-06-12 11:23 ` [PATCH v2 27/32] samsung-laptop: " Hans de Goede
2015-06-12 11:23 ` [PATCH v2 28/32] sony-laptop: " Hans de Goede
2015-06-12 11:23 ` [PATCH v2 29/32] thinkpad-acpi: " Hans de Goede
2015-06-12 11:23 ` [PATCH v2 30/32] toshiba-acpi: " Hans de Goede
2015-06-14  3:15   ` Azael Avalos
2015-06-16 12:53     ` Hans de Goede
2015-06-12 11:23 ` [PATCH v2 31/32] acpi-video-detect: Remove old API Hans de Goede
2015-06-12 11:23 ` [PATCH v2 32/32] acpi-video: Make acpi_video_unregister_backlight() private Hans de Goede
2015-06-15 23:22 ` [PATCH v2 00/32] acpi-video: Rewrite backlight interface selection logic Rafael J. Wysocki
2015-06-17  3:39   ` Darren Hart
2015-06-17  9:36     ` Rafael J. Wysocki
2015-06-18 21:05       ` Darren Hart

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1434108231-12323-10-git-send-email-hdegoede@redhat.com \
    --to=hdegoede@redhat.com \
    --cc=aaron.lu@intel.com \
    --cc=acpi4asus-user@lists.sourceforge.net \
    --cc=anisse@astier.eu \
    --cc=bskeggs@redhat.com \
    --cc=cezary.jackiewicz@gmail.com \
    --cc=coproscefalo@gmail.com \
    --cc=corentin.chary@gmail.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=dvhart@infradead.org \
    --cc=ibm-acpi-devel@lists.sourceforge.net \
    --cc=ibm-acpi@hmh.eng.br \
    --cc=ike.pan@canonical.com \
    --cc=jlee@suse.com \
    --cc=linux-acpi@vger.kernel.org \
    --cc=malattia@linux.it \
    --cc=mjg59@srcf.ucam.org \
    --cc=pali.rohar@gmail.com \
    --cc=platform-driver-x86@vger.kernel.org \
    --cc=rjw@rjwysocki.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.