All of lore.kernel.org
 help / color / mirror / Atom feed
From: Paulo Zanoni <przanoni@gmail.com>
To: intel-gfx@lists.freedesktop.org
Cc: Paulo Zanoni <paulo.r.zanoni@intel.com>
Subject: [PATCH 6/8] drm/i915: intel_unregister_dsm_handler() doesn't need struct_mutex
Date: Thu,  2 Jul 2015 19:25:12 -0300	[thread overview]
Message-ID: <1435875914-11516-7-git-send-email-przanoni@gmail.com> (raw)
In-Reply-To: <1435875914-11516-1-git-send-email-przanoni@gmail.com>

From: Paulo Zanoni <paulo.r.zanoni@intel.com>

So don't grab the lock before calling the function.

Reviewed-by: Chris wilson <chris@chris-wilson.co.uk>
Signed-off-by: Paulo Zanoni <paulo.r.zanoni@intel.com>
---
 drivers/gpu/drm/i915/intel_display.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/drivers/gpu/drm/i915/intel_display.c b/drivers/gpu/drm/i915/intel_display.c
index 219e4c5..01d7cff 100644
--- a/drivers/gpu/drm/i915/intel_display.c
+++ b/drivers/gpu/drm/i915/intel_display.c
@@ -15603,12 +15603,10 @@ void intel_modeset_cleanup(struct drm_device *dev)
 	 */
 	drm_kms_helper_poll_fini(dev);
 
-	mutex_lock(&dev->struct_mutex);
-
 	intel_unregister_dsm_handler();
 
+	mutex_lock(&dev->struct_mutex);
 	intel_fbc_disable(dev);
-
 	mutex_unlock(&dev->struct_mutex);
 
 	/* flush any delayed tasks or pending work */
-- 
2.1.4

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx

  parent reply	other threads:[~2015-07-02 22:26 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-07-02 22:25 [PATCH 0/8] FBC (+stolen) locking, v5 Paulo Zanoni
2015-07-02 22:25 ` [PATCH 1/8] drm/i915: add simple wrappers for stolen node insertion/removal Paulo Zanoni
2015-07-03 16:01   ` Chris Wilson
2015-07-02 22:25 ` [PATCH 2/8] drm/i915: move FBC code out of i915_gem_stolen.c Paulo Zanoni
2015-07-03 16:01   ` Chris Wilson
2015-07-02 22:25 ` [PATCH 3/8] drm/i915: add dev_priv->mm.stolen_lock Paulo Zanoni
2015-07-03 16:00   ` Chris Wilson
2015-07-02 22:25 ` [PATCH 4/8] drm/i915: add the FBC mutex Paulo Zanoni
2015-07-02 22:25 ` [PATCH 5/8] drm/i915: intel_frontbuffer_flip_prepare() doesn't need struct_mutex Paulo Zanoni
2015-07-02 22:25 ` Paulo Zanoni [this message]
2015-07-02 22:25 ` [PATCH 7/8] drm/i915: FBC doesn't need struct_mutex anymore Paulo Zanoni
2015-07-02 22:25 ` [PATCH 8/8] drm/i915: protect FBC functions with HAS_FBC checks Paulo Zanoni
2015-07-03 15:56   ` Chris Wilson
2015-07-03 16:03     ` Chris Wilson
2015-07-03 17:59     ` Paulo Zanoni
2015-07-03 18:23       ` Chris Wilson
2015-07-03 18:40         ` [PATCH 8/8] drm/i915: protect FBC functions with FBC checks Paulo Zanoni
2015-07-03 18:50           ` Chris Wilson
2015-07-06 12:34             ` Daniel Vetter

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1435875914-11516-7-git-send-email-przanoni@gmail.com \
    --to=przanoni@gmail.com \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=paulo.r.zanoni@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.